On Sat, Oct 19, 2013 at 2:39 PM, Dan Carpenter wrote:
> Your patch is great, but actually, are any of the functions in this
> header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows
> this header file.
>
> Perhaps we can delete the whole thing?
>
> regards,
> dan carpenter
Ah, good
On Wed, Oct 16, 2013 at 11:31:07AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Oct 16, 2013 at 07:07:35PM +0100, Russell King - ARM Linux wrote:
> > Sorry, but I don't think imx-drm is driving the hardware correctly, and
> > I know that Greg wants it moved out of drivers/staging, but frankly it
> >
On 18/10/13 19:24, Hartley Sweeten wrote:
On Friday, October 18, 2013 6:41 AM, Ian Abbott wrote:
Use the new macros defined in "s626.h" for constructing and decomposing
'CRA', 'CRB' and standardized encoder setup values to make the
conversions between standardized encoder setup values, and CRA/C
On 19/10/13 21:48, Greg Kroah-Hartman wrote:
On Fri, Oct 18, 2013 at 02:40:48PM +0100, Ian Abbott wrote:
Tidy up the "s626" driver a bit more. In particular, the handling of
encoder setup values is a bit hard to follow with lots of bit-shifting
and masking, particularly when converting between
On 18/10/13 18:24, Hartley Sweeten wrote:
On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote:
Sample values in comedi are generally represented as unsigned values.
Change the `ao_data[]` and `dmabuf_virt[]` members of `struct
pci9118_private` and various local variables dealing with sample
On 18/10/13 18:00, Hartley Sweeten wrote:
On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote:
Sample values in comedi are generally represented as unsigned values.
Change the `ao_data[]` and `dmabuf_virt[]` members of `struct
pci9118_private` and various local variables dealing with sample
Your patch is great, but actually, are any of the functions in this
header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows
this header file.
Perhaps we can delete the whole thing?
regards,
dan carpenter
___
devel mailing list
de...@linu
Fix cfs_bitmap struct, function parameters, and variable
declarations to resolve the "Do not add new typedefs"
warning generated by checkpatch.pl in bitmap.h and meet
kernel coding style.
Signed-off-by: Lisa Nguyen
---
Changes since v3:
- Combining the previous two patch versions into one!
...
Never mind. I figured out the answer from the rest of the patches.
Looks good.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, Oct 19, 2013 at 01:02:25AM +0300, Eli Billauer wrote:
> This is necessary so that xillybus_core uses the correct device pointer
> for PCIe devices in diagnostic message calls (dev_err, dev_warn and dev_info)
>
The changelog is unclear what happens in the current code. Does it use
a diffe
On Sat, Oct 19, 2013 at 02:06:42PM -0700, Lisa Nguyen wrote:
> Fix cfs_bitmap struct, function parameters, and variable
> declarations to eliminate the "Do not add new typedefs"
> warning generated by checkpatch.pl and meet kernel coding
> style.
>
> Signed-off-by: Lisa Nguyen
> ---
>
> Changes
Fix cfs_bitmap struct, function parameters, and variable
declarations to eliminate the "Do not add new typedefs"
warning generated by checkpatch.pl and meet kernel coding
style.
Signed-off-by: Lisa Nguyen
---
Changes since v2:
- Original patch had struct cfs_bitmap_t. Struct is renamed to
cfs_bi
On Sat, Oct 19, 2013 at 10:01:42PM +0530, Rashika Kheria wrote:
> This patch fixes the following Smatch warning in zram_drv.c-
> ~/git/kernels/linux/drivers/staging/zram/zram_drv.c:663
> reset_store() warn: variable dereferenced before check 'bdev' (see line 652)
> ~/git/kernels/linux/drivers/stagi
On Fri, Oct 18, 2013 at 02:40:48PM +0100, Ian Abbott wrote:
> Tidy up the "s626" driver a bit more. In particular, the handling of
> encoder setup values is a bit hard to follow with lots of bit-shifting
> and masking, particularly when converting between the "standardized"
> setup values and the
On Sat, Oct 19, 2013 at 01:02:25AM +0300, Eli Billauer wrote:
> This is necessary so that xillybus_core uses the correct device pointer
> for PCIe devices in diagnostic message calls (dev_err, dev_warn and dev_info)
>
> Signed-off-by: Eli Billauer
Nice job with these patches, thanks for doing th
On Sat, Oct 19, 2013 at 08:28:21AM -0700, Lisa Nguyen wrote:
> Fix cfs_bitmap_t struct and function parameters to eliminate the
> "Do not add new typedefs" warning generated by checkpatch.pl and
> meet kernel coding style.
>
> Signed-off-by: Lisa Nguyen
> ---
> .../staging/lustre/include/linux/l
Fix cfs_bitmap_t struct and function parameters to eliminate the
"Do not add new typedefs" warning generated by checkpatch.pl and
meet kernel coding style.
Signed-off-by: Lisa Nguyen
---
.../staging/lustre/include/linux/libcfs/bitmap.h | 22 +++---
1 file changed, 11 insertions
Also increment the kernel module version number to match the
userspace version, as compatibility with old userspace utilities
is now at least partially broken.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/usbip_common.h | 2 +-
drivers/staging/usb
This patch extends the TLS support to cover all communication in
userspace. The TLS connection is released shortly before the socket is
passed to the kernel.
This requires for additional connection state to be passed between
functions. We thus replaced the sockfd by a struct containing the TLS
con
In preparation for the kernel crypto support, we exchange two - randomly
generated - session keys between usbip and usbipd to be used for
encrypting all traffic generated in kernelspace. We use two different
128-bit keys, one for sending and one for receiving. Both are generated
by the client (usbi
This patch adds the possibility to stored ACLs for allowed clients for
each stub device in sysfs. It adds a new sysfs entry called "usbip_acl"
for each stub device, containing a list of CIDR masks of allowed
clients. This file will be used by usbip and usbipd to store the ACL.
Signed-off-by: Kurt
This patch adds new error codes and features extended error reporting in
op_common packets.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 3 +-
.../staging/usbip/us
This extends the userspace code to write the generated session keys to
sysfs in hexadecimal encoding after establishing the connection.
The kernel code is modified to parse the session keys.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub_dev.c
Not all new program versions necessarily introduce
non-backwards-compatible protocol changes. We thus move the definition
of the protocol version from configure.ac to usbip_network.h, where it
logically belongs to.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/u
This adds code performing the actual encryption and authentication
operations in the usbip kernel code. The whole data stream may now be
encrypted and authenticated with AES-GCM and symmetric 128 bit keys.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/Kcon
From: Tobias Polzer
README was updated and cleaned. It now contains just one example, which
was updated to use encryption. Also, the new crypto behaviour is
documented. The usbip "port" command has been removed from the README,
as it isn't supported by newer userland versions. One dead link was
r
Interpret the ACLs stored in sysfs in usbipd and reject clients not
matching one of the ACLs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/Makefile.am | 2 +-
drivers/staging/usbip/userspace/src/usbipd.c|
This adds two simple wrappers around kernel_sendmsg() and
kernel_recvmsg() that can be extended to perform additional
cryptographic operations on the data before sending it.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub_rx.c | 2 +-
drivers/stag
usbip now prints an error message when started as user and requiring
root access. Also, some debug messages are changed to error messages so
the command line utilities now print less confusing (and more verbose)
error messages when not used correctly.
Signed-off-by: Dominik Paulus
Signed-off-by:
For IPv6, IP:Port is unreadable.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbipd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/src/usbipd.c
b/drivers/staging/usbip/userspace/src/us
Add the command line argument -a (--allow) to usbip bind to specify
networks allowed to attach to the device and code to store the ACLs in
sysfs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/doc/usbip.8 | 8
Hi,
sorry for the messed-up error checking. We fixed some of the style nitpicks and
hopefully all of the mistakes you pointed out (thank you for that!).
Regards,
Dominik and Tobias
___
devel mailing list
de...@linuxdriverproject.org
http://driv
This patch adds a few utility functions to match IP addresses against
CIDR masks.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/utils.c | 84 +
drivers/staging/usbip/userspace/src/utils.h | 15 ++
2 files chang
This patch adds support for authenticating both client and server using
a pre-shared passphrase using SRP (Secure Remote Password) over TLS (see
RFC 5054) using GnuTLS. Both usbip and usbipd now accept a shared secret
as a command line argument. Currently, the established TLS connection is
only use
On Fri, Oct 18, 2013 at 04:39:04PM -0500, Larry Finger wrote:
> The driver places a 254-byte buffer on the stack when writing long output.
> To reduce stack usage, a buffer of the required length is acquired using
> kmemdup().
>
The patch is badly whitespace dammaged.
regards,
dan carpenter
___
Dave,
# -EIO retuned corrupts XFS
I turned up
lockdep, frame pointer, xfs debug
and also changed to 3.12.0-rc5 from rc1.
What's changed is that
the problem we discussed in previous mails
*never* reproduce.
However, if I turn off the lockdep only
it hangs up by setting blockup to 1 and then to 0
36 matches
Mail list logo
