Re: lustre: why does cfs_get_random_bytes() exist?

2013-10-04 Thread Dilger, Andreas
On 2013/10/03 5:45 PM, "Theodore Ts'o" wrote: >On Thu, Oct 03, 2013 at 11:06:58PM +, Dilger, Andreas wrote: >> >> The Lustre cfs_get_random_bytes() incorporates (via cfs_rand()) a seed >> which also hashes in the addresses from any network interfaces that are >> configured. >> Conversely, cfs

RE: [PATCH 1/1] Drivers: scsi: Derive the FLUSH_TIMEOUT from the basic I/O timeout

2013-10-04 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Friday, October 04, 2013 3:31 PM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; h...@infradead.org; > e...@purestor

Re: [PATCH 1/1] Drivers: scsi: Derive the FLUSH_TIMEOUT from the basic I/O timeout

2013-10-04 Thread James Bottomley
On Fri, 2013-10-04 at 22:01 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:jbottom...@parallels.com] > > Sent: Friday, October 04, 2013 2:42 PM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > de...@linuxdri

RE: [PATCH 1/1] Drivers: scsi: Derive the FLUSH_TIMEOUT from the basic I/O timeout

2013-10-04 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Friday, October 04, 2013 2:42 PM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; h...@infradead.org; > e...@purestor

Re: [PATCH 1/1] Drivers: scsi: Derive the FLUSH_TIMEOUT from the basic I/O timeout

2013-10-04 Thread James Bottomley
On Fri, 2013-10-04 at 12:38 -0700, K. Y. Srinivasan wrote: > Rather than having a separate constant for specifying the timeout on FLUSH > operations, use the basic I/O timeout value that is already configurable > on a per target basis to derive the FLUSH timeout. Looking at the current > definition

[PATCH 1/1] Drivers: scsi: Derive the FLUSH_TIMEOUT from the basic I/O timeout

2013-10-04 Thread K. Y. Srinivasan
Rather than having a separate constant for specifying the timeout on FLUSH operations, use the basic I/O timeout value that is already configurable on a per target basis to derive the FLUSH timeout. Looking at the current definitions of these timeout values, the FLUSH operation is supposed to have

Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread Eric Seppanen
On Fri, Oct 4, 2013 at 5:18 AM, Ewan Milne wrote: > On Thu, 2013-10-03 at 13:48 -0700, Eric Seppanen wrote: >> Do I/O timeouts and flush timeouts need to be independently adjusted? >> If you're having trouble with slow operations, it seems likely to be >> across the board. >> >> Flush timeout coul

Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread James Bottomley
On Fri, 2013-10-04 at 15:02 +, KY Srinivasan wrote: > > > -Original Message- > > From: Eric Seppanen [mailto:e...@purestorage.com] > > Sent: Thursday, October 03, 2013 1:49 PM > > To: Nicholas A. Bellinger > > Cc: KY Srinivasan; linux-ker...@vger.kernel.org; > > de...@linuxdriverproje

[PATCH] staging: dgnc: changes arguments in sizeof

2013-10-04 Thread Lidza Louina
The arguments that were passed into sizeof were generic. This patch changes this by putting the actual item that we need a size of instead. For example: - kzalloc(sizeof(struct dgnc_board), GFP_KERNEL); + kzalloc(sizeof(*brd), GFP_KERNEL); Signed-off-by: Lidza Louina --- drivers/staging/dgn

Re: [dm-devel] dm-writeboost testing

2013-10-04 Thread Mikulas Patocka
On Fri, 4 Oct 2013, Akira Hayakawa wrote: > Mikulas, > > Thanks for your pointing out. > > > The problem is that you are using workqueues the wrong way. You submit a > > work item to a workqueue and the work item is active until the device is > > unloaded. > > > > If you submit a work item

Re: [dm-devel] dm-writeboost testing

2013-10-04 Thread Joe Thornber
On Thu, Oct 03, 2013 at 10:27:54PM +0900, Akira Hayakawa wrote: > > dm-cache doesn't have this problem, if you overwrite the same piece of > > data again and again, it goes to the cache device. > > It is not a bug but should/can be optimized. > > Below is the cache hit path for writes. > writeb

RE: Drivers: scsi: FLUSH timeout

2013-10-04 Thread KY Srinivasan
> -Original Message- > From: Eric Seppanen [mailto:e...@purestorage.com] > Sent: Thursday, October 03, 2013 1:49 PM > To: Nicholas A. Bellinger > Cc: KY Srinivasan; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > linux-s...@vger.kernel.org > Subject: Re: Drivers: scsi: FLUSH

Re: [dm-devel] dm-writeboost testing

2013-10-04 Thread Akira Hayakawa
Mikulas, Thanks for your pointing out. > The problem is that you are using workqueues the wrong way. You submit a > work item to a workqueue and the work item is active until the device is > unloaded. > > If you submit a work item to a workqueue, it is required that the work > item finishes i

Re: [dm-devel] dm-writeboost testing

2013-10-04 Thread Mikulas Patocka
On Fri, 4 Oct 2013, Akira Hayakawa wrote: > Hi, Mikulas, > > I am sorry to say that > I don't have such machines to reproduce the problem. > > But agree with that I am dealing with workqueue subsystem > in a little bit weird way. > I should clean them up. > > For example, > free_cache() routi

Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread Ewan Milne
On Thu, 2013-10-03 at 13:48 -0700, Eric Seppanen wrote: > On Thu, Oct 3, 2013 at 5:09 AM, Nicholas A. Bellinger > wrote: > > > > On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > > Ideally, I want this to be adjustable like the way we can change the I/O > > > timeout. > > > Since that h

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-10-04 Thread Dan Carpenter
On Thu, Oct 03, 2013 at 01:55:29AM +0200, Laurent Pinchart wrote: > + > + ret = vb2_streamon(&vfh->queue, type); > + if (ret < 0) > + goto err_iss_video_check_format; > + > + /* In sensor-to-memory mode, the stream can be started synchronously > + * to the stream on com

[PATCH] staging: xillybus: remove redundant Kconfig dependency

2013-10-04 Thread Baruch Siach
XILLYBUS_PCIE and XILLYBUS_OF are inside 'if XILLYBUS' already, so there is not need to depend on XILLYBUS. Cc: Eli Billauer Signed-off-by: Baruch Siach --- drivers/staging/xillybus/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xillybus/Kconfig