On 1 October 2013 07:18, Greg KH wrote:
> On Fri, Sep 27, 2013 at 09:36:28AM +0530, Sachin Kamat wrote:
>> Pointers should be assigned NULL instead of 0.
>>
>> Signed-off-by: Sachin Kamat
>> ---
>> Most of the patches in this series will give checkpatch errors related
>> to spacing and indentatio
This member of the private data is initialized to '0' during the
board reset then never changed. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 13 +
1 file changed, 5 insertions(+), 8 deletions
For aesthetics, move this function closer to it's only caller.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 66 +++
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/stag
To clarify the code a bit, introduce a helper function to set/clear
the GRP2WR bit in the CFG1 register. This bit selects which group of
registers are used for the registers that share the same I/O addresses.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/st
For aesthetics, rename this function to help with greps.
Tidy up this function to follow the normal format for analog
output read back functions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 12 +++-
1 file chan
Change the MODULE_DESCRIPTION to something useful instead of the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
Cleanup the multi-line comments to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 69 ---
1 file changed, 35 insertions(+), 34 deletions(-)
diff --git a/drivers/staging/
Rename the defines for the STATUS register so they have namespace
associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
On Fri, Sep 27, 2013 at 09:36:28AM +0530, Sachin Kamat wrote:
> Pointers should be assigned NULL instead of 0.
>
> Signed-off-by: Sachin Kamat
> ---
> Most of the patches in this series will give checkpatch errors related
> to spacing and indentation. This is because the driver does not follow
>
On Fri, Sep 27, 2013 at 07:11:47AM -0400, Lidza Louina wrote:
> On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat wrote:
> > This check is not required.
> >
> > Signed-off-by: Sachin Kamat
> > Cc: Lidza Louina
> > ---
> > drivers/staging/dgnc/dgnc_kcompat.h |5 -
> > 1 file changed, 5 delet
On Sat, Sep 28, 2013 at 09:03:24PM +0200, Martin Berglund wrote:
> Cleanup of a few brace coding style issues.
>
> Signed-off-by: Martin Berglund
> ---
> drivers/staging/vt6655/80211mgr.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
Applied, thanks.
greg k-h
__
On Mon, Sep 30, 2013 at 10:22:11PM +0200, Jesper Juhl wrote:
> Make sure we always free(param); and remove a redundant "goto out;"
> just before we'll hit the label anyway.
>
> Signed-off-by: Jesper Juhl
> ---
> drivers/staging/vt6655/hostap.c | 25 ++---
> 1 files changed,
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, September 30, 2013 6:09 PM
>
> Yeah. I guess it's fine... I was going to suggest adding the + 1 in a
> different place but actually it doesn't matter.
>
> The key to understanding dwc2_set_param_host_channels() is that the
Yeah. I guess it's fine... I was going to suggest adding the + 1 in a
different place but actually it doesn't matter.
The key to understanding dwc2_set_param_host_channels() is that the
"val" parameter is always -1. That means it always returns -EINVAL and
the caller jumbles the error code in w
This bit is called DAC2S not DACS in the user manual. Fix it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_at_ao.c
This driver works with "at-ao-6/10" boards not "ai-ao-6/10" boards.
Fix the names in the boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
Each analog output channel is individually configurable. The current
analog output 'range_table' selection in this driver assumes that all
the channels are configured as either bipolar or unipolar. User option[2]
is then used during the attach to select the range_table to use.
Add a comedi_lrange
For aesthetics, add some whitespace to the subdevice init.
Remove the printk noise at the end of the attach.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 47 +--
1 file changed, 19 insertions
For aesthetics, move the boardinfo declaration closer to the struct
definition. Also, remove the cut-and-paste skel driver comment.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 25 ++---
1 file change
The AT-AO-6/10 boards use DAC8800 TrimDACs to software calibrate the
analog output channels. These are exposed to the user as a calibration
subdevice.
Tidy up, and document, the calibration subdevice.
Since the TrimDACs are not readable, store the calibration values in the
private data for the us
For aesthetics, rename this function to help with greps.
For channel 0, register group 1 only needs to be selected before
writing the values and restored to group 0 when the writes are
finished. Move the code out of the for () loop.
Use the comedi_ffset_munge() helper to handle the offset binary
For aesthetics, rename the remaining register map defines so they
follow the same format as the ones already renamed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 29 ++---
1 file changed, 14 inse
To better document the code, use the 8254.h helpers to set the
timers instead of doing the outb() instructions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 40 +++
1 file changed, 9 insertion
Rename the defines for the CFG3 register so they have namespace
associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
The digital in and digital out registers on this board share the same
address. They also effect the same digital i/o pins. To make this clear
combine the two defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 7 +++---
Rename the defines for the CFG1 register so they have namespace
associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 46 +++
1 file changed, 23 insertions(+), 23 deletions(
For aesthetics, sort the register map defines so the normal registers
are listed first and then alternate registers (when the GRP2WR bit is
set).
Convert the register bit defines into bit shifts to make them clear.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
dri
This define is only used during the board attach to specify the
I/O region length. Remove the define and just open code the value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_ao.c | 4 +---
1 file changed, 1 insertion(+), 3 de
Cleanup another comedi driver.
This series depends on:
staging: comedi: ni_at_ao: fix namespace clash of 'RSI' define
Patch 19/21 changes the names that are used to attach to the driver.
If Ian has issues with this it can be dropped.
Patch 20/21 changes the analog output range support. Again, i
Hi Dan,
On Tue, 2013-10-01 at 01:25 +0300, Dan Carpenter wrote:
> On Mon, Sep 30, 2013 at 05:05:23PM -0500, dingu...@altera.com wrote:
> > From: Dinh Nguyen
> >
> > The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding
> > a 1 to a 0xf results in a 0 for host_channels. Thus,
On Tue, 2013-10-01 at 01:25 +0300, Dan Carpenter wrote:
> On Mon, Sep 30, 2013 at 05:05:23PM -0500, dingu...@altera.com wrote:
> > From: Dinh Nguyen
> >
> > The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding
> > a 1 to a 0xf results in a 0 for host_channels. Thus, the driv
On Mon, Sep 30, 2013 at 05:05:23PM -0500, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding
> a 1 to a 0xf results in a 0 for host_channels. Thus, the driver was always
> thinking it had 0 host channels.
>
> Represent th
On Mon, Sep 30, 2013 at 04:54:51PM -0500, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding
> a 1 to a 0xf results in a 0 for host_channels. Thus, the driver was always
> thinking it had 0 host channels.
>
> Represent th
From: Dinh Nguyen
The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding
a 1 to a 0xf results in a 0 for host_channels. Thus, the driver was always
thinking it had 0 host channels.
Represent the correct number of host channels by using the host_channels
variable of dwc2_core_
From: Dinh Nguyen
The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding
a 1 to a 0xf results in a 0 for host_channels. Thus, the driver was always
thinking it had 0 host channels.
Represent the correct number of host channels by using the host_channels
variable of dwc2_core_
Hi,
On Mon, Sep 30, 2013 at 02:08:31PM -0700, David Daney wrote:
> On 09/30/2013 12:56 PM, Aaro Koskinen wrote:
> >What guarantees that CPU0 is around (or the smp_affinity is at its
> >default value) by the time user executes modprobe?
>
> Nothing enforced by the kernel. Just don't take CPU0 off
On 09/30/2013 12:56 PM, Aaro Koskinen wrote:
Hi,
On Mon, Sep 30, 2013 at 12:41:59PM -0700, David Daney wrote:
On 09/30/2013 12:35 PM, Aaro Koskinen wrote:
No, the original logic was already broken. The code assumed that the
NAPI scheduled by the driver init gets executed always on CPU 0. The
I
If 'down_read_trylock' fails we'll curently leak the memory allocated to
'buffer'.
Fix the leak by simply kfree'ing 'buffer' before returning '-EDEADLK'.
Signed-off-by: Jesper Juhl
---
.../lustre/lustre/libcfs/linux/linux-curproc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(
Make sure we always free(param); and remove a redundant "goto out;"
just before we'll hit the label anyway.
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6655/hostap.c | 25 ++---
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/vt6655/hos
Hi,
On Mon, Sep 30, 2013 at 12:41:59PM -0700, David Daney wrote:
> On 09/30/2013 12:35 PM, Aaro Koskinen wrote:
> >No, the original logic was already broken. The code assumed that the
> >NAPI scheduled by the driver init gets executed always on CPU 0. The
> >IRQ got enabled just because we are luc
On 09/30/2013 12:35 PM, Aaro Koskinen wrote:
Hi,
On Mon, Sep 30, 2013 at 10:23:10AM -0700, David Daney wrote:
On 09/28/2013 12:50 PM, Aaro Koskinen wrote:
Currently the driver assumes that CPU 0 is handling all the hard IRQs.
This is wrong in Linux SMP systems where user is allowed to assign t
Hi,
On Mon, Sep 30, 2013 at 10:23:10AM -0700, David Daney wrote:
> On 09/28/2013 12:50 PM, Aaro Koskinen wrote:
> >Currently the driver assumes that CPU 0 is handling all the hard IRQs.
> >This is wrong in Linux SMP systems where user is allowed to assign to
> >hardware IRQs to any CPU. The driver
On 09/28/2013 12:50 PM, Aaro Koskinen wrote:
Currently the driver assumes that CPU 0 is handling all the hard IRQs.
This is wrong in Linux SMP systems where user is allowed to assign to
hardware IRQs to any CPU. The driver will stop working if user sets
smp_affinity so that interrupts end up bein
As pointed out by Fengguang Wu, the RSI define in this driver clashes
with the one in arch/x86/include/uapi/asm/ptrace-abi.h.
This define isn't currently used by the driver so just rename it to fix
the clash.
Signed-off-by: H Hartley Sweeten
Reported-by: Fengguang Wu
Cc: Ian Abbott
Cc: Greg Kr
On Mon, Sep 30, 2013 at 04:35:47PM +0200, Jiri Kosina wrote:
> On Fri, 27 Sep 2013, Dan Carpenter wrote:
>
> > It looks like magicmouse_raw_event() returns 1 on success and 0 on
> > failure.
>
> Good catch indeed.
>
> I am not completely sure whether we are going to fix an oops or not by
> this
Web de administración de notificación de e-mail
Este mensaje es de nuestro centro de mensajes de administración para toda
nuestra cuenta de correo electrónico owners.We está eliminando el acceso a
todos nuestros clientes de correo web. Su correo electrónico
cuenta se actualizará a una interfaz
On 09/28/2013 04:58 AM, Dan Carpenter wrote:
We knew "peventbuf" was a valid pointer and "peventbuf + 2" is also
non-NULL. I have removed the check.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c
b/drivers/staging/rtl8712/rtl8712_cmd.c
index 088647c..53f247b
On Fri, 27 Sep 2013, Dan Carpenter wrote:
> It looks like magicmouse_raw_event() returns 1 on success and 0 on
> failure.
Good catch indeed.
I am not completely sure whether we are going to fix an oops or not by
this, as I haven't seen the actual oops anywhere in this thread :) But
definitely
On Sat, Sep 28, 2013 at 07:42:50PM +0200, Dominik Paulus wrote:
> @@ -352,34 +352,29 @@ int usbip_recv(struct socket *sock, void *buf, int size)
>
> usbip_dbg_xmit("enter\n");
>
> - if (!sock || !buf || !size) {
> - pr_err("invalid arg, sock %p buff %p size %d\n", sock, bu
There are still some checking ERR_PTR instead of NULL and some wrong
return codes left over.
On Sat, Sep 28, 2013 at 07:42:51PM +0200, Dominik Paulus wrote:
> This adds code performing the actual encryption and authentication
> operations in the usbip kernel code. The whole data stream may now be
On 09/19/2013 11:44 PM, Russell King wrote:
> Replace the following sequence:
>
> dma_set_mask(dev, mask);
> dma_set_coherent_mask(dev, mask);
>
> with a call to the new helper dma_set_mask_and_coherent().
>
> Signed-off-by: Russell King
Acked-by: Hans Verkuil
Regards,
H
The main thing is that there is an IS_ERR vs NULL check. The rest is
just style nits.
On Sat, Sep 28, 2013 at 07:42:39PM +0200, Dominik Paulus wrote:
> +static ssize_t store_acl(struct device *dev, struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> +
52 matches
Mail list logo
