Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-28 Thread Aaro Koskinen
Hi, On Sat, Sep 28, 2013 at 10:40:47PM +0200, Richard Weinberger wrote: > Am 28.09.2013 21:50, schrieb Aaro Koskinen: > > Currently the driver assumes that CPU 0 is handling all the hard IRQs. > > This is wrong in Linux SMP systems where user is allowed to assign to > > hardware IRQs to any CPU. T

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-28 Thread Richard Weinberger
Am 28.09.2013 21:50, schrieb Aaro Koskinen: > Currently the driver assumes that CPU 0 is handling all the hard IRQs. > This is wrong in Linux SMP systems where user is allowed to assign to > hardware IRQs to any CPU. The driver will stop working if user sets > smp_affinity so that interrupts end up

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-28 Thread Richard Weinberger
Am 28.09.2013 21:50, schrieb Aaro Koskinen: > Currently the driver assumes that CPU 0 is handling all the hard IRQs. > This is wrong in Linux SMP systems where user is allowed to assign to > hardware IRQs to any CPU. The driver will stop working if user sets > smp_affinity so that interrupts end up

[PATCH 2/2] staging: octeon-ethernet: allow to use only 1 CPU for packet processing

2013-09-28 Thread Aaro Koskinen
Module parameter max_rx_cpus has off-by-one error. Fix that. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index de831c1..fe1ee

[PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-28 Thread Aaro Koskinen
Currently the driver assumes that CPU 0 is handling all the hard IRQs. This is wrong in Linux SMP systems where user is allowed to assign to hardware IRQs to any CPU. The driver will stop working if user sets smp_affinity so that interrupts end up being handled by other than CPU 0. The patch fixes

[PATCH] Staging: vt6655: 80211mgr: Cleanup of brace coding style issues

2013-09-28 Thread Martin Berglund
Cleanup of a few brace coding style issues. Signed-off-by: Martin Berglund --- drivers/staging/vt6655/80211mgr.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6655/80211mgr.c b/drivers/staging/vt6655/80211mgr.c index 76c8490..7949d58 100

[PATCHv3 08/16] staging: usbip: Improve debug output

2013-09-28 Thread Dominik Paulus
For IPv6, IP:Port is unreadable. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/usbipd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/src/usbipd.c b/drivers/staging/usbip/userspace/src/us

[PATCHv3 07/16] staging: usbip: Handle usbip being started as user

2013-09-28 Thread Dominik Paulus
usbip now prints an error message when started as user and requiring root access. Also, some debug messages are changed to error messages so the command line utilities now print less confusing (and more verbose) error messages when not used correctly. Signed-off-by: Dominik Paulus Signed-off-by:

[PATCHv3 13/16] staging: usbip: Wrap kernel_sendmsg()/recvmsg()

2013-09-28 Thread Dominik Paulus
This adds two simple wrappers around kernel_sendmsg() and kernel_recvmsg() that can be extended to perform additional cryptographic operations on the data before sending it. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/stub_rx.c | 2 +- drivers/stag

[PATCHv3 12/16] staging: usbip: Pass session keys to the kernel

2013-09-28 Thread Dominik Paulus
This extends the userspace code to write the generated session keys to sysfs in hexadecimal encoding after establishing the connection. The kernel code is modified to parse the session keys. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/stub_dev.c

[PATCHv3 10/16] staging: usbip: TLS for all userspace communication

2013-09-28 Thread Dominik Paulus
This patch extends the TLS support to cover all communication in userspace. The TLS connection is released shortly before the socket is passed to the kernel. This requires for additional connection state to be passed between functions. We thus replaced the sockfd by a struct containing the TLS con

[PATCHv3 16/16] staging: usbip: Increment version number to 1.2.1

2013-09-28 Thread Dominik Paulus
Also increment the kernel module version number to match the userspace version, as compatibility with old userspace utilities is now at least partially broken. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/usbip_common.h | 2 +- drivers/staging/usb

[PATCHv3 09/16] staging: usbip: Separate protocol/program version

2013-09-28 Thread Dominik Paulus
Not all new program versions necessarily introduce non-backwards-compatible protocol changes. We thus move the definition of the protocol version from configure.ac to usbip_network.h, where it logically belongs to. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/u

[PATCHv3 05/16] staging: usbip: Add support for ACLs in usbipd

2013-09-28 Thread Dominik Paulus
Interpret the ACLs stored in sysfs in usbipd and reject clients not matching one of the ACLs. Signed-off-by: Kurt Kanzenbach Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/Makefile.am | 2 +- drivers/staging/usbip/userspace/src/usbipd.c|

[PATCHv3 11/16] staging: usbip: Exchange session keys in userspace

2013-09-28 Thread Dominik Paulus
In preparation for the kernel crypto support, we exchange two - randomly generated - session keys between usbip and usbipd to be used for encrypting all traffic generated in kernelspace. We use two different 128-bit keys, one for sending and one for receiving. Both are generated by the client (usbi

[PATCHv3 06/16] staging: usbip: Add proper error reporting

2013-09-28 Thread Dominik Paulus
This patch adds new error codes and features extended error reporting in op_common packets. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +- drivers/staging/usbip/userspace/src/usbip_list.c | 3 +- .../staging/usbip/us

[PATCHv3 15/16] staging: usbip: Update documentation

2013-09-28 Thread Dominik Paulus
From: Tobias Polzer README was updated and cleaned. It now contains just one example, which was updated to use encryption. Also, the new crypto behaviour is documented. The usbip "port" command has been removed from the README, as it isn't supported by newer userland versions. One dead link was r

[PATCHv3 14/16] staging: usbip: Add encryption support to kernel

2013-09-28 Thread Dominik Paulus
This adds code performing the actual encryption and authentication operations in the usbip kernel code. The whole data stream may now be encrypted and authenticated with AES-GCM and symmetric 128 bit keys. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/Kcon

[PATCHv3 02/16] staging: usbip: Add kernel support for client ACLs

2013-09-28 Thread Dominik Paulus
This patch adds the possibility to stored ACLs for allowed clients for each stub device in sysfs. It adds a new sysfs entry called "usbip_acl" for each stub device, containing a list of CIDR masks of allowed clients. This file will be used by usbip and usbipd to store the ACL. Signed-off-by: Kurt

[PATCHv3 01/16] staging: usbip: Add support for client authentication

2013-09-28 Thread Dominik Paulus
This patch adds support for authenticating both client and server using a pre-shared passphrase using SRP (Secure Remote Password) over TLS (see RFC 5054) using GnuTLS. Both usbip and usbipd now accept a shared secret as a command line argument. Currently, the established TLS connection is only use

[PATCHv3 03/16] staging: usbip: Add CIDR matching helper functions

2013-09-28 Thread Dominik Paulus
This patch adds a few utility functions to match IP addresses against CIDR masks. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/utils.c | 84 + drivers/staging/usbip/userspace/src/utils.h | 15 ++ 2 files chang

[PATCHv3 04/16] staging: usbip: Add ACL support to usbip bind

2013-09-28 Thread Dominik Paulus
Add the command line argument -a (--allow) to usbip bind to specify networks allowed to attach to the device and code to store the ACLs in sysfs. Signed-off-by: Kurt Kanzenbach Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/doc/usbip.8 | 8

Re: [PATCHv2 0/11] staging: usbip: Userland crypto and ACLs

2013-09-28 Thread Dominik Paulus
On Wed, Sep 25, 2013 at 04:36:38PM -0700, Greg Kroah-Hartman wrote: > Only the first patch could be applied. Can you refresh this series, and > your other one (fixing the issues pointed out there), and resend them > please? We've incorporated all of Dan's fixes and suggestions and rebased the whol

Re: Reworking dm-writeboost [was: Re: staging: Add dm-writeboost]

2013-09-28 Thread Akira Hayakawa
Hi, Two major progress: 1) .ctr accepts segment size so .ctr now accepts 3 arguments: . 2) fold the small files splitted that I suggested in the previous progress report. For 1) I use zero length array to dynamically accept the segment size. writeboost had the parameter embedded previously a

[PATCH 1/1] staging: imx-drm: Remove redundant of_match_ptr

2013-09-28 Thread Sachin Kamat
'imx_ldb_dt_ids' is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat --- drivers/staging/imx-drm/imx-ldb.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index b81e

[patch] staging: rtl8712: remove unneeded NULL check

2013-09-28 Thread Dan Carpenter
We knew "peventbuf" was a valid pointer and "peventbuf + 2" is also non-NULL. I have removed the check. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c index 088647c..53f247b 100644 --- a/drivers/staging/rtl8712/rtl8712_cm