This fixes the following sparse warnings
drivers/staging/android/binder.c:1703:5: warning: symbol 'binder_thread_write'
was not declared. Should it be static?
drivers/staging/android/binder.c:2058:6: warning: symbol 'binder_stat_br' was
not declared. Should it be static?
Signed-off-by: Bojan Prt
On Sun, Sep 1, 2013 at 10:41 PM, Ben Hutchings wrote:
> On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote:
>> On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings wrote:
>>
>> > pci_addr_phys = pdev->resource[0].start;
>> > - dev_info(&pdev->dev, "memory at 0x%08X\n",
>> > -
On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote:
> On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings wrote:
>
> > pci_addr_phys = pdev->resource[0].start;
> > - dev_info(&pdev->dev, "memory at 0x%08X\n",
> > -(unsigned int)pci_addr_phys);
> > + dev_info(&pde
On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings wrote:
> pci_addr_phys = pdev->resource[0].start;
> - dev_info(&pdev->dev, "memory at 0x%08X\n",
> -(unsigned int)pci_addr_phys);
> + dev_info(&pdev->dev, "memory at 0x%08llX\n",
> +(unsigned long lo
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt829.c
index c277bf3..8c5ba2a 100644
--- a/drivers/staging/media/lirc/lirc
We must call iounmap() when removed from a device.
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt829.c
index 8c5ba2a..76
We must not assume that the PCI device is already enabled.
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt829.c
index
Replace static variables with a device structure and pass pointers
to this into all the functions that need it.
Fold init_module(), do_pci_probe() and atir_init_start() into a
single probe function. Use dev_err() to provide context for
logging.
This also fixes a device reference leak, as the dri
I noticed lirc_bt829 didn't have a module device ID table, so I set out
to fix that and ended up with this series.
It still appears to do everything else wrong (like reinventing
i2c-algo-bit) though...
This is compile-tested only.
Ben.
Ben Hutchings (4):
[media] lirc_bt829: Make it a proper P
The point I was trying to make earlier was that I don't like knee jerk
error messages. Some people put an error message after every line
without thinking about it. It's a very common source of bugs is to
have a NULL dereference like:
if (!dev) {
pr_err("no device %s", dev
On Sat, Aug 31, 2013 at 06:19:11PM -0400, Lidza Louina wrote:
> This patch adds the dgnc_board struct to driver.h.
> This struct will replace board_t in this driver.
>
So on this one patches 3, 4 and 5 should just be one patch. It should
rename board_t to dgnc_board in the .h file and change all
On Sat, Aug 31, 2013 at 06:19:14PM -0400, Lidza Louina wrote:
> This patch removes the error statements that follow
> kzalloc. These are useless because kzalloc has its
> own error statement and the driver's error handling
> would never actually happen.
>
Gar! Wait! What? I'm sorry, I was tota
On Sat, Aug 31, 2013 at 06:19:10PM -0400, Lidza Louina wrote:
> This patch replaces all instances of "sizeof(struct"
> with actual instances of the struct. For example
> "sizeof(struct tty_struct" is replaced with
> "sizeof(brd->SerialDriver.ttys".
>
This one is not right.
> This patch affects d
compare_ether_addr is being removed so remove
even the commented out code referring to it.
Signed-off-by: Joe Perches
---
drivers/staging/vt6655/vntwifi.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/staging/vt6655/vntwifi.c b/drivers/staging/vt6655/vntwifi.
On Sun, Sep 01, 2013 at 10:18:44PM +0200, Bojan Prtvar wrote:
> -void binder_stat_br(struct binder_proc *proc, struct binder_thread *thread,
> +static void binder_stat_br(struct binder_proc *proc,
> + struct binder_thread *thread,
> uint32_t cmd)
The indenting
On Mon, Sep 02, 2013 at 03:30:12AM +0800, Wang Shilong wrote:
> Hello, Using checkpatch.pl, i get the following warnings(errors):
All of these were there in the original code.
Have your script copy the messages to your postponed messages folder and
then look over the output before mailing it.
re
This fixes the following sparse warnings
drivers/staging/android/binder.c:1703:5: warning: symbol 'binder_thread_write'
was not declared. Should it be static?
drivers/staging/android/binder.c:2058:6: warning: symbol 'binder_stat_br' was
not declared. Should it be static?
Signed-off-by: Bojan Prt
The Fastwel UNIOxx-5 is a PCI/104 board so put COMEDI_UNIOXX5 under
COMEDI_ISA_DRIVERS.
The PCI-20001C is, surprisingly, an ISA card, so also put
COMEDI_II_PCI20KC under COMEDI_ISA_DRIVERS.
The DIL/Net-PC 1486 is a 486 system, so put COMEDI_SSV_DNP under
COMEDI_MISC_DRIVERS and add a dependency o
On Mon, 2013-09-02 at 03:30 +0800, Wang Shilong wrote:
> Hello, Using checkpatch.pl, i get the following warnings(errors):
Hello.
Especially for staging patches, all of these are "don't care"
types of messages.
You should change your script to check if these are existing
warnings and if so, not
Hello, Using checkpatch.pl, i get the following warnings(errors):
WARNING: Avoid CamelCase: bHwError>
#124: FILE: drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1875:
+(!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV));
WARNING: Avoid CamelCase: bCRC>
#124: FILE: drivers/st
Preliminary to removing compare_ether_addr altogether:
Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.
Additionally:
Used is_zero_ether_addr, removed now unused variable
Converted uses of &foo[0] to foo
Done
Several speakup drivers are for ISA cards and are useless on systems
without ISA slots. Make them depend on ISA || COMPILE_TEST.
Signed-off-by: Ben Hutchings
---
drivers/staging/speakup/Kconfig | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/speakup/Kconfig b/drivers/sta
This fixes the following sparse error
drivers/staging/android/binder.c:1795:36: error: incompatible types in
comparison expression (different address spaces)
Signed-off-by: Bojan Prtvar
---
drivers/staging/android/binder.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Hello,
My name is Albert Liu Hongzuo, a Chinese national, I have an immense business
of great benefit for both of us. Upon your response I will update you with the
full details.
Await your immediate response.
Contact me with this Email (albertliuhong...@163.com)
Albert Liu
__
24 matches
Mail list logo
