Code should be for the kernel version it is merged in.
Version check is not necessary.
Signed-off-by: Sachin Kamat
---
Compile tested only.
---
drivers/staging/dgap/dgap_kcompat.h | 29 -
1 files changed, 0 insertions(+), 29 deletions(-)
diff --git a/drivers/stagin
Code should be for the kernel version it is merged in.
Version check is not necessary.
Signed-off-by: Sachin Kamat
---
Compile tested only.
---
drivers/staging/dgap/dgap_driver.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap_driver.c
b/dri
On Fri, Aug 30, 2013 at 12:46:22PM +0200, Benjamin Valentin wrote:
> Samsung released their exFAT (and FAT12/16/32) driver under the GPLv2, it is
> based on the in-kernel FAT driver and can be obtained from [1].
> This patch adds version 1.2.4 of the exfat driver, sans the ifdefs for older
> kernel
Use the new comedi_dio_update_state() and comedi_dio_insn_config() helpers
to tidy up the digital subdevices in this driver.
Remove the need for the kzalloc'd private data.
This series depends on the patch series:
"[PATCH v3 00/21] staging: comedi: tidy up digital output (*insn_bits)"
v2: reba
For aesthetic reasons, reorder the #include list.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/comedi_parp
Use the subdevice s->state to hold the current state of the data register
outputs instead of carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 12
1 file changed, 4
Rename this function to better describe it's use.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 14 ++-
This is the (*insn_config) function for a DIO subdevice. It should be
using the data[0] value as the "instruction" to perform on the subdevice.
Use the comedi_dio_insn_config() helper to properly handle instructions.
Also, rename the function to better describe it's use.
Signed-off-by: H Hartley
Rename this function to better describe it's use.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 18 +--
Tidy up the multi-line comments to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 136 +++-
1 file changed, 62 insertions(+), 74 deletions(-)
diff --git a/drivers
Use the dev->read_subdev to get the comedi_subdevice instead of accessing
the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
The control register for the parallel port is readable so there is no need
to cache the current value in the private data.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 34 ++---
1 file
For aesthetic reasons, rename this function.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_pa
Use the subdevice 'state' variable instead of carrying the state of
the output channels in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
Change the MODULE_DESCRIPTION to something useful instead of the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Add some whitespace to tidy up the subdevice init.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 64 +
1 file changed, 34 insertions(+), 30 deletions(-)
diff --git a/drivers/staging
The extra mask used to only update the channels configured as outputs is
not necessary in this driver. Remove it and use comedi_dio_update_state()
to handle the boilerplate code to update the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
The extra mask used to only update the channels configured as outputs is
not necessary in this driver. Remove it and use comedi_dio_update_state()
to handle the boilerplate code to update the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
Rename the register map defines to better describe the hardware.
Add defines for the control register bits that enable the irq and
change the direction of the data register. This gets rid of the
"magic" numbers.
Remove PARPORT_SIZE, it's only used when requesting the i/o region
with comedi_reques
Interrupt support in this driver is optional. Don't fail the attach of the
board if the request_irq() fails.
Only allocate and setup the subdevice for the interrupt if the request_irq()
was successful.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
The enabled state of the interrupt can be checked by reading the control
register.
Remove 'enabled_irq' from the private data.
Since the private data is now empty, remove it completely and remove the
allocation of it in parport_attach().
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Also, fix a bug where the state of the channels is returned in data[0].
The comedi core expects it to be returned in data[1].
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
--
Rename this function to better describe it's use.
Tidy it up to follow the normal comedi (*insn_bits) for DI subdevices.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 15 ++-
1 file changed, 6
On Thu, Aug 29, 2013 at 03:36:54PM +0530, Sachin Kamat wrote:
> Fixes the following compilation errors:
> drivers/staging/dgap/dgap_driver.c:423:3: error:
> implicit declaration of function ‘kfree’
> [-Werror=implicit-function-declaration]
> kfree(dgap_config_buf);
> ^
> drivers/staging/dgap/dgap_
On Thu, Aug 29, 2013 at 03:36:55PM +0530, Sachin Kamat wrote:
> Code should be for the kernel version it is merged in. Version
> check is not necessary.
>
> Signed-off-by: Sachin Kamat
> ---
> Compile tested only.
> ---
> drivers/staging/dgap/dgap_driver.c |4
> drivers/staging/dgap/dg
On Thu, Aug 29, 2013 at 07:00:37PM -0400, Lidza Louina wrote:
> This patchs adds a TODO for the driver.
>
> Signed-off-by: Lidza Louina
> ---
> drivers/staging/dgnc/TODO | 17 +
> 1 file changed, 17 insertions(+)
> create mode 100644 drivers/staging/dgnc/TODO
That's great, than
Use the subdevice 'state' variable instead of carrying the state of
the output channels in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
Use the subdevice 'state' variable instead of carrying the state of
the output channels in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
Use the subdevice 'state' variable instead of having to calculate the
current state based on the do_mux_bits in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
These drivers always need to update the hardware in order to update
the i/o configuration regardless of if the state has changed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Remove the DEBUG_DIO, its just added noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 45 +-
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Tidy up the vmk80xx_do_insn_bits() function a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/vmk80xx.c | 35 --
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state for simple cases where the hardware is updated
when any channel is modified.
Also, fix a bug in the amplc_pc263 and amplc_pci263 drivers where the
current state is not returned in data[1].
Signed-off-by:
Convert this driver to use the comedi_dio_update_state() helper
function.
Tidy up the comments to reflect the new code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/skel.c | 46 +++
1 file changed, 30
Use the subdevice 'state' variable instead of carrying the state of
the output channels in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state for more complex cases where the hardware is only
updated based on the 'mask' of the channels that are modified.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stag
The (*insn_bits) functions for DIO and DO subdevices typically use
the subdevice 's->state' to hold the current state of the output
channels. The 'insn' passed to these functions, INSN_BITS, specifies
two parameters passed in the 'data'.
data[0] = 'mask', the channels to update
data[1] = 'bits
The subdevice 'io_bits' is a bit mask of the i/o configuration for
digital subdevices. '0' values indicate that a channel is configured
as an input and '1' values that the channel is an output. Since the
subdevice data is kzalloc()'d, all channels default as inputs.
Modify __comedi_device_postconf
The extra mask used to only update the channels configured as outputs is
not necessary in this driver. Remove it and use comedi_dio_update_state()
to handle the boilerplate code to update the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
The extra mask used to only update the channels configured as outputs is
not necessary in this driver. Remove it and use comedi_dio_update_state()
to handle the boilerplate code to update the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
Consolidate the boilerplate code used to mask and set the output channels of
DIO and DO subdevices.
v3: fix [PATCH 01/21] to prevent overflow when calculating s->io_bits
fix [PATCH 02/21] so only the valid channels in the subdevice are modified
drop the patch that only updated to output ch
The extra mask used to only update the channels configured as outputs is
not necessary in this driver. Remove it and use comedi_dio_update_state()
to handle the boilerplate code to update the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
The extra mask used to only update the channels configured as outputs is
not necessary in this driver. Remove it and use comedi_dio_update_state()
to handle the boilerplate code to update the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletion
>From c21d0da84c92d351f37b70c0d9c01a66fcb84e88 Mon Sep 17 00:00:00 2001
From: Paul McQuade
Date: Thu, 15 Aug 2013 20:00:50 +0100
Subject: [PATCH] Staging:BCM:DDRInit.c:Renaming __FUNCTION__
__Function__ gets renamed with __func__
Signed-Off-By: Paul McQuade
---
drivers/staging/bcm/DDRInit.c |
On Fri, Aug 30, 2013 at 06:08:52PM +0200, Bjørn Mork wrote:
> A device inheriting a random or set address should reflect this in
> its addr_assign_type.
>
> Cc: Forest Bond
> Signed-off-by: Bjørn Mork
Acked-by: Greg Kroah-Hartman
___
devel mailing li
On Friday, August 30, 2013 5:26 AM, Ian Abbott wrote:
> On 2013-08-30 02:00, H Hartley Sweeten wrote:
>> Make sure that only the state of the channels configured as outputs are
>> updated.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ian Abbott
>> Cc: Greg Kroah-Hartman
>> ---
>> drivers/stag
Copying the dev_addr from a parent device is an operation
common to a number of drivers. The addr_assign_type should
be updated accordingly, either by reusing the value from
the source device or explicitly indicating that the address
is stolen by setting addr_assign_type to NET_ADDR_STOLEN.
This p
A device inheriting a random or set address should reflect this in
its addr_assign_type.
Cc: Forest Bond
Signed-off-by: Bjørn Mork
---
drivers/staging/vt6655/hostap.c |2 +-
drivers/staging/vt6655/ioctl.c |2 +-
drivers/staging/vt6655/wpactl.c |2 +-
3 files changed, 3 insertions(+
Some etherdevices inherit their address from a parent or
master device. The addr_assign_type should be updated along
with the address in these cases. Adding a helper function
to simplify this.
Signed-off-by: Bjørn Mork
---
include/linux/etherdevice.h | 15 +++
1 file changed, 15 i
On Fri, Aug 23, 2013 at 06:33:33PM +0100, Rupesh Gujare wrote:
>
> diff --git a/drivers/staging/ozwpan/ozproto.h
> b/drivers/staging/ozwpan/ozproto.h
> index e532347..0c49c8a 100644
> --- a/drivers/staging/ozwpan/ozproto.h
> +++ b/drivers/staging/ozwpan/ozproto.h
> @@ -19,7 +19,7 @@
> #define OZ
On Fri, Aug 23, 2013 at 06:33:33PM +0100, Rupesh Gujare wrote:
> Max. TX frame size supported is changed to 760 bytes.
Hi Rupesh,
>From the comment, this looks like an arbitrary change for no reason.
Why are you changing the TX frame size to 760 - and can we add the
reason to the changelog?
Chee
On 2013-08-30 01:59, Hartley Sweeten wrote:
On Thursday, August 29, 2013 7:19 AM, Ian Abbott wrote:
On 2013-08-28 21:55, H Hartley Sweeten wrote:
Use the new comedi_dio_insn_bits() and comedi_dio_insn_config() helpers
to tidy up the digital subdevices in this driver.
Remove the need for the kz
On 2013-08-30 02:00, H Hartley Sweeten wrote:
Make sure that only the state of the channels configured as outputs are
updated.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Mon 2013-08-26 17:09:59, Iker Pedrosa wrote:
> Fixes some coding style issues from drivers/staging/winbond
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
__
On Fri, 2013-08-30 at 12:46 +0200, Benjamin Valentin wrote:
> Samsung released their exFAT (and FAT12/16/32) driver under the GPLv2, it is
> based on the in-kernel FAT driver and can be obtained from [1].
> This patch adds version 1.2.4 of the exfat driver, sans the ifdefs for older
> kernel versio
On 2013-08-30 01:47, H Hartley Sweeten wrote:
The subdevice 'io_bits' is a bit mask of the i/o configuration for
digital subdevices. '0' values indicate that a channel is configured
as an input and '1' values that the channel is an output. Since the
subdevice data is kzalloc()'d, all channels def
On 2013-08-30 09:23, Dan Carpenter wrote:
On Thu, Aug 29, 2013 at 04:43:49PM +, Hartley Sweeten wrote:
You don't really need to test s->n_chan < 32. For s->n_chan >= 32,
s->io_bits will end up set to 0x anyway (and for s->n_chan > 32,
the low-level drivers shouldn't really be using
On Thu, Aug 29, 2013 at 04:43:49PM +, Hartley Sweeten wrote:
> > You don't really need to test s->n_chan < 32. For s->n_chan >= 32,
> > s->io_bits will end up set to 0x anyway (and for s->n_chan > 32,
> > the low-level drivers shouldn't really be using s->state and s->io_bits
> > an
many of the macros defined in Version.h are not being used,
so we can remove the file.
Signed-off-by: navin patidar
---
drivers/staging/bcm/Bcmchar.c |4 ++--
drivers/staging/bcm/Version.h | 29 -
drivers/staging/bcm/headers.h |3 +--
3 files changed, 3 inse
Use the subdevice 'state' variable instead of carrying the state of
the output channels in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
Convert this driver to use the comedi_dio_update_state() helper
function.
Tidy up the comments to reflect the new code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/skel.c | 49 +++
1 file changed, 33
The (*insn_bits) functions for DIO and DO subdevices typically use
the subdevice 's->state' to hold the current state of the output
channels. The 'insn' passed to these functions, INSN_BITS, specifies
two parameters passed in the 'data'.
data[0] = 'mask', the channels to update
data[1] = 'bits
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state for more complex cases where the hardware is only
updated based on the 'mask' of the channels that are modified.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stag
Use the subdevice 'state' variable instead of carrying the state of
the output channels in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
65 matches
Mail list logo