Re: [PATCH Resend 1/4] staging: dgap: Include version.h header in dgap_kcompat.h

On 29 August 2013 03:45, Greg KH wrote: > On Wed, Aug 28, 2013 at 10:35:46AM +0530, Sachin Kamat wrote: >> Include version.h header file as detected by versioncheck. >> >> Cc: Lidza Louina >> Signed-off-by: Sachin Kamat >> --- >> drivers/staging/dgap/dgap_kcompat.h |2 ++ >> 1 file changed,

Re: [PATCH v2 2/3] staging: dgnc: driver.c and tty.c: replaces dgnc_driver_kzmalloc with kzalloc

On Wed, Aug 28, 2013 at 4:30 AM, Dan Carpenter wrote: > On Tue, Aug 27, 2013 at 10:13:27PM -0400, Lidza Louina wrote: >> @@ -501,7 +501,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id) >> >> /* get the board structure and prep it */ >> brd = dgnc_Board[dgnc_NumBoards] = >

Re: [PATCH v2 2/3] staging: dgnc: driver.c and tty.c: replaces dgnc_driver_kzmalloc with kzalloc

On Wed, Aug 28, 2013 at 4:30 AM, Dan Carpenter wrote: > On Tue, Aug 27, 2013 at 10:13:27PM -0400, Lidza Louina wrote: >> @@ -501,7 +501,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id) >> >> /* get the board structure and prep it */ >> brd = dgnc_Board[dgnc_NumBoards] = >

Re: [PATCH v2 2/3] staging: dgnc: driver.c and tty.c: replaces dgnc_driver_kzmalloc with kzalloc

On Wed, Aug 28, 2013 at 12:54 AM, Greg KH wrote: > I'll take this for now, but all of these casts of the kzalloc() call > need to go away, as they are pointless (kzalloc() returns a void *, > which automatically can be assigned to any pointer type, no need to be > explicit about it.) > > So that m

[PATCH 07/15] staging: comedi: comedi_parport: remove 'c_data' from private data

The control register for the parallel port is readable so there is no need to cache the current value in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 34 ++--- 1 file changed,

[PATCH 15/15] staging: comedi: comedi_parport: change MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something useful instead of the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH] staging: comedi: ni_labpc: use comedi_range_is_unipolar()

Use the core provided helper function instead of duplicating it as a private function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/sta

[PATCH 00/15] staging: comedi: comedi_parport: cleanup driver

Use the new comedi_dio_insn_bits() and comedi_dio_insn_config() helpers to tidy up the digital subdevices in this driver. Remove the need for the kzalloc'd private data. H Hartley Sweeten (15): staging: comedi: comedi_parport: tidy up the register map staging: comedi: comedi_parport: remove '

[PATCH 05/15] staging: comedi: comedi_parport: tidy up parport_insn_b()

Rename this function to better describe it's use. Tidy it up to follow the normal comedi (*insn_bits) for DI subdevices. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 15 ++- 1 file changed, 6 insertion

Re: [PATCH v2 3/3] staging: dgnc: driver.c and .h: removes dgnc_driver_kzmalloc func

On Wed, Aug 28, 2013 at 06:50:44PM -0400, Lidza Louina wrote: > On Wed, Aug 28, 2013 at 6:34 PM, Lidza Louina wrote: > > On Wed, Aug 28, 2013 at 12:57 AM, Greg KH > > wrote: > >> On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote: > >>> This patch removes the dgnc_driver_kzmalloc funct

Re: [PATCH v2 3/3] staging: dgnc: driver.c and .h: removes dgnc_driver_kzmalloc func

On Wed, Aug 28, 2013 at 6:34 PM, Lidza Louina wrote: > On Wed, Aug 28, 2013 at 12:57 AM, Greg KH wrote: >> On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote: >>> This patch removes the dgnc_driver_kzmalloc function from >>> driver.c and driver.h. A previous patch replaced all >>> dgnc_

Re: [PATCH v2 3/3] staging: dgnc: driver.c and .h: removes dgnc_driver_kzmalloc func

On Wed, Aug 28, 2013 at 12:57 AM, Greg KH wrote: > On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote: >> This patch removes the dgnc_driver_kzmalloc function from >> driver.c and driver.h. A previous patch replaced all >> dgnc_driver_kzmalloc function calls with kzalloc. >> >> Signed-of

Re: [PATCH Resend 1/4] staging: dgap: Include version.h header in dgap_kcompat.h

On Wed, Aug 28, 2013 at 10:35:46AM +0530, Sachin Kamat wrote: > Include version.h header file as detected by versioncheck. > > Cc: Lidza Louina > Signed-off-by: Sachin Kamat > --- > drivers/staging/dgap/dgap_kcompat.h |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/stagin

[PATCH] staging: comedi: pcmad: use comedi_range_is_bipolar()

Use the core provided helper function instead of duplicating it as a private function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmad.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/co

[PATCH 1/1] Drivers: hv: vmbus: Do not attempt to negoatiate a new version prematurely

The current code would attempt to negotiate a different protocol version if the current negotiation timed out. This triggers an assert in the host (on debug builds). Avoid this by negotiating a newer version only if the host properly rejects the current version being negotiated. Signed-off-by: K.

[PATCH 14/15] staging: comedi: comedi_parport: use dev->read_subdev in interrupt handler

Use the dev->read_subdev to get the comedi_subdevice instead of accessing the dev->subdevices array directly. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 13/15] staging: comedi: comedi_parport: rename parport_intr_insn()

For aesthetic reasons, rename this function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_parport.c

[PATCH 12/15] staging: comedi: comedi_parport: reorder #include's

For aesthetic reasons, reorder the #include list. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/

[PATCH 11/15] staging: comedi: comedi_parport: tidy up multi-line comments

Tidy up the multi-line comments to follow the CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 136 +++- 1 file changed, 62 insertions(+), 74 deletions(-) diff --git a/drivers/staging/

[PATCH 10/15] staging: comedi: comedi_parport: tidy up parport_attach()

Add some whitespace to tidy up the subdevice init. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 64 + 1 file changed, 34 insertions(+), 30 deletions(-) diff --git a/drivers/staging/comedi/d

[PATCH 09/15] staging: comedi: comedi_parport: don't fail attach if irq is not available

Interrupt support in this driver is optional. Don't fail the attach of the board if the request_irq() fails. Only allocate and setup the subdevice for the interrupt if the request_irq() was successful. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/

[PATCH 08/15] staging: comedi: comedi_parport: remove 'enable_irq' from private data

The enabled state of the interrupt can be checked by reading the control register. Remove 'enabled_irq' from the private data. Since the private data is now empty, remove it completely and remove the allocation of it in parport_attach(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg

[PATCH 06/15] staging: comedi: comedi_parport: tidy up parport_insn_c()

Rename this function to better describe it's use. Use comedi_dio_insn_bits() to handle the boilerplate code to update the subdevice s->state. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 18 +- 1 f

[PATCH 03/15] staging: comedi: comedi_parport: tidy up parport_insn_a()

Rename this function to better describe it's use. Use comedi_dio_insn_bits() to handle the boilerplate code to update the subdevice s->state. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 14 ++ 1 file

[PATCH 04/15] staging: comedi: comedi_parport: fix parport_insn_config_a()

This is the (*insn_config) function for a DIO subdevice. It should be using the data[0] value as the "instruction" to perform on the subdevice. Use the comedi_dio_insn_config() helper to properly handle instructions. Also, rename the function to better describe it's use. Signed-off-by: H Hartley

[PATCH 02/15] staging: comedi: comedi_parport: remove 'a_data' from private data

Use the subdevice s->state to hold the current state of the data register outputs instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_parport.c | 12 1 file changed, 4 insertio

[PATCH 01/15] staging: comedi: comedi_parport: tidy up the register map

Rename the register map defines to better describe the hardware. Add defines for the control register bits that enable the irq and change the direction of the data register. This gets rid of the "magic" numbers. Remove PARPORT_SIZE, it's only used when requesting the i/o region with comedi_reques

[PATCH 01/11] staging: comedi: core: introduce comedi_dio_insn_bits()

The (*insn_bits) functions for DIO and DO subdevices typically use the subdevice 's->state' to hold the current state of the output channels. The 'insn' passed to these functions, INSN_BITS, specifies two parameters passed in the 'data'. data[0] = 'mask', the channels to update data[1] = 'bits

[PATCH 05/11] staging: comedi: core: initialize subdevice s->io_bits in postconfig

The subdevice 'io_bits' is a bit mask of the i/o configuration for digital subdevices. '0' values indicate that a channel is configured as an input and '1' values that the channel is an output. Since the subdevice data is kzalloc()'d, all channels default as inputs. Modify __comedi_device_postconf

[PATCH 09/11] staging: comedi: ssv_dnp: use comedi_dio_insn_bits()

Use comedi_dio_insn_bits() to handle the boilerplate code to update the subdevice s->state. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ssv_dnp.c | 51 +--- 1 file changed, 20 insertions(+), 31 deletions(

[PATCH 11/11] staging: comedi: adq12b: use comedi_dio_insn_bits()

Use comedi_dio_insn_bits() to handle the boilerplate code to update the subdevice s->state. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adq12b.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --

[PATCH 10/11] staging: comedi: adq12b: remove 'digital_state' from private data

Use the subdevice 'state' to hold the digital output state instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adq12b.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a

[PATCH 07/11] staging: comedi: drivers: use comedi_dio_insn_bits() for DIO subdevices

Use comedi_dio_insn_bits() to handle the boilerplate code to update the subdevice s->state for DIO subdevices. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_16xx.c | 11 +- drivers/staging/comedi/drivers/addi_apci_3xxx.c

[PATCH 08/11] staging: comedi: drivers: more users of comedi_dio_insn_bits()

Convert a couple more comedi drivers to use comedi_dio_insn_bits() to handle the boilerplate code to update the subdevice s->state. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../staging/comedi/drivers/amplc_dio200_common.c | 22 +- drivers

[PATCH 06/11] staging: comedi: core: only update outputs with comedi_dio_insn_bits()

Make sure only the state of the channels configured as outputs is updated by comedi_dio_insn_bits(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/c

[PATCH 04/11] staging: comedi: drivers: use comedi_dio_insn_bits()

Use comedi_dio_insn_bits() to handle the boilerplate code to update the subdevice s->state for DIO and DO subdevices. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/8255.c | 25 ++-- .../comedi/drivers/addi-data/hwdrv_

[PATCH 03/11] staging: comedi: usbdux drivers: use comedi_dio_insn_bits()

Use comedi_dio_insn_bits() to handle the boilerplate code to update the subdevice s->state. These drivers always need to update the hardware in order to update the i/o configuration regardless of if the state has changed. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman -

[PATCH 02/11] staging: comedi: skel: use comedi_dio_insn_bits()

Convert this driver to use the comedi_dio_insn_bits() helper function. Tidy up the comments to reflect the new code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/skel.c | 43 +++ 1 file changed, 28 in

[PATCH 00/11] staging: comedi: tidy up digital output (*insn_bits)

Consolidate the boilerplate code used to mask and set the output channels of DIO and DO subdevices. H Hartley Sweeten (11): staging: comedi: core: introduce comedi_dio_insn_bits() staging: comedi: skel: use comedi_dio_insn_bits() staging: comedi: usbdux drivers: use comedi_dio_insn_bits()

Re: [PATCH V3] i2c: move of helpers into the core

On Thu, 22 Aug 2013 18:00:14 +0200, Wolfram Sang wrote: > I2C of helpers used to live in of_i2c.c but experience (from SPI) shows > that it is much cleaner to have this in the core. This also removes a > circular dependency between the helpers and the core, and so we can > finally register child n

[PATCH] Staging: crystalhd: fixed whitespace and string style issues

Fixed 3 instances of user-visible string being broken into two string. Fixed 2 instances of illegal whitespace. --- drivers/staging/crystalhd/crystalhd_cmds.c |3 +-- drivers/staging/crystalhd/crystalhd_hw.c |7 +++ drivers/staging/crystalhd/crystalhd_lnx.c |3 +-- 3 files chang

Re: [PATCH 2/2] staging: rtl8188eu: Remove duplicate header inclusion in ioctl_linux.c

On 08/28/2013 12:55 AM, Sachin Kamat wrote: Removed the header files included twice. Signed-off-by: Sachin Kamat Cc: Larry Finger --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/driv

Re: [PATCH 3/3] staging: rtl8188eu: Include version.h header in xmit_linux.c

On 08/28/2013 12:35 AM, Sachin Kamat wrote: Include version.h header file as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c b/drivers

[v2 PATCH 3/3] staging: ozwpan: Return error, if PD is not connected.

Return error if we receive write(), while PD is not connected. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozcdev.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 50722ea..6ccb64f 100644 --- a/drivers/s

[v2 PATCH 2/3] staging: ozwpan: Change error number.

Incorrect error number was returned here (EPERM), ENXIO is more appropriate. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozcdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 03b41ee..50

[v2 PATCH 1/3] staging: ozwpan: Increase ISOC IN buffer depth

Buffer depth of 50 units is not sufficient when there is considerable delay occuring on air due to interference, increase ISOC IN buffer depth to 100 units. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

Re: [PATCH v2 2/3] staging: dgnc: driver.c and tty.c: replaces dgnc_driver_kzmalloc with kzalloc

On Tue, Aug 27, 2013 at 10:13:27PM -0400, Lidza Louina wrote: > @@ -501,7 +501,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id) > > /* get the board structure and prep it */ > brd = dgnc_Board[dgnc_NumBoards] = > - (struct board_t *) dgnc_driver_kzmalloc(sizeof(struc

[PATCH 1/2] staging: rtl8188eu: Remove duplicate incusion in drv_types.h

wlan_bssdef.h was included twice. Signed-off-by: Sachin Kamat Cc: Larry Finger --- drivers/staging/rtl8188eu/include/drv_types.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index 6e49359..ad