This is the (*insn_config) function for a DIO subdevice. It should be
using the data[0] value as the "instruction" to perform on the subdevice.
Use the comedi_dio_insn_config() helper to properly handle instructions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
d
This is the (*insn_config) function for a DIO subdevice. It should be
using the data[0] value as the "instruction" to perform on the subdevice.
Use the comedi_dio_insn_config() helper to properly handle instructions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
d
This is the (*insn_config) function for a DIO subdevice. It should be
using the data[0] value as the "instruction" to perform on the subdevice.
Use the comedi_dio_insn_config() helper to properly handle instructions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
d
These drivers all improperly implement the (*insn_config) for a DIO subdevice.
They
all treat the data[0] value as a flag to configure the channel in
insn->chanspec as
either an output or an input. The data[0] value is actually the 'instruction'
to be
performed on the channel.
Use the comedi_di
This is the (*insn_config) function for a DIO subdevice. It should be
using the data[0] value as the "instruction" to perform on the subdevice.
Use the comedi_dio_insn_config() helper to properly handle instructions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
d
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, August 26, 2013 4:14 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com; sta...@vger.kernel.org
> Sub
On Mon, Aug 26, 2013 at 10:48:16PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Monday, August 26, 2013 2:57 PM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > o...@aep
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, August 26, 2013 2:57 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com; sta...@vger.kernel.org
> Sub
Hyper-V supports a mechanism for retrieving the local API frequency.Use this
and bypass
the calibration code in the kernel. This would allow us to boot the Linux
kernel as a
"modern VM" on Hyper-V where many of the legacy devices (such as PIT) are not
emulated.
I would like to thank Olaf Hering
On Mon, Aug 26, 2013 at 02:08:58PM -0700, K. Y. Srinivasan wrote:
> The channel state should be correctly set before registering the device. In
> the current
> code the driver probe would fail for channels that have been rescinded and
> subsequently
> re-offered. Fix the bug.
>
> Signed-off-by:
The channel state should be correctly set before registering the device. In the
current
code the driver probe would fail for channels that have been rescinded and
subsequently
re-offered. Fix the bug.
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/hv/channel_mgmt.c | 14 +++---
1 f
This patch edits the vaddr variable in dgnc_tty_init.
The variable gets set to board_t->re_map_membase. A
previous patch changed the re_map_membase variable's
marker and type. This patch makes sure that the
changes are consistent and that it doesn't cause
sparse warnings.
Signed-off-by: Lidza Loui
This patch adds a marker to neo_read_eeprom function's
base parameter.
It removes these warnings found in neo.c:
warning: incorrect type in argument 1 (different address spaces)
expected unsigned char *base
got unsigned char [noderef] [usertype] *re_map_membase
warning: incorrect type in argu
This patch changes cls_vpd function's re_map_vpdbase variable
type and marker.
It removes these warnings found in cls.c:
warning: incorrect type in assignment (different address spaces)
expected unsigned char [usertype] *re_map_vpdbase
got void [noderef] *
warning: incorrect type in argument
This patch changes the board_t->re_map_membase variable
type and marker.
It removes these warnings found in the neo.c,
driver.c and cls.c files:
warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] *addr
got unsigned char volatile *
warning:
On Mon, 2013-08-26 at 19:02 +0300, Dan Carpenter wrote:
> On Mon, Aug 26, 2013 at 05:10:04PM +0200, Iker Pedrosa wrote:
[]
> > diff --git a/drivers/staging/winbond/phy_calibration.c
> > b/drivers/staging/winbond/phy_calibration.c
[]
> > @@ -1233,8 +1233,10 @@ u8 _rx_iq_calibration_loop_winbond(str
Btw, all the white space nit-pick I pointed out were pretty minor. I
don't like making people redo stuff so you can fix anything you want to
in later patches.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.l
On Mon, Aug 26, 2013 at 05:10:22PM +0200, Iker Pedrosa wrote:
> Fixed some lines over 80 characters.
>
> Signed-off-by: Iker Pedrosa
> ---
> drivers/staging/winbond/wbusb.c | 16 +++-
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/winbond/wbusb.c
On Mon, Aug 26, 2013 at 05:10:08PM +0200, Iker Pedrosa wrote:
> @@ -926,7 +928,8 @@ static void Set_ChanIndep_RfData_al7230_24(struct hw_data
> *pHwData, u32 *pltmp,
> u8 i;
> for (i = 0; i < number; i++) {
> pHwData->phy_para[i] = al7230_rf_data_24[i];
> -
Erased the spaces that existed after opening some square brackets '['.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35tx_s.h
b/drivers/staging/winbond/wb35tx_s.h
index 715f87d..dc
On Mon, Aug 26, 2013 at 05:10:08PM +0200, Iker Pedrosa wrote:
> First of the patches that fixes the lines over 80 characters in reg.c
>
> Signed-off-by: Iker Pedrosa
> ---
> drivers/staging/winbond/reg.c | 30 +-
> 1 file changed, 17 insertions(+), 13 deletions(-)
>
On Mon, Aug 26, 2013 at 05:10:04PM +0200, Iker Pedrosa wrote:
> Second of the patches that fixes the lines over 80 characters in
> phy_calibration.c
>
> Signed-off-by: Iker Pedrosa
> ---
> drivers/staging/winbond/phy_calibration.c | 12
> 1 file changed, 8 insertions(+), 4 deletion
This patch fixes these warnings found in the neo.c file:
warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] *addr
got unsigned char volatile *
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef
Fixed lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg_f.h | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg_f.h
b/drivers/staging/winbond/wb35reg_f.h
index 95dc980..cd6710c 100644
---
First of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.c | 46 ++-
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/winbond/phy_calibrati
White space deleted before semicolons.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 5883d23..80b4b34 100644
--- a/drivers/staging/winbond/r
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35rx.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c
index 48ed95c..999b7046 100644
--- a/drivers/stagin
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Seventh of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index
Prototype of two functions added to the header to avoid the use of extern.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.c | 4 +---
drivers/staging/winbond/mto.h | 4 ++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers/stagin
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wbusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
Deleted an space before a tabulation.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35reg_s.h
b/drivers/staging/winbond/wb35reg_s.h
index dc79faa..cdbbf35 100644
--- a/drivers/sta
The previously used printk lacked the warning level, now we've got a more
accurate way to know the error.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/stagi
Third of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
i
Fifth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wbusb.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index 3fa1ae4..c128bc9 100644
--- a/drivers
First of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
i
Second of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
Fourth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg
Sixth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
ind
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 52 +--
1 file changed,
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
The following function declarations have been removed because they aren't
implemented.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c
index 560c0ab..0d0f9fb 100644
Erased all the errors given by checkpatch stating trailing whitespace.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 75b7752..5883d
Second of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/phy_calibration.c
b/drivers/stag
Fixes some coding style issues from drivers/staging/winbond
Iker Pedrosa (24):
Staging: winbond: mto: removed function declaration
Staging: winbond: mto: avoided use of extern functions
Staging: winbond: mto: deleted extern functions
Staging: winbond: phy_calibration: fixed some lines over
Deleted declaration of external functions that weren't used on this driver.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h
index 22bb264..8d41eed 100644
--- a/drive
This patch removes these sparse warnings found in the cls.c file:
warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] *addr
got unsigned char volatile *
warning: incorrect type in argument 2 (different address spaces)
expected void volatile
On Fri, Aug 23, 2013 at 4:23 PM, Dan Carpenter wrote:
> On Wed, Aug 21, 2013 at 09:48:38PM -0400, Lidza Louina wrote:
>> -static int dgap_tty_ioctl(struct tty_struct *tty, struct file *file,
>> unsigned int cmd,
>> +static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
>>
49 matches
Mail list logo