[PATCH 4/4] staging: comedi: ni_atmio16d: fix atmio16d_dio_insn_config()

2013-08-26 Thread H Hartley Sweeten
This is the (*insn_config) function for a DIO subdevice. It should be using the data[0] value as the "instruction" to perform on the subdevice. Use the comedi_dio_insn_config() helper to properly handle instructions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 2/4] staging: comedi: dt282x: fix dt282x_dio_insn_config()

2013-08-26 Thread H Hartley Sweeten
This is the (*insn_config) function for a DIO subdevice. It should be using the data[0] value as the "instruction" to perform on the subdevice. Use the comedi_dio_insn_config() helper to properly handle instructions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 1/4] staging: comedi: dt2817: fix dt2817_dio_insn_config()

2013-08-26 Thread H Hartley Sweeten
This is the (*insn_config) function for a DIO subdevice. It should be using the data[0] value as the "instruction" to perform on the subdevice. Use the comedi_dio_insn_config() helper to properly handle instructions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 0/4] staging: comedi: drivers: more users of comedi_dio_insn_config()

2013-08-26 Thread H Hartley Sweeten
These drivers all improperly implement the (*insn_config) for a DIO subdevice. They all treat the data[0] value as a flag to configure the channel in insn->chanspec as either an output or an input. The data[0] value is actually the 'instruction' to be performed on the channel. Use the comedi_di

[PATCH 3/4] staging: comedi: dmm32at: fix dmm32at_dio_insn_config()

2013-08-26 Thread H Hartley Sweeten
This is the (*insn_config) function for a DIO subdevice. It should be using the data[0] value as the "instruction" to perform on the subdevice. Use the comedi_dio_insn_config() helper to properly handle instructions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in the handling of channel offers

2013-08-26 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, August 26, 2013 4:14 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; sta...@vger.kernel.org > Sub

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in the handling of channel offers

2013-08-26 Thread Greg KH
On Mon, Aug 26, 2013 at 10:48:16PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Monday, August 26, 2013 2:57 PM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > > o...@aep

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in the handling of channel offers

2013-08-26 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, August 26, 2013 2:57 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; sta...@vger.kernel.org > Sub

[PATCH 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor

2013-08-26 Thread K. Y. Srinivasan
Hyper-V supports a mechanism for retrieving the local API frequency.Use this and bypass the calibration code in the kernel. This would allow us to boot the Linux kernel as a "modern VM" on Hyper-V where many of the legacy devices (such as PIT) are not emulated. I would like to thank Olaf Hering

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in the handling of channel offers

2013-08-26 Thread Greg KH
On Mon, Aug 26, 2013 at 02:08:58PM -0700, K. Y. Srinivasan wrote: > The channel state should be correctly set before registering the device. In > the current > code the driver probe would fail for channels that have been rescinded and > subsequently > re-offered. Fix the bug. > > Signed-off-by:

[PATCH 1/1] Drivers: hv: vmbus: Fix a bug in the handling of channel offers

2013-08-26 Thread K. Y. Srinivasan
The channel state should be correctly set before registering the device. In the current code the driver probe would fail for channels that have been rescinded and subsequently re-offered. Fix the bug. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/hv/channel_mgmt.c | 14 +++--- 1 f

[PATCH] staging: dgnc: tty.c: edits var in init func for sparse

2013-08-26 Thread Lidza Louina
This patch edits the vaddr variable in dgnc_tty_init. The variable gets set to board_t->re_map_membase. A previous patch changed the re_map_membase variable's marker and type. This patch makes sure that the changes are consistent and that it doesn't cause sparse warnings. Signed-off-by: Lidza Loui

[PATCH] staging: dgnc: neo.c: changes param in neo_read_eeprom function for sparse

2013-08-26 Thread Lidza Louina
This patch adds a marker to neo_read_eeprom function's base parameter. It removes these warnings found in neo.c: warning: incorrect type in argument 1 (different address spaces) expected unsigned char *base got unsigned char [noderef] [usertype] *re_map_membase warning: incorrect type in argu

[PATCH] staging: dgnc: cls.c: changes var in cls_vpd function for sparse

2013-08-26 Thread Lidza Louina
This patch changes cls_vpd function's re_map_vpdbase variable type and marker. It removes these warnings found in cls.c: warning: incorrect type in assignment (different address spaces) expected unsigned char [usertype] *re_map_vpdbase got void [noderef] * warning: incorrect type in argument

[PATCH] staging: dgnc: driver.h: changes a struct board_t var's type and marker for sparse

2013-08-26 Thread Lidza Louina
This patch changes the board_t->re_map_membase variable type and marker. It removes these warnings found in the neo.c, driver.c and cls.c files: warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef] *addr got unsigned char volatile * warning:

Re: [PATCH 05/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters

2013-08-26 Thread Joe Perches
On Mon, 2013-08-26 at 19:02 +0300, Dan Carpenter wrote: > On Mon, Aug 26, 2013 at 05:10:04PM +0200, Iker Pedrosa wrote: [] > > diff --git a/drivers/staging/winbond/phy_calibration.c > > b/drivers/staging/winbond/phy_calibration.c [] > > @@ -1233,8 +1233,10 @@ u8 _rx_iq_calibration_loop_winbond(str

Re: [PATCH 00/24] Staging: winbond: Fixed some coding style issues

2013-08-26 Thread Dan Carpenter
Btw, all the white space nit-pick I pointed out were pretty minor. I don't like making people redo stuff so you can fix anything you want to in later patches. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.l

Re: [PATCH 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters

2013-08-26 Thread Dan Carpenter
On Mon, Aug 26, 2013 at 05:10:22PM +0200, Iker Pedrosa wrote: > Fixed some lines over 80 characters. > > Signed-off-by: Iker Pedrosa > --- > drivers/staging/winbond/wbusb.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/winbond/wbusb.c

Re: [PATCH 09/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Dan Carpenter
On Mon, Aug 26, 2013 at 05:10:08PM +0200, Iker Pedrosa wrote: > @@ -926,7 +928,8 @@ static void Set_ChanIndep_RfData_al7230_24(struct hw_data > *pHwData, u32 *pltmp, > u8 i; > for (i = 0; i < number; i++) { > pHwData->phy_para[i] = al7230_rf_data_24[i]; > -

[PATCH 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '['

2013-08-26 Thread Iker Pedrosa
Erased the spaces that existed after opening some square brackets '['. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35tx_s.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond/wb35tx_s.h index 715f87d..dc

Re: [PATCH 09/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Dan Carpenter
On Mon, Aug 26, 2013 at 05:10:08PM +0200, Iker Pedrosa wrote: > First of the patches that fixes the lines over 80 characters in reg.c > > Signed-off-by: Iker Pedrosa > --- > drivers/staging/winbond/reg.c | 30 +- > 1 file changed, 17 insertions(+), 13 deletions(-) >

Re: [PATCH 05/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters

2013-08-26 Thread Dan Carpenter
On Mon, Aug 26, 2013 at 05:10:04PM +0200, Iker Pedrosa wrote: > Second of the patches that fixes the lines over 80 characters in > phy_calibration.c > > Signed-off-by: Iker Pedrosa > --- > drivers/staging/winbond/phy_calibration.c | 12 > 1 file changed, 8 insertions(+), 4 deletion

[PATCH] staging: dgnc: neo_uart_struct: adds marker and changes vars' types for sparse

2013-08-26 Thread Lidza Louina
This patch fixes these warnings found in the neo.c file: warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef] *addr got unsigned char volatile * warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef

[PATCH 16/24] Staging: winbond: wb35reg_f: fixed lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Fixed lines over 80 characters. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35reg_f.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/winbond/wb35reg_f.h b/drivers/staging/winbond/wb35reg_f.h index 95dc980..cd6710c 100644 ---

[PATCH 04/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
First of the patches that fixes the lines over 80 characters in phy_calibration.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/phy_calibration.c | 46 ++- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers/staging/winbond/phy_calibrati

[PATCH 07/24] Staging: winbond: reg: white space deleted

2013-08-26 Thread Iker Pedrosa
White space deleted before semicolons. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c index 5883d23..80b4b34 100644 --- a/drivers/staging/winbond/r

[PATCH 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Fixed some lines over 80 characters. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35rx.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c index 48ed95c..999b7046 100644 --- a/drivers/stagin

[PATCH 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep

2013-08-26 Thread Iker Pedrosa
According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 15/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Seventh of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c index

[PATCH 02/24] Staging: winbond: mto: avoided use of extern functions

2013-08-26 Thread Iker Pedrosa
Prototype of two functions added to the header to avoid the use of extern. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/mto.c | 4 +--- drivers/staging/winbond/mto.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/winbond/mto.c b/drivers/stagin

[PATCH 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep

2013-08-26 Thread Iker Pedrosa
According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wbusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation

2013-08-26 Thread Iker Pedrosa
Deleted an space before a tabulation. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35reg_s.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35reg_s.h b/drivers/staging/winbond/wb35reg_s.h index dc79faa..cdbbf35 100644 --- a/drivers/sta

[PATCH 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err

2013-08-26 Thread Iker Pedrosa
The previously used printk lacked the warning level, now we've got a more accurate way to know the error. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35tx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/stagi

[PATCH 11/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Third of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c i

[PATCH 13/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Fifth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.

[PATCH 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Fixed some lines over 80 characters. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wbusb.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c index 3fa1ae4..c128bc9 100644 --- a/drivers

[PATCH 09/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
First of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c i

[PATCH 10/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Second of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c

[PATCH 12/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Fourth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg

[PATCH 14/24] Staging: winbond: reg: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Sixth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c ind

[PATCH 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep

2013-08-26 Thread Iker Pedrosa
According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 52 +-- 1 file changed,

[PATCH 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep

2013-08-26 Thread Iker Pedrosa
According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 01/24] Staging: winbond: mto: removed function declaration

2013-08-26 Thread Iker Pedrosa
The following function declarations have been removed because they aren't implemented. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/mto.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c index 560c0ab..0d0f9fb 100644

[PATCH 06/24] Staging: winbond: reg: erased trailing whitespace

2013-08-26 Thread Iker Pedrosa
Erased all the errors given by checkpatch stating trailing whitespace. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c index 75b7752..5883d

[PATCH 05/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters

2013-08-26 Thread Iker Pedrosa
Second of the patches that fixes the lines over 80 characters in phy_calibration.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/phy_calibration.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond/phy_calibration.c b/drivers/stag

[PATCH 00/24] Staging: winbond: Fixed some coding style issues

2013-08-26 Thread Iker Pedrosa
Fixes some coding style issues from drivers/staging/winbond Iker Pedrosa (24): Staging: winbond: mto: removed function declaration Staging: winbond: mto: avoided use of extern functions Staging: winbond: mto: deleted extern functions Staging: winbond: phy_calibration: fixed some lines over

[PATCH 03/24] Staging: winbond: mto: deleted extern functions

2013-08-26 Thread Iker Pedrosa
Deleted declaration of external functions that weren't used on this driver. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/mto.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h index 22bb264..8d41eed 100644 --- a/drive

[PATCH] staging: dgnc: cls_uart_struct: adds marker and changes vars' types for sparse

2013-08-26 Thread Lidza Louina
This patch removes these sparse warnings found in the cls.c file: warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef] *addr got unsigned char volatile * warning: incorrect type in argument 2 (different address spaces) expected void volatile

Re: [PATCH 08/12] staging: dgap: tty.c: fixes ioctl param list

2013-08-26 Thread Lidza Louina
On Fri, Aug 23, 2013 at 4:23 PM, Dan Carpenter wrote: > On Wed, Aug 21, 2013 at 09:48:38PM -0400, Lidza Louina wrote: >> -static int dgap_tty_ioctl(struct tty_struct *tty, struct file *file, >> unsigned int cmd, >> +static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd, >>