Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

2013-08-08 Thread Joe Perches
On Thu, 2013-08-08 at 23:44 +0300, Dan Carpenter wrote: > On Thu, Aug 08, 2013 at 06:03:49PM +0100, Paul McQuade wrote: > > -int InterfaceFileDownload( PVOID psIntfAdapter, > > -struct file *flp, > > -unsigned int on_chip_loc); > > +int InterfaceFileD

Re: Review [2/2] Staging: BCM: Removed more whitespace/Errors

2013-08-08 Thread Joe Perches
On Thu, 2013-08-08 at 23:54 +0300, Dan Carpenter wrote: > Joe, these automated checkpatch.pl things are annoying. It's too > easy to flood maintainers with hundreds of patches. We need to > figure out how to make these things easier to review. I have yet to see anyone submit a patch using $ scri

Re: Review [2/2] Staging: BCM: Removed more whitespace/Errors

2013-08-08 Thread Dan Carpenter
Joe, these automated checkpatch.pl things are annoying. It's too easy to flood maintainers with hundreds of patches. We need to figure out how to make these things easier to review. regards, dan carpenter ___ devel mailing list de...@linuxdriverprojec

Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

2013-08-08 Thread Dan Carpenter
On Thu, Aug 08, 2013 at 06:03:49PM +0100, Paul McQuade wrote: > -int InterfaceFileDownload( PVOID psIntfAdapter, > -struct file *flp, > -unsigned int on_chip_loc); > +int InterfaceFileDownload(PVOID psIntfAdapter, > +

Re: [PATCH 1/2] Staging: BCM: removed whitespaces and Errors.

2013-08-08 Thread Dan Carpenter
This breaks the compile. It's doing too many things at once as well. Do one type of white space fix at a time. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverde

Re: [PATCH] Staging:BCM:DDRInit.c:Replacing __FUNCTION__

2013-08-08 Thread Dan Carpenter
Please send patches inline instead of as attachments. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Review [2/2] Staging: BCM: Removed more whitespace/Errors

2013-08-08 Thread Joe Perches
On Thu, 2013-08-08 at 18:35 +0100, Paul McQuade wrote: > From 9f6231ce16996e35545e20ce1d91abc058f2a6fb Mon Sep 17 00:00:00 2001 > From: Paul McQuade > Date: Thu, 8 Aug 2013 17:49:22 +0100 > Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors > > Interface Whitespace/Errors Removed

[PATCH] Staging:zram:zram_drv.c Fixed Error of trailing whitespace

2013-08-08 Thread Kumar Gaurav
Fixed by removing trailing whitespace Signed-off-by: Kumar Gaurav --- drivers/staging/zram/zram_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index 82c7202..f590715 100644 --- a/drivers/staging/zram/

Review [2/2] Staging: BCM: Removed more whitespace/Errors

2013-08-08 Thread Paul McQuade
From 9f6231ce16996e35545e20ce1d91abc058f2a6fb Mon Sep 17 00:00:00 2001 From: Paul McQuade Date: Thu, 8 Aug 2013 17:49:22 +0100 Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors Interface Whitespace/Errors Removed with the help of checkpatch.pl Signed-off-by: Paul McQuade --- d

Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

2013-08-08 Thread Joe Perches
Please send your changes with an email client that does not require attaching patches. On Thu, 2013-08-08 at 18:03 +0100, Paul McQuade wrote: > -#define MAXIMUM_USB_TCB 128 > -#define MAXIMUM_USB_RCB 128 > +#define MAXIMUM_USB_TCB128 > +#define MAXIMUM_USB_RCB

[PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

2013-08-08 Thread Paul McQuade
>From 9f6231ce16996e35545e20ce1d91abc058f2a6fb Mon Sep 17 00:00:00 2001 From: Paul McQuade Date: Thu, 8 Aug 2013 17:49:22 +0100 Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors Interface Whitespace/Errors Removed with the help of checkpatch.pl Signed-off-by: Paul McQuade ---

[PATCH 1/2] Staging: BCM: removed whitespaces and Errors.

2013-08-08 Thread Paul McQuade
>From 6e70cd8754968f37e82f6a4d8b9da75ff6e0 Mon Sep 17 00:00:00 2001 From: Paul McQuade Date: Thu, 8 Aug 2013 16:09:46 +0100 Subject: [PATCH 1/2] Staging: BCM: removed whitespaces and Errors. BCM Driver had a lot of whitespaces and errors. Some of them are removed by this patch. Signed-off-

Re: [PATCH v2] staging/lustre: lloop depends on BLOCK

2013-08-08 Thread Christoph Hellwig
On Wed, Aug 07, 2013 at 07:45:17AM +, Dilger, Andreas wrote: > The problem still remains that the kernel loop driver eventually depends on > a local block device for the pages/bios to be written. The Lustre lloop > driver bypasses the VFS and block layer to generate RPCs from the submitted > p

[PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value after doing dev_alloc_skb

2013-08-08 Thread Iker Pedrosa
Checking the return of dev_alloc_skb as stated in the following bug: https://bugzilla.kernel.org/show_bug.cgi?id=60401 Signed-off-by: Iker Pedrosa --- drivers/staging/rtl8192e/rtllib_rx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/sta