On Tue, 2013-08-06 at 19:55 -0700, Joe Perches wrote:
> Previous attempt at fixing SPACING errors could
> make a hash of several defects.
I have run this against drivers/staging/...
It works rather better than the older version.
It does have an issue with c99 style comments
when it needs to rewr
On Tuesday, August 06, 2013 9:32 AM, H Hartley Sweeten wrote:
> Convert this driver to use the comedi_dio_insn_config() helper function.
>
> Tidy up the comments to reflect the new code.
>
> Signed-off-by: H Hartley Sweeten
> Reviewed-by: Ian Abbott
> Cc: Greg Kroah-Hartman
Oops.. This is the v
Convert the drivers with complex, port programmable i/o, to use the
comedi_dio_insn_config() helper function.
All of these drivers have some sort of 'port' programmable i/o where multiple
i/o channels are configured as a group. The 'mask' associated with the group
is passed to comedi_dio_insn_conf
Convert this driver to use the comedi_dio_insn_config() helper function.
Tidy up the comments to reflect the new code.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/skel.c | 42 ---
1 file cha
Convert the drivers with simple, per channel programmable i/o, to use the
comedi_dio_insn_config() helper function.
All of these pass a 'mask' of '0' to comedi_dio_insn_config() this causes
the per channel mask to be used to configure the i/o direction.
Signed-off-by: H Hartley Sweeten
Cc: Ian A
DIO subdevices always handle the INSN_CONFIG_DIO_{INPUT,OUTPUT} instructions
to configure the DIO channels. They also always handle the INSN_CONFIG_DIO_QUERY
instruction to query the configuration of a DIO channel.
Introduce a helper function to handle the (*insn_config) boilerplate for
comedi DIO
All the comedi drivers that have DIO subdevices implement a (*insn_config)
callback. This callback always handles the INSN_CONFIG_DIO_{INPUT,OUTPUT}
instructions to configure the DIO channels. They also always handle the
INSN_CONFIG_DIO_QUERY instruction to query the configuration of a DIO channel.
On Tuesday, August 06, 2013 9:07 AM, H Hartley Sweeten wrote:
> On Tuesday, August 06, 2013 6:38 AM, Ian Abbott wrote:
>> This won't work for ni_65xx as the DIO subdevice has 96 channels, but
>> s->io_bits only supports 32 channels.
>
> Ah, I thought I caught all the > 32 channel uses. Missed this
On Tuesday, August 06, 2013 6:38 AM, Ian Abbott wrote:
> On 2013-08-05 23:01, H Hartley Sweeten wrote:
>> Convert the drivers with simple, per channel programmable i/o, to use the
>> comedi_dio_insn_config() helper function.
>>
>> All of these pass a 'mask' of '0' to comedi_dio_insn_config() this c
On 2013-08-05 23:01, H Hartley Sweeten wrote:
Convert the drivers with complex, port programmable i/o, to use the
comedi_dio_insn_config() helper function.
All of these drivers have some sort of 'port' programmable i/o where multiple
i/o channels are configured as a group. The 'mask' associated
On 2013-08-05 23:00, H Hartley Sweeten wrote:
Convert this driver to use the comedi_dio_insn_config() helper function.
Tidy up the comments to reflect the new code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.
On 2013-08-05 23:00, H Hartley Sweeten wrote:
DIO subdevices always handle the INSN_CONFIG_DIO_{INPUT,OUTPUT} instructions
to configure the dio channels. They also always handle the INSN_CONFIG_DIO_QUERY
instruction to query the configuration of a dio channel.
Introduce a helper function to hand
On 2013-08-05 23:01, H Hartley Sweeten wrote:
Convert the drivers with simple, per channel programmable i/o, to use the
comedi_dio_insn_config() helper function.
All of these pass a 'mask' of '0' to comedi_dio_insn_config() this causes
the per channel mask to be used to configure the i/o directi
On Tue, Aug 06, 2013 at 11:26:14AM +0100, Rupesh Gujare wrote:
> I will work on it, once this patch series is applied to staging tree.
>
> I am assuming that you have no objection for it, & I will follow up
> with above style nits in follow on patches.
Yes. That's fine.
regards,
dan carpenter
On 05/08/13 21:23, Dan Carpenter wrote:
On Mon, Aug 05, 2013 at 07:43:16PM +0100, Rupesh Gujare wrote:
On 05/08/13 18:53, Dan Carpenter wrote:
On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote:
This patch fixes crash issue when there is quick cycle of
de-enumeration & enumeration d
I send it. If you haven't received it, maybe you have misplaced it, you can
look at it in the following archive:
http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg480978.html
On Mon, 5 Aug 2013 18:22:48 +
justin mattock wrote:
> where patch #2?
>
>
>
> Justin P. Mattock
>
>
16 matches
Mail list logo
