version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lustre/libcfs/linux/linux-debug.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
b/drivers/staging/lustre/lus
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lnet/klnds/socklnd/socklnd_lib-linux.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.h
b/drivers/staging/lustr
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/llite/dir.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/dir.c
b/drivers/staging/lustre/lustre/llite/dir.c
index a9
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/llite/super25.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/super25.c
b/drivers/staging/lustre/lustre/llite/super2
The usage of strict_strto*() is not preferred, because
strict_strto*() is obsolete. Thus, kstrto*() should be
used.
Previously, there were only strict_strtol(), strict_strtoul(),
strict_strtoull(), and strict_strtoll(). Thus, when converting
to the variables, only long, unsigned long, unsigned lon
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtos32() should be
used in order to convert a string to s32. Also, error handling
is added to get rid of a __must_check warning.
Signed-off-by: Jingoo Han
---
drivers/staging/tidspbridge/pmgr/dbll.c |
On Tuesday, July 23, 2013 8:03 PM, Dan Carpenter wrote:
>
> The following test program illustrates the memory corruption. You
> would hope foo.b would be 42 but it is corrupted to -1.
>
> #include
> #include
>
> struct foo {
> int a, b;
> };
>
> void kstrtol(long *x)
> {
> *x = -
On Tue, Jul 23, 2013 at 11:43:52AM +0300, Dan Carpenter wrote:
> On Tue, Jul 23, 2013 at 04:40:29PM +0900, Won Kang wrote:
> > Thank you so much for the review. I will try to fix them soon.
> > Should I continue to send patches until reviewers agrees to accept
> > them? I have no experience with su
On Wed, Jul 17, 2013 at 12:35:46PM -0700, Paul Zimmerman wrote:
> The transfer scheduler in the dwc2 driver is pretty basic, not to
> mention buggy. It works fairly well with just a couple of devices
> plugged in, but if you add, say, multiple devices with periodic
> endpoints, the scheduler breaks
On Thu, Jul 11, 2013 at 10:23:57AM +0300, Andy Shevchenko wrote:
>
> Do we have typo in the MAINTAINERS file? I have got mail delivery
> rejection for the de...@driverdev.osuosl.org.
No, the list was down, it should be back up now...
thanks,
greg k-h
On Mon, Jul 08, 2013 at 07:33:48PM +0300, Aldo Iljazi wrote:
> Fixed a coding style issue, specifically checkpatch.pl complain:
> ossiRelease.c:27: WARNING: line over 80 characters
>
> Signed-off-by: Aldo Iljazi
> ---
> drivers/staging/cxt1e1/ossiRelease.c |3 ++-
> 1 file changed, 2 inserti
On Thu, Jun 27, 2013 at 03:34:52PM +0530, navin patidar wrote:
> dev_warn() is preferred over pr_warning().
>
> container_of() is used to get usb_driver pointer from usbip_device container
> (stub_device or vhci_device), to get device structure required for dev_warn().
>
> Signed-off-by: navin pa
On Fri, Jun 21, 2013 at 10:54:40PM -0300, Raphael S. Carvalho wrote:
> Well, there is no need to use strcmp since we can make a test of similar
> semantic by using the var_id field of param.
> I moved the test into the VAR_NUM:VAR_TIME case since VAR_STRING will
> never be "voice".
>
> spk_xlate i
Here is another bit of cleaning up the devm usage. It is again removing the
resource check with devm_ioremap_resource, because a) new drivers came in and
b) coccinelle had a bug and missed to find a couple of occasions. Unlike last
time, I think it is better if these patches go in via the subsystem
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang
---
Please apply via the subsystem-tree.
drivers/staging/imx-drm/imx-tve.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-
On Tue, 2013-07-23 at 09:42 -0700, Joe Perches wrote:
> On Tue, 2013-07-23 at 19:51 +0800, Lilis Iskandar wrote:
> > Fixed spacing/tabs issues that were found using checkpatch.
>
> Hi Lilis.
>
> It'd be better to change the email subject to
> "[PATCH v2] etc..." to show that's it's a new
> versio
> -Original Message-
> From: Dave Hansen [mailto:dave.han...@intel.com]
> Sent: Tuesday, July 23, 2013 12:01 PM
> To: KY Srinivasan
> Cc: Michal Hocko; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> a...@firs
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, July 23, 2013 12:02 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de;
> a...@canonical.com; a...@firstfloor.org; a...@linux-foundation.org; l
On Tue, 2013-07-23 at 19:51 +0800, Lilis Iskandar wrote:
> Fixed spacing/tabs issues that were found using checkpatch.
Hi Lilis.
It'd be better to change the email subject to
"[PATCH v2] etc..." to show that's it's a new
version of the patch.
It's also useful to add a note or two like
"git diff
On Fri, Jul 19, 2013 at 12:23:05PM -0700, K. Y. Srinivasan wrote:
> The current machinery for hot-adding memory requires having udev
> rules to bring the memory segments online. Export the necessary functionality
> to to bring the memory segment online without involving user space code.
>
> Signe
On 07/23/2013 08:54 AM, KY Srinivasan wrote:
>> > Adding memory usually requires allocating some large, contiguous areas
>> > of memory for use as mem_map[] and other VM structures. That's really
>> > hard to do under heavy memory pressure. How are you accomplishing this?
> I cannot avoid failure
> -Original Message-
> From: Dave Hansen [mailto:dave.han...@intel.com]
> Sent: Tuesday, July 23, 2013 11:28 AM
> To: KY Srinivasan
> Cc: Michal Hocko; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> a...@firs
> -Original Message-
> From: Michal Hocko [mailto:mho...@suse.cz]
> Sent: Tuesday, July 23, 2013 11:10 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> a...@firstfloor.org; a...@lin
On 07/23/2013 07:52 AM, KY Srinivasan wrote:
> The current scheme of involving user
> level code to close this loop obviously does not perform well under high
> memory pressure.
Adding memory usually requires allocating some large, contiguous areas
of memory for use as mem_map[] and other VM str
On Tue, Jul 23, 2013 at 07:51:02PM +0800, Lilis Iskandar wrote:
> Fixed spacing/tabs issues that were found using checkpatch.
>
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://
On Tue 23-07-13 14:52:36, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Michal Hocko [mailto:mho...@suse.cz]
> > Sent: Monday, July 22, 2013 8:37 AM
> > To: KY Srinivasan
> > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> > de...@linuxdriverproject.org; o...@a
> -Original Message-
> From: Michal Hocko [mailto:mho...@suse.cz]
> Sent: Monday, July 22, 2013 8:37 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> a...@firstfloor.org; a...@linux
From: Joe Perches
Rename Kbuild to usual Makefile, consistent with
Kernel build structure.
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/Kbuild | 16
drivers/staging/ozwpan/Makefile | 16
2 files changed, 16 insertio
From: Joe Perches
Replace macro with inline function.
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozurbparanoia.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozurbparanoia.h
b/drivers/staging/ozwpan/
From: Joe Perches
Remove unnecessary debug logs. Most of these logs
print function name at the start of function, which
are not really required.
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c |2 --
drivers/staging/ozwpan/ozhcd.c | 28 ++
From: Joe Perches
Remove old oz_trace & oz_trace2 macro & related header files.
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/Kbuild |6 ++
drivers/staging/ozwpan/ozcdev.c|2 --
drivers/staging/ozwpan/ozconfig.h | 26 ---
This is v3 of this original patch series here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-June/039280.html
v3 adds commit log for each patch as suggested by Joe here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-July/039361.html
Joe Perches
Fixed spacing/tabs issues that were found using checkpatch.
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/Qos.c | 538 +++---
1 file changed, 269 insertions(+), 269 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
in
On 07/23/2013 01:26 PM, Dan Carpenter wrote:
> On Tue, Jul 23, 2013 at 07:19:03PM +0900, Jingoo Han wrote:
>> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> index 38a158b..03766bb 100644
>> --- a/drivers/staging/iio/trigger/
On Tue, Jul 23, 2013 at 07:19:03PM +0900, Jingoo Han wrote:
> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> index 38a158b..03766bb 100644
> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> +++ b/drivers/staging/iio/t
The following test program illustrates the memory corruption. You
would hope foo.b would be 42 but it is corrupted to -1.
#include
#include
struct foo {
int a, b;
};
void kstrtol(long *x)
{
*x = -1;
}
int main(void)
{
struct foo foo;
foo.b = 42;
kstrt
On Tue, Jul 23, 2013 at 07:19:03PM +0900, Jingoo Han wrote:
> The usage of strict_strto*() is not preferred, because
> strict_strto*() is obsolete. Thus, kstrto*() should be
> used.
In olden times there was just strict_strtol() and strict_strtoul().
These days we have kstrtou8() and kstrtoint() an
On Tuesday, July 23, 2013 7:34 PM, Dan Carpenter wrote:
> On Tue, Jul 23, 2013 at 07:16:21PM +0900, Jingoo Han wrote:
> > The usage of strict_strtol() is not preferred, because
> > strict_strtol() is obsolete. Thus, kstrtol() should be
> > used.
> >
> > Signed-off-by: Jingoo Han
> > ---
> > drive
On Tue, Jul 23, 2013 at 07:16:21PM +0900, Jingoo Han wrote:
> The usage of strict_strtol() is not preferred, because
> strict_strtol() is obsolete. Thus, kstrtol() should be
> used.
>
> Signed-off-by: Jingoo Han
> ---
> drivers/staging/tidspbridge/pmgr/dbll.c |6 --
> 1 file changed, 4 i
The usage of strict_strto*() is not preferred, because
strict_strto*() is obsolete. Thus, kstrto*() should be
used.
Signed-off-by: Jingoo Han
---
drivers/staging/iio/accel/sca3000_core.c |4 ++--
drivers/staging/iio/accel/sca3000_ring.c |2 +-
drivers/staging/iio/adda
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be
used.
Signed-off-by: Jingoo Han
---
drivers/staging/tidspbridge/pmgr/dbll.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/pmgr/
On Tue, Jul 23, 2013 at 06:10:41PM +0800, Lilis Iskandar wrote:
> Hi Dan,
>
> I have already accepted my fate when I submitted the patch. Though it's
> really great that I receive a response so fast :)
>
> Regarding the braces, I thought it would be more readable that way
> because of the long co
Hi Dan,
I have already accepted my fate when I submitted the patch. Though it's
really great that I receive a response so fast :)
Regarding the braces, I thought it would be more readable that way
because of the long code wrapping inside the "if" parameter. I'll fix it
and send the patches again
Hi hi,
Welcome first time submitter newbie. :) The tradition is to reject
first time code submissions in the meanest and grumpiest way
possible.
On Tue, Jul 23, 2013 at 05:20:29PM +0800, Lilis Iskandar wrote:
> >From a2f8b299baee0e075d548d2bbf77619373035446 Mon Sep 17 00:00:00 2001
> From: Lili
>From a2f8b299baee0e075d548d2bbf77619373035446 Mon Sep 17 00:00:00 2001
From: Lilis Iskandar
Date: Tue, 23 Jul 2013 17:08:37 +0800
Subject: [PATCH] Staging: bcm: Qos: Fix some coding style issues
Fix some coding style issues.
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/Qos.c | 600 ++
On Tue, Jul 23, 2013 at 04:40:29PM +0900, Won Kang wrote:
> Thank you so much for the review. I will try to fix them soon.
> Should I continue to send patches until reviewers agrees to accept
> them? I have no experience with submitting codes, and just not sure
> how to follow up. it's first time f
46 matches
Mail list logo
