On 2013-06-27 17:08, Ian Abbott wrote:
The "ni_labpc" module acts as a low-level comedi driver for various
National Instruments Lab-PC ISA cards if `CONFIG_NI_LABPC_ISA` is
enabled, and also as a common module depended on by the "ni_labpc_cs"
and "ni_labpc_pci" modules. For ISA cards, it optiona
The "ni_labpc" module acts as a low-level comedi driver for various
National Instruments Lab-PC ISA cards if `CONFIG_NI_LABPC_ISA` is
enabled, and also as a common module depended on by the "ni_labpc_cs"
and "ni_labpc_pci" modules. For ISA cards, it optionally supports the
use of an ISA DMA channe
'Unregister' functions generally return `void`.
`comedi_driver_unregister()` currently returns an `int` errno value.
Nothing looks at the return value. Change the return type to `void`.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 2 +-
drivers/staging/comedi/drivers.c |
A couple of patches to Comedi's driver list code. Patch 1 just changes
the return type on an unregister function to `void`. Patch 2 uses a
mutex for accessing the driver list.
1) staging: comedi: return void from comedi_driver_unregister()
2) staging: comedi: use a mutex when accessing driver li
Low-level comedi drivers registered with the comedi core by
`comedi_driver_register()` are linked together into a simple linked list
headed by the `comedi_drivers` variable and chained by the `next` member
of `struct comedi_driver`. A driver is removed from the list by
`comedi_driver_unregister()`
[Originally posted 2013-06-26. Reposting to new driverdev-devel list.]
On 2013-06-25 18:38, H Hartley Sweeten wrote:
On Tuesday, June 25, 2013 2:16 AM, Ian Abbott wrote:
On 2013-06-25 01:07, H Hartley Sweeten wrote:
The Intelligent Instrumentation PCI-20001C board is a legacy PC/XT/AT
8-bit I
[Originally posted 2013-06-25. Reposting to new driverdev-devel list.]
On 2013-06-25 01:04, H Hartley Sweeten wrote:
comedidev.h is the main kernel header for comedi. Every comedi
driver includes this header which then includes a number of
headers. All the drivers need and some
of them need .
[Originally posted 2013-06-25. Reposting to new driverdev-devel list.]
On 2013-06-25 00:54, H Hartley Sweeten wrote:
The comedi core automatically kfree()'s the device private data during
the (*detach) of the drivers. The kzalloc() in the drivers produces a
smatch warning due to the missing kfr
[Originally posted 2013-06-25. Reposting to new driverdev-devel list.]
On 2013-06-25 00:23, H Hartley Sweeten wrote:
During the attach of this driver, it's possible for the allocation
of the subdevice private data to fail. It's also possible that the
io region was not successfully requested.
V
[Originally posted 2013-06-25. Reposting to new driverdev-devel list.]
On 2013-06-25 01:11, H Hartley Sweeten wrote:
The only difference in the if() and else if() check of the chanlist
is the source of the range table length. Consolidate the checks to
make the function a bit more concise.
Sign
[Originally posted 2013-06-25. Reposting to new driverdev-devel list.]
On 2013-06-25 01:09, H Hartley Sweeten wrote:
This driver can support the WinSystems PCM-IO48 PC/104 board. That
board has two 8255 devices providing 48 digital I/O channels.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
[Originally posted 2013-06-24. Reposting to new driverdev-devel list.]
On 2013-06-23 16:09, Masanari Iida wrote:
Correct spelling typo in printk and comment
within staging/comedi.
Singed-off-by: Masanari Iida
---
drivers/staging/comedi/drivers/addi-data/APCI1710_Tor.c | 8
drivers
[Originally posted 2013-06-25. Reposting to new driverdev-devel list.]
On 2013-06-25 01:07, H Hartley Sweeten wrote:
The Intelligent Instrumentation PCI-20001C board is a legacy PC/XT/AT
8-bit ISA board not a PCI board. The "PCI" appears to mean "Personal
Computer Instrumentation".
Move the K
[Originally posted 2013-06-20. Reposting to new driverdev-devel list.]
On 2013-06-20 10:44, Ian Abbott wrote:
On 2013/06/19 09:43 PM, H Hartley Sweeten wrote:
On Wednesday, June 19, 2013 10:28 AM, Ian Abbott wrote:
On 2013-06-19 17:22, H Hartley Sweeten wrote:
On Wednesday, June 19, 2013 9:0
[Originally posted 2013-06-21. Reposting to new driverdev-devel list.]
On 2013-06-20 18:07, H Hartley Sweeten wrote:
On Thursday, June 20, 2013 2:50 AM, Ian Abbott wrote:
On 2013/06/19 11:24 PM, H Hartley Sweeten wrote:
As suggested by Ian Abbott, comedi_set_spriv() can only be used to
set th
[Originally posted 2013-06-20. Reposting to new driverdev-devel list.]
On 2013/06/19 11:24 PM, H Hartley Sweeten wrote:
As suggested by Ian Abbott, comedi_set_spriv() can only be used to
set the subdevice->private pointer to something that can be kfree()'d.
Rename the function to comedi_alloc_s
[Originally posted 2013-06-20. Reposting to new driverdev-devel list.]
On 2013/06/19 09:43 PM, H Hartley Sweeten wrote:
On Wednesday, June 19, 2013 10:28 AM, Ian Abbott wrote:
On 2013-06-19 17:22, H Hartley Sweeten wrote:
On Wednesday, June 19, 2013 9:09 AM, Ian Abbott wrote:
On 2013-06-18 2
[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-19 17:22, H Hartley Sweeten wrote:
On Wednesday, June 19, 2013 9:09 AM, Ian Abbott wrote:
On 2013-06-18 21:20, H Hartley Sweeten wrote:
Clean up and simplify this legacy driver.
The async command support (inter
[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-19 14:47, Ian Abbott wrote:
On 2013-06-18 21:21, H Hartley Sweeten wrote:
Introduce a helper function to handle writing a 24-bit value to the
three 8-bit registers associated with a "port" or "page".
Signed-off-
[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-18 21:20, H Hartley Sweeten wrote:
Clean up and simplify this legacy driver.
The async command support (interrupts) still needs a bit of work.
The command support is a bit goofy and does not really follow the
com
[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-18 20:13, H Hartley Sweeten wrote:
Due to the cleanup of the add-data drivers some of the "common" code is
no longer needed. Tidy it up a bit.
H Hartley Sweeten (6):
staging: comedi: addi-data: remove unused v
[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-19 16:10, Ian Abbott wrote:
On 2013-06-18 21:23, H Hartley Sweeten wrote:
The number of subdevices needed by the driver is based on the
'num_asics' reported by the boardinfo and each subdevice always
has 24 chann
[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-18 21:23, H Hartley Sweeten wrote:
The number of subdevices needed by the driver is based on the
'num_asics' reported by the boardinfo and each subdevice always
has 24 channels. Simplify the attach a bit.
We cou
[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-18 21:24, H Hartley Sweeten wrote:
Only subdevices 0 and 2 support interrupts. Simplify the attach
a bit.
Again, could define SUBDEVS_PER_ASIC as 2.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg K
[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-18 21:21, H Hartley Sweeten wrote:
Introduce a helper function to handle writing a 24-bit value to the
three 8-bit registers associated with a "port" or "page".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
C
[Originally posted 2013-06-17. Reposting to new driverdev-devel list.]
On 2013-06-13 00:03, H Hartley Sweeten wrote:
Separate this driver from the addi-data "common" code so the bloat
can be removed.
Cleanup all the subdevice support functions and fix the analog input
subdevice so it works cor
[Originally posted 2013-06-13. Reposting to new driverdev-devel list.]
On 2013-06-11 19:32, H Hartley Sweeten wrote:
Introduce a new subdevice runflags, SRF_FREE_SPRIV, and a new helper
function, comedi_set_spriv(), that the drivers can use to set the
comedi_subdevice private data pointer. The
> -Original Message-
> From: Tomas Hozza [mailto:tho...@redhat.com]
> Sent: Thursday, June 27, 2013 7:53 AM
> To: gre...@linuxfoundation.org
> Cc: jasow...@redhat.com; de...@linuxdriverproject.org; KY Srinivasan; Haiyang
> Zhang; Tomas Hozza
> Subject: [PATCH 3/3] tools: hv: Check return
> -Original Message-
> From: Tomas Hozza [mailto:tho...@redhat.com]
> Sent: Thursday, June 27, 2013 7:53 AM
> To: gre...@linuxfoundation.org
> Cc: jasow...@redhat.com; de...@linuxdriverproject.org; KY Srinivasan; Haiyang
> Zhang; Tomas Hozza
> Subject: [PATCH 2/3] tools: hv: Check return
> -Original Message-
> From: Tomas Hozza [mailto:tho...@redhat.com]
> Sent: Thursday, June 27, 2013 7:53 AM
> To: gre...@linuxfoundation.org
> Cc: jasow...@redhat.com; de...@linuxdriverproject.org; KY Srinivasan; Haiyang
> Zhang; Tomas Hozza
> Subject: [PATCH 1/3] tools: hv: Improve error
- Original Message -
> On Thu, Jun 27, 2013 at 5:22 PM, Tomas Hozza wrote:
> > Check return value of poll call and if it fails print error to the
> > system log. If errno is EINVAL then exit with non-zero value otherwise
> > continue the while loop and call poll again.
> >
> > Signed-off-b
On Thu, Jun 27, 2013 at 5:22 PM, Tomas Hozza wrote:
> Check return value of poll call and if it fails print error to the
> system log. If errno is EINVAL then exit with non-zero value otherwise
> continue the while loop and call poll again.
>
> Signed-off-by: Tomas Hozza
> ---
> tools/hv/hv_vss_
Check return value of poll call and if it fails print error to the
system log. If errno is EINVAL then exit with non-zero value otherwise
continue the while loop and call poll again.
Signed-off-by: Tomas Hozza
---
tools/hv/hv_vss_daemon.c | 11 ++-
1 file changed, 10 insertions(+), 1 del
Check return value of setsockopt call and if it fails print error to the
system log and exit with non-zero value.
Signed-off-by: Tomas Hozza
---
tools/hv/hv_vss_daemon.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
i
Use errno and strerror() when logging errors to provide more
information.
Signed-off-by: Tomas Hozza
---
tools/hv/hv_vss_daemon.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
index fea03a3..64112e1 100644
--- a
> -Original Message-
> From: James Bottomley [mailto:jbottom...@parallels.com]
> Sent: Wednesday, June 26, 2013 11:22 PM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com; h...@infradead.org; linux-
> s...@
36 matches
Mail list logo
