Re: [PATCH V3 0/5] Drivers: scsi: storvsc

2013-06-26 Thread James Bottomley
On Wed, 2013-06-26 at 12:58 +, KY Srinivasan wrote: > > > -Original Message- > > From: KY Srinivasan > > Sent: Monday, June 17, 2013 9:32 AM > > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; >

Re: [PATCH 3/5] Drivers: scsi: storvsc: Implement multi-channel support

2013-06-26 Thread James Bottomley
On Tue, 2013-06-04 at 12:05 -0700, K. Y. Srinivasan wrote: > Implement multi-channel support for the storage devices. This doesn't compile: CC [M] drivers/scsi/storvsc_drv.o drivers/scsi/storvsc_drv.c: In function ‘handle_sc_creation’: drivers/scsi/storvsc_drv.c:763:35: error: ‘struct vmbus_ch

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 13:46 -0400, Jason Baron wrote: > echo "grouping control_var level N +p" > /debugfs/dynamic_debug/control > > or > > echo "grouping control_var mask 0xN +p" > /debugfs/dynamic_debug/control > > So we can think of the 'control_var' as 'grouping' debug statements > together.

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 02:03 PM, Joe Perches wrote: > (Using Jason Baron's most current email address) > > On Tue, 2013-06-25 at 10:56 -0700, Joe Perches wrote: >> On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote: >>> On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote: a long needed extension

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 01:29 PM, Joe Perches wrote: > On Tue, 2013-06-25 at 10:02 -0700, Greg KH wrote: >> On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: >>> convert all debug messages from printk to dev_dbg() & add kernel config to >>> enable/disable these messages during compilation. >> No

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 06:56 -0700, Joe Perches wrote: > On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote: > > Above macros look good, however Greg have objection to define new macros > > & he had suggested to use dev_dbg() & pr_debug(). These macros already use pr_debug and should use dev_d

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote: > On 26/06/13 02:00, Joe Perches wrote: > > Use a normal Makefile. > > Convert oz_trace and oz_trace2 to a more normal oz_dbg. > > Consolidate oztrace and ozconfig files to ozdbg.h > > Update #include files. > > Reflow modified lines, fit to 8

RE: [PATCH V3 0/5] Drivers: scsi: storvsc

2013-06-26 Thread KY Srinivasan
> -Original Message- > From: KY Srinivasan > Sent: Monday, June 17, 2013 9:32 AM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; > h...@infradead.org; linux-s...@vger.kernel.org > Subject: RE: [PAT

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Rupesh Gujare
On 26/06/13 02:00, Joe Perches wrote: Use a normal Makefile. Convert oz_trace and oz_trace2 to a more normal oz_dbg. Consolidate oztrace and ozconfig files to ozdbg.h Update #include files. Reflow modified lines, fit to 80 cols, align arguments. Add a couple more oz__dbg macros to show how more

Re: [PATCH 2/2 v3] silicom: checkpatch: assignments in if conditions

2013-06-26 Thread Lorenz Kernel
Quoting Greg KH : On Wed, Jun 19, 2013 at 10:44:04AM +0200, Lorenz Haspel wrote: Fixes checkpatch error: There were assignments in if conditions, so I extracted them. Signed-off-by: Lorenz Haspel Signed-off-by: Michael Banken --- v2: removed some buggy extra lines and fixed white space issue