Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-11 Thread tang pengchuan
Daniel Vetter 于2019年12月10日周二 下午6:41写道: > On Tue, Dec 10, 2019 at 04:36:29PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > Adds drm support for the Unisoc's display subsystem. > > > > This is drm device and gem driver. This driver provides support for the > > Direct Rendering Infrastructu

Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-11 Thread tang pengchuan
Hi Thomas Zimmermann 于2019年12月10日周二 下午8:47写道: > Hi > > Am 10.12.19 um 13:38 schrieb tang pengchuan: > > Hi > > > > Thomas Zimmermann mailto:tzimmerm...@suse.de>> 于 > > 2019年12月10日周二 下午6:33写道: > > > > Hi > > > > Am 1

Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-11 Thread tang pengchuan
Hi Thomas Thomas Zimmermann 于2019年12月10日周二 下午8:47写道: > Hi > > Am 10.12.19 um 13:38 schrieb tang pengchuan: > > Hi > > > > Thomas Zimmermann mailto:tzimmerm...@suse.de>> 于 > > 2019年12月10日周二 下午6:33写道: > > > > Hi > > > > Am 1

Re: [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver

2019-12-11 Thread tang pengchuan
Hi Emil Velikov 于2019年12月11日周三 上午1:14写道: > Hi Kevin, > > On Tue, 10 Dec 2019 at 08:41, Kevin Tang wrote: > > > > From: Kevin Tang > > > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and > mo

Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-11 Thread tang pengchuan
Hi Thomas Zimmermann 于2019年12月10日周二 下午6:33写道: > Hi > > Am 10.12.19 um 09:36 schrieb Kevin Tang: > > From: Kevin Tang > > > > Adds drm support for the Unisoc's display subsystem. > > > > This is drm device and gem driver. This driver provides support for the > > Direct Rendering Infrastructure (

Re: [PATCH RFC 0/8] Add Unisoc's drm kms module

2019-12-13 Thread tang pengchuan
HI Sam Sam Ravnborg 于2019年12月11日周三 上午2:54写道: > Hi Kevin. > > Thanks for this new driver. > A few somments triggered alone from the diffstat. > > Kevin Tang (8): > > dt-bindings: display: add Unisoc's drm master bindings > > drm/sprd: add Unisoc's drm kms master > > dt-bindings: display: ad

Re: [PATCH RFC v1 2/6] drm/sprd: add Unisoc's drm kms master

2020-01-08 Thread tang pengchuan
Hi Thomas, Our soc needs to support both cma and iommu, but our iommu is not ready for upload, so i remove it from sprd_gem.c So can i upload the cma code first? and add iommu support later On Mon, Jan 6, 2020 at 6:11 PM Thomas Zimmermann wrote: > Hi Kevin > > Am 16.12.19 um 12:40 schrieb Kevin

Re: [PATCH RFC v3 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-02-24 Thread tang pengchuan
On Sat, Feb 22, 2020 at 5:39 AM Sam Ravnborg wrote: > Hi Kevin. > > On Fri, Feb 21, 2020 at 03:48:53PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > DPU (Display Processor Unit) is the Display Controller for the Unisoc > SoCs > > which transfers the image data from a video memory buffer

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

2020-02-24 Thread tang pengchuan
On Sun, Feb 23, 2020 at 12:26 PM tang pengchuan wrote: > > > On Sun, Feb 23, 2020 at 5:27 AM Sam Ravnborg wrote: > >> Hi Kevin/tang. >> >> Thanks for the quick and detailed feedback. >> Your questions are addressed below. >> >> Sam >&g

Re: [PATCH RFC v3 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-02-24 Thread tang pengchuan
Hi Sam, Thank you for your email On Sat, Feb 22, 2020 at 5:21 AM Sam Ravnborg wrote: > Hi Kevin. > > On Fri, Feb 21, 2020 at 03:48:51PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > The Unisoc DRM master device is a virtual device needed to list all > > DPU devices or other display inte

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

2020-02-24 Thread tang pengchuan
On Sat, Feb 22, 2020 at 5:36 AM Sam Ravnborg wrote: > Hi Kevin. > > On Fri, Feb 21, 2020 at 03:48:52PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > Adds drm support for the Unisoc's display subsystem. > > Thanks for the updated driver patch. > Good split of patches. > A few comments in

Re: [PATCH RFC v3 0/6] Add Unisoc's drm kms module

2020-02-24 Thread tang pengchuan
Hi Sam, Thanks for your feedback In the future we will have dp(displayport), hdmi encoder and more, so all those put into sprd directory, maybe better? On Sat, Feb 22, 2020 at 5:17 AM Sam Ravnborg wrote: > Hi Kevin. > > On Fri, Feb 21, 2020 at 03:48:50PM +0800, Kevin Tang wrote: > > ChangeList:

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

2020-02-24 Thread tang pengchuan
On Sun, Feb 23, 2020 at 5:27 AM Sam Ravnborg wrote: > Hi Kevin/tang. > > Thanks for the quick and detailed feedback. > Your questions are addressed below. > > Sam > > > > > > +static int sprd_drm_bind(struct device *dev) > > > > +{ > > > > + struct drm_device *drm; > > > > + struc

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

2020-02-25 Thread tang pengchuan
Got it, thanks! On Tue, Feb 25, 2020 at 12:43 AM Emil Velikov wrote: > Hi all, > > On Fri, 21 Feb 2020 at 11:15, Kevin Tang wrote: > > > > From: Kevin Tang > > > > Adds drm support for the Unisoc's display subsystem. > > > > This is drm device and gem driver. This driver provides support for t

Re: [PATCH RFC v3 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-02-26 Thread tang pengchuan
Hi Emil, Thanks for your feedback On Tue, Feb 25, 2020 at 1:35 AM Emil Velikov wrote: > On Fri, 21 Feb 2020 at 11:15, Kevin Tang wrote: > > > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

2020-02-26 Thread tang pengchuan
On Tue, Feb 25, 2020 at 3:38 PM Thomas Zimmermann wrote: > Hi > > Am 23.02.20 um 05:26 schrieb tang pengchuan: > > > > > > On Sun, Feb 23, 2020 at 5:27 AM Sam Ravnborg > <mailto:s...@ravnborg.org>> wrote: > > > > Hi Kevin/tang. >

Re: [PATCH RFC v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-03-05 Thread tang pengchuan
Hi Emil, Thanks for your feedback On Tue, Mar 3, 2020 at 2:29 AM Emil Velikov wrote: > Hi Kevin, > > There's a few small suggestions, although overall the driver looks a lot > better. > > On Thu, 27 Feb 2020 at 08:14, Kevin Tang wrote: > > > --- /dev/null > > +++ b/drivers/gpu/drm/sprd/dpu/Make

Re: [PATCH RFC v4 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-03-05 Thread tang pengchuan
On Fri, Feb 28, 2020 at 12:50 AM Rob Herring wrote: > On Wed, Feb 26, 2020 at 3:46 AM Kevin Tang wrote: > > > > From: Kevin Tang > > > > The Unisoc DRM master device is a virtual device needed to list all > > DPU devices or other display interface nodes that comprise the > > graphics subsystem

Re: [PATCH RFC v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-03-06 Thread tang pengchuan
On Tue, Mar 3, 2020 at 2:29 AM Emil Velikov wrote: > Hi Kevin, > > There's a few small suggestions, although overall the driver looks a lot > better. > > On Thu, 27 Feb 2020 at 08:14, Kevin Tang wrote: > > > --- /dev/null > > +++ b/drivers/gpu/drm/sprd/dpu/Makefile > > @@ -0,0 +1,7 @@ > > +# SPD

Re: [PATCH RFC v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-03-07 Thread tang pengchuan
Hi Emil, Maybe here is your missing comments I ’m really sorry, sometimes I forget to use plain text by gmail, never make the same mistake again. Emil Velikov 于2020年3月3日周二 上午2:29写道: > > Hi Kevin, > > There's a few small suggestions, although overall the driver looks a lot > better. > > On Thu, 2

Re: [PATCH RFC v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-03-07 Thread tang pengchuan
Emil Velikov 于2020年3月7日周六 上午1:14写道: > > On Thu, 5 Mar 2020 at 13:15, tang pengchuan wrote: > > On Tue, Mar 3, 2020 at 2:29 AM Emil Velikov > > wrote: > > >> Have you seen a case where the 0 or default case are reached? AFAICT they > >> will >

Re: [PATCH RFC v1 2/6] drm/sprd: add Unisoc's drm kms master

2020-01-15 Thread tang pengchuan
1) Convert to generic CMA handlers and submit. You'd want the least amount of code in your patches, so they go in quickly and easily. Ok, I will follow this suggestion, thank you very much! On Tue, Jan 7, 2020 at 8:22 PM Thomas Zimmermann wrote: > Hi > > Am 07.01.20 um 12:3