rdingly.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 6 +++---
> drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 6 +++---
> drivers/gpu/drm/omapdrm/displays/c
t;
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 5 ++---
> drivers/gpu/drm/omapdrm/displays/connector-hdmi.c | 5 ++---
> 2 files changed, 4 insertions(+), 6 deletions(-)
&g
gt;
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dpi.c | 10 ++
> drivers/gpu/drm/omapdrm/dss/dsi.c | 9 -
> drivers/gpu/drm/omapdrm/dss/hdmi4.c | 7 ---
> drivers/gpu/drm/omapdrm/
t probe
> time, initializing at bind time only the parts that depends on the DSS.
> The cleanup code is moved from unbind to remove in a similar way.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers
t probe
> time, initializing at bind time only the parts that depends on the DSS.
> The cleanup code is moved from unbind to remove in a similar way.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/g
t probe
> time, initializing at bind time only the parts that depends on the DSS.
> The cleanup code is moved from unbind to remove in a similar way.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/g
t probe
> time, initializing at bind time only the parts that depends on the DSS.
> The cleanup code is moved from unbind to remove in a similar way.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/
uct omap_dss_device *dssdev,
> diff --git a/drivers/gpu/drm/omapdrm/dss/output.c
> b/drivers/gpu/drm/omapdrm/dss/output.c
> index 191b2e801257..2f7a019d059e 100644
> --- a/drivers/gpu/drm/omapdrm/dss/output.c
> +++ b/drivers/gpu/drm/omapdrm/dss/output.c
> @@ -109,18 +109,17 @@ void dss_uninsta
aurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/display.c | 9 +
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/display.c
> b/drivers/g
off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/encoder-opa362.c| 9 +
> drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c| 9 +
> drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c | 9 +
On Sat, May 26, 2018 at 08:25:02PM +0300, Laurent Pinchart wrote:
> Similarly to for_each_dss_display(), the for_each_dss_output() macro
> iterates over all the DSS connected outputs.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/omapdrm/dss/base.c| 20 ++--
> d
e.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dpi.c | 69
> ++---
> drivers/gpu/drm/omapdrm/dss/dsi.c | 36 ---
> drive
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_drv.c | 18 +-
> 1 file changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
> b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 9b33859e9ac6..0d
Hi,
On Sat, May 26, 2018 at 08:25:07PM +0300, Laurent Pinchart wrote:
> Creating all the planes in a single location instead of creating them
> per-CRTC with remaining planes then created in a second step simplifies
> the logic.
>
> Signed-off-by: Laurent Pinchart
> ---
Revi
to handle the NULL case.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu
f-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> Changes since v0:
>
> - Use %u to format display ID
> ---
> drivers/gpu/drm/omapdrm/dss/display.c | 15 +++
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 --
> 2 files changed, 3 insertions
independent arrays and thus improves code readability.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_crtc.c | 4 +-
> drivers/gpu/drm/omapdrm/omap_drv.c | 144
> +---
m_disable(dssdev);
> - dsicm_disconnect(dssdev);
> + dsicm_disconnect(NULL, dssdev);
^^^ calling dsicm_disconnect() with src=NULL
This will execute dsi_release_vc(NULL, channel), which will try to
dereference NULL.
-- Sebastian
signature.asc
Description: PGP signatu
check.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/base.c | 1 +
> drivers/gpu/drm/omapdrm/dss/output.c | 29 ++---
> 2 files changed, 3 insertions(+), 27 deletions(-)
>
&g
zation to
> simplify pipeline connection handling.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dpi.c | 25 +++--
> drivers/gpu/drm/omapdrm/dss/dsi.c | 25 +++--
>
c_channel()
> function that is now unneeded.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/base.c| 9 -
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
> drivers/gpu/drm/omapdrm/omap_crtc.c | 7
s_output_unset_device() is never checked in the current
> code for that reason).
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/base.c| 2 ++
> drivers/gpu/drm/omapdrm/dss/dpi.c | 1 -
> drivers/gp
gt; the form of an array of omap_drm_pipeline pointers.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_crtc.c | 22 +-
> drivers/gpu/drm/omapdrm/omap_drv.c | 19 +++
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_crtc.c | 12 +++-
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c
> b/drivers/gpu/drm/omapdrm/omap_
gt; bug. All the output drivers have been verified and they are always
> assigned a DISPC channel that is supported on the SoC they run on. The
> check can thus be removed.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu
ead of
> going through the CRTC dss_mgr operations.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dpi.c | 3 +++
> drivers/gpu/drm/omapdrm/dss/dsi.c | 3 +++
> drivers/gpu/drm/omapdrm/dss/hdmi4.c | 3
Hi,
On Sat, May 26, 2018 at 08:25:18PM +0300, Laurent Pinchart wrote:
> The dss_mgr .connect() and .disconnect() are implemented as no-op in
> omapdrm. The operations are unneeded, remove them.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebast
Hi,
On Wed, Jun 06, 2018 at 12:36:30PM +0300, Laurent Pinchart wrote:
> The .probe(), .remove(), .run_test(), .get_rotate() and .set_rotate()
> omap_dss_driver operations are not used. Remove them.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
Hi,
On Wed, Jun 06, 2018 at 12:36:31PM +0300, Laurent Pinchart wrote:
> The .get_mirror() and .set_mirror() omap_dss_driver operations are
> implemented by the panel-tpo-td043mtea1 driver but are never used.
> Remove them.
>
> Signed-off-by: Laurent Pinchart
> ---
Revi
() macro it uses to iterate
> over displays locates the displays by checking the driver field
> internally.
>
> As those checks are unnecessary, remove them.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/om
Hi,
On Wed, Jun 06, 2018 at 12:36:34PM +0300, Laurent Pinchart wrote:
> The GPIO descriptor API is favoured over the plain GPIO API for consumer
> drivers. Using it simplifies the driver code.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebast
the polarity of all GPIO operations in the driver.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 51
> ++-
> 1 file changed, 13 insertions(+), 38 deletions(-)
he qvga GPIO is unused, so drop it completely.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> .../drm/omapdrm/displays/panel-nec-nl8048hl11.c| 54
> +-
> 1 file changed, 11 insertions(+), 43 deletions(-)
>
&g
Hi,
On Wed, Jun 06, 2018 at 12:36:37PM +0300, Laurent Pinchart wrote:
> The GPIO descriptor API is favoured over the plain GPIO API for consumer
> drivers. Using it simplifies the driver code.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebast
Hi,
On Wed, Jun 06, 2018 at 12:36:38PM +0300, Laurent Pinchart wrote:
> The driver doesn't use GPIOs and thus doesn't need to include the
> linux/gpio.h header.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gp
the polarity of all GPIO operations in the driver. Rename the
> nreset_gpio field to reset_gpio to reflect that.
>
> The reset GPIO is mandatory, so drop conditional tests through the
> driver.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Se
m recursive operations. To
> simplify current and future code, move all operations that are not
> specific to the display device to the omap_dss_device_ops.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> .../gpu/drm/omapdrm/displays/c
; drivers to signal support for operations.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/omap
> .detect() implementation. This moves the complexity to a single central
> location and simplifies the logic in omap_dss_device drivers.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 2 ++
Hi,
On Mon, Jun 11, 2018 at 08:16:24PM +0300, Laurent Pinchart wrote:
> Hi Sebastian,
>
> On Monday, 11 June 2018 02:48:45 EEST Sebastian Reichel wrote:
> > On Sat, May 26, 2018 at 08:25:04PM +0300, Laurent Pinchart wrote:
> > > The dss_mgr_connect() and dss_mgr_disconn
Hi,
On Mon, Jun 11, 2018 at 08:11:09PM +0300, Laurent Pinchart wrote:
> Hi Sebastian,
>
> On Monday, 11 June 2018 02:52:44 EEST Sebastian Reichel wrote:
> > On Sat, May 26, 2018 at 08:25:02PM +0300, Laurent Pinchart wrote:
> > > Similarly to for_each_dss_display(),
t; detection support, iterate over the devices manually in the DRM
> connector code. This moves the complexity to a single central location
> and simplifies the logic in omap_dss_device drivers.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
a
> result be turned into a void operation.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 9 +
> drivers/gpu/drm/omapdrm/displays/connector-hdmi.c| 14 +++--
= priv->pipes[i].display;
> -
> - if (display->ops->disable_hpd)
> - display->ops->disable_hpd(display);
> - }
> + for (i = 0; i < priv->num_pipes; i++)
> + omap_connector_enable_hpd(priv->pipes[i].connecto
AP4 internal HDMI encoder.
>
> Knowledge of the DSS internals need to be removed from the
> omap_dss_device instances in order to migrate to drm_bridge. To do so,
> move HPD handling for CEC to the omap_connector.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by:
e.
> This moves the complexity to a single central location and simplifies
> the logic in omap_dss_device drivers.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 15 +--
> dr
t; This gets in the way of the omap_dss_device operations refactoring.
> Replace that with a check based on the output_type field which is set
> for all omap_dss_device instances but displays.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
aurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_crtc.c| 25 -
> drivers/gpu/drm/omapdrm/omap_encoder.c | 7 ---
> drivers/gpu/drm/omapdrm/omap_encoder.h | 3 ---
> 3 files changed, 4 insertions(+), 31 dele
HDMI
> encoder just forward the operation to the previous component in the
> chain. Call the operations directly on the HDMI encoder.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/connector-hdmi.c | 20
gt; handling will require access to the output omap_dss_device. To prepare
> for that, pass it to the encoder initialization function and store it
> internally as well.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/d
reworking the .check_timings() operation by
> making use of the bus flags. Patches 11/23 to 13/23 rework the .get_timings()
> operation, and patches 14/23 to 21/23 complete the .check_timings() rework.
> Patches 22/23 and 23/23 finally rework the .set_timings() operation.
Hi,
On Tue, Nov 06, 2018 at 07:28:02AM -0800, Tony Lindgren wrote:
> We're missing a call to of_platform_depopulate() on errors for dsi.
> Looks like dss is already doing this.
>
> Signed-off-by: Tony Lindgren
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> driv
t; Fixes: 27d624527d99 ("drm/omap: dss: Acquire next dssdev at probe time")
> Signed-off-by: Laurent Pinchart
> Acked-by: Tony Lindgren
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> arch/arm/mach-omap2/display.c | 111 ++
&g
gt;
> Fixes: 27d624527d99 ("drm/omap: dss: Acquire next dssdev at probe time")
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> Changes since v2:
>
> - Call hdmi_runtime_put() instead of hdmi_runtime_get() in error path
> ---
_runtime_get() and dsi_runtime_put() calls.
>
> Fixes: edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind
> to probe")
> Signed-off-by: Laurent Pinchart
> Acked-by: Tony Lindgren
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers
erred, or at remove time du to the
> DISPC being already removed).
>
> Fixes: edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind
> to probe")
> Signed-off-by: Laurent Pinchart
> ---
+1 for writing fixes, that cleanup the code at the same time :)
D
trigger a display refresh
and seems to work as expected.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 116 ++--
drivers/gpu/drm/omapdrm/omap_crtc.h | 1 +
drivers/gpu/drm/omapdrm/omap_fb.c | 41 ++
3 files changed, 153 insert
This prepares framedone interrupt handling for
manual display update support.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 50 +
drivers/gpu/drm/omapdrm/omap_crtc.h | 1 +
drivers/gpu/drm/omapdrm/omap_irq.c | 25
PC VM for DSI here.
Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly")
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_connector.c | 8 +---
drivers/gpu/drm/omapdrm/omap_encoder.c | 8 +---
2 files changed, 10 insertions(+), 6 del
This macro is only used by omapdrm, which should print
debug messages using the DRIVER category instead of the
default CORE category.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
dsi_init_output().
Fixes: 27d624527d992 ("drm/omap: dss: Acquire next dssdev at probe time")
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/ds
erty to set DRM orientation hint
* Add Tested-by from Tony
Changes since PATCHv1:
* Drop patches, that were queued by Tomi
* Rebase to current master
* Rework the omap3 workaround patch to only affect omap3
* Add orientation DRM property support
-- Sebastian
Sebastian Reichel (6):
drm/omap: use D
ssue by exiting early if the output type definitely
has no hdmi_set operations.
Fixes: 83910ad3f51fb ("drm/omap: Move most omap_dss_driver operations to
omap_dss_device_ops")
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_encoder.c | 8
1 file changed, 8 inser
Hi Tomi,
On Fri, Nov 16, 2018 at 03:41:24PM +0200, Tomi Valkeinen wrote:
> On 16/11/18 01:06, Sebastian Reichel wrote:
> > The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the
> > same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in omap
Hi,
On Sat, Nov 17, 2018 at 10:08:40PM +0100, Pavel Machek wrote:
> > This prepares framedone interrupt handling for
> > manual display update support.
> >
> > Signed-off-by: Sebastian Reichel
>
> Acked-by: Pavel Machek
Thanks.
> > @@ -217,6 +239,9 @@ sta
This prepares framedone interrupt handling for
manual display update support.
Acked-by: Pavel Machek
Tested-by: Tony Lindgren
Tested-by: Pavel Machek
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 50 +
drivers/gpu/drm/omapdrm
existing 'rotation' DT property to set DRM orientation hint
* Add Tested-by from Tony
Changes since PATCHv1:
* Drop patches, that were queued by Tomi
* Rebase to current master
* Rework the omap3 workaround patch to only affect omap3
* Add orientation DRM property support
--
dsi_init_output().
Fixes: 27d624527d992 ("drm/omap: dss: Acquire next dssdev at probe time")
Acked-by: Pavel Machek
Tested-by: Tony Lindgren
Tested-by: Pavel Machek
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 20 ++--
1 file changed, 10
This macro is only used by omapdrm, which should print
debug messages using the DRIVER category instead of the
default CORE category.
Acked-by: Pavel Machek
Tested-by: Tony Lindgren
Tested-by: Pavel Machek
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++--
1
ove most omap_dss_driver operations to
omap_dss_device_ops")
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_encoder.c | 62 +++---
1 file changed, 37 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c
b/drivers/gpu/drm/omapdrm/omap
trigger a display refresh
and seems to work as expected.
Acked-by: Pavel Machek
Tested-by: Tony Lindgren
Tested-by: Pavel Machek
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 117 ++--
drivers/gpu/drm/omapdrm/omap_crtc.h | 1 +
drivers/gpu/d
e DISPC VM for DSI here.
Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly")
Acked-by: Pavel Machek
Tested-by: Tony Lindgren
Tested-by: Pavel Machek
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_connector.c | 8 +---
drivers/gpu/drm/om
Hi,
On Mon, Nov 26, 2018 at 11:34:30AM +0200, Tomi Valkeinen wrote:
> On 21/11/18 18:09, Sebastian Reichel wrote:
> > Here is another round of the DSI command mode panel patchset
> > integrating the feedback from PATCHv4. The patches are based
> > on 4.20-rc1 + fixes fro
> for all three serieses:
>
> Reviewed-by: Tomi Valkeinen
>
> Good work! And a special thanks for Sebastian for doing review.
>
> Sebastian, did you happen to test these with the DSI command mode
> patches on top?
No, I did not test this on Droid 4. I only reviewed them. I&#
> look them up by node only.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/base.c| 5 +--
> drivers/gpu/drm/omapdrm/dss/dss-of.c | 60 ---
> drivers/gpu/drm/omapdrm/dss/o
s to the end of the
> pipeline.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_connector.c | 31 ++--
> 1 file changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/
Hi,
On Wed, Dec 05, 2018 at 05:00:04PM +0200, Laurent Pinchart wrote:
> All the internal encoders share common init and cleanup code. Factor it
> out to separate functions.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/g
nce v1:
>
> - Set mode.crtc_* fields and mode name in venc_check_timings()
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/venc.c | 90 +++---
> 1 file changed, 44 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/gpu/
On Wed, Dec 05, 2018 at 04:59:56PM +0200, Laurent Pinchart wrote:
> The venc_device structure wss_data field is set to 0 and never otherwise
> modified, remove it.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapd
gt;
> Signed-off-by: Laurent Pinchart
> ---
Documentation/gpu/todo.rst says, that this should be converted to
drm_mode_config_helper_suspend, but at least it's no longer open
coded after your change.
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/o
gt; function.
>
> Signed-off-by: Laurent Pinchart
> ---
This is a bit tricky to review. It would probably be easier to
review, if the changes were split into two commits:
1. introduce common function
2. move drm_display_mode/videomode conversion further up the stack
Anyways:
Reviewed-
Hi,
On Wed, Dec 05, 2018 at 05:00:14PM +0200, Laurent Pinchart wrote:
> The field is only used to check whether the device is connected, and we
> can do so by checking the dss field instead. Remove the src field.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Se
Hi,
On Wed, Dec 05, 2018 at 04:59:54PM +0200, Laurent Pinchart wrote:
> The omap_connector_attached_encoder() doesn't exist anymore, remove its
> declaration from omap_connector.h.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
otable exception of the DSI pipelines that will require more
> work.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> .../omapdrm/displays/connector-analog-tv.c| 21
> .../gpu/drm/omapdrm/displays/connector-dvi.c | 21 -
On Wed, Dec 05, 2018 at 04:59:55PM +0200, Laurent Pinchart wrote:
> The kobj field from struct omap_dss_device is not used. Remove it.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 --
>
the safety checks.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> .../gpu/drm/omapdrm/displays/encoder-opa362.c | 7 ---
> .../gpu/drm/omapdrm/displays/encoder-tfp410.c | 7 ---
> .../drm/omapdrm/displays/encoder-tpd12s
M
> modes directly to the connector.
>
> As this puts more burden on display devices, we also create a helper
> function for panels to add a single DRM mode from the panel video
> timings.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
&g
Hi,
On Wed, Dec 05, 2018 at 05:00:03PM +0200, Laurent Pinchart wrote:
> The field is only used in a safety check during device
> connection/disconnection, where the src field can be easily used
> instead. Remove it and use src.
>
> Signed-off-by: Laurent Pinchart
> ---
Revi
k_timings(dssdev, adjusted_mode);
> if (ret)
> return MODE_BAD;
> }
>
> - if (adjusted_mode)
> - drm_display_mode_from_videomode(&vm, adjusted_mode);
> -
> return MODE_OK;
> }
Old code assumed,
before getting aliases and sorting the pipelines.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_drv.c | 123 +
> 1 file changed, 56 insertions(+), 67 deletions(-)
>
> diff
Hi,
On Wed, Dec 05, 2018 at 05:00:09PM +0200, Laurent Pinchart wrote:
> The display isn't used by the encoder implementation, don't pass it to
> the initialization function and store it internally needlessly.
>
> Signed-off-by: Laurent Pinchart
> ---
Revie
> instead.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/venc.c | 68 +++---
> 1 file changed, 34 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/ve
gned-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
This should also fix the issue with DSI in a less ugly way:
https://lists.freedesktop.org/archives/dri-devel/2018-November/196622.html
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_connector.c | 6 --
> drivers/gpu/drm
off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dpi.c | 9 -
> drivers/gpu/drm/omapdrm/dss/sdi.c | 6 +++---
> 2 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c
>
; Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/venc.c | 25 +++--
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c
> b/drivers/g
nection time and store
> it in the pipeline structure instead to keep the feature.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/display.c | 2 --
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 --
ncoder_disable()
> handlers.
>
> The enabled check in the .disable() handler is left untouched, it will
> be addressed separately.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> .../omapdrm/displays/connector-analog-tv.c| 23 +---
gt;
> The safety check is thus not needed, remove it.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dpi.c | 17 +
> drivers/gpu/drm/omapdrm/dss/dsi.c | 20 ++---
gt; pipeline.
>
> Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/omap_connector.c | 28 ++--
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap
; Signed-off-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 14 +++---
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ---
> drivers/gpu/drm/omapdrm/omap_connector.c| 15 ++
501 - 600 of 1159 matches
Mail list logo
