Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Fix enable error path

2023-05-04 Thread rfoss
From: Robert Foss On Thu, 4 May 2023 08:53:16 +0200, Alexander Stein wrote: > If PLL locking failed, the regulator needs to be disabled again. > > Applied, thanks! [1/1] drm/bridge: ti-sn65dsi83: Fix enable error path https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8a91b29f1f50

Re: [PATCH v1 0/9] drm/bridge: tc358768: various fixes on PLL calculation and DSI timings

2023-05-05 Thread rfoss
From: Robert Foss On Thu, 27 Apr 2023 16:29:25 +0200, Francesco Dolcini wrote: > From: Francesco Dolcini > > This series includes multiple fixes on the tc358768 parallel RGB to DSI > driver. > > With the following changes I am able to have a stable display output using a > TI > SN65DSI83 (DS

Re: [PATCH v1] drm/bridge: lt8912b: Fix DSI Video Mode

2023-04-03 Thread rfoss
From: Robert Foss On Thu, 30 Mar 2023 11:31:31 +0200, Francesco Dolcini wrote: > From: Francesco Dolcini > > LT8912 DSI port supports only Non-Burst mode video operation with Sync > Events and continuous clock on clock lane, correct dsi mode flags > according to that removing MIPI_DSI_MODE_VIDE

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: use dev_err_probe if host attach failed

2023-04-05 Thread rfoss
From: Robert Foss On Wed, 5 Apr 2023 09:52:23 +0200, Alexander Stein wrote: > There might be cases where the host attach is deferred, use dev_err_probe > to add more detailed information to /sys/kernel/debug/devices_deferred. > > Applied, thanks! [1/1] drm/bridge: ti-sn65dsi83: use dev_err_pr

Re: [PATCH v2 1/2] drm: bridge: ldb: add missing \n in dev_warn() string

2023-04-05 Thread rfoss
From: Robert Foss On Wed, 5 Apr 2023 10:10:56 +0200, Luca Ceresoli wrote: > dev_warn() and similar require a training \n. > > Applied, thanks! [1/2] drm: bridge: ldb: add missing \n in dev_warn() string https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8cc0b604f234 [2/2] drm: bridge:

Re: [PATCH] drm/bridge: ti-sn65dsi83: Do not generate HFP/HBP/HSA and EOT packet

2023-04-05 Thread rfoss
From: Robert Foss On Mon, 3 Apr 2023 21:02:42 +0200, Marek Vasut wrote: > Do not generate the HS front and back porch gaps, the HSA gap and > EOT packet, as per "SN65DSI83 datasheet SLLSEC1I - SEPTEMBER 2012 > - REVISED OCTOBER 2020", page 22, these packets are not required. > This makes the TI S

Re: [PATCH] drm/bridge: ps8640: Use constant sleep time for polling hpd

2023-04-05 Thread rfoss
From: Robert Foss On Fri, 31 Mar 2023 11:02:04 +0800, Pin-yen Lin wrote: > The default hpd_wait_us in panel_edp.c is 2 seconds. This makes the > sleep time in the polling of _ps8640_wait_hpd_asserted become 200ms. > Change it to a constant 20ms to speed up the function. > > Applied, thanks! [

Re: [PATCH] gpu: drm: bridge: sii9234: remove unused bridge_to_sii9234 function

2023-03-20 Thread rfoss
From: Robert Foss On Fri, 17 Mar 2023 20:23:21 -0400, Tom Rix wrote: > clang with W=1 reports > drivers/gpu/drm/bridge/sii9234.c:870:31: error: > unused function 'bridge_to_sii9234' [-Werror,-Wunused-function] > static inline struct sii9234 *bridge_to_sii9234(struct drm_bridge *bridge) >

Re: [PATCH] drm/bridge: tc358764: Fix debug print parameter order

2023-06-16 Thread rfoss
From: Robert Foss On Thu, 15 Jun 2023 17:28:17 +0200, Marek Vasut wrote: > The debug print parameters were swapped in the output and they were > printed as decimal values, both the hardware address and the value. > Update the debug print to print the parameters in correct order, and > use hexadec

Re: [PATCH v2] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro

2023-06-21 Thread rfoss
From: Robert Foss On Tue, 20 Jun 2023 08:12:54 +0200, Juerg Haefliger wrote: > The module loads firmware so add a MODULE_FIRMWARE macro to provide that > information via modinfo. > > Applied, thanks! [1/1] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro https://cgit.freedesktop.org/drm

Re: [PATCH] drm/bridge: tc358764: Use BIT() macro for actual bits

2023-06-22 Thread rfoss
From: Robert Foss On Thu, 15 Jun 2023 22:16:35 +0200, Marek Vasut wrote: > None of these four bits are bitfields, use BIT() macro and treat > them as bits. No functional change. > > Applied, thanks! [1/1] drm/bridge: tc358764: Use BIT() macro for actual bits https://cgit.freedesktop.org

Re: [PATCH 1/5] drm/bridge: tc358762: Split register programming from pre-enable to enable

2023-06-22 Thread rfoss
From: Robert Foss On Thu, 15 Jun 2023 22:18:58 +0200, Marek Vasut wrote: > Move the register programming part, which actually enables the bridge and > makes it push data out of its DPI side, into the enable callback. The DSI > host like DSIM may not be able to transmit commands in pre_enable, mov

Re: [PATCH v2] drm: bridge: dw-mipi-dsi: Fix enable/disable of DSI controller

2023-06-22 Thread rfoss
From: Robert Foss On Sun, 18 Jun 2023 00:48:25 +0200, Ondřej Jirman wrote: > From: Ondrej Jirman > > Before this patch, booting to Linux VT and doing a simple: > > echo 2 > /sys/class/graphics/fb0/blank > echo 0 > /sys/class/graphics/fb0/blank > > [...] Applied, thanks! [1/1] drm: bridg

Re: [PATCH 1/1] drm/bridge: tc358767: Switch to devm MIPI-DSI helpers

2023-05-17 Thread rfoss
From: Robert Foss On Wed, 17 May 2023 14:21:06 +0200, Alexander Stein wrote: > DSI device registering and attaching needs to be undone upon > deregistration. This fixes module unload/load. > > Applied, thanks! [1/1] drm/bridge: tc358767: Switch to devm MIPI-DSI helpers https://cgit.free

Re: [PATCH] drm/bridge: anx7625: Prevent endless probe loop

2023-05-23 Thread rfoss
From: Robert Foss On Thu, 18 May 2023 15:39:02 -0400, Nícolas F. R. A. Prado wrote: > During probe, the driver registers i2c dummy devices and populates the > aux bus, which registers a device for the panel. After doing that, the > driver can still defer probe if needed. This ordering of operatio

Re: [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread rfoss
From: Robert Foss On Mon, 22 May 2023 15:52:10 +, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an e

Re: [PATCH 1/2] dt-bindings: display: bridge: tc358762: Document reset-gpios

2023-06-01 Thread rfoss
From: Robert Foss On Tue, 30 May 2023 21:28:04 +0200, Marek Vasut wrote: > This chip has one reset GPIO input, document it. The reset GPIO > is optional as it is sometimes not connected on some hardware. > > Applied, thanks! [1/2] dt-bindings: display: bridge: tc358762: Document reset-gpios

Re: [PATCH v3 1/2] drm/bridge: imx: fix mixed module-builtin object

2023-06-05 Thread rfoss
From: Robert Foss On Mon, 5 Jun 2023 21:00:20 +0900, Masahiro Yamada wrote: > With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice > versa), imx-ldb-helper.o is linked to a module and also to vmlinux > even though the expected CFLAGS are different between builtins and > modules. >