[PATCH 0/2] Add HDMI audio support to the LT8912B bridge

2025-02-04 Thread rafael
From: Rafael Beims This patch series adds HDMI audio support to the Lontium LT8912B bridge driver using the I2S input. The audio output was tested using a Verdin iMX8MM + DSI to HDMI adapter connected to different monitors. Rafael Beims (2): dt-bindings: display: bridge: lt8912b: Add I2S

[PATCH 2/2] drm/bridge: lt8912b: Add support for audio

2025-02-04 Thread rafael
From: Rafael Beims Add support for HDMI codec with audio coming from the I2S input. Support 48kHz and 96kHz sample rate, with 16 bits word size. Co-developed-by: João Paulo Gonçalves Signed-off-by: João Paulo Gonçalves Signed-off-by: Rafael Beims --- drivers/gpu/drm/bridge/Kconfig

[PATCH 1/2] dt-bindings: display: bridge: lt8912b: Add I2S audio input port

2025-02-04 Thread rafael
From: Rafael Beims Add the I2S audio input port for audio over HDMI support. Signed-off-by: Rafael Beims --- .../bindings/display/bridge/lontium,lt8912b.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/lontium

[PATCH] drm/amdgpu: Fix memory leak in hpd_rx_irq_create_workqueue()

2022-09-12 Thread Rafael Mendonca
x_irq") Signed-off-by: Rafael Mendonca --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 51

[PATCH] drm/vmwgfx: Fix memory leak in vmw_mksstat_add_ioctl()

2022-09-16 Thread Rafael Mendonca
If the copy of the description string from userspace fails, then the page for the instance descriptor doesn't get freed before returning -EFAULT, which leads to a memleak. Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware mks-guest-stats") Signed-off-by: Rafael Mendonca ---

[PATCH] drm/amdgpu/powerplay/psm: Fix memory leak in power state init

2022-10-17 Thread Rafael Mendonca
ng. Fixes: 902bc65de0b3 ("drm/amdgpu/powerplay/psm: return an error in power state init") Signed-off-by: Rafael Mendonca --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c b/drivers/gpu/

[PATCH] drm/amdkfd: Fix memory leak in kfd_mem_dmamap_userptr()

2022-10-17 Thread Rafael Mendonca
Fixes: 264fb4d332f5 ("drm/amdgpu: Add multi-GPU DMA mapping helpers") Signed-off-by: Rafael Mendonca --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/driv

[PATCH] drm/amd/display: Remove duplicate code for DCN314 DML calculation

2022-10-20 Thread Rafael Mendonca
nt issue reported by coccinelle in 'display_rq_dlg_calc_314.c': static bool CalculateBytePerPixelAnd256BBlockSizes(...) { ... } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16) { ... } Signed-off-by: Rafael Mendonca --- .../dc/dml/dcn314/dis

[PATCH] dma-buf/sync_file: Always increment refcount when merging fences.

2016-09-13 Thread Rafael Antognolli
ut it. This patch fixes a kernel panic that can be triggered by creating a fence that is expired (or increasing the timeline until it expires), then creating a merged fence out of it, and deleting the merged fence. This will make the original expired fence's refcount go to zero. Signed-off-

[PATCH i-g-t] tests/sw_sync: Add subtest test_sync_expired_merge

2016-09-13 Thread Rafael Antognolli
kernel panick will follow. Signed-off-by: Rafael Antognolli --- tests/sw_sync.c | 28 1 file changed, 28 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index 4336659..31cde50 100644 --- a/tests/sw_sync.c +++ b/tests/sw_sync.c @@ -582,6 +582,31 @@ static void

[PATCH] dma-buf/sync_file: Always increment refcount when merging fences.

2016-09-14 Thread Rafael Antognolli
On Wed, Sep 14, 2016 at 11:04:01AM -0300, Gustavo Padovan wrote: > 2016-09-14 Chris Wilson : > > > On Tue, Sep 13, 2016 at 04:24:27PM -0700, Rafael Antognolli wrote: > > > The refcount of a fence should be increased whenever it is added to a > > > merged >

[PATCH] dma-buf/sync_file: Increment refcount of fence when all are signaled.

2016-09-14 Thread Rafael Antognolli
triggered by creating a fence that is expired (or increasing the timeline until it expires), then creating a merged fence out of it, and deleting the merged fence. This will make the original expired fence's refcount go to zero. Signed-off-by: Rafael Antognolli --- drivers/dma-buf/sync_file.

[PATCH] dma-buf/sync-file: Avoid enable fence signaling if poll(.timeout=0)

2016-09-14 Thread Rafael Antognolli
troy(fence1); sw_sync_fence_destroy(fence2); sw_sync_timeline_destroy(timeline1); sw_sync_timeline_destroy(timeline2); } It looks like you cannot trust fence_is_signaled() without a fence_add_callback(). I think the fence_array->num_pending won't get updated. Although I couldn't figure out why it only happens if you merge fences from different timelines. Regards, Rafael

[PATCH v2] dma-buf/sync_file: Increment refcount of fence when all are signaled.

2016-09-15 Thread Rafael Antognolli
triggered by creating a fence that is expired (or increasing the timeline until it expires), then creating a merged fence out of it, and deleting the merged fence. This will make the original expired fence's refcount go to zero. Testcase: igt/sw_sync/sync_expired_merge Signed-off-by: R

[PATCH v3] dma-buf/sync_file: Increment refcount of fence when all are signaled.

2016-09-15 Thread Rafael Antognolli
triggered by creating a fence that is expired (or increasing the timeline until it expires), then creating a merged fence out of it, and deleting the merged fence. This will make the original expired fence's refcount go to zero. Testcase: igt/sw_sync/sync_expired_merge Signed-off-by: R

[PATCH 2/7] drm/doc: Polish for drm_plane.[hc]

2016-09-27 Thread Rafael Antognolli
NE_TYPE_PRIMARY) { tests/kms_frontbuffer_tracking.c:2741: drm.plane_types[i] == DRM_PLANE_TYPE_PRIMARY) Anyway, should we update it on libdrm, bring the order back to its original values, or something else? Or am I missing something? Thanks, Rafael

[PATCH 2/7] drm/doc: Polish for drm_plane.[hc]

2016-09-28 Thread Rafael Antognolli
On Wed, Sep 28, 2016 at 11:11:52AM +0300, Jani Nikula wrote: > On Wed, 28 Sep 2016, Rafael Antognolli wrote: > > Hi Daniel, > > > > On Wed, Sep 21, 2016 at 10:59:25AM +0200, Daniel Vetter wrote: > >> diff --git a/include/drm/drm_plane.h b/include/drm/drm_p

[PATCH v8 0/2] Add drm_dp_aux chardev support.

2015-11-02 Thread Rafael Antognolli
This series implement support to a drm_dp_aux chardev that allows reading and writing an arbitrary amount of bytes to arbitrary dpcd register addresses using regular read, write and lseek operations. Rafael Antognolli (2): drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers

[PATCH v8 2/2] drm/dp: Set aux.dev to the drm_connector device, instead of drm_device.

2015-11-02 Thread Rafael Antognolli
o the drm_connector. This also removes the need to add a sysfs link for the i2c device under the connector, as it will already be there. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/dr

[PATCH v8 1/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-11-02 Thread Rafael Antognolli
unregister - other minor suggestions from Ville v7: - style fixes - error handling fixes v8: - more error handling fixes Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/Kconfig | 8 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/d

[PATCH v10 0/4] Add drm_dp_aux chardev support.

2016-01-21 Thread Rafael Antognolli
This series implement support to a drm_dp_aux chardev that allows reading and writing an arbitrary amount of bytes to arbitrary dpcd register addresses using regular read, write and lseek operations. Lukas Wunner (1): drm/radeon: Fix WARN_ON if DRM_DP_AUX_CHARDEV is enabled Rafael Antognolli

[PATCH v10 1/4] drm/kms_helper: Add a common place to call init and exit functions.

2016-01-21 Thread Rafael Antognolli
The module_init and module_exit functions will start here, and call the subsequent init's and exit's. v10: - Keep __init on drm_fb_helper init function. - Move MODULE_* macros to the common file. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/Makefile| 4 ++

[PATCH v10 2/4] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2016-01-21 Thread Rafael Antognolli
unregister - other minor suggestions from Ville v7: - style fixes - error handling fixes v8: - more error handling fixes v9: - remove module_init and module_exit, and add drm_dp_aux_dev_init/exit to drm_kms_helper_init/exit. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/Kconfig

[PATCH v10 4/4] drm/radeon: Fix WARN_ON if DRM_DP_AUX_CHARDEV is enabled

2016-01-21 Thread Rafael Antognolli
From: Lukas Wunner Rafael Antognolli's new DRM_DP_AUX_CHARDEV feature causes a WARN_ON if drm_dp_aux->dev == drm_connector->kdev and drm_dp_aux_unregister() is called after drm_connector_unregister(). radeon is the only driver affected by this besides i915. (amdgpu calls drm_dp_aux

[PATCH v10 3/4] drm/i915: Set aux.dev to the drm_connector device, instead of drm_device.

2016-01-21 Thread Rafael Antognolli
f the drm_connector device now. Calling drm_dp_aux_unregister() before prevents them from being destroyed twice. v10: - move aux_fini() to connector_unregister(), instead of moving drm_dp_aux_unregister() outside of connector_register(). Signed-off-by: Rafael Antognolli --- drivers/gpu/drm

[PATCH v9 3/3] drm/dp: Set aux.dev to the drm_connector device, instead of drm_device.

2016-01-21 Thread Rafael Antognolli
Hi Lukas, Sorry for the late answer, I went on vacation and then was busy with something else. Anyway, I tried to address all comments (yours and Daniel's) on a new version. See some comments below. On Sun, Dec 06, 2015 at 05:08:49PM +0100, Lukas Wunner wrote: > Hi Rafael, > >

[RFC 11/13] drm/dp: Add helper to dump DPCD

2015-08-14 Thread Rafael Antognolli
ific code? I am not sure yet how this works (if there's something like it around), but I'll take a look. > I could put some effort into this (maybe Rafael too?), as long as we > could agree on the interface. As I wrote in the referenced thread, I > wasn't thrilled about what w

[RFC 11/13] drm/dp: Add helper to dump DPCD

2015-08-20 Thread Rafael Antognolli
On Mon, Aug 17, 2015 at 10:02:04AM +0300, Jani Nikula wrote: > On Fri, 14 Aug 2015, Rafael Antognolli wrote: > > On Fri, Aug 14, 2015 at 02:56:55PM +0300, Jani Nikula wrote: > >> On Wed, 12 Aug 2015, Thierry Reding wrote: > >> > From: Thierry Reding > >

[Intel-gfx] [PATCH v8 2/2] drm/dp: Set aux.dev to the drm_connector device, instead of drm_device.

2015-12-01 Thread Rafael Antognolli
On Tue, Nov 24, 2015 at 10:31:41PM +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2015 at 12:33:48PM -0800, Rafael Antognolli wrote: > > So far, the i915 driver and some other drivers set it to the drm_device, > > which doesn't allow one to know which DP a given aux chann

[PATCH v9 0/3] Add drm_dp_aux chardev support.

2015-12-03 Thread Rafael Antognolli
This series implement support to a drm_dp_aux chardev that allows reading and writing an arbitrary amount of bytes to arbitrary dpcd register addresses using regular read, write and lseek operations. Rafael Antognolli (3): drm/kms_helper: Add a common place to call init and exit functions

[PATCH v9 2/3] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-12-03 Thread Rafael Antognolli
unregister - other minor suggestions from Ville v7: - style fixes - error handling fixes v8: - more error handling fixes v9: - remove module_init and module_exit, and add drm_dp_aux_dev_init/exit to drm_kms_helper_init/exit. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/Kconfig

[PATCH v9 3/3] drm/dp: Set aux.dev to the drm_connector device, instead of drm_device.

2015-12-03 Thread Rafael Antognolli
f the drm_connector device now. Calling drm_dp_aux_unregister() before prevents them from being destroyed twice. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v9 1/3] drm/kms_helper: Add a common place to call init and exit functions.

2015-12-03 Thread Rafael Antognolli
The module_init and module_exit functions will start here, and call the subsequent init's and exit's. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/Makefile| 4 ++- drivers/gpu/drm/drm_fb_helper.c | 9 +++ drivers/gpu/drm/drm_kms_helper_com

[PATCH RFC v2 3/3] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-09-22 Thread Rafael Antognolli
On Tue, Sep 22, 2015 at 10:59:51AM +0200, Daniel Vetter wrote: > On Tue, Sep 15, 2015 at 04:55:04PM -0700, Rafael Antognolli wrote: > > This module is heavily based on i2c-dev. Once loaded, it provides one > > dev node per DP AUX channel, named drm_aux-N. > > > >

[PATCH RFC v2 0/3] Add a drm_aux-dev module.

2015-09-25 Thread Rafael Antognolli
thing to notice is that I am not updating the file offset during read or write, which is kind of breaking the filesystem abstraction. But i2c-dev doesn't do it either, so I assumed it's fine. Rafael Antognolli (3): drm/dp: Keep a list of drm_dp_aux helper. drm/dp: Store the drm_connec

[PATCH v3 1/2] drm/dp: Store the drm_connector device pointer on the helper.

2015-09-25 Thread Rafael Antognolli
This is useful to determine which connector owns this AUX channel. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 1 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[PATCH v3 0/2] Add drm_dp_aux chardev support.

2015-09-25 Thread Rafael Antognolli
onfig is now a boolean - add inline stub functions to avoid breakage when this option is disabled Rafael Antognolli (2): drm/dp: Store the drm_connector device pointer on the helper. drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers. drivers/gpu/drm/Kconfig

[PATCH v3 2/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-09-25 Thread Rafael Antognolli
f the connector device pointer was correctly set in the aux helper struct. Two main operations are provided on the registers read and write. The address of the register to be read or written is given using lseek. The seek position is updated upon read or write. Signed-off-by: Rafael Antognolli --- driver

[PATCH RFC v2 3/3] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-09-25 Thread Rafael Antognolli
On Tue, Sep 22, 2015 at 02:17:51PM +0200, Daniel Vetter wrote: > On Tue, Sep 22, 2015 at 03:00:54PM +0300, Ville Syrjälä wrote: > > On Tue, Sep 15, 2015 at 04:55:04PM -0700, Rafael Antognolli wrote: > > > This module is heavily based on i2c-dev. Once loaded, it provides one >

[PATCH RFC v2 0/3] Add a drm_aux-dev module.

2015-09-25 Thread Rafael Antognolli
Oops, sorry, this email shouldn't be in the patch set, please disconsider it. -- Rafael On Fri, Sep 25, 2015 at 04:54:53PM -0700, Rafael Antognolli wrote: > Second attempt at implementing a module that allows reading/writing arbitrary > dpcd registers. Changes to this version: >

[PATCH v4 0/2] Add drm_dp_aux chardev support.

2015-09-28 Thread Rafael Antognolli
onfig is now a boolean - add inline stub functions to avoid breakage when this option is disabled v4: - fix build system changes - actually disable this module when not selected. Rafael Antognolli (2): drm/dp: Store the drm_connector device pointer on the helper. drm/dp: Add a drm_aux-dev m

[PATCH v4 2/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-09-28 Thread Rafael Antognolli
f the connector device pointer was correctly set in the aux helper struct. Two main operations are provided on the registers read and write. The address of the register to be read or written is given using lseek. The seek position is updated upon read or write. Signed-off-by: Rafael Antognolli --- driver

[PATCH v4 1/2] drm/dp: Store the drm_connector device pointer on the helper.

2015-09-28 Thread Rafael Antognolli
This is useful to determine which connector owns this AUX channel. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 1 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[PATCH i-g-t] tests: Adding kms_dp_aux_dev test.

2015-09-28 Thread Rafael Antognolli
, to confirm 0 is returned - seek one more byte and confirm that EINVAL is returned - try to read 64 bytes when at 8 bytes from the end of the address space - try to read 64 bytes at the address 0. So far, no write checks are done. Signed-off-by: Rafael Antognolli

[PATCH v4 1/2] drm/dp: Store the drm_connector device pointer on the helper.

2015-09-29 Thread Rafael Antognolli
On Tue, Sep 29, 2015 at 02:49:20PM +0200, Lukas Wunner wrote: > Hi Rafael, > > On Mon, Sep 28, 2015 at 04:45:35PM -0700, Rafael Antognolli wrote: > > This is useful to determine which connector owns this AUX channel. > > WTF? I posted a patch in August which does

[PATCH v4 2/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-09-29 Thread Rafael Antognolli
Thanks Ville for the review, I'm addressing all the issues but have some questions on the ones mentioned below: On Tue, Sep 29, 2015 at 05:09:23PM +0300, Ville Syrjälä wrote: > On Mon, Sep 28, 2015 at 04:45:36PM -0700, Rafael Antognolli wrote: > > This module is heavily based on

Re: [PATCH libdrm] intel/intel_chipset.h: Sync Cannonlake IDs.

2018-03-05 Thread Rafael Antognolli
This is matching both the kernel and the spec. Reviewed-by: Rafael Antognolli . On Wed, Feb 14, 2018 at 05:42:24PM -0800, Rodrigo Vivi wrote: > Let's sync CNL ids with Spec and kernel. > > Sync with kernel commit '3f43031b1693 ("drm/i915/cnl: > Add Cannonlake PCI

re: [PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Rafael Monica
I cannot test it now, but last time the flush call was removed it caused a major regression on Evergreen. See: https://bugs.freedesktop.org/show_bug.cgi?id=34008 So please do not remove unless there are also no regressions on Evergreen. Thanks. ___ dri

[PATCH] r600g: remove useless call to u_upload_flush

2011-06-10 Thread Rafael Monica
I cannot test it now, but last time the flush call was removed it caused a major regression on Evergreen. See: https://bugs.freedesktop.org/show_bug.cgi?id=34008 So please do not remove unless there are also no regressions on Evergreen. Thanks.

[PATCH v5 0/2] Add drm_dp_aux chardev support.

2015-10-09 Thread Rafael Antognolli
- Remove "connector" attribute - set aux.dev to the connector drm_connector device, instead of drm_device Rafael Antognolli (2): drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers. drm/dp: Set aux.dev to the drm_connector device, instead of drm_device. dri

[PATCH v5 1/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-10-09 Thread Rafael Antognolli
f the connector device pointer was correctly set in the aux helper struct. Two main operations are provided on the registers read and write. The address of the register to be read or written is given using lseek. The seek position is updated upon read or write. Signed-off-by: Rafael Antognolli --- driver

[PATCH v5 2/2] drm/dp: Set aux.dev to the drm_connector device, instead of drm_device.

2015-10-09 Thread Rafael Antognolli
o the drm_connector. This also removes the need to add a sysfs link for the i2c device under the connector, as it will already be there. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/dr

[PATCH v4 1/2] drm/dp: Store the drm_connector device pointer on the helper.

2015-10-09 Thread Rafael Antognolli
s Wunner wrote: > > > > On Mon, Sep 28, 2015 at 04:45:35PM -0700, Rafael Antognolli wrote: > > > > > This is useful to determine which connector owns this AUX channel. > > > > > > > > WTF? I posted a patch in August which does exactly that

[PATCH 0/4] enable migration of driver pages

2015-07-13 Thread Rafael Aquini
x/kernel-page-flags.h | 1 + > mm/balloon_compaction.c| 72 ++ > mm/compaction.c| 8 ++-- > mm/migrate.c | 24 +++--- > 12 files changed, 160 insertions(+), 74 deletions(-) > > -- > 2.1.4 > Acked-by: Rafael Aquini

[PATCH v6 0/2] Add drm_dp_aux chardev support.

2015-10-29 Thread Rafael Antognolli
- Remove "connector" attribute - set aux.dev to the connector drm_connector device, instead of drm_device v6: - Use atomic_t for usage count - Use a mutex instead of spinlock for idr lock - Destroy chardev immediately on unregister - other minor suggestions from Ville Rafael Anto

[PATCH v6 2/2] drm/dp: Set aux.dev to the drm_connector device, instead of drm_device.

2015-10-29 Thread Rafael Antognolli
o the drm_connector. This also removes the need to add a sysfs link for the i2c device under the connector, as it will already be there. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/dr

[PATCH v6 1/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-10-29 Thread Rafael Antognolli
f the connector device pointer was correctly set in the aux helper struct. Two main operations are provided on the registers read and write. The address of the register to be read or written is given using lseek. The seek position is updated upon read or write. Signed-off-by: Rafael Antognolli --- driver

[PATCH v6 1/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-10-30 Thread Rafael Antognolli
On Fri, Oct 30, 2015 at 12:04:17PM +0200, Ville Syrjälä wrote: > On Thu, Oct 29, 2015 at 04:23:45PM -0700, Rafael Antognolli wrote: > > This module is heavily based on i2c-dev. Once loaded, it provides one > > dev node per DP AUX channel, named drm_dp_auxN, where N is an integer

[PATCH v7 0/2] Add drm_dp_aux chardev support.

2015-10-30 Thread Rafael Antognolli
This series implement support to a drm_dp_aux chardev that allows reading and writing an arbitrary amount of bytes to arbitrary dpcd register addresses using regular read, write and lseek operations. Rafael Antognolli (2): drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers

[PATCH v7 1/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-10-30 Thread Rafael Antognolli
unregister - other minor suggestions from Ville v7: - style fixes - error handling fixes Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/Kconfig | 8 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_dp_aux_dev.c | 374 +++ drivers/gpu/d

[PATCH v7 2/2] drm/dp: Set aux.dev to the drm_connector device, instead of drm_device.

2015-10-30 Thread Rafael Antognolli
o the drm_connector. This also removes the need to add a sysfs link for the i2c device under the connector, as it will already be there. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/dr

[RFC 11/13] drm/dp: Add helper to dump DPCD

2015-09-03 Thread Rafael Antognolli
Hi, I'm back from vacation, so I'll be looking at this again. On Thu, Aug 20, 2015 at 04:26:42PM -0700, Rafael Antognolli wrote: > On Mon, Aug 17, 2015 at 10:02:04AM +0300, Jani Nikula wrote: > > On Fri, 14 Aug 2015, Rafael Antognolli > > wrote: > > > On Fri

[PATCH 0/3] RFC: Add a drm_aux-dev module.

2015-09-14 Thread Rafael Antognolli
or this kind of implementation. Or, if it's nothing like this, let me know what else you had in mind. If I'm going in the right direction, I'll refine the patch to provide full documentation and tests if needed. Rafael Antognolli (3): drm/dp: Keep a list of drm_dp_aux helper. d

[PATCH 2/3] drm/dp: Store the drm_connector device pointer on the helper.

2015-09-14 Thread Rafael Antognolli
This is useful to determine which connector owns this AUX channel. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 1 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[PATCH 1/3] drm/dp: Keep a list of drm_dp_aux helper.

2015-09-14 Thread Rafael Antognolli
This list will be used to get the aux channels registered through the helpers. Two functions are provided to register/unregister notifier listeners on the list, and another functiont to iterate over the list of aux channels. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/drm_dp_helper.c

[PATCH 3/3] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-09-14 Thread Rafael Antognolli
e len field of the struct. Signed-off-by: Rafael Antognolli --- Documentation/ioctl/ioctl-number.txt | 1 + drivers/gpu/drm/Kconfig | 4 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_aux-dev.c| 390 +++ include

[PATCH 1/3] drm/dp: Keep a list of drm_dp_aux helper.

2015-09-15 Thread Rafael Antognolli
On Tue, Sep 15, 2015 at 10:46:43AM +0300, Ville Syrjälä wrote: > On Mon, Sep 14, 2015 at 04:12:30PM -0700, Rafael Antognolli wrote: > > This list will be used to get the aux channels registered through the > > helpers. Two functions are provided to register/unregister notifier &

[PATCH 0/3] RFC: Add a drm_aux-dev module.

2015-09-15 Thread Rafael Antognolli
On Tue, Sep 15, 2015 at 10:35:19AM +0300, Ville Syrjälä wrote: > On Mon, Sep 14, 2015 at 04:12:29PM -0700, Rafael Antognolli wrote: > > This is a tentative implementation of a module that allows reading/writing > > arbitrary dpcd registers, following the suggestion from Da

[PATCH 0/3] RFC: Add a drm_aux-dev module.

2015-09-15 Thread Rafael Antognolli
On Tue, Sep 15, 2015 at 07:46:55PM +0300, Ville Syrjälä wrote: > On Tue, Sep 15, 2015 at 07:41:06PM +0300, Ville Syrjälä wrote: > > On Tue, Sep 15, 2015 at 09:34:15AM -0700, Rafael Antognolli wrote: > > > On Tue, Sep 15, 2015 at 10:35:19AM +0300, Ville Syrjälä wrote: >

[PATCH RFC v2 0/3] Add a drm_aux-dev module.

2015-09-15 Thread Rafael Antognolli
thing to notice is that I am not updating the file offset during read or write, which is kind of breaking the filesystem abstraction. But i2c-dev doesn't do it either, so I assumed it's fine. Rafael Antognolli (3): drm/dp: Keep a list of drm_dp_aux helper. drm/dp: Store the drm_connec

[PATCH RFC v2 1/3] drm/dp: Keep a list of drm_dp_aux helper.

2015-09-15 Thread Rafael Antognolli
This list will be used to get the aux channels registered through the helpers. One function is provided to set a callback for added/removed aux channels, and another function to iterate over the list of aux channels. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/drm_dp_helper.c | 73

[PATCH RFC v2 2/3] drm/dp: Store the drm_connector device pointer on the helper.

2015-09-15 Thread Rafael Antognolli
This is useful to determine which connector owns this AUX channel. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/i915/intel_dp.c | 1 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[PATCH RFC v2 3/3] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

2015-09-15 Thread Rafael Antognolli
r was correctly set in the aux helper struct. Two main operations are provided on the registers: read and write. The address of the register to be read or written is given using lseek. Reading or writing does not update the offset of the file. Signed-off-by: Rafael Antognolli --- drivers/gpu/drm/Kc

[PATCH 0/3] RFC: Add a drm_aux-dev module.

2015-09-16 Thread Rafael Antognolli
On Wed, Sep 16, 2015 at 11:47:21PM +0300, Ville Syrjälä wrote: > On Wed, Sep 16, 2015 at 01:09:54PM -0700, Daniel Vetter wrote: > > On Tue, Sep 15, 2015 at 10:03:09AM -0700, Rafael Antognolli wrote: > > > On Tue, Sep 15, 2015 at 07:46:55PM +0300, Ville Syrjälä wrote: >

Re: [PATCH 2/2] drm/bridge: lt8912b: Add support for audio

2025-02-04 Thread Rafael Beims
On 03/02/2025 16:23, raf...@beims.me wrote: From: Rafael Beims Add support for HDMI codec with audio coming from the I2S input. Support 48kHz and 96kHz sample rate, with 16 bits word size. Co-developed-by: João Paulo Gonçalves Signed-off-by: João Paulo Gonçalves Signed-off-by: Rafael Beims

Re: NVIDIA GPU fallen off the bus after exiting s2idle

2021-05-06 Thread Rafael J. Wysocki
On Tue, May 4, 2021 at 10:08 AM Chris Chiu wrote: > > Hi, > We have some Intel laptops (11th generation CPU) with NVIDIA GPU > suffering the same GPU falling off the bus problem while exiting > s2idle with external display connected. These laptops connect the > external display via the HDMI/Di

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Rafael J. Wysocki
On Sat, May 8, 2021 at 9:41 AM Stephen Boyd wrote: > > The device lists are poorly ordered when the component device code is > used. This is because component_master_add_with_match() returns 0 > regardless of component devices calling component_add() first. It can > really only fail if an allocati

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Rafael J. Wysocki
On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: [cut] > > > > > > I will try it, but then I wonder about things like system wide > > > suspend/resume too. The drm encoder chain would need to reimplement the > > > logic for system wide suspend/resume so that any PM ops attached to the > > > m

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Rafael J. Wysocki
On Tue, May 11, 2021 at 7:00 PM Stephen Boyd wrote: > > Quoting Rafael J. Wysocki (2021-05-11 03:52:06) > > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > > > [cut] > > > > > > > > > > > > > > I will try it, but then I

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley wrote: > > On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > > wrote: [cut] > > > > Maintainers routinely review 1-line trivial patches, not to mention > > internal API changes, etc. > >

Re: [PATCH v4] Add power/gpu_frequency tracepoint.

2020-11-17 Thread Rafael J. Wysocki
On 11/16/2020 10:05 PM, Steven Rostedt wrote: On Mon, 16 Nov 2020 12:55:29 -0800 Peiyong Lin wrote: Hi there, May I ask whether the merge window has passed? If so is it possible to ask for a review? This is up to the maintainers of power management to accept this. Rafael? I'd say

[PATCH v1 2/7] nouveau: ACPI: Use the ACPI_COMPANION() macro directly

2021-10-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION() macro and the ACPI handle produced by the former comes from the ACPI device object produced by the latter, so it is way more straightforward to evaluate the latter directly instead of passing the handle

[PATCH v2 2/7] nouveau: ACPI: Use the ACPI_COMPANION() macro directly

2021-10-13 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION() macro and the ACPI handle produced by the former comes from the ACPI device object produced by the latter, so it is way more straightforward to evaluate the latter directly instead of passing the handle

Re: acpi_get_devices() crash when acpi_disabled==true (was [PATCH v2] drm/privacy-screen: honor acpi=off in detect_thinkpad_privacy_screen)

2022-01-26 Thread Rafael J. Wysocki
acpi, > and at a first glance about half of those are missing an acpi_disabled > check. IMHO it would be better to simply add an acpi_disabled check to > acpi_get_devices() itself. > > Rafael, do you agree ? Yes, I do. > Note the just added chrome privacy-screen check uses > acpi_

Re: acpi_get_devices() crash when acpi_disabled==true (was [PATCH v2] drm/privacy-screen: honor acpi=off in detect_thinkpad_privacy_screen)

2022-01-26 Thread Rafael J. Wysocki
On Wed, Jan 26, 2022 at 5:41 PM Hans de Goede wrote: > > Hi, > > On 1/26/22 16:54, Rafael J. Wysocki wrote: > > On Wed, Jan 26, 2022 at 2:47 PM Hans de Goede wrote: > >> > >> Hi All, > >> > >> On 1/23/22 10:10, Tong Zhang wrote: > &g

Re: acpi_get_devices() crash when acpi_disabled==true (was [PATCH v2] drm/privacy-screen: honor acpi=off in detect_thinkpad_privacy_screen)

2022-01-27 Thread Rafael J. Wysocki
On Thu, Jan 27, 2022 at 2:05 PM Hans de Goede wrote: > > Hi, > > On 1/26/22 18:11, Rafael J. Wysocki wrote: > > On Wed, Jan 26, 2022 at 5:41 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 1/26/22 16:54, Rafael J. Wysocki wrote: >

Re: [PATCH v14 20/39] pwm: tegra: Add runtime PM and OPP support

2021-10-29 Thread Rafael J. Wysocki
On Fri, Oct 29, 2021 at 5:20 PM Dmitry Osipenko wrote: > > 26.10.2021 01:40, Dmitry Osipenko пишет: > > + ret = devm_pm_runtime_enable(&pdev->dev); > > + if (ret) > > + return ret; > > + > > + ret = devm_tegra_core_dev_init_opp_table_common(&pdev->dev); > > + if (ret) >

Re: [PATCH v14 20/39] pwm: tegra: Add runtime PM and OPP support

2021-10-29 Thread Rafael J. Wysocki
On Fri, Oct 29, 2021 at 6:29 PM Dmitry Osipenko wrote: > > 29.10.2021 18:56, Rafael J. Wysocki пишет: > > On Fri, Oct 29, 2021 at 5:20 PM Dmitry Osipenko wrote: > >> > >> 26.10.2021 01:40, Dmitry Osipenko пишет: > >>> + ret = devm_pm_runti

Re: [PATCH v2 12/63] thermal: intel: int340x_thermal: Use struct_group() for memcpy() region

2021-11-23 Thread Rafael J. Wysocki
On Wed, Aug 18, 2021 at 8:08 AM Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), avoid intentionally writing across > neighboring fields. > > Use struct_group() in struct art around members weight, and ac[0-9]_max, >

Re: [PATCH v2 12/63] thermal: intel: int340x_thermal: Use struct_group() for memcpy() region

2021-11-24 Thread Rafael J. Wysocki
On Wed, Nov 24, 2021 at 12:53 AM Srinivas Pandruvada wrote: > > On Tue, 2021-11-23 at 14:19 +0100, Rafael J. Wysocki wrote: > > On Wed, Aug 18, 2021 at 8:08 AM Kees Cook > > wrote: > > > > > > In preparation for FORTIFY_SOURCE performing compile-time an

Re: Regression report on laptop suspend

2021-12-27 Thread Rafael J. Wysocki
CC Daniel, Thomas and dri-devel. On Mon, Dec 27, 2021 at 5:32 PM wrote: > > Hello > > I've noticed my laptop totally freeze when going to hibernation. > The git bisect log is appended below. > Please note however that even the previous good commit was "good" (ie : > laptop managed to suspend and

Re: [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2019-01-21 Thread Rafael J. Wysocki
On Mon, Jan 21, 2019 at 4:17 PM Vincent Guittot wrote: > > On Fri, 18 Jan 2019 at 13:08, Guenter Roeck wrote: > > > > On 1/18/19 3:05 AM, Rafael J. Wysocki wrote: > > > On Fri, Jan 18, 2019 at 11:53 AM Vincent Guittot > > > wrote: > > >> >

Re: Armada DRM: bridge with componentized devices

2019-01-24 Thread Rafael J. Wysocki
On Friday, January 18, 2019 1:57:47 PM CET Daniel Vetter wrote: > On Fri, Jan 18, 2019 at 12:38 PM Rafael J. Wysocki wrote: > > > > On Fri, Jan 18, 2019 at 12:17 PM Rafael J. Wysocki > > wrote: > > > > > > On Fri, Jan 18, 2019 at 12:06 PM Daniel Vetter

Re: [PATCH 1/2] component: Add documentation

2019-02-05 Thread Rafael J. Wysocki
onstituing components. > > But that's way more than a quick doc typing exercise ... > > Thanks to Ram for commenting on an initial draft of these docs. Look goods to me overall (even though I'm not super-familiar with the component framework), but see below. > Cc: "C, Ramal

Re: [PATCH] component: Add documentation

2019-02-06 Thread Rafael J. Wysocki
way more than a quick doc typing exercise ... > > Thanks to Ram for commenting on an initial draft of these docs. > > v2: Review from Rafael: > - git add Documenation/driver-api/component.rst > - lots of polish to the wording + spelling fixes. > > v3: Review from Russell: &g

Re: [PATCH 2/3] components: multiple components for a device

2019-02-06 Thread Rafael J. Wysocki
(v1 code) > Signed-off-by: Ramalingam C (v1 commit message) > Cc: Ramalingam C > Cc: Greg Kroah-Hartman > Cc: Russell King > Cc: Rafael J. Wysocki > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Rodrigo Vivi > Cc: Jani Nikula

Re: [PATCH 2/3] components: multiple components for a device

2019-02-07 Thread Rafael J. Wysocki
On Thu, Feb 7, 2019 at 11:40 PM Daniel Vetter wrote: > > On Wed, Feb 06, 2019 at 11:57:04PM +0100, Rafael J. Wysocki wrote: > > ) On Wed, Feb 6, 2019 at 5:46 PM Daniel Vetter > > wrote: > > > > > > Component framework is extended to support multiple compone

Re: [PATCH 2/4] components: multiple components for a device

2019-02-07 Thread Rafael J. Wysocki
fferent components > with different subcomponent value, which will be matched to two > different component masters(Audio and HDCP) based on the subcomponent > values. > > v2: Add documenation. > > v3: Rebase on top of updated documenation. > > v4: Review from Rafael: > - Rem

Re: [PATCH v2 3/3] drm/i915: Move to new PM core fields

2018-12-18 Thread Rafael J. Wysocki
On Mon, Dec 17, 2018 at 3:22 PM Vincent Guittot wrote: > > On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote: > > > > On Fri, 14 Dec 2018 at 15:22, Vincent Guittot > > wrote: > > > > > > With jiffies been replaced by raw ns in PM core accounting, 915 driver is > > > updated to use this new time in

Re: [PATCH v2 3/3] drm/i915: Move to new PM core fields

2018-12-18 Thread Rafael J. Wysocki
On Tue, Dec 18, 2018 at 10:58 AM Vincent Guittot wrote: > > On Tue, 18 Dec 2018 at 10:57, Rafael J. Wysocki wrote: > > > > On Mon, Dec 17, 2018 at 3:22 PM Vincent Guittot > > wrote: > > > > > > On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote: &g

  1   2   3   4   5   6   7   >