Re: [PATCH v2 04/13] drm/bridge: lt9611: fix programming of video modes

2023-01-12 Thread Neil Armstrong
)(hsync_porch / 256) | + ((hfront_porch / 256) << 4)); regmap_write(lt9611->regmap, 0x831b, (u8)(hsync_porch % 256)); } Reviewed-by: Neil Armstrong

Re: [PATCH v2 05/13] drm/bridge: lt9611: fix clock calculation

2023-01-12 Thread Neil Armstrong
e, <9611->connector, Reviewed-by: Neil Armstrong

Re: [PATCH v2 06/13] drm/bridge: lt9611: pass a pointer to the of node

2023-01-12 Thread Neil Armstrong
+ const struct mipi_dsi_device_info info = { "lt9611", 0, lt9611->dev->of_node}; struct mipi_dsi_device *dsi; struct mipi_dsi_host *host; struct device *dev = lt9611->dev; Reviewed-by: Neil Armstrong

Re: [PATCH v2 09/13] drm/bridge: lt9611: fix sync polarity for DVI output

2023-01-12 Thread Neil Armstrong
ector->display_info.is_hdmi); lt9611_hdmi_tx_phy(lt9611); msleep(500); Reviewed-by: Neil Armstrong

Re: [v3, 3/7] drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement

2023-01-12 Thread Neil Armstrong
On 11/01/2023 13:41, Marek Szyprowski wrote: On 02.11.2022 19:07, Dmitry Baryshkov wrote: Use drm_connector's helpers enable_hpd and disable_hpd to enable and disable HPD automatically by the means of drm_kms_helper_poll_* functions. As the drm_bridge_connector_enable_hpd() and drm_bridge_connec

Re: [PATCH v2 13/13] drm/bridge: lt9611: properly program the dual host mode

2023-01-12 Thread Neil Armstrong
regmap_write(lt9611->regmap, 0x8348, hact / 256); + regmap_write(lt9611->regmap, 0x8349, hact % 256); + } regmap_write(lt9611->regmap, 0x8326, pcr_m); Reviewed-by: Neil Armstrong

Re: [PATCH v2 11/13] drm/bridge: lt9611: rework infoframes handling

2023-01-12 Thread Neil Armstrong
nfoframes(lt9611, connector, mode); lt9611_hdmi_tx_digital(lt9611, connector->display_info.is_hdmi); lt9611_hdmi_tx_phy(lt9611); Reviewed-by: Neil Armstrong

Re: [PATCH 2/2] drm/msm/dpu: don't use DPU_CLK_CTRL_CURSORn for DMA SSPP clocks

2023-01-16 Thread Neil Armstrong
dpu1/dpu_hw_catalog.h index 56d98b4dd2ac..9c96920e1849 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h @@ -513,6 +513,8 @@ enum dpu_clk_ctrl_type { DPU_CLK_CTRL_DMA1, DPU_CLK_CTRL_DMA2, DPU_CLK_CTRL_DMA3, + DPU_

Re: [PATCH 1/3] drm/msm/dpu: fix blend setup for DMA4 and DMA5 layers

2023-01-16 Thread Neil Armstrong
On 16/01/2023 07:33, Dmitry Baryshkov wrote: SM8550 uses new register to map SSPP_DMA4 and SSPP_DMA5 units to blend stages. Add proper support for this register to allow using these two planes for image processing. Fixes: efcd0107727c ("drm/msm/dpu: add support for SM8550") Cc: Neil

Re: [PATCH 2/3] drm/msm/dpu: simplify ctl_setup_blendstage calculation

2023-01-16 Thread Neil Armstrong
|= mix_ext << 20; break; case SSPP_CURSOR1: - mixercfg_ext |= ((i + 1) & 0xF) << 26; + mixercfg_ext |= mix_ext << 26; break; default: break; Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8550

Re: [PATCH 3/3] drm/msm/dpu: simplify blend configuration

2023-01-16 Thread Neil Armstrong
lm), mixercfg_ext3); + DPU_REG_WRITE(c, CTL_LAYER(lm), mixercfg[0]); + DPU_REG_WRITE(c, CTL_LAYER_EXT(lm), mixercfg[1]); + DPU_REG_WRITE(c, CTL_LAYER_EXT2(lm), mixercfg[2]); + DPU_REG_WRITE(c, CTL_LAYER_EXT3(lm), mixercfg[3]); if ((test_bit(DPU_CTL_HAS_LAYER_EXT4, &ctx->caps->features))) - DPU_REG_WRITE(c, CTL_LAYER_EXT4(lm), mixercfg_ext4); + DPU_REG_WRITE(c, CTL_LAYER_EXT4(lm), mixercfg[4]); } Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8550

Re: [PATCH 12/13] drm/bridge: lt9611: stop filtering modes via the table

2023-01-18 Thread Neil Armstrong
t; 30) + return MODE_CLOCK_HIGH; + + if (mode->hdisplay > 2000 && !lt9611->dsi1_node) return MODE_PANEL; else return MODE_OK; Reviewed-by: Neil Armstrong

Re: [RFC PATCH v3 1/3] drm/mipi-dsi: Fix byte order of 16-bit DCS set/get brightness

2023-01-18 Thread Neil Armstrong
c_write_seq - transmit data using a generic write packet Reviewed-by: Neil Armstrong

Re: [RFC PATCH v3 3/3] drm/panel: vtdr6130: Use 16-bit brightness function

2023-01-18 Thread Neil Armstrong
BRIGHTNESS, -payload, sizeof(payload)); + mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); if (ret < 0) return ret; Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8550-MTP Thanks !

Re: [RFC PATCH v3 2/3] drm/panel: sofef00: Use 16-bit brightness function

2023-01-18 Thread Neil Armstrong
err; Reviewed-by: Neil Armstrong

Re: [PATCH 00/13] drm/bridge: lt9611: several fixes and improvements

2023-01-18 Thread Neil Armstrong
Hi, On Wed, 18 Jan 2023 10:16:45 +0200, Dmitry Baryshkov wrote: > A series of patches to fix mode programming for the Lontium lt9611 > DSI-to-HDMI bridge (found e.g. on the Thundercomm RB3/Dragonboard845c > platform). > > Changes since v2: > - Rewrote mode_valid callback to be more explicit. >

Re: [RFC PATCH v3 0/3] drm/mipi-dsi: 16-bit Brightness Endianness Fix

2023-01-18 Thread Neil Armstrong
Hi, On Mon, 16 Jan 2023 17:49:06 -0500, Richard Acayan wrote: > Changes since v2 (20230114010006.50471-1-mailingrad...@gmail.com): > - patch vtdr6130 to use _large (3/3) > - remove Change-Id again (1/3) > - change patch subject (1-2/3) > - correct function name in patch description (2/3) > -

Re: [RFC PATCH v3 0/3] drm/mipi-dsi: 16-bit Brightness Endianness Fix

2023-01-18 Thread Neil Armstrong
On 19/01/2023 08:14, Sam Ravnborg wrote: Hi Richard. On Mon, Jan 16, 2023 at 05:49:06PM -0500, Richard Acayan wrote: Changes since v2 (20230114010006.50471-1-mailingrad...@gmail.com): - patch vtdr6130 to use _large (3/3) - remove Change-Id again (1/3) - change patch subject (1-2/3) - cor

Re: [PATCH] drm/bridge: sii902x: Allow reset line to be tied to a sleepy GPIO controller

2023-01-18 Thread Neil Armstrong
Hi, On Wed, 28 Dec 2022 15:57:04 +0100, Wadim Egorov wrote: > Switch to gpiod_set_value_cansleep() in sii902x_reset(). > This is relevant if the reset line is tied to a I2C GPIO > controller. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm

Re: [PATCH 1/1] drm/bridge: sii902x: Use dev_err_probe

2023-01-18 Thread Neil Armstrong
Hi, On Tue, 17 Jan 2023 11:59:03 +0100, Alexander Stein wrote: > This helps figuring out why the device probe is deferred. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/bridge: sii902x: Use dev_err_probe https://cgit.freedesktop.o

Re: [PATCH] dt-bindings: display: bridge: renesas,rzg2l-mipi-dsi: Document RZ/V2L support

2023-01-18 Thread Neil Armstrong
Hi, On Tue, 22 Nov 2022 19:54:13 +, Biju Das wrote: > Document RZ/V2L DSI bindings. RZ/V2L MIPI DSI is identical to one found on > the RZ/G2L SoC. No driver changes are required as generic compatible > string "renesas,rzg2l-mipi-dsi" will be used as a fallback. > > Thanks, Applied to https:

Re: [PATCH v2] drm/bridge: tc358767: Use devm_clk_get_enabled() helper

2023-01-18 Thread Neil Armstrong
Hi Christophe, On 30/12/2022 17:00, Christophe JAILLET wrote: The devm_clk_get_enabled() helper: - calls devm_clk_get() - calls clk_prepare_enable() and registers what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code a

Re: [PATCH 1/1] drm: bridge: ldb: Warn if LDB clock does not match requested link frequency

2023-01-18 Thread Neil Armstrong
_prepare_enable(fsl_ldb->clk); /* Program LDB_CTRL */ Reviewed-by: Neil Armstrong

Re: [PATCH 1/1] drm: bridge: ldb: Warn if LDB clock does not match requested link frequency

2023-01-18 Thread Neil Armstrong
Hi, On Thu, 08 Dec 2022 07:55:38 +0100, Alexander Stein wrote: > The LDB clock needs to be exactly 7-times the pixel clock used by the > display. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm: bridge: ldb: Warn if LDB clock does not matc

[PATCH] drm/panel: vtdr6130: fix unused ret in visionox_vtdr6130_bl_update_status

2023-01-19 Thread Neil Armstrong
Fix the following warning: panel-visionox-vtdr6130.c:249:12: warning: 'ret' is used uninitialized [-Wuninitialized] Fixes: 9402cde9347e ("drm/panel: vtdr6130: Use 16-bit brightness function") Reported-by: Daniel Vetter Reported-by: kernel test robot Signed-off-by: Neil Arm

Re: [PATCH] drm/panel: vtdr6130: fix unused ret in visionox_vtdr6130_bl_update_status

2023-01-19 Thread Neil Armstrong
Hi, On Thu, 19 Jan 2023 15:04:12 +0100, Neil Armstrong wrote: > Fix the following warning: > panel-visionox-vtdr6130.c:249:12: warning: 'ret' is used uninitialized > [-Wuninitialized] > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-mi

Re: [PATCH v3 0/2] drm/bridge: fsl-ldb: Add i.MX93 LDB support

2023-01-23 Thread Neil Armstrong
Hi, On Mon, 23 Jan 2023 10:14:47 +0800, Liu Ying wrote: > This patch set aims to add i.MX93 LVDS Display Bridge(LDB) support in > the existing i.MX8mp LDB DRM bridge driver. Same to i.MX8mp LDB, i.MX93 > LDB is controlled by mediamix blk-ctrl through two registers. i.MX93 > LDB supports only one

Re: [PATCH v3 1/2] drm/probe_helper: extract two helper functions

2023-01-24 Thread Neil Armstrong
tor_helper_funcs *funcs = - connector->helper_private; - - if (funcs && funcs->disable_hpd) - funcs->disable_hpd(connector); - } - drm_connector_list_iter_end(&conn_iter); + drm_kms_helper_disable_hpd(dev); cancel_delayed_work_sync(&dev->mode_config.output_poll_work); } Reviewed-by: Neil Armstrong

Re: [PATCH v1 09/14] drm/msm/dsi: export struct msm_compression_info to dpu encoder

2023-01-24 Thread Neil Armstrong
On 23/01/2023 19:24, Kuogee Hsieh wrote: struct msm_compression_info is used to support several different compression mechanisms. It also contains customized info required to configure DSC encoder engine. This patch also make changes DSI module to have DSI exports struct msm_compreion_info to dpu

Re: [PATCH v1 06/14] drm/msm/dp: add display compression related struct

2023-01-24 Thread Neil Armstrong
On 23/01/2023 19:24, Kuogee Hsieh wrote: Add display compression related struct to support variant compression mechanism. However, DSC is the only one supported at this moment. VDC may be added later. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.h | 42 ++

Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-24 Thread Neil Armstrong
On 23/01/2023 19:24, Kuogee Hsieh wrote: DSC V1.2 encoder engine is newly added hardware module. This patch add support functions to configure and enable DSC V1.2 encoder engine. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/

Re: [PATCH v1 13/14] drm/msm/disp/dpu1: add dsc supporting functions to dpu encoder

2023-01-25 Thread Neil Armstrong
On 23/01/2023 19:24, Kuogee Hsieh wrote: Since display Port is an external peripheral, runtime compression detection is added to handle plug in and unplugged events. Currently only DSC compression supported. Once DSC compression detected, topology is static added and used to allocate system resou

Re: [PATCH v1 12/14] drm/msm/disp/dpu1: revise timing engine programming to work for DSC

2023-01-25 Thread Neil Armstrong
On 25/01/2023 00:36, Marijn Suijten wrote: On 2023-01-24 09:55:24, Kuogee Hsieh wrote: This timing engine code is derived from our downstream code directly and it has been used at many mobile devices by many vendors for many years already. On the other words, it had been tested very thorough

Re: [PATCH] drm/msm/dpu: Add DSC hardware blocks to register snapshot

2023-01-25 Thread Neil Armstrong
s->mmio + cat->mdp[0].base, "top"); Thanks for the addition, it was missing :-) Reviewed-by: Neil Armstrong

Re: [PATCH] drm/bridge: Kconfig: fix a spelling mistake

2023-01-25 Thread Neil Armstrong
On 25/01/2023 00:34, Randy Dunlap wrote: Correct a spelling mistake (reported by codespell). Signed-off-by: Randy Dunlap Cc: Jagan Teki Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Reviewed-by: Neil

Re: [PATCH v3 2/2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-25 Thread Neil Armstrong
Hi, On 24/01/2023 11:45, Dmitry Baryshkov wrote: There are two flags attemting to guard connector polling: poll_enabled and poll_running. While poll_enabled semantics is clearly defined and fully adhered (mark that drm_kms_helper_poll_init() was called and not finalized by the _fini() call), the

Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-10-05 Thread neil . armstrong
ty to something more specific like: ite,dp-output-data-lane-count Use the same naming scheme for the other property: ite,dp-output-max-pixel-clock-khz Neil -Original Message----- From: Neil Armstrong Sent: Thursday, September 29, 2022 4:40 PM To: Allen Chen (陳柏宇) Cc: open list:OP

Re: [PATCH v4 1/4] gpu: drm: meson: Use devm_regulator_*get_enable*()

2022-10-21 Thread Neil Armstrong
meson_dw_hdmi->hdmitx_apb = devm_reset_control_get_exclusive(dev, "hdmitx_apb"); Reviewed-by: Neil Armstrong

Re: [PATCH v4 1/4] gpu: drm: meson: Use devm_regulator_*get_enable*()

2022-10-21 Thread Neil Armstrong
Hi, On 21/10/2022 17:02, Laurent Pinchart wrote: Hi Matti, On Fri, Oct 21, 2022 at 04:18:01PM +0300, Matti Vaittinen wrote: Simplify using the devm_regulator_get_enable_optional(). Also drop the seemingly unused struct member 'hdmi_supply'. Signed-off-by: Matti Vaittinen --- v3 => v4: - spl

Re: [PATCH 3/3] spi: meson-spicc: Lower CS between bursts

2022-11-17 Thread Neil Armstrong
Hi, On 17/11/2022 09:47, Carlo Caione wrote: On some hardware (reproduced on S905X) when a large payload is transmitted over SPI in bursts at the end of each burst, the clock line briefly fluctuates creating spurious clock transitions that are being recognised by the connected device as a genuin

Re: [PATCH v4 09/11] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-23 Thread Neil Armstrong
Hi, On 23/11/2022 00:12, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers during snapshot. Tested-by: Vinod Koul Reviewed-by: Vinod Koul Reviewed-by: Konrad Dy

Re: [PATCH v2 1/2] drm/tiny: rpi-lcd-35: Enable driver module autoloading

2022-11-29 Thread Neil Armstrong
); static const struct spi_device_id ili9486_id[] = { { "ili9486", 0 }, + { "rpi-lcd-35", 0 }, It should also contain "piscreen" then. Anyway: Reviewed-by: Neil Armstrong { } }; MODULE_DEVICE_TABLE(spi, ili9486_id);

Re: [PATCH v2 2/2] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-29 Thread Neil Armstrong
ine, but should somehow be tested on an RPi first to check if the 8bit fallback still works. Reviewed-by: Neil Armstrong

[PATCH] drm/panel: khadas-ts050: update timings to achieve 60Hz refresh rate

2022-10-25 Thread neil . armstrong
From: Neil Armstrong This updates the panel timings to achieve a clean 60Hz refresh rate. Signed-off-by: Neil Armstrong --- To: Sam Ravnborg To: David Airlie To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org --- drivers/gpu/drm/panel/panel-khadas-ts050

Re: [PATCH] drm/bridge: it6505: Fix return value check for pm_runtime_get_sync

2022-10-27 Thread Neil Armstrong
Hi, On Thu, 27 Oct 2022 11:21:49 +0800, Pin-yen Lin wrote: > `pm_runtime_get_sync` may return 1 on success. Fix the `if` statement > here to make the code less confusing, even though additional calls to > `it6505_poweron` doesn't break anything when it's already powered. > > This was reported by

Re: [PATCH v2] drm: bridge: adv7511: use dev_err_probe in probe function

2022-10-28 Thread Neil Armstrong
Hi, On Wed, 26 Oct 2022 14:52:46 +0200, Ahmad Fatoum wrote: > adv7511 probe may need to be attempted multiple times before no > -EPROBE_DEFER is returned. Currently, every such probe results in > an error message: > > [4.534229] adv7511 1-003d: failed to find dsi host > [4.580288] adv7511

Re: [RESEND PATCH v2] drm/bridge: dw-hdmi-i2s: set insert_pcuv bit if hardware supports it

2022-10-31 Thread Neil Armstrong
Hi, On 17/10/2022 14:04, Geraldo Nascimento wrote: Hi Mark, resending this as it failed to apply in my last submission. Added Neil Armstrong to Cc: as hopefully he will be able to better review this. Thanks, Geraldo Nascimento --- Starting with version 2.10a of Synopsys DesignWare HDMI

Re: [PATCH] drm/meson: Fix return type of meson_encoder_cvbs_mode_valid()

2022-11-03 Thread Neil Armstrong
Hi, On Wed, 2 Nov 2022 08:52:42 -0700, Nathan Chancellor wrote: > With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), > indirect call targets are validated against the expected function > pointer prototype to make sure the call target is valid to help mitigate > ROP attacks. If th

Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-01 Thread Neil Armstrong
357,8 @@ static void meson_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, state->period = 0; state->duty_cycle = 0; } + + return 0; } static const struct pwm_ops meson_pwm_ops = { For pwm-meson: Reviewed-by: Neil Armstrong

Re: [PATCH] drm: bridge: dw_hdmi: fix preference of RGB modes over YUV420

2022-12-01 Thread Neil Armstrong
Hi, On Wed, 16 Nov 2022 15:35:23 +0100, Guillaume BRUN wrote: > Cheap monitors sometimes advertise YUV modes they don't really have > (HDMI specification mandates YUV support so even monitors without actual > support will often wrongfully advertise it) which results in YUV matches > and user forum

Re: [PATCH RESEND2 v4 2/2] drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()

2022-12-01 Thread Neil Armstrong
On 30/11/2022 10:23, Matti Vaittinen wrote: Simplify using the devm_regulator_get_enable_optional(). Also drop the now unused struct member 'hdmi_supply'. Signed-off-by: Matti Vaittinen Martin Blumenstingl Missing Acked-by, I'll add it while applying. Neil --- v4 resend 2: Respinning unc

Re: [PATCH RESEND2 v4 0/2] Use devm helpers for regulator get and enable

2022-12-01 Thread Neil Armstrong
Hi, On Wed, 30 Nov 2022 11:21:51 +0200, Matti Vaittinen wrote: > Simplify couple of drivers by using the new devm_regulator_*get_enable*() > > These patches were previously part of the series: > https://lore.kernel.org/lkml/cover.1660934107.git.mazziesacco...@gmail.com/ > "Devm helpers for regula

Re: [PATCH v3 3/3] drm/tiny: ili9486: remove conflicting framebuffers

2022-12-06 Thread Neil Armstrong
Hi Carlo, On 06/12/2022 09:34, Carlo Caione wrote: For platforms using simplefb / efifb, call drm_aperture_remove_framebuffers() to remove the conflicting framebuffer. Conflicting framebuffer on the SPI display ? How is that possible ? The meson_drm should already do this, no ? Neil Signe

Re: [PATCH] drm/meson: Reduce the FIFO lines held when AFBC is not used

2022-12-19 Thread Neil Armstrong
patch). Acked-by: Martin Blumenstingl Yep I'll add the Fixes tag when applying Thank Carlo ! Acked-by: Neil Armstrong

Re: [PATCH v4 0/2] Make ILI9486 driver working with 16-bits SPI controllers

2022-12-19 Thread Neil Armstrong
mlesh Gurudasani To: David Airlie To: Daniel Vetter To: Mark Brown To: Neil Armstrong To: Kevin Hilman To: Jerome Brunet To: Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-amlo...@lists.infradead.org S

Re: [PATCH] drm/meson: Reduce the FIFO lines held when AFBC is not used

2023-01-02 Thread Neil Armstrong
Hi, On Mon, 19 Dec 2022 09:43:05 +0100, Carlo Caione wrote: > Having a bigger number of FIFO lines held after vsync is only useful to > SoCs using AFBC to give time to the AFBC decoder to be reset, configured > and enabled again. > > For SoCs not using AFBC this, on the contrary, is causing on so

Re: [PATCH v4 0/2] Make ILI9486 driver working with 16-bits SPI controllers

2023-01-02 Thread Neil Armstrong
Hi, On Mon, 19 Dec 2022 10:02:36 +0100, Carlo Caione wrote: > This patchset is trying to fix problems seen on S905X boards when interfacing > with an ILI9486 equipped SPI panel. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] drm/tiny: ili9486

Re: (subset) [PATCH v6 0/8] Support for the NPU in Vim3

2023-01-02 Thread Neil Armstrong
Hi, On Fri, 2 Dec 2022 12:52:12 +0100, Tomeu Vizoso wrote: > This series adds support for the Verisilicon VIPNano-QI NPU in the A311D > as in the VIM3 board. > > The IP is very closely based on previous Vivante GPUs, so the etnaviv > kernel driver works basically unchanged. > > The userspace par

Re: (subset) [PATCH v6 0/8] Support for the NPU in Vim3

2023-01-02 Thread Neil Armstrong
Hi, On Fri, 2 Dec 2022 12:52:12 +0100, Tomeu Vizoso wrote: > This series adds support for the Verisilicon VIPNano-QI NPU in the A311D > as in the VIM3 board. > > The IP is very closely based on previous Vivante GPUs, so the etnaviv > kernel driver works basically unchanged. > > The userspace par

Re: (subset) [PATCH v6 0/8] Support for the NPU in Vim3

2023-01-02 Thread Neil Armstrong
Hi, On Fri, 2 Dec 2022 12:52:12 +0100, Tomeu Vizoso wrote: > This series adds support for the Verisilicon VIPNano-QI NPU in the A311D > as in the VIM3 board. > > The IP is very closely based on previous Vivante GPUs, so the etnaviv > kernel driver works basically unchanged. > > The userspace par

[PATCH 0/2] drm/panel: add support for the Visionox VTDR6130 AMOLED DSI panel

2023-01-03 Thread Neil Armstrong
p.org Cc: devicet...@vger.kernel.org Cc: linux-arm-...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Neil Armstrong --- Neil Armstrong (2): dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings drm/panel: add visionox vtdr6130 DSI

[PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings

2023-01-03 Thread Neil Armstrong
Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. Signed-off-by: Neil Armstrong --- .../bindings/display/panel/visionox,vtdr6130.yaml | 53 ++ 1 file changed, 53 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130

[PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-03 Thread Neil Armstrong
compression is preferred for performance and power reasons, let's start with the uncompressed video mode support and add the DSC support later on. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-04 Thread Neil Armstrong
Hi Sam, On 03/01/2023 19:15, Sam Ravnborg wrote: Hi Neil, On Tue, Jan 03, 2023 at 03:22:28PM +0100, Neil Armstrong wrote: Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MTP board. By default the the panel is configured to work with DSI

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-04 Thread Neil Armstrong
On 04/01/2023 08:29, Tomi Valkeinen wrote: On 28/12/2022 23:58, Dmitry Baryshkov wrote: On 02/11/2022 20:06, Dmitry Baryshkov wrote:  From all the drivers using drm_bridge_connector only iMX/dcss and OMAP DRM driver do a proper work of calling drm_bridge_connector_en/disable_hpd() in right plac

[PATCH 1/6] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-04 Thread Neil Armstrong
Document the SM8550 DSI PHY which is very close from the 7nm and 5nm DSI PHYs found in earlier platforms. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings

[PATCH 0/6] drm/msm: add support for SM8450

2023-01-04 Thread Neil Armstrong
...@vger.kernel.org Signed-off-by: Neil Armstrong --- Neil Armstrong (6): dt-bindings: display/msm: document the SM8550 DSI PHY dt-bindings: display/msm: document the display hardware for SM8550 drm/msm/dpu: add support for SM8550 drm/msm: mdss: add support for SM8550 drm/msm/dsi

[PATCH 4/6] drm/msm: mdss: add support for SM8550

2023-01-04 Thread Neil Armstrong
Add support for the MDSS block on SM8550 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/msm_mdss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 144c8dd82be1..54483fe30ffd 100644 --- a/drivers/gpu/drm

[PATCH 2/6] dt-bindings: display/msm: document the display hardware for SM8550

2023-01-04 Thread Neil Armstrong
Document the MDSS and DPU blocks found on the Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 + .../bindings/display/msm/qcom,sm8550-mdss.yaml | 331 + 2 files changed, 465 insertions(+) diff

[PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-04 Thread Neil Armstrong
Add definitions for the display hardware used on Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h

[PATCH 6/6] drm/msm/dsi: add support for DSI 2.7.0

2023-01-04 Thread Neil Armstrong
Add support for DSI 2.7.0 (block used on sm8550). Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 16 drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi

[PATCH 5/6] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-04 Thread Neil Armstrong
SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c

Re: [PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-04 Thread Neil Armstrong
On 04/01/2023 10:45, Dmitry Baryshkov wrote: On 04/01/2023 11:08, Neil Armstrong wrote: Add definitions for the display hardware used on Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong ---   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 +   drivers/gpu

Re: [PATCH 5/6] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-04 Thread Neil Armstrong
On 04/01/2023 10:53, Dmitry Baryshkov wrote: On 04/01/2023 11:08, Neil Armstrong wrote: SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-05 Thread Neil Armstrong
Hi, On 04/01/2023 19:25, Rayyan Ansari wrote: Hello, I am not a maintainer, but I thought I might give a few comments. Any comment is always welcome ! On 03/01/2023 14:22, Neil Armstrong wrote: Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550

Re: [PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings

2023-01-05 Thread Neil Armstrong
On 03/01/2023 18:57, Sam Ravnborg wrote: Hi Neil, On Tue, Jan 03, 2023 at 03:22:27PM +0100, Neil Armstrong wrote: Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. Signed-off-by: Neil Armstrong --- .../bindings/display/panel/visionox,vtdr6130.yaml | 53

Re: [PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-05 Thread neil . armstrong
On 04/01/2023 18:48, Dmitry Baryshkov wrote: On Wed, 4 Jan 2023 at 12:08, Neil Armstrong wrote: On 04/01/2023 10:45, Dmitry Baryshkov wrote: On 04/01/2023 11:08, Neil Armstrong wrote: Add definitions for the display hardware used on Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong

Re: [PATCH v3 4/7] drm/imx/dcss: stop using drm_bridge_connector_en/disable_hpd()

2023-01-05 Thread Neil Armstrong
On 02/11/2022 19:07, Dmitry Baryshkov wrote: The functionality of drm_bridge_connector_enable_hpd() and drm_bridge_connector_disable_hpd() is provided automatically by the drm_kms_poll helpers. Stop calling these functions manually. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/dcss

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-05 Thread Neil Armstrong
Hi, On Wed, 02 Nov 2022 21:06:58 +0300, Dmitry Baryshkov wrote: > From all the drivers using drm_bridge_connector only iMX/dcss and OMAP > DRM driver do a proper work of calling > drm_bridge_connector_en/disable_hpd() in right places. Rather than > teaching each and every driver how to properly ha

Re: [PATCH 1/6] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-09 Thread Neil Armstrong
On 09/01/2023 00:09, Dmitry Baryshkov wrote: On 06/01/2023 17:41, Krzysztof Kozlowski wrote: On 04/01/2023 10:08, Neil Armstrong wrote: Document the SM8550 DSI PHY which is very close from the 7nm and 5nm DSI PHYs found in earlier platforms. Signed-off-by: Neil Armstrong ---   Documentation

[PATCH v2 0/2] drm/panel: add support for the Visionox VTDR6130 AMOLED DSI panel

2023-01-09 Thread Neil Armstrong
p.org Cc: devicet...@vger.kernel.org Cc: linux-arm-...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Neil Armstrong --- Changes in v2: - Patch 1: Added review tags - Patch 2: - Fixed includes block grouping - used mipi_dsi_dcs_write_seq() instead of custom macro - Used MIP

[PATCH v2 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-09 Thread Neil Armstrong
compression is preferred for performance and power reasons, let's start with the uncompressed video mode support and add the DSC support later on. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile

[PATCH v2 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings

2023-01-09 Thread Neil Armstrong
Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. Signed-off-by: Neil Armstrong Reviewed-by: Sam Ravnborg Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/panel/visionox,vtdr6130.yaml | 53 ++ 1 file changed, 53 insertions(+) diff --git a

[PATCH v2 0/7] drm/msm: add support for SM8550

2023-01-09 Thread Neil Armstrong
...@vger.kernel.org Signed-off-by: Neil Armstrong --- Changes in v2: - Rebased on msm-next-lumag & msm-next-lumag-dpu - Fixed cover letter title to SM8550 - Patch 1: renamed compatible to qcom,sm8550-dsi-phy-4nm - Patch 2: split in 2 patches, switch to renamed qcom,sm8550-dsi-phy-4nm - Patch 3: switch CT

[PATCH v2 1/7] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-09 Thread Neil Armstrong
Document the SM8550 DSI PHY which is very close from the 7nm and 5nm DSI PHYs found in earlier platforms. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings

[PATCH v2 6/7] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-09 Thread Neil Armstrong
SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c

[PATCH v2 2/7] dt-bindings: display/msm: document DPU on SM8550

2023-01-09 Thread Neil Armstrong
Document the DPU hardware found on the Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 + 1 file changed, 134 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml

[PATCH v2 7/7] drm/msm/dsi: add support for DSI 2.7.0

2023-01-09 Thread Neil Armstrong
Add support for DSI 2.7.0 (block used on sm8550). Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 16 drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c

[PATCH v2 4/7] drm/msm/dpu: add support for SM8550

2023-01-09 Thread Neil Armstrong
Add definitions for the display hardware used on Qualcomm SM8550 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm

[PATCH v2 5/7] drm/msm: mdss: add support for SM8550

2023-01-09 Thread Neil Armstrong
Add support for the MDSS block on SM8550 platform. Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index f9ef5085041d

[PATCH v2 3/7] dt-bindings: display/msm: document MDSS on SM8550

2023-01-09 Thread Neil Armstrong
Document the MDSS hardware found on the Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-mdss.yaml | 331 + 1 file changed, 331 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550

Re: [PATCH v2 6/7] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-09 Thread Neil Armstrong
On 09/01/2023 10:26, Neil Armstrong wrote: SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4

[PATCH v3 0/7] drm/msm: add support for SM8550

2023-01-09 Thread Neil Armstrong
...@vger.kernel.org Signed-off-by: Neil Armstrong --- Changes in v3: - Patch 1,2,3: Added Acked-by/Reviewed-by - Patch 6: Fixed compatible to qcom,sm8550-dsi-phy-4nm - Link to v2: https://lore.kernel.org/r/20230103-topic-sm8550-upstream-mdss-dsi-v2-0-87f1c16d7...@linaro.org Changes in v2: - Rebased on msm

[PATCH v3 1/7] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-09 Thread Neil Armstrong
Document the SM8550 DSI PHY which is very close from the 7nm and 5nm DSI PHYs found in earlier platforms. Acked-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v3 2/7] dt-bindings: display/msm: document DPU on SM8550

2023-01-09 Thread Neil Armstrong
Document the DPU hardware found on the Qualcomm SM8550 platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 + 1 file changed, 134 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v3 6/7] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-09 Thread Neil Armstrong
SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c

[PATCH v3 3/7] dt-bindings: display/msm: document MDSS on SM8550

2023-01-09 Thread Neil Armstrong
Document the MDSS hardware found on the Qualcomm SM8550 platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-mdss.yaml | 331 + 1 file changed, 331 insertions(+) diff --git a/Documentation/devicetree

[PATCH v3 7/7] drm/msm/dsi: add support for DSI 2.7.0

2023-01-09 Thread Neil Armstrong
Add support for DSI 2.7.0 (block used on sm8550). Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 16 drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c

[PATCH v3 4/7] drm/msm/dpu: add support for SM8550

2023-01-09 Thread Neil Armstrong
Add definitions for the display hardware used on Qualcomm SM8550 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm

[PATCH v3 5/7] drm/msm: mdss: add support for SM8550

2023-01-09 Thread Neil Armstrong
Add support for the MDSS block on SM8550 platform. Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index f9ef5085041d

<    5   6   7   8   9   10   11   12   13   14   >