Re: [PATCH v8 03/12] drm/rcar-du: Plug atomic state hooks to the default implementation

2020-01-27 Thread Neil Armstrong
= drm_atomic_helper_bridge_duplicate_state, > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > + .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_enable = rcar_lvds_atomic_enable, > .atomic_disable = rcar_lvds_atomic

Re: [PATCH v8 03/12] drm/rcar-du: Plug atomic state hooks to the default implementation

2020-01-27 Thread Neil Armstrong
= drm_atomic_helper_bridge_duplicate_state, > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > + .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_enable = rcar_lvds_atomic_enable, > .atomic_disable = rcar_lvds_atomic

[PATCH v4 11/11] drm/meson: Add YUV420 output support

2020-02-06 Thread Neil Armstrong
clock, but the video encoder must run at 2x the pixel clock. This patch enables the bridge bus format negociation, and handles the YUV420 case if selected by the negociation. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 91 --- 1 file changed, 70

[PATCH v4 02/11] drm/bridge: dw-hdmi: add max bpc connector property

2020-02-06 Thread Neil Armstrong
From: Jonas Karlman Add the max_bpc property to the dw-hdmi connector to prepare support for 10, 12 & 16bit output support. Signed-off-by: Jonas Karlman Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 1 file changed, 4 insertions(+) diff --git a/dri

[PATCH v4 01/11] drm/bridge: dw-hdmi: set mtmdsclock for deep color

2020-02-06 Thread Neil Armstrong
From: Jonas Karlman Configure the correct mtmdsclock for deep colors to prepare support for 10, 12 & 16bit output. Signed-off-by: Jonas Karlman Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 + 1 file changed, 17 insertions(+) diff --g

[PATCH v4 09/11] drm/meson: venc: add support for YUV420 setup

2020-02-06 Thread Neil Armstrong
YUV444 pixel stream to a YUV420 stream. In addition if pixel stream down-sampling, the Y Cb Cr components must also be mapped differently to align with the HDMI2.0 specifications. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++- drivers/gpu/drm/meson/meson_venc.c

[PATCH v4 05/11] drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2020-02-06 Thread Neil Armstrong
Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support for these modes in the connector if the platform supports them. We limit these modes to DW-HDMI IP version >= 0x200a which are designed to support HDMI2.0 display modes. Signed-off-by: Neil Armstrong --- drivers/gpu/

[PATCH v4 07/11] drm/meson: meson_dw_hdmi: add bridge and switch to drm_bridge_funcs

2020-02-06 Thread Neil Armstrong
Switch the dw-hdmi driver to drm_bridge_funcs by implementing a new local bridge, connecting it to the dw-hdmi bridge, then implement the atomic_get_input_bus_fmts/atomic_get_output_bus_fmts. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 105

[PATCH v4 03/11] drm/bridge: dw-hdmi: Plug atomic state hooks to the default implementation

2020-02-06 Thread Neil Armstrong
Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 051001f77dd4..fec4a4bcd1fe 100644 --- a/drivers/gpu/drm/bridge/synopsys

[PATCH v4 06/11] drm/meson: venc: make drm_display_mode const

2020-02-06 Thread Neil Armstrong
Before switching to bridge funcs, make sure drm_display_mode is passed as const to the venc functions. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_venc.c | 2 +- drivers/gpu/drm/meson/meson_venc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v4 10/11] drm/meson: vclk: add support for YUV420 setup

2020-02-06 Thread Neil Armstrong
order to better support these specific uses cases and switch to the Common Clock framework for clocks handling in the future. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 24 --- drivers/gpu/drm/meson/meson_vclk.c | 93 +++-- drivers/gpu

[PATCH v4 08/11] drm/meson: dw-hdmi: stop enforcing input_bus_format

2020-02-06 Thread Neil Armstrong
To allow using formats from negotiation, stop enforcing input_bus_format in the private dw-plat-data struct. Signed-off-by: Neil Armstrong Reviewed-by: Boris Brezillon --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/meson

[PATCH v4 00/11] drm/bridge: dw-hdmi: implement bus-format negotiation and YUV420 support

2020-02-06 Thread Neil Armstrong
7081425.15011-1-narmstr...@baylibre.com [6] https://patchwork.freedesktop.org/patch/msgid/20191218154637.17509-1-narmstr...@baylibre.com Jonas Karlman (2): drm/bridge: dw-hdmi: set mtmdsclock for deep color drm/bridge: dw-hdmi: add max bpc connector property Neil Armstrong (9): drm/bridg

Re: [PATCH v3] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-13 Thread Neil Armstrong
On 13/09/2019 08:37, Jonas Karlman wrote: > On 2019-09-11 19:02, Cheng-yi Chiang wrote: >> On Thu, Sep 12, 2019 at 12:54 AM Jernej Škrabec >> wrote: >>> Dne sreda, 11. september 2019 ob 18:23:59 CEST je Neil Armstrong napisal(a): >>>> On 11/09/2019 10:26, Chen

Re: [PATCH v5 0/5] Add HDMI jack support on RK3288

2019-09-13 Thread Neil Armstrong
Hi, On 09/09/2019 15:53, Mark Brown wrote: > On Mon, Sep 09, 2019 at 09:37:14AM +0200, Neil Armstrong wrote: > >> I'd like some review from ASoC people and other drm bridge reviewers, >> Jernej, Jonas & Andrzej. > >> Jonas could have some comments on the

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-17 Thread Neil Armstrong
Hi, On 17/09/2019 18:07, Liviu Dudau wrote: > On Tue, Sep 17, 2019 at 02:53:01PM +0200, Daniel Vetter wrote: >> On Mon, Sep 09, 2019 at 01:42:53PM +, Ayan Halder wrote: >>> Add a modifier 'DRM_FORMAT_MOD_ARM_PROTECTED' which denotes that the >>> framebuffer >>> is allocated in a protected sys

Re: [PATCH 0/4] drm/bridge: dw-hdmi: Add support for HDR metadata

2019-09-18 Thread Neil Armstrong
Hi Jonas, On 26/05/2019 23:18, Jonas Karlman wrote: > Add support for HDR metadata using the hdr_output_metadata connector property, > configure Dynamic Range and Mastering InfoFrame accordingly. > > A drm_infoframe flag is added to dw_hdmi_plat_data that platform drivers > can use to signal when

Re: [RFC] checking drm_framebuffer against config width/height

2019-09-18 Thread Neil Armstrong
Hi, On 19/09/2019 05:30, jsa...@codeaurora.org wrote: > Hello All, > > I bumped into the below check [1] enforced in drm_framebuffer creation which > checks the requested framebuffer width/height parameters against the drm mode > config width/height limits. As I understand, drm_mode_config: min

Re: [PATCH] drm/rockchip: Add AFBC support

2019-09-23 Thread Neil Armstrong
On 23/09/2019 14:20, Andrzej Pietrasiewicz wrote: > From: Ezequiel Garcia > > AFBC is a proprietary lossless image compression protocol and format. > It helps reduce memory bandwidth of the graphics pipeline operations. > This, in turn, improves power efficiency. > > Signed-off-by: Ezequiel Garc

Re: [PATCH RESEND] drm/meson: vclk: use the correct G12A frac max value

2019-09-25 Thread Neil Armstrong
Ping, could someone review this patch ? Neil On 28/08/2019 15:23, Neil Armstrong wrote: > When calculating the HDMI PLL settings for a DMT mode PHY frequency, > use the correct max fractional PLL value for G12A VPU. > > With this fix, we can finally setup the 1024x768-60 mode

drm_sched with panfrost crash on T820

2019-09-27 Thread Neil Armstrong
Hi Christian, In v5.3, running dEQP triggers the following kernel crash : [ 20.224982] Unable to handle kernel NULL pointer dereference at virtual address 0038 [...] [ 20.291064] Hardware name: Khadas VIM2 (DT) [ 20.295217] Workqueue: events drm_sched_job_timedout [...] [ 20.

Re: drm_sched with panfrost crash on T820

2019-09-27 Thread Neil Armstrong
Hi Steven, Thanks for your prompt reaction ! On 27/09/2019 12:48, Steven Price wrote: > On 27/09/2019 10:55, Steven Price wrote: > [...] >> One obvious issue with the DRM scheduler is that there is a call to >> cancel_delayed_work() in drm_sched_stop() which to me looks like it >> should be cance

Re: drm_sched with panfrost crash on T820

2019-09-27 Thread Neil Armstrong
Hi, On 27/09/2019 13:27, Neil Armstrong wrote: > Hi Steven, > > Thanks for your prompt reaction ! > > On 27/09/2019 12:48, Steven Price wrote: >> On 27/09/2019 10:55, Steven Price wrote: >> [...] >>> One obvious issue with the DRM scheduler is that there

Re: drm_sched with panfrost crash on T820

2019-09-27 Thread Neil Armstrong
On 27/09/2019 17:00, Steven Price wrote: > On 27/09/2019 12:48, Neil Armstrong wrote: >> Hi, >> >> On 27/09/2019 13:27, Neil Armstrong wrote: >>> Hi Steven, >>> >>> Thanks for your prompt reaction ! >>> >>> On 27/09/2019 12:48

Re: [PATCH] drm/meson: enable runtime PM

2019-09-30 Thread Neil Armstrong
Hi Kevin, On 25/09/2019 21:31, Kevin Hilman wrote: > From: Kevin Hilman > > On some SoCs, the VPU is in a power-domain and needs runtime PM > enabled and used in order to keep the power domain on. > > Signed-off-by: Kevin Hilman > --- > drivers/gpu/drm/meson/meson_drv.c | 4 > 1 file cha

Re: drm_sched with panfrost crash on T820

2019-09-30 Thread Neil Armstrong
esn't seem related to guilty job. Neil > > Andrey > > On 9/27/19 4:12 AM, Neil Armstrong wrote: >> Hi Christian, >> >> In v5.3, running dEQP triggers the following kernel crash : >> >> [ 20.224982] Unable to handle kernel NULL pointer dereference

Re: drm_sched with panfrost crash on T820

2019-09-30 Thread Neil Armstrong
Hi Steven, On 27/09/2019 17:00, Steven Price wrote: > On 27/09/2019 12:48, Neil Armstrong wrote: >> Hi, >> >> On 27/09/2019 13:27, Neil Armstrong wrote: >>> Hi Steven, >>> >>> Thanks for your prompt reaction ! >>> >>> On 27/09/2019

Re: [PATCH RESEND] drm/meson: vclk: use the correct G12A frac max value

2019-09-30 Thread Neil Armstrong
On 26/09/2019 23:08, Kevin Hilman wrote: > Neil Armstrong writes: > >> When calculating the HDMI PLL settings for a DMT mode PHY frequency, >> use the correct max fractional PLL value for G12A VPU. >> >> With this fix, we can finally setup the 1024x768-60 mode. &

Re: [PATCH] drm/meson: enable runtime PM

2019-10-01 Thread Neil Armstrong
On 30/09/2019 17:34, Kevin Hilman wrote: > Neil Armstrong writes: > >> Hi Kevin, >> >> On 25/09/2019 21:31, Kevin Hilman wrote: >>> From: Kevin Hilman >>> >>> On some SoCs, the VPU is in a power-domain and needs runtime PM >&g

Re: drm_sched with panfrost crash on T820

2019-10-02 Thread Neil Armstrong
Hi Andrey, On 02/10/2019 16:40, Grodzovsky, Andrey wrote: > > On 9/30/19 10:52 AM, Hillf Danton wrote: >> On Mon, 30 Sep 2019 11:17:45 +0200 Neil Armstrong wrote: >>> Did a new run from 5.3: >>> >>> [ 35.971972] Call trace: >>> [

Re: drm_sched with panfrost crash on T820

2019-10-03 Thread Neil Armstrong
Hi Andrey, Le 02/10/2019 à 16:40, Grodzovsky, Andrey a écrit : > > On 9/30/19 10:52 AM, Hillf Danton wrote: >> On Mon, 30 Sep 2019 11:17:45 +0200 Neil Armstrong wrote: >>> Did a new run from 5.3: >>> >>> [ 35.971972] Call trace: >>> [

Re: drm_sched with panfrost crash on T820

2019-10-03 Thread Neil Armstrong
Le 02/10/2019 à 18:53, Grodzovsky, Andrey a écrit : > > On 9/30/19 5:17 AM, Neil Armstrong wrote: >> Hi Andrey, >> >> On 27/09/2019 22:55, Grodzovsky, Andrey wrote: >>> Can you please use addr2line or gdb to pinpoint where in >>> drm_sched_increase_

Re: [PATCH v3 4/4] dt-bindings: display: add IMX MIPI DSI host controller doc

2019-11-20 Thread Neil Armstrong
Hi, On 18/11/2019 16:25, Adrian Ratiu wrote: A small commit log would be welcome here. > Signed-off-by: Sjoerd Simons > Signed-off-by: Martyn Welch > Signed-off-by: Adrian Ratiu > --- > .../bindings/display/imx/mipi-dsi.txt | 56 +++ > 1 file changed, 56 insertions(+)

Re: [PATCH v3] drm/bridge/synopsys: dsi: driver-specific configuration of phy timings

2019-11-25 Thread Neil Armstrong
Hi, On 23/11/2019 21:51, Heiko Stuebner wrote: > Hi Neil, > > Am Samstag, 23. November 2019, 13:38:41 CET schrieb Neil Armstrong: >> Le 23/11/2019 à 11:39, Heiko Stuebner a écrit : >>> From: Heiko Stuebner >>> >>> The timing values for dw-dsi a

Re: [PATCH v3 RESEND] drm/bridge/synopsys: dsi: driver-specific configuration of phy timings

2019-11-25 Thread Neil Armstrong
Hi, On 25/11/2019 10:31, Heiko Stuebner wrote: > From: Heiko Stuebner > > The timing values for dw-dsi are often dependent on the used display and > according to Philippe Cornu will most likely also depend on the used phy > technology in the soc-specific implementation. > > To solve this and al

Re: [PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-02 Thread Neil Armstrong
> mode->hsync_end, >> @@ -823,12 +829,11 @@ struct plane_arg { >> >> static drmModeModeInfo * >> connector_find_mode(struct device *dev, uint32_t con_id, const char >> *mode_str, >> -const float vrefresh) >> +float *vrefres

Re: [PATCH] drm: meson: venc: cvbs: fix CVBS mode matching

2019-12-04 Thread Neil Armstrong
Hi Martin, On 30/11/2019 23:25, Martin Blumenstingl wrote: > Drop the picture_aspect_ratio from the drm_display_modes which are valid > for the Amlogic Meson CVBS encoder. meson_venc_cvbs_encoder_atomic_check > and meson_venc_cvbs_encoder_mode_set only support two very specific > drm_display_modes

Re: [PATCH v4 00/11] drm: Add support for bus-format negotiation

2019-12-04 Thread Neil Armstrong
On 03/12/2019 19:19, Laurent Pinchart wrote: > Hi Boris, > > On Tue, Dec 03, 2019 at 03:15:04PM +0100, Boris Brezillon wrote: >> This patch series aims at adding support for runtime bus-format >> negotiation between all elements of the >> 'encoder -> bridges -> connector/display' section of the pi

Re: [PATCH v2 12/28] gpu: drm: bridge: sii9234: Use drm_bridge_init()

2019-12-05 Thread Neil Armstrong
Hi, On 04/12/2019 12:48, Mihail Atanassov wrote: > No functional change. > Why this particular one has "gpu: drm: bridge" unlike the other patches of the serie ? Neil > Signed-off-by: Mihail Atanassov > --- > drivers/gpu/drm/bridge/sii9234.c | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

Re: [PATCH v2 0/2] Meson VPU: fix CVBS output

2019-12-08 Thread Neil Armstrong
e lookup code > drm: meson: venc: cvbs: fix CVBS mode matching > > drivers/gpu/drm/meson/meson_venc_cvbs.c | 48 ++--- > 1 file changed, 27 insertions(+), 21 deletions(-) > For both: Acked-by: Neil Armstrong I'll squ

Re: [PATCH v2 0/2] Meson VPU: fix CVBS output

2019-12-08 Thread Neil Armstrong
On 08/12/2019 18:18, Martin Blumenstingl wrote: > The goal of this series is to fix the CVBS output with the Meson VPU > driver. Prior to this series kmscube reported: > failed to set mode: Invalid argument > > Changes since v1 at [0]: > - add patch to remove duplicate code (to match patch #2 ea

Re: [PATCH v2 0/2] Meson VPU: fix CVBS output

2019-12-09 Thread Neil Armstrong
On 08/12/2019 18:18, Martin Blumenstingl wrote: > The goal of this series is to fix the CVBS output with the Meson VPU > driver. Prior to this series kmscube reported: > failed to set mode: Invalid argument > > Changes since v1 at [0]: > - add patch to remove duplicate code (to match patch #2 ea

Re: [PATCH v2 00/28] drm/bridge: Consolidate initialization

2019-12-09 Thread Neil Armstrong
Hi Mihail, On 04/12/2019 12:48, Mihail Atanassov wrote: > Hi all, > > I've dropped the fun parts of this series since they need more work, but > figured drm_bridge_init() as a concept is still valuable on its own (and > I think I'll need it to roll out device links for registered bridges), > so h

Re: [PATCH v3 0/9] drm/meson: add AFBC support

2019-12-10 Thread Neil Armstrong
On 09/12/2019 23:09, Kevin Hilman wrote: > Neil Armstrong writes: > >> This adds support for the ARM Framebuffer Compression decoders found >> in the Amlogic GXM and G12A SoCs. >> >> This patchset is a merge of v2 "drm/meson: add AFBC support" at [3] and v

Re: [PATCH] drm: meson: use match data to detect vpu compatibility

2019-08-22 Thread Neil Armstrong
Hi Julien, On 22/08/2019 11:03, Julien Masson wrote: > This patch introduce new enum which contains all VPU family (GXBB, > GXL, GXM and G12A). > This enum is used to detect the VPU compatible with the device. > > We only need to set .data to the corresponding enum in the device > table, no need

Re: [PATCH RFC 14/19] drm/bridge: Add the necessary bits to support bus format negotiation

2019-08-22 Thread Neil Armstrong
On 22/08/2019 09:48, Boris Brezillon wrote: > On Thu, 22 Aug 2019 03:55:56 +0300 > Laurent Pinchart wrote: > >> Hi Boris, >> >> Thank you for the patch. >> >> On Thu, Aug 08, 2019 at 05:11:45PM +0200, Boris Brezillon wrote: >>> This takes the form of various helpers, plus the addition of 2 new >>

Re: [PATCH RFC 14/19] drm/bridge: Add the necessary bits to support bus format negotiation

2019-08-22 Thread Neil Armstrong
On 22/08/2019 12:09, Boris Brezillon wrote: > On Thu, 22 Aug 2019 11:29:40 +0200 > Neil Armstrong wrote: > >>>>> +/** >>>>> + * struct drm_bus_caps - bus capabilities >>>>> + * @supported_fmts: array of MEDIA_BUS_FMT_ formats >>&

Re: [PATCH RFC 14/19] drm/bridge: Add the necessary bits to support bus format negotiation

2019-08-22 Thread Neil Armstrong
On 22/08/2019 12:34, Boris Brezillon wrote: > On Thu, 22 Aug 2019 12:22:02 +0200 > Neil Armstrong wrote: > >> On 22/08/2019 12:09, Boris Brezillon wrote: >>> On Thu, 22 Aug 2019 11:29:40 +0200 >>> Neil Armstrong wrote: >>> >>>>>&

Re: [PATCH v2] drm: meson: use match data to detect vpu compatibility

2019-08-22 Thread Neil Armstrong
gpu/drm/meson/meson_venc_cvbs.c | 10 ++-- > drivers/gpu/drm/meson/meson_viu.c | 10 ++-- > drivers/gpu/drm/meson/meson_vpp.c | 10 ++-- > 11 files changed, 77 insertions(+), 62 deletions(-) Tested-by: Neil Armstrong on SEI510 (G12A), VIM2 (GXM) and Libretech-AC (GXL) and Acked-

Re: [PATCH] MAINTAINERS: Add Steven and Alyssa as panfrost reviewers

2019-08-23 Thread Neil Armstrong
ring > M: Tomeu Vizoso > +R: Steven Price > +R: Alyssa Rosenzweig > L: dri-devel@lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > Acked-by: Neil Armstrong ___ dri-devel mailing

[PATCH] drm/meson: vclk: use the correct G12A frac max value

2019-08-26 Thread Neil Armstrong
When calculating the HDMI PLL settings for a DMT mode PHY frequency, use the correct max fractional PLL value for G12A VPU. With this fix, we can finally setup the 1024x76-60 mode. Fixes: 202b9808f8ed ("drm/meson: Add G12A Video Clock setup") Signed-off-by: Neil Armstrong --- drive

Re: [PATCH] drm/meson: vclk: use the correct G12A frac max value

2019-08-27 Thread Neil Armstrong
On 27/08/2019 07:40, Martin Blumenstingl wrote: > On Mon, Aug 26, 2019 at 4:47 PM Neil Armstrong > wrote: >> >> When calculating the HDMI PLL settings for a DMT mode PHY frequency, >> use the correct max fractional PLL value for G12A VPU. >> >> With this fix,

Re: [PATCH v2 09/21] drm/bridge: Introduce drm_bridge_chain_get_next_bridge()

2019-08-27 Thread Neil Armstrong
On 26/08/2019 17:26, Boris Brezillon wrote: > And use it in drivers accessing the bridge->next field directly. > This is part of our attempt to make the bridge chain a double-linked list > based on the generic list helpers. Reviewed-by: Neil Armstrong > > Signed-off-b

Re: [PATCH v2 15/21] drm/bridge: Add the drm_bridge_chain_get_prev_bridge() helper

2019-08-27 Thread Neil Armstrong
On 26/08/2019 17:26, Boris Brezillon wrote: > Will be useful for bridge drivers that want to do bus format > negotiation with their neighbours. Reviewed-by: Neil Armstrong > > Signed-off-by: Boris Brezillon > --- > Changes in v2: > * Fix the kerneldoc > * Drop the !br

Re: [PATCH v2 11/21] drm/bridge: Add the drm_for_each_bridge_in_chain() helper

2019-08-27 Thread Neil Armstrong
On 26/08/2019 17:26, Boris Brezillon wrote: > To iterate over all bridges attached to a specific encoder. > > Suggested-by: Laurent Pinchart > Signed-off-by: Boris Brezillon Reviewed-by: Neil Armstrong > --- > Changes in v2: > * New patch > --- > in

Re: [PATCH v2 13/21] drm/bridge: Patch atomic hooks to take a drm_bridge_state

2019-08-27 Thread Neil Armstrong
the old > state. > > Signed-off-by: Boris Brezillon Reviewed-by: Neil Armstrong > --- > Changes in v2: > * Pass the old bridge state > --- > .../drm/bridge/analogix/analogix_dp_core.c| 12 ++- > drivers/gpu/drm/drm_bridge.c | 73 +

[PATCH RFC v2 8/8] drm/meson: Add YUV420 output support

2019-08-27 Thread Neil Armstrong
clock, but the video encoder must run at 2x the pixel clock. This patch enables the bridge bus format negociation, and handles the YUV420 case if selected by the negociation. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 85 +-- 1 file changed, 68

[PATCH RFC v2 0/8] drm/bridge: dw-hdmi: implement bus-format negotiation and YUV420 support

2019-08-27 Thread Neil Armstrong
https://patchwork.freedesktop.org/patch/msgid/20190520133753.23871-1-narmstr...@baylibre.com [3] https://patchwork.freedesktop.org/patch/msgid/1549022873-40549-1-git-send-email-narmstr...@baylibre.com [4] https://patchwork.freedesktop.org/patch/msgid/20190820084109.24616-1-narmstr...@baylibre.com Ne

[PATCH RFC v2 5/8] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2019-08-27 Thread Neil Armstrong
Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support for these modes in the connector if the platform supports them. We limit these modes to DW-HDMI IP version >= 0x200a which are designed to support HDMI2.0 display modes. Signed-off-by: Neil Armstrong --- drivers/gpu/

[PATCH RFC v2 4/8] drm/meson: dw-hdmi: stop enforcing input_bus_format

2019-08-27 Thread Neil Armstrong
To allow using formats from negociation, stop enforcing input_bus_format in the private dw-plat-data struct. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson

[PATCH RFC v2 6/8] drm/meson: venc: add support for YUV420 setup

2019-08-27 Thread Neil Armstrong
YUV444 pixel stream to a YUV420 stream. In addition if pixel stream down-sampling, the Y Cb Cr components must also be mapped differently to align with the HDMI2.0 specifications. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++- drivers/gpu/drm/meson/meson_venc.c

[PATCH RFC v2 2/8] drm/meson: meson_dw_hdmi: switch to drm_bridge_funcs

2019-08-27 Thread Neil Armstrong
Switch the dw-hdmi driver to drm_bridge_funcs, and implement the atomic_get_input_bus_fmts/atomic_get_output_bus_fmts. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 67 +-- 1 file changed, 54 insertions(+), 13 deletions(-) diff --git a

[PATCH RFC v2 3/8] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2019-08-27 Thread Neil Armstrong
Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate the possible output and input formats for the current mode and monitor, and use the negociated formats in a basic atomic_check callback. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 245

[PATCH RFC v2 7/8] drm/meson: vclk: add support for YUV420 setup

2019-08-27 Thread Neil Armstrong
order to better support these specific uses cases and switch to the Common Clock framework for clocks handling in the future. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 24 --- drivers/gpu/drm/meson/meson_vclk.c | 93 +++-- drivers/gpu

[PATCH RFC v2 1/8] drm/meson: venc: make drm_display_mode const

2019-08-27 Thread Neil Armstrong
Before switching to bridge funcs, make sure drm_display_mode is passed as const to the venc functions. Signed-off-by: Neil Armstrong Reviewed-by: Boris Brezillon --- drivers/gpu/drm/meson/meson_venc.c | 2 +- drivers/gpu/drm/meson/meson_venc.h | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH v2 16/21] drm/bridge: Add the necessary bits to support bus format negotiation

2019-08-27 Thread Neil Armstrong
the > side, and that's likely to happen for all external bridges since we > can't necessarily tell where they are used. I'll wait Laurent's feedback on this one, but I implemented the DW-HDMI negotiation with it, and it works fine, see [1] Tested-by: Neil Armstrong [

[PATCH 1/2] drm/meson: dw_hdmi: add resume/suspend hooks

2019-08-27 Thread Neil Armstrong
-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 110 ++ 1 file changed, 76 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index df3f9ddd2234..a722ddbfbede 100644 --- a/drivers

[PATCH 2/2] drm/meson: add resume/suspend hooks

2019-08-27 Thread Neil Armstrong
Add the suspend and resume hooks to: - save and disable the entire DRM driver on suspend - re-init the entire VPU subsystem on resume, to recover CRTC and pixel generator functionnal usage after DDR suspend, then recover DRM driver state Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson

[PATCH 0/2] drm/meson: add resume/suspend hooks

2019-08-27 Thread Neil Armstrong
board, using the newly accepted VRTC driver and the rtcwake utility. Neil Armstrong (2): drm/meson: dw_hdmi: add resume/suspend hooks drm/meson: add resume/suspend hooks drivers/gpu/drm/meson/meson_drv.c | 32 drivers/gpu/drm/meson/meson_dw_hdmi.c | 110 ++ 2

Re: [PATCH RFC v2 3/8] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2019-08-27 Thread Neil Armstrong
On 27/08/2019 11:03, Boris Brezillon wrote: > On Tue, 27 Aug 2019 10:14:20 +0200 > Neil Armstrong wrote: > >> Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate > > ^negotiate > &g

Re: [PATCH 0/2] drm/meson: add resume/suspend hooks

2019-08-28 Thread Neil Armstrong
On 27/08/2019 21:17, Kevin Hilman wrote: > Neil Armstrong writes: > >> This serie adds the resume/suspend hooks in the Amlogic Meson VPU main driver >> and the DW-HDMI Glue driver to correctly save state and disable HW before >> suspend, and succesfully re-init the H

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-08-28 Thread Neil Armstrong
Hi Robyn, On 31/05/2019 15:47, Robin Murphy wrote: > On 31/05/2019 13:04, Tomeu Vizoso wrote: >> On Wed, 29 May 2019 at 19:38, Robin Murphy wrote: >>> >>> On 29/05/2019 16:09, Tomeu Vizoso wrote: On Tue, 21 May 2019 at 18:11, Clément Péron wrote: > [snip] > [  345.204813] panfr

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-08-28 Thread Neil Armstrong
On 28/08/2019 13:49, Robin Murphy wrote: > Hi Neil, > > On 28/08/2019 12:28, Neil Armstrong wrote: >> Hi Robin, >> [...] >>> >>> OK - with the 32-bit hack pointed to up-thread, a quick kmscube test gave >>> me the impression that T720 works f

[PATCH RESEND] drm/meson: vclk: use the correct G12A frac max value

2019-08-28 Thread Neil Armstrong
When calculating the HDMI PLL settings for a DMT mode PHY frequency, use the correct max fractional PLL value for G12A VPU. With this fix, we can finally setup the 1024x768-60 mode. Fixes: 202b9808f8ed ("drm/meson: Add G12A Video Clock setup") Signed-off-by: Neil Armstrong --- Fix

Re: [PATCH 0/2] drm/meson: add resume/suspend hooks

2019-08-28 Thread Neil Armstrong
On 28/08/2019 17:12, Kevin Hilman wrote: > Neil Armstrong writes: > >> On 27/08/2019 21:17, Kevin Hilman wrote: >>> Neil Armstrong writes: >>> >>>> This serie adds the resume/suspend hooks in the Amlogic Meson VPU main >>>> driver >&g

Re: [PATCH 2/5] drm: dw-hdmi: move dw_hdmi_connector_detect()

2019-09-02 Thread Neil Armstrong
_unlock(&hdmi->mutex); > + > + return hdmi->phy.ops->read_hpd(hdmi, hdmi->phy.data); > +} > + > static int dw_hdmi_connector_get_modes(struct drm_connector *connector) > { > return dw_hdmi_connector_update_edid(connector, true); > Reviewed-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/5] drm: dw-hdmi: extract dw_hdmi_connector_update_edid()

2019-09-02 Thread Neil Armstrong
Hi Jonas, On 01/09/2019 18:14, Jonas Karlman wrote: > Extract code that updates EDID into a dw_hdmi_connector_update_edid() > helper, it will be called from dw_hdmi_connector_detect(). Small nit, you should precise you add a bool to optionally add the modes. Anyway: Reviewed-by: Neil Arm

Re: [PATCH 5/5] drm: dw-hdmi: update ELD on HPD event

2019-09-02 Thread Neil Armstrong
else > + drm_edid_to_eld(connector, edid); > kfree(edid); > } else { > dev_dbg(hdmi->dev, "failed to get edid\n"); > Reviewed-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/5] Revert "drm/edid: make drm_edid_to_eld() static"

2019-09-02 Thread Neil Armstrong
On 01/09/2019 18:14, Jonas Karlman wrote: > drm_edid_to_eld() is needed to update stale connector ELD on HPD event. > > This reverts part of commit 79436a1c9bcc ("drm/edid: make drm_edid_to_eld() > static"). Why not a full revert ? The documentation revert seems also relevant now Neil > > Si

Re: [PATCH 3/5] drm: dw-hdmi: update CEC phys addr and EDID on HPD event

2019-09-02 Thread Neil Armstrong
> > if (intr_stat & HDMI_IH_PHY_STAT0_HPD) { > Won't it possibly trigger twice edid readouts on each HPD event, one for CEC and one for modes ? It seems sane but not very efficient to me... Anyway: Reviewed-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm: dw-hdmi-i2s: enable audio clock in audio_startup

2019-09-02 Thread Neil Armstrong
Hi, On 02/09/2019 05:54, Cheng-Yi Chiang wrote: > In the designware databook, the sequence of enabling audio clock and > setting format is not clearly specified. > Currently, audio clock is enabled in the end of hw_param ops after > setting format. > > On some monitors, there is a possibility tha

Re: [PATCH v2] drm: dw-hdmi-i2s: enable audio clock in audio_startup

2019-09-02 Thread Neil Armstrong
On 02/09/2019 12:32, Jonas Karlman wrote: > On 2019-09-02 11:42, Neil Armstrong wrote: >> Hi, >> >> On 02/09/2019 05:54, Cheng-Yi Chiang wrote: >>> In the designware databook, the sequence of enabling audio clock and >>> setting format is not clearly s

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-03 Thread Neil Armstrong
Hi, On 03/09/2019 07:51, Cheng-Yi Chiang wrote: > From: Yakir Yang > > When transmitting IEC60985 linear PCM audio, we configure the > Audio Sample Channel Status information of all the channel > status bits in the IEC60958 frame. > Refer to 60958-3 page 10 for frequency, original frequency, and

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-03 Thread Neil Armstrong
Hi, Le 03/09/2019 à 11:53, Neil Armstrong a écrit : > Hi, > > On 03/09/2019 07:51, Cheng-Yi Chiang wrote: >> From: Yakir Yang >> >> When transmitting IEC60985 linear PCM audio, we configure the >> Audio Sample Channel Status information of all the channel >

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-04 Thread Neil Armstrong
Hi, On 04/09/2019 11:09, Cheng-yi Chiang wrote: > Hi, > > On Tue, Sep 3, 2019 at 5:53 PM Neil Armstrong wrote: >> >> Hi, >> >> On 03/09/2019 07:51, Cheng-Yi Chiang wrote: >>> From: Yakir Yang >>> >>> When transmitting IEC60985 linear

Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

2019-09-05 Thread Neil Armstrong
On 05/09/2019 15:02, Steven Price wrote: > On 05/09/2019 13:40, Mark Brown wrote: >> On Thu, Sep 05, 2019 at 10:37:53AM +0100, Steven Price wrote: >> >>> Ah, I didn't realise that regulator_get() will return a dummy regulator >>> if none is provided in the DT. In theory that seems like a nicer >>>

Re: [PATCH v5 0/5] Add HDMI jack support on RK3288

2019-09-09 Thread Neil Armstrong
Hi, On 08/09/2019 15:51, Cheng-yi Chiang wrote: > On Fri, Aug 30, 2019 at 10:55 AM Cheng-yi Chiang > wrote: >> >> On Wed, Jul 17, 2019 at 6:28 PM Tzung-Bi Shih wrote: >>> >>> On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang >>> wrote: This patch series supports HDMI jack reporting on

Re: [PATCH v3] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-11 Thread Neil Armstrong
mi *hdmi, unsigned int rate); > void dw_hdmi_set_channel_count(struct dw_hdmi *hdmi, unsigned int cnt); > +void dw_hdmi_set_channel_status(struct dw_hdmi *hdmi, u8 *channel_status); > void dw_hdmi_set_channel_allocation(struct dw_hdmi *hdmi, unsigned int ca); > void dw_hdmi_audio_ena

[PATCH 3/3] MAINTAINERS: Update with Amlogic DRM bindings converted as YAML

2019-08-05 Thread Neil Armstrong
The amlogic,meson-dw-hdmi.txt and amlogic,meson-vpu.txt has been converted to YAML schemas, update MAINTAINERS to match them again. Signed-off-by: Neil Armstrong --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6426db5198f0

[PATCH 0/3] drm/meson: convert bindings to YAML schemas

2019-08-05 Thread Neil Armstrong
fixes will be pushed once these yaml bindings are acked. Neil Armstrong (3): dt-bindings: display: amlogic,meson-dw-hdmi: convert to yaml dt-bindings: display: amlogic,meson-vpu: convert to yaml MAINTAINERS: Update with Amlogic DRM bindings converted as YAML .../display/amlogic,meson-dw

[PATCH 1/3] dt-bindings: display: amlogic, meson-dw-hdmi: convert to yaml

2019-08-05 Thread Neil Armstrong
uses the reversed instead of fixing the device trees order. Signed-off-by: Neil Armstrong --- .../display/amlogic,meson-dw-hdmi.txt | 119 - .../display/amlogic,meson-dw-hdmi.yaml| 160 ++ 2 files changed, 160 insertions(+), 119 deletions(-) delete m

[PATCH 2/3] dt-bindings: display: amlogic,meson-vpu: convert to yaml

2019-08-05 Thread Neil Armstrong
Now that we have the DT validation in place, let's convert the device tree bindings for the Amlogic Display Controller over to YAML schemas. The original example has a leftover "dmc" memory cell, that has been removed in the yaml rewrite. Signed-off-by: Neil Armstrong --- .../b

Re: [PATCH] drm/bridge/megachips: Drop GPIO header

2019-08-05 Thread Neil Armstrong
Hi Linus, On 05/08/2019 11:40, Linus Walleij wrote: > On Mon, Aug 5, 2019 at 11:31 AM Laurent Pinchart > wrote: >> On Mon, Aug 05, 2019 at 11:05:55AM +0200, Linus Walleij wrote: >>> On Mon, Jul 8, 2019 at 1:28 PM Linus Walleij >>> wrote: >>> This file isn't using any interfaces from so >>

Re: [PATCH 1/3] dt-bindings: display: amlogic, meson-dw-hdmi: convert to yaml

2019-08-06 Thread Neil Armstrong
On 06/08/2019 00:15, Rob Herring wrote: > On Mon, Aug 5, 2019 at 7:43 AM Neil Armstrong wrote: >> >> Now that we have the DT validation in place, let's convert the device tree >> bindings for the Amlogic Synopsys DW-HDMI specifics over to YAML schemas. >> >

Re: [PATCH 2/3] dt-bindings: display: amlogic,meson-vpu: convert to yaml

2019-08-06 Thread Neil Armstrong
On 06/08/2019 00:19, Rob Herring wrote: > On Mon, Aug 5, 2019 at 7:43 AM Neil Armstrong wrote: >> >> Now that we have the DT validation in place, let's convert the device tree >> bindings for the Amlogic Display Controller over to YAML schemas. >> >> Th

[PATCH v2 0/3] drm/meson: convert bindings to YAML schemas

2019-08-06 Thread Neil Armstrong
fixes will be pushed once these yaml bindings are acked. Neil Armstrong (3): dt-bindings: display: amlogic,meson-dw-hdmi: convert to yaml dt-bindings: display: amlogic,meson-vpu: convert to yaml MAINTAINERS: Update with Amlogic DRM bindings converted as YAML .../display/amlogic,meson-dw

[PATCH v2 2/3] dt-bindings: display: amlogic, meson-vpu: convert to yaml

2019-08-06 Thread Neil Armstrong
d in favor of a description of each port. Signed-off-by: Neil Armstrong --- .../bindings/display/amlogic,meson-vpu.txt| 121 --- .../bindings/display/amlogic,meson-vpu.yaml | 138 ++ 2 files changed, 138 insertions(+), 121 deletions(-) delete mode 100644

[PATCH v2 1/3] dt-bindings: display: amlogic,meson-dw-hdmi: convert to yaml

2019-08-06 Thread Neil Armstrong
uses the reversed instead of fixing the device trees order. The #sound-dai-cells optional property has been added to match this node as a sound dai. The port connection table has been dropped in favor of a description of each port. Signed-off-by: Neil Armstrong --- .../display/amlogic,meson-

Re: [PATCH v2 2/3] dt-bindings: display: amlogic,meson-vpu: convert to yaml

2019-08-06 Thread Neil Armstrong
Hi Rob, On 06/08/2019 17:08, Rob Herring wrote: > On Tue, Aug 6, 2019 at 6:44 AM Neil Armstrong wrote: >> >> Now that we have the DT validation in place, let's convert the device tree >> bindings for the Amlogic Display Controller over to YAML schemas. >> >&g

[PATCH v3 2/3] dt-bindings: display: amlogic, meson-vpu: convert to yaml

2019-08-08 Thread Neil Armstrong
d in favor of a description of each port. Signed-off-by: Neil Armstrong --- .../bindings/display/amlogic,meson-vpu.txt| 121 .../bindings/display/amlogic,meson-vpu.yaml | 137 ++ 2 files changed, 137 insertions(+), 121 deletions(-) delete mode 100644

<    3   4   5   6   7   8   9   10   11   12   >