writte the same sequence at the
next VSYNC event, until a new buffer is committed to the OSD plane.
The the Amlogic G12A is switched to RDMA, the Amlogic GXM Decoder
doesn't need a reset/reprogram at each vsync.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_cr
On 15/10/2019 13:18, Brian Starkey wrote:
> Hi Neil,
>
> On Fri, Oct 11, 2019 at 02:07:01PM +0200, Neil Armstrong wrote:
>> On 11/10/2019 12:56, Brian Starkey wrote:
>>> Hi,
>>>
>>> On Fri, Oct 11, 2019 at 11:14:43AM +0200, Neil Armstrong wrote:
>>&
On 15/10/2019 13:33, Neil Armstrong wrote:
> The VPU embeds a "Register DMA" that can write a sequence of registers
> on the VPU AHB bus, either manually or triggered by an internal IRQ
> event like VSYNC or a line input counter.
>
> The initial implementation handles
n't need a reset/reprogram at each vsync.
Changes since v1 at [1]:
- Fixed a regression when AFBC was not used, adding a reset() call for the afbc
module
- Added a define for the RDMA descriptor size
- Fixed overflow detection
[1] https://patchwork.freedesktop.org/series/68021/#rev1
Ne
The Amlogic VPU embeds a "Register DMA" that can write a sequence of registers
on the VPU AHB bus, either manually or triggered by an internal IRQ event like
VSYNC or a line input counter.
This adds the register defines.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_r
writte the same sequence at the
next VSYNC event, until a new buffer is committed to the OSD plane.
The the Amlogic G12A is switched to RDMA, the Amlogic GXM Decoder
doesn't need a reset/reprogram at each vsync.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_cr
handle the RDMA irq.
The RDMA will be usefull to reset and program the AFBC decoder unit
on each vsync without involving the interrupt handler that can
be masked for a log period of time, producing display glitches.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/Makefile | 2 +-
drive
Also store the framebuffer width in the private common struct
to be used by the AFBC decoder module driver when committing the AFBC
plane.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_drv.h | 1 +
drivers/gpu/drm/meson/meson_plane.c | 1 +
2 files changed, 2 insertions
roid.googlesource.com/device/amlogic/yukawa/+/refs/heads/master/gpu/
[2] https://patchwork.freedesktop.org/series/67832/#rev1
[3] https://patchwork.freedesktop.org/series/67832/#rev2
[4] https://patchwork.freedesktop.org/series/68021/#rev2
Neil Armstrong (9):
drm/meson: add AFBC decoder registe
The Amlogic VPU embeds a "Register DMA" that can write a sequence of registers
on the VPU AHB bus, either manually or triggered by an internal IRQ event like
VSYNC or a line input counter.
This adds the register defines.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_r
, producing display glitches.
The vsync irq must still be left enabled otherwise the RDMA modules isn't
trigerred when the interrupt line is masked.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_crtc.c | 77 --
1 file changed, 72 insertions(
ntil we support more pixel formats.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_viu.c | 81 +++
drivers/gpu/drm/meson/meson_viu.h | 4 ++
2 files changed, 85 insertions(+)
diff --git a/drivers/gpu/drm/meson/meson_viu.c
b/drivers/gpu/drm/mes
When using an AFBC encoded frame, the AFBC Decoder must be resetted,
configured and enabled at each vsync IRQ.
To leave time for that, use the maximum lines hold time to give time
for AFBC setup and avoid visual glitches.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_viu.c | 2
handle the RDMA irq.
The RDMA will be usefull to reset and program the AFBC decoder unit
on each vsync without involving the interrupt handler that can
be masked for a log period of time, producing display glitches.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/Makefile | 1 +
drive
Add the registers used to program the ARM Framebuffer Compression decoders
used in the Amlogic GXM and G12A SoCs families.
This also adds the routing and pipeline configuration bits and registers
needed to enable AFBC support.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson
, but needs to keep the
vsync interrupt enabled to trigger the RDMA module.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/Makefile | 2 +-
drivers/gpu/drm/meson/meson_drv.c | 50 ++-
drivers/gpu/drm/meson/meson_drv.h | 12 +
drivers/gpu/drm/meson/meson_osd_afbcd.c
ides to transfer the pixels.
For Amlogic GXM, the supported pixel formats are the same as the normal
linear OSD1 mode.
On the other side, Amlogic added support for all AFBC v1.2 formats for
the G12A AFBC integration.
For simplicity, we stick to the already supported formats for now.
Signed-of
Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Brian Starkey
> Cc: Neil Armstrong
> Cc: Kevin Hilman
> Cc: Laurent Pinchart
> Cc: Kieran Bingham
> Cc: Sandy Huang
> Cc: "Heiko Stübner"
> Cc: Yannick Fertre
> Cc: Philippe
Hi John,
On 21/10/2019 21:03, John Stultz wrote:
> Lucky number 13! :)
>
> Last week in v12 I had re-added some symbol exports to support
> later patches I have pending to enable loading heaps from
> modules. He reminded me that back around v3 (its been awhile!) I
> had removed those exports due
On 22/10/2019 17:56, John Stultz wrote:
> On Tue, Oct 22, 2019 at 1:21 AM Neil Armstrong
> wrote:
>>
>> Hi John,
>>
>> On 21/10/2019 21:03, John Stultz wrote:
>>> Lucky number 13! :)
>>>
>>> Last week in v12 I had re-added some symbol expo
hi Boris,
On 23/10/2019 17:44, Boris Brezillon wrote:
> This patch series aims at adding support for runtime bus-format
> negotiation between all elements of the
> 'encoder -> bridges -> connector/display' section of the pipeline.
>
> In order to support that, we need drm bridges to fully take pa
const struct drm_display_mode *mode,
> - const struct drm_display_mode *adjusted_mode);
> -void drm_bridge_pre_enable(struct drm_bridge *bridge);
> -void drm_bridge_enable(struct drm_bridge *bridge);
> +bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge,
> + const struct drm_display_mode *mode,
> + struct drm_display_mode *adjusted_mode);
> +enum drm_mode_status
> +drm_bridge_chain_mode_valid(struct drm_bridge *bridge,
> + const struct drm_display_mode *mode);
> +void drm_bridge_chain_disable(struct drm_bridge *bridge);
> +void drm_bridge_chain_post_disable(struct drm_bridge *bridge);
> +void drm_bridge_chain_mode_set(struct drm_bridge *bridge,
> +const struct drm_display_mode *mode,
> +const struct drm_display_mode *adjusted_mode);
> +void drm_bridge_chain_pre_enable(struct drm_bridge *bridge);
> +void drm_bridge_chain_enable(struct drm_bridge *bridge);
>
> -void drm_atomic_bridge_disable(struct drm_bridge *bridge,
> -struct drm_atomic_state *state);
> -void drm_atomic_bridge_post_disable(struct drm_bridge *bridge,
> +void drm_atomic_bridge_chain_disable(struct drm_bridge *bridge,
> + struct drm_atomic_state *state);
> +void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge,
> + struct drm_atomic_state *state);
> +void drm_atomic_bridge_chain_pre_enable(struct drm_bridge *bridge,
> + struct drm_atomic_state *state);
> +void drm_atomic_bridge_chain_enable(struct drm_bridge *bridge,
> struct drm_atomic_state *state);
> -void drm_atomic_bridge_pre_enable(struct drm_bridge *bridge,
> - struct drm_atomic_state *state);
> -void drm_atomic_bridge_enable(struct drm_bridge *bridge,
> - struct drm_atomic_state *state);
>
> #ifdef CONFIG_DRM_PANEL_BRIDGE
> struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel);
>
Reviewed-by: Neil Armstrong
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
; spin_lock_irq(&crtc->dev->event_lock);
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 8aeba83fcf31..27eef63ce0ff 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -25,6 +25,7 @@
>
> #include
> #include
> +#include
> #include
> #include
>
> @@ -422,6 +423,20 @@ drm_bridge_chain_get_next_bridge(struct drm_bridge
> *bridge)
> return bridge->next;
> }
>
> +/**
> + * drm_bridge_chain_get_first_bridge() - Get the first bridge in the chain
> + * @encoder: encoder object
> + *
> + * RETURNS:
> + * the first bridge in the chain, or NULL if @encoder has no bridge attached
> + * to it.
> + */
> +static inline struct drm_bridge *
> +drm_bridge_chain_get_first_bridge(struct drm_encoder *encoder)
> +{
> + return encoder->bridge;
> +}
> +
> bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge,
>const struct drm_display_mode *mode,
>struct drm_display_mode *adjusted_mode);
>
Reviewed-by: Neil Armstrong
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
409,6 +409,19 @@ struct drm_bridge *of_drm_find_bridge(struct device_node
> *np);
> int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
> struct drm_bridge *previous);
>
> +/**
> + * drm_bridge_chain_get_next_bridge() - Get
> \
> + list_for_each_entry(bridge, &(encoder)->bridge_chain, chain_node)
> +
> bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge,
>const struct drm_display_mode *mode,
>struct drm_display_mode *adjusted
include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -384,8 +384,8 @@ struct drm_bridge {
> struct drm_device *dev;
> /** @encoder: encoder to which this bridge is connected */
> struct drm_encoder *encoder;
> - /** @next: the nex
drm_bridge_funcs {
>* @atomic_post_disable or @post_disable function. If the preceding
>* element is a &drm_encoder it's called right after the encoder's
>* &drm_encoder_helper_funcs.atomic_disable hook.
> + * This hook is passed the old atomic state (atomic state after new/old
> + * states have been swapped).
>*
>* The bridge must assume that the display pipe (i.e. clocks and timing
>* signals) feeding it is no longer running when this callback is
> @@ -355,7 +363,7 @@ struct drm_bridge_funcs {
>* The @atomic_post_disable callback is optional.
>*/
> void (*atomic_post_disable)(struct drm_bridge *bridge,
> - struct drm_atomic_state *state);
> + struct drm_atomic_state *old_state);
>
> /**
>* @atomic_duplicate_state:
>
Reviewed-by: Neil Armstrong
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
t; +{
> + if (list_is_first(&bridge->chain_node, &bridge->encoder->bridge_chain))
> + return NULL;
> +
> + return list_prev_entry(bridge, chain_node);
> +}
> +
> /**
> * drm_bridge_chain_get_first_bridge() - Get the first bridge in the c
t drm_bridge_state *
> +drm_atomic_helper_bridge_reset(struct drm_bridge *bridge);
> +void drm_atomic_helper_bridge_destroy_state(struct drm_bridge *bridge,
> + struct drm_bridge_state *state);
> +void __drm_atomic_helper_b
ector_state *conn_state);
> +
> /**
>* @atomic_reset:
>*
> @@ -542,6 +566,9 @@ void drm_bridge_chain_mode_set(struct drm_bridge *bridge,
> void drm_bridge_chain_pre_enable(struct drm_bridge *bridge);
> void drm_bridge_chain_enable(struct drm_bridge *bridge);
>
> +int drm_atomic_bridge_chain_check(struct drm_bridge *bridge,
> + struct drm_crtc_state *crtc_state,
> + struct drm_connector_state *conn_state);
> void drm_atomic_bridge_chain_disable(struct drm_bridge *bridge,
>struct drm_atomic_state *state);
> void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge,
>
Reviewed-by: Neil Armstrong
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate
the possible output and input formats for the current mode and monitor,
and use the negotiated formats in a basic atomic_check callback.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 272
On 07/02/2020 12:02, Boris Brezillon wrote:
> On Thu, 6 Feb 2020 20:18:27 +0100
> Neil Armstrong wrote:
>
>> Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate
>
> ^ hooks?
>
>>
On 06/02/2020 20:18, Neil Armstrong wrote:
> Before switching to bridge funcs, make sure drm_display_mode is passed
> as const to the venc functions.
>
> Signed-off-by: Neil Armstrong
> ---
> drivers/gpu/drm/meson/meson_venc.c | 2 +-
> drivers/gpu/drm/meson/meson_ven
On 06/02/2020 20:18, Neil Armstrong wrote:
> Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support
> for these modes in the connector if the platform supports them.
> We limit these modes to DW-HDMI IP version >= 0x200a which
> are designed to support HDMI2.
On 07/02/2020 15:57, Boris Brezillon wrote:
> On Thu, 6 Feb 2020 20:18:30 +0100
> Neil Armstrong wrote:
>
>> Switch the dw-hdmi driver to drm_bridge_funcs by implementing a new local
>> bridge, connecting it to the dw-hdmi bridge, then implement the
>>
Hi,
On 10/02/2020 10:05, Tomi Valkeinen wrote:
> On 10/02/2020 10:49, Andrzej Hajda wrote:
>
>>> Is this ok to merge?
>>
>>
>> Yes, If I remember you have merge rights. If not, let me know.
>
> Yes, I have.
>
> Generally speaking, how do you manage bridge patches? If you give
> reviewed-by/ack
Hi,
On 02/02/2020 19:23, Sam Ravnborg wrote:
> Hi Marek.
>
> On Mon, Jan 27, 2020 at 03:20:22AM +0100, Marek Vasut wrote:
>> Add DT bindings for ITE IT6251 LVDS-to-eDP bridge.
>>
>> Signed-off-by: Marek Vasut
>> Cc: Daniel Vetter
>> Cc: Rob Herring
>> Cc: Sean Cross
>> Cc: devicet...@vger.ker
-by: Tomi Valkeinen
>>> Fixes: aa92213f388b ("drm/bridge: tc358767: Simplify polling in
>>> tc_link_training()")
>>
>> Tested on RDU2 with TC358767/eDP panel, doesn't seem to break anything
>> there, so:
>>
>> Tested-by: Andrey Smirnov
>
> Andrzej, can you pick this up for -fixes?
>
> Tomi
>
Reviewed-by: Neil Armstrong
Applied to drm-misc-fixes
Neil
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
n
> connector sysfs directory")
> Signed-off-by: Geert Uytterhoeven
> Reviewed-by: Neil Armstrong
> ---
> v2:
> - Add Reviewed-by.
> ---
> drivers/gpu/drm/bridge/ti-tfp410.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers
On 21/01/2020 09:27, Bogdan Togorean wrote:
> This patch-set add support for ADV7535 part in ADV7511 driver.
>
> ADV7535 and ADV7533 are pin to pin compatible parts but ADV7535
> support TMDS clock upto 148.5Mhz and resolutions up to 1080p@60Hz.
>
> ---
> Changes in v4:
> - get out ADV7533 v1p2
On 31/01/2020 12:15, Peter Ujfalusi wrote:
> Hi,
>
> Changes since v3:
> - bindings/example: Fixed the node name
> - bindings/example: Added include for GPIO_ACTIVE_LOW and fixed up the gpio
> binding
> - driver: Moved the label for goto in tc358768_calc_pll()
> - driver: Replace
On 29/11/2019 16:23, Jyri Sarha wrote:
> To enable HDMI audio the SND_SOC_HDMI_CODEC needs to be
> configured. Enable HDMI audio by selecting SND_SOC_HDMI_CODEC if
> SND_SOC is configured. SND_SOC_HDMI_CODEC has no config menu entry and
> should be selected atomatically by the drivers using it.
>
On 18/12/2019 13:12, Enric Balletbo i Serra wrote:
> Fix the 'manged' typo with 'managed' in the drm_panel_bridge_add
> kernel-doc documentation.
>
> Signed-off-by: Enric Balletbo i Serra
> ---
>
> drivers/gpu/drm/bridge/panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On 21/01/2020 11:24, Yannick Fertre wrote:
> From: Yannick Fertré
>
> Sometime the post_disable function is missing (not registered).
>
> Signed-off-by: Yannick Fertré
> ---
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --gi
Hi,
On 13/02/2020 00:04, Doug Anderson wrote:
> Andrzej / Neil,
>
> On Mon, Feb 3, 2020 at 4:21 PM Doug Anderson wrote:
>>
>> Andrzej / Neil,
>>
>> On Mon, Feb 3, 2020 at 3:37 PM Bjorn Andersson
>> wrote:
>>>
>>> On Wed 18 Dec 14:35 PST 2019, Douglas Anderson wrote:
>>>
The current bridge
On 12/02/2020 14:42, Fabio Estevam wrote:
> The hardcoded '12' means the number of elements in the
> adv7511_csc_ycbcr_to_rgb[] array, so use the ARRAY_SIZE() macro
> to let the code less error prone.
>
> Signed-off-by: Fabio Estevam
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 16
On 18/12/2019 23:35, Douglas Anderson wrote:
> This series contains a pile of patches that was created to support
> hooking up the AUO B116XAK01 panel to the eDP side of the bridge. In
> general it should be useful for hooking up a wider variety of DP
> panels to the bridge, especially those with
Hi,
On 16/02/2020 18:21, Noralf Trønnes wrote:
> Hi,
>
> A while back I had the idea to turn a Raspberry Pi Zero into a $5
> USB to HDMI/SDTV/DSI/DPI display adapter.
>
> Thinking about how to represent the display to the driver I realised
> that hardware use registers as API. And Linux does hav
(connector, plane, ...).
> - * 1/ The reset operation happens when the bridge is attached, not when
> + *
> + * 1. The reset operation happens when the bridge is attached, not when
>*drm_mode_config_reset() is called
> - * 2/ It's meant to
On 18/02/2020 16:15, Boris Brezillon wrote:
> Commit 751465913f04 ("drm/bridge: Add a drm_bridge_state object")
> introduced new helpers and hooks but the kernel was slightly broken.
> Fix that now.
>
> v2:
> * Fix the drm_atomic_add_encoder_bridges() doc
>
> Fixes: 751465913f04 ("drm/bridge: Add
On 19/02/2020 11:21, Daniel Vetter wrote:
> It's right above the drm_dev_put().
>
> Aside: This driver gets its devm_ stuff all wrong wrt drm_device and
> anything hanging off that. Not the only one unfortunately.
>
> Signed-off-by: Daniel Vetter
> Cc: Neil Armstrong
Hi,
On 19/02/2020 11:20, Daniel Vetter wrote:
> We have lots of these. And the cleanup code tends to be of dubious
> quality. The biggest wrong pattern is that developers use devm_, which
> ties the release action to the underlying struct device, whereas
> all the userspace visible stuff attached
(SM1) in 8bit
(Scatter+Mem Saving on G12A/SM1, Mem Saving on GXL) and 10bit
(Scatter on G12A/SM1, default on GXL).
It's expected to work as-is on GXM and G12B SoCs.
Neil Armstrong (4):
drm/fourcc: Add modifier definitions for describing Amlogic Video
Framebuffer Compression
drm/meson
Add the registers of the VPU VD1 Amlogic FBC decoder module, and routing
register.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_registers.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/meson/meson_registers.h
b/drivers/gpu/drm
the superblock can
be reduced, thus saving memory.
Signed-off-by: Neil Armstrong
---
include/uapi/drm/drm_fourcc.h | 56 +++
1 file changed, 56 insertions(+)
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 5ba481f49931
.
The scatter mode needs a simplier management since only the header is needed,
since it contains an IOMMU scatter table to locate the superblocks in memory.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_drv.h | 16 ++
drivers/gpu/drm/meson/meson_overlay.c | 257
Since the VD1 Amlogic FBC decoder is now configured by the overlay driver,
commit the right registers to decode the Amlogic FBC frame.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_crtc.c | 118 +
1 file changed, 88 insertions(+), 30 deletions
Le 20/02/2020 à 17:27, Neil Armstrong a écrit :
> Add the registers of the VPU VD1 Amlogic FBC decoder module, and routing
> register.
>
> Signed-off-by: Neil Armstrong
> ---
> drivers/gpu/drm/meson/meson_registers.h | 22 ++
> 1 file changed, 22 in
On 20/02/2020 09:35, Vasily Khoruzhick wrote:
> From: Samuel Holland
>
> We don't need to pass '-supply' suffix to devm_get_regulator()
>
> Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> Signed-off-by: Samuel Holland
> Signed-off-by: Vasily Khoruzhick
> ---
> drivers/gpu/d
Hi Jernej,
On 17/02/2020 07:38, Jernej Škrabec wrote:
> Hi!
>
> Dne četrtek, 06. februar 2020 ob 20:18:25 CET je Neil Armstrong napisal(a):
>> From: Jonas Karlman
>>
>> Add the max_bpc property to the dw-hdmi connector to prepare support
>> for 10, 12 & 16bi
.
The scatter mode needs a simplier management since only the header is needed,
since it contains an IOMMU scatter table to locate the superblocks in memory.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_drv.h | 16 ++
drivers/gpu/drm/meson/meson_overlay.c | 257
Add the registers of the VPU VD1 Amlogic FBC decoder module, and routing
register.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_registers.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/meson/meson_registers.h
b/drivers/gpu/drm
Since the VD1 Amlogic FBC decoder is now configured by the overlay driver,
commit the right registers to decode the Amlogic FBC frame.
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/meson/meson_crtc.c | 118 +
1 file changed, 88 insertions(+), 30 deletions
eries/73722/#rev1
Neil Armstrong (4):
drm/fourcc: Add modifier definitions for describing Amlogic Video
Framebuffer Compression
drm/meson: add Amlogic Video FBC registers
drm/meson: overlay: setup overlay for Amlogic FBC
drm/meson: crtc: handle commit of Amlogic FBC frames
drivers/gpu/drm/
the superblock can
be reduced, thus saving memory.
Signed-off-by: Neil Armstrong
---
include/uapi/drm/drm_fourcc.h | 56 +++
1 file changed, 56 insertions(+)
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 8bc0b31597d8
On 29/02/2020 08:42, Jernej Škrabec wrote:
> Hi Neil!
>
> Dne četrtek, 06. februar 2020 ob 20:18:27 CET je Neil Armstrong napisal(a):
>> Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate
>> the possible output and input formats for the current mode an
On 29/02/2020 11:09, Jonas Karlman wrote:
> Hi Jernej,
>
> On 2020-02-29 08:42, Jernej Škrabec wrote:
>> Hi Neil!
>>
>> Dne četrtek, 06. februar 2020 ob 20:18:27 CET je Neil Armstrong napisal(a):
>>> Add the atomic_get_output_bus_fmts, atomic_get_input_bu
On 02/03/2020 10:05, Laurent Pinchart wrote:
> Hi Neil and Jonas,
>
> Thank you for the patch.
>
> On Thu, Feb 06, 2020 at 08:18:24PM +0100, Neil Armstrong wrote:
>> From: Jonas Karlman
>>
>> Configure the correct mtmdsclock for deep colors to prepare sup
Hi Jernej,
On 29/02/2020 17:30, Jernej Skrabec wrote:
> Currently, is_color_space_conversion() compares not only color spaces
> but also formats. For example, function would return true if YCbCr 4:4:4
> and YCbCr 4:2:2 would be set. Obviously in that case color spaces are
> the same.
>
> Fix that
MI_SCAN_MODE_NONE;
> -
> /*
>* The Designware IP uses a different byte format from standard
>* AVI info frames, though generally the bits are in the correct
>
Reviewed-by: Neil Armstrong
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
On 02/03/2020 10:05, Laurent Pinchart wrote:
> Hi Neil and Jonas,
>
> Thank you for the patch.
>
> On Thu, Feb 06, 2020 at 08:18:24PM +0100, Neil Armstrong wrote:
>> From: Jonas Karlman
>>
>> Configure the correct mtmdsclock for deep colors to prepare sup
On 02/03/2020 10:18, Laurent Pinchart wrote:
> Hi Neil and Jonas,
>
> (CC'ing Daniel for a framework question)
>
> Thank you for the patch.
>
> On Fri, Feb 21, 2020 at 09:50:18AM +0100, Neil Armstrong wrote:
>> On 17/02/2020 07:38, Jernej Škrabec wrote:
>>
On 02/03/2020 10:56, Laurent Pinchart wrote:
> Hi Neil,
>
> Thank you for the patch.
>
> On Thu, Feb 06, 2020 at 08:18:26PM +0100, Neil Armstrong wrote:
>> Signed-off-by: Neil Armstrong
>
> How about adding a commit message ?
Done, thanks
>
&
On 02/03/2020 11:18, Laurent Pinchart wrote:
> Hi Neil,
>
> Thank you for the patch.
>
> On Thu, Feb 06, 2020 at 08:18:27PM +0100, Neil Armstrong wrote:
>> Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate
>> the possible output and input forma
On 02/03/2020 11:03, Laurent Pinchart wrote:
> Hi Neil,
>
> Thank you for the patch.
>
> On Thu, Feb 06, 2020 at 08:18:28PM +0100, Neil Armstrong wrote:
>> Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support
>> for these modes in the connector if
On 02/03/2020 17:42, Jernej Škrabec wrote:
> Dne ponedeljek, 02. marec 2020 ob 10:26:09 CET je Neil Armstrong napisal(a):
>> Hi Jernej,
>>
>> On 29/02/2020 17:30, Jernej Skrabec wrote:
>>> Currently, is_color_space_conversion() compares not only color spaces
>
color
drm/bridge: dw-hdmi: add max bpc connector property
Neil Armstrong (9):
drm/bridge: dw-hdmi: Plug atomic state hooks to the default
implementation
drm/bridge: synopsys: dw-hdmi: add bus format negociation
drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a
drm/meson
From: Jonas Karlman
Add the max_bpc property to the dw-hdmi connector to prepare support
for 10, 12 & 16bit output support.
Signed-off-by: Jonas Karlman
Signed-off-by: Neil Armstrong
Reviewed-by: Laurent Pinchart
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
Before switching to bridge funcs, make sure drm_display_mode is passed
as const to the venc functions.
Signed-off-by: Neil Armstrong
Reviewed-by: Boris Brezillon
Acked-by: Laurent Pinchart
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/meson/meson_venc.c | 2 +-
drivers/gpu/drm/meson
To allow using formats from negotiation, stop enforcing input_bus_format
in the private dw-plat-data struct.
Signed-off-by: Neil Armstrong
Reviewed-by: Boris Brezillon
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/meson/meson_dw_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
Add atomic_duplicate_state/atomic_destroy_state/atomic_reset bridge
funcs to allow setup of atomic bridge state.
Signed-off-by: Neil Armstrong
Reviewed-by: Boris Brezillon
Reviewed-by: Laurent Pinchart
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++
1 file
Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate
the possible output and input formats for the current mode and monitor,
and use the negotiated formats in a basic atomic_check callback.
Signed-off-by: Neil Armstrong
Reviewed-by: Boris Brezillon
Reviewed-by: Jernej
order to better support these specific uses cases and switch
to the Common Clock framework for clocks handling in the future.
Signed-off-by: Neil Armstrong
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/meson/meson_dw_hdmi.c | 24 ---
drivers/gpu/drm/meson/meson_vclk.c | 93
Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support
for these modes in the connector if the platform supports them.
We limit these modes to DW-HDMI IP version >= 0x200a which
are designed to support HDMI2.0 display modes.
Signed-off-by: Neil Armstrong
Reviewed-by: Andrzej Ha
Switch the dw-hdmi driver to drm_bridge_funcs by implementing a new local
bridge, connecting it to the dw-hdmi bridge, then implement the
atomic_get_input_bus_fmts/atomic_get_output_bus_fmts.
Signed-off-by: Neil Armstrong
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/meson/meson_dw_hdmi.c
From: Jonas Karlman
Configure the correct mtmdsclock for deep colors to prepare support
for 10, 12 & 16bit output.
Signed-off-by: Jonas Karlman
Signed-off-by: Neil Armstrong
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 21 -
1 file cha
, but
the video encoder must run at 2x the pixel clock.
This patch enables the bridge bus format negociation, and handles
the YUV420 case if selected by the negociation.
Signed-off-by: Neil Armstrong
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/meson/meson_dw_hdmi.c | 91
YUV444 pixel stream to a YUV420
stream.
In addition if pixel stream down-sampling, the Y Cb Cr components must
also be mapped differently to align with the HDMI2.0 specifications.
Signed-off-by: Neil Armstrong
Reviewed-by: Jernej Škrabec
---
drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++-
drivers
ote:
>>>
>>>> On Tue, Mar 3, 2020 at 11:53 AM Brian Starkey
>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> On Tue, Mar 03, 2020 at 12:10:29PM +0200, Pekka Paalanen wrote:
>>>>>> On F
On 04/03/2020 11:40, Neil Armstrong wrote:
> Hi Philippe, Heiko, Maxime, Laurent,
>
> A bad negociation was detected on platforms not implementing a bridge on the
> encoder side, which has been fixed in this version.
>
> Could you check it doesn't break your platforms usi
u32(client->dev.of_node, "reg", ®)) {
> - dev_err(&client->dev,
> - "Can't get i2c reg property from device-tree\n");
> - return -ENXIO;
> + dvi = devm_kzalloc(&client->dev, sizeof(*dvi), GFP_KERNEL);
> + if (!dvi)
> + return -ENOMEM;
> +
> + dvi->dev = &client->dev;
> +
> + dvi->regmap = devm_regmap_init_i2c(client, &tfp410_regmap_config);
> + if (IS_ERR(dvi->regmap))
> + return PTR_ERR(dvi->regmap);
> +
> + ret = tfp410_check_version(dvi);
> + if (ret < 0) {
> + dev_err(dvi->dev, "failed to read device ID (%d)\n", ret);
> + return ret;
> }
>
> - return tfp410_init(&client->dev, true);
> + return tfp410_init(dvi);
> }
>
> static int tfp410_i2c_remove(struct i2c_client *client)
>
Reviewed-by: Neil Armstrong
Neil
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
On 11/03/2020 08:18, Jitao Shi wrote:
> Some chips's sample mode are rising, falling and dual edge (both
> falling and rising edge).
> Extern the pclk-sample property to support dual edge.
>
> Acked-by: Rob Herring
> Reviewed-by: CK Hu
> Signed-off-by: Jitao Shi
> ---
> Documentation/devi
On 11/03/2020 08:18, Jitao Shi wrote:
> DPI can sample on falling, rising or both edge.
> When DPI sample the data both rising and falling edge.
> It can reduce half data io pins.
>
> Reviewed-by: CK Hu
> Signed-off-by: Jitao Shi
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 27 +
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/ite,it66121.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ITE it66121 HDMI bridge Device Tree Bindin
On 13/03/2020 15:17, Laurent Pinchart wrote:
> Hi Neil,
>
> On Fri, Mar 13, 2020 at 03:12:13PM +0100, Neil Armstrong wrote:
>> On 13/03/2020 14:40, Laurent Pinchart wrote:
>>> On Wed, Mar 11, 2020 at 01:51:33PM +0100, Phong LE wrote:
>>>> Add the ITE bridge HDM
On 30/12/2019 10:04, Enric Balletbo i Serra wrote:
> Hi all,
>
> This is another version of the driver. Note that the driver changed
> significally and is a more simply because now is using the panel_bridge
> helpers. Apart from this, I addressed the comments from Maxime, Laurent
> and Ezequiel.
>
e_reset,
> };
>
> after applying the following I got a hdmi signal again
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index 0c28816146ba..7e7b0fac8f4f 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/
ature by adding a new
> drm_bridge_state object inheriting from drm_private_obj so we can
> re-use some of the existing state initialization/tracking logic.
>
> Signed-off-by: Boris Brezillon
> Signed-off-by: Neil Armstrong
> ---
> Changes in v8:
> * Move bridge state he
gix_dp_bridge_atomic_enable,
> .atomic_disable = analogix_dp_bridge_atomic_disable,
>
Reviewed-by: Neil Armstrong
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
isable,
> + .atomic_reset = drm_atomic_helper_bridge_reset,
> + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
> + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt,
> };
>
> /
601 - 700 of 3201 matches
Mail list logo