[PATCH] gpu/drm: mediatek: hdmi: check for valid modes on MT8167

2021-04-09 Thread Neil Armstrong
On MT8167, only CEA modes and anything using a clock below 148500 is supported for HDMI. This change adds some checks to make sure the video format is OK for MT8167. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 17 + 1

Re: [PATCH 00/18] drm/vc4: hdmi: Add Support for the YUV output

2021-04-09 Thread Neil Armstrong
On 18/03/2021 19:16, Jernej Škrabec wrote: > Hi! > > Dne sreda, 17. marec 2021 ob 16:43:34 CET je Maxime Ripard napisal(a): >> Hi, >> >> Here's an attempt at support the HDMI YUV output on the BCM2711 SoC found on >> the RaspberryPi4. >> >> I took the same approach than what dw-hdmi did already, t

Re: [PATCH] gpu/drm: mediatek: hdmi: check for valid modes on MT8167

2021-04-12 Thread Neil Armstrong
On 10/04/2021 00:41, Chun-Kuang Hu wrote: > Hi, Neil: > > Neil Armstrong 於 2021年4月9日 週五 下午4:43寫道: >> >> On MT8167, only CEA modes and anything using a clock below 148500 is >> supported for HDMI. This change adds some checks to make sure the >> video format is

[PATCH v2 0/5] mediatek: hdmi: add MT8167 configuration

2021-04-12 Thread Neil Armstrong
to specify mac TMDS supported clock - add a conf entry for the MT8167 compatible Neil Armstrong (5): dt-bindings: display: mediatek,hdmi: Convert to use graph schema dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings gpu/drm: mediatek: hdmi: add check for CEA modes only gpu

[PATCH v2 5/5] gpu/drm: mediatek: hdmi: add MT8167 configuration

2021-04-12 Thread Neil Armstrong
The MT8167 SoC have a hard limit on the maximal supported HDMI TMDS clock, and is not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration entry linked to the MT8167 compatible. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm

[PATCH v2 2/5] dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings

2021-04-12 Thread Neil Armstrong
Add mt8167 SoC compatible to Mediatek hdmi, hdmi-ddc and cec schema bindings. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/display/mediatek/mediatek,cec.yaml | 1 + .../devicetree/bindings/display/mediatek/mediatek,hdmi-ddc.yaml | 1 + .../devicetree/bindings/display

[PATCH v2 1/5] dt-bindings: display: mediatek, hdmi: Convert to use graph schema

2021-04-12 Thread Neil Armstrong
Update the mediatek,dpi binding to use the graph schema. Signed-off-by: Neil Armstrong --- .../display/mediatek/mediatek,cec.yaml| 51 +++ .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 .../display/mediatek/mediatek,hdmi.txt| 136

[PATCH v2 3/5] gpu/drm: mediatek: hdmi: add check for CEA modes only

2021-04-12 Thread Neil Armstrong
Some SoCs like the MT8167 are not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration boolean to filter out non-CEA modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 1 file changed, 4 insertions

[PATCH v2 4/5] gpu/drm: mediatek: hdmi: add optional limit on maximal HDMI mode clock

2021-04-12 Thread Neil Armstrong
Some SoCs like the MT8167 have a hard limit on the maximal supported HDMI TMDS clock, so add a configuration value to filter out those modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-12 Thread Neil Armstrong
From: Phong LE This commit is a simple driver for bridge HMDI it66121. The input format is RBG and there is no color conversion. Audio, HDCP and CEC are not supported yet. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/Kconfig |8 + drivers/gpu/drm

[PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings

2021-04-12 Thread Neil Armstrong
From: Phong LE Add the ITE bridge HDMI it66121 bindings. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong --- .../bindings/display/bridge/ite,it66121.yaml | 123 ++ 1 file changed, 123 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge

[PATCH v3 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry

2021-04-12 Thread Neil Armstrong
From: Phong LE Add Neil Armstrong and myself as maintainers Signed-off-by: Phong LE --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ae8444c96b4..ff6450c83049 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9515,6 +9515,14 @@ Q

[PATCH v3 0/3] drm/bridge: Add it66121 driver

2021-04-12 Thread Neil Armstrong
The IT66121 is a high-performance and low-power single channel HDMI transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward compatible to DVI 1.0 specifications. It supports pixel rates from 25MHz to 165MHz. This series contains document bindings, add vendor prefix, Kconfig to enable or

Re: [PATCH v3 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry

2021-04-12 Thread Neil Armstrong
On 12/04/2021 17:46, Neil Armstrong wrote: > From: Phong LE > > Add Neil Armstrong and myself as maintainers > > Signed-off-by: Phong LE Obviously: Signed-off-by: Neil Armstrong > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --g

Re: [PATCH v2 1/5] dt-bindings: display: mediatek,hdmi: Convert to use graph schema

2021-04-12 Thread Neil Armstrong
On 12/04/2021 11:39, Neil Armstrong wrote: > Update the mediatek,dpi binding to use the graph schema. > > Signed-off-by: Neil Armstrong > --- > .../display/mediatek/mediatek,cec.yaml| 51 +++ > .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 >

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-13 Thread Neil Armstrong
Hi Rob, Le 13/04/2021 à 22:21, Robert Foss a écrit : > Hey Neil & Phong, > > Thanks for submitting this series! > >> + >> +static const struct drm_bridge_funcs it66121_bridge_funcs = { >> + .attach = it66121_bridge_attach, >> + .enable = it66121_bridge_enable, >> + .disable = i

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-13 Thread Neil Armstrong
d failures, I'll fix these for v4. Were you able to test on your setup ? The v2 always forced DDR mode, with this v3, I also switch to normal 24input mode, but totally untested. Thanks, Neil > > Cheers, > -Paul > > > Le lun. 12 avril 2021 à 17:46, Neil Armstrong a &

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-14 Thread Neil Armstrong
On 14/04/2021 10:06, Robert Foss wrote: > On Wed, 14 Apr 2021 at 08:13, Neil Armstrong wrote: >> >> Hi Rob, >> >> Le 13/04/2021 à 22:21, Robert Foss a écrit : >>> Hey Neil & Phong, >>> >>> Thanks for submitting this ser

Re: [PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings

2021-04-14 Thread Neil Armstrong
On 13/04/2021 18:03, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Mon, Apr 12, 2021 at 05:46:46PM +0200, Neil Armstrong wrote: >> From: Phong LE >> >> Add the ITE bridge HDMI it66121 bindings. >> >> Signed-off-b

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-14 Thread Neil Armstrong
On 14/04/2021 10:16, Laurent Pinchart wrote: > Hi Neil, > > On Wed, Apr 14, 2021 at 10:08:46AM +0200, Neil Armstrong wrote: >> On 14/04/2021 10:06, Robert Foss wrote: >>> On Wed, 14 Apr 2021 at 08:13, Neil Armstrong >>> wrote: >>>> Le 13/04/2021

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-15 Thread Neil Armstrong
On 14/04/2021 19:35, Paul Cercueil wrote: > Hi Neil, > > Le mer. 14 avril 2021 à 8:17, Neil Armstrong a > écrit : >> Hi, >> >> Le 13/04/2021 à 22:56, Paul Cercueil a écrit : >>>  Hi Neil, >>> >>>  I get build failures locally: &

[PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
pin, leading to some confusion when the DW-HDMI CEC controller can't communicate on the bus. Jernej Skrabec (1): drm/bridge/synopsys: dw-hdmi: Add an option to suppress loading CEC driver Neil Armstrong (1): drm/meson: dw-hdmi: disable DW-HDMI CEC sub-driver drivers/gpu/drm/b

[PATCH 1/2] drm/bridge/synopsys: dw-hdmi: Add an option to suppress loading CEC driver

2021-04-16 Thread Neil Armstrong
connected to a physical pin, leading to some confusion when the DW-HDMI CEC controller can't communicate on the bus. Reviewed-by: Neil Armstrong Signed-off-by: Jernej Skrabec Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- include/drm/bridge/dw_h

[PATCH 2/2] drm/meson: dw-hdmi: disable DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
On the Amlogic SoCs, the DW-HDMI HW support is here but the DW-HDMI CEC signal is not connected to a physical pin, leading to confusion when the dw-hdmi cec controller can't communicate on the bus. Disable it to avoid exposing a non-functinal bus. Signed-off-by: Neil Armstrong --- driver

Re: [PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
On 16/04/2021 11:58, Laurent Pinchart wrote: > Hi Neil, > > On Fri, Apr 16, 2021 at 11:27:35AM +0200, Neil Armstrong wrote: >> This adds DW-HDMI driver a glue option to disable loading of the CEC >> sub-driver. >> >> On some SoCs, the CEC functionality is enabl

[PATCH v4 0/3] drm/bridge: Add it66121 driver

2021-04-19 Thread Neil Armstrong
The IT66121 is a high-performance and low-power single channel HDMI transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward compatible to DVI 1.0 specifications. It supports pixel rates from 25MHz to 165MHz. This series contains document bindings, add vendor prefix, Kconfig to enable or

[PATCH v4 1/3] dt-bindings: display: bridge: add it66121 bindings

2021-04-19 Thread Neil Armstrong
From: Phong LE Add the ITE bridge HDMI it66121 bindings. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/ite,it66121.yaml | 124 ++ 1 file changed, 124 insertions(+) create mode

[PATCH v4 2/3] drm: bridge: add it66121 driver

2021-04-19 Thread Neil Armstrong
From: Phong LE This commit is a simple driver for bridge HMDI it66121. The input format is RBG and there is no color conversion. Audio, HDCP and CEC are not supported yet. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/Kconfig |8 + drivers/gpu/drm

[PATCH v4 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry

2021-04-19 Thread Neil Armstrong
From: Phong LE Add Neil Armstrong and myself as maintainers Signed-off-by: Phong LE Signed-off-by: Neil Armstrong Reviewed-by: Robert Foss --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ae8444c96b4..313b3374a51e 100644 --- a

[PATCH v3 0/5] mediatek: hdmi: add MT8167 configuration

2021-04-19 Thread Neil Armstrong
to specify mac TMDS supported clock - add a conf entry for the MT8167 compatible Changes since v4: - fixed bindings Neil Armstrong (5): dt-bindings: display: mediatek,hdmi: Convert to use graph schema dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings gpu/drm: mediatek: hdmi

[PATCH v3 1/5] dt-bindings: display: mediatek, hdmi: Convert to use graph schema

2021-04-19 Thread Neil Armstrong
Update the mediatek,dpi binding to use the graph schema. Signed-off-by: Neil Armstrong --- .../display/mediatek/mediatek,cec.yaml| 51 +++ .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 .../display/mediatek/mediatek,hdmi.txt| 136

[PATCH v3 2/5] dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings

2021-04-19 Thread Neil Armstrong
Add mt8167 SoC compatible to Mediatek hdmi, hdmi-ddc and cec schema bindings. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/display/mediatek/mediatek,cec.yaml | 1 + .../devicetree/bindings/display/mediatek/mediatek,hdmi-ddc.yaml | 1 + .../devicetree/bindings/display

[PATCH v3 3/5] gpu/drm: mediatek: hdmi: add check for CEA modes only

2021-04-19 Thread Neil Armstrong
Some SoCs like the MT8167 are not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration boolean to filter out non-CEA modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 1 file changed, 4 insertions

[PATCH v3 4/5] gpu/drm: mediatek: hdmi: add optional limit on maximal HDMI mode clock

2021-04-19 Thread Neil Armstrong
Some SoCs like the MT8167 have a hard limit on the maximal supported HDMI TMDS clock, so add a configuration value to filter out those modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v3 5/5] gpu/drm: mediatek: hdmi: add MT8167 configuration

2021-04-19 Thread Neil Armstrong
The MT8167 SoC have a hard limit on the maximal supported HDMI TMDS clock, and is not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration entry linked to the MT8167 compatible. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm

Re: [PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-20 Thread Neil Armstrong
On 20/04/2021 17:13, Hans Verkuil wrote: > On 16/04/2021 13:38, Neil Armstrong wrote: >> On 16/04/2021 11:58, Laurent Pinchart wrote: >>> Hi Neil, >>> >>> On Fri, Apr 16, 2021 at 11:27:35AM +0200, Neil Armstrong wrote: >>>> This adds DW-HDMI dr

Re: [PATCH v4 2/3] drm: bridge: add it66121 driver

2021-04-21 Thread Neil Armstrong
Hi Paul, On 19/04/2021 09:12, Neil Armstrong wrote: > From: Phong LE > > This commit is a simple driver for bridge HMDI it66121. > The input format is RBG and there is no color conversion. > Audio, HDCP and CEC are not supported yet. Did you manage to get it working on your pl

Re: [PATCH v4 2/3] drm: bridge: add it66121 driver

2021-04-21 Thread Neil Armstrong
Hi, On 21/04/2021 11:58, Paul Cercueil wrote: > Hi Neil, > > Le mer. 21 avril 2021 à 11:25, Neil Armstrong a > écrit : >> Hi Paul, >> >> On 19/04/2021 09:12, Neil Armstrong wrote: >>>  From: Phong LE >>> >>>  This commit is a simple dri

Re: [PATCH v4 0/3] drm/bridge: Add it66121 driver

2021-04-21 Thread Neil Armstrong
On 19/04/2021 09:12, Neil Armstrong wrote: > The IT66121 is a high-performance and low-power single channel HDMI > transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward > compatible to DVI 1.0 specifications. > It supports pixel rates from 25MHz to 165MHz. > > Th

Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings

2021-04-22 Thread Neil Armstrong
On 22/04/2021 00:31, Marek Vasut wrote: > Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge. > > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Jagan Teki > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: Stephen Boyd > C

Re: [PATCH v2] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-22 Thread Neil Armstrong
l modeset when only connector's DPMS is > brought out of "Off" status. I would split the changes in multiple patches to clarify the changes. Neil > > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jer

Re: [PATCH v2] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-22 Thread Neil Armstrong
Hi, On 22/04/2021 11:31, Liu Ying wrote: > Hi Neil, > > On Thu, 2021-04-22 at 10:48 +0200, Neil Armstrong wrote: >> Hi, >> >> On 22/04/2021 07:14, Liu Ying wrote: >>> Some MIPI DSI panel drivers like 'raydium,rm68200' send >>> MIPI_DCS_S

Re: [PATCH] drm: bridge: add missing word in Analogix help text

2021-04-26 Thread Neil Armstrong
Le 24/04/2021 à 08:18, Randy Dunlap a écrit : > Insert a missing word "power" in Kconfig help text. > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > Signed-off-by: Randy Dunlap > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robe

Re: [PATCH v3 0/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-26 Thread Neil Armstrong
Hi, On 23/04/2021 11:26, Liu Ying wrote: > Hi, > > This series aims to make the nwl-dsi bridge be able to connect with > more MIPI DSI panels. Some MIPI DSI panel drivers like 'raydium,rm68200' > send MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which > requires the MIPI DSI contr

Re: [PATCH] drm: bridge: add missing word in Analogix help text

2021-04-26 Thread Neil Armstrong
On 26/04/2021 09:42, Robert Foss wrote: > > > On Mon, Apr 26, 2021, 09:15 Neil Armstrong <mailto:narmstr...@baylibre.com>> wrote: > > > > Le 24/04/2021 à 08:18, Randy Dunlap a écrit : > > Insert a missing word "power" in Kconfig help t

Re: [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU

2021-04-26 Thread Neil Armstrong
Hi, On 21/04/2021 07:28, Nicolas Boichat wrote: > Hi! > > This is just a rebase of the v11, untested (but it seems like > Neil Armstrong recently tested it), with small changes in > binding and dts. v11 cover follows: > > Follow-up on the v5 [1], things have gotten signific

Re: [PATCH] drm: bridge: add missing word in Analogix help text

2021-04-27 Thread Neil Armstrong
On 26/04/2021 10:59, Neil Armstrong wrote: > On 26/04/2021 09:42, Robert Foss wrote: >> >> >> On Mon, Apr 26, 2021, 09:15 Neil Armstrong > <mailto:narmstr...@baylibre.com>> wrote: >> >> >> >> Le 24/04/2021 à 08:18, Randy Dunlap a écrit

Re: [PATCH] drm/bridge: anx7625: Fix power on delay

2021-04-27 Thread Neil Armstrong
00); > > /* Power on pin enable */ > gpiod_set_value(ctx->pdata.gpio_p_on, 1); > Reviewed-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Neil Armstrong
On 28/04/2021 11:26, Loic Poulain wrote: > On Wed, 28 Apr 2021 at 10:13, Frieder Schrempf > wrote: >> >> On 28.04.21 09:51, Frieder Schrempf wrote: >>> On 22.04.21 00:31, Marek Vasut wrote: Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-lin

[PATCH] drm/meson: fix shutdown crash when component not probed

2021-04-30 Thread Neil Armstrong
it. Fixes: fa0c16caf3d7 ("drm: meson_drv add shutdown function") Reported-by: Stefan Agner Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_drv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-30 Thread Neil Armstrong
On 29/04/2021 18:27, Frieder Schrempf wrote: > On 28.04.21 16:16, Marek Vasut wrote: >> On 4/28/21 11:24 AM, Neil Armstrong wrote: >> [...] >> >>>>>>> +static int sn65dsi83_probe(struct i2c_client *client, >>>>>>> +  

Re: [PATCH v3 1/3] drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true

2021-04-30 Thread Neil Armstrong
->atomic_disable() are called in pairs. > > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: David Airlie > Cc: Daniel Vetter > Cc: Guido Günther > Cc: Robert Chiras > Cc: NXP

Re: [PATCH v3 2/3] drm/bridge: nwl-dsi: Remove a check on unchanged HS clock rate from ->mode_set()

2021-04-30 Thread Neil Armstrong
ely skipped. > So, this patch removes that check to make sure MIPI DSI controller > and PHY will be brought up and taken down from ->mode_set() and > ->atomic_disable() respectively in pairs. > > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Lauren

Re: [PATCH v3 3/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-30 Thread Neil Armstrong
IPI DSI panels can connect to this nwl-dsi bridge. > > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: David Airlie > Cc: Daniel Vetter > Cc: Guido Günther > Cc: Robert Chiras >

Re: [PATCH v3 0/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-30 Thread Neil Armstrong
On 23/04/2021 11:26, Liu Ying wrote: > Hi, > > This series aims to make the nwl-dsi bridge be able to connect with > more MIPI DSI panels. Some MIPI DSI panel drivers like 'raydium,rm68200' > send MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which > requires the MIPI DSI controller

Re: [PATCH 02/18] drm/bridge: Add HDMI output fmt helper

2021-03-17 Thread Neil Armstrong
On 17/03/2021 16:43, Maxime Ripard wrote: > The atomic_get_output_bus_fmts bridge callback is there to list the > available formats for output by decreasing order of preference. > > On HDMI controllers, we have a fairly static list that will depend on > what the HDMI sink is capable of and the BPC

Re: [PATCH] drm/meson: Fix few typo

2021-03-19 Thread Neil Armstrong
On 18/03/2021 12:00, Bhaskar Chowdhury wrote: > > s/initialy/initially/ > s/desined/designed/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/gpu/drm/meson/meson_venc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_venc.c > b/drivers

Re: [PATCH 02/18] drm/bridge: Add HDMI output fmt helper

2021-03-19 Thread Neil Armstrong
On 18/03/2021 19:31, Jernej Škrabec wrote: > Dne sreda, 17. marec 2021 ob 17:08:07 CET je Neil Armstrong napisal(a): >> On 17/03/2021 16:43, Maxime Ripard wrote: >>> The atomic_get_output_bus_fmts bridge callback is there to list the >>> available formats for ou

Re: [PATCH v1] MAINTAINERS: Update Maintainers of DRM Bridge Drivers

2021-03-24 Thread Neil Armstrong
Hi ! On 24/03/2021 11:20, Robert Foss wrote: > Add myself as co-maintainer of DRM Bridge Drivers. Repository > commit access has already been granted. > > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/338 > > Cc: Neil Armstrong > Cc: Laurent Pinchart

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-15 Thread Neil Armstrong
Hi, On 10/01/2021 21:06, Oliver Graute wrote: > On 10/01/21, Fabio Estevam wrote: >> Hi Oliver, >> >> On Sun, Jan 10, 2021 at 12:35 PM Oliver Graute >> wrote: >> >>> the first two errors are gone. But I still get this: >>> >>> [ 42.387107] mxsfb 21c8000.lcdif: Cannot connect bridge: -517 >>>

Re: [PATCH 2/2] dt-bindings: display: Add "disable-hpd" binding

2021-02-08 Thread Neil Armstrong
Hi, On 31/01/2021 10:57, Mykyta Poturai wrote: > Add the "disable-hpd" binding, used to disable hotplug detected > functionality in the driver. When it's enabled the driver assumes that > the connector is always connected and disables the hotplug detect > related IRQ. DT describes the hardware, n

Re: [PATCH 1/2] drm/bridge: dw-hdmi: Add DT binding to disable hotplug detect

2021-02-08 Thread Neil Armstrong
On 31/01/2021 10:55, Mykyta Poturai wrote: > Add "disable-hpd" boolean binding for the device tree. When this option > is turned on HPD-related IRQ is disabled and it is assumed that the HDMI > connector is connected all the time. This may be useful in systems where > it is impossible or undesirabl

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-02-15 Thread Neil Armstrong
Hi, On 14/02/2021 18:44, Jagan Teki wrote: > SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge > controller IC's from Texas Instruments. > > SN65DSI83 - Single Channel DSI to Single-link LVDS bridge > SN65DSI84 - Single Channel DSI to Dual-link LVDS bridge > SN65DSI85 - Dual Channel DSI t

Re: ITE66121 HDMI driver

2021-02-15 Thread Neil Armstrong
Hi, On 14/02/2021 00:54, Paul Cercueil wrote: > Hi Phong and Neil, > > I see you sent a patchset to support the ITE66121 HDMI transmitter, last > version being the V2 back in March 2020. > > Do you still plan to mainline it? Yes, we still plan to mainline it. > > I do have a device with a IT

Re: [PATCH 1/3] dt-bindings: Add YAML bindings for Host1x and NVDEC

2021-02-15 Thread Neil Armstrong
On 13/02/2021 11:15, Mikko Perttunen wrote: > Convert the original Host1x bindings to YAML and add new bindings for > NVDEC, now in a more appropriate location. The old text bindings > for Host1x and engines are still kept at display/tegra/ since they > encompass a lot more engines that haven't bee

Re: [PATCH 0/3] NVIDIA Tegra NVDEC support

2021-02-15 Thread Neil Armstrong
Hi, On 13/02/2021 11:15, Mikko Perttunen wrote: > Hi all, > > with the release of documentation headers for Tegra multimedia engines > (NVDEC, NVENC, NVJPG) [1], I have started working on the corresponding > implementations. Here's the first one, NVDEC. > > The kernel driver is a simple Falcon b

Re: [PATCH 0/3] NVIDIA Tegra NVDEC support

2021-02-15 Thread Neil Armstrong
Hi Thierry, On 15/02/2021 10:50, Thierry Reding wrote: > On Mon, Feb 15, 2021 at 10:10:26AM +0100, Neil Armstrong wrote: >> Hi, >> >> On 13/02/2021 11:15, Mikko Perttunen wrote: >>> Hi all, >>> >>> with the release of documentation headers for T

Re: ITE66121 HDMI driver

2021-02-15 Thread Neil Armstrong
On 15/02/2021 13:01, Paul Cercueil wrote: > > > Le lun. 15 févr. 2021 à 10:05, Neil Armstrong a > écrit : >> Hi, >> >> On 14/02/2021 00:54, Paul Cercueil wrote: >>>  Hi Phong and Neil, >>> >>>  I see you sent a patchset to support the

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-02-15 Thread Neil Armstrong
Hi, On 15/02/2021 12:25, Jagan Teki wrote: > On Mon, Feb 15, 2021 at 2:32 PM Neil Armstrong > wrote: >> >> Hi, >> >> On 14/02/2021 18:44, Jagan Teki wrote: >>> SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge >>> controller IC'

Re: [PATCH] drm: meson_drv add shutdown function

2021-03-08 Thread Neil Armstrong
gt; > static struct platform_driver meson_drm_platform_driver = { > .probe = meson_drv_probe, > + .shutdown = meson_drv_shutdown, > .driver = { > .name = "meson-drm", > .of_match_table = dt_match, > Acked-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: meson_drv add shutdown function

2021-03-09 Thread Neil Armstrong
On 02/03/2021 05:22, Artem Lapkin wrote: > Problem: random stucks on reboot stage about 1/20 stuck/reboots > // debug kernel log > [4.496660] reboot: kernel restart prepare CMD:(null) > [4.498114] meson_ee_pwrc c883c000.system-controller:power-controller: > shutdown begin > [4.503949]

Re: [PATCH] drm: meson_drv add shutdown function

2021-03-09 Thread Neil Armstrong
On 09/03/2021 18:13, Kevin Hilman wrote: > Hi Neil, > > Neil Armstrong writes: > >> On 02/03/2021 05:22, Artem Lapkin wrote: >>> Problem: random stucks on reboot stage about 1/20 stuck/reboots >>> // debug kernel log >>> [4.496660] reboot: kernel

Re: [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU

2021-05-14 Thread Neil Armstrong
On 13/05/2021 16:55, Ezequiel Garcia wrote: > Hi Neil, > > On Mon, 26 Apr 2021 at 06:59, Neil Armstrong wrote: >> >> Hi, >> >> On 21/04/2021 07:28, Nicolas Boichat wrote: >>> Hi! >>> >>> This is just a rebase of the v11, untested (bu

Re: [PATCH 1/2] drm: bridge: it66121: fix an error code in it66121_probe()

2021-05-17 Thread Neil Armstrong
> - return PTR_ERR(ctx); > + return PTR_ERR(ctx->regmap); > } > > regmap_read(ctx->regmap, IT66121_VENDOR_ID0_REG, &vendor_ids[0]); > Thanks ! Acked-by: Neil Armstrong Applying to drm-misc-fixes

Re: [PATCH 2/2] drm: bridge: it66121: fix a resource leak in probe

2021-05-17 Thread Neil Armstrong
> + ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0); > + if (!ep) > + return -EINVAL; > + > ctx->dev = dev; > ctx->client = client; > > Thanks ! Acked-by: Neil Armstrong Applying to drm-misc-fixes

Re: [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU

2021-05-17 Thread Neil Armstrong
On 14/05/2021 17:27, Steven Price wrote: > On 14/05/2021 15:48, Neil Armstrong wrote: >> On 13/05/2021 16:55, Ezequiel Garcia wrote: >>> Hi Neil, >>> >>> On Mon, 26 Apr 2021 at 06:59, Neil Armstrong >>> wrote: >>>> >>>&g

[PATCH 0/2] drm: panel: add support for the Khadas TS050 panel

2020-11-23 Thread Neil Armstrong
This add support & bindings for the Khadas TS050 1080x1920 5" LCD DSI panel designed to work with the Khadas Edge-V, Captain, VIM3 and VIM3L Single Board Computers. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller. Neil Armstrong (2): dt

[PATCH 1/2] dt-bindings: panel-simple-dsi: add Khadas TS050 panel bindings

2020-11-23 Thread Neil Armstrong
This add the bindings for the Khadas TS050 1080x1920 5" LCD DSI panel designed to work with the Khadas Edge-V, Captain, VIM3 and VIM3L Single Board Computers. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++ 1 file changed, 2 inser

[PATCH 2/2] drm: panel: add Khadas TS050 panel driver

2020-11-23 Thread Neil Armstrong
ource tree, comments were added to the know values but most of the init table is undocumented. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-khadas-ts050.c

Re: [PATCH 2/2] drm: panel: add Khadas TS050 panel driver

2020-11-24 Thread Neil Armstrong
Hi Sam, On 23/11/2020 22:05, Sam Ravnborg wrote: > Hi Neil. > > Looks good but a few comments in the following that needs some attention. > > Sam > > On Mon, Nov 23, 2020 at 03:33:54PM +0100, Neil Armstrong wrote: >> This add support for the Khadas TS050

[PATCH v2 0/2] drm: panel: add support for the Khadas TS050 panel

2020-12-04 Thread Neil Armstrong
k enabled=true unconditionnally - use dev_err_probe in probe() Neil Armstrong (2): dt-bindings: panel-simple-dsi: add Khadas TS050 panel bindings drm: panel: add Khadas TS050 panel driver .../display/panel/panel-simple-dsi.yaml | 2 + drivers/gpu/drm/panel/Kconfig

[PATCH v2 1/2] dt-bindings: panel-simple-dsi: add Khadas TS050 panel bindings

2020-12-04 Thread Neil Armstrong
This add the bindings for the Khadas TS050 1080x1920 5" LCD DSI panel designed to work with the Khadas Edge-V, Captain, VIM3 and VIM3L Single Board Computers. Signed-off-by: Neil Armstrong Reviewed-by: Sam Ravnborg --- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2

[PATCH v2 2/2] drm: panel: add Khadas TS050 panel driver

2020-12-04 Thread Neil Armstrong
ource tree, comments were added to the know values but most of the init table is undocumented. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-khadas-ts050.c

Re: [PATCH v2 2/2] drm: panel: add Khadas TS050 panel driver

2020-12-07 Thread Neil Armstrong
Hi, On 05/12/2020 20:15, Sam Ravnborg wrote: > Hi Neil, > >> + >> +static int khadas_ts050_panel_probe(struct mipi_dsi_device *dsi) >> +{ >> +struct khadas_ts050_panel *khadas_ts050; >> +int err; >> + >> +dsi->lanes = 4; >> +dsi->format = MIPI_DSI_FMT_RGB888; >> +dsi->mode_fla

Re: [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Neil Armstrong
; > Signed-off-by: Thomas Zimmermann > --- ... > drivers/gpu/drm/meson/meson_drv.c | 2 +- Acked-by: Neil Armstrong ... > > diff --git a/drivers/gpu/drm/meson/meson_drv.c > b/drivers/gpu/drm/meson/meson_drv.c > index a7388bf7c838..3d0ccc7eef1b

Re: [PATCH] drm/meson: Convert to Linux IRQ interfaces

2021-07-06 Thread Neil Armstrong
> drm_dev_put(drm); > > @@ -382,7 +378,7 @@ static void meson_drv_unbind(struct device *dev) > drm_kms_helper_poll_fini(drm); > drm_atomic_helper_shutdown(drm); > component_unbind_all(dev, drm); > - drm_irq_uninstall(drm); > + free_irq(priv->vsync_irq, drm); > drm_dev_put(drm); > > if (priv->afbcd.ops) { > Looks good ! Reviewed-by: Neil Armstrong Thanks, Neil

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-03 Thread Neil Armstrong
On 03/11/2020 03:02, Rob Herring wrote: > On Mon, Nov 2, 2020 at 10:38 AM Neil Armstrong > wrote: >> >> On 02/11/2020 16:16, Rob Herring wrote: >>> On Fri, Oct 30, 2020 at 4:15 PM Sam Ravnborg wrote: >>>> >>>> Hi Neil. >>>> >

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-03 Thread Neil Armstrong
On 02/11/2020 19:04, Sam Ravnborg wrote: > Hi Neil. > >>> --- >>> .../bindings/display/intel,keembay-display.yaml| 75 >>> ++ >>> 1 file changed, 75 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/display/intel,keembay-

Re: [PATCH 17/40] drm/meson/meson_vclk: Make two local functions static

2020-11-16 Thread Neil Armstrong
s prototype for > ‘meson_hdmi_pll_set_params’ [-Wmissing-prototypes] > > Cc: Neil Armstrong > Cc: David Airlie > Cc: Daniel Vetter > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: dri-devel@lists.freedesktop.org > Cc: linux-am

Re: [PATCH 14/40] drm/meson/meson_venc: Make local function 'meson_venc_hdmi_get_dmt_vmode' static

2020-11-16 Thread Neil Armstrong
On 13/11/2020 14:49, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/meson/meson_venc.c:893:6: warning: no previous prototype for > ‘meson_venc_hdmi_get_dmt_vmode’ [-Wmissing-prototypes] > > Cc: Neil Armstrong > Cc: David Airlie

Re: [PATCH 0/4] drm/meson: Module removal fixes

2020-11-17 Thread Neil Armstrong
Hi Marc, On 16/11/2020 21:07, Marc Zyngier wrote: > Hi all, > > Having recently moved over to a top-of-the-tree u-boot on one of my > VIM3L systems in order to benefit from unrelated improvements > (automatic PCIe detection, EFI...), I faced the issue that my kernel > would hang like this: > > [

Re: [PATCH 1/4] drm/meson: Free RDMA resources after tearing down DRM

2020-11-17 Thread Neil Armstrong
t; > - if (priv->afbcd.ops) { > - priv->afbcd.ops->reset(priv); > - meson_rdma_free(priv); > - } > - > drm_dev_unregister(drm); > drm_irq_uninstall(drm); > drm_kms_helper_poll_fini(drm); > drm_dev_put(drm

Re: [PATCH 2/4] drm/meson: Unbind all connectors on module removal

2020-11-17 Thread Neil Armstrong
3d1de9cbb1c8 100644 > --- a/drivers/gpu/drm/meson/meson_drv.c > +++ b/drivers/gpu/drm/meson/meson_drv.c > @@ -390,8 +390,10 @@ static void meson_drv_unbind(struct device *dev) > } > > drm_dev_unregister(drm); > - drm_irq_uninstall(drm); > drm_kms_helper_poll_fini(drm); > +

Re: [PATCH 3/4] drm/meson: dw-hdmi: Register a callback to disable the regulator

2020-11-17 Thread Neil Armstrong
= devm_add_action_or_reset(dev, meson_disable_regulator, > +meson_dw_hdmi->hdmi_supply); > + if (ret) > + return ret; > } > > meson_dw_hdmi->hdmitx_apb = devm_reset_control_get_exclusive(dev, > Acked-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/4] drm/meson: dw-hdmi: Ensure that clocks are enabled before touching the TOP registers

2020-11-17 Thread Neil Armstrong
gt; return PTR_ERR(meson_dw_hdmi->hdmi); > > + meson_dw_hdmi_init(meson_dw_hdmi); > + > next_bridge = of_drm_find_bridge(pdev->dev.of_node); > if (next_bridge) > drm_bridge_attach(encoder, next_bridge, > Acked-by: Neil Armstron

Re: [PATCH 0/4] drm/meson: Module removal fixes

2020-11-17 Thread Neil Armstrong
On 17/11/2020 10:19, Marc Zyngier wrote: > Hi Neil, > > On 2020-11-17 08:49, Neil Armstrong wrote: >> Hi Marc, >> >> On 16/11/2020 21:07, Marc Zyngier wrote: >>> Hi all, >>> >>> Having recently moved over to a top-of-the-tree u-boot o

Re: next/master bisection: baseline.dmesg.emerg on meson-gxbb-p200

2020-11-19 Thread Neil Armstrong
On 19/11/2020 11:20, Marc Zyngier wrote: > On 2020-11-19 08:50, Guillaume Tucker wrote: >> Please see the automated bisection report below about some kernel >> errors on meson-gxbb-p200. >> >> Reports aren't automatically sent to the public while we're >> trialing new bisection features on kernelci

Re: next/master bisection: baseline.dmesg.emerg on meson-gxbb-p200

2020-11-20 Thread Neil Armstrong
On 19/11/2020 19:35, Marc Zyngier wrote: > On 2020-11-19 18:13, Jerome Brunet wrote: >> On Thu 19 Nov 2020 at 19:04, Guillaume Tucker >> wrote: >> >>> Hi Marc, >>> >>> On 19/11/2020 11:58, Marc Zyngier wrote: >>>> On 2020-11-19 10:26, N

Re: [PATCH 2/2] drm/meson: dw-hdmi: Enable the iahb clock early enough

2020-11-20 Thread Neil Armstrong
On 20/11/2020 12:10, Marc Zyngier wrote: > On 2020-11-20 10:54, Guillaume Tucker wrote: >> On 20/11/2020 09:42, Marc Zyngier wrote: >>> Instead of moving meson_dw_hdmi_init() around which breaks existing >>> platform, let's enable the clock meson_dw_hdmi_init() depends on. >>> This means we don't h

Re: [PATCH 1/2] drm/meson: dw-hdmi: Disable clocks on driver teardown

2020-11-20 Thread Neil Armstrong
meson_dw_hdmi->venci_clk = devm_clk_get(dev, "venci"); > - if (IS_ERR(meson_dw_hdmi->venci_clk)) { > - dev_err(dev, "Unable to get venci clk\n"); > - return PTR_ERR(meson_dw_hdmi->venci_clk); > - } > - clk_pr

  1   2   3   4   5   6   7   8   9   10   >