On 2016å¹´04æ05æ¥ 21:50, John Keeping wrote:
> The call to arm_iommu_detach_device() on the previous line sets
> dev->archdata.mapping to NULL so this call is always a no-op.
>
> Signed-off-by: John Keeping
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 -
> 1 file changed, 1 deleti
On 2016å¹´04æ05æ¥ 21:50, John Keeping wrote:
> arm_iommu_attach_device() takes its own reference to the mapping we give
> it. Since we do not keep a reference to the mapping ourselves, we must
> release it before returning.
>
> Also fix the error path, which fails to release the mapping if it h
Hi Marek
With your patches, do drm/rockchip dma-mapping rewrite, IOMMU works good
on drm/rockchip ARM64 platform.
Thanks for your patches.
On 2016å¹´02æ19æ¥ 16:22, Marek Szyprowski wrote:
> Dear All,
>
> This is an initial RFC on the unification of IOMMU-based DMA-mapping
> code for ARM and
ski
IOMMU works good on drm/rockchip ARM64 platform with this patch. So
Tested-by: Mark Yao
Thanks.
--
ï¼ark Yao
good on drm/rockchip ARM64 platform with this patch. So
Tested-by: Mark Yao
Thanks.
--
ï¼ark Yao
rtc mode_set.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 37 +++-
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 44 ++-
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c |5 +--
drivers/gpu/drm/rockchip/inno_hdmi.c|
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
Signed-off-by: Mark Yao
---
.../bindings/display/rockchip/rockchip-vop.txt |2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
b
four windows.
VOP_LIT only support two windows.
RK3399 vop register layout is similar with rk3288, so some feature
can reuse with rk3288.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 60 +
drivers/gpu/drm/rockchip/rockchip_drm_vop.h |5 +
drivers/gpu
On 2016å¹´04æ18æ¥ 17:25, John Keeping wrote:
>> >We need to take care of the vop status when use
>> >rockchip_drm_crtc_mode_config, if vop is disabled,
>> >the function would failed, that is terrible.
>> >
>> >Save connector type and output mode on drm_display_mode->private_flags
>> >at encoder
Some rockchip vop not support iommu, need use non-iommu
buffer for it. And if we get iommu issues, we can compare
the issues with non-iommu path, the would help the debug.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 65 +++
1 file changed
On 2016å¹´04æ18æ¥ 17:25, John Keeping wrote:
> On Mon, 18 Apr 2016 11:03:31 +0800, Mark Yao wrote:
>
>> >We need to take care of the vop status when use
>> >rockchip_drm_crtc_mode_config, if vop is disabled,
>> >the function would failed, that is terrible.
tform.
Cc: Marek Szyprowski
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/Kconfig|3 +-
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 81 +++
drivers/gpu/drm/rockchip/rockchip_drm_drv.h |1 +
3 files changed, 60 insertions(+), 25 deletions(-)
di
On 2016å¹´04æ19æ¥ 15:58, Heiko Stübner wrote:
> patch subject above:
> dt-bindings: add documentation for Rockchip rk3399 display controllers
>
> not everybody skimming over patches directly knows what a vop is;-)
>
> I still believe even such a trivial patch should also get some form of
> desc
On 2016å¹´04æ19æ¥ 17:06, John Keeping wrote:
> On Tue, 19 Apr 2016 10:43:03 +0800, Mark yao wrote:
>
>> On 2016å¹´04æ18æ¥ 17:25, John Keeping wrote:
>>> On Mon, 18 Apr 2016 11:03:31 +0800, Mark Yao wrote:
>>>
>>>>> We
We need to take care of the vop status when use
rockchip_drm_crtc_mode_config, if vop is disabled,
the function would failed, that is terrible.
Save output_type and output_mode into rockchip_crtc_state,
it's nice to make them into atomic.
Signed-off-by: Mark Yao
---
Changes in v2:
Advis
We need to take care of the vop status when use
rockchip_drm_crtc_mode_config, if vop is disabled,
the function would failed, that is terrible.
Save output_type and output_mode into rockchip_crtc_state,
it's nice to make them into atomic.
Signed-off-by: Mark Yao
---
Changes in v3:
-
Some rockchip vop not support iommu, need use non-iommu
buffer for it. And if we get iommu issues, we can compare
the issues with non-iommu path, the would help the debug.
Signed-off-by: Mark Yao
---
Changes in v2
Advised by Heiko Stuebner
- use more suitable message print.
drivers/gpu/drm
patches tested on rk3399 evb board.
Changes in v2:
- sort the registers and vop compatible name
- spilt VOP_REG_MASK into a single patch
- make rk3399 vop documentation more readable(Heiko Stübner)
Mark Yao (5):
drm/rockchip: sort registers define by chip's number
dt-bindings: sort Rockchi
No functional changes, sort the vop registers to make
code more readable.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 166 +--
drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 88 +++---
2 files changed, 127 insertions(+), 127
four windows.
VOP_LIT only support two windows.
RK3399 vop register layout is similar with rk3288, so some feature
can reuse with rk3288.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 15 ++-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h |4 +
drivers/gpu/drm
Signed-off-by: Mark Yao
---
.../bindings/display/rockchip/rockchip-vop.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
index
Some new vop register support mask, bit[16-31] is mask,
bit[0-15] is value, the mask is correspond to the value.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 45 ++-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h |1 +
drivers/gpu/drm
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
Signed-off-by: Mark Yao
---
.../bindings/display/rockchip/rockchip-vop.txt |5 +
1 file changed, 5 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
b
On 2016å¹´04æ21æ¥ 22:03, Dan Carpenter wrote:
> On Fri, Feb 26, 2016 at 02:26:23PM +0800, Yakir Yang wrote:
>> Dan,
>>
>> On 02/26/2016 05:30 AM, Dan Carpenter wrote:
>>> We were accidentally returning PTR_ERR(NULL) which means success when we
>>> wanted to return a negative error code.
>>>
>>>
On 2017年10月05日 20:09, Arnd Bergmann wrote:
The new driver fails to build when CONFIG_PINCTRL is disabled:
drivers/gpu/drm/rockchip/rockchip_lvds.c: In function
'rockchip_lvds_grf_config':
drivers/gpu/drm/rockchip/rockchip_lvds.c:229:39: error: dereferencing pointer
to incomplete type 'struct d
On 2017年10月09日 16:06, Sandy Huang wrote:
Some Rockchip CRTCs, like rv1108, can directly output parallel and
serial RGB data to panel or conversion chip, so we add this driver to
probe encoder and connector.
Signed-off-by: Sandy Huang
---
Changes in v3:
update for rgb-mode move to panel node.
On 2017年10月19日 01:52, Brian Norris wrote:
Hi Kristian,
On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Högsberg wrote:
We used to call drm_of_encoder_active_endpoint_id() from
rockchip_dp_drm_encoder_atomic_check() to determine the endpoint for the
active encoder. However, the encoder isn't
On 2017年10月20日 01:46, Kristian Høgsberg wrote:
On Wed, Oct 18, 2017 at 5:49 PM, Mark yao wrote:
On 2017年10月19日 01:52, Brian Norris wrote:
Hi Kristian,
On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Högsberg wrote:
We used to call drm_of_encoder_active_endpoint_id() from
On 2017年10月19日 11:48, Jeffy Chen wrote:
Remove unnecessary init code, since we would do it in the power_on()
callback.
Also move of parse code to probe().
Fixes: 9e32e16e9e98 ("drm: rockchip: dp: add rockchip platform dp driver")
Signed-off-by: Jeffy Chen
Looks good for me
Acke
On 2017年10月19日 11:48, Jeffy Chen wrote:
The rockchip_drm_psr_register() can fail, so add a sanity check for that.
Also reorder the calls in unbind() to match bind().
Signed-off-by: Jeffy Chen
Looks good for me
Acked-by: Mark Yao
Mark
___
dri
On 2017年10月19日 11:48, Jeffy Chen wrote:
Add missing pm_runtime_disable() in bind()'s error handling path.
Also cleanup encoder & connector in unbind().
Fixes: 80a9a059d4e4 ("drm/rockchip/dsi: add dw-mipi power domain support")
Signed-off-by: Jeffy Chen
Looks good for me
On 2017年10月19日 11:48, Jeffy Chen wrote:
Add missing error handling in bind().
Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Signed-off-by: Jeffy Chen
Looks good for me
Acked-by: Mark Yao
Mark
___
dri-devel ma
od for me
Acked-by: Mark Yao
Mark
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Sandy
On 2017年08月15日 08:56, Sandy Huang wrote:
This adds support for Rockchip soc lvds found on rk3288
Based on the patches from Mark yao and Heiko Stuebner
Signed-off-by: Sandy Huang
Signed-off-by: Mark yao
Signed-off-by: Heiko Stuebner
---
drivers/gpu/drm/rockchip/Kconfig
On 2017年08月23日 14:26, Sandy Huang wrote:
This patch add Document for Rockchip Soc RK3288 LVDS,
This based on the patches from Mark yao and Heiko Stuebner.
Signed-off-by: Sandy Huang
Signed-off-by: Mark yao
Signed-off-by: Heiko Stuebner
---
Looks good for me:
Reviewed-by: Mark Yao
Hi Sandy
Looks good for me, so:
Reviewed-by: Mark Yao
I'd like to apply these lvds patches tomorrow if there is no more doubts.
Best Regards
Mark
On 2017年09月02日 19:28, Sandy Huang wrote:
This adds support for Rockchip soc lvds found on rk3288
Based on the patches from Mark yao and
On 2017年09月07日 20:09, Heiko Stübner wrote:
Hi Mark,
Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao:
Looks good for me, so:
Reviewed-by: Mark Yao
I'd like to apply these lvds patches tomorrow if there is no more doubts.
Rob had some minor comments on v7 of the dt-bi
On 2017年09月08日 13:04, Heiko Stuebner wrote:
Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao:
On 2017年09月07日 20:09, Heiko Stübner wrote:
Hi Mark,
Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao:
Looks good for me, so:
Reviewed-by: Mark Yao
I'd like to
On 2017年09月08日 14:12, Mark yao wrote:
On 2017年09月08日 13:04, Heiko Stuebner wrote:
Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao:
On 2017年09月07日 20:09, Heiko Stübner wrote:
Hi Mark,
Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao:
Looks good for me, so
Change the tile to:
drm/rockchip: Replace dev_* with DRM_DEV_*
Thanks.
On 2017年09月15日 14:47, Haneen Mohammed wrote:
This patch replace instances of dev_info/err/debug with
DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted
specific log messages. Issue corrected with the help
On 2017年09月15日 16:36, Haneen Mohammed wrote:
This patch replace instances of dev_info/err/debug with
DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted
specific log messages. Issue corrected with the help of the following
Coccinelle script:
@r@
@@
(
-dev_info
+DRM_DEV_INFO
|
-d
On 2017年09月21日 06:29, Thomas Meyer wrote:
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
Looks good for me:
Acked-by: Mark Yao
diff -u -p a/drivers/gpu/drm/rockchip/rockchip
On 2017年09月21日 08:13, Sean Paul wrote:
If there are no children for lvds, ret is used uninitialized. This patch
initializes ret and returns an error if the port has no children.
Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Cc: Mark Yao
Cc: Heiko Stuebner
On 2017年09月26日 13:12, Daniel Vetter wrote:
On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote:
On 2017年09月21日 06:29, Thomas Meyer wrote:
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Th
On 2017年09月26日 15:55, Nickey Yang wrote:
Rockchip driver has been moved to using the
DRM_DEV_ERROR log messages, so change all
instances of dev_err.
Signed-off-by: Nickey Yang
Hi Nickey
Haneen Mohammed already send similar patch, and it was applied, see following
patch on drm-misc-next
On 2017年09月26日 15:55, Nickey Yang wrote:
This patch correct Feedback divider setting:
1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN
2、Due to the use of a "by 2 pre-scaler," the range of the
feedback multiplication Feedback divider is limited to even
division numbers, and Feedback divider must
-misc-next, these patches would conflict to
current drm-misc-next branch.
And please see my comment inline.
Mark Yao
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 390
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 +
drivers/gpu/drm/rockchip
On 2017年07月14日 04:29, Sean Paul wrote:
On Thu, Jul 13, 2017 at 09:33:45AM +0800, Mark yao wrote:
On 2017年07月13日 00:47, Sean Paul wrote:
On Wed, Jul 12, 2017 at 10:03:27AM +0800, Mark Yao wrote:
Register init table use un-document define, it is unreadable,
And sometimes we only want to update
alize registers directly, and drops
init_table mechanism out.
Changes in v3:
- Explain more in details
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++--
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 10 ++-
drivers/gpu/drm/rockchip/rockchip_vop_reg.c
abnormal
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
- correct some vop registers define
Mark Yao (7):
drm/rockchip: vop: initialize registers directly
drm/rockchip: vop: move write_relaxed flags to vop register
drm/rockchip: vop: move line_flag_num to interrupt registers
drm
Grouping the vop registers facilitates make register
definition clearer, and also is useful for different vop
reuse the same group register.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h
patch
Signed-off-by: Mark Yao
Reviewed-by: Sean Paul
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++--
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm
then old one.
Changes in v3:
- fixup some mistake
- use separate structures instead VOP_REG_VER mechanism
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
- correct some vop registers define
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 9 +
drivers/gpu/drm
bit[7:4] win_rid_win0_cbr
axi read id of win0 cbr channel
bit[3:0] win_rid_win0_yrgb
axi read id of win0 yrgb channel
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 +
drivers/gpu/drm/rockchip/rockchip
flags to vop registers,
then can only do synchronize write for those actual needed register.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 +++---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 42 -
2 files changed, 28 insertions
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
Signed-off-by: Mark Yao
---
Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4
1 file changed, 4 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
b/Documentation
bit[7:4] win_rid_win0_cbr
axi read id of win0 cbr channel
bit[3:0] win_rid_win0_yrgb
axi read id of win0 yrgb channel
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 +
drivers/gpu/drm/rockchip/rockchip
flags to vop registers,
then can only do synchronize write for those actual needed register.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 +++---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 42 -
2 files changed, 28 insertions
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
Signed-off-by: Mark Yao
---
Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4
1 file changed, 4 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
b/Documentation
then old one.
Changes in v3:
- fixup some mistake
- use separate structures instead VOP_REG_VER mechanism
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
- correct some vop registers define
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 9 +
drivers/gpu/drm
alize registers directly, and drops
init_table mechanism out.
Changes in v3:
- Explain more in details
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++--
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 10 ++-
drivers/gpu/drm/rockchip/rockchip_vop_reg.c
Grouping the vop registers facilitates make register
definition clearer, and also is useful for different vop
reuse the same group register.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h
patch
Signed-off-by: Mark Yao
Reviewed-by: Sean Paul
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++--
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm
registers
- Explain more on patch commit message
- fix rk3328 overlay abnormal
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
- correct some vop registers define
Mark Yao (7):
drm/rockchip: vop: initialize registers directly
drm/rockchip: vop: move write_relaxed flags to vop register
drm
Sorry for sending this mail without thread, my send-patches scripts has a
bug:-( , Already fix the script bug.
On 2017年07月19日 10:57, Mark Yao wrote:
These patches try to make all current rockchip full framework vop works
on drm, fill missing vop on full framework.
Vop Full framework now has
On 2017年07月18日 01:24, Rob Herring wrote:
On Wed, Jul 12, 2017 at 10:04:02AM +0800, Mark Yao wrote:
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
This goes below '---' and you need a commit msg here. Also, it is not
clear in the subject this is for Rockchip.
Got it, will
flags to vop registers,
then can only do synchronize write for those actual needed register.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 +++---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 42 -
2 files changed, 28 insertions
Grouping the vop registers facilitates make register
definition clearer, and also is useful for different vop
reuse the same group register.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h
:
- group vop register instead using VOP_REG_VER mechanism
- Explain more on patch commit message
- move write_relaxed flags to vop registers
- fix rk3328 overlay abnormal
Changes in v2:
- rename rk322x to rk3228
- correct some vop registers define
Mark Yao (7):
drm/rockchip: vop: initialize
alize registers directly, and drops
init_table mechanism out.
Changes in v3:
- Explain more in details
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++--
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 10 ++-
drivers/gpu/drm/rockchip/rockchip_vop_reg.c
patch
Signed-off-by: Mark Yao
Reviewed-by: Sean Paul
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++--
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm
then old one.
Changes in v3:
- fixup some mistake
- use separate structures instead VOP_REG_VER mechanism
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
- correct some vop registers define
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 9 +
drivers/gpu/drm
bit[7:4] win_rid_win0_cbr
axi read id of win0 cbr channel
bit[3:0] win_rid_win0_yrgb
axi read id of win0 yrgb channel
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 +
drivers/gpu/drm/rockchip/rockchip
Signed-off-by: Mark Yao
---
Changes in v5:
- clean document commit title
- move changes description out of docummit commit msg
Changes in v2:
- rename rk322x to rk3228
- correct some vop registers define
Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4
1 file
On 2017年07月22日 05:12, Arnd Bergmann wrote:
A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m,
the rockchip drm driver will fail to link:
drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined refe
On 2017年07月25日 03:53, Rob Herring wrote:
On Thu, Jul 20, 2017 at 10:43:53AM +0800, Mark Yao wrote:
Signed-off-by: Mark Yao
---
Changes in v5:
- clean document commit title
- move changes description out of docummit commit msg
Changes in v2:
- rename rk322x to rk3228
- correct some vop
On 2017年07月26日 06:36, Heiko Stuebner wrote:
Hi Mark,
Am Donnerstag, 20. Juli 2017, 10:43:22 CEST schrieb Mark Yao:
At present we are using init_table to initialize some
registers, but the Register init table use un-document define,
it is unreadable, and sometimes we only want to update tiny
On 2017年07月26日 05:47, Heiko Stuebner wrote:
Hi Mark,
Am Donnerstag, 20. Juli 2017, 10:43:27 CEST schrieb Mark Yao:
Since the drm atomic framework, only a small part of the vop
register needs sync write, Currently seems only following registers
need sync write:
cfg_done, standby and
On 2017年07月26日 05:54, Heiko Stuebner wrote:
Hi Mark,
Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao:
In the hardware design process, the design of line flags
register is associated with the interrupt register,
placing the line flags in the interrupt definition is
more reasonable
alize registers directly, and drops
init_table mechanism out.
Signed-off-by: Mark Yao
---
Changes in v6:
- fix rk3036 blank display
Changes in v3:
- Explain more in details
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++--
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 10 ++-
drivers/gp
some vop registers define
Mark Yao (7):
drm/rockchip: vop: initialize registers directly
drm/rockchip: vop: move write_relaxed flags to vop register
drm/rockchip: vop: move line_flag_num to interrupt registers
drm/rockchip: vop: group vop registers
drm/rockchip: vop: add a series of vop
Signed-off-by: Mark Yao
Acked-by: Rob Herring
---
Changes in v5:
- clean document commit title
- move changes description out of docummit commit msg
Changes in v2:
- rename rk322x to rk3228
- correct some vop registers define
Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
In the hardware design process, the design of line flags
register is associated with the interrupt register,
placing the line flags in the interrupt definition is
more reasonable, and it would make multi-vop define easilier.
Signed-off-by: Mark Yao
Reviewed-by: Sean Paul
---
Changes in v6
flags to vop registers,
then can only do synchronize write for those actual needed register.
Signed-off-by: Mark Yao
---
Changes in v6:
- fix compile error
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 28 ---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 +
drivers/gpu/drm
bit[7:4] win_rid_win0_cbr
axi read id of win0 cbr channel
bit[3:0] win_rid_win0_yrgb
axi read id of win0 yrgb channel
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 +
drivers/gpu/drm/rockchip/rockchip
Grouping the vop registers facilitates make register
definition clearer, and also is useful for different vop
reuse the same group register.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 60
then old one.
Signed-off-by: Mark Yao
---
Changes in v3:
- fixup some mistake
- use separate structures instead VOP_REG_VER mechanism
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)
- correct some vop registers define
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 9 +
drivers/gpu/drm
Hi Heiko
Thanks for the test.
On 2017年07月27日 18:10, Heiko Stübner wrote:
Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner:
Hi Mark,
Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao:
Grouping the vop registers facilitates make register
definition clearer, and also
Hi Heiko
On 2017年07月28日 09:02, Mark yao wrote:
Hi Heiko
Thanks for the test.
On 2017年07月27日 18:10, Heiko Stübner wrote:
Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner:
Hi Mark,
Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao:
Grouping the vop registers
Grouping the vop registers facilitates make register
definition clearer, and also is useful for different vop
reuse the same group register.
Signed-off-by: Mark Yao
Reviewed-by: Jeffy Chen
---
Changes in v6.1
- fix Null pointer crash on vop_reg_set
drivers/gpu/drm/rockchip/rockchip_drm_vop.c
Hi
Pushed to drm-misc-next.
Thanks Sean Paul, Jeffy Chen's review, Heiko's test and Rob's ack.
Best regards.
On 2017年07月26日 14:18, Mark Yao wrote:
These patches try to make all current rockchip full framework vop works
on drm, fill missing vop on full framework.
Vop Full fr
Since atomic framework, crtc enable and disable are in pairs,
no need to wait vblank.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 36 -
1 file changed, 36 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers
The user would be confused while facing a error commit without
any error report.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip
fixup the scale calculation formula on the case
src_height == (dst_height/2).
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h
b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h
Here are some fixes port from rockchip_linux project[0],
Tested on rk3399 and rk3288 board.
[0]: https://github.com/rockchip-linux/kernel
Mark Yao (6):
drm/rockchip: vop: no need wait vblank on crtc enable
drm/rockchip: vop: fix iommu page fault when resume
drm/rockchip: vop: fix NV12
0.756316] [] ret_from_fork+0x10/0x40
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index 81f9548..e6bd0f4 100644
--- a
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33 +
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 0bfd563..0b5fd75 100644
---
) + (win0_vir_width%3)
RGB565 : ceil(win0_vir_width/2)
YUV : ceil(win0_vir_width/4)
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip
On 2017年07月31日 20:28, Daniel Vetter wrote:
On Mon, Jul 31, 2017 at 1:57 PM, Emil Velikov wrote:
On 31 July 2017 at 10:50, Mark Yao wrote:
Since fb_helper is not a pointer on rockchip_drm_private, it's no
need to check pointer.
Kms hotplug event may race into fbdev helper initial
xf0
[0.756316] [] ret_from_fork+0x10/0x40
[0]: https://01.org/linuxgraphics/gfx-docs/drm/gpu/drm-kms-helpers.html
Signed-off-by: Mark Yao
---
Changes in v1.1:
- According to the kerneldoc, fix the race bug in generic way.
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 13 ++---
1 f
301 - 400 of 597 matches
Mail list logo
