[PATCH v3] drm/rockchip: support non-iommu buffer path

Some rockchip vop not support iommu, need use non-iommu buffer for it. And if we get iommu issues, we can compare the issues with non-iommu path, the would help the debug. Signed-off-by: Mark Yao --- Changes in v3 - fix conflict with other iommu patch. Changes in v2 Advised by Heiko Stuebner

[PATCH] drm/rockchip: vop: fix iommu crash with async atomic

hardware. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 28596e7..38c4de9 100644 --- a/drivers/gpu/drm

[PATCH] drm/rockchip: vop: Initialize vskiplines to zero

There is a path that use vskiplines with non-initialize. That would cause vop abnormal behavior. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu

[PATCH v2] drm/rockchip: vop: fix iommu crash with async atomic

actually swap out from vop hardware. Signed-off-by: Mark Yao --- Changes in v2: - fix some format problem. drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip

[PATCH] drm/rockchip: fix fbdev crash when not use DRM_FBDEV_EMULATION

[1.172204] [] drm_kms_helper_hotplug_event+0x28/0x34 [1.172207] [] output_poll_execute+0x150/0x198 [1.172212] [] process_one_work+0x218/0x3dc [1.172215] [] worker_thread+0x24c/0x374 [1.172217] [] kthread+0xdc/0xe4 [1.17] [] ret_from_fork+0x10/0x40 Signed-off-by: Mark Yao

[PATCH] drm/rockchip: fix fbdev crash when not use DRM_FBDEV_EMULATION

On 2016年08月03日 16:46, Daniel Vetter wrote: > On Wed, Aug 03, 2016 at 10:43:21AM +0200, Daniel Vetter wrote: >> On Wed, Aug 03, 2016 at 04:13:45PM +0800, Mark Yao wrote: >>> [1.162571] Unable to handle kernel NULL pointer dereference at virtual >>> address

[PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

Hi Yakir After apply your patch, I got following warning messge: drivers/gpu/drm/rockchip/inno_hdmi.c:818:2: warning: initialization from incompatible pointer type [enabled by default] drivers/gpu/drm/rockchip/inno_hdmi.c:818:2: warning: (near initialization for 'audio_codec_ops.hw_params') [en

[PATCH v1] drm/rockchip: fix fbdev crash when not use DRM_FBDEV_EMULATION

[1.172204] [] drm_kms_helper_hotplug_event+0x28/0x34 [1.172207] [] output_poll_execute+0x150/0x198 [1.172212] [] process_one_work+0x218/0x3dc [1.172215] [] worker_thread+0x24c/0x374 [1.172217] [] kthread+0xdc/0xe4 [1.17] [] ret_from_fork+0x10/0x40 Signed-off-by: Mark Yao

[PATCH] drm/rockchip: Properly adjust to a true clock in adjusted_mode

On 2016年08月09日 03:29, Sean Paul wrote: > From: Douglas Anderson > > When fixing up the clock in vop_crtc_mode_fixup() we're not doing it > quite correctly. Specifically if we've got the true clock 26667 Hz, > we'll perform this calculation: > 26667 / 1000 => 26 > > Later whe

[PATCH] drm/bridge: dw-hdmi: fix hdmi display lost

Cc: Liu Ying Signed-off-by: Mark Yao --- drivers/gpu/drm/bridge/dw-hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c index 77ab473..a4fcb47 100644 --- a/drivers/gpu/drm/bridge/dw-hdmi.c +++ b/dri

[PATCH] drm/bridge: dw-hdmi: fix hdmi display lost

An HTML attachment was scrubbed... URL:

[PATCH] drm/bridge: dw-hdmi: fix hdmi display lost

An HTML attachment was scrubbed... URL:

[v10.1 PATCH 5/5] drm/rockchip: cdn-dp: add cdn DP support for rk3399

pin_pol of vop must not be invert for DP. > > Signed-off-by: Chris Zhong > Reviewed-by: Sean Paul > Acked-by: Mark Yao > > --- > > Changes in v10.1: > - support read sink count from DPCD > > Changes in v10: > - control the grf_clk in DP > > Chan

[PATCH 2/2] drm/rockchip: Use DRM_DEV_ERROR in vop

On 2016年08月13日 01:00, Sean Paul wrote: > Since we can have multiple vops, use DRM_DEV_ERROR to > make logs easier to process. > > Signed-off-by: Sean Paul looks good for me Acked-by: Mark Yao > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 24 ++---

[PATCH v3 1/5] drm/rockchip: sort registers define by chip's number

Hi Sean Thanks for send v3 patch for rk3399 vop support. But sorry for that, I had changed my mind, those patches are deprecated, I have new rk3399 patch on my downstream kernel, I will upstream soon. Thanks. On 2016年08月18日 01:20, Sean Paul wrote: > From: Mark Yao > > No f

[PATCH v3 1/5] drm/rockchip: sort registers define by chip's number

On 2016年08月18日 17:11, Daniel Vetter wrote: > On Thu, Aug 18, 2016 at 05:08:14PM +0800, Mark yao wrote: >> >Hi Sean >> > >> >Thanks for send v3 patch for rk3399 vop support. >> > >> >But sorry for that, I had changed my mind, those patches a

[PATCH v3 1/5] drm/rockchip: sort registers define by chip's number

On 2016年08月23日 04:30, Sean Paul wrote: > On Thu, Aug 18, 2016 at 6:02 AM, Mark yao wrote: >> On 2016年08月18日 17:11, Daniel Vetter wrote: >>> On Thu, Aug 18, 2016 at 05:08:14PM +0800, Mark yao wrote: >>>>> Hi Sean >>>>> >&

[PATCH] drm/bridge: analogix: protect power when get_modes or detect

0x44/0xdc [] drm_helper_probe_single_connector_modes_merge_bits+0xe8/0x41c [] drm_helper_probe_single_connector_modes+0x10/0x18 [] drm_mode_getconnector+0xf4/0x304 [] drm_ioctl+0x23c/0x390 [] do_vfs_ioctl+0x4b8/0x58c [] SyS_ioctl+0x60/0x88 Cc: Inki Dae Cc: Sean Paul Cc: Gustavo Padovan Cc: "Ville Syrjälä" Sign

Question: Re: [PATCH] drm/bridge: analogix: protect power when get_modes or detect

An HTML attachment was scrubbed... URL:

[PATCH v2] drm/bridge: analogix: protect power when get_modes or detect

0x44/0xdc [] drm_helper_probe_single_connector_modes_merge_bits+0xe8/0x41c [] drm_helper_probe_single_connector_modes+0x10/0x18 [] drm_mode_getconnector+0xf4/0x304 [] drm_ioctl+0x23c/0x390 [] do_vfs_ioctl+0x4b8/0x58c [] SyS_ioctl+0x60/0x88 Cc: Inki Dae Cc: Sean Paul Cc: Gustavo Padovan Cc: "Ville Syrjälä" Sign

Question: Re: [PATCH] drm/bridge: analogix: protect power when get_modes or detect

On 2016年10月12日 22:51, Sean Paul wrote: > On Wed, Oct 12, 2016 at 6:22 AM, Mark yao wrote: >> I'm not familiar with the analogix driver, maybe use a power reference count >> would better then direct power on/off analogix_dp. >> >> Does anyone has the idea

rockchip: drm: analogix_dp-rockchip would stock the kernel

On 2016年10月16日 02:03, ayaka wrote: > Hello: >I meet a problem with eDP in rk3288 with the linux next 20161006, > it is just like the early stage of 4.4 > kernel. I have added a eDP panel entry in the firefly reload board, > once the kernel loaded analogix_dp-rockchip.ko, after printed

About the Xserver for rockchip

On 2016年10月17日 15:12, Heiko Stuebner wrote: > Am Montag, 17. Oktober 2016, 14:45:30 CEST schrieb Randy Li: >> Hello Tomasz: >>Heiko told me you are in charge of the graphics part of chromium, I >> think I had better told you the developing status of the xorg xserver in >> rockchip. > What

Re: [PATCH] drm/rockchip: Set line flag config register in vop_crtc_enable

me: Acked-by: Mark Yao --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 ++-- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 +-- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 20 +--- 3 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drive

[PATCH 1/2] drm/rockchip: support mode_valid for crtc

drm crtc already has mode_fixup callback to can do mode check, but We actually want to valid display mode on connector getmode time, mode_fixup can't do it. So add a private mode_valid callback to rockchip crtc, connectors can check mode with this mode_valid callback. Signed-off-by: Mar

[PATCH 2/2] drm/rockchip: dw_hdmi: check display mode with crtc mode valid

Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 47 +++-- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index a6d4a02..64408bc 100644

Re: [PATCH v3 3/5] drm/rockchip/dsi: remove mode_valid function

ese 2 value come from rockchip_drm_mode_config_init, currently, they are both 4096. So you are right, drm driver does not distinguish between vop lit and big. I think Mark Yao already have a local solution, and he will post it soon. Hi See follow patches, support mode valid with vop callback. [0] https://patch

[GIT PULL] drm/rockchip: add cdn-dp support and some fixes

Hi Dave drm/rockchip cdn-dp driver is v17 now, I think it's ready to land it. Thanks. The following changes since commit 99743ae4c5f52f8f8ceb17783056fcc9b4f8b64c: Merge branch 'drm-etnaviv-next' of https://git.pengutronix.de/git/lst/linux into drm-next (2017-02-03 05:41:58 +1000) are ava

Re: [PATCH v17 0/7] drm/rockchip: Add CDN DP driver

Hi Chris Applied to my drm-next and already sent pull request to Dave. Thanks. On 2017年02月05日 15:54, Chris Zhong wrote: This series adds support for the CDN DP controller to the rockchip drm driver. This version fixes some coding style error in v16, it post by Sean Paul, you can find it here:

[PATCH] drm/rockchip: cdn-dp: fix cdn-dp complie warning

fix warning: drivers/gpu/drm/rockchip/cdn-dp-reg.c:632:24: warning: 'val[1]' may be used uninitialized in this function [-Wmaybe-uninitialized] msa_misc = 2 * val[0] + 32 * val[1] + Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 +- 1 file changed, 1 inser

Re: [GIT PULL] drm/rockchip: add cdn-dp support and some fixes

On 2017年02月07日 09:05, Dave Airlie wrote: On 5 February 2017 at 18:40, Mark yao wrote: Hi Dave drm/rockchip cdn-dp driver is v17 now, I think it's ready to land it. Thanks. The following changes since commit 99743ae4c5f52f8f8ceb17783056fcc9b4f8b64c: Merge branch 'drm-etnavi

[PATCH 0/4] drm/rockchip: switch to drm_mm for support arm64 iommu

arm-kernel/msg513781.html [1]: https://patchwork.kernel.org/patch/9196367 [2]: https://patchwork.kernel.org/patch/9196369 Mark Yao (2): drm/rockchip: gem: add mutex lock for drm mm drm/rockchip: gem: fixup iommu_map_sg error path Shunqian Zheng (1): drm/rockchip: Use common IOMMU API to atta

[PATCH 1/4] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

Zheng Acked-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 4 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 217 ++-- drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 8 + 3 files changed, 219 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 3/4] drm/rockchip: gem: add mutex lock for drm mm

naked+0x24/0x28 Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891 Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 + drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 9 + 3 files changed, 12 insertions(+)

[PATCH 2/4] drm/rockchip: Use common IOMMU API to attach devices

anymore and this patch wires things to use the new method. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa Acked-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 +++- 1 file changed, 53 insertions(+), 47 deletions(-) diff --git a/drivers/gpu

[PATCH 4/4] drm/rockchip: gem: fixup iommu_map_sg error path

14 Change-Id: Id79c052691270553c1c60086f9926f39a5296354 Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 8d27965..c

Re: [PATCH 1/4] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

On 2017年02月07日 14:53, Tomasz Figa wrote: Hi Mark, Thanks for reviving this series and sorry for not taking care of it myself. Please see some comments inline. Hi Tomasz Thanks for review, I will add the patches you mentioned into v2 version. On Tue, Feb 7, 2017 at 3:09 PM, Mark Yao

[PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu

arm-kernel/msg513781.html [1]: https://patchwork.kernel.org/patch/9196367 [2]: https://patchwork.kernel.org/patch/9196369 Changes in v2: Advices by Tomasz: add some fixes patches from chromeos project. Mark Yao (2): drm/rockchip: gem: add mutex lock for drm mm drm/rockchip: gem: fixup io

[PATCH v2 1/7] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

Zheng Acked-by: Mark Yao Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 4 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 217 ++-- drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 8 + 3 files changed, 219 insertions(+), 10 deletions(-) diff

[PATCH v2 4/7] drm/rockchip: gem: fixup iommu_map_sg error path

14 Change-Id: Id79c052691270553c1c60086f9926f39a5296354 Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 8d27965..c

[PATCH v2 2/7] drm/rockchip: Use common IOMMU API to attach devices

anymore and this patch wires things to use the new method. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa Acked-by: Mark Yao Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 +++- 1 file changed, 53 insertions(+), 47 deletions

[PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm

naked+0x24/0x28 Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891 Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 + drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 9 + 3 files changed, 12 insertions(+)

[PATCH v2 5/7] drm/rockchip: Fix the call to drm_gem_put_pages()

tool --set --percent=0 && sleep 8 && backlight_dbus_tool --set --percent=100 && sleep 3 ; done Signed-off-by: Tomasz Figa Signed-off-by: Mark Yao Reviewed-on: https://chromium-review.googlesource.com/382934 Reviewed-by: Daniel Kurtz --- drivers/gpu/drm/rockchip/rockchip_d

[PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base

PI if attached to IOMMU domain") TEST=while true; do backlight_dbus_tool --set --percent=0 && sleep 8 && backlight_dbus_tool --set --percent=100 && sleep 3 ; done Signed-off-by: Tomasz Figa Signed-off-by: Mark Yao Reviewed-on: https://chromium-review.googlesour

[PATCH v2 6/7] drm/rockchip: Respect page offset in IOMMU mmap

=graphics_GLBench Signed-off-by: rjan Eide Signed-off-by: Tomasz Figa Signed-off-by: Mark Yao Reviewed-on: https://chromium-review.googlesource.com/386477 Reviewed-by: Daniel Kurtz --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

Re: [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm

On 2017年02月07日 20:19, Thierry Reding wrote: On Tue, Feb 07, 2017 at 04:35:38PM +0800, Mark Yao wrote: drm_mm_insert_node_generic and drm_mm_remove_node may access same resource with list ops, it's not threads safe, so protect this context with mutex lock. Fix bug: [49451.8

Re: [PATCH 1/2] drm/rockchip: support mode_valid for crtc

On 2017年02月08日 00:14, Sean Paul wrote: On Sun, Feb 05, 2017 at 03:36:36PM +0800, Mark Yao wrote: drm crtc already has mode_fixup callback to can do mode check, but We actually want to valid display mode on connector getmode time, mode_fixup can't do it. So add a private mode_valid callba

Re: [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu

On 2017年02月07日 20:38, Thierry Reding wrote: On Tue, Feb 07, 2017 at 04:35:35PM +0800, Mark Yao wrote: Some iommu patches on the series[0] "iommu/rockchip: Fix bugs and enable on ARM64" already landed, So drm/rockchip related patches [1] and [2] ready to landed, this series just reba

[PATCH v3 1/2] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

Zheng Signed-off-by: Mark Yao Signed-off-by: rjan Eide Tested-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 6 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 244 ++-- drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 8 + 3 files changed, 244

[PATCH v3 0/2] drm/rockchip: switch to drm_mm for support arm64 iommu

Some iommu patches on the series[0] "iommu/rockchip: Fix bugs and enable on ARM64" already landed, So drm/rockchip related patches [1] and [2] ready to landed, this series just rebase them to lastest drm-next. Thanks Heiko's Tested-by on rk3288 and rk3399 platform. Changes in v3: Advices by Tomas

[PATCH v3 2/2] drm/rockchip: Use common IOMMU API to attach devices

anymore and this patch wires things to use the new method. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa Signed-off-by: Mark Yao Tested-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 101 +++- 1 file changed, 54 insertions(+), 47

Re: [PATCH] drm/rockchip: add extcon dependency for DP

On 2017年02月15日 05:31, Arnd Bergmann wrote: The newly added DP driver links against the extcon core, which fails when extcon is a module and this driver is not: drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined

[GIT PULL] drm/rockchip: convert to drm_mm

Hi Dave After convert to drm_mm, rockchip arm64 platform can works with iommu, like rk3399. it's import patches for rockchip arm64 platform And these patches already have full reviewed, I hope these patches can be landed.   Best regards Th

Re: [PATCH] drm/rockchip: cdn-dp: Fix error handling

On 2017年02月20日 00:59, Christophe JAILLET wrote: It is likely that both 'clk_disable_unprepare()' should be called if 'pm_runtime_get_sync()' fails. Add a new label for that, because 'err_set_rate' is not meaningful in this case. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support fo

Re: [PATCH] drm/rockchip: cdn-dp: Fix error handling

On 2017年02月20日 14:41, Christophe JAILLET wrote: Le 20/02/2017 à 02:40, Mark yao a écrit : On 2017年02月20日 00:59, Christophe JAILLET wrote: It is likely that both 'clk_disable_unprepare()' should be called if 'pm_runtime_get_sync()' fails. Add a new label for that, because &

Re: [PATCH v2] drm/rockchip: cdn-dp: Fix error handling

untime_put()'. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Signed-off-by: Christophe JAILLET looks good for me Reviewed-by: Mark Yao --- V2: rename label add missing call to 'pm_runtime_put_sync()' in error path --- driver

[PATCH] drm/rockchip: vop: no need wait vblank on crtc enable

Since atomic framework, crtc enable and disable are in pairs, no need to wait vblank. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 36 - 1 file changed, 36 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers

[PATCH 2/2] drm/rockchip: vop: verify pixelclock for hdmi and displayport

Hdmi or DisplayPort request a accurate clock, reject the display mode if clock is not good. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b

[PATCH 1/2] drm/rockchip: vop: verify display mode with vop max_output

Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 7 +++ drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 13 + 3 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/rockchip

[GIT PULL] drm/rockchip: some fixes

drm/rockchip: add extcon dependency for DP Christophe Jaillet (1): drm/rockchip: cdn-dp: Fix error handling Mark Yao (3): drm/rockchip: vop: no need wait vblank on crtc enable drm/rockchip: vop: verify display mode with vop max_output drm/rockchip: vop: verify pixe

Re: [GIT PULL] drm/rockchip: some fixes

On 2017年02月23日 00:09, Sean Paul wrote: On Tue, Feb 21, 2017 at 7:54 PM, Mark yao wrote: Hi Dave Some fixes, looks good to me. Hi Mark, As we discussed, rockchip patches should now go through -misc. Since 4.10 is already released, I'll push these through over there. Sean Hi Sean Rig

Re: [GIT PULL] drm/rockchip: some fixes

On 2017年02月24日 02:01, Sean Paul wrote: On Thu, Feb 23, 2017 at 10:03:23AM +0800, Mark yao wrote: On 2017年02月23日 00:09, Sean Paul wrote: On Tue, Feb 21, 2017 at 7:54 PM, Mark yao wrote: Hi Dave Some fixes, looks good to me. Hi Mark, As we discussed, rockchip patches should now go through

Re: [GIT PULL] drm/rockchip: convert to drm_mm

On 2017年02月27日 04:45, Daniel Vetter wrote: On Thu, Feb 16, 2017 at 11:02:31AM +0800, Mark yao wrote: Hi Dave After convert to drm_mm, rockchip arm64 platform can works with iommu, like rk3399. it's import patches for rockchip arm64 platform And these patches already have full reviewed, I

Re: [PATCH v4 00/23] drm/rockchip: MIPI fixes & improvements

and I can't easily test it. It's on the list if anyone wants to pick it up in the future. Version 3 was posted here: http://www.spinics.net/lists/dri-devel/msg130977.html Thanks to Sean Paul and Chris Zhong for their review and testing of this series. Looks good to me. Acked-by: Ma

Re: [RFC][PATCH 1/2] drm/probe-helper: Add mode_valid check to drm_crtc_helper_funcs

On 2017年02月15日 04:32, Daniel Stone wrote: Hi John, On 14 February 2017 at 19:25, John Stultz wrote: +static enum drm_mode_status +drm_connector_check_crtc_modes(struct drm_connector *connector, + struct drm_display_mode

[PATCH] drm/rockchip: return ERR_PTR instead of NULL

On 2016年11月11日 05:10, Julia Lawall wrote: > rockchip_drm_framebuffer_init is only used in one case, in > rockchip_drm_fbdev.c, where its return value is tested using IS_ERR. To > enable propagating the reason for the error, change the definition so that > it returns an ERR_PTR value. > > Pro

[PATCH v3 2/3] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

Yang Signed-off-by: Mark Yao --- Changes in v3: none Changes in v2: describe vpll on Documentation. .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 2 +- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 25 +- 2 files changed, 25 insertions(+), 2 deletions(-) diff

[PATCH v3 0/3] Add RK3399 HDMI Support

uptream, reuse hdmi_phy_configure_dwc_hdmi_3d_tx Mark Yao (3): drm/rockchip: dw_hdmi: add RK3399 HDMI support drm/rockchip: dw_hdmi: introduce the VPLL clock setting drm/rockchip: dw_hdmi: introduce the pclk for grf .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 6 +- drivers/gpu/drm/rockchip/dw_

[PATCH v3 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. Signed-off-by: Yakir Yang Signed-off-by: Mark Yao --- Changes in v3: remove hdmi_phy_configure_dwc_hdmi_3d_tx callbak. Changes in v2: reuse hdmi_phy_configure_dwc_hdmi_3d_tx for phy

[PATCH v3 3/3] drm/rockchip: dw_hdmi: introduce the pclk for grf

For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, so it's better to introduce an optional grf clock in driver. Signed-off-by: Yakir Yang Signed-off-by: Mark Yao --- Changes in v3: no

Re: [PATCH 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures

On 2017年06月20日 21:07, Bhumika Goyal wrote: Add const to drm_encoder_helper_funcs structures as they are only passed as an argument to the function drm_encoder_helper_add and this argument is of type const. So, add const to these structures. Also, fix line over 80 characters warning while adding c

Re: [PATCH v2 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures

the line exceed over 80 characters while adding const. Acked-by: Mark Yao Thanks -- Ｍark Yao ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. Signed-off-by: Yakir Yang Signed-off-by: Mark Yao --- Changes in v3.1: Correct documentation compatible's format(Rob Herring). Changes in v3: remove hdmi_phy_configure_dwc_hdmi_3d_tx ca

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

On 2017年06月22日 15:31, Heiko Stuebner wrote: + >+/** >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips >+ * @lcdsel_grf_reg: grf register offset of lcdc select >+ * @lcdsel_big: reg value of selecting vop big for HDMI >+ * @lcdsel_lit: reg value of selecting vop little

Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

m not familiar with hdmi, but hdmi display actually works for us. And, I had tried the 4.12-rc1 kernel with your patch, display works good. So: Tested-by: Mark Yao On 2017年06月13日 22:11, Jose Abreu wrote: Hi Laurent, Sorry for the late reply! On 10-06-2017 09:50, Laurent Pinchart wrote: Hi Jose

Re: [PATCH v3 0/3] Add RK3399 HDMI Support

Thanks for Heiko's review and Rob's Ack. Seems no more confuse, pushed to drm-misc-next. Thanks. On 2017年06月09日 15:10, Mark Yao wrote: RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure, and an external VPLL clock need to configure

Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

avo A. R. Silva Thanks for the fix, Acked-by: Mark Yao --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index 14fa1f8..9b0b058 100644 --- a/driv

Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

On 2017年07月11日 03:04, Sean Paul wrote: On Fri, Jul 07, 2017 at 08:56:28AM +0800, Mark yao wrote: On 2017年07月07日 05:58, Gustavo A. R. Silva wrote: The right variable to check here is port, not dp. This issue was detected using Coccinelle and the following semantic patch: @@ expression x

[PATCH 1/5] drm/rockchip: vop: get rid of register init table

Register init table use un-document define, it is unreadable, And sometimes we only want to update tiny bits, init table method is not friendly, it's diffcult to reuse for difference chips. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++-- drivers/gp

[PATCH 0/5] drm/rockchip: add all full framework vop support

for the vops from register table. Mark Yao (5): drm/rockchip: vop: get rid of register init table drm/rockchip: vop: support verify registers with vop version drm/rockchip: vop: move line_flag_num to interrupt registers drm/rockchip: vop: add a series of vop support dt-bindings: display

[PATCH 2/5] drm/rockchip: vop: support verify registers with vop version

Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 66 + drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 18 ++-- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 20 ++--- 3 files changed, 77 insertions(+), 27 deletions(-) diff --git a

[PATCH 5/5] dt-bindings: display: fill Documents for series of vop

Signed-off-by: Mark Yao --- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt

[PATCH 3/5] drm/rockchip: vop: move line_flag_num to interrupt registers

Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rockchip

[PATCH 4/5] drm/rockchip: vop: add a series of vop support

then old one. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 198 -- drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 905 ++-- 2 files changed, 859 insertions(+), 244 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b

Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop

On 2017年07月11日 20:45, Heiko Stübner wrote: Hi Mark, Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao: Signed-off-by: Mark Yao --- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree

[PATCH v2 0/5] drm/rockchip: add all full framework vop support

for the vops from register table. Tested on rk3399 evb board. Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define Mark Yao (5): drm/rockchip: vop: get rid of register init table drm/rockchip: vop: support verify registers with vop version drm/rockchip

[PATCH v2 1/5] drm/rockchip: vop: get rid of register init table

Register init table use un-document define, it is unreadable, And sometimes we only want to update tiny bits, init table method is not friendly, it's diffcult to reuse for difference chips. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++-- drivers/gp

[PATCH v2 3/5] drm/rockchip: vop: move line_flag_num to interrupt registers

Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rockchip

[PATCH v2 2/5] drm/rockchip: vop: support verify registers with vop version

Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 66 + drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 18 ++-- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 20 ++--- 3 files changed, 77 insertions(+), 27 deletions(-) diff --git a

[PATCH v2 4/5] drm/rockchip: vop: add a series of vop support

then old one. Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 202 +-- drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 905 ++-- 2 files changed, 863

[PATCH v2 5/5] dt-bindings: display: fill Documents for series of vop

Changes in v2: - rename rk322x to rk3228(Heiko Stübner) Signed-off-by: Mark Yao --- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation

Re: [PATCH 09/16] drm/rockchip: Use for_each_oldnew_plane_in_state in vop_crtc_atomic_flush

On 2017年07月12日 16:13, Maarten Lankhorst wrote: for_each_obj_in_state is about to be removed, so use the new atomic iterator macros. Signed-off-by: Maarten Lankhorst Cc: Mark Yao Cc: Heiko Stuebner Cc:linux-arm-ker...@lists.infradead.org Cc:linux-rockc...@lists.infradead.org Looks good for me

Re: [PATCH v2 4/5] drm/rockchip: vop: add a series of vop support

On 2017年07月13日 02:33, Sean Paul wrote: On Wed, Jul 12, 2017 at 10:03:54AM +0800, Mark Yao wrote: Vop Full framework now has following vops: IP versionchipname 3.1 rk3288 3.2 rk3368 3.4 rk3366 3.5 rk3399

Re: [PATCH v2 1/5] drm/rockchip: vop: get rid of register init table

On 2017年07月13日 00:47, Sean Paul wrote: On Wed, Jul 12, 2017 at 10:03:27AM +0800, Mark Yao wrote: Register init table use un-document define, it is unreadable, And sometimes we only want to update tiny bits, init table method is not friendly, it's diffcult to reuse for difference chips.

Re: [PATCH v2 2/5] drm/rockchip: vop: support verify registers with vop version

On 2017年07月13日 01:53, Sean Paul wrote: On Wed, Jul 12, 2017 at 10:03:38AM +0800, Mark Yao wrote: Please add a commit message describing *what* and *why* you are making the change. Got it, I will fix it at next version. Thanks. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip

Re: [PATCH v2 3/5] drm/rockchip: vop: move line_flag_num to interrupt registers

On 2017年07月13日 01:54, Sean Paul wrote: On Wed, Jul 12, 2017 at 10:03:46AM +0800, Mark Yao wrote: Again, please add commit message describing the what and why of this change. You can also add: Reviewed-by: Sean Paul Thanks for the review, will fix it at next version. Signed-off-by: Mark

Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API

v6: Remove superfluous variable Signed-off-by: Tomeu Vizoso --- looks good for me Acked-by: Mark Yao drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/

Re: [PATCH] drm/rockchip: Refactor the component match logic.

+ ret = rockchip_drm_register_drivers(); + if (ret) + return ret; + + ret = platform_driver_register(&rockchip_drm_platform_driver); + if (ret) + goto err_unreg_drivers; + + return 0; + +err_unreg_drivers: + rockchip_drm_unregister_drivers(); + return ret; +} + +static void __exit rockchip_drm_fini(v

[PATCH] drm/rockchip: Correct vop out_mode configure

on atomic_check, but encoder maybe NULL, so out_mode configure would fail, it cause edp no display. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 12 drivers/gpu/drm/rockchip/cdn-dp-core.c | 9 ++--- drivers/gpu/drm/rockchip

Re: [PATCH] drm/rockchip: gem: add the lacks lock and trivial changes

-by: Caesar Wang Looks good. Reviewed-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h b/drivers/gpu/drm

  1   2   3   4   5   6   >