dress Daniel Vetter 's comments.
Changes in v5:
Fix wrong git account.
Changes in v2:
Fix some commit messages.
Jeffy Chen (2):
drm: Unplug drm device when unregistering it
drm: Prevent release fb after cleanup drm_mode_config
drivers/gpu/drm/drm_drv.c | 19 +++
drive
drm_device_set_plug_state helper.
Changes in v6:
Reuse unplug status.
Changes in v5:
Fix wrong git account.
Changes in v2:
Fix some commit messages.
Jeffy Chen (1):
drm: Unplug drm device when unregistering it
drivers/gpu/drm/drm_drv.c | 26 ++
drivers/gpu/drm/udl/udl_drv.c
After unbinding drm, the user space may still owns the drm dev fd, and
may still be able to call drm ioctl.
We're using an unplugged state to prevent something like that, so let's
reuse it here.
Also drop drm_unplug_dev, because it would be unused after other changes.
Signed-off-by:
After unbinding drm, the user space may still owns the drm dev fd, and
may still be able to call drm ioctl.
We're using an unplugged state to prevent something like that, so let's
reuse it here.
Also drop drm_unplug_dev, because it would be unused after other changes.
Signed-off-by:
state into drm_drv.
v7: Add missing drm_dev_unref in udl_drv.
v8: Fix compiler errors after enable udl.
Signed-off-by: Jeffy Chen
---
drivers/gpu/drm/drm_drv.c | 26 ++
drivers/gpu/drm/udl/udl_drv.c | 3 ++-
include/drm/drmP.h| 6 --
include/drm
We need to set vop config done after update line flag config, it's a
new requirement for chips newer than rk3368.
Since we would only use line flag irq for vact_end, let's move it to
vop_crtc_enable.
Signed-off-by: Jeffy Chen
---
drivers/gpu/drm/rockchip/analogix_dp-rockc
We need to set vop config done after update line flag config, it's a
new requirement for chips newer than rk3368.
Since we would only use line flag irq for vact_end, let's move it to
vop_crtc_enable.
v2: Remove unused check and variables.
Signed-off-by: Jeffy Chen
---
Changes in
Remove unused check and variables after:
drm/rockchip: Set line flag config register in vop_crtc_enable
Signed-off-by: Jeffy Chen
---
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/rockchip
DRM_IOCTL_VERSION is supposed to update the name_len/date_len/desc_len
fields to user.
Fixes: 012c6741c6aa("switch compat_drm_version() to drm_ioctl_kernel()")
Signed-off-by: Jeffy Chen
---
drivers/gpu/drm/drm_ioc32.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drive
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen
---
drivers/gpu/drm/rockchip/Kconfig| 10 +-
drivers/gpu/drm
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen
---
drivers/gpu/drm/rockchip/Kconfig| 10 +-
drivers/gpu/drm
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen
Reviewed-by: Andrzej Hajda
---
Changes in v3:
Address Andrzej Hajda 's com
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen
Reviewed-by: Andrzej Hajda
---
Changes in v4:
Use platform_driver helpers to
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen
Reviewed-by: Andrzej Hajda
Acked-by: Mark Yao
---
Changes in v6:
Add Mark Yao &#
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen
Reviewed-by: Andrzej Hajda
Acked-by: Mark Yao
Tested-by: Heiko Stuebner
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen
Reviewed-by: Andrzej Hajda
Acked-by: Mark Yao
Tested-by: Heiko Stuebner
The system would crash when trying to alloc zero sized gem buffer:
[6.712435] Unable to handle kernel NULL pointer dereference at virtual
address 0010 <--ZERO_SIZE_PTR
...
[6.757502] PC is at sg_alloc_table_from_pages+0x170/0x1ec
Signed-off-by: Jeffy Chen
---
drivers/gpu/
0x28/0x158
[] drm_atomic_helper_suspend+0x5c/0xf0
Problem here is that we are duplicating the drm_atomic_state in
drm_atomic_helper_suspend(), but not unreference it in the resume path.
Fixes: 1494276000db ("drm/atomic-helper: Implement subsystem-level
suspend/resume")
Signed-off-by: Jeffy Chen
Make edp display works on chromebook kevin(at least for boot animation).
Also solve some issues i meet during the bringup.
Jeffy Chen (4):
arm64: dts: rockchip: Enable edp disaplay on kevin
backlight: pwm_bl: Add device link for pwm_bl and pwm
drm/rockchip: Fix error handling path in
esume PM callbacks.
Jeffy Chen (4):
arm64: dts: rockchip: Enable edp disaplay on kevin
backlight: pwm_bl: Add device link for pwm_bl and pwm
drm/rockchip: Fix error handling path in rockchip_dp_bind()
drm/rockchip: Add device links for master and components
Tomasz Figa (1):
drm/bridge/ana
barely
a good practice and in fact has led to many bugs in this driver.
Let's clean up this mess and change Analogix entry points to simply
accept some opaque struct pointer, adjusting their users at the same
time to avoid breaking the compilation.
Signed-off-by: Tomasz Figa
Signed-off-by:
Add missing error handling in rockchip_dp_bind().
Fixes: 9e32e16e9e98 ("drm: rockchip: dp: add rockchip platform dp driver")
Signed-off-by: Jeffy Chen
---
Changes in v2: None
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 14 --
1 file changed, 12 insertions(+), 2
When the pwm driver is unbound, the pwm_bl driver would still hold a
reference to that pwm, and crash the kernel later(if someone trying
to access that invalid pwm).
Add a device link to avoid this.
Signed-off-by: Jeffy Chen
---
Changes in v2: None
drivers/video/backlight/pwm_bl.c | 2 ++
1
Since we are trying to access components' resources in the master's
suspend/resume PM callbacks(e.g. panel), add device links to correct
the suspend/resume and shutdown ordering.
Signed-off-by: Jeffy Chen
---
Changes in v2:
Use device link to correct the suspend/resume and shutdow
shutdown ordering,
instead of converting rockchip spi's suspend/resume PM callbacks to
late suspend/resume PM callbacks.
Jeffy Chen (4):
arm64: dts: rockchip: Enable edp disaplay on kevin
drm/rockchip: Fix error handling path in rockchip_dp_bind()
pwm: Add dummy pwmchip for orphan pwms
barely
a good practice and in fact has led to many bugs in this driver.
Let's clean up this mess and change Analogix entry points to simply
accept some opaque struct pointer, adjusting their users at the same
time to avoid breaking the compilation.
Signed-off-by: Tomasz Figa
Signed-off-by:
Since we are trying to access components' resources in the master's
suspend/resume PM callbacks(e.g. panel), add device links to correct
the suspend/resume and shutdown ordering.
Signed-off-by: Jeffy Chen
---
Changes in v3: None
Changes in v2:
Use device link to correct the suspend/
Add missing error handling in rockchip_dp_bind().
Fixes: 9e32e16e9e98 ("drm: rockchip: dp: add rockchip platform dp driver")
Signed-off-by: Jeffy Chen
---
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 14 --
1 file changed, 12
link to correct the suspend/resume and shutdown ordering,
instead of converting rockchip spi's suspend/resume PM callbacks to
late suspend/resume PM callbacks.
Jeffy Chen (7):
arm64: dts: rockchip: Enable edp disaplay on kevin
drm/rockchip: analogix_dp: Fix error handling path
drm/rockchi
Add missing error handling in rockchip_dp_bind().
Fixes: 9e32e16e9e98 ("drm: rockchip: dp: add rockchip platform dp driver")
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 14
Add missing pm_runtime_disable() in bind()'s error handling path.
Also cleanup encoder & connector in unbind().
Fixes: 80a9a059d4e4 ("drm/rockchip/dsi: add dw-mipi power domain support")
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3: None
Changes in v2: Non
Add missing error handling in bind().
Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/inno_hdmi.c | 20
1 file c
barely
a good practice and in fact has led to many bugs in this driver.
Let's clean up this mess and change Analogix entry points to simply
accept some opaque struct pointer, adjusting their users at the same
time to avoid breaking the compilation.
Signed-off-by: Tomasz Figa
Signed-off-by:
Add missing clk_disable_unprepare() in bind()'s error handling path.
Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support")
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c |
Since we are trying to access components' resources in the master's
suspend/resume PM callbacks(e.g. panel), add device links to correct
the suspend/resume and shutdown ordering.
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3: None
Changes in v2:
Use device link to c
Since we are initing connector in the core driver and encoder in the
plat driver, let's clean them up in the right places.
Signed-off-by: Jeffy Chen
---
Changes in v5: None
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
drivers/gpu/drm/exynos/exynos_dp.c
practice and in fact has led to many bugs in this driver.
Let's clean up this mess and change Analogix entry points to simply
accept some opaque struct pointer, adjusting their users at the same
time to avoid breaking the compilation.
Signed-off-by: Tomasz Figa
Signed-off-by: Jeffy Chen
Review
unbind().
Add disable to unbind(), and inline clk_prepare_enable() with bind().
Jeffy Chen (9):
arm64: dts: rockchip: Enable edp disaplay on kevin
drm/rockchip: analogix_dp: Remove unnecessary init code
drm/bridge: analogix: Do not use device's drvdata
drm/bridge: analogix_dp
Add missing pm_runtime_disable() in bind()'s error handling path.
Also cleanup encoder & connector in unbind().
Fixes: 80a9a059d4e4 ("drm/rockchip/dsi: add dw-mipi power domain support")
Signed-off-by: Jeffy Chen
---
Changes in v5:
Call the destroy hook in the error ha
We inited connector in attach(), so need a detach() to cleanup.
Also fix wrong use of dw_hdmi_remove() in bind().
Signed-off-by: Jeffy Chen
---
Changes in v5: None
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers
Remove unnecessary init code, since we would do it in the power_on()
callback.
Also move of parse code to probe().
Fixes: 9e32e16e9e98 ("drm: rockchip: dp: add rockchip platform dp driver")
Signed-off-by: Jeffy Chen
---
Changes in v5: None
drivers/gpu/drm/rockchip/analogix_dp-rockc
Add missing error handling in bind().
Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Signed-off-by: Jeffy Chen
---
Changes in v5:
Call the destroy hook in the error handling path like in unbind().
Update cleanup order in unbind().
drivers/gpu/drm/rockchip/i
Let plat drivers own the drvdata, so that they could cleanup resources
in their unbind().
Signed-off-by: Jeffy Chen
---
Changes in v5: None
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 43 ++---
drivers/gpu/drm/imx/dw_hdmi-imx.c | 22 +--
drivers
Add missing clk_disable_unprepare() in bind()'s error handling path and
unbind().
Also inline clk_prepare_enable() with bind().
Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support")
Signed-off-by: Jeffy Chen
---
Changes in v5:
Add disable to unbin
hook in the error handling path like in unbind().
Update cleanup order in unbind().
Add disable to unbind(), and inline clk_prepare_enable() with bind().
Jeffy Chen (10):
arm64: dts: rockchip: Enable edp disaplay on kevin
drm/rockchip: analogix_dp: Remove unnecessary init code
drm/bridge: ana
Since we are initing connector in the core driver and encoder in the
plat driver, let's clean them up in the right places.
Signed-off-by: Jeffy Chen
Reviewed-by: Andrzej Hajda
---
Changes in v6:
Don't change order of rockchip_drm_psr_register().
Changes in v5: None
drivers/gpu/
Add missing error handling in bind().
Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Signed-off-by: Jeffy Chen
---
Changes in v6: None
Changes in v5:
Call the destroy hook in the error handling path like in unbind().
Update cleanup order in unbind().
drive
practice and in fact has led to many bugs in this driver.
Let's clean up this mess and change Analogix entry points to simply
accept some opaque struct pointer, adjusting their users at the same
time to avoid breaking the compilation.
Signed-off-by: Tomasz Figa
Signed-off-by: Jeffy Chen
Review
Remove unnecessary init code, since we would do it in the power_on()
callback.
Also move of parse code to probe().
Fixes: 9e32e16e9e98 ("drm: rockchip: dp: add rockchip platform dp driver")
Signed-off-by: Jeffy Chen
---
Changes in v6: None
Changes in v5: None
drivers/gpu/dr
We inited connector in attach(), so need a detach() to cleanup.
Also fix wrong use of dw_hdmi_remove() in bind().
Signed-off-by: Jeffy Chen
---
Changes in v6: None
Changes in v5: None
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion
The rockchip_drm_psr_register() can fail, so add a sanity check for that.
Also reorder the calls in unbind() to match bind().
Signed-off-by: Jeffy Chen
---
Changes in v6: None
Changes in v5: None
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 15 +++
1 file changed, 11
Add missing pm_runtime_disable() in bind()'s error handling path.
Also cleanup encoder & connector in unbind().
Fixes: 80a9a059d4e4 ("drm/rockchip/dsi: add dw-mipi power domain support")
Signed-off-by: Jeffy Chen
---
Changes in v6: None
Changes in v5:
Call the destro
Add missing clk_disable_unprepare() in bind()'s error handling path and
unbind().
Also inline clk_prepare_enable() with bind().
Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support")
Signed-off-by: Jeffy Chen
---
Changes in v6: None
Changes in v5:
Add disable t
Let plat drivers own the drvdata, so that they could cleanup resources
in their unbind().
Signed-off-by: Jeffy Chen
Reviewed-by: Neil Armstrong
---
Changes in v6: None
Changes in v5: None
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 43 ++---
drivers/gpu/drm/imx
Free the drm_atomic_state allocated by drm_atomic_helper_suspend().
Fixes: 5a5873830972 ("drm/rockchip: Use atomic PM helpers")
Signed-off-by: Jeffy Chen
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/dr
Currently we are calling scl_vop_cal_scale() to get vskiplines for yrgb
and cbcr. So the cbcr's vskiplines might be an unexpected value if the
second scl_vop_cal_scale() didn't update it.
Init vskiplines in scl_vop_cal_scale() to avoid that.
Signed-off-by: Jeffy Chen
---
drive
5c
[<0e17cd06>] platform_device_register_full+0x64/0x108
[<418a0882>] __dw_hdmi_probe+0xb9c/0xcc0
[<e0b720fd>] dw_hdmi_bind+0x30/0x88
[<9af347f6>] dw_hdmi_rockchip_bind+0x260/0x2e8
Signed-off-by: Jeffy Chen
---
drivers/gpu/drm/brid
101 - 157 of 157 matches
Mail list logo
