Hi YoungJun,
On 2014ë
11ì 19ì¼ 13:39, YoungJun Cho wrote:
> Hi Inki,
>
> There are 3 comments below.
>
> On 11/19/2014 12:19 PM, Inki Dae wrote:
>> This patch makes non kms drivers to be independent modules.
>> For this, it removes all register codes
2014-11-19 17:49 GMT+09:00 Andrzej Hajda :
> On 11/18/2014 04:26 PM, Inki Dae wrote:
>> This patch makes kms drivers to be independent modules.
>> For this, it removes all register codes to kms drivers
>> from exynos_drm_drv module and adds module_init/exit
>> for each
rs will be built-in kernel image.
Thanks,
Inki Dae
Inki Dae (4):
drm/exynos: make kms drivers to be independent drivers
drm/exynos: make non kms drivers to be indenpendent drivers
drm/exynos: make vidi driver to be independent driver
drm/exynos: clean up machine compatible string check
module_init/exit.
- Configure all kms drivers to be built in kernel image.
Changelog v2:
- none
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c |2 ++
drivers/gpu/drm/exynos/exynos_drm_drv.c | 43 +++---
drivers/gpu/drm/exynos/exynos_drm_drv.h
this driver can be bound independently.
Changelog v3:
- none
Changelog v2:
- none
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 12 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |9
drivers/gpu/drm/exynos/exynos_drm_vidi.c | 81
instead of -EPROBE_DEFER in case of no non kms device
registered. This case is not error.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_core.c| 164 +++
drivers/gpu/drm/exynos/exynos_drm_drv.c | 50 +---
drivers/gpu/drm/exynos/exynos_drm_drv.h
Use 'for' statemant instead of hard-coded 'if' statement.
Changelog v3:
- none
Changelog v2:
- none
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/dr
On 2014ë
11ì 20ì¼ 22:19, Andrzej Hajda wrote:
> On 11/20/2014 11:24 AM, Inki Dae wrote:
>> This patch makes kms drivers to be independent drivers.
>> For this, it removes all register codes to kms drivers
>> from exynos_drm_drv module and adds module_init/exit
>>
ing
> a deadlock in __driver_attach(). Fix this by moving the platform
> drivers registration to exynos_drm_init().
Could you re-base this patch on top of exynos-drm-next? I tried to
separate sub drivers into independent drivers but it seems that we need
more times. So I will merge your
Hi Javier,
On 2014ë
11ì 20ì¼ 23:06, Javier Martinez Canillas wrote:
> Hello Inki,
>
> On Thu, Nov 20, 2014 at 2:56 PM, Inki Dae wrote:
>>> If you try to build exynosdrm as module you will receive errors due to
>>> multiple definitions of init_module, ie
On 2014ë
11ì 20ì¼ 23:23, Andrzej Hajda wrote:
> On 11/20/2014 02:56 PM, Inki Dae wrote:
>> On 2014ë
11ì 20ì¼ 22:19, Andrzej Hajda wrote:
>>> On 11/20/2014 11:24 AM, Inki Dae wrote:
>>>> This patch makes kms drivers to be independent drivers.
>>>&g
Hi Javier,
On 2014ë
11ì 20ì¼ 23:28, Javier Martinez Canillas wrote:
> Hello Inki,
>
> On 11/20/2014 03:07 PM, Inki Dae wrote:
>> Could you re-base this patch on top of exynos-drm-next? I tried to
>> separate sub drivers into independent drivers but it seems that we nee
2014-11-21 0:26 GMT+09:00 Javier Martinez Canillas
:
> Hello Inki,
>
> On 11/20/2014 04:06 PM, Inki Dae wrote:
>>> BTW, it would be great if exynos-drm-next is pulled in linux-next. That is
>>> what most people use to test integration issues so you can catch earlier
On 2014ë
11ì 21ì¼ 08:12, Gustavo Padovan wrote:
> 2014-11-13 Inki Dae :
>
>> This patch fixes null pointer dereference issue incurred
>> when ipp driver is enabled and Exynos drm driver is closed.
>>
>> Non kms driver should register its own sub driver to setup
sad to say, it seems other maintainers leave NAK for this patch series
because this trying had failed already long time ago - they had learned such
thing didn't work well. So seems we have to keep this in only Exynos DRM.
[1] https://lwn.net/Articles/640290/
Thanks,
Inki Dae
>
2016ë
08ì 24ì¼ 20:57ì Daniel Vetter ì´(ê°) ì´ ê¸:
> On Wed, Aug 24, 2016 at 08:44:24PM +0900, Inki Dae wrote:
>> Hi,
>>
>> 2016ë
08ì 23ì¼ 18:41ì Daniel Stone ì´(ê°) ì´ ê¸:
>>> Hi,
>>>
>>> On 22 August 2016 at 16:23, Rob Cla
2016ë
08ì 25ì¼ 17:42ì Daniel Vetter ì´(ê°) ì´ ê¸:
> On Thu, Aug 25, 2016 at 05:06:55PM +0900, Inki Dae wrote:
>>
>>
>> 2016ë
08ì 24ì¼ 20:57ì Daniel Vetter ì´(ê°) ì´ ê¸:
>>> On Wed, Aug 24, 2016 at 08:44:24PM +0900, Inki Dae wrote:
>>>
2016ë
08ì 25ì¼ 21:14ì Daniel Vetter ì´(ê°) ì´ ê¸:
> On Thu, Aug 25, 2016 at 08:45:25PM +0900, Inki Dae wrote:
>>
>>
>> 2016ë
08ì 25ì¼ 17:42ì Daniel Vetter ì´(ê°) ì´ ê¸:
>>> On Thu, Aug 25, 2016 at 05:06:55PM +0900, Inki Dae wrote:
>>>
Hi Dave,
Sorry for late. Just refactoring HDMI driver by using infoframe helper
function, fixing GSC Kconfig dependency issue and including trivial
cleanups.
Please kindly let me know if there is any problem.
Thanks,
Inki Dae
The following changes since commit
ctor);
You removed above function from encoder and connector drivers.Is
removing this required?
And is this related to this patch? If not so, it seems this change
should go to another patch with the reason to remove this function
call.
Thanks,
Inki Dae
2016ë
08ì 16ì¼ 01:02ì Daniel Vetter ì´(ê°) ì´ ê¸:
> On Mon, Aug 15, 2016 at 04:42:18PM +0100, Chris Wilson wrote:
>> Rendering operations to the dma-buf are tracked implicitly via the
>> reservation_object (dmabuf->resv). This is used to allow poll() to
>> wait upon outstanding renderi
2016ë
12ì 18ì¼ 07:12ì Laurent Pinchart ì´(ê°) ì´ ê¸:
> Hello Inki,
>
> On Saturday 17 Dec 2016 09:33:31 Inki Dae wrote:
>> HI,
>>
>> Thanks for patch. Reasonable to me and go to misc excepting below one thing.
>> Please check my comment.
>&g
2015-08-13 0:54 GMT+09:00 Gustavo Padovan :
> 2015-08-12 Gustavo Padovan :
>
>> Hi Inki,
>>
>> 2015-08-11 Inki Dae :
>>
>> > On 2015ë
08ì 11ì¼ 09:38, Gustavo Padovan wrote:
>> > > Hi Inki,
>> > >
>> > > 2015-08-07 Inki
locks.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/drm_atomic.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 1066e4b..4349154 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -1230,9
NULL or not.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/drm_crtc_helper.c | 44 ++-
1 file changed, 29 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c
b/drivers/gpu/drm/drm_crtc_helper.c
index ef53475..aa1f42f 100644
--- a
mf)
>
> mutex_unlock(&dev->struct_mutex);
>
> - return convert_to_vm_err_msg(ret);
> + switch (ret) {
> + case 0:
> + case -ERESTARTSYS:
You missed -EINTR but I can modify it.
Thanks,
Inki Dae
> + return VM_FAULT_NOPAGE;
> + case -ENOMEM:
> + return VM_FAULT_OOM;
> + default:
> + return VM_FAULT_SIGBUS;
> + }
> }
>
> int exynos_drm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
>
d even in case of
not using dumb* interfaces. I.e.,
exynos_drm_gem_create_ioctl -> exynos_drm_gem_mmap
And drm_gem_create_mmap_offset checks if vma_node was already allocated
or not so this patch doesn't make sense.
Thanks,
Inki Dae
>
> Signed-off-by: Joonyoung Shim
>
e function would be called by drm_gem_vm_close
function which drops a reference of the gem object.
However, drm_gem_vm_close should be a pair with drm_gem_vm_open
function. These will be called whenever a process opens or closes the
VMA. So the reference count of the gem object had already been t
vm_area_struct *vma)
> obj = vma->vm_private_data;
> exynos_gem_obj = to_exynos_gem_obj(obj);
>
> - ret = check_gem_flags(exynos_gem_obj->flags);
> - if (ret)
> + if (exynos_gem_obj->flags & ~(EXYNOS_BO_MASK)) {
> + DRM_ERROR("invalid flags.\n");
> goto err_close_vm;
> + }
I will remove above checking as Daniel Stone commented because user
space cannot control the flag.
Thanks,
Inki Dae
>
> update_vm_cache_attr(exynos_gem_obj, vma);
>
>
's good idea to use prime helpers. However, I'm not sure of
there really is no any corner case the prime helper doesn't consider for
Vendor SoC yet. So let's have more reviews about this.
Thanks,
Inki Dae
>
> Signed-off-by: Joonyoung Shim
> ---
> drivers/gpu/drm
On 2015ë
08ì 16ì¼ 14:26, Inki Dae wrote:
> On 2015ë
07ì 28ì¼ 17:53, Joonyoung Shim wrote:
>> The dma-buf codes of exynos drm is almost same with prime helpers. A
>> difference is that consider DMA_NONE when import dma-buf, but it's wrong
>> and we don't
On 2015ë
08ì 17ì¼ 14:29, Joonyoung Shim wrote:
> On 08/16/2015 01:50 PM, Inki Dae wrote:
>> On 2015ë
07ì 28ì¼ 17:53, Joonyoung Shim wrote:
>>> Don't create a fake mmap offset in exynos_drm_gem_dumb_map_offset. If
>>> not, it will call drm_gem_create_mm
On 2015ë
08ì 17ì¼ 14:29, Joonyoung Shim wrote:
> On 08/16/2015 02:07 PM, Inki Dae wrote:
>> On 2015ë
07ì 28ì¼ 17:53, Joonyoung Shim wrote:
>>> The drm_gem_object_release() function already performs this cleanup,
>>> so there is no reason to do it explic
On 2015ë
08ì 17ì¼ 17:17, Joonyoung Shim wrote:
> On 08/17/2015 04:52 PM, Inki Dae wrote:
>> On 2015ë
08ì 17ì¼ 14:29, Joonyoung Shim wrote:
>>> On 08/16/2015 02:07 PM, Inki Dae wrote:
>>>> On 2015ë
07ì 28ì¼ 17:53, Joonyoung Shim wrote:
>>>&
From: Joonyoung Shim
This patch allows clients who want to use render node to access
rendering relevant ioctls - g2d, post processor and gem allocation.
Signed-off-by: Joonyoung Shim
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 39 +
1
epare_plane(exynos_crtc,
> + exynos_plane);
There is no any reason to use prepare_plane/cleanup_plane callback
names. How about using atomic_begin/atomic_flush callback names instead
for consistency between framework and device drivers?
Thanks
> {fimd/decon}_update_plane.
Hyungwon,
Gustavo already posted atomic_begin/flush support. However, he didn't
consider decon drivers.
Can you post only atomic_begin/flush support for decon drivers?
Thanks,
Inki Dae
>
> Signed-off-by: Hyungwon Hwang
> ---
> drivers/gpu/drm/
On 2015ë
08ì 27ì¼ 00:45, Gustavo Padovan wrote:
> Hi Inki,
>
> 2015-08-24 Inki Dae :
>
>> On 2015ë
08ì 16ì¼ 01:26, Gustavo Padovan wrote:
>>> From: Gustavo Padovan
>>>
>>> .prepare_plane() and .cleanup_plane() allows to perform extra
2015-08-27 17:31 GMT+09:00 Joonyoung Shim :
> If exynos_drm_gem_init() is failed, the result is ERR_PTR, so we should
> just return the result. If not, wrong porinter will be referenced from
> err label.
>
> Reported-by: Dan Carpenter
> Signed-off-by: Joonyoung Shim
> ---
> drivers/gpu/drm/exyno
Hi Emil,
On 2015ë
08ì 31ì¼ 20:58, Emil Velikov wrote:
> Hi all,
>
> On 18 August 2015 at 08:01, Inki Dae wrote:
>> From: Joonyoung Shim
>>
>> This patch allows clients who want to use render node to access
>> rendering relevant ioctls - g2d, post processo
On 2015ë
08ì 24ì¼ 23:13, Tobias Jakobi wrote:
> The amount of commands (regular and GEM) doesn't depend
> on the input here.
>
> Signed-off-by: Tobias Jakobi
> ---
> exynos/exynos_fimg2d.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fi
pace(ctx, 11, 2))
> + return -ENOSPC;
Above lines could be integrated with 3 and 4 patches as one patch. And
you can make other codes to other one.
Thanks,
Inki Dae
> +
> + g2d_add_cmd(ctx, DST_SELECT_REG, G2D_SELECT_MODE_BGCOLOR);
> + g2d_add_cmd(ctx, DST_COLOR_M
case G2D_OP_DISJOINT_DST:
> + case G2D_OP_CONJOINT_CLEAR:
> + case G2D_OP_CONJOINT_SRC:
> + case G2D_OP_CONJOINT_DST:
> + return 0;
Ditto, You could modify it like above.
Thanks,
Inki Dae
> + }
> +
> + return 1;
> +}
> +
> +/*
> * g2d_add_cmd - set given command and value to user side command buffer.
> *
> * @ctx: a pointer to g2d_context structure.
>
+
> + gem_space = src->select_mode == G2D_SELECT_MODE_NORMAL ? 2 : 1;
> +
> + if (g2d_check_space(ctx, 12, gem_space))
> + return -ENOSPC;
As I mentioned before, above two lines could be integrated with other
patches.
Thanks,
Inki Dae
>
>
t; + fprintf(stderr , "invalid select mode for source.\n");
> + return -EINVAL;
> + }
> +
> + if (g2d_validate_blending_op(op)) {
> + fprintf(stderr , "unsupported blending operation.\n");
> + return
0, 0, 0);
> - break;
With this, how about changing above switch and case statement to if
statement?
Thanks,
Inki Dae
> }
>
> return val.val;
>
On 2015ë
09ì 01ì¼ 03:30, Emil Velikov wrote:
> On 31 August 2015 at 13:36, Inki Dae wrote:
>> Hi Emil,
>>
>> On 2015ë
08ì 31ì¼ 20:58, Emil Velikov wrote:
>>> Hi all,
>>>
>>> On 18 August 2015 at 08:01, Inki Dae wrote:
>>>> F
On 2015ë
09ì 01ì¼ 03:53, Emil Velikov wrote:
> On 31 August 2015 at 14:25, Inki Dae wrote:
>> On 2015ë
08ì 24ì¼ 23:14, Tobias Jakobi wrote:
>>> We now validate the blending mode via g2d_validate_mode()
>>> prior to feeding it to g2d_get_blend_op().
>>&
On 2015ë
09ì 01ì¼ 04:57, Emil Velikov wrote:
> On 31 August 2015 at 20:27, Tobias Jakobi
> wrote:
>> Hello!
>>
>> Inki Dae wrote:
>>> On 2015ë
08ì 24ì¼ 23:13, Tobias Jakobi wrote:
>
>>>> +if (g2d_check_space(ctx, 7, 1))
>>>
n
>> even if we don't get too many reviewers. We better keep it around for
>> a couple of weeks in case others are swamped with unrelated work atm,
>> yet willing to take a look.
> Sure, I'm going to wait and do some pings from time to time :)
>
I had a review and loo
off-by: Andrzej Hajda
> ---
> Hi Inki,
>
> This is the patch I have promised during our discussion about
> PM callbcks in components.
Thanks for your patch. I will check it.
Thanks,
Inki Dae
>
> Regards
> Andrzej
>
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 76
Hi Javier,
2015ë
11ì 26ì¼ 22:35ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
> [adding Ajay Kumar who added the bridge support]
>
> Hello Inki,
>
> On 11/26/2015 09:47 AM, Inki Dae wrote:
>> This patch fixes wrong return type when dt binding of bridge device
>&g
-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 94f02a0..0b53045 100644
--- a/drivers/gpu/drm/exynos
-EINVAL if getting a port node failed.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 0b53045..c77fb83 100644
---
Hi Javier,
2015ë
12ì 03ì¼ 00:04ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
> Hello Inki,
>
> On 12/02/2015 08:57 AM, Inki Dae wrote:
>> This patch adds of_graph dt binding support for panel device
>> and also keeps the backward compatibility.
>>
>
&g
This patch makes it to return -EINVAL instead of -ENXIO
when getting a port or endpoint node failed.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu
It seems that below patch should be modifed for only one of two outbound nodes
- panel
and bridge - to be bound because in case of using bridge device, the bridge
driver will
bind the panel. I will fix and post it again.
Thanks,
Inki Dae
2015ë
12ì 02ì¼ 20:57ì Inki Dae ì´(ê°) ì´ ê
.
Changelog v2:
- return -EINVAL if getting a port node failed.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos
-EINVAL if getting a port node failed.
Signed-off-by: Inki Dae
Reviewed-by: Javier Martinez Canillas
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_co
es
on google.com so couldn't link it.
Thanks,
Inki Dae
[1] [PATCH 0/2] drm/exynos: dp: add of_graph dt binding for panel device
Inki Dae (3):
drm/exynos: dp: add of_graph dt binding support for panel
drm/exynos: dp: fix wrong return type
dt-bindings: exynos-dp: update ports node binding
This patch updates a ports node binding for panel.
With this, dp node can have a ports node which describes
a remote endpoint node that can be connected to panel or bridge
node.
Signed-off-by: Inki Dae
---
.../bindings/display/exynos/exynos_dp.txt | 28 ++
1 file
only reviewed and
tested patches will be merged to exynos-drm-next.
>
> On 12/03/2015 06:30 AM, Inki Dae wrote:
>> This patch adds of_graph dt binding support for panel device
>> and also keeps the backward compatibility.
>>
>> i.e.,
>> The dts file for E
Hi Javier,
2015ë
12ì 03ì¼ 22:29ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
> Hello Inki,
>
> On 12/03/2015 06:30 AM, Inki Dae wrote:
>> This patch updates a ports node binding for panel.
>>
>> With this, dp node can have a ports node which describes
>> a
Hi Rob,
2015ë
12ì 04ì¼ 08:38ì Rob Herring ì´(ê°) ì´ ê¸:
> On Thu, Dec 03, 2015 at 06:30:10PM +0900, Inki Dae wrote:
>> This patch updates a ports node binding for panel.
>>
>> With this, dp node can have a ports node which describes
>> a remote endpoint no
Hi Javier,
2015-12-04 21:38 GMT+09:00 Javier Martinez Canillas :
> Hello Inki,
>
> On 12/04/2015 06:00 AM, Inki Dae wrote:
>> Hi Javier,
>>
>> 2015ë
12ì 03ì¼ 22:55ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
>>> Hello Inki,
>>>
>>> I fo
Hi Javier,
2015-12-03 22:05 GMT+09:00 Javier Martinez Canillas :
>
> Hello Inki,
>
> On 12/02/2015 11:11 PM, Inki Dae wrote:
>> Hi Javier,
>>
>> 2015ë
12ì 03ì¼ 00:04ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
>>> Hello Inki,
>>>
>>>
and Javier.
- update description about eDP device.
Thanks,
Inki Dae
Inki Dae (3):
drm/exynos: dp: add of_graph dt binding support for panel
drm/exynos: dp: fix wrong return type
dt-bindings: exynos-dp: update ports node binding for panel
Javier Martinez Canillas (1):
ARM: dts: Use OF graph
.
Changelog v2:
- return -EINVAL if getting a port node failed.
Signed-off-by: Inki Dae
Reviewed-by: Javier Martinez Canillas
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
: Inki Dae
Reviewed-by: Javier Martinez Canillas
---
.../bindings/display/exynos/exynos_dp.txt | 41 +++---
1 file changed, 37 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
b/Documentation/devicetree/bindings
-EINVAL if getting a port node failed.
Signed-off-by: Inki Dae
Reviewed-by: Javier Martinez Canillas
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_co
LVDS chip and uses OF graph too.
Signed-off-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Reviewed-by: Inki Dae
---
arch/arm/boot/dts/exynos5800-peach-pi.dts | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5800-peach-p
This patch just removes unused variables, i and ret.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index edfd6e3
Hi Javier,
2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas :
> Hello Inki,
>
> On 12/07/2015 09:52 AM, Inki Dae wrote:
>> From: Javier Martinez Canillas
>>
>
> Thanks a lot for posting this patch.
>
>> The DT binding for the Exynos DRM Display Port (DP)
2015ë
12ì 08ì¼ 09:48ì Krzysztof Kozlowski ì´(ê°) ì´ ê¸:
> On 08.12.2015 00:36, Inki Dae wrote:
>> Hi Javier,
>>
>> 2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas > osg.samsung.com>:
>>> Hello Inki,
>>>
>>> On 12/07/201
2015ë
12ì 08ì¼ 10:47ì Krzysztof Kozlowski ì´(ê°) ì´ ê¸:
> On 08.12.2015 10:33, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 12/07/2015 09:45 PM, Krzysztof Kozlowski wrote:
>>> On 07.12.2015 21:52, Inki Dae wrote:
>>>> From:
CCing Mr. Kukjin and Krzysztof
Hi Kukjin and Krzysztof,
Below patch includes dt binding about gsc device but it'd be nice this patch to
exynos drm tree with others.
So could you give me Acked-by so that I can merge it to exynos drm tree?
Thanks,
Inki Dae
2015ë
11ì 30ì¼ 22:53ì
his patch is different from above description. I think below
patch is just cleanup,
which passes each member necessary instead of passing a drm_framebuffer object.
Thanks,
Inki Dae
>
> Signed-off-by: Marek Szyprowski
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 24
1 << ctx->pipe, type, formats,
> - ARRAY_SIZE(formats), zpos);
> + plane_config.pixel_formats = formats;
> + plane_config.num_pixel_formats = ARRAY_SIZE(formats);
> +
> + for (i = 0; i < WINDOWS_NR;
ing a connection sysfs file, vidi driver
tries modeset binding by calling drm_fb_helper_hotplug_event.
However, at this time it seems there is a case that plan->state->crtc exists
but plane->fb is NULL, which would be related to vidi driver.
I just looked into this issue roughly so we w
Second - why the ippdrv has to be printed? Is it useful for debugging?
Marek fixed just compilation warnings on ARM64 so yes it wouldn't need to print
out ippdrv address but as other cleanup patch.
Thanks,
Inki Dae
>
> Best regards,
> Krzysztof
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
Hi Dave,
2016ë
02ì 05ì¼ 13:46ì Dave Airlie ì´(ê°) ì´ ê¸:
> On 1 February 2016 at 16:42, Inki Dae wrote:
>> Hi Dave,
>>
>>Just regression fixes.
>>- Fix build warning and error without PM configuration
>>- Fix no display issue on Snow
mipi dsi.
> The bypass option can be founded from system register and the bit
> of the option is 11.
>
> Cc: Inki Dae
> Cc: Joonyoung Shim
> Cc: Seung-Woo Kim
> Signed-off-by: Chanho Park
> ---
> .../devicetree/bindings/display/exynos/samsung-fimd.txt| 2 ++
&
he
> exynos5433. For example, the exynos5422 uses sw reset like
> previous chips.
Picked it up.
Thanks,
Inki Dae
>
> Cc: Inki Dae
> Cc: Joonyoung Shim
> Cc: Seung-Woo Kim
> Signed-off-by: Chanho Park
> ---
> .../bindings/display/exynos/exynos_dsim.txt| 1 +
Hi Marek,
For all patches, picked them up.
Thanks,
Inki Dae
2016ë
02ì 03ì¼ 21:42ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> From: Joonyoung Shim
>
> Because PLAT_SAMSUNG isn't include exynos SoCs for arm64, but
> ARCH_EXYNOS can do it. And it also needs to add ARCH_S
Hi Chanho,
There was a missing one so below is my review again.
2016ë
02ì 11ì¼ 22:59ì Chanho Park ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On Thu, Feb 11, 2016 at 7:37 PM, Inki Dae wrote:
>> Hi Chanho,
>>
>> 2016ë
01ì 30ì¼ 22:58ì Chanho Park ì´(ê°) ì´
e
accessed by the module.
I could fix it easily like below but I'm not sure that it's reasonable.
+extern void arch_setup_dma_ops(struct device *dev, u64 dma_base,
+ u64 size, struct iommu_ops *iommu,
+ bool coherent)
Picked it up.
Thanks,
Inki Dae
2016ë
02ì 11ì¼ 20:25ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> Decon requires that clocks should be disabled in reverse order. Otherwise
> system hangs.
>
> Signed-off-by: Andrzej Hajda
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c
Picked it up.
Thanks,
Inki Dae
2016ë
02ì 11ì¼ 20:32ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> dma_mmap_attrs() should be called with cpu address returned by
> dma_alloc_attrs(). Existing code however passed pages array base as cpu
> address. This worked only by a pure luck on ARM arc
Hi Chanho,
2016ë
02ì 12ì¼ 16:39ì Chanho Park ì´(ê°) ì´ ê¸:
> Hi,
>
> On Fri, Feb 12, 2016 at 1:56 PM, Inki Dae wrote:
>> Hi Chanho,
>>
>> There was a missing one so below is my review again.
>>
>> 2016ë
02ì 11ì¼ 22:59ì Chanho Park ì´(ê°
== -EPROBE_DEFER) {
> + return ret;
> + } else {
WARNING: else is not generally useful after a break or return
#146: FILE: drivers/gpu/drm/exynos/exynos_dp_core.c:1208:
+ return ret;
+ } else {
How about just returning ret like
t;> duplication
>> and finally it does not allow to handle more than one device in system.
>> It seems better to embed such structures in private context of the device.
>
> Gently ping.
This patch series already is in exynos-drm-next-todo branch. I will move
it to exynos-drm-n
nally it moves device registration
>> related ifdefs to header file.
>>
>> Signed-off-by: Andrzej Hajda
>
> ping
>
Oops, this is one of them I missed. Sorry for this. Can you rebase this
patch on top of exynos-drm-next?. I just had a setup to exynos-drm-next.
Thanks,
In
le.
Applied.
Thanks,
Inki Dae
>
> Signed-off-by: Andrzej Hajda
> ---
> Hi Inki,
>
> Rebased on the latest exynos-drm-next.
>
> Regards
> Andrzej
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 170
> +++-
> drivers/gpu/drm/exy
Update Exynos's DRM driver to use component match support rater than
add_components.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 40 ++-
1 file changed, 18 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/e
sung-soc/37266
>
> I have tested successfully your patch with trats and universal_c210 boards.
>
> Few additional comments below.
>
> On 09/01/2014 02:19 PM, Inki Dae wrote:
>> Update Exynos's DRM driver to use component match support rater than
>> add_components.
&
vel/2013-September/046207.html
Is there any issue I am missing , that could be incurred by Exynos codes?
Thanks,
Inki Dae
>
> Thanks, Daniel
>
>
> On Fri, Dec 20, 2013 at 11:36 AM, Inki Dae wrote:
>> This patch resolves potential deadlock issue that can be incurred
>
sting and above fixup patch set. Will look into them soon. :)
Thanks,
Inki Dae
>
> Few additional comments below.
>
> On 09/01/2014 02:19 PM, Inki Dae wrote:
>> Update Exynos's DRM driver to use component match support rater than
>> add_components.
>>
On 2014? 09? 11? 15:22, Daniel Vetter wrote:
> On Thu, Sep 11, 2014 at 11:16:53AM +0900, Inki Dae wrote:
>> On 2014? 09? 10? 18:01, Daniel Vetter wrote:
>>> Ok I've stumbled over the exynos mmap stuff again while cleaning up
>>> drm legacy cruft and I just don
On 2014? 09? 11? 16:01, Joonyoung Shim wrote:
> Hi,
>
> On 09/11/2014 03:22 PM, Daniel Vetter wrote:
>> On Thu, Sep 11, 2014 at 11:16:53AM +0900, Inki Dae wrote:
>>> On 2014? 09? 10? 18:01, Daniel Vetter wrote:
>>>> Ok I've stumbled over the exynos mm
he 2nd version of the series I have included changes proposed by
> Joonyoung Shim.
> I have decided to resend whole series because the changes caused merge
> conflicts and
> two separate patches have been added to the series.
> Changes are described in comit messages.
Applied.
Than
601 - 700 of 3085 matches
Mail list logo
