[PATCH] drm: Flush output polling on shutdown

2019-05-31 Thread Chris Wilson
00708 R15: 0007 <4> [341.890730] FS: () GS:88827620() knlGS: <4> [341.890739] CS: 0010 DS: ES: CR0: 80050033 <4> [341.890745] CR2: 55a4e064f4a0 CR3: 00026d234003 CR4: 003606f0 <4> [341.890752] C

Re: [PATCH] drm: Flush output polling on shutdown

2019-05-31 Thread Chris Wilson
Quoting Chris Wilson (2019-05-31 18:16:15) > We need to mark the output polling as disabled to prevent concurrent > irqs from queuing new work as shutdown the probe -- causing that work to > execute after we have freed the structs: > > <4> [341.846490] DEBUG_LOCKS_WARN_ON

[PATCH v2] drm: Flush output polling on shutdown

2019-05-31 Thread Chris Wilson
52] Call Trace: <4> [341.890760] drm_fb_helper_hotplug_event.part.24+0x89/0xb0 <4> [341.890768] drm_kms_helper_hotplug_event+0x21/0x30 <4> [341.890774] output_poll_execute+0x9d/0x1a0 <4> [341.890782] process_one_work+0x245/0x610 <4> [341.890790] worker_thread+0x37/0x380 &

[PATCH v2] drm: Flush output polling on shutdown

2019-05-31 Thread Chris Wilson
52] Call Trace: <4> [341.890760] drm_fb_helper_hotplug_event.part.24+0x89/0xb0 <4> [341.890768] drm_kms_helper_hotplug_event+0x21/0x30 <4> [341.890774] output_poll_execute+0x9d/0x1a0 <4> [341.890782] process_one_work+0x245/0x610 <4> [341.890790] worker_thread+0x37/0x38

[PATCH] dma-buf: Discard old fence_excl on retrying get_fences_rcu for realloc

2019-06-04 Thread Chris Wilson
If we have to drop the seqcount & rcu lock to perform a krealloc, we have to restart the loop. In doing so, be careful not to lose track of the already acquired exclusive fence. Fixes: fedf54132d24 ("dma-buf: Restart reservation_object_get_fences_rcu() after writes") #v4.10 Signed

[PATCH v2] dma-buf: Discard old fence_excl on retrying get_fences_rcu for realloc

2019-06-04 Thread Chris Wilson
If we have to drop the seqcount & rcu lock to perform a krealloc, we have to restart the loop. In doing so, be careful not to lose track of the already acquired exclusive fence. Fixes: fedf54132d24 ("dma-buf: Restart reservation_object_get_fences_rcu() after writes") #v4.10 Signed

[PATCH v3] dma-buf: Discard old fence_excl on retrying get_fences_rcu for realloc

2019-06-04 Thread Chris Wilson
If we have to drop the seqcount & rcu lock to perform a krealloc, we have to restart the loop. In doing so, be careful not to lose track of the already acquired exclusive fence. Fixes: fedf54132d24 ("dma-buf: Restart reservation_object_get_fences_rcu() after writes") #v4.10 Signed

[PATCH] dma-fence: Signal all callbacks from dma_fence_release()

2019-06-09 Thread Chris Wilson
up, and if they care they can check for the error. Signed-off-by: Chris Wilson Reviewed-by: Gustavo Padovan --- drivers/dma-buf/dma-fence.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index

[PATCH] dma-fence: Signal all callbacks from dma_fence_release()

2019-06-09 Thread Chris Wilson
up, and if they care they can check for the error. Signed-off-by: Chris Wilson Reviewed-by: Gustavo Padovan --- drivers/dma-buf/dma-fence.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index

Re: [PATCH] drm/fb: document dirty helper better

2019-06-11 Thread Chris Wilson
Quoting Daniel Vetter (2019-06-11 12:28:59) > Apparently little none fact that there's no need to hand-roll your own s/none/known/ > anymore. Cc'ing a bunch of driver people who might want to know this > too. ___ dri-devel mailing list dri-devel@lists.fre

[PATCH] dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES

2019-06-12 Thread Chris Wilson
Mark the access to reservation_object.fence as being protected to silence sparse. Signed-off-by: Chris Wilson --- include/linux/reservation.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/linux/reservation.h b/include/linux/reservation.h index ee750765cc94

Re: ✗ Fi.CI.SPARSE: warning for dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES

2019-06-12 Thread Chris Wilson
ssion > -./include/linux/reservation That'll cheer up some of the warnings CI periodically sends. Thanks for the quick review, -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH] drm/panfrost: Add support for mapping BOs on GPU page faults

2019-06-12 Thread Chris Wilson
gt; > What's the difference between i_mapping and f_mapping? > > What kind of clean-up on close is needed? Based on vgem faults, there > doesn't seem to be any refcounting. Assume userspace is responsible for > not freeing the BO while a

Re: [BUG] lockdep splat with kernfs lockdep annotations and slab mutex from drm patch??

2019-06-14 Thread Chris Wilson
t;= FULL && err >= 0 && is_root_cache(s)) { struct kmem_cache *c; mutex_lock(&slab_mutex); so it happens to hit the error + FULL case with the additional slabcaches? Anyway, according to lockdep, it is dangerous to use the slab_mutex inside sl

Re: [PATCH 48/59] drm/vgem: Ditch attach trickery in the fence ioctl

2019-06-18 Thread Chris Wilson
drm: Add reservation_object to drm_gem_object") > Signed-off-by: Daniel Vetter Reviewed-by: Chris Wilson Quick leave before I start ranting about the horrors of reservation_object. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

2019-06-26 Thread Chris Wilson
We gracefully handle the caller specifying a zero range, so don't force them to special case that condition if it naturally falls out of their setup. What we don't check is if the end < start, so keep that as an assert for an illegal call. Signed-off-by: Chris Wilson Cc: Joonas

Re: [PATCH] drm/i915: Fix reporting of size of created GEM object

2019-07-09 Thread Chris Wilson
ring actual size of created > GEM object before a reference to the object is put. > > Fixes: 929eec99f5fd ("drm/i915: Avoid use-after-free in reporting > create.size") This doesn't do anything. -Chris ___ dri-devel mailing

Re: [Intel-gfx] [PATCH v2 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-20 Thread Chris Wilson
Quoting Chris Wilson (2019-03-04 09:43:43) > Quoting Andy Shevchenko (2019-03-04 09:29:07) > > Switch to bitmap_zalloc() to show clearly what we are allocating. > > Besides that it returns pointer of bitmap type instead of opaque void *. > > > > Signed-off-by: And

[PATCH 1/2] dma-fence: Propagate errors to dma-fence-array container

2019-03-24 Thread Chris Wilson
When one of the array of fences is signaled, propagate its errors to the parent fence-array (keeping the first error to be raised). Signed-off-by: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan --- drivers/dma-buf/dma-fence-array.c | 4 1 file changed, 4 insertions(+) diff --git a

[PATCH 2/2] dma-fence: Report the composite sync_file status

2019-03-24 Thread Chris Wilson
Same as for the individual fences, we want to report the actual status of the fence when queried. Reported-by: Petri Latvala Signed-off-by: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan Cc: Petri Latvala --- drivers/dma-buf/sync_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2] dma-fence: Propagate errors to dma-fence-array container

2019-03-25 Thread Chris Wilson
When one of the array of fences is signaled, propagate its errors to the parent fence-array (keeping the first error to be raised). v2: Opencode cmpxchg_local to avoid compiler freakout. Signed-off-by: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan --- drivers/dma-buf/dma-fence-array.c

Re: [PATCH] drm/i915: Fix an error code in i915_gem_context_open()

2019-03-25 Thread Chris Wilson
ile_priv->vm_idr_lock); > mutex_destroy(&file_priv->context_idr_lock); > - return PTR_ERR(ctx); > + return err; I beat you by mere moments! Thanks for the patch, will be fixed momentarily. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-26 Thread Chris Wilson
l GGTT") > > Signed-off-by: Dan Carpenter > > Reviewed-by: Mika Kuoppala > > i915_request.c has another :) Having found it, you could have typed up the patch :-p Thanks for the fix, pushed. -Chris ___ dri-devel mailing list dri-devel@list

Re: [PATCH v2 2/3] drm: Add a drm_gem_objects_lookup helper

2019-04-01 Thread Chris Wilson
= 0; i < count; i++) { > > + /* Check if we currently have a reference on the object */ > > + obj = idr_find(&filp->object_idr, handle[i]); > > + if (!obj) { > > + ret = -ENOENT; Unwind previous drm_gem

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
n closed, how have we failed to flush and retire all requests (thereby unpinning the contexts and all other pointers). -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-04 11:40:24) > On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-04-04 11:24:45) > > > From: Janusz Krzysztofik > > > > > > In case the driver gets unbound while a device is open, ke

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-04 11:50:14) > On Thu, 2019-04-04 at 11:43 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-04-04 11:40:24) > > > On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: > > > > Quoting Janusz Krzysztofik (2019-

Re: [RFC PATCH 0/6] Rename functions to match their entry points

2019-07-10 Thread Chris Wilson
t; but by the end I was in agreement. The early_release though, that is worth a bit of artistic license to say early_probe pairs with late_release. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH] drm/i915: Drop extern qualifiers from header function prototypes

2019-07-10 Thread Chris Wilson
unsigned long arg); > +long i915_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long > arg); > #else > #define i915_compat_ioctl NULL > #endif > extern const struct dev_pm_ops i915_pm_ops; > +extern const struct dev_pm_ops i915_pm_ops_1; That's novel. -Chris

Re: [RFC PATCH] drm/i915: Join quoted strings and align them with open parenthesis

2019-07-10 Thread Chris Wilson
erent convention. -Chris

Re: [PATCH v2] drm/i915: Drop extern qualifiers from header function prototypes

2019-07-10 Thread Chris Wilson
s to see extern header churn. Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] dma-buf: Expand reservation_list to fill allocation

2019-07-12 Thread Chris Wilson
extra space. Signed-off-by: Chris Wilson Cc: Christian König Cc: Michel Dänzer --- drivers/dma-buf/reservation.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c index a6ac2b3a0185..80ecc1283d15 100644 --- a

[PATCH 2/2] dma-buf: Relax the write-seqlock for reallocating the shared fence list

2019-07-12 Thread Chris Wilson
As the set of shared fences is not being changed during reallocation of the reservation list, we can skip updating the write_seqlock. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Christian König --- drivers/dma-buf/reservation.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH] drm/vgem: Reclassify buffer creation debug message

2019-07-12 Thread Chris Wilson
A buffer is created in response to the user ioctl, it should therefore be a plain DRM_DEBUG() message to reflect it being a user invoked response and not a driver construct. This is just to make the commonplace drm.debug=[26e] quieter when running with vgem. Signed-off-by: Chris Wilson Cc

Re: [PATCH] drm/vgem: Reclassify buffer creation debug message

2019-07-12 Thread Chris Wilson
Quoting Daniel Vetter (2019-07-12 13:51:58) > On Fri, Jul 12, 2019 at 2:01 PM Chris Wilson wrote: > > > > A buffer is created in response to the user ioctl, it should therefore > > be a plain DRM_DEBUG() message to reflect it being a user invoked > > response

Re: [PATCH 1/2] dma-buf: Expand reservation_list to fill allocation

2019-07-15 Thread Chris Wilson
Quoting Koenig, Christian (2019-07-14 08:37:47) > Am 12.07.19 um 10:03 schrieb Chris Wilson: > > Since kmalloc() will round up the allocation to the next slab size or > > page, it will normally return a pointer to a memory block bigger than we > > asked for. We can query for t

Re: [PATCH 1/2] dma-buf: Expand reservation_list to fill allocation

2019-07-15 Thread Chris Wilson
Quoting Chris Wilson (2019-07-12 09:03:13) > Since kmalloc() will round up the allocation to the next slab size or > page, it will normally return a pointer to a memory block bigger than we > asked for. We can query for the actual size of the allocated block using > ksize() and expand

Re: [PATCH 2/2] drm/vgem: use normal cached mmap'ings

2019-07-16 Thread Chris Wilson
_concurrent_blit:8309) CRITICAL: Failed assertion: v[((y)*(b->width) + (((y) + pass)%(b->width)))] == val (gem_concurrent_blit:8309) CRITICAL: error: 0 != 0xdeadbeef and igt/prime_vgem Can you please cc intel-gfx so CI can pick up these changes? -Chris

Re: [PATCH v2 2/3] drm: plumb attaching dev thru to prime_pin/unpin

2019-07-16 Thread Chris Wilson
Quoting Rob Clark (2019-07-16 18:43:22) > From: Rob Clark > > Needed in the following patch for cache operations. What's the base for this patch? (I'm missing the ancestor for drm_gem.c) -Chris ___ dri-devel mai

Re: [PATCH 2/2] dma-buf: Relax the write-seqlock for reallocating the shared fence list

2019-07-16 Thread Chris Wilson
Quoting Daniel Vetter (2019-07-16 10:21:54) > On Fri, Jul 12, 2019 at 09:03:14AM +0100, Chris Wilson wrote: > > As the set of shared fences is not being changed during reallocation of > > the reservation list, we can skip updating the write_seqlock. > > > > Signed-o

Re: [PATCH] drm/syncobj: return meaningful value to user space

2019-07-18 Thread Chris Wilson
and found that would be an interesting experience. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/syncobj: return meaningful value to user space

2019-07-18 Thread Chris Wilson
Quoting Chunming Zhou (2019-07-18 14:04:09) > > 在 2019/7/18 19:18, Chris Wilson 写道: > > Quoting Chunming Zhou (2019-07-18 12:13:39) > >> if WAIT_FOR_SUBMIT isn't set and in the meanwhile no underlying fence on > >> syncobj, > >> then return non-bloc

Re: [PATCH] drm/syncobj: return meaningful value to user space

2019-07-18 Thread Chris Wilson
Quoting Chunming Zhou (2019-07-18 14:15:49) > > 在 2019/7/18 21:10, Chris Wilson 写道: > > Quoting Chunming Zhou (2019-07-18 14:04:09) > >> 在 2019/7/18 19:18, Chris Wilson 写道: > >>> Quoting Chunming Zhou (2019-07-18 12:13:39) > >>>> if WAIT_FOR_SUB

Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h

2019-07-18 Thread Chris Wilson
between include/drm/* and uapi/* > > Signed-off-by: Sam Ravnborg > Suggested-by: Daniel Vetter > Reviewed-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Rob Clark > Cc: Sean Paul > Cc: Chris Wilson > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Fix up broken merge

2019-07-22 Thread Chris Wilson
ime_export with obj_funcs.export > > plus make sure i915_gem_dma_buf.c doesn't get zombie-resurrect. It > moved in > > commit 10be98a77c558f8cfb823cd2777171fbb35040f6 > Author: Chris Wilson > Date: Tue May 28 10:29:49 2019 +0100 > > drm/i915: Move more GEM o

Re: [PATCH] drm/i915: Fix up broken merge

2019-07-22 Thread Chris Wilson
ime_export with obj_funcs.export > > plus make sure i915_gem_dma_buf.c doesn't get zombie-resurrect. It > moved in > > commit 10be98a77c558f8cfb823cd2777171fbb35040f6 > Author: Chris Wilson > Date: Tue May 28 10:29:49 2019 +0100 > > drm/i915: Move mo

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_get_drvdata

2019-07-23 Thread Chris Wilson
Quoting Chuhong Yuan (2019-07-23 11:39:16) > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan That cuts out some circumlocution, Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_get_drvdata

2019-07-23 Thread Chris Wilson
Quoting Chris Wilson (2019-07-23 17:25:17) > Quoting Chuhong Yuan (2019-07-23 11:39:16) > > Instead of using to_pci_dev + pci_get_drvdata, > > use dev_get_drvdata to make code simpler. > > > > Signed-off-by: Chuhong Yuan > > That cuts out some circumlocution,

Re: [PATCH v5 2/3] dma-buf: add DMA_BUF_SET_NAME ioctls

2019-07-26 Thread Chris Wilson
buf->resv); This trusts that access to the name via the fs is serialised by the refcount. It would have been great if the inode would only be allocated for a named dmabuf, but I expect that requires replacing struct file after it is exposed (but maybe a struct file can be moved between fs?). -Chris

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Chris Wilson
y: Thomas Gleixner Which tree do you plan to apply it to? I can put in drm-intel, and with the fixes tag it will percolate through to 5.3 and beyond, but if you want to apply it directly to squash the build warnings, feel free. -Chris

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Chris Wilson
Quoting Thomas Gleixner (2019-07-26 20:18:32) > On Fri, 26 Jul 2019, Chris Wilson wrote: > > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > > > Objtool reports: > > > > > > >

Re: [PATCH 1/2] dma-buf: add dma_fence_chain_for_each_unwrap helper

2019-07-30 Thread Chris Wilson
r = dma_fence_chain_walk(iter)) ? It doesn't look like dma_fence_chain_unwrap() can legally return NULL, but if you pass NULL to unwrap it returns NULL. I'd vote for dma_fence_chain_for_each_fence() in the spirit of list_for_each_entry(). -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf: add dma_fence_chain_for_each_unwrap helper v2

2019-07-31 Thread Chris Wilson
\ > +(fence = dma_fence_chain_unwrap(iter)); \ > +iter = dma_fence_chain_walk(iter)) Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf: add more reservation object locking wrappers

2019-07-31 Thread Chris Wilson
nical, Reviewed-by: Chris Wilson Quietly opines for s/reservation_object/dma_reservation/ -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf: add more reservation object locking wrappers

2019-07-31 Thread Chris Wilson
Quoting Christian König (2019-07-31 14:34:28) > Am 31.07.19 um 14:33 schrieb Chris Wilson: > > Quoting Christian König (2019-07-31 12:38:53) > >> Complete the abstraction of the ww_mutex inside the reservation object. > >> > >> This allows us to add more handl

Re: [PATCH] drm/vgem: fix cache synchronization on arm/arm64

2019-08-01 Thread Chris Wilson
keeps the WC buffers and avoids any drm core > > > changes. On the minus side, I don't think it will work (at least > > > on arm64) prior to v5.0[2], so the fix can't be backported very > > > far. > > > &

[PATCH] Revert "drm/vgem: fix cache synchronization on arm/arm64"

2019-08-01 Thread Chris Wilson
commit 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") broke all of the !llc i915-vgem coherency tests in CI, and left the HW very, very unhappy (which is even more scary). Fixes: 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") Signed-off-

Re: [PATCH] drm/vgem: fix cache synchronization on arm/arm64

2019-08-01 Thread Chris Wilson
Quoting Rob Clark (2019-08-01 16:18:45) > On Thu, Aug 1, 2019 at 5:40 AM Chris Wilson wrote: > > > > Quoting Sean Paul (2019-07-31 20:23:31) > > > On Fri, Jul 19, 2019 at 11:21:53AM +0200, Daniel Vetter wrote: > > > > On Wed, Jul 17, 2019 at 02:15:37PM -0700,

Re: [Intel-gfx] [linux-next] mm/i915: i915_gemfs_init() NULL dereference

2019-08-01 Thread Chris Wilson
ontext() here as well. I guess it's better than poking at the SB_INFO directly ourselves. I think though we shouldn't bail if we can't change the thp setting, and just accept whatever with a warning. Looks like the API is already available in dinq, so we can apply this ahead of the n

Re: [PATCH 1/2] i915: convert to new mount API

2019-08-02 Thread Chris Wilson
ps->reconfigure(fc)) > + ok = false; > } > > +out: > + if (!ok) > + pr_err("i915 gemfs reconfiguration failed\n"); Let's make it a bit more user friendly, dev_err(i915->drm.dev, "Unable to reconfig

Re: [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Sergey Senozhatsky (2019-08-02 13:39:56) > put_filesystem() before i915_gemfs_init() deals with > kern_mount() error. > > Signed-off-by: Sergey Senozhatsky > --- > drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/g

Re: [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Chris Wilson (2019-08-02 13:58:36) > Quoting Sergey Senozhatsky (2019-08-02 13:39:56) > > put_filesystem() before i915_gemfs_init() deals with > > kern_mount() error. > > > > Signed-off-by: Sergey Senozhatsky > > --- > > drivers/gpu/drm/i915/gem/i9

Re: [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
unt, don't release mnt until * we unmount before file sys is unregistered */ real_mount(mnt)->mnt_ns = MNT_NS_INTERNAL; } return mnt; } With the exception of fiddling with MNT_NS_INTERNAL, it seems amenable for our needs. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Sergey Senozhatsky (2019-08-02 14:49:55) > On (08/02/19 14:41), Chris Wilson wrote: > [..] > > struct vfsmount *kern_mount(struct file_system_type *type) > > { > > struct vfsmount *mnt; > > mnt = vfs_kern_mount(type, SB_KERNMOUNT, type->nam

[PATCH 2/2] drm/syncobj: Lookup the syncobj with RCU protection

2019-08-02 Thread Chris Wilson
our reference. Signed-off-by: Chris Wilson Cc: Daniel Vetter --- drivers/gpu/drm/drm_syncobj.c | 12 +--- include/drm/drm_syncobj.h | 2 ++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 4fc71dc9fc43

[PATCH 1/2] drm/syncobj: Convert syncobj_idr to XArray

2019-08-02 Thread Chris Wilson
Prior to making the syncobj lookup lockless, update the idr to the new XArray API. Based on a patch by Matthew Wilcox Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_syncobj.c | 64 ++- include/drm/drm_file.h| 7 ++-- 2 files changed, 21 insertions

[RFC 0/4] rockchip-dsi for rk3568

2022-08-12 Thread Chris Morgan
From: Chris Morgan This series adds support for the dsi and dphy controllers on the Rockchip RK3568. I can confirm that for the Rockchip RK3568 this current series DOES NOT WORK properly yet. The image on the screen is shifted about 100 pixels to the right and does not appear to be a timing

[RFC 1/4] dt-bindings: display: rockchip-dsi: add rk3568 compatible

2022-08-12 Thread Chris Morgan
From: Chris Morgan The rk3568 uses the same dw-mipi-dsi controller as previous Rockchip SOCs, so add a compatible string for it. Signed-off-by: Chris Morgan --- .../bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[RFC 2/4] dt-bindings: phy: phy-rockchip-inno-dsidphy: add compatible for rk3568

2022-08-12 Thread Chris Morgan
From: Chris Morgan Add a compatible string for the rk3568 dsi-dphy. Signed-off-by: Chris Morgan --- .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b

[RFC 3/4] drm/rockchip: dsi: add rk3568 support

2022-08-12 Thread Chris Morgan
From: Chris Morgan Add the compatible and GRF definitions for the RK3568 soc. Signed-off-by: Chris Morgan --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 51 ++- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c

[RFC 4/4] phy/rockchip: inno-dsidphy: Add support for rk3568

2022-08-12 Thread Chris Morgan
From: Chris Morgan Add support for the Rockchip RK3568 DSI-DPHY. Registers were taken from the BSP kernel driver and wherever possible cross referenced with the TRM. Signed-off-by: Chris Morgan --- .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 204 ++ 1 file changed, 158

[RESEND 0/6 v2] Support Geekworm MZP280 Panel for Raspberry Pi

2022-05-19 Thread Chris Morgan
From: Chris Morgan This patch series is to add support for the MZP280 panel for the Raspberry Pi. This panel requires adding support for Mode 3 of the Raspberry Pi DPI connector, which necessitates a new media bus format. This patch series has been tested on my Raspberry Pi 4 with version 1 of

[RESEND 2/6 v2] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI. This format is used by the Geekworm MZP280 panel which interfaces with the Raspberry Pi. Signed-off-by: Chris Morgan --- .../media/v4l/subdev-formats.rst | 37 +++ 1 file changed, 37 insertions

[RESEND 1/6 v2] dt-bindings: vendor-prefixes: Add Geekworm

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add vendor prefix for Geekworm (https://geekworm.com). Signed-off-by: Chris Morgan --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation

[RESEND 5/6 v2] drm/panel: simple: add Geekworm MZP280 Panel

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add support for the Geekworm MZP280 Panel Signed-off-by: Chris Morgan Acked-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm

[RESEND 4/6 v2] dt-bindings: display: simple: add Geekworm MZP280 Panel

2022-05-19 Thread Chris Morgan
From: Chris Morgan The Geekworm MZP280 panel is a 480x640 (portrait) panel with a capacitive touch interface and a 40 pin header meant to interface directly with the Raspberry Pi. The screen is 2.8 inches diagonally, and there appear to be at least 4 distinct versions all with the same panel

[RESEND 6/6 v2] drm/vc4: dpi: Support DPI interface in mode3 for RGB565

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add support for the VC4 DPI driver to utilize DPI mode 3. This is defined here as xxxRxxGGxxxB: https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#parallel-display-interface-dpi This mode is required to use the Geekworm MZP280 DPI display

[RESEND 3/6 v2] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm MZP280 panel for the Raspberry Pi. Signed-off-by: Chris Morgan --- include/uapi/linux/media-bus-format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/media-bus

[WARNING] [AMDGPU] Linux 5.16.18 warning about ttm_bo_release with R7 360

2022-04-03 Thread Chris Rankin
machine.) This is with a Fedora 5.16.18-200.fc35.x86_64 kernel. Kernel trace follows. Cheers, Chris [ 568.881348] [ cut here ] [ 568.881354] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/ttm/ttm_bo.c:411 ttm_bo_release+0x34c/0x370 [ttm] [ 568.881365] Modules linked in: rfcomm

RE: [WARNING] [AMDGPU] Linux 5.16.18 warning about ttm_bo_release with R7 360

2022-04-03 Thread Chris Rankin
Ah yes, here it is: https://lore.kernel.org/lkml/CAK2bqVJo8TZUwu4-5VcY0MEezM7gJJq77prMpCB=fda24fe...@mail.gmail.com/ It looks like this warning started with the 5.14.x kernels. Cheers, Chris

[PATCH V2 0/2] chrontel-ch7033: Add byteswap order option

2022-09-02 Thread Chris Morgan
From: Chris Morgan This series adds the ability to set the byteswap order in the chrontel ch7033 driver via an optional devicetree node. This is necessary because the HDMI DIP of the NTC CHIP requires a byteswap order that differs from the default value of the driver. Changes from V1

[PATCH V2 1/2] dt-bindings: Add byteswap order to chrontel ch7033

2022-09-02 Thread Chris Morgan
From: Chris Morgan Update dt-binding documentation to add support for setting byteswap of chrontel ch7033. New property name of chrontel,byteswap added to set the byteswap order. This property is optional. Signed-off-by: Chris Morgan Reviewed-by: Robert Foss --- .../bindings/display/bridge

[PATCH V2 2/2] drm/bridge: chrontel-ch7033: Add byteswap order setting

2022-09-02 Thread Chris Morgan
From: Chris Morgan Add the option to set the byteswap order in the devicetree. For the official HDMI DIP for the NTC CHIP the byteswap order needs to be RGB, however the driver sets it as BGR. With this patch the driver will remain at BGR unless manually specified via devicetree. Signed-off-by

mesa-22.3.0-devel + linux-5.19.6 + mediapipe: panfrost js fault

2022-09-03 Thread Chris Ruehl
scores 588. Same code run on a x86_64 with an AMD GPU working fine. Anything help fix the bug is welcome. Thanks Chris

[PATCH v2 0/5] rockchip-dsi for rk3568

2022-09-06 Thread Chris Morgan
From: Chris Morgan This series adds support for the dsi and dphy controllers on the Rockchip RK3568. I can confirm that for the Rockchip RK3568 this current series DOES WORK now, but it requires rolling back clk changes made for the HDMI driver. If the clock changes are not rolled back, the

[PATCH v2 1/5] dt-bindings: display: rockchip-dsi: add rk3568 compatible

2022-09-06 Thread Chris Morgan
From: Chris Morgan The rk3568 uses the same dw-mipi-dsi controller as previous Rockchip SOCs, so add a compatible string for it. Signed-off-by: Chris Morgan --- .../bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v2 2/5] dt-bindings: phy-rockchip-inno-dsidphy: add compatible for rk3568

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add a compatible string for the rk3568 dsi-dphy. Signed-off-by: Chris Morgan --- .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b

[PATCH v2 3/5] drm/rockchip: dsi: add rk3568 support

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add the compatible and GRF definitions for the RK3568 soc. Signed-off-by: Chris Morgan --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 51 ++- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c

[PATCH v2 5/5] arm64: dts: rockchip: Add DSI and DSI-DPHY nodes to rk356x

2022-09-06 Thread Chris Morgan
From: Chris Morgan This adds the DSI controller nodes and DSI-DPHY controller nodes to the rk356x device tree. Signed-off-by: Chris Morgan --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 72 1 file changed, 72 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH v2 4/5] phy/rockchip: inno-dsidphy: Add support for rk3568

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add support for the Rockchip RK3568 DSI-DPHY. Registers were taken from the BSP kernel driver and wherever possible cross referenced with the TRM. Signed-off-by: Chris Morgan --- .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 204 ++ 1 file changed, 158

[PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS495QA01 panel bindings

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add documentation for the Samsung AMS495QA01 panel. Signed-off-by: Chris Morgan --- .../display/panel/samsung,ams495qa01.yaml | 49 +++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung

[PATCH 0/2] drm/panel: Add Samsung AMS495QA01 Panel

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add the Samsung AMS495QA01 panel as found on the Anbernic RG503. This panel uses DSI to receive video signals, but 3-wire SPI to receive command signals. Chris Morgan (2): dt-bindings: display: panel: Add Samsung AMS495QA01 panel bindings drm/panel: Add Samsung AMS495QA01

[PATCH 2/2] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-09-06 Thread Chris Morgan
From: Chris Morgan Support Samsung AMS495QA01 panel as found on the Anbernic RG503. Note This panel receives video signals via DSI, however it receives commands via 3-wire SPI. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel

[PATCH 0/2] drm/panel: Add NewVision NV3051D Panels

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add the NewVision NV3051D panel as found on the Anbernic RG353P and RG353V. The underlying LCD panel itself is unknown (the NV3051D is the controller), so the device name is used for the panel. Chris Morgan (2): dt-bindings: display: panel: Add NewVision NV3051D panel

[PATCH 2/2] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel

2022-09-06 Thread Chris Morgan
From: Chris Morgan Support NewVision NV3051D panels as found on the Anbernic RG353P and RG353V. The underlying panel part number for the RG353x devices is unknown, so the device name is used instead. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/Kconfig | 9

[PATCH 1/2] dt-bindings: display: panel: Add NewVision NV3051D panel bindings

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Signed-off-by: Chris Morgan --- .../display/panel/newvision,nv3051d.yaml | 48 +++ 1 file

Re: [PATCH v2 0/5] rockchip-dsi for rk3568

2022-09-06 Thread Chris Morgan
you. > > Best Regards, > Maya Matuszczyk > > > wt., 6 wrz 2022 o 19:52 Chris Morgan napisał(a): > > > > From: Chris Morgan > > > > This series adds support for the dsi and dphy controllers on the > > Rockchip RK3568. I can confirm that for th

Re: [PATCH V2 1/2] dt-bindings: Add byteswap order to chrontel ch7033

2022-09-07 Thread Chris Morgan
On Mon, Sep 05, 2022 at 05:20:57PM +0200, Robert Foss wrote: > Thanks Laurent, > > On Sat, 3 Sept 2022 at 02:17, Laurent Pinchart > wrote: > > > > Hi Chris, > > > > Thank you for the patch. > > > > On Fri, Sep 02, 2022 at 10:39:05AM -05

Re: [PATCH 1/2] dt-bindings: display: panel: Add NewVision NV3051D panel bindings

2022-09-07 Thread Chris Morgan
On Wed, Sep 07, 2022 at 02:53:56PM +0200, Krzysztof Kozlowski wrote: > On 06/09/2022 20:52, Chris Morgan wrote: > > From: Chris Morgan > > > > Add documentation for the NewVision NV3051D panel bindings. > > Note that for the two expected consumers of this panel bin

Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS495QA01 panel bindings

2022-09-07 Thread Chris Morgan
On Tue, Sep 06, 2022 at 04:41:00PM -0500, Rob Herring wrote: > On Tue, 06 Sep 2022 13:36:41 -0500, Chris Morgan wrote: > > From: Chris Morgan > > > > Add documentation for the Samsung AMS495QA01 panel. > > > > Signed-off-by: Chris Morgan > > --- > &g

<    1   2   3   4   5   6   7   8   9   10   >