Move existing condition to while(), so it will be clear on what
circumstances the loop is successfully finishing.
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a
Drop unused vlv_iosf_sb_read() and vlv_iosf_sb_write().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/vlv_sideband.c | 17 -
drivers/gpu/drm/i915/vlv_sideband.h | 3 ---
2 files changed, 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/vlv_sideband.c
b/drivers/gpu
From: Jani Nikula
Purely a guess. Drop the nop function.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers
On Thu, Nov 02, 2023 at 04:47:41PM +0100, Hans de Goede wrote:
> On 11/2/23 16:12, Andy Shevchenko wrote:
...
> > + soc_exec_opaque_gpio(connector, gpio_index,
> > "INT33FF:03", "Panel SE",
> > +
On Thu, Nov 02, 2023 at 07:10:09PM +0200, Ville Syrjälä wrote:
> On Thu, Nov 02, 2023 at 05:12:14PM +0200, Andy Shevchenko wrote:
...
> > if (native)
> > icl_native_gpio_set_value(dev_priv, gpio_number, value);
> > else if (DISPLA
Names of the MIPI sequence steps are sequential and defined, no
need to check for the gaps. However in seq_name the MIPI_SEQ_END
is missing. Add it there, and drop unneeded NULL check in
sequence_name().
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display
From: Jani Nikula
Follow the contemporary conventions.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers
From: Jani Nikula
The lowest level functions are about setting GPIO values, not about
executing any sequences anymore.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20
From: Jani Nikula
With the various sequence versions and pointer increments interleaved,
it's a bit hard to decipher what's going on. Add separate paths for
different sequence versions.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy
From: Jani Nikula
Purely a guess. Drop the nop function.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers
From: Jani Nikula
Drop the unused parameter.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915
Names of the MIPI sequence steps are sequential and defined, no
need to check for the gaps. However in seq_name the MIPI_SEQ_END
is missing. Add it there, and drop unneeded NULL check in
sequence_name().
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers
le of precursor patches by Hans
- added Rb tag for used to be first three patches (Andi)
- rebased on top of the above changes
- fixed indexing for multi-community devices, such as Cherry View
In v2:
- added a few cleanup patches
- reworked to use dynamic GPIO lookup tables
- converted CHV as well
Taking all this into consideration replace the hack with proper
GPIO APIs being used.
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 98 ++--
1 file changed, 28 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/i915/displa
For a couple of cases the branches call the same bxt_gpio_set_value().
As Ville suggested they can be combined by dropping the DISPLAY_VER()
check from Gen 11 to Gen 9. Do it that way.
Suggested-by: Ville Syrjälä
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c
Move existing condition to while(), so it will be clear on what
circumstances the loop is successfully finishing.
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +
1 file changed, 1 insertion(+), 4
In the snippets like the following
if (...)
return / goto / break / continue ...;
else
...
the 'else' is redundant. Get rid of it.
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i9
From: Hans de Goede
Fix wrong initial value for GPIOs in bxt_gpio_set_value().
Signed-off-by: Hans de Goede
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers
Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.
For CHV case, for example, we will need to distinguish community based index
from the one that VBT is using. Introduce an additional parameter to
soc_gpio_set_value() and its callers.
Signed-off-by: Andy Shevchenko
ed.
After getting the "backlight" and "panel" GPIOs the lookup table
registered by intel_dsi_vbt_gpio_init() is no longer necessary,
remove it so that another temporary lookup-table for the ":00:02.0"
device can be added.
Signed-off-by: Hans de Goede
Signed-off-by
Taking all this into consideration replace the hack
with proper GPIO APIs being used.
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 47 +---
1 file changed, 10 insertions(+), 37 deletions(-)
diff --git a/drivers/
Drop unused vlv_iosf_sb_read() and vlv_iosf_sb_write().
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/vlv_sideband.c | 17 -
drivers/gpu/drm/i915/vlv_sideband.h | 3 ---
2 files changed, 20 deletions(-)
diff --git a/drivers/gpu/drm/i915
Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++-
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915
dant 'else'?
> goto out;
> +#if IS_ENABLED(CONFIG_FB_BACKLIGHT)
> + else if (info->bl_dev && info->bl_dev != bd)
Ditto.
> + goto out;
> +#endif
--
With Best Regards,
Andy Shevchenko
acklight_ops.
check_fb()
Acked-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
On Wed, Feb 21, 2024 at 5:45 PM Thomas Zimmermann wrote:
> Am 21.02.24 um 15:34 schrieb Andy Shevchenko:
> > On Wed, Feb 21, 2024 at 10:41:28AM +0100, Thomas Zimmermann wrote:
> >> Framebuffer drivers for devices with dedicated backlight are supposed
> >> to set s
27;, expected: ')'
> 482arch/arm64/kernel/entry-fpsimd.S:98: Info: macro invoked from here
> 483arch/arm64/kernel/entry-fpsimd.S:282: Error: unexpected characters
> following instruction at operand 3 -- `bic x2,x1,(0+(((unsigned
> long)~0ULL-((unsigned long)(1)<<(0))+1)&((unsigned
> long)~0ULL>>((sizeof(unsigned long)*8)-1-(3)'
> 484arch/arm64/kernel/entry-fpsimd.S:98: Info: macro invoked from here
--
With Best Regards,
Andy Shevchenko
iously wrong. Has to be dropped. If somebody wants that, it will
be material for v6.10 cycle.
--
With Best Regards,
Andy Shevchenko
On Wed, Feb 21, 2024 at 11:06:10PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 21, 2024 at 10:37:30PM +0200, Dmitry Baryshkov wrote:
> > On Wed, 21 Feb 2024 at 22:30, Dmitry Baryshkov
> > wrote:
...
> > Excuse me, it seems a c&p from gitlab didn't work as expecte
left untouched for asm case, no?
--
With Best Regards,
Andy Shevchenko
* mutex_destroy() is an empty function if CONFIG_DEBUG_MUTEXES is
> + * disabled. No need to allocate an action in that case.
> + */
> + if (IS_ENABLED(CONFIG_DEBUG_MUTEXES))
> + return devm_add_action_or_reset(dev, devm_mutex_drop, lock);
> + else
> + return 0;
> +}
Cc: George Stark
--
With Best Regards,
Andy Shevchenko
On Wed, Feb 28, 2024 at 05:39:21PM -0600, Lucas De Marchi wrote:
> On Thu, Feb 22, 2024 at 06:49:59AM -0800, Yury Norov wrote:
> > On Wed, Feb 21, 2024 at 03:59:06PM -0600, Lucas De Marchi wrote:
> > > On Wed, Feb 21, 2024 at 11:04:22PM +0200, Andy Shevchenko wrote:
> > >
On Thu, Feb 29, 2024 at 12:21:34PM -0600, Lucas De Marchi wrote:
> On Thu, Feb 29, 2024 at 12:49:57PM +0200, Andy Shevchenko wrote:
> > On Wed, Feb 28, 2024 at 05:39:21PM -0600, Lucas De Marchi wrote:
> > > On Thu, Feb 22, 2024 at 06:49:59AM -0800, Yury Norov wrote:
...
> &g
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdm
On Wed, Jan 24, 2024 at 05:19:53PM +, Daniel Thompson wrote:
> On Sun, Jan 14, 2024 at 05:25:08PM +0200, Andy Shevchenko wrote:
...
> > +typedef int (*hx8357_init)(struct lcd_device *);
> > + hx8357_init init;
>
> As somewhere else in this thread, I'd find thi
On Wed, Jan 24, 2024 at 05:25:07PM +, Daniel Thompson wrote:
> On Sun, Jan 14, 2024 at 05:25:11PM +0200, Andy Shevchenko wrote:
...
> Reviewed-by: Daniel Thompson
Thank you for the review, I will address comments and send a new version
at the end of the next week I hope.
--
Wit
A few ad-hoc cleanups and one patch to make driver OF-independent.
Chagelog v2:
- renamed init to init_fn and typedef accordingly (Daniel)
- added tags (Daniel, Javier)
Andy Shevchenko (4):
backlight: hx8357: Make use of device properties
backlight: hx8357: Move OF table closer to its
Simplify the error handling in probe function by switching from
dev_err() to dev_err_probe().
Reviewed-by: Daniel Thompson
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 12
1 file changed, 4 insertions(+), 8 deletions
We have a temporary variable to keep pointer to struct device.
Utilise it inside the ->probe() implementation.
Reviewed-by: Daniel Thompson
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 7 +++
1 file changed, 3 insertions(+)
Allow to use driver on non-OF platforms and other cleanups.
Changelog v2:
- rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel)
- add tags (Daniel, Flavio)
- new patch 2
Andy Shevchenko (3):
backlight: mp3309c: Make use of device properties
backlight: mp3309c:
Replace dev_err() with dev_err_probe().
This helps in simplifing code and standardizing the error output.
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/video/backlight
Move OF table near to the user.
While at it, drop comma at terminator entry.
Reviewed-by: Daniel Thompson
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Include mod_devicetable.h explicitly to replace the dropped of.h
which included mod_devicetable.h indirectly.
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Andy Shevchenko
---
drivers/video
We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.
Reviewed-by: Daniel Thompson
Tested-by: Flavio Suligoi
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 30 --
1 file changed, 12 insertions(+), 18
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Add mod_devicetable.h include.
Tested-by: Flavio Suligoi
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 44 +--
1 file changed, 18 insertions
On Fri, Feb 02, 2024 at 10:52:32AM +, Flavio Suligoi wrote:
> > Andy Shevchenko (3):
> > backlight: mp3309c: Make use of device properties
> > backlight: mp3309c: use dev_err_probe() instead of dev_err()
> > backlight: mp3309c: Utilise temporary variable for st
On Thu, Feb 08, 2024 at 10:53:04AM +, Lee Jones wrote:
> On Thu, 01 Feb 2024, Andy Shevchenko wrote:
...
> Someone may wish to address this:
>
> WARNING: DT compatible string "himax,hx8369" appears un-documented -- check
> ./Documentation/devicetree/bindings/
&
On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote:
> On Thu, 01 Feb 2024, Andy Shevchenko wrote:
...
> > backlight: mp3309c: Utilise temporary variable for struct device
(1)
> Set no longer applies. Please rebase, thanks.
I got a contradictory messages:
1) email that s
On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote:
> On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote:
> > > On Thu, 01 Feb 2024, Andy Shevchenko wrote:
...
> > > > backlight: mp3309c: Utilise tempor
On Thu, Feb 08, 2024 at 06:14:55PM +, Lee Jones wrote:
> On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote:
> > > On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > > > On Thu, Feb 08, 2024 at 11:34:25AM +,
We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.
Reviewed-by: Daniel Thompson
Tested-by: Flavio Suligoi
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 30 --
1 file changed, 12 insertions(+), 18
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Add mod_devicetable.h include.
Tested-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 44 +--
1
iel)
- add tags (Daniel, Flavio)
- new patch 2
Andy Shevchenko (3):
backlight: mp3309c: Make use of device properties
backlight: mp3309c: use dev_err_probe() instead of dev_err()
backlight: mp3309c: Utilise temporary variable for struct device
drivers/video/backlight/mp3309c.c |
Replace dev_err() with dev_err_probe().
This helps in simplifing code and standardizing the error output.
Tested-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 18 +++---
1 file changed, 7 insertions(+), 11
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Add mod_devicetable.h include.
Tested-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 44 +--
1
iel)
- add tags (Daniel, Flavio)
- new patch 2
Andy Shevchenko (3):
backlight: mp3309c: Make use of device properties
backlight: mp3309c: use dev_err_probe() instead of dev_err()
backlight: mp3309c: Utilise temporary variable for struct device
drivers/video/backlight/mp3309c.c |
We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.
Reviewed-by: Daniel Thompson
Tested-by: Flavio Suligoi
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 30 --
1 file changed, 12 insertions(+), 18
Replace dev_err() with dev_err_probe().
This helps in simplifing code and standardizing the error output.
Tested-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 18 +++---
1 file changed, 7 insertions(+), 11
On Thu, Feb 08, 2024 at 08:24:46PM +0200, Andy Shevchenko wrote:
> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
>
> Add mod_devicetable.h include.
It seems some emails are missing, I just sent a 'resend v3' hopefully
om here. In any case, nice patch:
And it's at the bottom (among SoB lines), there is no violation with Submitting
Patches.
--
With Best Regards,
Andy Shevchenko
On Fri, Feb 09, 2024 at 07:50:52AM +, Lee Jones wrote:
> On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > On Thu, Feb 08, 2024 at 06:14:55PM +, Lee Jones wrote:
> > > On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > > > On Thu, Feb 08, 2024 at 05:39:46PM +,
aragraph should go to the comment/changelog area below.
> Signed-off-by: Devarsh Thakkar
> ---
> V1->V6 (No change, patch introduced in V7)
> ---
--
With Best Regards,
Andy Shevchenko
f 8192 is?
--
With Best Regards,
Andy Shevchenko
v4l2-jpeg.c as suggested in mailing list [1].
> - Add macros to round to closest integer (either higher or lower) while
>rounding in order of 2.
Nice, now it's chained!
But all my comments to the previous mails are still applicable here.
--
With Best Regards,
Andy Shevchenko
is to go smaller than bigger.
--
With Best Regards,
Andy Shevchenko
On Fri, May 10, 2024 at 06:15:34PM +0300, Jani Nikula wrote:
> On Fri, 10 May 2024, Andy Shevchenko
> wrote:
> > On Fri, May 10, 2024 at 12:09:52AM +0530, Devarsh Thakkar wrote:
> >> Add macros to round to nearest specified power of 2.
> >
> > This is not what
On Fri, May 10, 2024 at 06:16:42PM +0300, Laurent Pinchart wrote:
> On Fri, May 10, 2024 at 06:03:52PM +0300, Andy Shevchenko wrote:
> > On Fri, May 10, 2024 at 12:10:10AM +0530, Devarsh Thakkar wrote:
> > > Use generic macro round_closest_up for rounding to nearest multi
On Sun, May 12, 2024 at 07:46:58AM +0300, Alexey Dobriyan wrote:
> I think
>
> roundup(x, 1 << n)
Since it's about power-of-two, round_up() is better.
> is more readable.
--
With Best Regards,
Andy Shevchenko
macros, and it's not clear
why you can't use one of them in your case.
The patch that changes those to a new one are doubtful to begin with.
I.e. need a careful review on the arithmetics side of the change
including HW capabilities of handling "closest" results.
--
With Best Regards,
Andy Shevchenko
On Mon, May 13, 2024 at 04:55:58PM +0530, Devarsh Thakkar wrote:
> On 13/05/24 14:29, Andy Shevchenko wrote:
> > On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote:
> >> On 10/05/24 20:45, Jani Nikula wrote:
[...]
> >>> Moreover, I think the namin
On Mon, May 13, 2024 at 06:34:19PM +0530, Devarsh Thakkar wrote:
> On 13/05/24 17:55, Andy Shevchenko wrote:
> > On Mon, May 13, 2024 at 04:55:58PM +0530, Devarsh Thakkar wrote:
> >> On 13/05/24 14:29, Andy Shevchenko wrote:
> >>> On Sat, May 11, 2024 at 11:11:14P
#include
+ math.h // obviously
+ module.h
> +#include
+ types.h
...
Other than above, LGTM.
--
With Best Regards,
Andy Shevchenko
On Fri, May 17, 2024 at 01:53:47PM -0700, Daniel Latypov wrote:
> On Fri, May 17, 2024 at 1:14 PM Andy Shevchenko
> wrote:
...
> > > [devarsht: Rebase to 6.9 and change license to GPL]
> >
> > I'm not sure that you may change license. It needs the author's
On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote:
> On 18/05/24 01:44, Andy Shevchenko wrote:
> > On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote:
[..]
> >> +#include
> >> +#include
> >
> >> +#include
> >
>
On Mon, May 20, 2024 at 07:51:24PM +0530, Devarsh Thakkar wrote:
> On 20/05/24 17:52, Andy Shevchenko wrote:
> > On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote:
> >> On 18/05/24 01:44, Andy Shevchenko wrote:
> >>> On Fri, May 17, 2024 at 11:06:07P
0], &tmp64, sizeof(u64));
> memcpy(&guid[8], &tmp64, sizeof(u64));
What is the type of guid? Shouldn't it be guid_t with the respective
guid_is_null()
...
> - if (memchr_inv(guid, 0, 16))
> + if (!mem_is_zero(guid, 16))
>
ing to have a new function per byte in question, or do we
come up with a common denominator, like mem_is_all_of(mem, byte)?
--
With Best Regards,
Andy Shevchenko
* round_closest_up(17, 4) = 16
> + * round_closest_up(15, 4) = 16
> + * round_closest_up(14, 4) = 16
Btw, is kernel-doc validator happy about all kernel docs you added?
> + */
--
With Best Regards,
Andy Shevchenko
de
...
> +MODULE_LICENSE("GPL");
modpost validator won't be happy about this, i.e. missing MODULE_DESCRIPTION().
--
With Best Regards,
Andy Shevchenko
On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote:
> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote:
...
> > +MODULE_LICENSE("GPL");
>
> modpost validator won't be happy about this, i.e. missing
> MODULE_DESCRIPTION().
And obvi
k_get(&tmu->pdev->dev, "fck");
devm_ approach can help a lot in case of platform device code.
> + if (IS_ERR(tmu->clk)) {
> + dev_err(&tmu->pdev->dev, "cannot get clock\n");
> + return PTR_ERR(tmu->clk);
return dev_err_probe() ?
> + }
--
With Best Regards,
Andy Shevchenko
On Tue, May 28, 2024 at 04:02:30PM +0530, Devarsh Thakkar wrote:
> On 28/05/24 02:02, Andy Shevchenko wrote:
> > On Sun, May 26, 2024 at 11:38:56PM +0530, Devarsh Thakkar wrote:
...
> >> +/**
> >> + * round_closest_up - round closest to be multiple of spec
On Tue, May 28, 2024 at 04:51:46PM +0530, Devarsh Thakkar wrote:
> On 28/05/24 02:07, Andy Shevchenko wrote:
[..]
> >> +#include
> >> +#include
> >> +#include
> >
> > + math.h (where abs()/DIV_ROUND_*()/etc come from?)
> > I believe I mentioned
On Tue, May 28, 2024 at 05:01:31PM +0530, Devarsh Thakkar wrote:
> On 28/05/24 02:08, Andy Shevchenko wrote:
> > On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote:
> >> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote:
...
> >
e been
> a bit flaky recently, so needed to do a rerun.
>
> That said, I'm not sure if we have any hardware in CI that would
> actually exercise the modifications, so in that sense I trust Hans'
> testing much more.
Thank you!
Should I fix checkpatch warnings CI reported about?
--
With Best Regards,
Andy Shevchenko
On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote:
> On 11/3/23 21:18, Andy Shevchenko wrote:
> > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> > talking to GPIO IP behind the actual driver's back. A second attempt
> > to fix t
fact, using a default value of 1 leads to the display not working when
> the fbdev is attached to the framebuffer console.
>
> Reported-by: Sahaj Sarup
Closes?
Fixes?
> Signed-off-by: Javier Martinez Canillas
--
With Best Regards,
Andy Shevchenko
since we do the same for formats anyway. But it did
> occur to me (twice at least) that a kmemdup_array() might a nice thing
> to have for things like this. But that's a separate topic.
JFYI:
https://lore.kernel.org/all/20231017052322.2636-2-kkar...@nvidia.com/
--
With Best Regards,
Andy Shevchenko
The driver uses math.h and not util_macros.h.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c
b/drivers/gpu/drm/i915/display/intel_snps_phy.c
index
to put the GPIO-descriptors.
Fine by me, but I'm not to judge if it is a right approach or not.
In my series I have reused existing call... Anyway, FWIW,
Reviewed-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
fbtft_framebuffer_release(info);
> return -EINVAL;
ret = dev_err_probe(dev, -EINVAL, "buswidth is not set\n");
goto out_release;
> }
--
With Best Regards,
Andy Shevchenko
ays, not any comples RGB or so devices. If
those devices are capable of representing characters/digits in similar
way, we may export linedisp library for them to utilise.
--
With Best Regards,
Andy Shevchenko
Update header inclusions to follow IWYU (Include What You Use)
principle.
Signed-off-by: Andy Shevchenko
---
include/drm/drm_fixed.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h
index 81572d32db0c..387fb81d5b81 100644
ndependent")
How is it a fix?
> Closes: https://lore.kernel.org/lkml/20230223203713.hcse3mkbq3m6sogb@skbuf/
Yes, and then Reported-by, which is missing here.
> Cc: Andy Shevchenko
> Cc: Daniel Scally
> Cc: Heikki Krogerus
> Cc: Sakari Ailus
> Cc: Greg Kroah-Hartman
> Cc: &quo
Update header inclusions to follow IWYU (Include What You Use)
principle.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fb_seps525.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_seps525.c
b/drivers/staging/fbtft/fb_seps525.c
On Wed, Apr 24, 2024 at 12:37:16AM +0300, Dmitry Baryshkov wrote:
> On Wed, Apr 24, 2024 at 12:49:18AM +0800, Sui Jingfeng wrote:
> > On 2024/4/23 21:28, Andy Shevchenko wrote:
> > > On Tue, Apr 23, 2024 at 12:46:58AM +0800, Sui Jingfeng wrote:
...
> But let me throw an ar
On Wed, Apr 24, 2024 at 04:34:39PM +0300, Dmitry Baryshkov wrote:
> On Wed, 24 Apr 2024 at 16:11, Andy Shevchenko
> wrote:
> >
> > On Wed, Apr 24, 2024 at 12:37:16AM +0300, Dmitry Baryshkov wrote:
> > > On Wed, Apr 24, 2024 at 12:49:18AM +0800, Sui Jingfeng wrote:
>
On Wed, Apr 24, 2024 at 07:34:54PM +0300, Dmitry Baryshkov wrote:
> On Wed, Apr 24, 2024 at 05:52:03PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 24, 2024 at 04:34:39PM +0300, Dmitry Baryshkov wrote:
> > > On Wed, 24 Apr 2024 at 16:11, Andy Shevchenko
> > > wrote:
&
make
maintenance and support eaiser for everybody.
Also see discussion [1] for details about Ilitek 9341 duplication
code.
Link: https://lore.kernel.org/r/zxm9pg-53v4s8...@smile.fi.intel.com [1]
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/Kconfig | 13 --
drivers/gpu/drm/tiny
The modpost script is not happy
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/gpu/drm/drm_mipi_dbi.o
because there is a missing module description.
Add it to the module.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/drm_mipi_dbi.c | 1 +
1 file changed, 1 insertion
801 - 900 of 1147 matches
Mail list logo
