Re: [PATCH v3 00/26] compat_ioctl: cleanups

2019-05-06 Thread Andy Shevchenko
E conversion. > I'll post the patches I made for that later, as they need more > testing and review from the scsi maintainers. > > I hope you can still take these for the coming merge window, unless > new problems come up. > drivers/platform/x86/wmi.c

Re: [PATCH 03/16] lib,treewide: add new match_string() helper/macro

2019-05-09 Thread Andy Shevchenko
decs/max98088.c > +++ b/sound/soc/codecs/max98088.c > @@ -1405,7 +1405,7 @@ static int max98088_get_channel(struct > snd_soc_component *component, const char > { > int ret; > > - ret = __match_string(eq_mode_name, ARRAY_SIZE(eq_mode_name), name); > + ret = match

Re: [PATCH v5 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-04-16 Thread Andy Shevchenko
uple of places where something maybe optimized. Nevertheless, FWIW, Reviewed-by: Andy Shevchenko > > CC: Federico Lorenzi > CC: Lukas Wunner > CC: Andy Shevchenko > Link: https://bugzilla.kernel.org/show_bug.cgi?id=99891 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=108331 &

Re: [PATCH v5 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-04-17 Thread Andy Shevchenko
On Mon, Apr 15, 2019 at 04:09:55PM -0700, Life is hard, and then you die wrote: > On Mon, Apr 15, 2019 at 12:03:46PM +0300, Andy Shevchenko wrote: > > On Mon, Apr 15, 2019 at 01:13:00AM -0700, Ronald Tschalär wrote: > > > +static void > > > +applespi_remap_fn_k

[PATCH v1] drm/tinydrm: Trivia typo fix

2019-02-20 Thread Andy Shevchenko
Fix adddress -> address typo. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index 3a05e56f9b0d..2f8c2d1d09bc 100644 --- a/driv

Re: [PATCH] tinydrm/mipi-dbi: Use dma-safe buffers for all SPI transfers

2019-02-25 Thread Andy Shevchenko
+0x1dd/0x1f0 > [ 23.750773] spi_sync+0x26/0x40 > [ 23.750790] mipi_dbi_typec3_command_read+0x14d/0x240 [mipi_dbi] > [ 23.750802] ? spi_finalize_current_transfer+0x10/0x10 > [ 23.750821] mipi_dbi_typec3_command+0x1bc/0x1d0 [mipi_dbi] > After few runs I don't see the wa

[PATCH v1] drm/tinydrm/ili9341: Support Adafruit 2.8" TFT display

2019-02-25 Thread Andy Shevchenko
The Adafruit 2.8" TFT display [1] has different dimensions than 2.4" one. Add support for it. [1]: https://cdn-shop.adafruit.com/datasheets/MI0283QT-11+V1.1.PDF Signed-off-by: Andy Shevchenko --- - based on top of drm-tip drivers/gpu/drm/tinydrm/ili9341.c | 17 ++-

Re: [PATCH v1] drm/tinydrm/ili9341: Support Adafruit 2.8" TFT display

2019-02-26 Thread Andy Shevchenko
On Mon, Feb 25, 2019 at 04:07:05PM +0100, Noralf Trønnes wrote: > > > Den 25.02.2019 15.45, skrev Andy Shevchenko: > > The Adafruit 2.8" TFT display [1] has different dimensions than 2.4" one. > > Add support for it. > > > > [1]: https://cdn-shop.a

Re: [PATCH] tinydrm/mipi-dbi: Use dma-safe buffers for all SPI transfers

2019-03-05 Thread Andy Shevchenko
On Mon, Mar 04, 2019 at 03:45:56PM +0100, Noralf Trønnes wrote: > > > Den 22.02.2019 16.58, skrev Andy Shevchenko: > > On Fri, Feb 22, 2019 at 01:43:29PM +0100, Noralf Trønnes wrote: > >> Buffers passed to spi_sync() must be dma-safe even for tiny buffers since > >

[PATCH v1 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-05 Thread Andy Shevchenko
Switch to bitmap_zalloc() to show clearly what we are allocating. Besides that it returns pointer of bitmap type instead of opaque void *. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/selftests/test-drm_mm.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a

[PATCH v2 2/2] drm: i915: Switch to bitmap_zalloc()

2019-03-05 Thread Andy Shevchenko
Switch to bitmap_zalloc() to show clearly what we are allocating. Besides that it returns pointer of bitmap type instead of opaque void *. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_gem_fence_reg.c | 3 +-- drivers/gpu

[PATCH v1 2/2] drm: i915: Switch to bitmap_zalloc()

2019-03-05 Thread Andy Shevchenko
Switch to bitmap_zalloc() to show clearly what we are allocating. Besides that it returns pointer of bitmap type instead of opaque void *. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_gem_fence_reg.c | 3 +-- drivers/gpu

[PATCH v2 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-05 Thread Andy Shevchenko
Switch to bitmap_zalloc() to show clearly what we are allocating. Besides that it returns pointer of bitmap type instead of opaque void *. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/selftests/test-drm_mm.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a

Re: [Intel-gfx] [PATCH v2 2/2] drm: i915: Switch to bitmap_zalloc()

2019-03-05 Thread Andy Shevchenko
On Mon, Mar 04, 2019 at 09:41:34AM +, Chris Wilson wrote: > Quoting Andy Shevchenko (2019-03-04 09:29:08) > > Switch to bitmap_zalloc() to show clearly what we are allocating. > > Besides that it returns pointer of bitmap type instead of opaque void *. > > Which i

Re: [PATCH] tinydrm/mipi-dbi: Use dma-safe buffers for all SPI transfers

2019-03-05 Thread Andy Shevchenko
On Mon, Mar 04, 2019 at 06:51:33PM +0100, Noralf Trønnes wrote: > Den 04.03.2019 16.10, skrev Andy Shevchenko: > > On Mon, Mar 04, 2019 at 03:45:56PM +0100, Noralf Trønnes wrote: > >> Den 22.02.2019 16.58, skrev Andy Shevchenko: > >>> On Fri, Feb 22, 2019 at 01:43:29

Re: [PATCH v1 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-06 Thread Andy Shevchenko
On Tue, Mar 05, 2019 at 11:28:36AM +0200, Joonas Lahtinen wrote: > I take it that both instances are supposed to call bitmap_zalloc? > > If you can send a v2 that compiles, I can merge it after it passes the > CI. v2 had been sent yesterday. -- With Best Regards, And

Re: [PATCH v3 06/20] docs: mark orphan documents as such

2019-06-11 Thread Andy Shevchenko
t; +:orphan: > + > LG Gram laptop extra features > = > Can we rather create a toc tree there? It was a first document in reST format in that folder. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 06/20] docs: mark orphan documents as such

2019-06-11 Thread Andy Shevchenko
On Tue, Jun 11, 2019 at 8:05 PM Mauro Carvalho Chehab wrote: > > Em Tue, 11 Jun 2019 19:52:04 +0300 > Andy Shevchenko escreveu: > > > On Fri, Jun 7, 2019 at 10:04 PM Mauro Carvalho Chehab > > wrote: > > > Sphinx doesn't like orphan documents: > > &

[PATCH v1] backlight: pwm_bl: convert to use SPDX identifier

2019-06-19 Thread Andy Shevchenko
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. While here, correct MODULE_LICENSE() string to be aligned with license text. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/pwm_bl.c | 11 +++ 1 file changed, 3 insertions(+), 8

[PATCH v1] backlight: gpio_backlight: Enable ACPI enumeration

2019-06-20 Thread Andy Shevchenko
ACPI allows to enumerate specific devices by using compatible strings. Enable that enumeration for GPIO based backlight devices. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/gpio_backlight.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git

Re: [PATCH v1] backlight: gpio_backlight: Enable ACPI enumeration

2019-06-21 Thread Andy Shevchenko
On Thu, Jun 20, 2019 at 03:12:05PM +0100, Daniel Thompson wrote: > On 19/06/2019 16:21, Andy Shevchenko wrote: > > ACPI allows to enumerate specific devices by using compatible strings. > > Enable that enumeration for GPIO based backlight devices. > > +

Re: [PATCH v2 2/7] backlight: gpio: simplify the platform data handling

2019-07-22 Thread Andy Shevchenko
; > - } > - return ret; > - } > - > - return 0; > -} Why not leave this function (perhaps with different name)? -- With Best Regards, Andy Shevchenko

dri-devel@lists.freedesktop.org

2019-07-22 Thread Andy Shevchenko
enum gpiod_flags flags; > + struct device *dev; Can't we do struct device dev = &pdev->dev; struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev); ? It fits 80 nicely. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 0/7] backlight: gpio: simplify the driver

2019-07-22 Thread Andy Shevchenko
provements for the GPIO backlight driver while we're already > modifying it. > > I don't have access to this HW but hopefully this works. Only compile > tested. > > [1] https://lkml.org/lkml/2019/6/25/900 For uncommented ones Reviewed-by: Andy Shevchenko > >

Re: [PATCH v2 2/7] backlight: gpio: simplify the platform data handling

2019-07-23 Thread Andy Shevchenko
On Tue, Jul 23, 2019 at 08:28:00AM +0200, Bartosz Golaszewski wrote: > pon., 22 lip 2019 o 18:06 Andy Shevchenko > napisał(a): > > > > On Mon, Jul 22, 2019 at 05:02:57PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > >

dri-devel@lists.freedesktop.org

2019-07-23 Thread Andy Shevchenko
On Tue, Jul 23, 2019 at 08:29:52AM +0200, Bartosz Golaszewski wrote: > pon., 22 lip 2019 o 18:09 Andy Shevchenko > napisał(a): > > > > On Mon, Jul 22, 2019 at 05:03:02PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > I

[PATCH v1] backlight: lm3630a: Switch to use fwnode_property_count_uXX()

2019-07-23 Thread Andy Shevchenko
Use use fwnode_property_count_uXX() directly, that makes code neater. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/lm3630a_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index

Re: [PATCH v3 2/7] backlight: gpio: simplify the platform data handling

2019-07-24 Thread Andy Shevchenko
GPIO handling and unify a big chunk of code. > > The only field used from the platform data is now the fbdev pointer. Reviewed-by: Andy Shevchenko > > Signed-off-by: Bartosz Golaszewski > --- > drivers/video/backlight/gpio_backlight.c | 64 +--- >

dri-devel@lists.freedesktop.org

2019-07-24 Thread Andy Shevchenko
On Wed, Jul 24, 2019 at 10:25:08AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Instead of dereferencing pdev each time, use a helper variable for > the associated device pointer. Reviewed-by: Andy Shevchenko > > Signed-off-by: Bartosz Golaszewski >

Re: [PATCH v2 00/10] drivers, provide a way to add sysfs groups easily

2019-07-31 Thread Andy Shevchenko
; > Maybe make an immutable branch off 5.2 with just patch 1/10 so that > subsystems (and the driver core tree itself) could pull it in at their > leisure into their "*-next" branches and did not have to wait till 5.4 > or risk merge clashes? Isn't cherry-pick enough for one patch? -- With Best Regards, Andy Shevchenko

Re: [PATCH 06/14] leds: mt6370: Add Mediatek MT6370 Indicator support

2022-06-02 Thread Andy Shevchenko
On Thu, Jun 2, 2022 at 8:27 AM ChiYuan Huang wrote: > On Wed, Jun 01, 2022 at 11:48:58AM +0200, Andy Shevchenko wrote: > > On Tue, May 31, 2022 at 1:16 PM ChiaEn Wu wrote: ... > > What indicator? > It's RGB curent sink type LED driver (maximum supported current is only 2

Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-02 Thread Andy Shevchenko
On Thu, Jun 2, 2022 at 2:07 PM szuni chen wrote: > Andy Shevchenko 於 2022年6月1日 週三 下午5:57寫道: > > On Tue, May 31, 2022 at 1:32 PM ChiaEn Wu wrote: ... > > > + const char * const states[] = { "off", "keep", "on" }; >

Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-02 Thread Andy Shevchenko
On Thu, Jun 2, 2022 at 3:57 PM Andy Shevchenko wrote: > On Thu, Jun 2, 2022 at 2:07 PM szuni chen wrote: > > Andy Shevchenko 於 2022年6月1日 週三 下午5:57寫道: > > > On Tue, May 31, 2022 at 1:32 PM ChiaEn Wu wrote: ... > > > > + const char * const s

Re: [PATCH] staging: ftbft: Use backlight helper

2022-06-07 Thread Andy Shevchenko
; > Instead of manually checking the power state in struct > backlight_properties, use backlight_is_blank(). Reviewed-by: Andy Shevchenko > Signed-off-by: Stephen Kitt > Cc: Greg Kroah-Hartman > Cc: "Noralf Trønnes" > Cc: Thomas Zimmermann > Cc: Andy Shevche

Re: [PATCH v8 01/16] clk: generalize devm_clk_get() a bit

2022-06-22 Thread Andy Shevchenko
so contained.) Even easier, you may take a message-id from the Link and supply to `b4`: b4 mbox ${message-id} mutt -f ${message-id}.mbx # or whatever MUA that handles mboxes Dunno if `b4` has capability to parse Link instead of message-id. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 3/4] MAINTAINERS: Add entry for Solomon SSD130X OLED displays DRM driver

2022-02-04 Thread Andy Shevchenko
nce the new DRM driver was made compatible with the existing binding. ... > drivers/gpu/drm/drm_format_helper.c | 2 +- Nothing about this in the commit message... Stray change? -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 2/4] drm/tiny: Add driver for Solomon SSD130X OLED displays

2022-02-04 Thread Andy Shevchenko
. ... > + if (IS_ERR(bl)) { > + ret = PTR_ERR(bl); > + dev_err(dev, "Unable to register backlight device: %d\n", ret); > + return ret; return dev_err_probe(); > + } ... > + ret = drm_dev_register(drm, 0); > + if (ret) { > + dev_err(dev, "DRM device register failed: %d\n", ret); > + return ret; > + } Ditto. ... > + {}, Comma is not needed in terminator entry. ... > +static struct i2c_driver ssd130x_i2c_driver = { > + .driver = { > + .name = DRIVER_NAME, > + .of_match_table = ssd130x_of_match, > + }, > + .probe_new = ssd130x_probe, > + .remove = ssd130x_remove, > + .shutdown = ssd130x_shutdown, > +}; > + Redundant blank line. > +module_i2c_driver(ssd130x_i2c_driver); -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 3/4] MAINTAINERS: Add entry for Solomon SSD130X OLED displays DRM driver

2022-02-04 Thread Andy Shevchenko
On Fri, Feb 04, 2022 at 03:12:17PM +0100, Javier Martinez Canillas wrote: > On 2/4/22 14:57, Andy Shevchenko wrote: > > On Fri, Feb 04, 2022 at 02:43:46PM +0100, Javier Martinez Canillas wrote: ... > > Stray change? > > Sigh, I'm not sure how added that change. Just i

Re: [PATCH v2 2/4] drm/tiny: Add driver for Solomon SSD130X OLED displays

2022-02-05 Thread Andy Shevchenko
On Fri, Feb 04, 2022 at 08:19:12PM +0100, Javier Martinez Canillas wrote: > On 2/4/22 15:26, Andy Shevchenko wrote: > > On Fri, Feb 04, 2022 at 02:43:45PM +0100, Javier Martinez Canillas wrote: ... > >> +struct ssd130x_device { > >> + struct drm

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-09 Thread Andy Shevchenko
, Geert, for testing and reporting this issue in particular. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Andy Shevchenko
ed to allocate DRM device: %d\n", ret); > + return ssd130x; return dev_err_probe() ? > + } ... > + bl = devm_backlight_device_register(dev, dev_name(dev), dev, ssd130x, > + &ssd130xfb_bl_ops, NULL); > + if (IS_ERR(bl)) { > + ret = PTR_ERR(bl); > + dev_err(dev, "Unable to register backlight device: %d\n", ret); > + return ERR_PTR(ret); Ditto. > + } ... > + ret = drm_dev_register(drm, 0); > + if (ret) { > + dev_err(dev, "DRM device register failed: %d\n", ret); > + return ERR_PTR(ret); Ditto. > + } ... I have feelings that half of my comments were ignored... Maybe I missed the discussion(s). -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 4/7] drm/solomon: Add SSD130X OLED displays I2C support

2022-02-09 Thread Andy Shevchenko
illas s?! ... > +#include > +#include regmap.h ? err.h? ... > + ssd130x = ssd130x_probe(&client->dev, regmap); > + Redundant blank line. > + if (IS_ERR(ssd130x)) > + return PTR_ERR(ssd130x); ... > + { /* sentinel */ }, No comma for terminator

Re: [PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support

2022-02-09 Thread Andy Shevchenko
h Best Regards, Andy Shevchenko

Re: [PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support

2022-02-09 Thread Andy Shevchenko
be a good time to deprecate the existing > "solomon,ssd130*fb-i2c" compatible values, and switch to > "solomon,ssd130*fb" instead, for both I2C and SPI. Agree! > Of course the I2C subdriver still has to bind against the old values, > too, for backwards compatibility. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support

2022-02-09 Thread Andy Shevchenko
if nobody keep an eye each rc cycle. It might take time to return it in shape first. *) Speaking out of my own experience with device(s) that I possess. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-09 Thread Andy Shevchenko
t resurrection discussion I can send a new version to unorphan it, route via fbdev, and leave under staging, so it will be a compromise between all stakeholders. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Andy Shevchenko
On Wed, Feb 09, 2022 at 04:54:01PM +0100, Javier Martinez Canillas wrote: > On 2/9/22 16:12, Andy Shevchenko wrote: > > On Wed, Feb 09, 2022 at 10:03:10AM +0100, Javier Martinez Canillas wrote: ... > >> + do { > >> + value = va_arg(ap, int); > >> +

Re: [PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support

2022-02-09 Thread Andy Shevchenko
On Wed, Feb 09, 2022 at 05:07:03PM +0100, Javier Martinez Canillas wrote: > On 2/9/22 16:17, Andy Shevchenko wrote: > > On Wed, Feb 09, 2022 at 01:25:46PM +0100, Geert Uytterhoeven wrote: > >> On Wed, Feb 9, 2022 at 10:12 AM Javier Martinez Ca

Re: [PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support

2022-02-09 Thread Andy Shevchenko
are different buses, can't clash). -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Andy Shevchenko
On Wed, Feb 09, 2022 at 05:26:00PM +0100, Javier Martinez Canillas wrote: > On 2/9/22 17:08, Andy Shevchenko wrote: ... > On that topic, I even typed a SPI driver because of your feedback :) Much appreciated, makes me much easier to test. Thank you for doing all this! -- With Best R

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Andy Shevchenko
= 100.% > > With unsorted page lists: > > BENCHMARKs: VC: 31.005s VO: 42.889s A: 0.000s Sys: 2.256s = 76.150s > BENCHMARK%: VC: 40.7156% VO: 56.3219% A: 0.% Sys: 2.9625% = 100.% > > VC shows the overhead of video decoding, VO shows the overhead of the

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-11 Thread Andy Shevchenko
8 b = *src & 0x00ff; > + > + /* ITU BT.601: Y = 0.299 R + 0.587 G + 0.114 B */ > + *dst++ = (3 * r + 6 * g + b) / 10; > + src++; > + } Can be done as while (pixels--) { ... } or do {

Re: [PATCH v4 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed()

2022-02-11 Thread Andy Shevchenko
art and end pixels that > + * are not aligned to multiple of 8. > + * > + * Calculate if the start and end pixels are not aligned and set the > + * offsets for the reversed mono line conversion function to adjust. > + */ > + start_offset = clip->x1 % 8; > + end_len = clip->x2 % 8; ALIGN() ? -- With Best Regards, Andy Shevchenko

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 11:40:13AM +0100, Javier Martinez Canillas wrote: > On 2/11/22 11:28, Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 10:19:22AM +0100, Javier Martinez Canillas wrote: ... > >> +static void drm_fb_xrgb_to_gray8_line(u8 *dst, const u32 *src,

Re: [PATCH v4 4/6] drm/solomon: Add SSD130x OLED displays I2C support

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 10:19:25AM +0100, Javier Martinez Canillas wrote: > The ssd130x driver only provides the core support for these devices but it > does not have any bus transport logic. Add a driver to interface over I2C. Reviewed-by: Andy Shevchenko > Signed-off-by: Javier

Re: [PATCH v4 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-02-11 Thread Andy Shevchenko
lt; k; > + } > + data_array[array_idx++] = data; > + } > + } ... > + bl = devm_backlight_device_register(dev, dev_name(dev), dev, ssd130x, > + &ssd130xfb_bl_ops, NULL); > + if (IS_ERR(bl)) { > + ret = PTR_ERR(bl); > + dev_err_probe(dev, ret, "Unable to register backlight > device\n"); > + return ERR_PTR(ret); dev_err_probe(dev, PTR_ERR(bl), "Unable to register backlight device\n"); return bl; ? > + } -- With Best Regards, Andy Shevchenko

Re: [PATCH v4 5/6] MAINTAINERS: Add entry for Solomon SSD130x OLED displays DRM driver

2022-02-11 Thread Andy Shevchenko
nce the new DRM driver was made compatible with the existing binding. Reviewed-by: Andy Shevchenko > Signed-off-by: Javier Martinez Canillas > Acked-by: Sam Ravnborg > --- > > (no changes since v3) > > Changes in v3: > - Adapt MAINTAINERS entry to point to the n

Re: [PATCH v4 6/6] dt-bindings: display: ssd1307fb: Add myself as binding co-maintainer

2022-02-11 Thread Andy Shevchenko
intainer of the binding, to make sure that I will > be on Cc when patches are proposed for it. Reviewed-by: Andy Shevchenko > Suggested-by: Sam Ravnborg > Signed-off-by: Javier Martinez Canillas > Acked-by: Rob Herring > --- > > Changes in v4: > - Add Rob Herring Acked-

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 02:05:56PM +0200, Jani Nikula wrote: > On Fri, 11 Feb 2022, Thomas Zimmermann wrote: > > Am 11.02.22 um 12:12 schrieb Andy Shevchenko: > >> On Fri, Feb 11, 2022 at 11:40:13AM +0100, Javier Martinez Canillas wrote: > >>> On 2/11/22 11:28, An

Re: [PATCH v4 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 01:05:57PM +0100, Javier Martinez Canillas wrote: > On 2/11/22 12:33, Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 10:19:24AM +0100, Javier Martinez Canillas wrote: ... > >> + * Helper to write command (SSD130X_COMMAND). The fist variadic argume

Re: [PATCH v4 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed()

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 12:50:04PM +0100, Javier Martinez Canillas wrote: > On 2/11/22 12:10, Andy Shevchenko wrote: ... > >> + for (xb = 0; xb < pixels; xb++) { > >> + unsigned int start = 0, end = 8; > >> + u8 byte = 0x00; > > >

Re: [PATCH v5 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-11 Thread Andy Shevchenko
critical, so Reviewed-by: Andy Shevchenko > Suggested-by: Thomas Zimmermann > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > --- > > Changes in v5: > - Add Thomas Zimmermann's Reviewed-by to patch #1. > > Changes in v3: > - Add a drm_fb_x

Re: [PATCH v5 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed()

2022-02-11 Thread Andy Shevchenko
nditionals from the loop), but since it's almost a direct copy of the existing code let's improve it later on. Reviewed-by: Andy Shevchenko > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > --- > > Changes in v5: > - Use drm_WARN_ON*

Re: [PATCH v5 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-02-11 Thread Andy Shevchenko
be(dev, PTR_ERR(ssd130x), > + "Failed to allocate DRM device\n"); > + return ssd130x; This... > + } ... > + bl = devm_backlight_device_register(dev, dev_name(dev), dev, ssd130x, > + &ssd130xfb_bl_ops, NULL); > + if (IS_ERR(bl)) > + return ERR_PTR(dev_err_probe(dev, PTR_ERR(bl), > + "Unable to register backlight > device\n")); Can be consistent with this then. -- With Best Regards, Andy Shevchenko

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 06:25:17PM +0200, Jani Nikula wrote: > On Fri, 11 Feb 2022, Andy Shevchenko > wrote: > > On Fri, Feb 11, 2022 at 02:05:56PM +0200, Jani Nikula wrote: > >> On Fri, 11 Feb 2022, Thomas Zimmermann wrote: > >> > Am 11.02.22 um 12:12 schrie

Re: [PATCH] drivers: fbtft: Refactor backlight logic

2022-02-14 Thread Andy Shevchenko
all your fbtft patches to fbdev maintainer as well. -- With Best Regards, Andy Shevchenko

Re: [PATCH] drivers: fbtft: Add property 'keep-bootlogo'

2022-02-14 Thread Andy Shevchenko
-- With Best Regards, Andy Shevchenko

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Andy Shevchenko
On Mon, Feb 14, 2022 at 11:17:11AM +0200, Pekka Paalanen wrote: > On Fri, 11 Feb 2022 19:27:12 +0200 > Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 06:25:17PM +0200, Jani Nikula wrote: > > > On Fri, 11 Feb 2022, Andy Shevchenko > > > wrote: > > &g

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Andy Shevchenko
On Mon, Feb 14, 2022 at 10:03:53AM +0100, Thomas Zimmermann wrote: > Am 11.02.22 um 16:41 schrieb Andy Shevchenko: ... > > > IMO *always* prefer a for loop over while or do-while. > > > > > > The for (i = 0; i < N; i++) is such a strong paradigm in C. You &g

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Andy Shevchenko
On Mon, Feb 14, 2022 at 01:12:48PM +0100, Thomas Zimmermann wrote: > Am 14.02.22 um 11:38 schrieb Andy Shevchenko: > > On Mon, Feb 14, 2022 at 10:03:53AM +0100, Thomas Zimmermann wrote: > > > Am 11.02.22 um 16:41 schrieb Andy Shevchenko: ... > > > > > IMO *always

[PATCH v1 1/1] drm/i915/selftests: Replace too verbose for-loop with simpler while

2022-02-15 Thread Andy Shevchenko
It's hard to parse for-loop which has some magic calculations inside. Much cleaner to use while-loop directly. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/selftests/i915_syncmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH v1 1/1] drm/i915/selftests: Replace too verbose for-loop with simpler while

2022-02-15 Thread Andy Shevchenko
On Tue, Feb 15, 2022 at 07:14:49PM +0200, Jani Nikula wrote: > On Tue, 15 Feb 2022, Andy Shevchenko > wrote: > > It's hard to parse for-loop which has some magic calculations inside. > > Much cleaner to use while-loop directly. > > I assume you're trying to

Re: [PATCH v7 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

2022-08-05 Thread Andy Shevchenko
al > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > Add a support for the Type-C & Power Delivery controller in > MediaTek MT6370 IC. Reviewed-by: Andy Shevchenko > Reviewed-by:

Re: [PATCH v7 09/13] iio: adc: mt6370: Add MediaTek MT6370 support

2022-08-05 Thread Andy Shevchenko
ght WLED driver, > a display bias driver and a general LDO for portable devices. > > Add a support for the Type-C & Power Delivery controller in > MediaTek MT6370 IC. Reviewed-by: Andy Shevchenko > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: ChiaEn Wu >

Re: [PATCH v7 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver

2022-08-05 Thread Andy Shevchenko
switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > Add a support for the Type-C & Power Delivery controll

Re: [PATCH v7 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-08-05 Thread Andy Shevchenko
;on" }; > + ret = fwnode_property_read_string(init_data->fwnode, "default-state", > + &stat_str); > + if (!ret) { > + ret = match_string(states, ARRAY_SIZE(states), stat_str); > + if (ret < 0) > + ret = STATE_OFF; > + > + led->default_state = ret; > + } Replace this by using led_init_default_state_get(). -- With Best Regards, Andy Shevchenko

Re: [PATCH v7 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-08-05 Thread Andy Shevchenko
use different mask, shift and default > +* maxiimum brightness value. Use spell-checker for all your patches. > +*/ -- With Best Regards, Andy Shevchenko

Re: [PATCH v7 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

2022-08-05 Thread Andy Shevchenko
eed to check the style * of multi-line comments like * this one. */ > +*/ -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name

2022-08-06 Thread Andy Shevchenko
On Sat, Aug 6, 2022 at 6:37 PM Markuss Broks wrote: > > The "node" argument is actually an offset, and it's also > an "int", and not "unsigned long". Correct the of_setup_earlycon > function. Suggested-by: Greg KH? > Signed-off-by: Markuss Broks -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem

2022-08-06 Thread Andy Shevchenko
if ((x >> (7 - n)) & 1) > + memset(dst, 0xff, (info.depth / 8)); Too many parentheses. > + else > + memset(dst, 0, (info.depth / 8)); Ditto. > + dst += (info.depth / 8); Ditto. > + } > +} -- With Best Regards, Andy Shevchenko

Re: tiny drm driver for NOKIA-5110 LCD

2022-08-09 Thread Andy Shevchenko
x/latest/source/drivers/staging/fbtft/fb_pcd8544.c [2]: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/solomon -- With Best Regards, Andy Shevchenko

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-16 Thread Andy Shevchenko
we already in trouble? -- With Best Regards, Andy Shevchenko

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-16 Thread Andy Shevchenko
block of code > that enables the resources in the right order. These devres helpers give > a false sense of security to driver authors and they will end up > introducing problems, the same way that devm_kzalloc() makes it > outrageously easy to crash the kernel by disconnecting a device that is > in use. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 00/14] Use devm helpers for regulator get and enable

2022-08-19 Thread Andy Shevchenko
fy using devm_regulator_get_enable() > hwmon: adm1177: simplify using devm_regulator_get_enable() hwmon uses a different pattern for the Subject line. -- With Best Regards, Andy Shevchenko

Re: [PATCH] staging: fbtft: fix checkpatch.pl struct should normally be const

2022-05-19 Thread Andy Shevchenko
ps), GFP_KERNEL); > + const fbops = devm_kzalloc(dev, sizeof(struct fb_ops), GFP_KERNEL); Why? -- With Best Regards, Andy Shevchenko

Re: [PATCH 06/14] leds: mt6370: Add Mediatek MT6370 Indicator support

2022-06-01 Thread Andy Shevchenko
int mt6372_tfreqs[] = { > + 8000, 4000, 2000, 1000, 500, 250, 8, 4 Ditto. > +}; -- With Best Regards, Andy Shevchenko

Re: [PATCH 06/14] leds: mt6370: Add Mediatek MT6370 Indicator support

2022-06-01 Thread Andy Shevchenko
On Wed, Jun 1, 2022 at 11:48 AM Andy Shevchenko wrote: > On Tue, May 31, 2022 at 1:16 PM ChiaEn Wu wrote: > > > > From: Alice Chen > > All below comments are applicable to the rest of the series as well > (one way or another), so please fix all your patches where it

Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-01 Thread Andy Shevchenko
? ... > + if (!count || count > MT6370_MAX_LEDS) { > + dev_err(&pdev->dev, > + "No child node or node count over max led number %lu\n", > count); > + return -EINVAL; return dev_err_probe(...); > + } -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support

2022-06-23 Thread Andy Shevchenko
f; bank_idx = u8_buf[0]; bank_addr = u8_buf[1]; ? ... > + if (ret < 0) > + return ret; > + else if (ret != val_size) Redundant 'else'. > + return -EIO; ... > + bank_idx = *(u8 *)data; > + bank_addr = *(u8 *)(data + 1); As per above. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver

2022-06-23 Thread Andy Shevchenko
ci_data); > + if (IS_ERR(priv->tcpci)) { > + dev_err(&pdev->dev, "Failed to register tcpci port\n"); > + return PTR_ERR(priv->tcpci); return dev_err_probe(); ? > + } ... > + if (ret) { > + dev_err(&pdev->dev, "Failed to allocate irq (%d)\n", ret); > + tcpci_unregister_port(priv->tcpci); > + return ret; Ditto. > + } -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support

2022-06-23 Thread Andy Shevchenko
dev_err(priv->dev, > + "Failed to register (%d) regulator\n", i); > + return PTR_ERR(rdev); return dev_err_probe(...); ? > + } > + > + priv->rdev[i] = rdev; > + } ... > + if (!priv->regmap) { > + dev_err(&pdev->dev, "Failed to init regmap\n"); > + return -ENODEV; > + } return dev_err_probe(...); -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 10/14] iio: adc: mt6370: Add Mediatek MT6370 support

2022-06-23 Thread Andy Shevchenko
if (!regmap) { > + dev_err(&pdev->dev, "Failed to get regmap\n"); > + return -ENODEV; return dev_err_probe(...); > + } ... > + ret = regmap_write(priv->regmap, MT6370_REG_CHG_ADC, 0); > + if (ret) { > + dev_err(&pdev->dev, "Failed to reset ADC\n"); > + return ret; > + } Ditto. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 11/14] power: supply: mt6370: Add Mediatek MT6370 charger driver

2022-06-23 Thread Andy Shevchenko
arly the initialization of these in the ->probe(). Besides that, does destroy_workque() synchronize the actual queue(s)? Mixing devm_ and non-devm_ may lead to a wrong release order that's why it is better to see allocating and destroying resources in one function (they may be wrapped, but should be both of them, seems like you have done it only for the first parts). > + return ret; > +} ... > +static int mt6370_chg_remove(struct platform_device *pdev) > +{ > + struct mt6370_priv *priv = platform_get_drvdata(pdev); > + > + if (priv) { Can you describe when this condition can be false? > + mt6370_chg_enable_irq(priv, "mivr", false); > + cancel_delayed_work_sync(&priv->mivr_dwork); > + destroy_workqueue(priv->wq); > + mutex_destroy(&priv->attach_lock); > + } > + > + return 0; > +} ... > +static struct platform_driver mt6370_chg_driver = { > + .probe = mt6370_chg_probe, > + .remove = mt6370_chg_remove, > + .driver = { > + .name = "mt6370-charger", > + .of_match_table = of_match_ptr(mt6370_chg_of_match), No good use of of_match_ptr(), please drop it. > + }, > +}; -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support

2022-06-28 Thread Andy Shevchenko
On Fri, Jun 24, 2022 at 12:19 PM ChiaEn Wu wrote: > Andy Shevchenko 於 2022年6月24日 週五 凌晨2:01寫道: > > On Thu, Jun 23, 2022 at 1:59 PM ChiaEn Wu wrote: ... > > > obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o > > > obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC)

Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support

2022-06-28 Thread Andy Shevchenko
On Fri, Jun 24, 2022 at 12:33 PM ChiaEn Wu wrote: > Andy Shevchenko 於 2022年6月24日 週五 凌晨2:19寫道: > > On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote: ... > We got a notification from Mark telling us that this patch has been > applied to git. > ( > https://lore.kernel

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Andy Shevchenko
decs/rt5645.c | 4 +--- > sound/soc/codecs/rt5663.c | 4 +--- > sound/soc/codecs/rt5670.c | 4 +--- > sound/soc/codecs/rt5677.c | 4 +--- > sound/soc/codecs/r

Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver

2022-07-04 Thread Andy Shevchenko
v->dev; and here on a single line return dev_err_probe(dev, ...); Ditto for the rest. ... > + ret = mt6370_check_vendor_info(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > +"Failed to check vendor info\n"); This duplicates (with less info given) the message from the callee. ... > + { .compatible = "mediatek,mt6370-tcpc", }, Inner comma is not needed. -- With Best Regards, Andy Shevchenko

Re: [PATCH v4 07/13] mfd: mt6370: Add Mediatek MT6370 support

2022-07-04 Thread Andy Shevchenko
0, 0, "mediatek,mt6370-charger"), > + MFD_CELL_OF("backlight", NULL, NULL, 0, 0, > "mediatek,mt6370-backlight"), > + MFD_CELL_OF("flashlight", NULL, NULL, 0, 0, > "mediatek,mt6370-flashlight"), > + MFD_CELL_OF("indicator", NULL, NULL, 0, 0, > "mediatek,mt6370-indicator"), > + MFD_CELL_OF("tcpc", NULL, NULL, 0, 0, "mediatek,mt6370-tcpc"), > + MFD_CELL_RES("regulator", mt6370_regulator_irqs) Leave a comma here. > +}; -- With Best Regards, Andy Shevchenko

Re: [PATCH v4 09/13] iio: adc: mt6370: Add Mediatek MT6370 support

2022-07-04 Thread Andy Shevchenko
for struct device pointer. > +} ... > +MODULE_DESCRIPTION("MT6370 ADC Drvier"); Driver. Spell check your patches. -- With Best Regards, Andy Shevchenko

Re: [PATCH v4 10/13] power: supply: mt6370: Add Mediatek MT6370 charger driver

2022-07-04 Thread Andy Shevchenko
return 0; > + } > + > + priv->attach = pwr_rdy; > + mutex_unlock(&priv->attach_lock); > + > + if (!queue_work(priv->wq, &priv->bc12_work)) > + dev_err(priv->dev, "bc12 work has already queued\n"); > + > + return 0; > +} -- With Best Regards, Andy Shevchenko

<    1   2   3   4   5   6   7   8   9   10   >