t_sequence[j] >= 0; j++);
Why is i + 1 initial for the j? You may rather access the 'i + 1 +
j'th element in the array...
...
> + par->init_sequence[i], j - i - 1,
...and get rid of the ' - i -1' part here.
--
With Best Regards,
Andy Shevchenko
On Sun, Jul 25, 2021 at 4:59 PM Len Baker wrote:
> On Sat, Jul 24, 2021 at 11:21:04PM +0300, Andy Shevchenko wrote:
> > On Sat, Jul 24, 2021 at 7:05 PM Len Baker wrote:
...
> > > - char msg[128];
> >
> > 128 / 4 = 32. So, this buffer is enough to debug
r to maintain it there.
> Changelog v1 -> v2
> - Add two new commits to clean the code.
> - Use the "%*ph" format specifier instead of strscpy() function (Geert
> Uytterhoeven)
>
> Changelog v2 -> v3
> - Change the initialization of the "j" variabl
from something which has its own domain
At the same time convert users tree-wide to use new headers, although
for the time being include new header back to kernel.h to avoid twisted
indirected includes for existing users.
Signed-off-by: Andy Shevchenko
Reviewed-by: Bjorn Andersson
Acked-by
After the commit 72915994e028 ("video: ssd1307fb: Make use of device
properties") driver does not depend on OF, drop unneeded dependency.
Signed-off-by: Andy Shevchenko
---
drivers/video/fbdev/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/Kconfig b/dri
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 12
1 file changed, 4 insertions(+), 8 dele
gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Jan Sebastian Götte
Cc: Phil Reid
Cc: Nishad Kamdar
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/TODO | 5 -
drivers/staging/fbtft/fb_agm126
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
> > the GPIO descriptor interface") broke GPIO handling completely
On Fri, Apr 16, 2021 at 04:37:48PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
&g
Now, after a few fixes we may consider the conversion to
the GPIO descriptor API is done.
Signed-off-by: Andy Shevchenko
---
v2: new patch split from the bigger fix (Greg)
drivers/staging/fbtft/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/fbtft/TODO b/drivers
sing gpio
descriptor")
Fixes: dbc4f989c878 ("Staging: fbtft: Fix probing of gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Jan Sebastian Götte
Cc: Phil Reid
Cc: Nishad Kamdar
Signed-off-by: Andy Shevchenko
---
v2: sh
the hardware.
Fixes: b2ebd4be6fa1 ("staging: fbtft: add fb_agm1264k-fl driver")
Signed-off-by: Andy Shevchenko
---
v2: new patch split from the bigger fix (Greg)
drivers/staging/fbtft/fb_agm1264k-fl.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/fb
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
v2: no changes
drivers/staging/fbtft/fbtft-core.c | 12
1 file changed, 4 inser
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
> > the GPIO descriptor interface") broke GPIO handling completely
+Cc: Greg.
Greg, can you pick up this one?
The subsystem seems orphaned and I see your name in the git history for the
recent submissions against that driver.
Id is 20210409164140.17337-1-andriy.shevche...@linux.intel.com
On Fri, Apr 09, 2021 at 07:41:40PM +0300, Andy Shevchenko wrote:
> Af
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/ili9341.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/ili9486.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/st7735r.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/ili9225.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/st7586.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/mi0283qt.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/hx8357d.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
On Tue, Apr 27, 2021 at 2:09 PM Greg Kroah-Hartman
wrote:
> On Fri, Apr 16, 2021 at 05:20:41PM +0300, Andy Shevchenko wrote:
> > The custom ->reset() repeats the generic one, replace it.
> >
> > Note, in newer kernels the context of the function is a sleeping one,
> &g
Now, after a few fixes we may consider the conversion to
the GPIO descriptor API is done.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/fbtft/TODO b/drivers/staging/fbtft/TODO
index a9f4802bb6be
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 12
1 file changed, 4 insertions(+), 8 dele
patch 1
- added Rb tag (Phil)
- dropped Fixes tag from the patch 2 (Greg)
Andy Shevchenko (4):
staging: fbtft: Rectify GPIO handling
staging: fbtft: Replace custom ->reset() with generic one
staging: fbtft: Don't spam logs when probe is deferred
staging: fbtft: Update TODO
dr
fbtft: Fix reset assertion when using
gpio descriptor")
Fixes: dbc4f989c878 ("Staging: staging: fbtft: Fix probing of gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: staging: fbtft: Switch to the gpio descriptor
interface")
Cc: Jan Sebastian Götte
Cc: Nishad Kamdar
Signed-o
the hardware.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c
b/drivers/staging/fbtft/fb_agm1264k-fl.c
index b545c2ca80a4..207d578547cd 100644
--- a/drivers/staging/fbtf
On Thu, Apr 29, 2021 at 05:42:44PM +0300, Dan Carpenter wrote:
> On Wed, Apr 28, 2021 at 04:04:14PM +0300, Andy Shevchenko wrote:
> > + if (IS_ERR(*gpiop))
> > + dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s
> > GPIO\n", name);
>
&
road map here.
I have the SPI panel (tiny) based on the ILI9341 and I'm using
actually mi0283qt driver. With yours we will have 3 (three!) drivers
for the same chip. I really do not want this. Without road map on the
prospective of these all drivers, NAK.
--
With Best Regards,
Andy Shevchenko
On Thu, Aug 5, 2021 at 2:18 PM Greg Kroah-Hartman
wrote:
> On Sun, Aug 01, 2021 at 02:40:40PM +0300, Andy Shevchenko wrote:
> > On Sun, Aug 1, 2021 at 11:53 AM Len Baker wrote:
> > >
> > > strcpy() performs no bounds checking on the destination buffer. This
> > &
2:38 PM Greg Kroah-Hartman
wrote:
> On Thu, Aug 05, 2021 at 02:30:35PM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 5, 2021 at 2:18 PM Greg Kroah-Hartman
> > wrote:
> > > On Sun, Aug 01, 2021 at 02:40:40PM +0300, Andy Shevchenko wrote:
> > > > On Sun, Aug
KERNEL_PARAM_FL_UNSAFE)
(above left for the above comment)
...
> +#define __module_param_call_wdata(prefix, name, ops, arg, perm, level,
> flags, data) \
Similar __module_param_call_with_data()
--
With Best Regards,
Andy Shevchenko
kp->data;
So you need space after ')' ?
> + rc = kstrtoul(instr, 0, &inbits);
> + if (rc) {
> + pr_err("set_dyndbg: failed\n");
> + return -EINVAL;
Why not to return rc?
> + }
> + vpr_info("set_dyndbg: input 0x%lx\n", inbits);
> +
> + for (i = 0; !!bitmap[i].prefix; i++) {
Hmm... Why not simply
for (bitmap = ...; bitmap->prefix; bitmap++) {
?
> +
Redundant blank line.
> + sprintf(query, "format '^%s' %cp", bitmap[i].prefix,
> + test_bit(i, &inbits) ? '+' : '-');
snprintf() ?
> +
> + chgct = dynamic_debug_exec_queries(query, kp->mod->name);
> +
> + v2pr_info("bit-%d: %d changes by '%s'\n", i, chgct, query);
> + totct += chgct;
> + }
> + vpr_info("total changes: %d\n", totct);
> + return 0;
> +}
...
> + return scnprintf(buffer, PAGE_SIZE, "%u\n",
> + *((unsigned int *)kp->arg));
One line.
--
With Best Regards,
Andy Shevchenko
missing.
No objections
Acked-by: Andy Shevchenko
> Cc: Andy Shevchenko
> Cc: Andrew Morton
> Cc: Nick Desaulniers
> Cc: Andy Lavr
> Cc: Nathan Chancellor
> Cc: Alexey Dobriyan
> Cc: Stephen Rothwell
> Cc: Bartosz Golaszewski
> Signed-off-by: Kees Cook
> ---
&g
info("query %d: \"%s\" %s\n", i, query, (modname) ?
> modname : "");
too many parentheses. Also may use
modname ?: ""
form (but not all maintainers are happy with it).
...
> + if (!bitmap) {
> + pr_err("set_dyndbg: no bits=>queries map\n");
> + return -EINVAL;
> + }
> + rc = kstrtoul(instr, 0, &inbits);
> + if (rc) {
> + pr_err("set_dyndbg: failed\n");
> + return rc;
> + }
> + vpr_info("set_dyndbg: input 0x%lx\n", inbits);
> +
> + for (i = 0; bitmap->prefix; i++, bitmap++) {
> + snprintf(query, FMT_QUERY_SIZE, "format '^%s' %cp",
> bitmap->prefix,
> +test_bit(i, &inbits) ? '+' : '-');
> +
> + matches = ddebug_exec_queries(query, KP_MOD_NAME);
> +
> + v2pr_info("bit-%d: %d matches on '%s'\n", i, matches, query);
> + totct += matches;
> + }
I'm wondering if there is a room to parse a bitmap as a bitmap.
...
> +int param_get_dyndbg(char *buffer, const struct kernel_param *kp)
> +{
> + return scnprintf(buffer, PAGE_SIZE, "%u\n",
> +*((unsigned int *)kp->arg));
One line?
> +}
--
With Best Regards,
Andy Shevchenko
urn -EINVAL;
> + }
> +
> + rmem->ops = &rmem_swiotlb_ops;
> + pr_info("Reserved memory: created restricted DMA pool at %pa, size
> %ld MiB\n",
> + &rmem->base, (unsigned long)rmem->size / SZ_1M);
Oh là là, besides explicit casting that I believe can be avoided, %ld
!= unsigned long. Can you check the printk-formats.rst document?
> + return 0;
> +}
> +
> +RESERVEDMEM_OF_DECLARE(dma, "restricted-dma-pool", rmem_swiotlb_setup);
> #endif /* CONFIG_DMA_RESTRICTED_POOL */
--
With Best Regards,
Andy Shevchenko
On Fri, Jan 22, 2021 at 04:15:33PM +0100, Patrik Jakobsson wrote:
> On Fri, Jan 22, 2021 at 3:51 PM Andy Shevchenko
> wrote:
> >
> > On Fri, Jan 22, 2021 at 03:16:55PM +0100, Patrik Jakobsson wrote:
> > > On Fri, Jan 22, 2021 at 12:39 PM Andy Shevchenko
> > >
Convert the GMA500 driver to use the new SCU IPC API. This allows us
to get rid of the duplicate PMC IPC implementation which is now covered
in SCU IPC driver.
Signed-off-by: Andy Shevchenko
Acked-by: Linus Walleij
---
drivers/gpu/drm/gma500/Kconfig | 1 +
drivers/gpu/drm/gma500
Since GPIOs are optional we don't need to repeat checks that are done
in the GPIO API. Remove them for good.
Signed-off-by: Andy Shevchenko
Acked-by: Linus Walleij
---
drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
On Fri, Jan 22, 2021 at 03:16:55PM +0100, Patrik Jakobsson wrote:
> On Fri, Jan 22, 2021 at 12:39 PM Andy Shevchenko
> wrote:
> >
> > Convert the GMA500 driver to use the new SCU IPC API. This allows us
> > to get rid of the duplicate PMC IPC implementation which is no
On Tue, Jan 26, 2021 at 4:23 PM Hans de Goede wrote:
>
> Hi,
>
> On 1/26/21 1:38 PM, Andy Shevchenko wrote:
> > Hi guys,
> >
> > This is first part of Intel MID outdated platforms removal. It's collected
> > into
> > immutable branch wi
On Tue, Jan 26, 2021 at 5:25 PM Patrik Jakobsson
wrote:
> On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko
> wrote:
> >
> > Hi guys,
> >
> > This is first part of Intel MID outdated platforms removal. It's collected
> > into
> > immutable branch wi
On Tue, Jan 26, 2021 at 6:55 PM Patrik Jakobsson
wrote:
> On Tue, Jan 26, 2021 at 4:51 PM Andy Shevchenko
> wrote:
> >
> > On Tue, Jan 26, 2021 at 5:25 PM Patrik Jakobsson
> > wrote:
> > > On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko
>
On Tue, Jan 26, 2021 at 8:33 PM Hans de Goede wrote:
> On 1/26/21 6:14 PM, Andy Shevchenko wrote:
> > On Tue, Jan 26, 2021 at 6:55 PM Patrik Jakobsson
> > wrote:
> >> On Tue, Jan 26, 2021 at 4:51 PM Andy Shevchenko
> >> wrote:
> >>> On Tue, Jan 26,
Hi guys,
This is first part of Intel MID outdated platforms removal. It's collected into
immutable branch with a given tag, please pull to yours subsystems.
(All changes are tagged by the respective maintainers)
Thanks,
With Best Regards,
Andy Shevchenko
The following changes since c
OCs and make code easier to read and understand.
> + for (i = 0; i < to_copy; i++)
> + txbuf16[i] = cpu_to_be16(vmem16[i]);
If both of them are 16-bit wide, consider moving this to a helper
which somebody can move to byteorder/generic.h in the future.
> + vmem16 = vmem16 + to_copy;
> + ret = par->fbtftops.write(par, par->txbuf.buf,
> +startbyte_size + to_copy * 2);
> + if (ret < 0)
> + return ret;
> + remain -= to_copy;
> + }
> +
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, Jan 28, 2021 at 4:33 PM Andy Shevchenko
wrote:
> On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
...
> Taking all together you probably need to create a helper and use it
> inside init_display(), like
>
> static int init_tearing_effect_line(struct fbtft_par *par)
> {
On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> On Thu, 28 Jan 2021 16:33:02 +0200
> Andy Shevchenko wrote:
> > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
> >
> > Thanks for your contribution, my comments below.
> >
> > > From: zhangxuezhi
> >
&
On Fri, Jan 29, 2021 at 2:47 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > > On Thu, 28 Jan 2021 16:33:02 +0200
> > > Andy Shevchenko wrote:
> > > > On Thu, Jan
On Fri, Jan 29, 2021 at 2:54 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > > On Thu, 28 Jan 2021 16:33:02 +0200
> > > Andy Shevchenko wrote:
...
> > This one is not like
On Fri, Jan 29, 2021 at 3:56 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
We are almost there, I have no idea what Noralf or others are going to
say though.
...
> Hi, I apologize for what I said in the previous two emails. I missed
> one email you
On Sat, Jan 30, 2021 at 8:39 AM carlis wrote:
> On Fri, 29 Jan 2021 16:26:12 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 3:56 PM carlis wrote:
> > > On Fri, 29 Jan 2021 12:23:08 +0200
> > > Andy Shevchenko wrote:
...
> > > Hi, I apolog
On Tue, Jan 26, 2021 at 4:23 PM Hans de Goede wrote:
> On 1/26/21 1:38 PM, Andy Shevchenko wrote:
> > Hi guys,
> >
> > This is first part of Intel MID outdated platforms removal. It's collected
> > into
> > immutable branch with a given tag, please pull to
On Tue, Jan 26, 2021 at 2:41 PM Andy Shevchenko
wrote:
>
> Hi guys,
>
> This is first part of Intel MID outdated platforms removal. It's collected
> into
> immutable branch with a given tag, please pull to yours subsystems.
>
> (All changes are tagged by the respe
On Wed, Feb 03, 2021 at 11:35:59AM +0100, Hans de Goede wrote:
> On 2/3/21 10:54 AM, Andy Shevchenko wrote:
> > On Tue, Jan 26, 2021 at 4:23 PM Hans de Goede wrote:
> >> On 1/26/21 1:38 PM, Andy Shevchenko wrote:
> >>> Hi guys,
> >>>
> >>&
On Tue, Jan 26, 2021 at 5:25 PM Patrik Jakobsson
wrote:
> On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko
> wrote:
> >
> > Hi guys,
> >
> > This is first part of Intel MID outdated platforms removal. It's collected
> > into
> > immutable branch wi
d can carry the fix as
> necessary. This is now fixed as far as linux-next is concerned, but any
> non trivial conflicts should be mentioned to your upstream maintainer
> when your tree is submitted for merging. You may also want to consider
> cooperating with the maintainer of the co
On Thu, Feb 04, 2021 at 11:57:52AM +0100, Alexandre Belloni wrote:
> On 04/02/2021 11:50:03+0100, Hans de Goede wrote:
> > On 2/4/21 11:36 AM, Daniel Vetter wrote:
> > > On Thu, Feb 4, 2021 at 11:19 AM Patrik Jakobsson
> > > wrote:
> > >> On Wed,
On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko
wrote:
>> Today's linux-next merge of the drivers-x86 tree got a conflict in:
>
> Thanks. I already asked Patrik yesterday day if DRM missed to pull an
> immutable tag I provided. I think they can pull and resolve con
Hi Linus,
This is first part of Intel MID outdated platforms removal. It's collected into
immutable branch with a given tag, please pull to yours subsystems.
(All changes are tagged by the respective maintainers)
Thanks,
With Best Regards,
Andy Shevchenko
The following changes since c
On Fri, Feb 5, 2021 at 3:05 PM Daniel Vetter wrote:
> On Fri, Feb 5, 2021 at 12:14 PM Patrik Jakobsson
> wrote:
> >
> > On Fri, Feb 5, 2021 at 12:07 PM Andy Shevchenko
> > wrote:
> > >
> > > On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko
> > &g
> +
> + *p++ = ' ';
> + *p++ = '(';
> + p = special_hex_number(p, output + sizeof(output) - 2, *fourcc,
> + sizeof(u32));
This is perfectly one line (in this file we have even longer lines).
> + *p++ = ')';
> + *p = '\0';
> +
> + return string(buf, end, output, spec);
> +}
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 8, 2021 at 10:11 PM Sakari Ailus
> wrote:
...
> > +static noinline_for_stack
> > +char *fourcc_string(char *buf, char *end, const u32 *fourcc,
> > + struct printf_sp
On Tue, Feb 09, 2021 at 11:20:32AM +0200, Sakari Ailus wrote:
> On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 8, 2021 at 10:11 PM Sakari Ailus
> > wrote:
...
> > > + %p4cc BG12 little-endian (0x32314742)
> >
> >
On Mon, Feb 08, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 8, 2021 at 10:11 PM Sakari Ailus
> > wrote:
...
> __le32 val;
>
> val = cpu_to_le32(*fourcc & ~BIT(31));
>
> p
hat the drm-misc tree is merged before the pm
> tree (or the drivers-x86 tree). Or you need to include module.h in
> mdfld_output.c before intel_scu_ipc.h (or in intel_scu_ipc.h itself).
Thanks for the report.
I guess the DRM tree should carry this burden, or they can merge the
immutable tag themselve
+Cc: Patrik (JFYI).
On Mon, Feb 15, 2021 at 12:23 PM Andy Shevchenko
wrote:
>
> On Mon, Feb 15, 2021 at 2:45 AM Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced
l free to add
Reviewed-by: From: Andy Shevchenko
after considering addressing below nit-picks.
> Suggested-by: Mauro Carvalho Chehab
> Signed-off-by: Sakari Ailus
> Reviewed-by: Petr Mladek
> Reviewed-by: Sergey Senozhatsky
> ---
> Documentation/core-api/printk-formats
On Mon, Feb 15, 2021 at 01:40:29PM +0200, Sakari Ailus wrote:
> Now that we can print FourCC codes directly using printk, make use of the
> feature in V4L2 core.
Reviewed-by: Andy Shevchenko
See also below.
> Signed-off-by: Sakari Ailus
> ---
> drivers/media/v4l2-core/v4
On Mon, Feb 15, 2021 at 01:40:30PM +0200, Sakari Ailus wrote:
> Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
> large number of temporary variables at the same time.
What a nice clean up!
Reviewed-by: Andy Shevchenko
after addressing nit-picks below.
Side no
We have already few similar implementation and a lot of code that can benefit
of the yesno() helper. Consolidate yesno() helpers under string.h hood.
Signed-off-by: Andy Shevchenko
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c| 6 +-
drivers/gpu/drm/i915/i915_utils.h
We have already an implementation and a lot of code that can benefit
of the onoff() helper. Move it under string.h hood.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_utils.h | 5 -
include/linux/string.h| 5 +
2 files changed, 5 insertions(+), 5 deletions
We have already an implementation and a lot of code that can benefit
of the enableddisabled() helper. Move it under string.h hood.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_utils.h | 5 -
include/linux/string.h| 5 +
2 files changed, 5 insertions(+), 5
+Cc: Sakari and printk people
On Mon, Feb 15, 2021 at 4:28 PM Christian König
wrote:
> Am 15.02.21 um 15:21 schrieb Andy Shevchenko:
> > We have already few similar implementation and a lot of code that can
> > benefit
> > of the yesno() helper. Consolidate yesno() helper
On Tue, Feb 2, 2021 at 3:52 AM Carlis wrote:
> On Mon, 1 Feb 2021 19:40:21 +0200
> Andy Shevchenko wrote:
>
> > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote:
> > > On Fri, 29 Jan 2021 16:26:12 +0200
> > > Andy Shevchenko wrote:
> > > > On Fri,
On Mon, Feb 15, 2021 at 03:56:50PM +0200, Sakari Ailus wrote:
> On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote:
> > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
&
On Mon, Feb 15, 2021 at 04:37:50PM +0200, Jani Nikula wrote:
> On Mon, 15 Feb 2021, Andy Shevchenko
> wrote:
> > We have already few similar implementation and a lot of code that can
> > benefit
> > of the yesno() helper. Consolidate yesno() helpers under string.h hood
On Mon, Feb 15, 2021 at 07:26:55PM +0200, Sakari Ailus wrote:
> On Mon, Feb 15, 2021 at 03:41:14PM +0200, Andy Shevchenko wrote:
> ...
> > > + seq_printf(m, "\t\tuapi: [FB:%d] ", fb ? fb->base.id : 0);
> > > + if (fb)
> > > + seq_printf(
plane_visibility(plane_state), DRM_RECT_FP_ARG(&src),
DRM_RECT_ARG(&dst), rot_str);
This will show logical parts separately and clear view on what would be printed
when !fb. Also it uses seq_puts() without any needs for formatting.
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, May 3, 2021 at 7:46 PM Greg Kroah-Hartman
wrote:
> On Wed, Apr 28, 2021 at 04:04:12PM +0300, Andy Shevchenko wrote:
> > Fixes: 92e3e884887c ("Staging: staging: fbtft: Fix GPIO handling")
> > Fixes: b918d1c27066 ("Staging: staging: fbtft: Fix reset
sertion when using gpio
descriptor")
Fixes: dbc4f989c878 ("Staging: fbtft: Fix probing of gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Jan Sebastian Götte
Cc: Nishad Kamdar
Signed-off-by: Andy Shevchenko
Revi
(Dan)
- new patch to support orientation on HX8347d
In v3:
- added staging prefix (Fabio)
- slightly amended commit message in the patch 1
- added Rb tag (Phil)
- dropped Fixes tag from the patch 2 (Greg)
Andy Shevchenko (5):
staging: fbtft: Rectify GPIO handling
staging: fbtft: Don't spam
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Nishad Kamdar
Signed-off-by:
Now, after a few fixes we may consider the conversion to
the GPIO descriptor API is done.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/fbtft/TODO b/drivers/staging/fbtft/TODO
index a9f4802bb6be
the hardware.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c
b/drivers/staging/fbtft/fb_agm1264k-fl.c
index b545c2ca80a4..207d578547cd 100644
--- a/drivers/staging/fbtf
Himax HX8347d has non-standard register to control orientation.
Add support for different orientation values.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fb_hx8347d.c | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
970,6 +14970,7 @@ int intel_modeset_init_nogem(struct
> drm_i915_private *i915)
>
> drm_modeset_lock_all(dev);
> intel_modeset_setup_hw_state(dev, dev->mode_config.acquire_ctx);
> + intel_acpi_assign_connector_fwnodes(i915);
> drm_modeset_unlock_all(dev);
>
> for_each_intel_crtc(dev, crtc) {
> --
> 2.31.1
>
>
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 0261801af62c..d20bfd7576ed 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -1254,6 +1254,8 @@ struct drm_connector {
> struct device *kdev;
> /** @attr: sysf
index d20bfd7576ed..ae377354e48e 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -1267,6 +1267,14 @@ struct drm_connector {
> */
> struct list_head head;
>
> + /**
> +* @global_connector_list_entry:
> +*
> +* Connector entry in the global connector-list, used by
> +* drm_connector_find_by_fwnode().
> +*/
> + struct list_head global_connector_list_entry;
> +
> /** @base: base KMS object */
> struct drm_mode_object base;
>
> --
> 2.31.1
>
>
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue, May 4, 2021 at 2:53 PM Hans de Goede wrote:
> On 5/4/21 10:00 AM, Andy Shevchenko wrote:
> > On Monday, May 3, 2021, Hans de Goede > <mailto:hdego...@redhat.com>> wrote:
...
> > +struct drm_connector *drm_connector_find_by_fwnode(struct
On Wed, May 5, 2021 at 12:07 PM Hans de Goede wrote:
> On 5/4/21 9:52 AM, Andy Shevchenko wrote:
> > On Monday, May 3, 2021, Hans de Goede > <mailto:hdego...@redhat.com>> wrote:
...
> > + fwnode = device_get_next_child_node(kdev, fwnode);
&g
On Wed, May 5, 2021 at 12:28 PM Hans de Goede wrote:
> On 5/5/21 11:17 AM, Andy Shevchenko wrote:
> > On Wed, May 5, 2021 at 12:07 PM Hans de Goede wrote:
> >> On 5/4/21 9:52 AM, Andy Shevchenko wrote:
> >>> On Monday, May 3, 2021, Hans de Goede >>&
On Wed, May 5, 2021 at 1:30 PM Hans de Goede wrote:
> On 5/5/21 12:02 PM, Andy Shevchenko wrote:
...
> But we do really need to document the behavior better here
> in the kdoc for fwnode_get_next_child_node() and
> device_get_next_child_node().
Totally agree!
> of_get_next_chi
device_for_each_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.
Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support")
Cc: Brian Masney
Cc: Dan Murphy
Signed-off-by: Andy Shevchenko
---
dri
from something which has its own domain
At the same time convert users tree-wide to use new headers, although
for the time being include new header back to kernel.h to avoid twisted
indirected includes for existing users.
Signed-off-by: Andy Shevchenko
Reviewed-by: Bjorn Andersson
Acked-by
ually needed for such patches.
That's why I don't like churn produced by people who often even didn't
compile their useful contributions.
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
%pM).
But I'm not insisting on them, consider it like just my 2 cents to the
discussion.
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, Dec 10, 2020 at 03:55:27PM +0200, Sakari Ailus wrote:
> On Thu, Dec 10, 2020 at 03:05:02PM +0200, Andy Shevchenko wrote:
> > On Thu, Dec 10, 2020 at 2:16 PM Petr Mladek wrote:
> > > On Fri 2020-11-13 12:54:41, Sakari Ailus wrote:
> > > > Add a printk modifie
j = i + 1;
> while (par->init_sequence[j] >= 0) {
> sprintf(str, "0x%02X ",
> par->init_sequence[j]);
--
With Best Regards,
Andy Shevchenko
1 - 100 of 1131 matches
Mail list logo
