Re: Re: [PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread alexious
> Am 03.12.23 um 18:16 schrieb Zhipeng Lu: > > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every > > following error-handling path. However, in the error-handling of > > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, > > resulting in a memleak in this function.

Re: Re: [PATCH] drm/lima: fix a memleak in lima_heap_alloc

2024-01-16 Thread alexious
> Thanks for the fix. As the error handling gets longer and duplicated, > could you rearrange them like the lima_gem_submit(): > err_out2: > dma_unmap_sgtable(dev, &sgt, DMA_BIDIRECTIONAL, 0); > err_out1: > kfree(bo->base.sgt); > bo->base.sgt = NULL; > err_out0: > sg_free_table(&sgt