RE: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-14 Thread Zhang, Jack (Jian)
; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily Cc: Zhang, Jack (Jian) Subject: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak re-insert Bailing jobs to avoid memory leak. V2: move re-insert step to drm/scheduler logic V3: add panfrost's return value for bailing jobs in ca

RE: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-16 Thread Zhang, Jack (Jian)
[AMD Public Use] Ping -Original Message- From: Zhang, Jack (Jian) Sent: Monday, March 15, 2021 1:24 PM To: Jack Zhang ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Koenig, Christian ; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily ; Rob Herring ; Tomeu Vizoso

RE: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-16 Thread Zhang, Jack (Jian)
b to avoid memleak [AMD Public Use] Ping -Original Message----- From: Zhang, Jack (Jian) Sent: Monday, March 15, 2021 1:24 PM To: Jack Zhang ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Koenig, Christian ; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily ; Rob Herring ; To

Re: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-17 Thread Zhang, Jack (Jian)
[AMD Official Use Only - Internal Distribution Only] Hi,Andrey, Good catch,I will expore this corner case and give feedback soon~ Best, Jack From: Grodzovsky, Andrey Sent: Wednesday, March 17, 2021 10:50:59 PM To: Christian König ; Zhang, Jack (Jian) ; dri

RE: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-18 Thread Zhang, Jack (Jian)
mp;sched->job_list_lock); + atomic_set(&in_reset, 0); //reset in_reset when the first thread finished tdr } Thanks, Jack From: amd-gfx On Behalf Of Zhang, Jack (Jian) Sent: Wednesday, March 17, 2021 11:11 PM To: Christian König ; dri-devel@lists.freedesktop.org; amd-...@lists.freedeskto

RE: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-25 Thread Zhang, Jack (Jian)
*sched; struct drm_sched_fence *s_fence; @@ -198,6 +199,7 @@ struct drm_sched_job { enum drm_sched_priority s_priority; struct drm_sched_entity *entity; struct dma_fence_cb cb; + }; From: Grodzovsky, Andrey Sent: Friday, March 19, 2021

RE: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-25 Thread Zhang, Jack (Jian)
will start to consider other drm-driver if it will influence other drivers(except for amdgpu). Best, Jack -Original Message- From: Steven Price Sent: Monday, March 22, 2021 11:29 PM To: Zhang, Jack (Jian) ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Koenig

RE: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-25 Thread Zhang, Jack (Jian)
add a fence and get/put to that fence rather than using an explicit refcount? And another concerns? Thanks, Jack -Original Message- From: Grodzovsky, Andrey Sent: Friday, March 26, 2021 12:32 AM To: Zhang, Jack (Jian) ; Christian König ; dri-devel@lists.freedesktop.org; amd-...@li

RE: [PATCH] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-11 Thread Zhang, Jack (Jian)
[AMD Official Use Only - Internal Distribution Only] Hi, Andrey, ok, I have changed it and uploaded V2 patch. Thanks, Jack -Original Message- From: Grodzovsky, Andrey Sent: Friday, March 12, 2021 1:04 PM To: Alex Deucher ; Zhang, Jack (Jian) ; Maling list - DRI developers Cc: amd