From: Yonatan Maman
The `nouveau_dmem_copy_one` function ensures that the copy push command is
sent to the device firmware but does not track whether it was executed
successfully.
In the case of a copy error (e.g., firmware or hardware failure), the
copy push command will be sent via the
On 30/09/2024 14:20, Danilo Krummrich wrote:
External email: Use caution opening links or attachments
On Mon, Sep 23, 2024 at 01:54:58PM +, Yonatan Maman wrote:
A copy push command might fail, causing `migrate_to_ram` to return a
dirty HIGH_USER page to the user.
This exposes a
From: Yonatan Maman
When `nouveau_dmem_copy_one` is called, the following error occurs:
[272146.675156] nouveau :06:00.0: fifo: PBDMA9: 0004 [HCE_PRIV]
ch 1 0300 3386
This indicates that a copy push command triggered a Host Copy Engine
Privileged error on channel 1 (Copy Engine
From: Yonatan Maman
Date: Mon, 7 Oct 2024 14:48:26 +0300
Subject: [PATCH v2 0/2] drm/nouveau/dmem: Fix Memory Leaking and Device
Channels configuration
This patch series addresses two critical issues in the Nouveau driver
related to device channels, error handling, and memory leaks.
- Memory
From: Yonatan Maman
This patch series addresses two critical issues in the Nouveau driver
related to device channels, error handling, and sensitive data leaks.
- Vulnerability in migrate_to_ram: The migrate_to_ram function might
return a dirty HIGH_USER page when a copy push command (FW
From: Yonatan Maman
The `nouveau_dmem_copy_one` function ensures that the copy push command is
sent to the device firmware but does not track whether it was executed
successfully.
In the case of a copy error (e.g., firmware or hardware failure), the
copy push command will be sent via the
From: Yonatan Maman
When `nouveau_dmem_copy_one` is called, the following error occurs:
[272146.675156] nouveau :06:00.0: fifo: PBDMA9: 0004 [HCE_PRIV]
ch 1 0300 3386
This indicates that a copy push command triggered a Host Copy Engine
Privileged error on channel 1 (Copy Engine
From: Yonatan Maman
When `nouveau_dmem_copy_one` is called, the following error occurs:
[272146.675156] nouveau :06:00.0: fifo: PBDMA9: 0004 [HCE_PRIV]
ch 1 0300 3386
This indicates that a copy push command triggered a Host Copy Engine
Privileged error on channel 1 (Copy Engine
From: Yonatan Maman
A copy push command might fail, causing `migrate_to_ram` to return a
dirty HIGH_USER page to the user.
This exposes a security vulnerability in the nouveau driver. To prevent
memory leaks in `migrate_to_ram` upon a copy error, allocate a zero
page for the destination page
From: Yonatan Maman
This patch series addresses two critical issues in the Nouveau driver
related to device channels, error handling, and sensitive data leaks.
- Vulnerability in migrate_to_ram: The migrate_to_ram function might
return a dirty HIGH_USER page when a copy push command (FW
On 30/09/2024 14:09, Danilo Krummrich wrote:
External email: Use caution opening links or attachments
Hi Yonatan,
On Mon, Sep 23, 2024 at 01:54:56PM +, Yonatan Maman wrote:
When `nouveau_dmem_copy_one` is called, the following error occurs:
[272146.675156] nouveau :06:00.0: fifo
, 2024 at 06:23:45PM +0300, Yonatan Maman wrote:
From: Yonatan Maman
hmm_range_fault() natively triggers a page fault on device private
pages, migrating them to RAM.
That "natively" above doesn't make sense to me.
What I meant to convey is that hmm_range_fault() by default triggered a
On 16/10/2024 7:23, Christoph Hellwig wrote:
On Tue, Oct 15, 2024 at 06:23:44PM +0300, Yonatan Maman wrote:
From: Yonatan Maman
This patch series aims to enable Peer-to-Peer (P2P) DMA access in
GPU-centric applications that utilize RDMA and private device pages. This
enhancement is crucial
On 16/10/2024 8:12, Alistair Popple wrote:
Yonatan Maman writes:
From: Yonatan Maman
Enabling Peer-to-Peer DMA (P2P DMA) access in GPU-centric applications
is crucial for minimizing data transfer overhead (e.g., for RDMA use-
case).
This change aims to enable that capability for
On 18/10/2024 10:26, Zhu Yanjun wrote:
External email: Use caution opening links or attachments
在 2024/10/16 17:16, Yonatan Maman 写道:
On 16/10/2024 7:23, Christoph Hellwig wrote:
On Tue, Oct 15, 2024 at 06:23:44PM +0300, Yonatan Maman wrote:
From: Yonatan Maman
This patch series aims
From: Yonatan Maman
Enabling Peer-to-Peer DMA (P2P DMA) access in GPU-centric applications
is crucial for minimizing data transfer overhead (e.g., for RDMA use-
case).
This change aims to enable that capability for Nouveau over HMM device
private pages. P2P DMA for private device pages allows
From: Yonatan Maman
Add Peer-to-Peer (P2P) DMA request for hmm_range_fault calling,
utilizing capabilities introduced in mm/hmm. By setting
range.default_flags to HMM_PFN_REQ_FAULT | HMM_PFN_REQ_TRY_P2P, HMM
attempts to initiate P2P DMA connections for device private pages
(instead of page fault
From: Yonatan Maman
ATS (Address Translation Services) mainly utilized to optimize PCI
Peer-to-Peer transfers and prevent bus failures. This change employed
ATS usage for ODP memory, to optimize DMA P2P for ODP memory. (e.g DMA
P2P for private device pages - ODP memory).
Signed-off-by: Yonatan
From: Yonatan Maman
hmm_range_fault() natively triggers a page fault on device private
pages, migrating them to RAM. In some cases, such as with RDMA devices,
the migration overhead between the device (e.g., GPU) and the CPU, and
vice-versa, significantly damages performance. Thus, enabling Peer
From: Yonatan Maman
This patch series aims to enable Peer-to-Peer (P2P) DMA access in
GPU-centric applications that utilize RDMA and private device pages. This
enhancement is crucial for minimizing data transfer overhead by allowing
the GPU to directly expose device private page data to devices
From: Yonatan Maman
hmm_range_fault() by default triggered a page fault on device private
when HMM_PFN_REQ_FAULT flag was set. pages, migrating them to RAM. In some
cases, such as with RDMA devices, the migration overhead between the
device (e.g., GPU) and the CPU, and vice-versa, significantly
From: Yonatan Maman
Based on: Provide a new two step DMA mapping API patchset
https://lore.kernel.org/kvm/20241114170247.ga5...@lst.de/T/#t
This patch series aims to enable Peer-to-Peer (P2P) DMA access in
GPU-centric applications that utilize RDMA and private device pages. This
enhancement
From: Yonatan Maman
Enabling Peer-to-Peer DMA (P2P DMA) access in GPU-centric applications
is crucial for minimizing data transfer overhead (e.g., for RDMA use-
case).
This change aims to enable that capability for Nouveau over HMM device
private pages. P2P DMA for private device pages allows
From: Yonatan Maman
Add Peer-to-Peer (P2P) DMA request for hmm_range_fault calling,
utilizing capabilities introduced in mm/hmm. By setting
range.default_flags to HMM_PFN_REQ_FAULT | HMM_PFN_REQ_TRY_P2P, HMM
attempts to initiate P2P DMA connections for device private pages
(instead of page fault
From: Yonatan Maman
Handle P2P DMA mapping errors when the transaction requires traversing
an inaccessible host bridge that is not in the allowlist:
- In `populate_mtt`, if a P2P mapping fails, the `HMM_PFN_ALLOW_P2P` flag
is cleared only for the PFNs that returned a mapping error.
- In
From: Yonatan Maman
ATS (Address Translation Services) mainly utilized to optimize PCI
Peer-to-Peer transfers and prevent bus failures. This change employed
ATS usage for ODP memory, to optimize DMA P2P for ODP memory. (e.g DMA
P2P for private device pages - ODP memory).
Signed-off-by: Yonatan
From: Yonatan Maman
hmm_range_fault() by default triggered a page fault on device private
when HMM_PFN_REQ_FAULT flag was set. pages, migrating them to RAM. In some
cases, such as with RDMA devices, the migration overhead between the
device (e.g., GPU) and the CPU, and vice-versa, significantly
From: Yonatan Maman
Enabling Peer-to-Peer DMA (P2P DMA) access in GPU-centric applications
is crucial for minimizing data transfer overhead (e.g., for RDMA use-
case).
This change aims to enable that capability for Nouveau over HMM device
private pages. P2P DMA for private device pages allows
From: Yonatan Maman
Add Peer-to-Peer (P2P) DMA request for hmm_range_fault calling,
utilizing capabilities introduced in mm/hmm. By setting
range.default_flags to HMM_PFN_REQ_FAULT | HMM_PFN_REQ_TRY_P2P, HMM
attempts to initiate P2P DMA connections for device private pages
(instead of page fault
From: Yonatan Maman
This patch series aims to enable Peer-to-Peer (P2P) DMA access in
GPU-centric applications that utilize RDMA and private device pages. This
enhancement reduces data transfer overhead by allowing the GPU to directly
expose device private page data to devices such as NICs
From: Yonatan Maman
Add support for P2P for MLX5 NIC devices with automatic fallback to
standard DMA when P2P mapping fails.
The change introduces P2P DMA requests by default using the
HMM_PFN_ALLOW_P2P flag. If P2P mapping fails with -EFAULT error, the
operation is retried without the P2P flag
From: Yonatan Maman
ATS (Address Translation Services) mainly utilized to optimize PCI
Peer-to-Peer transfers and prevent bus failures. This change employed
ATS usage for ODP memory, to optimize DMA P2P for ODP memory. (e.g DMA
P2P for private device pages - ODP memory).
Signed-off-by: Yonatan
On 21/07/2025 9:59, Christoph Hellwig wrote:
On Fri, Jul 18, 2025 at 02:51:08PM +0300, Yonatan Maman wrote:
From: Yonatan Maman
hmm_range_fault() by default triggered a page fault on device private
when HMM_PFN_REQ_FAULT flag was set. pages, migrating them to RAM. In some
cases, such as
On 21/07/2025 10:00, Christoph Hellwig wrote:
On Fri, Jul 18, 2025 at 02:51:09PM +0300, Yonatan Maman wrote:
+ .get_dma_pfn_for_device = nouveau_dmem_get_dma_pfn,
Please don't shorten the method name prefix in the implementation
symbol name, as that makes reading / refactorin
On 20/07/2025 13:30, Leon Romanovsky wrote:
External email: Use caution opening links or attachments
On Fri, Jul 18, 2025 at 02:51:07PM +0300, Yonatan Maman wrote:
From: Yonatan Maman
This patch series aims to enable Peer-to-Peer (P2P) DMA access in
GPU-centric applications that utilize
35 matches
Mail list logo
