[PATCH 7/8] drm/msm/dp: Retry Link Training 2 with lower pattern

2024-11-29 Thread Xiangxu Yin
Add a mechanism to retry Link Training 2 by lowering the pattern level when the link training #2 first attempt fails. This approach enhances compatibility, particularly addressing issues caused by certain hub configurations. Signed-off-by: Xiangxu Yin --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 34

[PATCH 8/8] drm/msm/dp: Support external GPIO HPD with 3rd pinctrl chip

2024-11-29 Thread Xiangxu Yin
or falling) rather than state interrupts, the GPIO state must be read during the first DP bridge HPD enablement. This ensures the current connection state is determined and a hot plug event is reported accordingly. Signed-off-by: Xiangxu Yin --- drivers/gpu/drm/msm/dp/dp_display.c | 83

[PATCH 3/8] phy: qcom: qmp-usbc: Add DP phy mode support on QCS615

2024-11-29 Thread Xiangxu Yin
into the layout structure. Signed-off-by: Xiangxu Yin --- drivers/phy/qualcomm/phy-qcom-qmp-dp-phy.h |1 + drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 1453 2 files changed, 1254 insertions(+), 200 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-dp

[PATCH 2/8] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add DP support for QCS615

2024-11-29 Thread Xiangxu Yin
Declare the DP QMP PHY present on the Qualcomm QCS615 platforms. Signed-off-by: Xiangxu Yin --- .../bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp

[PATCH 4/8] drm/msm/dp: Add DisplayPort support for QCS615

2024-11-29 Thread Xiangxu Yin
The Qualcomm QCS615 platform comes with a DisplayPort controller use the same base offset as sc7180. add support for this in DP driver. Signed-off-by: Xiangxu Yin --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b

[PATCH 1/8] dt-bindings: display/msm: Document DP on QCS615

2024-11-29 Thread Xiangxu Yin
Document the DP hardware found on the Qualcomm QCS615 platform. Signed-off-by: Xiangxu Yin --- .../devicetree/bindings/display/msm/dp-controller.yaml | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b

[PATCH 0/8] Add DisplayPort support for QCS615 platform

2024-11-29 Thread Xiangxu Yin
This series aims to extend the USB-C PHY to support DP mode and enable DisplayPort on the Qualcomm QCS615 platform. The devicetree modification for DisplayPort on QCS615 will be provided in a future patch. Signed-off-by: Xiangxu Yin --- Xiangxu Yin (8): dt-bindings: display/msm: Document

[PATCH 5/8] drm/msm/dp: Add support for lane mapping configuration

2024-11-29 Thread Xiangxu Yin
sical lane mapping sequence, ensuring correct lane assignment for non-default configurations. Signed-off-by: Xiangxu Yin --- drivers/gpu/drm/msm/dp/dp_catalog.c | 11 +-- drivers/gpu/drm/msm/dp/dp_catalog.h | 2 +- drivers/gpu/drm/msm/dp/dp_ctrl.c| 2 +- drivers/gpu/drm/msm/dp/dp_pa

[PATCH 6/8] drm/msm/dp: Add maximum width limitation for modes

2024-11-29 Thread Xiangxu Yin
Introduce a maximum width constraint for modes during validation. This ensures that the modes are filtered based on hardware capabilities, specifically addressing the line buffer limitations of individual pipes. Signed-off-by: Xiangxu Yin --- drivers/gpu/drm/msm/dp/dp_display.c | 3

Re: [PATCH 5/8] drm/msm/dp: Add support for lane mapping configuration

2024-12-03 Thread Xiangxu Yin
On 11/29/2024 9:50 PM, Dmitry Baryshkov wrote: > On Fri, 29 Nov 2024 at 09:59, Xiangxu Yin wrote: >> >> Add the ability to configure lane mapping for the DP controller. This is >> required when the platform's lane mapping does not follow the default >> order (0,

Re: [PATCH 6/8] drm/msm/dp: Add maximum width limitation for modes

2024-12-03 Thread Xiangxu Yin
On 11/29/2024 9:52 PM, Dmitry Baryshkov wrote: > On Fri, 29 Nov 2024 at 09:59, Xiangxu Yin wrote: >> >> Introduce a maximum width constraint for modes during validation. This >> ensures that the modes are filtered based on hardware capabilities, >> specifically

Re: [PATCH 7/8] drm/msm/dp: Retry Link Training 2 with lower pattern

2024-12-03 Thread Xiangxu Yin
On 11/29/2024 9:53 PM, Dmitry Baryshkov wrote: > On Fri, 29 Nov 2024 at 09:59, Xiangxu Yin wrote: >> >> Add a mechanism to retry Link Training 2 by lowering the pattern level >> when the link training #2 first attempt fails. This approach enhances >> compatibili

Re: [PATCH 6/8] drm/msm/dp: Add maximum width limitation for modes

2024-12-03 Thread Xiangxu Yin
On 12/2/2024 5:32 PM, Dmitry Baryshkov wrote: > On Mon, 2 Dec 2024 at 11:05, Xiangxu Yin wrote: >> >> >> >> On 11/29/2024 9:52 PM, Dmitry Baryshkov wrote: >>> On Fri, 29 Nov 2024 at 09:59, Xiangxu Yin wrote: >>>> >>>> Introduce

Re: [PATCH 3/8] phy: qcom: qmp-usbc: Add DP phy mode support on QCS615

2024-12-03 Thread Xiangxu Yin
On 11/29/2024 4:18 PM, Krzysztof Kozlowski wrote: > On 29/11/2024 08:57, Xiangxu Yin wrote: >> Extended DP support for QCS615 USB or DP phy. Differentiated between >> USBC and DP PHY using the match table’s type, dynamically generating >> different types of cfg and lay

Re: [PATCH 3/8] phy: qcom: qmp-usbc: Add DP phy mode support on QCS615

2024-12-06 Thread Xiangxu Yin
On 11/29/2024 10:33 PM, Dmitry Baryshkov wrote: > On Fri, 29 Nov 2024 at 09:59, Xiangxu Yin wrote: >> >> Extended DP support for QCS615 USB or DP phy. Differentiated between >> USBC and DP PHY using the match table’s type, dynamically generating >> different types o

Re: [PATCH 5/8] drm/msm/dp: Add support for lane mapping configuration

2024-12-06 Thread Xiangxu Yin
On 12/2/2024 6:46 PM, Dmitry Baryshkov wrote: > On Mon, Dec 02, 2024 at 04:40:05PM +0800, Xiangxu Yin wrote: >> >> >> On 11/29/2024 9:50 PM, Dmitry Baryshkov wrote: >>> On Fri, 29 Nov 2024 at 09:59, Xiangxu Yin wrote: >>>> >>>> Add the a

Re: [PATCH 6/8] drm/msm/dp: Add maximum width limitation for modes

2024-12-09 Thread Xiangxu Yin
On 12/7/2024 4:13 AM, Abhinav Kumar wrote: > > > On 12/3/2024 5:58 AM, Dmitry Baryshkov wrote: >> On Tue, Dec 03, 2024 at 03:41:53PM +0800, Xiangxu Yin wrote: >>> >>> >>> On 12/2/2024 5:32 PM, Dmitry Baryshkov wrote: >>&g

Re: [PATCH 3/8] phy: qcom: qmp-usbc: Add DP phy mode support on QCS615

2024-12-11 Thread Xiangxu Yin
On 12/11/2024 5:46 PM, Dmitry Baryshkov wrote: > On Wed, Dec 11, 2024 at 08:46:16AM +0800, Xiangxu Yin wrote: >> >> >> On 12/10/2024 11:09 PM, Dmitry Baryshkov wrote: >>> On Thu, Dec 05, 2024 at 08:31:24PM +0200, Dmitry Baryshkov wrote: >>>> On Thu, Dec

Re: [PATCH 3/8] phy: qcom: qmp-usbc: Add DP phy mode support on QCS615

2024-12-10 Thread Xiangxu Yin
On 12/10/2024 11:09 PM, Dmitry Baryshkov wrote: > On Thu, Dec 05, 2024 at 08:31:24PM +0200, Dmitry Baryshkov wrote: >> On Thu, Dec 05, 2024 at 09:26:47PM +0800, Xiangxu Yin wrote: >>> >>> >>> On 11/29/2024 10:33 PM, Dmitry Baryshkov wrote: >>&g

Re: [PATCH v3] drm/msm/dpu: filter out too wide modes if no 3dmux is present

2024-12-10 Thread Xiangxu Yin
a...@quicinc.com > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 13 + > 1 file changed, 13 insertions(+) > Tested-by: Xiangxu Yin # QCS615 > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index > 9f6ffd344693ecfb6

Re: [PATCH 3/8] phy: qcom: qmp-usbc: Add DP phy mode support on QCS615

2024-12-18 Thread Xiangxu Yin
On 12/12/2024 3:15 AM, Dmitry Baryshkov wrote: > On Wed, Dec 11, 2024 at 08:50:02PM +0800, Xiangxu Yin wrote: >> >> >> On 12/11/2024 5:46 PM, Dmitry Baryshkov wrote: >>> On Wed, Dec 11, 2024 at 08:46:16AM +0800, Xiangxu Yin wrote: >>>> >>>&g

Re: [PATCH 5/8] drm/msm/dp: Add support for lane mapping configuration

2024-12-19 Thread Xiangxu Yin
On 12/5/2024 7:40 PM, Dmitry Baryshkov wrote: > On Thu, 5 Dec 2024 at 13:28, Xiangxu Yin wrote: >> >> >> >> On 12/2/2024 6:46 PM, Dmitry Baryshkov wrote: >>> On Mon, Dec 02, 2024 at 04:40:05PM +0800, Xiangxu Yin wrote: >>>> >>>> >

Re: [PATCH 3/8] phy: qcom: qmp-usbc: Add DP phy mode support on QCS615

2025-03-21 Thread Xiangxu Yin
On 3/6/2025 5:25 AM, Dmitry Baryshkov wrote: > On Wed, Mar 05, 2025 at 06:20:45PM +0800, Xiangxu Yin wrote: >> >> >> On 12/20/2024 8:01 AM, Dmitry Baryshkov wrote: >>> On Wed, Dec 18, 2024 at 08:55:54PM +0800, Xiangxu Yin wrote: >>>> >>>&

Re: [PATCH 5/8] drm/msm/dp: Add support for lane mapping configuration

2025-03-05 Thread Xiangxu Yin
On 12/20/2024 5:45 AM, Dmitry Baryshkov wrote: > On Thu, Dec 19, 2024 at 06:36:38PM +0800, Xiangxu Yin wrote: >> >> >> On 12/5/2024 7:40 PM, Dmitry Baryshkov wrote: >>> On Thu, 5 Dec 2024 at 13:28, Xiangxu Yin wrote: >>>> >>>> >>&g

Re: [PATCH 3/8] phy: qcom: qmp-usbc: Add DP phy mode support on QCS615

2025-03-05 Thread Xiangxu Yin
On 12/20/2024 8:01 AM, Dmitry Baryshkov wrote: > On Wed, Dec 18, 2024 at 08:55:54PM +0800, Xiangxu Yin wrote: >> >> >> On 12/12/2024 3:15 AM, Dmitry Baryshkov wrote: >>> On Wed, Dec 11, 2024 at 08:50:02PM +0800, Xiangxu Yin wrote: >>>> >>>&

Re: [PATCH 5/8] drm/msm/dp: Add support for lane mapping configuration

2025-05-19 Thread Xiangxu Yin
On 3/6/2025 5:14 AM, Dmitry Baryshkov wrote: > On Wed, Mar 05, 2025 at 06:16:45PM +0800, Xiangxu Yin wrote: >> >> >> On 12/20/2024 5:45 AM, Dmitry Baryshkov wrote: >>> On Thu, Dec 19, 2024 at 06:36:38PM +0800, Xiangxu Yin wrote: >>>> >>>

Re: [PATCH 7/8] drm/msm/dp: Retry Link Training 2 with lower pattern

2025-07-09 Thread Xiangxu Yin
On 5/28/2025 4:49 AM, Konrad Dybcio wrote: > On 12/3/24 3:07 PM, Dmitry Baryshkov wrote: >> On Tue, Dec 03, 2024 at 04:13:22PM +0800, Xiangxu Yin wrote: >>> >>> >>> On 11/29/2024 9:53 PM, Dmitry Baryshkov wrote: >>>> On Fri, 29 Nov 2024 at 09

[PATCH v2 04/13] phy: qcom: qmp-usbc: Rename USB structs and reorganize layout

2025-07-22 Thread Xiangxu Yin
USB-specific members out of the shared `qmp_usbc` structure. No functional changes; this is a preparatory cleanup for DP PHY support. Signed-off-by: Xiangxu Yin --- drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 304 +-- 1 file changed, 163 insertions(+), 141 deletions

[PATCH v2 05/13] phy: qcom: qmp-usbc: Introduce PHY type enum for USB/DP support

2025-07-22 Thread Xiangxu Yin
to prepare for future DP support. No functional changes and serves as a preparatory step for adding DP PHY support. Signed-off-by: Xiangxu Yin --- drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 195 --- 1 file changed, 126 insertions(+), 69 deletions(-) diff --git a

[PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY

2025-07-22 Thread Xiangxu Yin
multiplexing. The binding describes the required clocks, resets, TCSR configuration, and clock/PHY cells for proper integration. Signed-off-by: Xiangxu Yin --- .../bindings/phy/qcom,qcs615-qmp-dp-phy.yaml | 111 + 1 file changed, 111 insertions(+) diff --git a

[PATCH v2 03/13] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: support dual TCSR registers

2025-07-22 Thread Xiangxu Yin
rfaces, respectively. This is required for platforms that consume the PHY clock and select PHY mode dynamically. Signed-off-by: Xiangxu Yin --- .../bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml| 28 +- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/Documen

[PATCH v2 00/13] Add DisplayPort support for QCS615 platform

2025-07-22 Thread Xiangxu Yin
This series aims to extend the USB-C PHY to support DP mode and enable DisplayPort on the Qualcomm QCS615 platform. The devicetree modification for DisplayPort on QCS615 will be provided in a future patch. Signed-off-by: Xiangxu Yin --- Changes in v2: - Add new binding qcom,qcs615-qmp-dp

[PATCH v2 06/13] phy: qcom: qmp-usbc: Add DP PHY struct definitions

2025-07-22 Thread Xiangxu Yin
, including mapped registers, DP options from driver, and dynamically configured clocks. - `qmp_usbc_dp_offsets`: Platform-defined base offsets for DP sub-blocks. These structures mirror the USB counterparts and enable clean separation of DP logic. Signed-off-by: Xiangxu Yin --- drivers/phy

[PATCH v2 01/13] dt-bindings: display/msm: Document DP on QCS615

2025-07-22 Thread Xiangxu Yin
The QCS615 platform is based on the SM6150 SoC. Since the DP hardware is shared with SM6150, the compatible string qcom,sm6150-dp is used to represent the DP controller on QCS615. Signed-off-by: Xiangxu Yin --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file

[PATCH v2 09/13] phy: qcom: qmp-usbc: Wire up DP PHY ops and flow for QCS615

2025-07-22 Thread Xiangxu Yin
the QMP combo PHY design. Signed-off-by: Xiangxu Yin --- drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 486 ++- 1 file changed, 484 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c index

[PATCH v2 13/13] drm/msm/dp: Add support for lane mapping configuration

2025-07-22 Thread Xiangxu Yin
The DP PHY supports polarity inversion (PN swap) but does not support lane swapping. Therefore, lane mapping should be handled in the DP controller domain using REG_DP_LOGICAL2PHYSICAL_LANE_MAPPING. Signed-off-by: Xiangxu Yin --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 10 ++--- drivers/gpu/drm/msm/dp/dp_

[PATCH v2 07/13] phy: qcom: qmp-usbc: Add QCS615 DP PHY configuration and init data

2025-07-22 Thread Xiangxu Yin
Introduce QCS615 hardware-specific configuration for DP PHY mode, including register offsets, initialization tables, voltage swing and pre-emphasis settings, and regulator definitions. Signed-off-by: Xiangxu Yin --- drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 148

[PATCH v2 08/13] phy: qcom: qmp-usbc: Implement DP PHY bring-up flow for QCS615

2025-07-22 Thread Xiangxu Yin
: Xiangxu Yin --- drivers/phy/qualcomm/phy-qcom-qmp-dp-phy.h | 1 + drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 256 + 2 files changed, 257 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-dp-phy.h b/drivers/phy/qualcomm/phy-qcom-qmp-dp-phy.h index

[PATCH v2 10/13] phy: qcom: qmp-usbc: Track PHYs for standalone DP/USB3.0 handling

2025-07-22 Thread Xiangxu Yin
same platform but operate independently. Signed-off-by: Xiangxu Yin --- drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 51 ++-- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp

[PATCH v2 11/13] phy: qcom: qmp-usbc: Add QCS615 DP PHY compatible

2025-07-22 Thread Xiangxu Yin
place - Compatible handling is aligned with USB3.0 PHY via type-based dispatch - Supports coexistence with USB3.0 PHY through mutual exclusion based on shared TCSR region This enables end-to-end support for DP PHY mode on QCS615 platforms. Signed-off-by: Xiangxu Yin --- drivers/phy/qualcomm

[PATCH v2 12/13] drm/msm/dp: Add DisplayPort support for QCS615

2025-07-22 Thread Xiangxu Yin
The Qualcomm QCS615 platform comes with a DisplayPort controller use the same base offset as sc7180. add support for this in DP driver. Reviewed-by: Dmitry Baryshkov Signed-off-by: Xiangxu Yin --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH 7/8] drm/msm/dp: Retry Link Training 2 with lower pattern

2025-07-20 Thread Xiangxu Yin
On 7/19/2025 5:43 PM, Dmitry Baryshkov wrote: > On Wed, Jul 09, 2025 at 05:16:02PM +0800, Xiangxu Yin wrote: >> >> On 5/28/2025 4:49 AM, Konrad Dybcio wrote: >>> On 12/3/24 3:07 PM, Dmitry Baryshkov wrote: >>>> On Tue, Dec 03, 2024 at 04:13:22PM +0800, Xia

Re: [PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY

2025-07-22 Thread Xiangxu Yin
On 7/22/2025 4:38 PM, Dmitry Baryshkov wrote: > On Tue, Jul 22, 2025 at 03:22:03PM +0800, Xiangxu Yin wrote: >> Introduce device tree binding documentation for the Qualcomm QMP DP PHY >> on QCS615 SoCs. This PHY supports DisplayPort functionality and is >> designed to opera

Re: [PATCH v2 01/13] dt-bindings: display/msm: Document DP on QCS615

2025-07-22 Thread Xiangxu Yin
On 7/22/2025 5:23 PM, Krzysztof Kozlowski wrote: > On 22/07/2025 11:16, Dmitry Baryshkov wrote: >> On 22/07/2025 12:13, Krzysztof Kozlowski wrote: >>> On 22/07/2025 09:22, Xiangxu Yin wrote: >>>> The QCS615 platform is based on the SM6150 SoC. Since the DP hardw

Re: [PATCH v2 12/13] drm/msm/dp: Add DisplayPort support for QCS615

2025-07-28 Thread Xiangxu Yin
On 7/22/2025 5:21 PM, Krzysztof Kozlowski wrote: > On 22/07/2025 09:22, Xiangxu Yin wrote: >> The Qualcomm QCS615 platform comes with a DisplayPort controller use the >> same base offset as sc7180. add support for this in DP driver. >> >> Reviewed-by: Dmitry Baryshkov

Re: [PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY

2025-07-30 Thread Xiangxu Yin
On 7/31/2025 2:35 AM, Dmitry Baryshkov wrote: > On Wed, Jul 30, 2025 at 04:53:16PM +0800, Xiangxu Yin wrote: >> On 7/22/2025 8:41 PM, Dmitry Baryshkov wrote: >>> On Tue, Jul 22, 2025 at 08:05:06PM +0800, Xiangxu Yin wrote: >>>> On 7/22/2025 4:38 PM, Dmitry Baryshk

Re: [PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY

2025-07-30 Thread Xiangxu Yin
On 7/22/2025 8:41 PM, Dmitry Baryshkov wrote: > On Tue, Jul 22, 2025 at 08:05:06PM +0800, Xiangxu Yin wrote: >> On 7/22/2025 4:38 PM, Dmitry Baryshkov wrote: >>> On Tue, Jul 22, 2025 at 03:22:03PM +0800, Xiangxu Yin wrote: >>>> Introduce device tree binding documen

Re: [PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY

2025-07-31 Thread Xiangxu Yin
On 8/1/2025 1:13 AM, Dmitry Baryshkov wrote: > On 31/07/2025 08:06, Xiangxu Yin wrote: >> >> On 7/31/2025 2:35 AM, Dmitry Baryshkov wrote: >>> On Wed, Jul 30, 2025 at 04:53:16PM +0800, Xiangxu Yin wrote: >>>> On 7/22/2025 8:41 PM, Dmitry Baryshkov wrote: >

Re: [PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY

2025-08-01 Thread Xiangxu Yin
On 8/1/2025 3:30 PM, Dmitry Baryshkov wrote: > On Fri, Aug 01, 2025 at 11:57:50AM +0800, Xiangxu Yin wrote: >> On 8/1/2025 1:13 AM, Dmitry Baryshkov wrote: >>> On 31/07/2025 08:06, Xiangxu Yin wrote: >>>> On 7/31/2025 2:35 AM, Dmitry Baryshkov wrote: >>&g