Signed-off-by: Val Packett
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
index 9bcb40a64..e2c6ba26f 100644
--- a/drivers/gpu
On the RK3066, there is a bit that must be cleared on flush, otherwise
we do not get display output (at least for RGB).
Signed-off-by: Val Packett
Cc: sta...@vger.kernel.org
---
Hi! This was required to get display working on an old RK3066 tablet,
along with the next tiny patch in the series
On Sun, May 19 2024 at 09:59:47 +02:00:00, Greg KH
wrote:
On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote:
On the RK3066, there is a bit that must be cleared on flush,
otherwise
we do not get display output (at least for RGB).
What commit id does this fix?
I guess
old Rockchip RK3066 tablet, and it did fix
the problem :) Thank you.
Tested-by: Val Packett
On the RK3066, there is a bit that must be cleared, otherwise
the picture does not show up on the display (at least for RGB).
Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions")
Cc: sta...@vger.kernel.org
Signed-off-by: Val Packett
---
v2: doing this on vblank makes
The RK3066 does have RGB display output, so it should be marked as such.
Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions")
Cc: sta...@vger.kernel.org
Signed-off-by: Val Packett
---
v2: expanded commit message
---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 +
1 fi
On Mon, May 27 2024 at 22:43:18 +02:00:00, Heiko Stübner
wrote:
Hi Val,
Am Montag, 27. Mai 2024, 09:16:33 CEST schrieb Val Packett:
On the RK3066, there is a bit that must be cleared, otherwise
the picture does not show up
on the display (at least for RGB).
Fixes: f4a6de8 (&quo
do it, since it indicates exactly that: that the hardware is done
with the frame.
This seems to be a redundant synchronization mechanism that was removed
in later iterations of the VOP hardware block.
Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions")
Cc: sta...@vger.kern
The RK3066 does have RGB display output, so it should be marked as such.
Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions")
Cc: sta...@vger.kernel.org
Signed-off-by: Val Packett
---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 +
1 file changed, 1 insertion(+)
di
This tiny patch series makes the changes required to enable the RGB
display output on the Rockchip RK3066 SoC. Final version as discussed.
Val Packett (2):
drm/rockchip: vop: clear DMA stop bit on RK3066
drm/rockchip: vop: enable VOP_FEATURE_INTERNAL_RGB on RK3066
drivers/gpu/drm/rockchip
: rockchip: vop: add rk3066 vop definitions")
Cc: sta...@vger.kernel.org
Signed-off-by: Val Packett
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 +
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 +
3 files changed, 6 insertions(+)
The RK3066 does have RGB display output, so it should be marked as such.
Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions")
Cc: sta...@vger.kernel.org
Signed-off-by: Val Packett
---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 +
1 file changed, 1 insertion(+)
di
On Mon, May 27 2024 at 20:11:49 -03:00:00, Val Packett
wrote:
The RK3066 VOP sets a dma_stop bit when it's done scanning out a frame
and needs the driver to acknowledge that by clearing the bit.
So unless we clear it "between" frames, the RGB output only shows
noise
instead
Cannot confirm which variant exactly it is, as the EDID alphanumeric data
contains '0RGNR' <0x80> 'NE14QDM' and ends there; but it's 60 Hz and with
touch.
I do not have access to datasheets for these panels, so the timing is
a guess that was tested to work fine on t
s how it worked before.
Fixes: f2db78e37fe7 ("drm/dp: Modify drm_edp_backlight_set_level")
Signed-off-by: Val Packett
---
Video evidence (haha): https://files.catbox.moe/sp1g9v.mp4
As this fix is tiny, if you prefer to fix it differently somehow, feel free to
just redo it yourselves
0 00 00 fe 00 30
52 47 4e 52 80 4e 45 31 34 51 44 4d 00 00 00 00
00 02 41 31 a8 00 01 00 00 1a 41 0a 20 20 00 8f
Signed-off-by: Val Packett
---
drivers/gpu/drm/panel/panel-edp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-edp.c
b/drivers/gpu/drm/panel
0 00 00 fe 00 30
52 47 4e 52 80 4e 45 31 34 51 44 4d 00 00 00 00
00 02 41 31 a8 00 01 00 00 1a 41 0a 20 20 00 8f
Signed-off-by: Val Packett
---
drivers/gpu/drm/panel/panel-edp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-edp.c
b/drivers/gpu/drm/panel
17 matches
Mail list logo