Re: [PATCH v8 11/34] gpu: host1x: Add runtime PM and OPP support

2021-08-17 Thread Ulf Hansson
On Tue, 17 Aug 2021 at 03:30, Dmitry Osipenko wrote: > > Add runtime PM and OPP support to the Host1x driver. It's required for > enabling system-wide DVFS and supporting dynamic power management using > a generic power domain. For the starter we will keep host1x always-on > because dynamic power

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-18 Thread Ulf Hansson
On Wed, 18 Aug 2021 at 08:27, Viresh Kumar wrote: > > On 18-08-21, 09:22, Dmitry Osipenko wrote: > > 18.08.2021 08:58, Viresh Kumar пишет: > > > What about calling dev_pm_opp_set_rate(dev, clk_get_rate(dev)) here > > > instead ? That will work, right ? The advantage is it works without > > > any s

Re: [PATCH v8 11/34] gpu: host1x: Add runtime PM and OPP support

2021-08-18 Thread Ulf Hansson
On Tue, 17 Aug 2021 at 16:03, Thierry Reding wrote: > > On Tue, Aug 17, 2021 at 02:04:38PM +0200, Ulf Hansson wrote: > > On Tue, 17 Aug 2021 at 03:30, Dmitry Osipenko wrote: > > > > > > Add runtime PM and OPP support to the Host1x driver. It's required for

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-18 Thread Ulf Hansson
On Wed, 18 Aug 2021 at 11:14, Viresh Kumar wrote: > > On 18-08-21, 10:29, Ulf Hansson wrote: > > Me and Dmitry discussed adding a new genpd callback for this. I agreed > > that it seems like a reasonable thing to add, if he insists. > > > > The intent was t

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-18 Thread Ulf Hansson
On Wed, 18 Aug 2021 at 11:41, Ulf Hansson wrote: > > On Wed, 18 Aug 2021 at 11:14, Viresh Kumar wrote: > > > > On 18-08-21, 10:29, Ulf Hansson wrote: > > > Me and Dmitry discussed adding a new genpd callback for this. I agreed > > > that it seems like a re

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-18 Thread Ulf Hansson
On Wed, 18 Aug 2021 at 11:50, Viresh Kumar wrote: > > On 18-08-21, 11:41, Ulf Hansson wrote: > > On Wed, 18 Aug 2021 at 11:14, Viresh Kumar wrote: > > > What we need here is just configure. So something like this then: > > > > &

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-19 Thread Ulf Hansson
On Wed, 18 Aug 2021 at 17:43, Dmitry Osipenko wrote: > > 18.08.2021 13:08, Ulf Hansson пишет: > > On Wed, 18 Aug 2021 at 11:50, Viresh Kumar wrote: > >> > >> On 18-08-21, 11:41, Ulf Hansson wrote: > >>> On Wed, 18 Aug 2021 at 11:14, Viresh Kumar >

Re: [PATCH v8 19/34] pwm: tegra: Add runtime PM and OPP support

2021-08-19 Thread Ulf Hansson
On Thu, 19 Aug 2021 at 15:21, Thierry Reding wrote: > > On Tue, Aug 17, 2021 at 04:27:39AM +0300, Dmitry Osipenko wrote: > > The PWM on Tegra belongs to the core power domain and we're going to > > enable GENPD support for the core domain. Now PWM must be resumed using > > runtime PM API in order

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-19 Thread Ulf Hansson
On Thu, 19 Aug 2021 at 08:17, Viresh Kumar wrote: > > On 18-08-21, 18:55, Dmitry Osipenko wrote: > > 18.08.2021 12:41, Ulf Hansson пишет: > > > > Either way gives the equal result. The new callback allows to remove the > > boilerplate dev_pm_opp_set_rate(clk_get_r

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-20 Thread Ulf Hansson
On Thu, 19 Aug 2021 at 21:35, Dmitry Osipenko wrote: > > 19.08.2021 16:07, Ulf Hansson пишет: > > On Wed, 18 Aug 2021 at 17:43, Dmitry Osipenko wrote: > >> > >> 18.08.2021 13:08, Ulf Hansson пишет: > >>> On Wed, 18 Aug 2021 at 11:50, Viresh Kumar >

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-20 Thread Ulf Hansson
On Fri, 20 Aug 2021 at 07:18, Viresh Kumar wrote: > > On 19-08-21, 16:55, Ulf Hansson wrote: > > Right, that sounds reasonable. > > > > We already have pm_genpd_opp_to_performance_state() which translates > > an OPP to a performance state. This function invokes the

Re: [PATCH v8 07/34] clk: tegra: Support runtime PM and power domain

2021-08-20 Thread Ulf Hansson
[...] > > > > I'm creating platform device for the clocks that require DVFS. These > > clocks don't use regulator, they are attached to the CORE domain. > > GENPD framework manages the performance state, aggregating perf votes > > from each device, i.e. from each clock individually. > > > > You wa

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-23 Thread Ulf Hansson
[...] > We have three components comprising PM on Tegra: > > 1. Power gate > 2. Clock state > 3. Voltage state > > GENPD on/off represents the 'power gate'. > > Clock and reset are controlled by device drivers using clk and rst APIs. > > Volta

Re: [PATCH v2 01/14] opp: Add devres wrapper for dev_pm_opp_set_clkname

2021-03-12 Thread Ulf Hansson
On Fri, 12 Mar 2021 at 06:33, Viresh Kumar wrote: > > On 11-03-21, 22:20, Dmitry Osipenko wrote: > > +struct opp_table *devm_pm_opp_set_clkname(struct device *dev, const char > > *name) > > +{ > > + struct opp_table *opp_table; > > + int err; > > + > > + opp_table = dev_pm_opp_set_clk

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-06 Thread Ulf Hansson
On Thu, 5 Nov 2020 at 11:40, Viresh Kumar wrote: > > On 05-11-20, 11:34, Ulf Hansson wrote: > > I am not objecting about scaling the voltage through a regulator, > > that's fine to me. However, encoding a power domain as a regulator > > (even if it may seem like a r

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-06 Thread Ulf Hansson
On Thu, 5 Nov 2020 at 11:06, Viresh Kumar wrote: > > On 05-11-20, 10:45, Ulf Hansson wrote: > > + Viresh > > Thanks Ulf. I found a bug in OPP core because you cc'd me here :) Happy to help. :-) > > > On Thu, 5 Nov 2020 at 00:44, Dmitry Osipenko wrote: > >

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-06 Thread Ulf Hansson
+ Viresh On Thu, 5 Nov 2020 at 00:44, Dmitry Osipenko wrote: > > Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces > power consumption and heating of the Tegra chips. Tegra SoC has multiple > hardware units which belong to a core power domain of the SoC and share > the core

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-06 Thread Ulf Hansson
On Thu, 5 Nov 2020 at 12:13, Viresh Kumar wrote: > > On 05-11-20, 11:56, Ulf Hansson wrote: > > On Thu, 5 Nov 2020 at 11:40, Viresh Kumar wrote: > > > Btw, how do we identify if it is a power domain or a regulator ? > > To be honest, I was a bit afraid and embarrassed

Re: [PATCH v1 01/30] dt-bindings: host1x: Document OPP and voltage regulator properties

2020-11-12 Thread Ulf Hansson
On Thu, 5 Nov 2020 at 00:44, Dmitry Osipenko wrote: > > Document new DVFS OPP table and voltage regulator properties of the > Host1x bus and devices sitting on the bus. > > Signed-off-by: Dmitry Osipenko > --- > .../display/tegra/nvidia,tegra20-host1x.txt | 56 +++ > 1 file cha

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-12 Thread Ulf Hansson
On Sun, 8 Nov 2020 at 13:19, Dmitry Osipenko wrote: > > 05.11.2020 18:22, Dmitry Osipenko пишет: > > 05.11.2020 12:45, Ulf Hansson пишет: > > ... > >> I need some more time to review this, but just a quick check found a > >> few potential issues... > >

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-15 Thread Ulf Hansson
On Thu, 12 Nov 2020 at 23:14, Dmitry Osipenko wrote: > > 12.11.2020 23:43, Thierry Reding пишет: > >> The difference in comparison to using voltage regulator directly is > >> minimal, basically the core-supply phandle is replaced is replaced with > >> a power-domain phandle in a device tree. > > T

Re: [PATCH v13 20/35] mtd: rawnand: tegra: Add runtime PM and OPP support

2021-10-19 Thread Ulf Hansson
On Sun, 17 Oct 2021 at 10:38, Dmitry Osipenko wrote: > > 01.10.2021 18:01, Ulf Hansson пишет: > > On Fri, 1 Oct 2021 at 16:35, Dmitry Osipenko wrote: > >> > >> 01.10.2021 17:24, Ulf Hansson пишет: > >>> On Mon, 27 Sept 2021 at 00:42, Dmitry Osipen

Re: [PATCH v14 01/39] soc/tegra: Enable runtime PM during OPP state-syncing

2021-10-27 Thread Ulf Hansson
;t work > while RPM is disabled. Instead of replicating the boilerplate RPM-enable > code around OPP helper for each driver, let's make OPP helper to take care > of enabling it. > > Signed-off-by: Dmitry Osipenko Just a minor nitpick, see below. Nevertheless feel free to add: Re

Re: [PATCH v14 29/39] soc/tegra: regulators: Prepare for suspend

2021-10-27 Thread Ulf Hansson
On Tue, 26 Oct 2021 at 00:46, Dmitry Osipenko wrote: > > Depending on hardware version, Tegra SoC may require a higher voltages > during resume from system suspend, otherwise hardware will crash. Set > SoC voltages to a nominal levels during suspend. > > Signed-off-by: Dmitry Osipenko I don't un

Re: [PATCH v14 00/39] NVIDIA Tegra power management patches for 5.17

2021-10-27 Thread Ulf Hansson
gt; for simplicity. > > Changelog: > > v14: - Fixed missing runtime PM syncing on removal of drivers, which was >spotted by Ulf Hansson in v13. > > - clk-device driver now resumes RPM on system suspend instead of >preparing clock which it backs. This wa

Re: [PATCH v13 06/35] clk: tegra: Support runtime PM and power domain

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > The Clock-and-Reset controller resides in a core power domain on NVIDIA > Tegra SoCs. In order to support voltage scaling of the core power domain, > we hook up DVFS-capable clocks to the core GENPD for managing of the > GENPD's performanc

Re: [PATCH v13 02/35] soc/tegra: Add devm_tegra_core_dev_init_opp_table_common()

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > Only couple drivers need to get the -ENODEV error code and majority of > drivers need to explicitly initialize the performance state. Add new > common helper which sets up OPP table for these drivers. > > Signed-off-by: Dmitry Osipenko > -

Re: [PATCH v13 09/35] gpu: host1x: Add runtime PM and OPP support

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > Add runtime PM and OPP support to the Host1x driver. For the starter we > will keep host1x always-on because dynamic power management require a major > refactoring of the driver code since lot's of code paths are missing the > RPM handling

Re: [PATCH v13 11/35] drm/tegra: dc: Support OPP and SoC core voltage scaling

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > Add OPP and SoC core voltage scaling support to the display controller > driver. This is required for enabling system-wide DVFS on pre-Tegra186 > SoCs. > > Tested-by: Peter Geis # Ouya T30 > Tested-by: Paul Fertser # PAZ00 T20 > Tested-by

Re: [PATCH v13 13/35] drm/tegra: gr2d: Support generic power domain and runtime PM

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > Add runtime power management and support generic power domains. > > Tested-by: Peter Geis # Ouya T30 > Tested-by: Paul Fertser # PAZ00 T20 > Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 > Tested-by: Matt Merhar # Ouya T30 > Signe

Re: [PATCH v13 14/35] drm/tegra: gr3d: Support generic power domain and runtime PM

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > Add runtime power management and support generic power domains. > > Tested-by: Peter Geis # Ouya T30 > Tested-by: Paul Fertser # PAZ00 T20 > Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 > Tested-by: Matt Merhar # Ouya T30 > Signe

Re: [PATCH v13 17/35] bus: tegra-gmi: Add runtime PM and OPP support

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > The GMI bus on Tegra belongs to the core power domain and we're going to > enable GENPD support for the core domain. Now GMI must be resumed using > runtime PM API in order to initialize the GMI power state. Add runtime PM > and OPP support

Re: [PATCH v13 20/35] mtd: rawnand: tegra: Add runtime PM and OPP support

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > The NAND on Tegra belongs to the core power domain and we're going to > enable GENPD support for the core domain. Now NAND must be resumed using > runtime PM API in order to initialize the NAND power state. Add runtime PM > and OPP support

Re: [PATCH v13 00/35] NVIDIA Tegra power management patches for 5.16

2021-10-01 Thread Ulf Hansson
On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > This series adds runtime PM support to Tegra drivers and enables core > voltage scaling for Tegra20/30 SoCs, resolving overheating troubles. > > All patches in this series are interdependent and should go via Tegra tree. > > Changelog: > >

Re: [PATCH v13 13/35] drm/tegra: gr2d: Support generic power domain and runtime PM

2021-10-01 Thread Ulf Hansson
On Fri, 1 Oct 2021 at 16:29, Dmitry Osipenko wrote: > > 01.10.2021 16:39, Ulf Hansson пишет: > > On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > >> > >> Add runtime power management and support generic power domains. > >> > >> Tested

Re: [PATCH v13 20/35] mtd: rawnand: tegra: Add runtime PM and OPP support

2021-10-01 Thread Ulf Hansson
On Fri, 1 Oct 2021 at 16:35, Dmitry Osipenko wrote: > > 01.10.2021 17:24, Ulf Hansson пишет: > > On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > >> > >> The NAND on Tegra belongs to the core power domain and we're going to > >> enable GENPD s

Re: [PATCH v13 00/35] NVIDIA Tegra power management patches for 5.16

2021-10-01 Thread Ulf Hansson
On Fri, 1 Oct 2021 at 16:41, Dmitry Osipenko wrote: > > 01.10.2021 17:36, Ulf Hansson пишет: > > On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > >> > >> This series adds runtime PM support to Tegra drivers and enables core > >> voltage scaling for

Re: [PATCH v13 13/35] drm/tegra: gr2d: Support generic power domain and runtime PM

2021-10-04 Thread Ulf Hansson
On Fri, 1 Oct 2021 at 21:00, Dmitry Osipenko wrote: > > 01.10.2021 17:55, Ulf Hansson пишет: > > On Fri, 1 Oct 2021 at 16:29, Dmitry Osipenko wrote: > >> > >> 01.10.2021 16:39, Ulf Hansson пишет: > >>> On Mon, 27 Sept 2021 at 00:42, Dmitry Osipen

Re: [PATCH v13 13/35] drm/tegra: gr2d: Support generic power domain and runtime PM

2021-10-05 Thread Ulf Hansson
On Mon, 4 Oct 2021 at 17:57, Dmitry Osipenko wrote: > > 04.10.2021 14:01, Ulf Hansson пишет: > > On Fri, 1 Oct 2021 at 21:00, Dmitry Osipenko wrote: > >> > >> 01.10.2021 17:55, Ulf Hansson пишет: > >>> On Fri, 1 Oct 2021 at 16:29, Dmitry Osipenko

Re: [PATCH v13 06/35] clk: tegra: Support runtime PM and power domain

2021-10-05 Thread Ulf Hansson
On Sat, 2 Oct 2021 at 22:44, Dmitry Osipenko wrote: > > 01.10.2021 15:32, Ulf Hansson пишет: > >> +static __maybe_unused int tegra_clock_pm_suspend(struct device *dev) > >> +{ > >> + struct tegra_clk_device *clk_dev = dev_get_drvdata(dev); > >&g

Re: [PATCH v13 06/35] clk: tegra: Support runtime PM and power domain

2021-10-06 Thread Ulf Hansson
On Wed, 6 Oct 2021 at 00:19, Dmitry Osipenko wrote: > > 05.10.2021 16:10, Ulf Hansson пишет: > > On Sat, 2 Oct 2021 at 22:44, Dmitry Osipenko wrote: > >> > >> 01.10.2021 15:32, Ulf Hansson пишет: > >>>> +static __maybe_unused

Re: [PATCH v13 06/35] clk: tegra: Support runtime PM and power domain

2021-10-06 Thread Ulf Hansson
On Wed, 6 Oct 2021 at 00:43, Dmitry Osipenko wrote: > > 06.10.2021 01:19, Dmitry Osipenko пишет: > ... > > I reproduced the OFF problem by removing the clk prepare/unprepare from > > the suspend/resume of the clk driver and making some extra changes to > > clock tree topology and etc to trigger th

Re: [PATCH v13 06/35] clk: tegra: Support runtime PM and power domain

2021-10-07 Thread Ulf Hansson
On Thu, 7 Oct 2021 at 01:21, Dmitry Osipenko wrote: > > 07.10.2021 01:01, Dmitry Osipenko пишет: > > 07.10.2021 00:14, Dmitry Osipenko пишет: > >> 06.10.2021 15:43, Ulf Hansson пишет: > >>> On Wed, 6 Oct 2021 at 00:43, Dmitry Osipenko wrote: > >>>>

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Ulf Hansson
Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Florian Fainelli > Cc: Vladimir Oltean > Cc: Kalle Valo > Cc: Viresh Kumar > Cc: Stephen Boyd > C

Re: [PATCH v14 20/39] pwm: tegra: Add runtime PM and OPP support

2021-10-29 Thread Ulf Hansson
On Fri, 29 Oct 2021 at 17:20, Dmitry Osipenko wrote: > > 26.10.2021 01:40, Dmitry Osipenko пишет: > > + ret = devm_pm_runtime_enable(&pdev->dev); > > + if (ret) > > + return ret; > > + > > + ret = devm_tegra_core_dev_init_opp_table_common(&pdev->dev); > > + if (ret) > >

Re: [PATCH 03/11] mmc: bcm2835: stop setting chan_config->slave_id

2021-11-15 Thread Ulf Hansson
Arnd Bergmann Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/mmc/host/bcm2835.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c > index 8c2361e66277..463b707d9e99 100644 > --- a/drivers/mmc/host

Re: [PATCH v2 04/11] mmc: bcm2835: stop setting chan_config->slave_id

2021-11-23 Thread Ulf Hansson
: Nicolas Saenz Julienne > Signed-off-by: Arnd Bergmann I think I acked the previous version, but nevermind: Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/mmc/host/bcm2835.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/bcm2835.c b/drive

Re: [PATCH v2 31/48] soc/tegra: regulators: Support Core domain state syncing

2021-01-13 Thread Ulf Hansson
-regulator voltage syncing once the state of domain is synced, at > this point the Core voltage is allowed to go lower. > > Signed-off-by: Dmitry Osipenko This looks reasonable to me, feel free to add: Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/so

Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver

2021-01-13 Thread Ulf Hansson
On Thu, 17 Dec 2020 at 19:07, Dmitry Osipenko wrote: > > NVIDIA Tegra SoCs have multiple power domains, each domain corresponds > to an external SoC power rail. Core power domain covers vast majority of > hardware blocks within a Tegra SoC. The voltage of a power domain should > be set to a value

Re: [RFC v2 08/11] arm64: dts: sdm845: Add ufs opps and power-domains

2019-05-14 Thread Ulf Hansson
On Wed, 20 Mar 2019 at 10:50, Rajendra Nayak wrote: > > Add the additional power domain and the OPP table for ufs on sdm845 > so the driver can set the appropriate performance state of the > power domain while setting the clock rate. > > Signed-off-by: Rajendra Nayak > --- > arch/arm64/boot/dts/

Re: [PATCH v2 3/3] drm/i915: Move to new PM core fields

2018-12-18 Thread Ulf Hansson
On Mon, 17 Dec 2018 at 15:22, Vincent Guittot wrote: > > On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote: > > > > On Fri, 14 Dec 2018 at 15:22, Vincent Guittot > > wrote: > > > > > > With jiffies been replaced by raw ns in PM core accounting, 915 dr

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
On Wed, 19 Dec 2018 at 14:26, Vincent Guittot wrote: > > On Wed, 19 Dec 2018 at 11:43, Ulf Hansson wrote: > > > > On Wed, 19 Dec 2018 at 11:34, Vincent Guittot > > wrote: > > > > > > On Wed, 19 Dec 2018 at 11:21, Ulf Hansson wrote: > > > &

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
On Wed, 19 Dec 2018 at 11:34, Vincent Guittot wrote: > > On Wed, 19 Dec 2018 at 11:21, Ulf Hansson wrote: > > > > On Wed, 19 Dec 2018 at 11:11, Vincent Guittot > > wrote: > > > > > > On Wed, 19 Dec 2018 at 10:58, Ulf Hansson wrote: > > > >

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
On Wed, 19 Dec 2018 at 11:11, Vincent Guittot wrote: > > On Wed, 19 Dec 2018 at 10:58, Ulf Hansson wrote: > > > > On Tue, 18 Dec 2018 at 15:55, Vincent Guittot > > wrote: > > > > > > Some drivers (like i915/drm) need to get the accounted suspended

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
On Tue, 18 Dec 2018 at 15:55, Vincent Guittot wrote: > > Some drivers (like i915/drm) need to get the accounted suspended time. > pm_runtime_accounted_time_get() will return the suspended or active > accounted time until now. I suggest to leave the active accounted time out for now. At least unti

Re: [PATCH v2 1/3] PM/pm_runtime: move autosuspend on hrtimer

2018-12-20 Thread Ulf Hansson
a bss dec hex filename > 133042996805276 402768 20512343138fe57 vmlinux > > Signed-off-by: Vincent Guittot If not too late, feel free to add: Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/base/power/runtime.c | 63 > +++

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
On Wed, 19 Dec 2018 at 11:43, Ulf Hansson wrote: > > On Wed, 19 Dec 2018 at 11:34, Vincent Guittot > wrote: > > > > On Wed, 19 Dec 2018 at 11:21, Ulf Hansson wrote: > > > > > > On Wed, 19 Dec 2018 at 11:11, Vincent Guittot > > > wrote: > >

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
[...] > Hold on. I am wondering if the drm driver could use the existing > pm_runtime_autosuspend_expiration() function instead. Isn't that > really that what is needed? No, it can't. I don't know why I thought that, sorry for the noise. U ___ dri-deve

Re: [PATCH v4 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2018-12-21 Thread Ulf Hansson
On Thu, 20 Dec 2018 at 15:17, Vincent Guittot wrote: > > From: Thara Gopinath > > This patch replaces jiffies based accounting for runtime_active_time > and runtime_suspended_time with ktime base accounting. This makes the > runtime debug counters inline with genpd and other pm subsytems which >

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-21 Thread Ulf Hansson
On Wed, 19 Dec 2018 at 17:52, Vincent Guittot wrote: > > On Wed, 19 Dec 2018 at 17:36, Ulf Hansson wrote: > > > > On Wed, 19 Dec 2018 at 14:26, Vincent Guittot > > wrote: > > > > > > On Wed, 19 Dec 2018 at 11:43, Ulf Hansson wrote: > > > >

Re: [PATCH v4 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-21 Thread Ulf Hansson
On Thu, 20 Dec 2018 at 15:16, Vincent Guittot wrote: > > Some drivers (like i915/drm) needs to get the accounted suspended time. > pm_runtime_suspended_time() will return the suspended accounted time > in ns unit. > > Signed-off-by: Vincent Guittot Reviewed-by: Ulf Hansson

Re: [PATCH v4 2/3] drm/i915: Move on the new pm runtime interface

2018-12-21 Thread Ulf Hansson
ng to the new runtime PM API. I think the changelog deserves to state that, in some simple way. > > Signed-off-by: Vincent Guittot Other than the minor things above: Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/gpu/drm/i915/i915_pmu.c | 16 ++-- &g

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-21 Thread Ulf Hansson
[...] > > > > Re-thinking this a bit from my earlier comments - and by following the > > > > above reasoning, it sounds like this better belongs in the > > > > driver/subsystem, without requiring any data from the core. > > > > > > > > The driver/subsystem could just store a timestamp in it's > >

Re: [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2018-12-21 Thread Ulf Hansson
vices can start to be initialized) called from rest_init() via > kernel_init_freeable() and do_basic_setup(). > > Signed-off-by: Thara Gopinath > [move from ktime to raw nsec] > Signed-off-by: Vincent Guittot Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/bas

Re: [PATCH 00/41] OMAP1 full multiplatform conversion

2022-04-19 Thread Ulf Hansson
On Tue, 19 Apr 2022 at 15:37, Arnd Bergmann wrote: > > From: Arnd Bergmann > > This is the full series for converting OMAP1 to multiplatform, rebased > from my 2019 attempt to do the same thing. The soc tree contains simpler > patches to do the same for iop32x, ixp4xx, ep93xx and s3c24xx, which >

Re: [PATCH] dt-bindings: Drop redundant 'maxItems/minItems' in if/then schemas

2022-05-04 Thread Ulf Hansson
s. > > Cc: Abel Vesa > Cc: Stephen Boyd > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Ulf Hansson > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Miquel Raynal > Cc: Richard

Re: [PATCH v2] PM: runtime: Return properly from rpm_resume() if dev->power.needs_force_resume flag is set

2022-09-23 Thread Ulf Hansson
On Fri, 23 Sept 2022 at 14:47, Liu Ying wrote: > > After a device transitions to sleep state through it's system suspend > callback pm_runtime_force_suspend(), the device's driver may still try > to do runtime PM for the device(runtime suspend first and then runtime > resume) although runtime PM i

Re: [PATCH v2] PM: runtime: Return properly from rpm_resume() if dev->power.needs_force_resume flag is set

2022-09-26 Thread Ulf Hansson
On Fri, 23 Sept 2022 at 17:23, Liu Ying wrote: > > On Fri, 2022-09-23 at 15:48 +0200, Ulf Hansson wrote: > > On Fri, 23 Sept 2022 at 14:47, Liu Ying wrote: > > > > > > After a device transitions to sleep state through it's system > > > suspend &g

Re: [PATCH v2 2/2] drm/tegra: Do not implement runtime PM

2019-12-13 Thread Ulf Hansson
On Thu, 12 Dec 2019 at 13:33, Thierry Reding wrote: > > On Thu, Dec 12, 2019 at 09:52:22AM +0100, Ulf Hansson wrote: > > On Mon, 9 Dec 2019 at 14:03, Thierry Reding > > wrote: > > > > > > From: Thierry Reding > > > > > > The Tegra DRM dr

Re: [PATCH v2 2/2] drm/tegra: Do not implement runtime PM

2019-12-13 Thread Ulf Hansson
On Mon, 9 Dec 2019 at 14:03, Thierry Reding wrote: > > From: Thierry Reding > > The Tegra DRM driver heavily relies on the implementations for runtime > suspend/resume to be called at specific times. Unfortunately, there are > some cases where that doesn't work. One example is if the user disable

Re: [PATCH v2 2/2] drm/tegra: Do not implement runtime PM

2019-12-23 Thread Ulf Hansson
On Thu, 12 Dec 2019 at 17:48, Rafael J. Wysocki wrote: > > On Thu, Dec 12, 2019 at 2:32 PM Ulf Hansson wrote: > > > > On Thu, 12 Dec 2019 at 13:33, Thierry Reding > > wrote: > > > > > > On Thu, Dec 12, 2019 at 09:52:22AM +0100, Ulf Hansson wrote: &g

Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h

2019-10-21 Thread Ulf Hansson
hael Turquette > Cc: Stephen Boyd > Cc: Viresh Kumar > Cc: Dmitry Torokhov > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: Ulf Hansson > Cc: Dominik Brodowski > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Guenter Roeck > Cc: Mark Brown > Cc: linux-

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-10 Thread Ulf Hansson
ple domains, as in MT8183 Bifrost > GPU, we need to handle them in driver code. > > Signed-off-by: Nicolas Boichat Besides a minor nitpick, feel free to add: Reviewed-by: Ulf Hansson Kind regards Uffe > > --- > > The downstream driver we use on chromeos-4.19 currently uses 2

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-10 Thread Ulf Hansson
On Sun, 9 Feb 2020 at 13:50, Nicolas Boichat wrote: > > On Fri, Feb 7, 2020 at 10:26 PM Ulf Hansson wrote: > > > > On Fri, 7 Feb 2020 at 06:27, Nicolas Boichat wrote: > > > > > > When there is a single power domain per device, the core will > > > ens

Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough;

2020-03-12 Thread Ulf Hansson
On Wed, 11 Mar 2020 at 08:40, Miquel Raynal wrote: > > Hi Joe, > > Joe Perches wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: > > https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d39

Re: [PATCH v2 5/7] drm/panfrost: Add support for multiple power domain support

2020-01-27 Thread Ulf Hansson
On Fri, 10 Jan 2020 at 02:53, Nicolas Boichat wrote: > > +Ulf to keep me honest on the power domains > > On Thu, Jan 9, 2020 at 10:08 PM Steven Price wrote: > > > > On 08/01/2020 05:23, Nicolas Boichat wrote: > > > When there is a single power domain per device, the core will > > > ensure the pow

Re: [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema

2019-10-03 Thread Ulf Hansson
lthough, I have to admit that I am still learning about the DT json-schema. So, FWIW: Reviewed-by: Ulf Hansson Kind regards Uffe > > --- > > Changes since v1: > 1. Select all nodes for consumers, > 2. Remove from consumers duplicated properties with dt-schema, > 3. Fix power

Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems

2021-06-17 Thread Ulf Hansson
ars-Peter Clausen > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Joerg Roedel > Cc: Jassi Brar > Cc: Mauro Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Ulf Hansson > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn >

Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-01-25 Thread Ulf Hansson
resent. > > Add unevaluatedProperties or additionalProperties as appropriate, and > then add any missing properties flagged by the addition. > > Signed-off-by: Rob Herring Acked-by: Ulf Hansson # For MMC Kind regards Uffe > --- > To: Krzysztof Kozlowski > To: David Airlie > To: Dani

Re: [PATCH v3 0/5] treewide cleanup of random integer usage

2022-10-07 Thread Ulf Hansson
t; Cc: Heiko Carstens > Cc: Helge Deller > Cc: Herbert Xu > Cc: Huacai Chen > Cc: Hugh Dickins > Cc: Jakub Kicinski > Cc: James E.J. Bottomley > Cc: Jan Kara > Cc: Jason Gunthorpe > Cc: Jens Axboe > Cc: Johannes Berg > Cc: Jonathan Corbet > Cc: Jozsef K

Re: [PATCH v2 35/65] clk: ux500: sysctrl: Add a determine_rate hook

2022-11-10 Thread Ulf Hansson
. > > And if it was an oversight, then we are at least explicit about our > behavior now and it can be further refined down the line. > > Signed-off-by: Maxime Ripard Seems reasonable to me! Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/clk/ux500/clk-sysctrl

Re: [PATCH v2 35/65] clk: ux500: sysctrl: Add a determine_rate hook

2022-11-10 Thread Ulf Hansson
On Thu, 10 Nov 2022 at 12:39, Linus Walleij wrote: > > On Thu, Nov 10, 2022 at 12:29 PM Ulf Hansson wrote: > > On Fri, 4 Nov 2022 at 14:32, Maxime Ripard wrote: > > > > > > The UX500 sysctrl "set_parent" clocks implement a mux with a set_parent > >

Re: [PATCH v7 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-12-07 Thread Ulf Hansson
On Wed, 5 Oct 2022 at 11:08, Akhil P Oommen wrote: > > Add a reset op compatible function to poll for gdsc collapse. This is > required because: > 1. We don't wait for it to turn OFF at hardware for VOTABLE GDSCs. > 2. There is no way for client drivers (eg. gpu driver) to do > put-with-wait

Re: [PATCH v7 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-12-07 Thread Ulf Hansson
On Wed, 5 Oct 2022 at 11:08, Akhil P Oommen wrote: > > Allow a consumer driver to poll for cx gdsc collapse through Reset > framework. Would you mind extending this commit message, to allow us to better understand what part is really the consumer part. I was expecting the consumer part to be the

Re: [PATCH v7 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-12-07 Thread Ulf Hansson
On Thu, 1 Dec 2022 at 23:57, Bjorn Andersson wrote: > > On Wed, Oct 05, 2022 at 02:36:58PM +0530, Akhil P Oommen wrote: > > > > @Ulf, Akhil has a power-domain for a piece of hardware which may be > voted active by multiple different subsystems (co-processors/execution > contexts) in the system. >

Re: [PATCH v7 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-12-08 Thread Ulf Hansson
On Wed, 7 Dec 2022 at 17:55, Bjorn Andersson wrote: > > On Wed, Dec 07, 2022 at 05:00:51PM +0100, Ulf Hansson wrote: > > On Thu, 1 Dec 2022 at 23:57, Bjorn Andersson wrote: > > > > > > On Wed, Oct 05, 2022 at 02:36:58PM +0530, Akhil P Oommen wrote: > > >

Re: [PATCH v7 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-12-09 Thread Ulf Hansson
On Thu, 8 Dec 2022 at 22:06, Bjorn Andersson wrote: > > On Thu, Dec 08, 2022 at 02:40:55PM +0100, Ulf Hansson wrote: > > On Wed, 7 Dec 2022 at 17:55, Bjorn Andersson wrote: > > > > > > On Wed, Dec 07, 2022 at 05:00:51PM +0100, Ulf Hansson wrote: > > &g

Re: [PATCH v7 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-12-12 Thread Ulf Hansson
On Fri, 9 Dec 2022 at 18:36, Ulf Hansson wrote: > > On Thu, 8 Dec 2022 at 22:06, Bjorn Andersson wrote: > > > > On Thu, Dec 08, 2022 at 02:40:55PM +0100, Ulf Hansson wrote: > > > On Wed, 7 Dec 2022 at 17:55, Bjorn Andersson wrote: > > > > > > >

Re: [PATCH v3 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2022-12-21 Thread Ulf Hansson
On Tue, 20 Dec 2022 at 08:44, Akhil P Oommen wrote: > > From: Ulf Hansson > > Some genpd providers doesn't ensure that it has turned off at hardware. > This is fine until the consumer really requires during some special > scenarios that the power domain collapse at hardwar

Re: [PATCH v4 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2022-12-22 Thread Ulf Hansson
> Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson Kind regards Uffe > --- > > (no changes since v3) > > Changes in v3: > - Rename the var 'force_sync' to 'wait (Stephen) > > drivers/clk/qcom/gdsc.c | 11 ++- > 1 file changed, 6 in

Re: [PATCH v4 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2022-12-22 Thread Ulf Hansson
sing > genpd framework will be implemented in the upcoming patch. > > This effectively reverts commit 1f6cca404918 > ("drm/msm/a6xx: Ensure CX collapse during gpu recovery"). > > Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson Kind regards Uffe > --- >

Re: [PATCH v4 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2022-12-22 Thread Ulf Hansson
fier along with the newly introduced > dev_pm_genpd_synced_poweroff() api to ensure that cx gdsc has collapsed > before we turn it back ON. > > Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson Kind regards Uffe > --- > > (no changes since v2) > > Changes in v2:

Re: [PATCH v4 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2022-12-22 Thread Ulf Hansson
ctive 0 > cx_gdsc on 0 > /devices/platform/soc@0/3da.iommu active 0 > /devices/genpd:0:3d6a000.gmu active 0 > > Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson Kind regards Uff

Re: [PATCH 3/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

2023-05-02 Thread Ulf Hansson
e situtation better and > solves the immediate issue. > > Fixes: 92bf78b33b0b ("gpio: omap: use dynamic allocation of base") > Signed-off-by: Linus Walleij This looks like it's best funneled through the soc maintainer's tree(s), right? Acked-by: Ulf Han

Re: [PATCH] drm/msm/a6xx: add CONFIG_PM dependency

2023-03-24 Thread Ulf Hansson
ower_off_work); >^ > drivers/base/power/domain.c:853:26: error: no member named 'ignore_children' > in 'struct dev_pm_info' > if (!dev || dev->power.ignore_children) > ~~ ^ > > Fixes: c11fa1204fe9

Re: [PATCH v3] drm/bridge: panel: Add a device link between drm device and panel device

2023-08-09 Thread Ulf Hansson
ler and resumes later than the panel device, hence resolves > problems where the order is reversed, like the problematic case mentioned > in the below link. > > Link: > https://lore.kernel.org/lkml/capdykfr0xjru_udkoukq_q8rwaukyql+8fv-7s1ctmqi7u3...@mail.gmail.com/T/ > Suggested-by:

[PATCH v2 1/2] PM / Domains: Allow genpd to power on during the system PM phase

2016-05-11 Thread Ulf Hansson
c: Alex Deucher Cc: Christian König Cc: Maruthi Srinivas Bayyavarapu Cc: dri-devel at lists.freedesktop.org Signed-off-by: Ulf Hansson --- Changes in v2: - Updated changelog. - Added a fix in the AMD ACP (Audio CoProcessor) drm driver, which registers a ge

[PATCH v2 2/2] PM / Domains: Remove redundant wrapper functions for system PM

2016-05-11 Thread Ulf Hansson
lback invokes pm_generic_resume(), while it should be pm_generic_restore(). Let's fix this as well. Signed-off-by: Ulf Hansson --- Changes in v2: - Updated changelog. --- drivers/base/power/domain.c | 203 +++- 1 file changed, 12 insertions(+), 191

[PATCH v2 0/2] PM / Domains: Second step in improving system PM code in genpd

2016-05-11 Thread Ulf Hansson
ch is actually fixing a bug while it also enables for further clean-ups, which is done in the second patch. The next step of improving system PM code in genpd will move it to the part of trying to optimize the behaviour, such as avoid waking up devices unless it's really needed. Ulf Hansson

[PATCH v2 1/2] PM / Domains: Allow genpd to power on during the system PM phase

2016-05-12 Thread Ulf Hansson
On 11 May 2016 at 23:25, Rafael J. Wysocki wrote: > On Wed, May 11, 2016 at 10:00 AM, Ulf Hansson > wrote: >> If the PM domain is powered off when the first device in the domain starts >> its system PM prepare phase, genpd prevents any further attempts to power >> on

  1   2   >