EDID modes unavailable when no connector/crtc available at boot

2013-08-12 Thread Tony Prisk
height are set to the initialized mode. Later in drm_fb_helper.c:drm_fb_helper_hotplug_event, max_width if set to fb->width. This is what causes the modes to be truncated when the HDMI connector is finally connected (max_width is now limited to 1024). Sug

Re: EDID modes unavailable when no connector/crtc available at boot

2013-08-12 Thread Tony Prisk
On 11/08/13 20:42, Dave Airlie wrote: On Sun, Aug 11, 2013 at 2:41 PM, Tony Prisk wrote: I am working on the HDMI driver for the i.MX6 as part of the larger DRM driver written by Sascha Hauer and need a little advice. I seem to be missing one important part of the subsystem that I haven't

EDID modes unavailable when no connector/crtc available at boot

2013-08-11 Thread Tony Prisk
set to the initialized mode. Later in drm_fb_helper.c:drm_fb_helper_hotplug_event, max_width if set to fb->width. This is what causes the modes to be truncated when the HDMI connector is finally connected (max_width is now limited to 1024). Suggestions appreciated. Regards Tony Prisk

EDID modes unavailable when no connector/crtc available at boot

2013-08-11 Thread Tony Prisk
On 11/08/13 20:42, Dave Airlie wrote: > On Sun, Aug 11, 2013 at 2:41 PM, Tony Prisk wrote: >> I am working on the HDMI driver for the i.MX6 as part of the larger DRM >> driver written by Sascha Hauer and need a little advice. I seem to be >> missing one important part of

[PATCH 2/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-18 Thread Tony Prisk
ned-off-by: Tony Prisk CC: Inki Dae CC: Joonyoung Shim CC: Seung-Woo Kim CC: Kyungmin Park CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_mixer.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c

[PATCH 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-18 Thread Tony Prisk
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. Signed-off-by: Tony Prisk CC: Inki Dae CC: Joonyoung Shim CC: Seung-Woo Kim CC: Kyungmin Park CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
Resend to include mailing lists. Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. Signed-off-by: Tony Prisk CC: Inki Dae CC: Joonyoung Shim CC: Seung-Woo Kim CC: Kyungmin Park CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +- 1 file

[PATCH RESEND 2/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
x27;t been clk_get'd yet. Signed-off-by: Tony Prisk CC: Inki Dae CC: Joonyoung Shim CC: Seung-Woo Kim CC: Kyungmin Park CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_mixer.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drive

Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
On Tue, 2012-12-18 at 21:39 +0300, Dan Carpenter wrote: > On Wed, Dec 19, 2012 at 06:34:05AM +1300, Tony Prisk wrote: > > Resend to include mailing lists. > > > > Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. > > > > The original code is correct. cl

Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote: > I don't care either way, but being different from the documentation > is less bad than crashing which is what your patch does. Please > be more careful in the future. > > regards, > dan carpenter Critism accepted. Given that the driver d

Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
On Wed, 2012-12-19 at 08:11 +1300, Tony Prisk wrote: > On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote: > > I don't care either way, but being different from the documentation > > is less bad than crashing which is what your patch does. Please > > be

[PATCH 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-18 Thread Tony Prisk
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. Signed-off-by: Tony Prisk CC: Inki Dae CC: Joonyoung Shim CC: Seung-Woo Kim CC: Kyungmin Park CC: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 2/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-18 Thread Tony Prisk
ned-off-by: Tony Prisk CC: Inki Dae CC: Joonyoung Shim CC: Seung-Woo Kim CC: Kyungmin Park CC: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_mixer.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_

[PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
Resend to include mailing lists. Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. Signed-off-by: Tony Prisk CC: Inki Dae CC: Joonyoung Shim CC: Seung-Woo Kim CC: Kyungmin Park CC: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +- 1 file

[PATCH RESEND 2/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
x27;t been clk_get'd yet. Signed-off-by: Tony Prisk CC: Inki Dae CC: Joonyoung Shim CC: Seung-Woo Kim CC: Kyungmin Park CC: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_mixer.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/d

[PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
On Tue, 2012-12-18 at 21:39 +0300, Dan Carpenter wrote: > On Wed, Dec 19, 2012 at 06:34:05AM +1300, Tony Prisk wrote: > > Resend to include mailing lists. > > > > Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. > > > > The original code is correct. cl

[PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote: > I don't care either way, but being different from the documentation > is less bad than crashing which is what your patch does. Please > be more careful in the future. > > regards, > dan carpenter Critism accepted. Given that the driver d

[PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-19 Thread Tony Prisk
On Wed, 2012-12-19 at 08:11 +1300, Tony Prisk wrote: > On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote: > > I don't care either way, but being different from the documentation > > is less bad than crashing which is what your patch does. Please > > be