nouveau "eDP-1: EDID is invalid" regression after 4.11 with HP ZBook 15 G3

2017-05-10 Thread Tommi Rantala
Hi, The HP ZBook 15 G3 laptop builtin display (eDP-1) does not work correctly with v4.11-11413-g2868b25. When booting the laptop, the resolution seems to be limited to 1024x768, and gnome-session segfaults. Up to 4.11 the display works just fine in 1920x1080 mode. I'm seeing this in the kernel

(radeon?) WARNING: drivers/gpu/drm/drm_irq.c:1195 drm_vblank_put (v4.11-12441-g56868a4)

2017-05-10 Thread Tommi Rantala
Hi, I just tested v4.11-12441-g56868a4 on HP xw6600 with radeon graphics, and I'm seeing the following WARNING triggered constantly. I have not seen this earlier e.g. with the distro kernel 4.10.13-200.fc25.x86_64 $ lspci|grep -i amd 60:00.0 VGA compatible controller: Advanced Micro Devices, Inc

Re: nouveau "eDP-1: EDID is invalid" regression after 4.11 with HP ZBook 15 G3

2017-05-14 Thread Tommi Rantala
et just in case it's needed from DEVINIT scripts where DRM isn't available. Signed-off-by: Ben Skeggs dmesg after boot with drm.debug enabled: v4.10-10409-g5c68d91 (still works): http://termbin.com/b0is v4.10-10410-gdf8dc97 (failure): http://termbin.com/j6lq Tommi 2017-05-10 1

Re: nouveau "eDP-1: EDID is invalid" regression after 4.11 with HP ZBook 15 G3

2017-05-14 Thread Tommi Rantala
2017-05-15 3:03 GMT+03:00 Ben Skeggs : > On 05/15/2017 01:10 AM, Tommi Rantala wrote: >> >> Hi, > > Hey Tommi, > > Thanks for bisecting this. It's rather unexpected that you should be seeing > problems here, but, the commit makes sense for it at least. > &g

Re: (radeon?) WARNING: drivers/gpu/drm/drm_irq.c:1195 drm_vblank_put (v4.11-12441-g56868a4)

2017-05-18 Thread Tommi Rantala
2017-05-11 5:51 GMT+03:00 Michel Dänzer : > On 11/05/17 04:33 AM, Tommi Rantala wrote: >> Complete kernel log: >> http://termbin.com/dzy5 >> >> [ 249.952546] [ cut here ] >> [ 249.952593] WARNING: CPU: 5 PID: 0 at >> /home/ttrantal/g

Re: (radeon?) WARNING: drivers/gpu/drm/drm_irq.c:1195 drm_vblank_put (v4.11-12441-g56868a4)

2017-05-22 Thread Tommi Rantala
2017-05-22 10:32 GMT+03:00 Daniel Vetter : > Yeah I think the locking stuff we've fixed, at least if you don't see it > in 4.12 it should be all good. And I think I spotted the bug you've > bisected to, patch is on dri-devel, pls test. Thanks! I'll test it later today. -Tommi

Re: [PATCH] drm: Fix deadlock retry loop in page_flip_ioctl

2017-05-22 Thread Tommi Rantala
t; Cc: Jani Nikula > Cc: Sean Paul > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Reported-by: Tommi Rantala > Cc: Tommi Rantala > Cc: Michel Dänzer > Signed-off-by: Daniel Vetter Thanks, confirmed that this fixes the warning that I was seeing! Tested-by: Tommi R

Re: nouveau "eDP-1: EDID is invalid" regression after 4.11 with HP ZBook 15 G3

2017-06-03 Thread Tommi Rantala
2017-05-15 8:20 GMT+03:00 Tommi Rantala : > 2017-05-15 3:03 GMT+03:00 Ben Skeggs : >> On 05/15/2017 01:10 AM, Tommi Rantala wrote: >>> >>> Hi, >> >> Hey Tommi, >> >> Thanks for bisecting this. It's rather unexpected that you should be seeing

[PATCH 0/6] alloc_apertures() handling fixes

2012-11-09 Thread Tommi Rantala
Greetings, The following patches fix a few memory leaks and other problems related to the alloc_apertures() call. Tommi Rantala (6): drm/cirrus: check alloc_apertures() success in cirrus_kick_out_firmware_fb() drm/mgag200: check alloc_apertures() success in mga_vram_init() drm/mgag200

[PATCH 1/6] drm/cirrus: check alloc_apertures() success in cirrus_kick_out_firmware_fb()

2012-11-09 Thread Tommi Rantala
Check for alloc_apertures() memory allocation failure, and propagate an error code in case the allocation failed. Signed-off-by: Tommi Rantala --- drivers/gpu/drm/cirrus/cirrus_drv.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/cirrus

[PATCH 2/6] drm/mgag200: check alloc_apertures() success in mga_vram_init()

2012-11-09 Thread Tommi Rantala
Check for alloc_apertures() memory allocation failure, and propagate an error code in case the allocation failed. Signed-off-by: Tommi Rantala --- drivers/gpu/drm/mgag200/mgag200_main.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers

[PATCH 3/6] drm/mgag200: free memory allocated with alloc_apertures()

2012-11-09 Thread Tommi Rantala
Fix a memory leak by deallocating the memory we got from alloc_apertures(). Signed-off-by: Tommi Rantala --- drivers/gpu/drm/mgag200/mgag200_main.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index

[PATCH 4/6] drm/mgag200: remove unneeded aper->count assignment after alloc_apertures()

2012-11-09 Thread Tommi Rantala
alloc_apertures() already does the assignment for us, so assigning the count member after the alloc_apertures() call is not needed. Signed-off-by: Tommi Rantala --- drivers/gpu/drm/mgag200/mgag200_main.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200

[PATCH 5/6] drm/radeon: check alloc_apertures() success in radeon_kick_out_firmware_fb()

2012-11-09 Thread Tommi Rantala
Check for alloc_apertures() memory allocation failure, and propagate an error code in case the allocation failed. Signed-off-by: Tommi Rantala --- drivers/gpu/drm/radeon/radeon_drv.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon

[PATCH 6/6] drm/nouveau: free memory allocated with alloc_apertures()

2012-11-09 Thread Tommi Rantala
Fix a memory leak by deallocating the memory we got from alloc_apertures(). Signed-off-by: Tommi Rantala --- drivers/gpu/drm/nouveau/nouveau_drm.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 0910125

BUG: unable to handle kernel paging request at ffffc90000669000, IP: [] bitfill_unaligned+0x10a/0x1a0

2013-02-19 Thread Tommi Rantala
Hello, Hit the following oops while fuzzing the kernel with Trinity in a qemu virtual machine: [ 2143.140647] BUG: unable to handle kernel paging request at c9669000 [ 2143.140652] IP: [] bitfill_unaligned+0x10a/0x1a0 [ 2143.140654] PGD 3e073067 PUD 3e074067 PMD 3ca84067 PTE 0 [ 2143.1406

idr_remove called for id=4096 which is not allocated

2013-02-19 Thread Tommi Rantala
Hello, Saw this WARNING a few times while fuzzing the kernel with Trinity in a qemu virtual machine: [ 22.883257] idr_remove called for id=4096 which is not allocated. [ 22.884487] Pid: 2303, comm: trinity-child1 Not tainted 3.8.0+ #87 [ 22.885601] Call Trace: [ 22.886080] [] idr_remove+

NULL pointer deref at drm_lock_free()

2013-02-19 Thread Tommi Rantala
Hello, Hit this oops a few times while fuzzing the kernel with Trinity in a qemu virtual machine: [ 133.012360] BUG: unable to handle kernel NULL pointer dereference at (null) [ 133.013015] IP: [] drm_lock_free+0x90/0x110 [ 133.013015] PGD 2fed8067 PUD 2fed9067 PMD 0 [ 133.013015] O

NULL pointer deref at drm_newctx()

2013-02-19 Thread Tommi Rantala
Hello, Hit this oops a few times while fuzzing the kernel with trinity in a qemu VM: [ 139.826369] BUG: unable to handle kernel NULL pointer dereference at (null) [ 139.827023] IP: [] drm_newctx+0x64/0xb0 [ 139.827023] PGD 36f6d067 PUD 36f6e067 PMD 0 [ 139.827023] Oops: [#1] SM

Re: [PATCH 2/2] drm: don't oops in ioctls that require the lock if no lock

2013-02-20 Thread Tommi Rantala
f6 14 82 bf 01 00 00 00 4d 8d 74 24 58 <8b> 00 89 54 24 08 48 c7 c2 f9 2c e7 81 89 04 24 31 c0 e8 ea 0c [ 66.167069] RIP [] drm_lock+0xaf/0x330 [ 66.167069] RSP [ 66.167069] CR2: [ 66.216777] ---[ end trace 148abe85b0cacc0f ]--- > Reported-by: Tommi Rantala &g

i915 drm oopses while fuzzing

2013-03-14 Thread Tommi Rantala
Hi, I saw these i915 oopses while fuzzing with trinity. The kernel is mainline v3.9-rc2-188-g6c23cbb, along with these two patches from Dave Airlie applied: [PATCH 1/2] drm: fix idr_remove warning during fuzzing [PATCH 2/2] drm: don't oops in ioctls that require the lock if no lock [4.68058

Re: [PATCH] drm/i915: Sanity check incoming ioctl data for a NULL pointer

2013-03-14 Thread Tommi Rantala
2013/3/14 Chris Wilson : > In order to prevent a potential NULL deference with hostile userspace, > we need to check whether the ioctl was passed an invalid args pointer. > > Reported-by: Tommi Rantala > Link: > http://lkml.kernel.org/r/ca+ydwtpubvbwxbt-tdgpuvj1eu7it

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check incoming ioctl data for a NULL pointer

2013-04-11 Thread Tommi Rantala
2013/3/17 Chris Wilson : > On Mon, Mar 18, 2013 at 07:42:58AM +1000, Dave Airlie wrote: >> On Mon, Mar 18, 2013 at 7:40 AM, Chris Wilson >> wrote: >> > On Sun, Mar 17, 2013 at 08:50:03PM +0100, Daniel Vetter wrote: >> >> On Sat, Mar 16, 2013 at 11:19 AM, Chris Wilson >> >> wrote: >> >> > If *us

[Intel-gfx] [PATCH] drm/i915: Sanity check incoming ioctl data for a NULL pointer

2013-04-11 Thread Tommi Rantala
2013/3/17 Chris Wilson : > On Mon, Mar 18, 2013 at 07:42:58AM +1000, Dave Airlie wrote: >> On Mon, Mar 18, 2013 at 7:40 AM, Chris Wilson >> wrote: >> > On Sun, Mar 17, 2013 at 08:50:03PM +0100, Daniel Vetter wrote: >> >> On Sat, Mar 16, 2013 at 11:19 AM, Chris Wilson > >> chris-wilson.co.uk> wrot

drm_mode_create_dumb_ioctl: divide error

2014-08-21 Thread Tommi Rantala
Hello, Triggered this while fuzzing v3.17-rc1-51-g372b1db with Trinity. Tommi [drm:drm_mode_legacy_fb_format] *ERROR* bad bpp, assuming x8r8g8b8 pixel format divide error: [#1] SMP DEBUG_PAGEALLOC CPU: 0 PID: 2854 Comm: trinity-c7 Not tainted 3.17.0-rc1+ #14 Hardware name: Bochs Bochs, BIO

drm_mode_create_dumb_ioctl: divide error

2014-08-24 Thread Tommi Rantala
22.8.2014 13.38 kirjoitti "David Herrmann" : > > Hi > > On Thu, Aug 21, 2014 at 8:18 PM, Tommi Rantala > wrote: > > Hello, > > > > Triggered this while fuzzing v3.17-rc1-51-g372b1db with Trinity. > > > > Tommi > > > > > >

drm_ioctl & WARNING at arch/x86/mm/ioremap.c:98

2014-08-27 Thread Tommi Rantala
Hello, Got this warning while fuzzing v3.17-rc2-40-gff0c57a with Trinity. Was running as root in qemu. Tommi ioremap: invalid physical address 40004000 [ cut here ] WARNING: CPU: 0 PID: 2887 at arch/x86/mm/ioremap.c:98 __ioremap_caller+0x7a/0x2e0() CPU: 0 PID: 28

BUG: unable to handle kernel paging request at ffffc90000669000, IP: [] bitfill_unaligned+0x10a/0x1a0

2013-02-19 Thread Tommi Rantala
Hello, Hit the following oops while fuzzing the kernel with Trinity in a qemu virtual machine: [ 2143.140647] BUG: unable to handle kernel paging request at c9669000 [ 2143.140652] IP: [] bitfill_unaligned+0x10a/0x1a0 [ 2143.140654] PGD 3e073067 PUD 3e074067 PMD 3ca84067 PTE 0 [ 2143.1406

idr_remove called for id=4096 which is not allocated

2013-02-19 Thread Tommi Rantala
Hello, Saw this WARNING a few times while fuzzing the kernel with Trinity in a qemu virtual machine: [ 22.883257] idr_remove called for id=4096 which is not allocated. [ 22.884487] Pid: 2303, comm: trinity-child1 Not tainted 3.8.0+ #87 [ 22.885601] Call Trace: [ 22.886080] [] idr_remove+

NULL pointer deref at drm_lock_free()

2013-02-19 Thread Tommi Rantala
Hello, Hit this oops a few times while fuzzing the kernel with Trinity in a qemu virtual machine: [ 133.012360] BUG: unable to handle kernel NULL pointer dereference at (null) [ 133.013015] IP: [] drm_lock_free+0x90/0x110 [ 133.013015] PGD 2fed8067 PUD 2fed9067 PMD 0 [ 133.013015] O

NULL pointer deref at drm_newctx()

2013-02-19 Thread Tommi Rantala
Hello, Hit this oops a few times while fuzzing the kernel with trinity in a qemu VM: [ 139.826369] BUG: unable to handle kernel NULL pointer dereference at (null) [ 139.827023] IP: [] drm_newctx+0x64/0xb0 [ 139.827023] PGD 36f6d067 PUD 36f6e067 PMD 0 [ 139.827023] Oops: [#1] SM

[PATCH 2/2] drm: don't oops in ioctls that require the lock if no lock

2013-02-20 Thread Tommi Rantala
f6 14 82 bf 01 00 00 00 4d 8d 74 24 58 <8b> 00 89 54 24 08 48 c7 c2 f9 2c e7 81 89 04 24 31 c0 e8 ea 0c [ 66.167069] RIP [] drm_lock+0xaf/0x330 [ 66.167069] RSP [ 66.167069] CR2: [ 66.216777] ---[ end trace 148abe85b0cacc0f ]--- > Reported-by: Tommi Rantala &g

[PATCH 0/6] alloc_apertures() handling fixes

2012-11-09 Thread Tommi Rantala
Greetings, The following patches fix a few memory leaks and other problems related to the alloc_apertures() call. Tommi Rantala (6): drm/cirrus: check alloc_apertures() success in cirrus_kick_out_firmware_fb() drm/mgag200: check alloc_apertures() success in mga_vram_init() drm/mgag200

[PATCH 1/6] drm/cirrus: check alloc_apertures() success in cirrus_kick_out_firmware_fb()

2012-11-09 Thread Tommi Rantala
Check for alloc_apertures() memory allocation failure, and propagate an error code in case the allocation failed. Signed-off-by: Tommi Rantala --- drivers/gpu/drm/cirrus/cirrus_drv.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/cirrus

[PATCH 2/6] drm/mgag200: check alloc_apertures() success in mga_vram_init()

2012-11-09 Thread Tommi Rantala
Check for alloc_apertures() memory allocation failure, and propagate an error code in case the allocation failed. Signed-off-by: Tommi Rantala --- drivers/gpu/drm/mgag200/mgag200_main.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers

[PATCH 3/6] drm/mgag200: free memory allocated with alloc_apertures()

2012-11-09 Thread Tommi Rantala
Fix a memory leak by deallocating the memory we got from alloc_apertures(). Signed-off-by: Tommi Rantala --- drivers/gpu/drm/mgag200/mgag200_main.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index

[PATCH 4/6] drm/mgag200: remove unneeded aper->count assignment after alloc_apertures()

2012-11-09 Thread Tommi Rantala
alloc_apertures() already does the assignment for us, so assigning the count member after the alloc_apertures() call is not needed. Signed-off-by: Tommi Rantala --- drivers/gpu/drm/mgag200/mgag200_main.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200

[PATCH 5/6] drm/radeon: check alloc_apertures() success in radeon_kick_out_firmware_fb()

2012-11-09 Thread Tommi Rantala
Check for alloc_apertures() memory allocation failure, and propagate an error code in case the allocation failed. Signed-off-by: Tommi Rantala --- drivers/gpu/drm/radeon/radeon_drv.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon

[PATCH 6/6] drm/nouveau: free memory allocated with alloc_apertures()

2012-11-09 Thread Tommi Rantala
Fix a memory leak by deallocating the memory we got from alloc_apertures(). Signed-off-by: Tommi Rantala --- drivers/gpu/drm/nouveau/nouveau_drm.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 0910125

[PATCH] drm: Fix deadlock due to getconnector locking changes

2015-03-02 Thread Tommi Rantala
2015-02-24 1:55 GMT+02:00 Marc Finet : > On Sun, Feb 22, 2015 at 11:38:36AM +0100, Daniel Vetter wrote: >> In >> >> daniel at phenom:~/linux/src$ git show ccfc08655 >> commit ccfc08655d5fd5076828f45fb09194c070f2f63a >> Author: Rob Clark >> Date: Thu Dec 18 16:01:48 2014 -0500 >> >> drm: twea

[PATCH] drm/i915: fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl

2015-03-26 Thread Tommi Rantala
Fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl, so that it is different from the DRM_IOCTL_I915_SET_SPRITE_COLORKEY ioctl. Signed-off-by: Tommi Rantala --- include/uapi/drm/i915_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/i915_drm.h

intel_sprite_get_colorkey oops

2015-03-26 Thread Tommi Rantala
Hello, Trinity discovered oopses with the i915 colorkey ioctls, reproducible on my system with this: #include #include #include #include #include #include #include #include #define GET DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GET_SPRITE_COLORKEY, struct drm_intel_sprite_colorkey) int main(i

[PATCH] drm/i915: Rip out GET_SPRITE_COLORKEY ioctl

2015-03-27 Thread Tommi Rantala
it search in userspace and only found >>> broken definitions and no users anywhere. >>> >>> Cc: Tommi Rantala >>> Signed-off-by: Daniel Vetter >> >> Hm Tommi discovered oopses in there, so I guess this should be >> cherry-picked to -fixes+cc: stable

nouveau: BUG: KASAN: slab-out-of-bounds in memcpy+0x1d/0x40

2015-11-22 Thread Tommi Rantala
Hello, I'm seeing this kasan report after booting with linus v4.4-rc1-290-g3ad5d7e. BUG: KASAN: slab-out-of-bounds in memcpy+0x1d/0x40 at addr 880169e21fd0 Read of size 64 by task kworker/1:0/14 = BUG kmalloc-8192 (No

nouveau: iowrite32 oops & warning at drivers/gpu/drm/nouveau/nouveau_fence.c:198

2015-11-22 Thread Tommi Rantala
Hello, I'm seeing this warning and oops when trying to fuzz linus v4.4-rc1-290-g3ad5d7e with trinity. [ cut here ] WARNING: CPU: 1 PID: 4308 at drivers/gpu/drm/nouveau/nouveau_fence.c:198 nouveau_fence_context_new+0x22e/0x270() CPU: 1 PID: 4308 Comm: trinity-c19 Tainted: G

nouveau: iowrite32 oops & warning at drivers/gpu/drm/nouveau/nouveau_fence.c:198

2015-11-23 Thread Tommi Rantala
2015-11-22 22:49 GMT+02:00 Ilia Mirkin : > Not sure if these apply here but there are a couple of outstanding > locking fixes available in > http://cgit.freedesktop.org/~darktama/nouveau/ -- specifically these > two: > > http://cgit.freedesktop.org/~darktama/nouveau/commit/?id=2f3a56ad019e378a352e9

[PATCH] drm/radeon: fix DRM_IOCTL_RADEON_CS oops

2015-03-02 Thread Tommi Rantala
00 [ 47.149253] ---[ end trace 09576b4e8b2c20b8 ]--- Signed-off-by: Tommi Rantala --- drivers/gpu/drm/radeon/radeon_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c index a579ed3..4d0f96c 10

[PATCH] drm: fix drm_mode_getconnector() locking imbalance regression

2015-04-03 Thread Tommi Rantala
imbalance. Signed-off-by: Tommi Rantala Cc: Daniel Vetter --- drivers/gpu/drm/drm_crtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 679b10e..b6f076b 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm

i915 drm oopses while fuzzing

2013-03-14 Thread Tommi Rantala
Hi, I saw these i915 oopses while fuzzing with trinity. The kernel is mainline v3.9-rc2-188-g6c23cbb, along with these two patches from Dave Airlie applied: [PATCH 1/2] drm: fix idr_remove warning during fuzzing [PATCH 2/2] drm: don't oops in ioctls that require the lock if no lock [4.68058

[PATCH] drm/i915: Sanity check incoming ioctl data for a NULL pointer

2013-03-14 Thread Tommi Rantala
2013/3/14 Chris Wilson : > In order to prevent a potential NULL deference with hostile userspace, > we need to check whether the ioctl was passed an invalid args pointer. > > Reported-by: Tommi Rantala > Link: > http://lkml.kernel.org/r/CA+ydwtpuBvbwxbt-tdgPUvj1EU7itmCHo_2B3w