On 28/07/2021 18:37, Laurent Pinchart wrote:
Hello,
This patch series stems from subsystem-wide changes I wanted to
compile-test with an ARM64 cross-compiler. My laziness to fire a 32-bit
ARM build probably resulted in more time being spent writing these
patches, but hopefully they'll turn out t
On 28/07/2021 18:37, Laurent Pinchart wrote:
On 64-bit platforms, the compiler complains that casting a void pointer
to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned
to fix this.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
1 file chan
by: Thomas Zimmermann
---
drivers/gpu/drm/tidss/tidss_drv.c | 15 +--
drivers/gpu/drm/tidss/tidss_drv.h | 2 ++
drivers/gpu/drm/tidss/tidss_irq.c | 27 ---
drivers/gpu/drm/tidss/tidss_irq.h | 4 +---
4 files changed, 32 insertions(+), 16 deletions(-)
Reviewe
/tidss_kms.c | 4 +---
drivers/gpu/drm/tilcdc/tilcdc_external.c | 4 +---
drivers/gpu/drm/vc4/vc4_dsi.c | 4 +---
26 files changed, 33 insertions(+), 103 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
Hi Hans,
On 02/03/2021 18:23, Hans Verkuil wrote:
Add bridge connector_attach/detach ops. These ops are called when a
bridge is attached or detached to a drm_connector. These ops can be
used to register and unregister an HDMI CEC adapter for a bridge that
supports CEC.
Signed-off-by: Hans Verku
/gpu/drm/omapdrm/dss/hdmi4.c | 27 +
drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 9 ++---
drivers/gpu/drm/omapdrm/dss/hdmi4_cec.h | 7 ---
3 files changed, 29 insertions(+), 14 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
prototype for
disable_vblank(). Prototype was for omap_irq_disable_vblank() instead
Cc: Tomi Valkeinen
Cc: David Airlie
Cc: Daniel Vetter
Cc: Rob Clark
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++--
1 file changed, 2 insertions
On 16/04/2021 17:37, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/omapdrm/omap_gem.c:619: warning: expecting prototype for
omap_gem_dumb_map(). Prototype was for omap_gem_dumb_map_offset() instead
Cc: Tomi Valkeinen
Cc: David Airlie
Cc: Daniel Vetter
Hi Tony,
On 26/04/2021 17:12, Tony Lindgren wrote:
On resume, dispc pm_runtime_force_resume() is not enabling the hardware
as we pass the pm_runtime_need_not_resume() test as the device is suspended
with no child devices.
As the resume continues, omap_atomic_comit_tail() calls dispc_runtime_get
On 29/04/2021 07:46, Tony Lindgren wrote:
Hi,
* Laurent Pinchart [210428 14:10]:
Based on my experience on the camera and display side with devices that
are made of multiple components, suspend and resume are best handled in
a controlled way by the top-level driver. Otherwise you end up having
On 01/05/2021 23:00, Sebastian Reichel wrote:
Running a legacy application, which directly uses /dev/fb0
currently results in display not being refreshed when the
application mmaps the memory instead of calling write().
Deferred IO support will also schedule dirty_work with the
damage collected
en + 4) {
@@ -2390,7 +2390,7 @@ static int dsi_vc_generic_read(struct omap_dss_device
*dssdev, int vc,
return 0;
err:
- DSSERR("%s(vc %d, reqlen %d) failed\n", __func__, vc, msg->tx_len);
+ DSSERR("%s(vc %d, reqlen %zu) failed\n", __func__, vc, msg->
ed_workqueue("omapdrm", 0);
mutex_init(&priv->list_lock);
Reviewed-by: Tomi Valkeinen
Tomi
DRM_OMAP
tristate "OMAP DRM"
depends on DRM
- depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
+ depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM || COMPILE_TEST
select OMAP2_DSS
select DRM_KMS_HELPER
select VIDEOMODE_HELPERS
Reviewe
On 14/03/2021 04:15, Laurent Pinchart wrote:
Hi Junlin,
Thank you for the patch.
On Fri, Mar 12, 2021 at 03:14:45PM +0800, angkery wrote:
From: Junlin Yang
r is "u32" always >= 0,mipi_dsi_create_packet may return little than zero.
so r < 0 condition is never accessible.
Fixes coccicheck war
Hi Sebastian, Sam, Thierry,
On 27/02/2021 23:45, Sebastian Reichel wrote:
From: Sebastian Reichel
Disable TE for Droid 4 panel, since implementation is currently
broken. Also disable it for N950 panel, which is untested.
Reported-by: Tony Lindgren
Reported-by: Tomi Valkeinen
Fixes
On 14/03/2021 17:13, Dario Binacchi wrote:
As reported by TI spruh73x RM, the LCD pixel clock (LCD_PCLK) frequency
is obtained by dividing LCD_CLK, the LCD controller reference clock,
for CLKDIV:
LCD_PCLK = LCD_CLK / CLKDIV
where CLKDIV must be greater than 1.
Therefore LCD_CLK must be set to
Hi,
On 17/03/2021 11:48, ChunyouTang wrote:
From: tangchunyou
1.the type of mipi_dsi_create_packet id int
2.u32 can not < 0
Signed-off-by: tangchunyou
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.
On 18/03/2021 03:02, Stephen Rothwell wrote:
Hi all,
Today's linux-next merge of the drm tree got a conflict in:
drivers/gpu/drm/omapdrm/dss/dsi.c
between commit:
690911544275 ("drm/omap: dsi: fix unsigned expression compared with zero")
from the drm-misc-fixes tree and commit:
bbd
On 21/03/2021 10:31, Dario Binacchi wrote:
The warning message did not printed the LCD pixel clock rate but the LCD
clock divisor input rate. As a consequence, the required and real pixel
clock rates are now passed to the tilcdc_pclk_diff().
Signed-off-by: Dario Binacchi
---
Changes in v2:
-
fixes
a warning message.
Thanks you,
I think this looks good now.
Reviewed-by: Jyri Sarha
For the series.
I'll wait a day or two if Tomi has something more to say and merge this
to drm-misc-next.
I had one comment about the print, but otherwise:
Reviewed-by: Tomi Valkeinen
On 22/03/2021 18:41, Arnd Bergmann wrote:
From: Arnd Bergmann
An old patch added a 'return' statement after each BUG() in this driver,
which was necessary at the time, but has become redundant after the BUG()
definition was updated to handle this properly.
gcc-11 now warns about one such insta
On 23/03/2021 13:15, Sebastian Reichel wrote:
Hi,
On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:
fixed the following coccicheck:
./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT
Reported-by: Abaci Robot
Signed-
On 25/03/2021 15:05, Laurent Pinchart wrote:
Hi Wan,
Thank you for the patch.
On Thu, Mar 25, 2021 at 07:10:24PM +0800, Wan Jiabing wrote:
struct dss_device has been declared. Remove the duplicate.
And sort these forward declarations alphabetically.
Signed-off-by: Wan Jiabing
Reviewed-by:
On 06/04/2021 16:51, Thierry Reding wrote:
On Tue, Mar 16, 2021 at 04:11:30PM +0200, Tomi Valkeinen wrote:
Hi Sebastian, Sam, Thierry,
On 27/02/2021 23:45, Sebastian Reichel wrote:
From: Sebastian Reichel
Disable TE for Droid 4 panel, since implementation is currently
broken. Also disable
On 27/01/2021 03:51, menglong8.d...@gmail.com wrote:
> From: Menglong Dong
>
> The 'r' in dsi_vc_send_short() is of type 'unsigned int', so the
> 'r < 0' can't be true.
>
> Fix this by introducing a 'err' of type 'int' insteaded.
>
> Fixes: 1ed6253856cb ("drm/omap: dsi: switch dsi_vc_send_long/
Dropped the @ti.com addresses and added the new ones.
Tomi
On 29/01/2021 07:58, quanyang.w...@windriver.com wrote:
> From: Quanyang Wang
>
> When run xrandr to change resolution on Beaglebone Black board, it will
> print the error information:
>
> root@beaglebone:~# xrandr -display :0 --outpu
On 08/02/2021 19:55, Tony Lindgren wrote:
> Hi,
>
> * Tomi Valkeinen [201124 12:47]:
>> From: Sebastian Reichel
>>
>> In preparation for removing custom DSS calls from the DSI
>> panel driver, this moves support for external tearing event
>> GPIOs int
Adding Jyri with the non-TI address.
Tomi
On 14/02/2021 15:16, Dario Binacchi wrote:
> The fdd property of the tilcdc_panel_info structure must set the reqdly
> bit field (bit 12 to 19) of the raster control register. The previous
> statement set the least significant bit instead.
>
> Signed-o
ot blow up LCDC totally?
The fix looks correct to me, but it will change the register value for
boards that have apparently been working for years.
Dario, did you test this on actual HW, or did you just spot the error?
Reviewed-by: Tomi Valkeinen
Tomi
On 11/02/2021 19:35, Tony Lindgren wrote:
> * Tomi Valkeinen [210211 07:35]:
>> On 08/02/2021 19:55, Tony Lindgren wrote:
>>> Hi,
>>>
>>> * Tomi Valkeinen [201124 12:47]:
>>>> From: Sebastian Reichel
>>>>
>>>> In prepar
Hi Hans,
On 11/02/2021 12:37, Hans Verkuil wrote:
> Add cec clock to the dra7 and omap5 device trees.
>
> Signed-off-by: Hans Verkuil
> ---
> arch/arm/boot/dts/dra7.dtsi | 5 +++--
> arch/arm/boot/dts/omap5.dtsi | 5 +++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/ar
Hi Hans,
On 11/02/2021 12:37, Hans Verkuil wrote:
> Add HDMI CEC support for OMAP5.
>
> Many thanks to Tomi for helping out how to enable CEC for omap5.
>
> Signed-off-by: Hans Verkuil
> Thanks-to: Tomi Valkeinen
> ---
> drivers/gpu/drm/omapdrm/dss/Kconfig |
idge_connector.c | 23 +++
> include/drm/drm_bridge.h | 31 ++
> 2 files changed, 54 insertions(+)
Reviewed-by: Tomi Valkeinen
Tomi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedeskt
> drivers/gpu/drm/omapdrm/dss/hdmi4.c | 28 +
> drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 8 ---
> drivers/gpu/drm/omapdrm/dss/hdmi4_cec.h | 7 ---
> 3 files changed, 28 insertions(+), 15 deletions(-)
Revie
---
> drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 4 ++--
> drivers/gpu/drm/omapdrm/dss/hdmi4_cec.h | 5 +++--
> 3 files changed, 7 insertions(+), 15 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
___
dri-devel mailing list
dri-devel@
gt;
>> arch/arm/boot/dts/dra7.dtsi | 5 +-
>> arch/arm/boot/dts/omap5.dtsi | 5 +-
>> drivers/gpu/drm/drm_bridge_connector.c | 23 +++
>> drivers/gpu/drm/omapdrm/dss/Kconfig | 8 +
>> drivers/gpu/drm/omapdrm/dss/Makefile | 1 +
&
On 18/02/2021 07:57, Tony Lindgren wrote:
> * Tomi Valkeinen [210217 07:42]:
>> On 11/02/2021 19:35, Tony Lindgren wrote:
>>> * Tomi Valkeinen [210211 07:35]:
>>>> On 08/02/2021 19:55, Tony Lindgren wrote:
>>>>> Hi,
>>>>>
>>&g
On 25/02/2021 14:46, Tony Lindgren wrote:
* Tomi Valkeinen [210222 08:47]:
On 18/02/2021 07:57, Tony Lindgren wrote:
Oh cool that you have those running again/still :) In this case there
is no te-gpios if that might make a difference.
No, GPIO TE is not used on OMAP4 SDP either.
OK
So
On 27/02/2021 23:45, Sebastian Reichel wrote:
From: Sebastian Reichel
Disable TE for Droid 4 panel, since implementation is currently
broken. Also disable it for N950 panel, which is untested.
Reported-by: Tony Lindgren
Reported-by: Tomi Valkeinen
Fixes: 4c1b935fea54 ("drm/omap: dsi:
-names: "fck", "sys_clk", "cec"
Optional nodes:
- Video port for HDMI output
Reviewed-by: Tomi Valkeinen
Tomi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
kctrl
OMAP5_DSS_CORE_CLKCTRL 11>;
+ clock-names = "fck", "sys_clk",
"cec";
dmas = <&sdma 76>;
dma-names = "audio_tx&quo
everything else uses tabs.
Other than that:
Reviewed-by: Tomi Valkeinen
Tomi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
* The @connector_detach callback is optional.
+*/
+ void (*connector_detach)(struct drm_bridge *bridge,
+ struct drm_connector *conn);
};
/**
Reviewed-by: Tomi Valkeinen
I can take this series as it's mostly omapdrm, but w
On 05/05/2021 14:12, Tony Lindgren wrote:
* Tony Lindgren [210503 12:18]:
I think we still fix the dispc related issue too, otherwise the parent
child_count will just keep increasing on each suspend. I check that
again though.
After tons more debugging, I found the root cause for the parent c
quired in other places.
>
> Signed-off-by: Nikhil Devshatwar
> Reviewed-by: Swapnil Jakhade
Reviewed-by: Tomi Valkeinen
I think this is fine as a fix for this issue, but at some point the irq
management needs some work.
E.g. we call cdns_mhdp_bridge_hpd_enable when attaching/enabling t
as possible.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/display-connector.c | 46 +-
1 file changed, 44 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/display-connector.c
b/drivers/gpu/drm/bridge/display-connector.c
index 4d278573cdb9..04362
even if there is, I don't want to guess what
it could look like, and could it be part of the dp-connector binding.
* No DP++. I'm not familiar with DP++. DP++ might need an i2c bus added
to the bindings.
Signed-off-by: Tomi Valkeinen
Cc: Rob Herring
---
.../displa
Hi,
This series adds the DT bindings and a driver for DisplayPort connector.
This is a resend of
https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg326794.html
with no changes (rebased on top of latest drm-misc).
Tomi
Tomi Valkeinen (2):
dt-bindings: dp-connector: add binding
efconfig: Update for moved DSI command mode panel
Tomi Valkeinen (31):
drm/omap: squash omapdrm sub-modules into one
drm/omap: remove unused display.c
drm/omap: drop unused owner field
drm/omap: remove dispc_ops
drm/omap: remove dss_mgr_ops
drm/panel: panel-dsi-cm: use MIPI_DCS_GET_
From: Sebastian Reichel
This reverts commit e086558ae923 ("drm/omap: dss: Remove unused
omap_dss_device operations")
This is still needed by DSI. E.g. unloading modules without this will
cause a crash.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-b
From: Sebastian Reichel
This converts the panel-dsi-cm driver to use the transfer
API instead of specific functions, so that the specific
functions can be unexported and squashed into the generic
transfer function.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Acked-by
From: Sebastian Reichel
After converting all DSI drivers, unexport the specific transfer
functions.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 12
drivers/gpu/drm/omapdrm/dss/omapdss.h
From: Sebastian Reichel
The write buffers are not modified, so they can be constant.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 24
drivers/gpu/drm/omapdrm/dss/omapdss.h
From: Sebastian Reichel
This replaces OMAP specific enum for pixel format with
common implementation.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 +-
drivers/gpu/drm/omapdrm/dss/dsi.c
From: Sebastian Reichel
The panel-dsi-cm's ddata->pin_config is always NULL, so this
callback is never called. Instead the DSI encoder gets the pin
configuration directly from DT.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
dri
From: Sebastian Reichel
Simplify the write related messages handling by using the functionality
provided by CONFIG_DRM_MIPI_DSI.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/Kconfig | 1 +
drivers/gpu/drm
: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 121 +-
drivers/gpu/drm/omapdrm/dss/dsi.c | 53 ++--
drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 -
3 files changed, 102 insertions
From: Sebastian Reichel
memory_read is not used, so we can drop the code.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 93 ---
drivers/gpu/drm/omapdrm/dss/omapdss.h
From: Sebastian Reichel
The get_te() callback is not used, so we can drop the
custom API.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 13 -
drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
2 files
From: Sebastian Reichel
Use dsi->channel everywhere, which originates from DT.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 20 +++
1 file changed, 7 insertions(+),
el, after which we can do that
work with the proper APIs.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 11 ++---
drivers/gpu/drm/omapdrm/dss/dsi.c | 46 ---
drivers/
patches.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 54 +++
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ++
2 files changed, 57 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm
acquisition follows works in the same way as the
exynos DSI implementation.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 103 +---
drivers/gpu/drm/omapdrm/dss/dsi.c | 146 --
2 files changed
From: Sebastian Reichel
After converting the driver to mipi_dsi_device we can use the generic
message helpers to simplify the driver a lot.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 125
From: Sebastian Reichel
Simplify the read related message handling by using the functionality
provided by CONFIG_DRM_MIPI_DSI.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 110
From: Sebastian Reichel
Drop local definition of common MIPI DCS 1.3 defines.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
the latter will get dropped.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 24 +---
drivers/gpu/drm/omapdrm/dss/dsi.c | 61 ---
drivers/gpu/drm/omapdrm/dss/omapdss.h
From: Sebastian Reichel
Use bulk regulator API to simplify the code. This also switches
from _optional variant to normal variant, which will provide a
dummy regulator (i.e. if some always-enabled regulator is not
described in DT).
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
From: Sebastian Reichel
The DSI sync() function only locks the bus and then releases
it again. Currently the only invocation is directly before
update(), which locks the bus anyways.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
.../gpu/drm/omapdrm/displays/panel-dsi
From: Sebastian Reichel
enable_te() is not used, so the custom API can be dropped.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 39 ---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 -
2 files changed
From: Sebastian Reichel
Integrate low-power / high-speed bus switching into transfer
function and drop the omapdrm specific enable_hs() callback.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
nel driver moving it a bit further to a
standard drm_panel driver.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 74 +--
drivers/gpu/drm/omapdrm/omap_encoder.c| 28 ++
From: Sebastian Reichel
Simplify the DSI encoder by using mipi_dsi_msg for
dsi_vc_send_long and dsi_vc_send_short. Further improvements
require cleaning up the channel allocation code first.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
From: Sebastian Reichel
Create a custom function pointer for ULPS and use it instead of
reusing disable/enable functions for ULPS mode switch. This allows
us to use the common disable/enable functions pointers for DSI.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
From: Sebastian Reichel
Instead of using the custom enable_te() API, this automatically
enables/disables TE core support when a matching packet is sent
to the panel.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
.../gpu/drm/omapdrm/displays
From: Sebastian Reichel
This converts the DSI module to expect common drm_panel display
drivers instead of dssdev based ones.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 203 +++---
drivers/gpu/drm/omapdrm/dss
From: Sebastian Reichel
The table of compatible values needed to be prefixed with "omapdss,"
is empty, so all of this code is doing nothing now. Let's drop it.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/
From: Sebastian Reichel
This moves the bus locking into the host driver and unexports
the custom API in preparation for drm_panel support.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 44 +--
drivers/gpu
ities.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 ---
drivers/gpu/drm/omapdrm/dss/dsi.c | 8
drivers/gpu/drm/omapdrm/dss/omapdss.h | 8 +---
drivers/gp
From: Sebastian Reichel
The panel driver is no longer using any OMAP specific APIs, so
let's move it into the generic panel directory.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Cc: Thierry Reding
Cc: Sam Ravnborg
Acked-by: Sam Ravnborg
Acked-by: Laurent Pin
-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
index 19d629a976c5..35a0c7da1974
From: Sebastian Reichel
This moves the panel refresh/update function from the panel
driver into the DSI host driver to prepare for common drm_panel
support.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 68
From: Sebastian Reichel
Remove unused code. Connectors are now created via drm_bridge_connector_init()
and no longer OMAP specific.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/Makefile | 1 -
drivers/gpu
From: Sebastian Reichel
In order to reduce the amount of custom functionality, this moves
handling of pixel format and DSI mode from set_config() to dsi
attach.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 --
drivers
From: Sebastian Reichel
We can simply provide the device to the omapdrm driver
via pdata. omapdss_is_initialized() is no longer required
(even before this patch), since omapdrm device is only
registered after the pointer is initialized.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi
From: Sebastian Reichel
Move ULPS handling into the DSI host controller, so that we
no longer need a custom API for the DSI client.
Note that for now ULPS is always disabled.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Acked-by: Laurent Pinchart
---
.../gpu/drm/omapdrm
From: Sebastian Reichel
All displays are now using a drm_panel or a drm_bridge that models the
connector instead of dssdev, so this field is always 0 and can be
dropped.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm
From: Sebastian Reichel
Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8
dssdev->owner is set, but never used. We can drop the field.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 1 -
drivers/gpu/drm/omapdrm/dss/dsi.c | 1 -
drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 -
drivers/gpu/drm/omapdrm/dss/hd
From: Sebastian Reichel
Now, that the driver implements the common DRM panel API
the unbind no longer needs to be suppressed.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Acked-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 5 ++---
1 file
Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 134 --
1 file changed, 89 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
b/drivers/gpu/drm/omapdrm/dss/dsi.c
index 549386f3897b
From: Sebastian Reichel
All DSS devices have been converted to bridge API, so
the device operations are always NULL. This removes
the device ops function pointers and all code using it.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers
From: Sebastian Reichel
Implement check timings, which will check if it's possible to
configure the clocks for the provided mode using the same code
as the set_config() hook.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dsi.c
From: Sebastian Reichel
Move dsi_ops into the main structure, since all other ops
are gone. Instead of checking the device type we can simply
check if dsi_ops are set.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm
Set the column & page address once during setup, instead of relying the
DSI host driver to set those.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/panel/panel-dsi-cm.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.
From: Sebastian Reichel
The omapdss device's ops_flags field is no longer
used and can be dropped.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 -
drivers/gpu/drm/omapdrm/dss/venc.c
The functions in display.c are not used, so drop the file.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/Makefile | 2 +-
drivers/gpu/drm/omapdrm/dss/display.c | 58 ---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 --
3
From: Sebastian Reichel
The DSI command mode panel is no longer specific
to OMAP and thus the config option has been renamed
slightly.
Signed-off-by: Sebastian Reichel
Signed-off-by: Tomi Valkeinen
Cc: Tony Lindgren
Reviewed-by: Laurent Pinchart
---
arch/arm/configs/omap2plus_defconfig | 2
Simplify and optimize dsi_vc_enable_hs() so that it can be called
without checking the current HS/LP mode. Make dsi_vc_enable_hs() return
if the VC is already in the correct mode.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 10 --
1 file changed, 4 insertions
1 - 100 of 3676 matches
Mail list logo
