Re: [PATCH] drm/panfrost: Fix module unload

2020-11-03 Thread Tomeu Vizoso
Looks good, thanks! Reviewed-by: Tomeu Vizoso On Fri, 30 Oct 2020 at 15:59, Steven Price wrote: > When unloading the call to pm_runtime_put_sync_suspend() will attempt to > turn the GPU cores off, however panfrost_device_fini() will have turned > the clocks off. This leads to the

Re: [PATCH v7 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-07 Thread Tomeu Vizoso
On 1/7/21 9:26 AM, Nicolas Boichat wrote: GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling, disable devfreq for now. Signed-off-by: Nicolas Boichat --- Changes in v7: - Fix GPU ID in commit message Changes in v6: - New change drivers/g

Re: [PATCH v7 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-07 Thread Tomeu Vizoso
On 1/7/21 9:49 AM, Nicolas Boichat wrote: On Thu, Jan 7, 2021 at 4:31 PM Tomeu Vizoso wrote: On 1/7/21 9:26 AM, Nicolas Boichat wrote: GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling, disable devfreq for now. Signed-off-by: Nicolas Boichat

Re: [PATCH v10 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-12 Thread Tomeu Vizoso
On 1/13/21 7:06 AM, Nicolas Boichat wrote: Hi! Follow-up on the v5 [1], things have gotten significantly better in the last 9 months, thanks to the efforts on Bifrost support by the Collabora team (and probably others I'm not aware of). I've been testing this series on a MT8183/kukui device, wi

Re: [PATCH] drm/panfrost: Avoid user size passed to kvmalloc()

2021-12-16 Thread Tomeu Vizoso
On 12/16/21 6:49 PM, Alyssa Rosenzweig wrote: This provides an easy method for user space to trigger the OOM killer (by temporarily allocating large amounts of kernel memory) panfrost user space has a lot of easy ways to trigger to the OOM killer unfortunately if this is something we want

[PATCH 08/12] i2c: core: Add support for 'i2c-bus' subnode

2016-08-02 Thread Tomeu Vizoso
On 23 June 2016 at 17:59, Jon Hunter wrote: > If the 'i2c-bus' device-tree node is present for an I2C adapter then > parse this subnode for I2C slaves. > > Signed-off-by: Jon Hunter > --- > drivers/i2c/i2c-core.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a

[PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-04 Thread Tomeu Vizoso
Remove code for reading the EDID and DPCD fields and use the helpers instead. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso Cc

[PATCH 08/12] i2c: core: Add support for 'i2c-bus' subnode

2016-08-04 Thread Tomeu Vizoso
On 2 August 2016 at 08:49, Jon Hunter wrote: > > On 02/08/16 07:26, Tomeu Vizoso wrote: >> On 23 June 2016 at 17:59, Jon Hunter wrote: >>> If the 'i2c-bus' device-tree node is present for an I2C adapter then >>> parse this subnode for I2C s

[Intel-gfx] [PATCH v3 3/3] drm/i915: Use new CRC debugfs API

2016-08-04 Thread Tomeu Vizoso
On 3 August 2016 at 10:01, Daniel Vetter wrote: > On Fri, Jul 22, 2016 at 04:10:45PM +0200, Tomeu Vizoso wrote: >> The core provides now an ABI to userspace for generation of frame CRCs, >> so implement the ->set_crc_source() callback and reuse as much code as >> possib

[PATCH v4 0/4] New debugfs API for capturing CRC of frames

2016-08-05 Thread Tomeu Vizoso
for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915

[PATCH v4 1/4] drm/i915/debugfs: Move out pipe CRC code

2016-08-05 Thread Tomeu Vizoso
In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/i915/Makefile

[PATCH v4 2/4] drm: Add API for capturing frame CRCs

2016-08-05 Thread Tomeu Vizoso
ze of an entry in a helper. - Add 0x prefix to hex numbers in the data file. - Remove unnecessary snprintf and strlen usage in read callback. Signed-off-by: Tomeu Vizoso --- Documentation/gpu/drm-uapi.rst| 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_c

[PATCH v4 3/4] drm/i915: Use new CRC debugfs API

2016-08-05 Thread Tomeu Vizoso
ommit. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/i915/i915_irq.c | 69 --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 2 + drivers/gpu/drm/i915/intel_pipe_crc.c | 124 -- 4 files chang

[PATCH v4 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

2016-08-05 Thread Tomeu Vizoso
Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-05 Thread Tomeu Vizoso
On 3 August 2016 at 09:06, Ville Syrjälä wrote: > On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: >> Adds files and directories to debugfs for controlling and reading frame >> CRCs, per CRTC: >> >> dri/0/crtc-0/crc >> dri/0/crtc-0/crc

[PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-05 Thread Tomeu Vizoso
Remove code for reading the EDID and DPCD fields and use the helpers instead. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso Tested

[PATCH v4 0/7] rk3399 support ddr frequency scaling

2016-08-05 Thread Tomeu Vizoso
On 29 July 2016 at 09:56, Lin Huang wrote: > rk3399 platform have dfi controller can monitor ddr load, > and dcf controller to handle ddr register so we can get the > right ddr frequency and make ddr controller happy work(which > will implement in bl31). So we do ddr frequency scaling with > follo

[PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-08 Thread Tomeu Vizoso
On 6 August 2016 at 19:04, Daniel Stone wrote: > Hi Tomeu, > > On 22 July 2016 at 15:10, Tomeu Vizoso wrote: >> +/** >> + * DOC: CRC ABI >> + * >> + * DRM device drivers can provide to userspace CRC information of each >> frame as >> + * it

[PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-08 Thread Tomeu Vizoso
the tools pick up your address for the right patches? Thanks, Tomeu > > - Yakir > > > > On 08/05/2016 08:59 PM, Tomeu Vizoso wrote: >> >> Remove code for reading the EDID and DPCD fields and use the helpers >> instead. >> >> Besides the obvious co

[PATCH v1 0/5] drm/rockchip: Implement CRC debugfs API

2016-08-09 Thread Tomeu Vizoso
to use it. Also had to add a connector backpointer to the AUX struct so we could wait for the right vblank and store the CRCs afterwards. Thanks, Tomeu Tomeu Vizoso (5): drm/dp: add connector backpointer to drm_dp_aux drm/bridge: analogix_dp: set connector to drm_dp_aux drm/dp: add

[PATCH v1 1/5] drm/dp: add connector backpointer to drm_dp_aux

2016-08-09 Thread Tomeu Vizoso
This backpointer allows DP helpers to access the connector it's being used for. Signed-off-by: Tomeu Vizoso --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 63b8bd502444..f66cc8501d71 1

[PATCH v1 2/5] drm/bridge: analogix_dp: set connector to drm_dp_aux

2016-08-09 Thread Tomeu Vizoso
Set the backpointer so that the DP helpers are able to access the connector that the drm_dp_aux is associated with. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH v1 4/5] drm/bridge: analogix_dp: add helpers for capture of frame CRCs

2016-08-09 Thread Tomeu Vizoso
Add two simple functions that just take the drm_dp_aux from our struct and calls the corresponding DP helpers with it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 16 include/drm/bridge/analogix_dp.h | 3 +++ 2 files

[PATCH v1 3/5] drm/dp: add helpers for capture of frame CRCs

2016-08-09 Thread Tomeu Vizoso
Adds helpers for starting and stopping capture of frame CRCs through the DPCD. When capture is on, a worker waits for vblanks and retrieves the frame CRC to put it in the queue on the CRTC that is using the eDP connector, so it's passed to userspace. Signed-off-by: Tomeu Vizoso --- driver

[PATCH v1 5/5] drm/rockchip: Implement CRC debugfs API

2016-08-09 Thread Tomeu Vizoso
Implement the .set_crc_source() callback and call the DP helpers accordingly to start and stop CRC capture. This is only done if this CRTC is currently using the eDP connector. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 48 + 1

[PATCH] drm/doc: Add a few words on validation with IGT

2016-08-23 Thread Tomeu Vizoso
Also provide some pointers for building IGT as some kernel hackers might not be that familiar with building stuff on Linux distros. Signed-off-by: Tomeu Vizoso Cc: Daniel Vetter --- Documentation/gpu/drm-uapi.rst | 37 + 1 file changed, 37 insertions

[PATCH] drm/panfrost: Only put sync_out if non-NULL

2019-05-09 Thread Tomeu Vizoso
ence. Signed-off-by: Tomeu Vizoso Reported-by: Dan Carpenter Link: https://lists.freedesktop.org/archives/dri-devel/2019-May/217014.html --- drivers/gpu/drm/panfrost/panfrost_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/driv

Re: [PATCH] drm/panfrost: Make devfreq truly optional

2019-05-14 Thread Tomeu Vizoso
On 5/14/19 5:36 PM, Ezequiel Garcia wrote: On Tue, 2019-05-14 at 08:38 -0500, Rob Herring wrote: On Mon, May 13, 2019 at 12:56 PM Ezequiel Garcia wrote: Currently, there is some logic to make devfreq optional, but it fails to cover some cases such as !CONFIG_PM_DEVFREQ. Fails how? compiling?

Re: [PATCH] drm/panfrost: Add AArch64 page table format support

2019-05-28 Thread Tomeu Vizoso
Robin, Steven, would you or someone else at Arm be able to run the IGT tests [0] on 5.2-rc2 with this patch on top? I don't have any hw with Bifrost and am not planning to work on the userspace any time soon, but I think it would be good to at least check that the kernel doesn't have any obvious

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-09 Thread Tomeu Vizoso
On Mon, 8 Apr 2019 at 23:04, Rob Herring wrote: > > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > > > > On 01/04/2019 08:47, Rob Herring wrote: > > > This adds the initial driver for panfrost which supports Arm Mali > > > Midgard and Bifrost family of GPUs. Currently, only the T860 and > >

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-10 Thread Tomeu Vizoso
On Wed, 10 Apr 2019 at 12:20, Steven Price wrote: > > On 08/04/2019 22:04, Rob Herring wrote: > > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > >> > >> On 01/04/2019 08:47, Rob Herring wrote: > >>> This adds the initial driver for panfrost which supports Arm Mali > >>> Midgard and Bifrost

Re: [PATCH v3 2/3] drm: Add a drm_gem_objects_lookup helper

2019-04-12 Thread Tomeu Vizoso
Acked-by: Tomeu Vizoso On Tue, 9 Apr 2019 at 22:54, Rob Herring wrote: > > Similar to the single handle drm_gem_object_lookup(), > drm_gem_objects_lookup() takes an array of handles and returns an array > of GEM objects. > > v2: > - Take the userspace pointer directly a

Re: [PATCH] drm/panfrost: Add support for 2MB page entries

2019-04-12 Thread Tomeu Vizoso
Acked-by: Tomeu Vizoso Thanks! Tomeu On Fri, 12 Apr 2019 at 09:27, Alyssa Rosenzweig wrote: > > Acked-by: Alyssa Rosenzweig > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/

Re: [PATCH -next] drm/panfrost: Make panfrost_gem_free_object() static

2019-04-17 Thread Tomeu Vizoso
Both patches are: Reviewed-by: Tomeu Vizoso Thanks! On 4/17/19 4:51 PM, Steven Price wrote: On 16/04/2019 16:00, Yue Haibing wrote: From: YueHaibing Fix sparse warning: drivers/gpu/drm/panfrost/panfrost_gem.c:17:6: warning: symbol 'panfrost_gem_free_object' was not declared.

[PATCH] drm/panfrost: Prevent concurrent resets

2019-04-18 Thread Tomeu Vizoso
If a job times out in slot 0 while a reset is performed because a job timed out in slot 1, the drm-sched core can get into a deadlock. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/panfrost/panfrost_device.c | 1 + drivers/gpu/drm/panfrost/panfrost_device.h | 1 + drivers/gpu/drm/panfrost

[PATCH] drm/panfrost: Add sanity checks to submit IOCTL

2019-04-24 Thread Tomeu Vizoso
So userspace can get feedback on any error conditions, instead of going ahead and things breaking later. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/panfrost/panfrost_drv.c | 35 + 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/panfrost: Add sanity checks to submit IOCTL

2019-04-24 Thread Tomeu Vizoso
On Wed, 24 Apr 2019 at 15:20, Daniel Vetter wrote: > > On Wed, Apr 24, 2019 at 03:13:53PM +0200, Tomeu Vizoso wrote: > > So userspace can get feedback on any error conditions, instead of going > > ahead and things breaking later. > > > > Signed-off-by: Tomeu V

Re: [PATCH v6 1/2] drm/sched: Refactor ring mirror list handling.

2019-03-12 Thread Tomeu Vizoso
On Thu, 27 Dec 2018 at 20:28, Andrey Grodzovsky wrote: > > Decauple sched threads stop and start and ring mirror > list handling from the policy of what to do about the > guilty jobs. > When stoppping the sched thread and detaching sched fences > from non signaled HW fenes wait for all signaled HW

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-05-29 Thread Tomeu Vizoso
On Tue, 21 May 2019 at 18:11, Clément Péron wrote: > [snip] > [ 345.204813] panfrost 180.gpu: mmu irq status=1 > [ 345.209617] panfrost 180.gpu: Unhandled Page fault in AS0 at VA > 0x02400400 >From what I can see here, 0x02400400 points to the first byte of the first sub

Re: [PATCH] drm/panfrost: Add AArch64 page table format support

2019-05-29 Thread Tomeu Vizoso
On Wed, 29 May 2019 at 15:00, Robin Murphy wrote: > > Hi Tomeu, Rob, > > On 28/05/2019 08:03, Tomeu Vizoso wrote: > > Robin, Steven, > > > > would you or someone else at Arm be able to run the IGT tests [0] on > > 5.2-rc2 with this patch on top? > > >

Re: Panfrost impossible to probe without opp table

2019-05-31 Thread Tomeu Vizoso
On Wed, 29 May 2019 at 23:29, Clément Péron wrote: > > Hi, > > I have rebase my kernel on latest 5.2-rc2, and my panfrost driver is > no more probing. > > The issue is coming from f3617b449d0bcf3b5d80a97f51498dcf7463cf7e > drm/panfrost: Select devfreq > > Currently, there is some logic for

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-05-31 Thread Tomeu Vizoso
On Wed, 29 May 2019 at 19:38, Robin Murphy wrote: > > On 29/05/2019 16:09, Tomeu Vizoso wrote: > > On Tue, 21 May 2019 at 18:11, Clément Péron wrote: > >> > > [snip] > >> [ 345.204813] panfrost 180.gpu: mmu irq status=1 > >> [ 345.209617] panf

Re: Panfrost impossible to probe without opp table

2019-05-31 Thread Tomeu Vizoso
On Fri, 31 May 2019 at 14:03, Neil Armstrong wrote: > > Hi Tomeu, > > On 31/05/2019 13:59, Tomeu Vizoso wrote: > > On Wed, 29 May 2019 at 23:29, Clément Péron wrote: > >> > >> Hi, > >> > >> I have rebase my kernel on latest 5.2-rc2, and my

Re: [PATCH] drm/panfrost: Make sure a BO is only unmapped when appropriate

2019-05-31 Thread Tomeu Vizoso
On Wed, 29 May 2019 at 11:18, Boris Brezillon wrote: > > mmu_ops->unmap() will fail when called on a BO that has not been > previously mapped, and the error path in panfrost_ioctl_create_bo() > can call drm_gem_object_put_unlocked() (which in turn calls > panfrost_mmu_unmap()) on a BO that has not

Re: Panfrost impossible to probe without opp table

2019-06-04 Thread Tomeu Vizoso
On Mon, 3 Jun 2019 at 19:24, Clément Péron wrote: > > Hi, > > > On Fri, 31 May 2019 at 14:13, Neil Armstrong wrote: > > > > On 31/05/2019 14:09, Tomeu Vizoso wrote: > > > On Fri, 31 May 2019 at 14:03, Neil Armstrong > > > wrote: > > >>

Re: [PATCH] drm/panfrost: Require the simple_ondemand governor

2019-06-09 Thread Tomeu Vizoso
On 6/5/19 8:48 PM, Ezequiel Garcia wrote: Panfrost depends on the simple_ondemand governor, and therefore it's a required configuration. Select it. Fixes: f3617b449d ("drm/panfrost: Select devfreq") Signed-off-by: Ezequiel Garcia Good one, had totally forgotten about it. Rev

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-06-10 Thread Tomeu Vizoso
On Wed, 29 May 2019 at 19:38, Robin Murphy wrote: > > On 29/05/2019 16:09, Tomeu Vizoso wrote: > > On Tue, 21 May 2019 at 18:11, Clément Péron wrote: > >> > > [snip] > >> [ 345.204813] panfrost 180.gpu: mmu irq status=1 > >> [ 345.209617] panf

[PATCH i-g-t 1/2] lib/panfrost: Add support for SFBD to igt_panfrost_trivial_job

2019-06-11 Thread Tomeu Vizoso
T720 GPUs and older don't have support for MFBD, so use the SFBD structs instead. We don't know yet how to hang the GPU with SFBD descriptors, so for now skip that test. Signed-off-by: Tomeu Vizoso --- lib/igt_panfrost.c | 71 +- lib/igt_

[PATCH i-g-t 2/2] tests/panfrost: Fix couple of things so submit tests work on T720

2019-06-11 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- tests/panfrost_submit.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/tests/panfrost_submit.c b/tests/panfrost_submit.c index 5770dc24a42b..13ce85b73d9e 100644 --- a/tests/panfrost_submit.c +++ b/tests

Re: [RFC PATCH] drm/panfrost: Add support for mapping BOs on GPU page faults

2019-06-12 Thread Tomeu Vizoso
GPUs will be the most interesting to support... Will give this patch some testing tomorrow. Thanks, Tomeu > Cc: Robin Murphy > Cc: Steven Price > Cc: Alyssa Rosenzweig > Cc: Tomeu Vizoso > Signed-off-by: Rob Herring > --- > > drivers/gpu/drm/panfrost/TODO |

Re: [PATCH] drm/panfrost: Align GEM objects GPU VA to 2MB

2019-06-13 Thread Tomeu Vizoso
On Mon, 10 Jun 2019 at 18:58, Rob Herring wrote: > > In order to increase the chances of using 2MB pages, we need to align the > GPU VA mapping to 2MB. Only do this if the object size is 2MB or more. > > Cc: Robin Murphy > Cc: Steven Price > Cc: Tomeu Vizoso > Si

Re: [RFC PATCH] drm/panfrost: Add support for mapping BOs on GPU page faults

2019-06-16 Thread Tomeu Vizoso
On Fri, 14 Jun 2019 at 23:22, Rob Herring wrote: > > On Wed, Jun 12, 2019 at 6:55 AM Tomeu Vizoso wrote: > > > > On Mon, 10 Jun 2019 at 19:06, Rob Herring wrote: > > > > > > The midgard/bifrost GPUs need to allocate GPU memory which is allocated > > >

Re: [RFC PATCH] drm/panfrost: Add support for mapping BOs on GPU page faults

2019-06-19 Thread Tomeu Vizoso
On Mon, 17 Jun 2019 at 16:56, Rob Herring wrote: > > On Sun, Jun 16, 2019 at 11:15 PM Tomeu Vizoso > wrote: > > > > On Fri, 14 Jun 2019 at 23:22, Rob Herring wrote: > > > > > > On Wed, Jun 12, 2019 at 6:55 AM Tomeu Vizoso > > > wrote: > >

Re: [PATCH v3 1/2] drm/virtio: Add window server support

2019-03-18 Thread Tomeu Vizoso
[Tomasz wants to comment, adding him to CC] On 2/5/18 9:19 AM, Tomeu Vizoso wrote: On 1 February 2018 at 17:36, Gerd Hoffmann wrote: Hi, Sorry for joining the party late. Had a broken finger and was offline for a bunch of weeks (and a buif backlog afterwards ...). Hi, no problem, hope it&#

Re: [PATCH 4/5] drm/panfrost: Add support for GPU heap allocations

2019-07-23 Thread Tomeu Vizoso
On Tue, 23 Jul 2019 at 09:14, Alyssa Rosenzweig wrote: > > > A fair bit of the complexity of kbase comes from trying to avoid the > > possibility of one process DoSing another by submitting malicious jobs. > > ...and yet it was still doable so easily (by accident, with buggy jobs > instead of mali

Re: [PATCH RESEND] drm: Switch to use DEVFREQ_GOV_SIMPLE_ONDEMAND constant

2019-07-26 Thread Tomeu Vizoso
On 7/25/19 5:52 AM, Yue Hu wrote: From: Yue Hu Since governor name is defined by DEVFREQ framework internally, use the macro definition instead of using the name directly. Signed-off-by: Yue Hu Acked-by: Tomeu Vizoso --- drivers/gpu/drm/msm/msm_gpu.c | 3 ++- drivers

Re: [PATCH v5] drm: Add initial ci/ subdirectory

2022-08-11 Thread Tomeu Vizoso
ailures in the GitLab UI Signed-off-by: Tomeu Vizoso Reviewed-by: Neil Armstrong ---   Documentation/gpu/automated_testing.rst   | 84 ++   drivers/gpu/drm/ci/amdgpu-stoney-fails.txt    | 13 +++   drivers/gpu/drm/ci/amdgpu-stoney-flakes.txt   | 20 +   drivers/gpu/drm/ci/amd

[PATCH v6] drm: Add initial ci/ subdirectory

2022-08-16 Thread Tomeu Vizoso
ebase on top of latest drm-next - Lower priority of LAVA jobs to not impact Mesa CI as much - Update docs Signed-off-by: Tomeu Vizoso Reviewed-by: Neil Armstrong Reviewed-by: Rob Clark --- Documentation/gpu/automated_testing.rst | 86 +++ drivers/gpu/drm/ci/amdgpu-s

[RFC] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
know when a code change breaks those expectations. This will allow all contributors to drm/msm to reuse the infrastructure already in gitlab.freedesktop.org to test the driver on several generations of the hardware. Signed-off-by: Tomeu Vizoso --- Documentation/gpu/msm_automated_testing.rst

[RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
ecute tests that are going to skip on all boards Signed-off-by: Tomeu Vizoso --- Documentation/gpu/msm_automated_testing.rst | 70 + drivers/gpu/drm/msm/ci/gitlab-ci.yml | 11 ++ drivers/gpu/drm/msm/ci/msm.testlist | 148 ++ .../gpu/drm/m

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
On 5/10/22 9:39 PM, Jessica Zhang wrote: On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: +igt@kms_atomic_interruptible@legacy-setmode@pipe-a-edp-1 +igt@kms_atomic_interruptible@atomic-setmode@pipe-a-edp-1 +igt@kms_atomic_interruptible@legacy-dpms@pipe-a-edp-1 +igt@kms_atomic_interruptible@legacy

[RFC v3] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
ecute tests that are going to skip on all boards v3: - Remove tracking of dmesg output during test execution Signed-off-by: Tomeu Vizoso --- Documentation/gpu/msm_automated_testing.rst | 70 + drivers/gpu/drm/msm/ci/gitlab-ci.yml | 11 ++ drivers/gpu/drm/msm/ci/msm.tes

Re: [RFC v3] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Tomeu Vizoso
On 5/11/22 3:20 PM, Rob Clark wrote: On Tue, May 10, 2022 at 11:15 PM Tomeu Vizoso wrote: And use it to store expectations about what the drm/msm driver is supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-12 Thread Tomeu Vizoso
On 5/11/22 7:46 PM, Rob Clark wrote: On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: On Tue, 10 May 2022 at 22:26, Rob Clark wrote: On Tue, May 10, 2022 at 12:39 PM Jessica Zhang wrote: On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: And use it to store expectations about what the

[RFC v4] drm: Add initial ci/ subdirectory

2022-05-17 Thread Tomeu Vizoso
pass from expected results file, to reduce the size of in-tree files - Add docs about how to deal with outages in automated testing labs - Specify the exact SHA of the CI scripts to be used Signed-off-by: Tomeu Vizoso --- Documentation/gpu/automated_testing.rst | 84 +++ driver

Re: [RFC v4] drm: Add initial ci/ subdirectory

2022-05-17 Thread Tomeu Vizoso
On 5/17/22 11:18 AM, Neil Armstrong wrote: On 17/05/2022 10:16, Tomeu Vizoso wrote: And use it to store expectations about what the DRM drivers are supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test

Re: [PATCH] drm/rockchip: Detach from ARM DMA domain in attach_device

2022-07-05 Thread Tomeu Vizoso
Thanks, this fixes the DRM driver on 5.19-rc2 on the rk3288-veyron-jaq. Tested-by: Tomeu Vizoso Cheers, Tomeu On Wed, Jun 15, 2022 at 5:52 PM Steven Price wrote: > Since commit 1ea2a07a532b ("iommu: Add DMA ownership management > interfaces") the Rockchip display drive

[PATCH v7] drm: Add initial ci/ subdirectory

2022-08-29 Thread Tomeu Vizoso
ebase on top of latest drm-next - Lower priority of LAVA jobs to not impact Mesa CI as much - Update docs v7: - Rebase on top of latest drm-next Signed-off-by: Tomeu Vizoso Reviewed-by: Neil Armstrong Reviewed-by: Rob Clark --- Documentation/gpu/automated_testing.rst

[PATCH v5] drm: Add initial ci/ subdirectory

2022-07-26 Thread Tomeu Vizoso
ff-by: Tomeu Vizoso Reviewed-by: Neil Armstrong --- Documentation/gpu/automated_testing.rst | 84 ++ drivers/gpu/drm/ci/amdgpu-stoney-fails.txt| 13 +++ drivers/gpu/drm/ci/amdgpu-stoney-flakes.txt | 20 + drivers/gpu/drm/ci/amdgpu-stoney-skips.txt| 2 + driver

Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-07 Thread Tomeu Vizoso
On 10/7/19 6:09 AM, Neil Armstrong wrote: Hi Steven, On 07/10/2019 14:50, Steven Price wrote: Panfrost uses multiple schedulers (one for each slot, so 2 in reality), and on a timeout has to stop all the schedulers to safely perform a reset. However more than one scheduler can trigger a timeout

[PATCH] panfrost: Properly undo pm_runtime_enable when deferring a probe

2019-10-23 Thread Tomeu Vizoso
When deferring the probe because of a missing regulator, we were calling pm_runtime_disable even if pm_runtime_enable wasn't called. Move the call to pm_runtime_disable to the right place. Signed-off-by: Tomeu Vizoso Fixes: f4a3c6a44b35 ("drm/panfrost: Disable PM on probe failure&q

[PATCH v2] panfrost: Properly undo pm_runtime_enable when deferring a probe

2019-10-23 Thread Tomeu Vizoso
When deferring the probe because of a missing regulator, we were calling pm_runtime_disable even if pm_runtime_enable wasn't called. Move the call to pm_runtime_disable to the right place. Signed-off-by: Tomeu Vizoso Reported-by: Chen-Yu Tsai Cc: Robin Murphy Fixes: f4a3c6a44b35

Re: [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches)

2020-02-06 Thread Tomeu Vizoso
On 2/7/20 6:26 AM, Nicolas Boichat wrote: Hi! Follow-up on the v3: https://patchwork.kernel.org/cover/11331343/. The main purpose of this series is to upstream the dts change and the binding document, but I wanted to see how far I could probe the GPU, to check that the binding is indeed correct

Re: [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches)

2020-02-07 Thread Tomeu Vizoso
On 2/7/20 8:42 AM, Nicolas Boichat wrote: On Fri, Feb 7, 2020 at 2:18 PM Tomeu Vizoso wrote: On 2/7/20 6:26 AM, Nicolas Boichat wrote: Hi! Follow-up on the v3: https://patchwork.kernel.org/cover/11331343/. The main purpose of this series is to upstream the dts change and the binding

Re: [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches)

2020-02-10 Thread Tomeu Vizoso
On 2/10/20 4:39 AM, Nicolas Boichat wrote: On Fri, Feb 7, 2020 at 4:13 PM Tomeu Vizoso wrote: On 2/7/20 8:42 AM, Nicolas Boichat wrote: On Fri, Feb 7, 2020 at 2:18 PM Tomeu Vizoso wrote: Some more changes are still required to get devfreq working, and of course I do not have a userspace

Re: [PATCH v2] drm/panfrost: Don't try to map on error faults

2020-02-23 Thread Tomeu Vizoso
On Wed, 12 Feb 2020 at 21:22, Rob Herring wrote: > > From: Tomeu Vizoso > > If the exception type isn't a translation fault, don't try to map and > instead go straight to a terminal fault. > > Otherwise, we can get flooded by kernel warnings and further faults.

[PATCH] drm/panfrost: Don't try to map on error faults

2020-02-05 Thread Tomeu Vizoso
If the exception type isn't one of the normal faults, don't try to map and instead go straight to a terminal fault. Otherwise, we can get flooded by kernel warnings and further faults. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 +++-- 1 file

Re: [PATCH 0/2] drm/panfrost: Tidy up the devfreq implementation

2019-09-13 Thread Tomeu Vizoso
() misuse. This also deletes the code changes from 52282163dfa6 and e21dd290881b which would otherwise need reverting, see the previous discussion[2]. Both patches look great. Reviewed-by: Tomeu Vizoso Thanks! Tomeu [1] https://lore.kernel.org/lkml/20190904123032.23263-1-broo...@kernel

Re: [PATCH] MAINTAINERS: Add Steven and Alyssa as panfrost reviewers

2019-08-23 Thread Tomeu Vizoso
On 8/23/19 3:33 AM, Rob Herring wrote: Add Steven Price and Alyssa Rosenzweig as reviewers as they have been the primary reviewers already. Cc: Steven Price Cc: Alyssa Rosenzweig Cc: Tomeu Vizoso Signed-off-by: Rob Herring Acked-by: Tomeu Vizoso --- MAINTAINERS | 2 ++ 1 file

Re: [PATCH] drm/panfrost: Remove completed features still in TODO

2019-08-05 Thread Tomeu Vizoso
On 8/2/19 9:57 PM, Rob Herring wrote: There's a few features the driver supports which we forgot to remove, so remove them now. Cc: Tomeu Vizoso Cc: Boris Brezillon Signed-off-by: Rob Herring --- drivers/gpu/drm/panfrost/TODO | 9 - 1 file changed, 9 deletions(-) diff --

Re: [PATCH v3 0/8] drm/panfrost: Add heap and no execute buffer allocation

2019-08-05 Thread Tomeu Vizoso
On 8/2/19 9:51 PM, Rob Herring wrote: This series adds new BO allocation flags PANFROST_BO_HEAP and PANFROST_BO_NOEXEC. The heap allocations are paged in on GPU page faults. Tomeu reports he has tested this in the panfrost CI. All seems to be working fine: https://gitlab.freedesktop.org/tomeu

Re: [PATCH v3 0/8] drm/panfrost: Add heap and no execute buffer allocation

2019-08-05 Thread Tomeu Vizoso
On 8/5/19 11:10 PM, Rob Herring wrote: On Mon, Aug 5, 2019 at 10:10 AM Tomeu Vizoso wrote: On 8/2/19 9:51 PM, Rob Herring wrote: This series adds new BO allocation flags PANFROST_BO_HEAP and PANFROST_BO_NOEXEC. The heap allocations are paged in on GPU page faults. Tomeu reports he has

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-09 Thread Tomeu Vizoso
On 8/9/19 5:01 AM, Rob Herring wrote: On Thu, Aug 8, 2019 at 5:11 PM Alyssa Rosenzweig wrote: @@ -448,6 +453,7 @@ static irqreturn_t panfrost_job_irq_handler(int irq, void *data) } if (status & JOB_INT_MASK_DONE(j)) { + panfrost_mmu_as_put(p

Re: [PATCH] drm/panfrost: Queue jobs on the hardware

2019-08-19 Thread Tomeu Vizoso
On 8/16/19 11:31 AM, Steven Price wrote: The hardware has a set of '_NEXT' registers that can hold a second job while the first is executing. Make use of these registers to enqueue a second job per slot. I like this in principle, but upon some quick testing I found that Mesa is around 10% slow

Re: [PATCH 0/4] drm/panfrost: Plumb cycle counters to userspace

2021-05-27 Thread Tomeu Vizoso
Hi Alyssa, Will this be enough to implement GL_TIMESTAMP and GL_TIME_ELAPSED queries? Guess the DDK implements these as WRITE_VALUE jobs, and there's also a soft job BASE_JD_REQ_SOFT_DUMP_CPU_GPU_TIME that I guess is used for glGet*(GL_TIMESTAMP). Other DRM drivers use an ioctl for that instea

Re: [PATCH v5 7/7] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2023-02-01 Thread Tomeu Vizoso
On 2/1/23 14:26, Lucas Stach wrote: Hi Tomeu, Am Donnerstag, dem 01.12.2022 um 11:30 +0100 schrieb Tomeu Vizoso: This is a compute-only module marketed towards AI and vision acceleration. This particular version can be found on the Amlogic A311D SoC. The feature bits are taken from the Khadas

Re: [PATCH] drm/etnaviv: show number of NN cores in GPU debugfs info

2023-02-01 Thread Tomeu Vizoso
intf(m, "\t pixel_pipes: %d\n", gpu->identity.pixel_pipes); seq_printf(m, "\t vertex_output_buffer_size: %d\n", Hi Lucas, That looks good to me. Reviewed-by: Tomeu Vizoso Cheers, Tomeu

[PATCH 0/6] Support for the NPU in Vim3

2022-11-25 Thread Tomeu Vizoso
Hi, This series adds support for the Verisilicon VIPNano-QI NPU in the A311D as in the VIM3 board. The IP is very closeley based on previous Vivante GPUs, so the etnaviv driver works basically unchanged. Regards, Tomeu Tomeu Vizoso (6): dt-bindings: reset: meson-g12a: Add missing NNA reset

[PATCH 6/6] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2022-11-25 Thread Tomeu Vizoso
This is a compute-only module marketed towards AI and vision acceleration. This particular version can be found on the Amlogic A311D SoC. The feature bits are taken from the Khadas downstream kernel driver 6.4.4.3.310723AAA. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv

[PATCH v2 0/5] Support for the NPU in Vim3

2022-11-28 Thread Tomeu Vizoso
://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18986 Regards, Tomeu Tomeu Vizoso (5): dt-bindings: reset: meson-g12a: Add missing NNA reset dt-bindings: power: Add NNA power domain soc: amlogic: meson-pwrc: Add NNA power domain for A311D arm64: dts: Add DT node for the VIPNano-QI on the A311D drm

[PATCH v2 5/5] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2022-11-28 Thread Tomeu Vizoso
This is a compute-only module marketed towards AI and vision acceleration. This particular version can be found on the Amlogic A311D SoC. The feature bits are taken from the Khadas downstream kernel driver 6.4.4.3.310723AAA. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv

[PATCH v3 0/5] Support for the NPU in Vim3

2022-11-29 Thread Tomeu Vizoso
://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18986 v2: Move reference to RESET_NNA to npu node (Neil) v3: Fix indentation mistake (Neil) Regards, Tomeu Tomeu Vizoso (5): dt-bindings: reset: meson-g12a: Add missing NNA reset dt-bindings: power: Add G12A NNA power domain soc: amlogic: meson-pwrc: Add NNA

[PATCH v3 5/5] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2022-11-29 Thread Tomeu Vizoso
This is a compute-only module marketed towards AI and vision acceleration. This particular version can be found on the Amlogic A311D SoC. The feature bits are taken from the Khadas downstream kernel driver 6.4.4.3.310723AAA. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv

[PATCH v4 0/7] Support for the NPU in Vim3

2022-12-01 Thread Tomeu Vizoso
://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18986 v2: Move reference to RESET_NNA to npu node (Neil) v3: Fix indentation mistake (Neil) v4: Add warning when etnaviv probes on a NPU Regards, Tomeu Tomeu Vizoso (7): dt-bindings: reset: meson-g12a: Add missing NNA reset dt-bindings: power: Add G12A NNA power

[PATCH v4 5/7] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2022-12-01 Thread Tomeu Vizoso
This is a compute-only module marketed towards AI and vision acceleration. This particular version can be found on the Amlogic A311D SoC. The feature bits are taken from the Khadas downstream kernel driver 6.4.4.3.310723AAA. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv

[PATCH v4 7/7] drm/etnaviv: Warn when probing on NPUs

2022-12-01 Thread Tomeu Vizoso
Userspace is still not making full use of the hardware, so we don't know yet if changes to the UAPI won't be needed. Warn about it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etn

[PATCH v4 6/7] drm/etnaviv: Add nn_core_count to chip feature struct

2022-12-01 Thread Tomeu Vizoso
We will use these for differentiating between GPUs and NPUs, as the downstream driver does. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 3 +++ drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 5 + 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/etnaviv

[PATCH v5 0/7] Support for the NPU in Vim3

2022-12-01 Thread Tomeu Vizoso
://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18986 v2: Move reference to RESET_NNA to npu node (Neil) v3: Fix indentation mistake (Neil) v4: Add warning when etnaviv probes on a NPU (Lucas) v5: Reorder HWDB commit to be the last (Lucas) Regards, Tomeu Tomeu Vizoso (7): dt-bindings: reset: meson-g12a: Add

[PATCH v5 5/7] drm/etnaviv: Add nn_core_count to chip feature struct

2022-12-01 Thread Tomeu Vizoso
We will use these for differentiating between GPUs and NPUs, as the downstream driver does. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 3 +++ drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 4 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/etnaviv

[PATCH v5 6/7] drm/etnaviv: Warn when probing on NPUs

2022-12-01 Thread Tomeu Vizoso
Userspace is still not making full use of the hardware, so we don't know yet if changes to the UAPI won't be needed. Warn about it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etn

  1   2   3   4   5   >