[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-05 Thread Tomasz Figa
rm, exynos_drm_fimd_driver_ids); If I see correctly, this will crash on a null pointer dereference on Exynos4 without DT, because of NULL driver_data. P.S. I think you should CC linux-arm-kernel and linux-samsung-soc lists when submitting patches related to ARM and Samsung SoCs. Best regards, -- Tomasz Figa Samsung Poland R&D Center

Re: [RFC v2 0/5] Common Display Framework

2012-12-21 Thread Tomasz Figa
gt; > o write data > > o write command > > § MIPI DSI will be registered as bus_register() > > When MIPI DSI probe is called, it (e.g., Exynos or OMAP MIPI DSI) will > initialize the MIPI DSI HW IP. > > This probe will also parse the DT file for MIPI DSI based

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Tomasz Figa
Hi Laurent, On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > Hi Tomasz, > > On Friday 21 December 2012 11:00:52 Tomasz Figa wrote: > > On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote: > > > On 17 December 2012 20:55, Laurent Pinchart

Re: [RFC 0/6] Common Display Framework-T

2012-12-31 Thread Tomasz Figa
--- > > > > > > Tomi's proposal split the display entities into video sources > > > (struct > > > video_source) and display entities (struct display_entity). To make > > > generic pipeline operations easier, we agreed to merge the video > >

Re: [PATCH 2/2] [RFC] video: display: Adding frame related ops to MIPI DSI video source struct

2013-01-03 Thread Tomasz Figa
and clear_frame_done do not look at anything used at the moment and if frame done status monitoring will be ever needed, I think a better way should be implemented. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform __

Re: [RFC v2 0/5] Common Display Framework

2013-01-08 Thread Tomasz Figa
On Tuesday 08 of January 2013 11:12:26 Marcus Lorentzon wrote: > On 01/08/2013 09:18 AM, Laurent Pinchart wrote: > > On Thursday 27 December 2012 15:43:34 Tomasz Figa wrote: > >> > On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > >>> > &g

[RFC PATCH 0/4] Common Display Framework-TF

2013-01-30 Thread Tomasz Figa
nd with some hacks to provide control over entity state to userspace using lcd device. However it can be used to demonstrate video source ops in use. Feel free to comment as much as you can. Tomasz Figa (4): video: add display-core video: add makefile & kconfig video: display

[RFC PATCH 1/4] video: add display-core

2013-01-30 Thread Tomasz Figa
Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/display-core.c | 295 +++ include/video/display.h | 230 +++ 2 files changed, 525 insertions(+) create mode 100644 drivers/video/display

[RFC PATCH 2/4] video: add makefile & kconfig

2013-01-30 Thread Tomasz Figa
Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/Kconfig | 1 + drivers/video/Makefile | 1 + drivers/video/display/Kconfig | 10 ++ drivers/video/display/Makefile | 1 + 4 files changed, 13 insertions(+) create mode 100644 drivers/video

[RFC PATCH 3/4] video: display: Add exynos-dsi video source driver

2013-01-30 Thread Tomasz Figa
This patch adds new driver for DSI master block available in Samsung Exynos SoCs. The driver is designed and written specifically for Common Display Framework. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/Kconfig |3 + drivers/video/display

[RFC PATCH 4/4] video: display: Add Samsung s6e8ax0 display panel driver

2013-01-30 Thread Tomasz Figa
This patch adds Common Display Framework driver for Samsung s6e8ax0 MIPI DSI display panel. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/Kconfig |3 + drivers/video/display/Makefile|1 + drivers/video/display/panel-s6e8ax0.c | 1027

Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-05 Thread Tomasz Figa
rm, exynos_drm_fimd_driver_ids); If I see correctly, this will crash on a null pointer dereference on Exynos4 without DT, because of NULL driver_data. P.S. I think you should CC linux-arm-kernel and linux-samsung-soc lists when submitting patches related to ARM and Samsung SoCs. Best regards, -- Tom

Re: [PATCH 1/3] Move FIMD register headers to include/video/

2012-08-01 Thread Tomasz Figa
(0x10)) > > In this case, the FIMD driver does not need to change. > Also, one binary is available. > This would look good indeed, but there are some drawbacks: - it would not scale nicely for future SoCs using the new FIMD - it would add the overhead of checking SoC ID for every access

Re: [RFC PATCH 0/4] Common Display Framework-TF

2013-02-03 Thread Tomasz Figa
Hi Laurent, On Saturday 02 of February 2013 11:39:59 Laurent Pinchart wrote: > Hi Tomasz, > > Thank you for your RFC. > > On Wednesday 30 January 2013 16:38:59 Tomasz Figa wrote: > > Hi, > > > > After pretty long time of trying to adapt Exynos-specific DSI disp

Re: [RFC PATCH 4/4] video: display: Add Samsung s6e8ax0 display panel driver

2013-02-07 Thread Tomasz Figa
On Thursday 07 of February 2013 15:04:30 Vikas Sajjan wrote: > Hi Figa, > > On Wed, Jan 30, 2013 at 9:09 PM, Tomasz Figa wrote: > > This patch adds Common Display Framework driver for Samsung s6e8ax0 > > MIPI DSI display panel. > > > > Signed-off-by: Tomasz

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi, On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > On 8 April 2013 16:37, Vikas Sajjan wrote: > > While migrating to common clock framework (CCF), I found that the FIMD > > clocks were pulled down by the CCF. > > If CCF finds any clock(s) which has NOT been claimed by any of the > > dr

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote: > On 20 April 2013 20:56, Inki Dae wrote: > > Sorry for being late. I think clk_prepare/unprepare are nothing to do > > yet in case of Exynos but those might be used for in the future so > > your patch looks good to me as is. > > > > Applied

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi Inki, On Sunday 21 of April 2013 23:05:45 Inki Dae wrote: > 2013/4/21 Tomasz Figa > > > On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote: > > > On 20 April 2013 20:56, Inki Dae wrote: > > > > Sorry for being late. I think clk_prepare/unprepare are not

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi Inki, On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > 2013/4/21 Tomasz Figa > > > Hi, > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > On 8 April 2013 16:37, Vikas Sajjan wrote: > > > > While migrating to c

[PATCH] MAINTAINERS: Add linux-samsung-soc list to all related entries

2013-04-21 Thread Tomasz Figa
, even though they are related to Samsung SoCs. This patch adds pointers to linux-samsung-soc mailing list to affected entries of MAINTAINERS file. Signed-off-by: Tomasz Figa --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6c0d68b

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > > > 2013/4/21 Tomasz Figa > > > > > > > Hi, > > > > > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > > > On 8 April 2013 16:37, Vikas Sajjan wrote: >

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: > On 21 April 2013 20:13, Tomasz Figa wrote: > > 3) after those two changes, all that remains is to fix compliance with > > Common Clock Framework, in other words: > > > > s/clk_enable/clk_prepare_enable/ > >

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
t; > How about making the driver dependant on PM_RUNTIME and making it always > use pm_runtime_* API, regardless if the platform actually implements runtime > PM or not ? Is there any issue in using the Runtime PM core always, rather > than coding any workarounds in drivers when PM

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 12:05:49 Sylwester Nawrocki wrote: > On 04/22/2013 11:56 AM, Tomasz Figa wrote: > > On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: > >> On 21 April 2013 20:13, Tomasz Figa wrote: > >>> 3) after those two changes, all that rem

Re: [PATCH] drm/exynos: fix multiple definition build error

2013-04-26 Thread Tomasz Figa
Hi Inki, On Friday 26 of April 2013 14:03:10 Inki Dae wrote: > This patch fixes multiple definition error like below when building it > as moudle with device tree support. > > drivers/gpu/drm/exynos/exynos_drm_g2d.o: In function `.LANCHOR1': > exynos_drm_g2d.c:(.rodata+0x6c): multiple definition

Re: [PATCH] drm/exynos: fix multiple definition build error

2013-04-26 Thread Tomasz Figa
On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote: > On 04/26/2013 10:20 AM, Inki Dae wrote: > > Exactly right. it's my mistake. But now it seems that > > __mode_of_device_table is multi defined at fimd and g2d side so there > > still is module build error. :( > Since all drivers seem to

[PATCH 0/4] drm/exynos: fimd: Add support for S3C6400/S3C6410

2013-05-01 Thread Tomasz Figa
Tree support: Tested-by: Tomasz Figa Tomasz Figa (4): drm/exynos: fimd: Hold pointer to driver data in context struct drm/exynos: fimd: Add support for FIMD versions without SHADOWCON register drm/exynos: fimd: Add support for FIMD variants with clock selection drm/exynos: fimd: Add

[PATCH 1/4] drm/exynos: fimd: Hold pointer to driver data in context struct

2013-05-01 Thread Tomasz Figa
This patch adds pointer to driver data to fimd_context structure, to remove the need to call drm_fimd_get_driver_data() each time access to driver data is necessary. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[PATCH 2/4] drm/exynos: fimd: Add support for FIMD versions without SHADOWCON register

2013-05-01 Thread Tomasz Figa
data. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 69 +++- 1 file changed, 49 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 264434f..a5559f6 100644

[PATCH 3/4] drm/exynos: fimd: Add support for FIMD variants with clock selection

2013-05-01 Thread Tomasz Figa
patch sets the selection bitfield to use the special clock. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index a5559f6..a2e385d

[PATCH 4/4] drm/exynos: fimd: Add support for S3C64xx SoCs

2013-05-01 Thread Tomasz Figa
The FIMD block present on S3C6400/S3C6410 SoCs is compatible with this driver, so it can be supported by it as well. This patch adds appropriate device IDs and driver data to enable this driver for S3C64xx SoCs. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 10

[PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-05-01 Thread Tomasz Figa
retrieved, in addition to standard video timings. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c

DMA mapping API abuse in exynos-drm

2013-05-04 Thread Tomasz Figa
Hi, Recently I've been working a bit on a DRM driver for the GPU of Samsung S3C6410 SoCs, which required me to familiarize a bit with exynos-drm, as it already contains a KMS driver which is compatible with the SoC I'm working with, making it a good place to put my driver in. Reading through e

Re: Introduce a new helper framework for buffer synchronization

2013-05-13 Thread Tomasz Figa
Hi, On Monday 13 of May 2013 20:24:01 Inki Dae wrote: > > -Original Message- > > From: Maarten Lankhorst [mailto:maarten.lankho...@canonical.com] > > Sent: Monday, May 13, 2013 6:52 PM > > To: Inki Dae > > Cc: 'Rob Clark'; 'Daniel Vetter'; 'DRI mailing list'; linux-arm- > > ker...@lists.in

Re: [PATCH 0/4] drm/exynos: fimd: Add support for S3C6400/S3C6410

2013-05-19 Thread Tomasz Figa
Hi, On Wednesday 01 of May 2013 21:02:25 Tomasz Figa wrote: > Much of the code in Exynos DRM subsystem is generic enough to use > it for older (non-Exynos) Samsung SoCs as well, after minor > modifications. > > This series starts adding support for previous SoCs to Exynos DRM b

Re: [PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-05-19 Thread Tomasz Figa
Hi, On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote: > On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote: > > This patch modifies the driver to perform two stage parsing of video > > timings from device tree, to get timing information as struct > > vide

Re: [PATCH] drm/exynos: wait for the completion of pending page flip

2013-05-22 Thread Tomasz Figa
Hi Inki, On Wednesday 22 of May 2013 15:37:14 Inki Dae wrote: > 2013/5/22 Stéphane Marchesin > > > On Tue, May 21, 2013 at 9:22 PM, Inki Dae wrote: > > > 2013/5/22 Stéphane Marchesin > > > > > >> On Tue, May 21, 2013 at 1:08 AM, Inki Dae wrote: > > >> > This patch fixes the issue that drm_

Re: [PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-06-05 Thread Tomasz Figa
On Wednesday 01 of May 2013 21:06:09 Tomasz Figa wrote: > This patch modifies the driver to perform two stage parsing of video > timings from device tree, to get timing information as struct videomode, > which contains more data than struct fb_videomode. > > Thanks to this chan

Re: [PATCH 0/4] drm/exynos: fimd: Add support for S3C6400/S3C6410

2013-06-05 Thread Tomasz Figa
On Sunday 19 of May 2013 13:26:57 Tomasz Figa wrote: > Hi, > > On Wednesday 01 of May 2013 21:02:25 Tomasz Figa wrote: > > Much of the code in Exynos DRM subsystem is generic enough to use > > it for older (non-Exynos) Samsung SoCs as well, after minor > > modifica

Re: [PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-06-06 Thread Tomasz Figa
Hi Joonyoung, On Thursday 06 of June 2013 13:30:49 Joonyoung Shim wrote: > On 05/19/2013 08:32 PM, Tomasz Figa wrote: > > Hi, > > > > On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote: > >> On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote: > &

Re: [PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-19 Thread Tomasz Figa
Hi Rahul, On Tuesday 18 of June 2013 18:19:35 Rahul Sharma wrote: > This patch renames the combatible strings for hdmi, mixer, ddc > and hdmiphy. It follows the convention of using compatible string > which represent the SoC in which the IP was added for the first > time. > > Signed-off-by: Rahul

Re: [PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-19 Thread Tomasz Figa
o:dri-devel-bounces+inki.dae=samsung@lists.freedesktop.org] On > >> Behalf Of Lucas Stach > >> Sent: Wednesday, June 19, 2013 4:59 PM > >> To: Tomasz Figa > >> Cc: kgene@samsung.com; devicetree-disc...@lists.ozlabs.org; > >> sw0312@samsung.com; jo.

Re: [PATCH v3 1/3] drm/exynos: add new compatible strings for hdmi subsystem

2013-06-20 Thread Tomasz Figa
Hi Rahul, On Thursday 20 of June 2013 07:41:53 Rahul Sharma wrote: > Hi Tomasz, Lucas, > > How does this patch look to you ? Please share your views. Looks fine now. Have my Reviewed-by: Tomasz Figa for the whole series. Best regards, Tomasz > regards, > Rahul Sharma. >

Re: [PATCH] drm/exynos: Add missing includes

2013-07-05 Thread Tomasz Figa
On Tuesday 02 of July 2013 16:04:49 Mark Brown wrote: > On Tue, Jul 02, 2013 at 09:21:32PM +0900, Inki Dae wrote: > > > Ensure that all externally accessed functions are correctly > > > prototyped > > > when defined in each file by making sure the headers with the > > > protoypes > > > are included

Re: [PATCH] drm/exynos: exynos_drm_ipp: fix return value check

2013-07-05 Thread Tomasz Figa
jun > --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Tomasz Figa Best regards, Tomasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org htt

Re: DT binding review for Armada display subsystem

2013-07-15 Thread Tomasz Figa
Hi, On Sunday 14 of July 2013 00:09:55 Russell King - ARM Linux wrote: > On Sun, Jul 14, 2013 at 12:16:58AM +0200, Sylwester Nawrocki wrote: > > On 07/13/2013 11:02 PM, Russell King - ARM Linux wrote: > >> On Sat, Jul 13, 2013 at 10:43:29PM +0200, Sylwester Nawrocki wrote: > >>> I wasn't aware of

Re: [PATCH 2/3] drm/exynos: add dt-binding documentation for rotator

2013-07-22 Thread Tomasz Figa
On Monday 22 of July 2013 16:00:22 Sylwester Nawrocki wrote: > On 07/22/2013 03:31 PM, Inki Dae wrote: > >> ---Original Message- > >> > >> > From: linux-samsung-soc-ow...@vger.kernel.org > >> > [mailto:linux-samsung-soc- ow...@vger.kernel.org] On Behalf Of > >> > Lucas Stach > >> > Sent: Monda

Re: [PATCH 1/3] drm/exynos: add device tree support for rotator

2013-07-22 Thread Tomasz Figa
On Monday 22 of July 2013 15:49:25 Chanho Park wrote: > The exynos4 platform is only dt-based since 3.10, we should convert > driver data and ids to dt-based parsing methods. The rotator driver has > a limit table to get size limit. The minimum size of RGB888 format is 8 > x 8 and maximum size is 8

[RFC v2 0/5] Common Display Framework

2012-12-21 Thread Tomasz Figa
PI DSI based panel, add > the panel device (device_add() ) to kernel and register the display > entity with its control and video ops with CDF. > > I can give this a try. I am currently in progress of reworking Exynos MIPI DSIM code and s6e8ax0 LCD driver to use the v2 RFC of Common Display Framework. I have most of the work done, I have just to solve several remaining problems. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform

[RFC v2 0/5] Common Display Framework

2012-12-27 Thread Tomasz Figa
Hi Laurent, On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > Hi Tomasz, > > On Friday 21 December 2012 11:00:52 Tomasz Figa wrote: > > On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote: > > > On 17 December 2012 20:55, Laurent Pinchart

[RFC 0/6] Common Display Framework-T

2012-12-31 Thread Tomasz Figa
--- > > > > > > Tomi's proposal split the display entities into video sources > > > (struct > > > video_source) and display entities (struct display_entity). To make > > > generic pipeline operations easier, we agreed to merge the video > >

Re: [PATCH 00/23] drm/exynos: Refactor parts of the exynos driver

2013-10-12 Thread Tomasz Figa
Hi Sean, On Thursday 10 of October 2013 20:30:13 Sean Paul wrote: > This patchset refactors parts of the exynos driver to move it closer to a > proper > drm driver (rather than just implementing a drm layer on top of the hardware > drivers). The hope is to get to a point where the dp/hdmi drivers

[PATCH V3 1/7] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-27 Thread Tomasz Figa
On 27.06.2014 15:02, Ajay kumar wrote: > Hi Andrej, > > On Fri, Jun 27, 2014 at 6:14 PM, Andrzej Hajda wrote: >> On 06/27/2014 01:48 PM, Ajay kumar wrote: >>> Hi Andrej, >>> >>> On Fri, Jun 27, 2014 at 4:52 PM, Andrzej Hajda >>> wrote: Hi Ajay, +CC DT On 06/27/2014 12:1

[RFC PATCH v2 00/21] Add DSI display support for Exynos based boards

2014-03-12 Thread Tomasz Figa
On 12.03.2014 11:08, Inki Dae wrote: > 2014-03-07 19:00 GMT+09:00 Andrzej Hajda : >> On 03/05/2014 03:56 AM, Inki Dae wrote: >>> Hi Andrzej, >>> >>> Thanks for your contributions. >>> >>> 2014-02-12 20:31 GMT+09:00 Andrzej Hajda : Hi, This patchset adds drivers and bindings to the fo

[PATCH] drm/exynos: set the active aspect ratio as per mode

2014-03-12 Thread Tomasz Figa
Hi Shirish, On 10.03.2014 04:44, Shirish S wrote: > now that the drm_display_mode also provides aspect > ratio for all resolutions, this patch adds its usage > to set the active aspect ratio of AVI info frame > packets as per CEA-861-D standard's Table 9. > > This is also needed to abide by the 7-

[PATCH] drm/exynos: add phy settings for RB resolutions

2014-03-12 Thread Tomasz Figa
Hi Shirish, On 10.03.2014 15:17, Shirish S wrote: > below is list of pixel clocks and resoluitons > this patch adds: > > 7100 - 1280x800 at 60Hz RB > 7325 - 800x600 at 120Hz RB > 8875 - 1440x900 at 60Hz RB > 11550 - 1024x768 at 120Hz RB > 11900 - 1680x1050 at 60Hz RB > > wit

[PATCH] drm/exynos: add hdmi power on/off sequence

2014-03-12 Thread Tomasz Figa
Hi Shirish, On 11.03.2014 12:26, Shirish S wrote: > This patch implements the power on/off sequence > (and its dependant functions) of HDMI exynos5250 > as provided by the hardware team. > > Signed-off-by: Shirish S > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 137 >

[PATCH v4 00/34] drm/exynos: Refactor parts of the exynos driver

2014-03-13 Thread Tomasz Figa
Hi Inki, On 13.03.2014 08:33, Inki Dae wrote: > Hi Sean, > > Merged your all patch series except for dt binding patches - it needs > more cleanups about ddc and phy - and I had a little change just for > cleanup. > And some more cleanups and enhanced feature set on top of your patch > series would

[PATCH v4 00/34] drm/exynos: Refactor parts of the exynos driver

2014-03-13 Thread Tomasz Figa
On 13.03.2014 16:48, Inki Dae wrote: > Hi Tomasz, > > 2014-03-13 23:05 GMT+09:00 Tomasz Figa : >> Hi Inki, >> >> >> On 13.03.2014 08:33, Inki Dae wrote: >>> >>> Hi Sean, >>> >>> Merged your all patch series except for dt binding

[PATCH] drm/exynos: add phy settings for RB resolutions

2014-03-18 Thread Tomasz Figa
+ > 1 file changed, 45 insertions(+) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH] drm/exynos: set the active aspect ratio as per mode

2014-03-18 Thread Tomasz Figa
0x01 > #define HDMI_AUI_LENGTH 0x0A > +#define AVI_SAME_AS_PIC_ASPECT_RATIO 0x8 > +#define AVI_4_3_CENTER_RATIO0x9 > +#define AVI_16_9_CENTER_RATIO 0xa One minor nitpick: Please don't use tabs between #define and macro name. After fixing this issue feel free to add my: Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH 0/9] Restore parallel display support for Exynos based boards

2014-03-18 Thread Tomasz Figa
+- > drivers/gpu/drm/exynos/exynos_drm_drv.h| 8 + > drivers/gpu/drm/exynos/exynos_drm_fb.c | 3 + > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 32 +- > 10 files changed, 432 insertions(+), 32 deletions(-) > create mode 100644 drivers/gpu/d

[PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-05-07 Thread Tomasz Figa
[CCing more DT-folks :)] On 07.05.2014 16:19, Rahul Sharma wrote: > On 7 May 2014 19:06, Tomasz Stanislawski wrote: >> On 05/07/2014 12:38 PM, Rahul Sharma wrote: >>> On 5 May 2014 15:14, Kishon Vijay Abraham I wrote: Hi, On Wednesday 09 April 2014 03:31 PM, Sylwester Nawrocki wro

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Tomasz Figa
Hi Rahul, Tomasz, On 14.05.2014 21:17, Rahul Sharma wrote: > From: Tomasz Stanislawski > > Add exynos-simple-phy driver to support a single register > PHY interfaces present on Exynos4 SoC. > > Signed-off-by: Tomasz Stanislawski > Signed-off-by: Rahul Sharma > > --- > .../devicetree/binding

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi, On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > On 8 April 2013 16:37, Vikas Sajjan wrote: > > While migrating to common clock framework (CCF), I found that the FIMD > > clocks were pulled down by the CCF. > > If CCF finds any clock(s) which has NOT been claimed by any of the > > dr

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote: > On 20 April 2013 20:56, Inki Dae wrote: > > Sorry for being late. I think clk_prepare/unprepare are nothing to do > > yet in case of Exynos but those might be used for in the future so > > your patch looks good to me as is. > > > > Applied

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi Inki, On Sunday 21 of April 2013 23:05:45 Inki Dae wrote: > 2013/4/21 Tomasz Figa > > > On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote: > > > On 20 April 2013 20:56, Inki Dae wrote: > > > > Sorry for being late. I think clk_prepare/unprepare are not

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi Inki, On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > 2013/4/21 Tomasz Figa > > > Hi, > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > On 8 April 2013 16:37, Vikas Sajjan wrote: > > > > While migrating to c

[PATCH] MAINTAINERS: Add linux-samsung-soc list to all related entries

2013-04-21 Thread Tomasz Figa
, even though they are related to Samsung SoCs. This patch adds pointers to linux-samsung-soc mailing list to affected entries of MAINTAINERS file. Signed-off-by: Tomasz Figa --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6c0d68b

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > > > 2013/4/21 Tomasz Figa > > > > > > > Hi, > > > > > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > > > On 8 April 2013 16:37, Vikas Sajjan > >

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: > On 21 April 2013 20:13, Tomasz Figa wrote: > > 3) after those two changes, all that remains is to fix compliance with > > Common Clock Framework, in other words: > > > > s/clk_enable/clk_prepare_enable/ > >

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
t; > How about making the driver dependant on PM_RUNTIME and making it always > use pm_runtime_* API, regardless if the platform actually implements runtime > PM or not ? Is there any issue in using the Runtime PM core always, rather > than coding any workarounds in drivers when PM

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 12:05:49 Sylwester Nawrocki wrote: > On 04/22/2013 11:56 AM, Tomasz Figa wrote: > > On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: > >> On 21 April 2013 20:13, Tomasz Figa wrote: > >>> 3) after those two changes, all that rem

[PATCH] drm/exynos: fix multiple definition build error

2013-04-26 Thread Tomasz Figa
Hi Inki, On Friday 26 of April 2013 14:03:10 Inki Dae wrote: > This patch fixes multiple definition error like below when building it > as moudle with device tree support. > > drivers/gpu/drm/exynos/exynos_drm_g2d.o: In function `.LANCHOR1': > exynos_drm_g2d.c:(.rodata+0x6c): multiple definition

[PATCH] drm/exynos: fix multiple definition build error

2013-04-26 Thread Tomasz Figa
On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote: > On 04/26/2013 10:20 AM, Inki Dae wrote: > > Exactly right. it's my mistake. But now it seems that > > __mode_of_device_table is multi defined at fimd and g2d side so there > > still is module build error. :( > Since all drivers seem to

[PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-02 Thread Tomasz Figa
Hi Vikas, On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote: > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel > connected with resolution 2560x1600, following error occured even with > IOMMU enabled: > [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to all

[PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-02 Thread Tomasz Figa
Hi Vikas, On Friday 02 of August 2013 12:08:52 Vikas Sajjan wrote: > Hi Rob, > > On 2 August 2013 06:03, Rob Clark wrote: > > On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa wrote: > >> Hi Vikas, > >> > >> On Thursday 01 of August 2013 16:49:32 Vikas Sa

[PATCH V2] drm/exynos: Add fallback option to get non physically continous memory for fb

2013-08-05 Thread Tomasz Figa
CONTIG > memory allocation fails. > > Signed-off-by: Vikas Sajjan > Signed-off-by: Arun Kumar > --- > changes since v1: >- Modified to add the fallback patch if CONTIG alloc fails as suggested > by Rob Clark robdclark at gmail.com and Tomasz Figa > . > >

[PATCHv2 1/5] drm/exynos: add device tree support for rotator

2013-08-09 Thread Tomasz Figa
Hi Chanho, On Friday 09 of August 2013 16:40:49 Chanho Park wrote: > The exynos4 platform is only dt-based since 3.10, we should convert > driver data and ids to dt-based parsing methods. The rotator driver has > a limit table to get size limit of input picture. Each SoCs has slightly > different

[PATCHv2 2/5] ARM: dts: Add rotator node for exynos4210

2013-08-09 Thread Tomasz Figa
On Friday 09 of August 2013 16:40:50 Chanho Park wrote: > This patch adds a rotator node for exynos4210. The exynos4210 has > different limitation of image size compared with later chips. > > Signed-off-by: Chanho Park > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Inki Dae > Signed-off-by: Kyung

[PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator

2013-08-09 Thread Tomasz Figa
Hi Chanho, On Friday 09 of August 2013 16:40:53 Chanho Park wrote: > This patch describes each nodes of rotator and specifies a example how to > bind it. > > Signed-off-by: Chanho Park > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Inki Dae > Signed-off-by: Kyungmin Park > --- > .../devicetree

[PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator

2013-08-09 Thread Tomasz Figa
On Friday 09 of August 2013 10:38:30 Stephen Warren wrote: > On 08/09/2013 07:15 AM, Tomasz Figa wrote: > > Hi Chanho, > > > > On Friday 09 of August 2013 16:40:53 Chanho Park wrote: > >> This patch describes each nodes of rotator and specifies a example how > >

[PATCH 1/3] Move FIMD register headers to include/video/

2012-07-30 Thread Tomasz Figa
Hi, On Monday 30 of July 2012 at 16:46:03, Leela Krishna Amudala wrote: > Hello Jingoo Han, > > On Mon, Jul 30, 2012 at 2:23 PM, Jingoo Han wrote: > > On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote: > >> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side > >> to inclu

[PATCH 1/3] Move FIMD register headers to include/video/

2012-07-31 Thread Tomasz Figa
(0x10)) > > In this case, the FIMD driver does not need to change. > Also, one binary is available. > This would look good indeed, but there are some drawbacks: - it would not scale nicely for future SoCs using the new FIMD - it would add the overhead of checking SoC ID for every access

[PATCH 1/4] clk: propagate parent change up one level

2014-05-01 Thread Tomasz Figa
Mike, On 08.04.2014 17:45, Tomasz Figa wrote: > Hi, > > On 04.04.2014 16:53, Tomasz Stanislawski wrote: >> This patch adds support for propagation of setup of clock's parent one >> level >> up. >> >> This feature is helpful when a driver changes topol

[PATCH 2/4] clk: exynos4: export sclk_hdmiphy clock

2014-05-01 Thread Tomasz Figa
On 04.04.2014 16:53, Tomasz Stanislawski wrote: > Export sclk_hdmiphy clock to be usable from DT. > > Signed-off-by: Tomasz Stanislawski > --- > drivers/clk/samsung/clk-exynos4.c |2 +- > include/dt-bindings/clock/exynos4.h |1 + > 2 files changed, 2 insertions(+), 1 deletion(-) >

[PATCH v2 12/26] drm/exynos: Split manager/display/subdrv

2013-10-29 Thread Tomasz Figa
Hi, On Wednesday 23 of October 2013 12:09:06 Sean Paul wrote: > On Wed, Oct 23, 2013 at 11:53 AM, Dave Airlie wrote: > > I think we need to start considering a framework where subdrivers > > just > > add drm objects themselves, then the toplevel node is responsible > > for > >

[PATCH v2 12/26] drm/exynos: Split manager/display/subdrv

2013-10-29 Thread Tomasz Figa
On Tuesday 29 of October 2013 12:19:35 Olof Johansson wrote: > On Mon, Oct 28, 2013 at 4:13 PM, Tomasz Figa wrote: > > Hi, > > > > On Wednesday 23 of October 2013 12:09:06 Sean Paul wrote: > >> On Wed, Oct 23, 2013 at 11:53 AM, Dave Airlie wrote: >

[PATCH v2 12/26] drm/exynos: Split manager/display/subdrv

2013-10-29 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 16:36:47 Sean Paul wrote: > On Mon, Oct 28, 2013 at 7:13 PM, Tomasz Figa wrote: > > Hi, > > > > On Wednesday 23 of October 2013 12:09:06 Sean Paul wrote: > >> On Wed, Oct 23, 2013 at 11:53 AM, Dave Airlie wrote: >

outcome of DRM/KMS DT bindings session

2013-10-30 Thread Tomasz Figa
On Wednesday 30 of October 2013 13:02:29 Sascha Hauer wrote: > On Tue, Oct 29, 2013 at 01:52:57PM +1000, Dave Airlie wrote: > > So we had a sessions at kernel summit to discuss the driver model and > > DT interactions for a display pipeline, > > > > we had good attendance from a few sides and I ho

[GIT PULL] exynos-drm-next

2014-04-04 Thread Tomasz Figa
Hi Inki, On 03.04.2014 19:34, inki.dae at samsung.com wrote: > Hi Dave, > Sorry for late. > This pull request includes MIPI-DSI driver, two panel drivers, > super device support, and relevant dt bindings. > > Summaries: > - Add MIPI-DSI Driver, and dt bindigs > - Add S6E8AA0 MIPI-DSI b

[GIT PULL] exynos-drm-next

2014-04-04 Thread Tomasz Figa
On 04.04.2014 07:34, Inki Dae wrote: > Hi Tomasz, > >> -Original Message----- >> From: Tomasz Figa [mailto:tomasz.figa at gmail.com] >> Sent: Friday, April 04, 2014 2:00 PM >> To: inki.dae at samsung.com; airlied at linux.ie; dri- >> devel at lists.freed

[GIT PULL] exynos-drm-next

2014-04-04 Thread Tomasz Figa
On 04.04.2014 09:48, Inki Dae wrote: > > >> -Original Message----- >> From: Tomasz Figa [mailto:t.figa at samsung.com] >> Sent: Friday, April 04, 2014 4:29 PM >> To: Inki Dae; 'Tomasz Figa'; airlied at linux.ie; dri- >> devel at lists.freedes

[PATCH v2 1/7] drm/exynos: add super device support

2014-04-04 Thread Tomasz Figa
Hi Inki, On 01.04.2014 14:37, Inki Dae wrote: > This patch adds super device support to bind sub drivers > using device tree. > > For this, you should add a super device node to each machine dt files > like belows, > > In case of using MIPI-DSI, > display-subsystem { > compatib

[PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Tomasz Figa
[adding more people and MLs on Cc for further discussion] On 04.04.2014 17:44, Inki Dae wrote: > 2014-04-04 22:55 GMT+09:00 Tomasz Figa : >> Hi Inki, >> >> >> On 01.04.2014 14:37, Inki Dae wrote: >>> >>> This patch adds super device support to bind s

[PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Tomasz Figa
On 05.04.2014 20:24, Russell King - ARM Linux wrote: > On Sat, Apr 05, 2014 at 07:32:50PM +0200, Tomasz Figa wrote: >> Not exactly. The approach we found does mostly the same as componentized >> subsystem framework but without _any_ extra data in Device Tree. Just >>

[PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Tomasz Figa
On 05.04.2014 20:52, Russell King - ARM Linux wrote: > On Sat, Apr 05, 2014 at 08:31:15PM +0200, Tomasz Figa wrote: >> Maybe my words have been misinterpreted, but all I'm suggesting here is >> that there is no need to add any new data to DT to solve the same issue >

[PATCH v2 1/7] drm/exynos: add super device support

2014-04-07 Thread Tomasz Figa
Hi Andrzej, On 07.04.2014 16:18, Andrzej Hajda wrote: > Hi Inki and Tomasz, > > On 04/06/2014 05:15 AM, Inki Dae wrote: > > (...) >> The code creating the list of components to wait for >> (exynos_drm_add_components()) doesn't seem to consider which sub-drivers are >> actually enabled in kernel co

[PATCH v2 1/7] drm/exynos: add super device support

2014-04-07 Thread Tomasz Figa
On 07.04.2014 17:16, Inki Dae wrote: > Hi Andrzej, > > 2014-04-07 23:18 GMT+09:00 Andrzej Hajda : >> Hi Inki and Tomasz, >> >> On 04/06/2014 05:15 AM, Inki Dae wrote: >> >> (...) >>> The code creating the list of components to wait for >>> (exynos_drm_add_components()) doesn't seem to consider whic

[PATCH 1/4] clk: propagate parent change up one level

2014-04-08 Thread Tomasz Figa
LK_SET_RATE_NO_REPARENT BIT(7) /* don't re-parent on rate change */ > #define CLK_GET_ACCURACY_NOCACHE BIT(8) /* do not use the cached clk > accuracy */ > +#define CLK_SET_PARENT_PARENTBIT(9) /* propagate parent change up > one level */ > > struct clk_hw; > struct dentry; > This would be very useful, at least on Exynos platforms, with mux-div-gate clock paths. PARENT_PARENT sounds a bit funny, though. Reviewed-by: Tomasz Figa Best regards, Tomasz

<    1   2   3   4   5   >