Re: [v3,2/4] drm/edid: Add CTA-861-G modes with VIC >= 193

2019-12-11 Thread Tom Anderson
Reviewed-by: Thomas Anderson On Wed, Sep 25, 2019 at 04:55:00PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a second table to the cea modes with VIC >= 193. > > Cc: Hans Verkuil > Cc: Shashank Sharma > Signed-off-by: Ville Syrjälä > Reviewed-by: Manasi Navare > --- > drivers

Re: [PATCH] drm/edid: Add modes from CTA-861-G

2019-12-11 Thread Tom Anderson
On Tue, Dec 03, 2019 at 02:53:12PM +0200, Ville Syrjälä wrote: > On Mon, Dec 02, 2019 at 03:32:46PM -0800, Tom Anderson wrote: > > On Mon, Nov 25, 2019 at 01:42:00PM -0500, Bhawanpreet Lakha wrote: > > > Reviewed-by: Bhawanpreet Lakha > > > > Thank you for the re

Re: [PATCH] drm/edid: Add modes from CTA-861-G

2019-12-11 Thread Tom Anderson
On Tue, Dec 10, 2019 at 10:05:55PM +0200, Ville Syrjälä wrote: > On Tue, Dec 10, 2019 at 11:13:35AM -0800, Tom Anderson wrote: > > On Tue, Dec 03, 2019 at 02:53:12PM +0200, Ville Syrjälä wrote: > > > On Mon, Dec 02, 2019 at 03:32:46PM -0800, Tom Anderson wrote: > > > &

Re: [v3,4/4] drm/edid: Make sure the CEA mode arrays have the correct amount of modes

2019-12-11 Thread Tom Anderson
Reviewed-by: Thomas Anderson On Wed, Sep 25, 2019 at 04:55:02PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We depend on a specific relationship between the VIC number and the > index in the CEA mode arrays. Assert that the arrays have the excpected > size to make sure we've not accid

Re: [v3,3/4] drm/edid: Throw away the dummy VIC 0 cea mode

2019-12-11 Thread Tom Anderson
On Wed, Sep 25, 2019 at 04:55:01PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that the cea mode handling is not 100% tied to the single > array the dummy VIC 0 mode is pretty much pointles. Throw it > out. > > Cc: Hans Verkuil > Cc: Shashank Sharma > Signed-off-by: Ville Syrjälä

Re: [v3,1/4] drm/edid: Abstract away cea_edid_modes[]

2019-12-11 Thread Tom Anderson
+CCs that were accidnetally lost On Tue, Dec 10, 2019 at 02:34:23PM -0800, Tom Anderson wrote: > On Wed, Sep 25, 2019 at 04:54:59PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We're going to need two cea mode tables (on for VICs < 128, > > s

Re: [PATCH v4 1/4] drm/edid: Abstract away cea_edid_modes[]

2019-12-14 Thread Tom Anderson
claring (Tom) > Improve the comment for cea_modes_*[] to indicate > that one should always use cea_mode_for_vic() (Tom) > > Cc: Tom Anderson > Cc: Hans Verkuil > Cc: Manasi Navare > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 67 +++

Re: [PATCH v4 3/4] drm/edid: Throw away the dummy VIC 0 cea mode

2019-12-14 Thread Tom Anderson
lgtm Reviewed-by: Thomas Anderson On Fri, Dec 13, 2019 at 07:43:47PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that the cea mode handling is not 100% tied to the single > array the dummy VIC 0 mode is pretty much pointles. Throw it > out. > > v2: Rebase

Re: [PATCH v2] drm/amd/display: Reduce HDMI pixel encoding if max clock is exceeded

2019-12-23 Thread Tom Anderson
Ping. Is there any action required to get this landed? On Tue, Dec 10, 2019 at 10:59:24AM -0800, Tom Anderson wrote: > Friendly ping. > > On Mon, Dec 02, 2019 at 01:47:13PM -0800, Thomas Anderson wrote: > > For high-res (8K) or HFR (4K120) displays, using uncompressed pixel &

Re: [PATCH] drm/amd/display: Reduce HDMI pixel encoding if max clock is exceeded

2019-11-30 Thread Tom Anderson
I just realized that at 4:2:2, the pixel clock isn't actually decreased to 3/4 of it's value at 4:4:4. I'll send a revised patch on Monday. On Fri, Nov 22, 2019 at 09:29:00PM -0800, Thomas Anderson wrote: > For high-res (8K) or HFR (4K120) displays, using uncompressed pixel > formats like YCbCr444

Re: [PATCH] drm/edid: Add modes from CTA-861-G

2019-12-03 Thread Tom Anderson
On Mon, Nov 25, 2019 at 01:42:00PM -0500, Bhawanpreet Lakha wrote: > Reviewed-by: Bhawanpreet Lakha Thank you for the review. +Ville has brought to my attention 978f6b0693c7 which added modes up to 128 which was part of a recent merge, so I didn't seen the changes until now. Ville also pointed o

[libdrm patch] Fix build with -std=c11

2018-07-26 Thread Tom Anderson
Hello, I have a simple one-line patch that fixes the libdrm build with -std=c11. I would appreciate if anyone with commit access could merge the attached change on my behalf. Thanks! Tom From fc7a593454030df2b06e5b9dbafaa666d51a30ac Mon Sep 17 00:00:00 2001 From: Tom Anderson Date: Wed, 25 Jul