(no display pin, so I need to clamp all pads) is
still called, thus it works for me.
Tested-by: Sylvain Rochet
Cheers,
Sylvain
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Unfortunately we used the enabled flag in struct drm_crtc instead of the
enabled flag in struct atmel_hlcdc_crtc. This obviously leads to
discrepancies on crtc enable state.
This patch fixes the issue by using the struct atmel_hlcdc_crtc enabled
flag in PM support.
Signed-off-by: Sylvain Rochet
From: Boris Brezillon
drm_vblank_on() now warns on nested use or if vblank is not properly
initialized. This patch fixes Atmel HLCDC vblank initial state.
Signed-off-by: Boris Brezillon
Reported-by: Sylvain Rochet
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 1 +
drivers/gpu/drm
rom that, it works perfectly, you can add my:
Tested-by: Sylvain Rochet
[ cut here ]
WARNING: CPU: 0 PID: 9 at drivers/clk/clk.c:992 clk_disable+0x28/0x34()
Modules linked in:
CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted 3.19.0-rc7-next-20150204+ #90
Hardware name: Atmel S
Some LCD panels have back-powering issue when un-powered, allows users
to use an alternate pinctrl "sleep" in order to clamp outputs to a
wanted state at suspend.
Signed-off-by: Sylvain Rochet
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 3 +++
1 file changed, 3 insertion
This series depends on Boris' "[PATCH v2] drm: atmel-hlcdc: Atomic
mode-setting conversion"
<1423236143-6494-1-git-send-email-boris.brezillon at free-electrons.com>
plus a few fixes which are going to be in v3 of Boris' patch.
This series adds basic PM support for At
On suspend: switch off CRTC if not already suspended with runtime PM
On resume: switch on CRTC if we were not already suspended from runtime
PM while suspending.
Signed-off-by: Sylvain Rochet
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 60
1 file changed, 60
Hello Boris,
On Tue, Feb 10, 2015 at 03:05:57PM +0100, Boris Brezillon wrote:
> On Tue, 10 Feb 2015 14:40:45 +0100
> Sylvain Rochet wrote:
> > +
> > +static SIMPLE_DEV_PM_OPS(atmel_hlcdc_dc_drm_pm_ops,
> > + atmel_hlcdc_dc_drm_suspend, atmel_hlcdc_dc_drm_r
Some LCD panels have back-powering issue when un-powered, allows users
to use an alternate pinctrl "sleep" in order to clamp outputs to a
wanted state at suspend.
Signed-off-by: Sylvain Rochet
Acked-by: Boris Brezillon
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 3 +++
1 fi
On suspend: switch off CRTC if not already suspended with runtime PM
On resume: switch on CRTC if we were not already suspended from runtime
PM while suspending.
Signed-off-by: Sylvain Rochet
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 60
1 file changed, 60
l HLCDC.
Changes since v1:
* (*crtc_funcs->disable)(crtc) replaced to crtc_funcs->disable(crtc)
Sylvain Rochet (2):
drm: atmel-hlcdc: Add PM suspend/resume support
drm: atmel-hlcdc: Add pinctrl PM select sleep,default state in CRTC
suspend/resume
drivers/gpu/drm/atmel-hlcdc/atm
Hello Boris,
On Fri, Feb 13, 2015 at 04:36:25PM +0100, Boris Brezillon wrote:
> Remove a useless pm_runtime_put_sync leading to unbalanced
> usage_count.
>
> Signed-off-by: Boris Brezillon
> Reported-by: Sylvain Rochet
> ---
Indeed, this is actually a necessary fix for my
Some LCD panels have back-powering issue when un-powered, allows users
to use an alternate pinctrl "sleep" in order to clamp outputs to a
wanted state at suspend.
Signed-off-by: Sylvain Rochet
Acked-by: Boris Brezillon
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 3 +++
1 fi
el_hlcdc_dc_suspend to atmel_hlcdc_dc_drm_suspend and
atmel_hlcdc_dc_resume to atmel_hlcdc_dc_drm_resume since we don't
need the previous callbacks anymore
* Removed useless check of drm_dev in suspend/resume functions
Changes since v1:
* (*crtc_funcs->disable)(crtc) replaced to crtc_funcs-
On suspend: switch off CRTC if not already suspended with runtime PM
On resume: switch on CRTC if we were not already suspended from runtime
PM while suspending.
Signed-off-by: Sylvain Rochet
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 47
1 file changed, 47
Hello Andrzej,
On Tue, Feb 17, 2015 at 10:47:23AM +0100, Andrzej Hajda wrote:
> On 02/12/2015 09:49 PM, Sylvain Rochet wrote:
> > +static int atmel_hlcdc_dc_resume(struct drm_device *dev)
> > +{
> > + struct drm_crtc *crtc;
> > +
>
16 matches
Mail list logo
