ons for allocation
> limits.
> >
> > Reviewed-by: John Stultz
>
> Thank you for taking a look John!
>
Looks good to me; I will apply it to drm-misc today.
>
> Regards,
> Hridya
>
> >
> > thanks
> > -john
>
Best,
Sumit.
--
Thanks and regards,
Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs
cation
> > limits.
> >
> > Reviewed-by: John Stultz
>
> Thank you for taking a look John!
Looks good to me; I will apply it to drm-misc today.
>
> Regards,
> Hridya
>
> >
> > thanks
> > -john
Best,
Sumit.
--
Thanks and regards,
Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs
ill push into drm-misc-next.
>
> Cc: Sumit Semwal
> Cc: Liam Mark
> Cc: Laura Abbott
> Cc: Brian Starkey
> Cc: Hridya Valsaraju
> Cc: Suren Baghdasaryan
> Cc: Sandeep Patil
> Cc: Daniel Mentz
> Cc: Chris Goldsworthy
> Cc: Ørjan Eide
> Cc: Robin Murphy
le creating the fd via
> dma_buf_fd().
Thanks for the patch! LGTM, feels a lot neater now. I'll merge into
drm-misc-next.
>
> Cc: Sumit Semwal
> Cc: Liam Mark
> Cc: Laura Abbott
> Cc: Brian Starkey
> Cc: Hridya Valsaraju
> Cc: Suren Baghdasaryan
> Cc:
Hi Veera,
On Wed, 20 Jan 2021 at 02:00, John Stultz wrote:
>
> On Fri, Jan 15, 2021 at 4:31 PM Veera Sundaram Sankaran
> wrote:
> >
> > Some drivers have hardware capability to get the precise HW timestamp
> > of certain events based on which the fences are triggered. The delta
> > between the e
or the vunmap
count more than vmap count. Is there a specific need for this in the heaps?
Best,
Sumit.
>
> Cc: Sumit Semwal
> Cc: Liam Mark
> Cc: Laura Abbott
> Cc: Brian Starkey
> Cc: Hridya Valsaraju
> Cc: Suren Baghdasaryan
> Cc: Sandeep Patil
> Cc: Daniel Me
Hi Hridya,
On Wed, 27 Jan 2021 at 17:36, Greg KH wrote:
>
> On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote:
> > This patch allows statistics to be enabled for each DMA-BUF in
> > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS.
> >
> > The following stats will be exposed
On Thu, 28 Jan 2021 at 17:23, Christian König
wrote:
>
> Am 28.01.21 um 12:00 schrieb Sumit Semwal:
> > Hi Hridya,
> >
> > On Wed, 27 Jan 2021 at 17:36, Greg KH wrote:
> >> On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote:
> >>> This p
Hi Simon,
On Thu, 28 Jan 2021 at 20:01, Simon Ser wrote:
>
> On Thursday, January 28th, 2021 at 1:03 PM, Sumit Semwal
> wrote:
>
> > Since he didn't comment over Hridya's last clarification about the
> > tracepoints to track total GPU memory allocations bein
ion with tooling, and there is
> > > > the future potential where multiple heap types may be exported
> > > > by the same module (but would all have the same name).
> > > >
> > > > So to avoid all this, set the exporter exp_name to the heap name.
&g
cation performance, the
> uncached heap allocations do result in *much* improved
> performance on HiKey960 as it avoids a lot of flushing and
> invalidating buffers that the cpu doesn't touch often.
>
> Feedback on these would be great!
>
> thanks
> -john
>
> New
u, Nov 12, 2020 at 1:32 AM Daniel Vetter wrote:
> > > > > On Thu, Nov 12, 2020 at 11:09:04AM +0530, Sumit Semwal wrote:
> > > > > > On Tue, 10 Nov 2020 at 09:19, John Stultz
> > > > > > wrote:
> > > > > > >
> > > > &
anks for the patch; looks sane.
>
> Signed-off-by: Xiaoke Wang
Acked-by: Sumit Semwal
Will queue it up.
> ---
> drivers/dma-buf/selftest.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma-buf/selftest.c b/drivers/dma-buf/selftest.c
> index c60b6
Hi Christian,
On Wed, 1 Sept 2021 at 13:30, Christian König
wrote:
>
> The seqno-fence was removed, cleanup the kerneldoc include as well.
>
> Signed-off-by: Christian König
> Fixes: 992c238188a8 ("dma-buf: nuke seqno-fence")
Thanks for fixing; LGTM, please feel free
Hello Geert,
On Thu, 2 Sept 2021 at 18:19, Geert Uytterhoeven wrote:
>
> Hi Sumit, Christian,
>
> This patch series adds missing dependencies on DMA_SHARED_BUFFER to
> various options of DMA-BUF, and drops a bogus select.
>
> As drivers/dma-buf/Kconfig contains interleaved options that se
fall back to single page allocatitions in that case.
> > This is the similar to what we already do for large order
> > allocations.
> >
> > Cc: Daniel Vetter
> > Cc: Christian Koenig
> > Cc: Sumit Semwal
> > Cc: Liam Mark
> > Cc: Chris Goldsworth
Hello Guangming, Christian,
On Tue, 12 Oct 2021, 14:09 , wrote:
> From: Guangming Cao
>
> > Am 09.10.21 um 07:55 schrieb guangming@mediatek.com:
> > From: Guangming Cao
> > >
> > > If dma-buf don't want userspace users to touch the dmabuf buffer,
> > > it seems we should add this restric
her
>
LGTM, but perhaps you want to send it from your amd.com account?
Acked-by: Sumit Semwal
>
> > ---
> > include/linux/dma-buf.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dma-buf.h b/include/linux/dma-b
> >> Cc: Thomas Zimmermann
> >> Cc: Mauro Carvalho Chehab
> >> Cc: dri-devel@lists.freedesktop.org
> >> Acked-by: Daniel Vetter
> >> Acked-by: Christian König
> >> Acked-by: Arnd Bergmann
> >> Acked-by: Sumit Semwal
> >>
properly import the namespace to not break the build at the
> same time.
>
> Now the output of modinfo shows the use of these symbols, making it
> easier to watch for users over time:
>
> $ modinfo drivers/misc/fastrpc.ko | grep import
> import_ns: DMA_BUF
>
> Cc: S
Hello Jordy,
On Tue, 1 Feb 2022 at 02:09, John Stultz wrote:
>
> On Sat, Jan 29, 2022 at 7:06 AM Jordy Zomer wrote:
> >
> > It appears like nr could be a Spectre v1 gadget as it's supplied by a
> > user and used as an array index. Prevent the contents
> > of kernel memory from being leaked to us
pplied to drm-misc-fixes.
> >
> > Fixes: d963ab0f15fb0 ("dma-buf: system_heap: Allocate higher order pages if
> > available")
> > Signed-off-by: Guangming
> > Reviewed-by: Robin Murphy
> > Cc: # 5.11.*
>
> Thanks so much for catching this and sending in all the revisions!
>
> Reviewed-by: John Stultz
Best,
Sumit.
--
Thanks and regards,
Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs
Kozlowski
> Kuninori Morimoto
> +Laura Abbott
> +Laura Abbott
> +Laura Abbott
> Leonardo Bras
> Leonid I Ananiev
> Leon Romanovsky
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 43007f2d29e0..21ab7c9d1bee 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINE
ction 'cma_heap_do_vmap':
> drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of
> function 'vmap'
Thanks for the patch; I've merged it to drm-misc-next-fixes.
>
> Cc: Sumit Semwal
> Cc: Liam Mark
> Cc: Laura Abbott
> Cc:
Hi Charan,
On Mon, 4 Jan 2021 at 17:22, Christian König
wrote:
>
> Am 04.01.21 um 12:36 schrieb Charan Teja Reddy:
> > It is observed 'use-after-free' on the dmabuf's file->f_inode with the
> > race between closing the dmabuf file and reading the dmabuf's debug
> > info.
> >
> > Consider the belo
ures the pagelist is also freed on release.
Thanks for your patch.
>
> Cc: Bing Song
> Cc: Sumit Semwal
> Cc: Liam Mark
> Cc: Laura Abbott
> Cc: Brian Starkey
> Cc: Hridya Valsaraju
> Cc: Suren Baghdasaryan
> Cc: Sandeep Patil
> Cc: Daniel Mentz
> Cc: Chr
gt; > > > index 56bf5ad01ad5..e39d2be98d69 100644
> > > > --- a/drivers/dma-buf/dma-heap.c
> > > > +++ b/drivers/dma-buf/dma-heap.c
> > > > @@ -55,6 +55,8 @@ static int dma_heap_buffer_alloc(struct
> > > > dma_heap *heap, size_t len,
> > > > struct dma_buf *dmabuf;
> > > > int fd;
> > > >
> > > > + if (len / PAGE_SIZE > totalram_pages())
> > > > + return -EINVAL;
> > >
> > > This seems sane. I know ION used to have some 1/2 of memory cap to
> > > avoid unnecessary memory pressure on crazy allocations.
> > >
> > > Could you send again with an improved commit message?
> > >
> > > thanks
> > > -john
> >
> >
--
Thanks and regards,
Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs
Hello Weizhao,
On Tue, 4 Jan 2022 at 13:13, John Stultz wrote:
>
> On Mon, Jan 3, 2022 at 11:36 PM Weizhao Ouyang wrote:
> >
> > Fix cma_heap_buffer mutex locking critical section to protect vmap_cnt
> > and vaddr.
> >
> > Fixes: a5d2d29e24be ("dma-buf: heaps: Move heap-helper logic into the
>
Convert dma-buf documentation over to sphinx; also cleanup to
address sphinx warnings.
While at that, convert dma-buf-sharing.txt as well, and make it the
dma-buf API guide.
There is no content change yet; only format conversion and creation of
some hyperlinks.
Sumit Semwal (4):
dma-buf/fence
Convert dma-buf documentation over to sphinx; also cleanup to
address sphinx warnings.
While at that, convert dma-buf-sharing.txt as well, and make it the
dma-buf API guide.
There is no content change yet; only format conversion and creation of
some hyperlinks.
Sumit Semwal (4):
dma-buf/fence
Commit 0431b9065f28ecf6c320fefebe0241620049984f ("staging/android: bring
struct sync_pt back") removed child_list and active_list from struct fence,
but left it in kernel doc. Delete them.
Fixes: 0431b9065f28 ("staging/android: bring struct sync_pt back")
Signed-
Commit e941759c74a44d6ac2eed21bb0a38b21fe4559e2 ("fence: dma-buf
cross-device synchronization (v18)") had a spurious kerneldoc section
header that caused Sphinx to complain. Fix it.
Fixes: e941759c74a4 ("fence: dma-buf cross-device synchronization (v18)")
Signed-
Branch out dma-buf related documentation into its own rst file to allow
adding it to the sphinx documentation generated.
While at it, move dma-buf-sharing.txt into rst as the dma-buf guide too.
Signed-off-by: Sumit Semwal
---
Documentation/DocBook/device-drivers.tmpl | 37 ---
Documentation
Include dma-buf sphinx documentation into top level index.
Signed-off-by: Sumit Semwal
---
Documentation/index.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/index.rst b/Documentation/index.rst
index 43c722f15292..2fe8e82d7d8c 100644
--- a/Documentation/index.rst
+++ b
Hello Jani,
On 11 August 2016 at 17:17, Jani Nikula wrote:
> On Thu, 11 Aug 2016, Sumit Semwal wrote:
>> diff --git a/Documentation/dma-buf/guide.rst
>> b/Documentation/dma-buf/guide.rst
>> new file mode 100644
>> index ..fd3534fdccb3
>> --- /dev/nu
ructs:
> http://www.sphinx-doc.org/en/stable/markup/index.html
> * Sphinx domains: http://www.sphinx-doc.org/en/stable/domains.html
> * Sphinx cross references:
> http://www.sphinx-doc.org/en/stable/markup/inline.html#cross-referencing-arbitrary-locations
>
> Am 11.08.2016 um 12:4
Hi Chris,
On 11 August 2016 at 20:16, Chris Wilson wrote:
> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
> need to handle such conversion in the caller. The only challenge are
> those callers that wi
Hi Jon!
On 11 August 2016 at 20:06, Jonathan Corbet wrote:
> On Thu, 11 Aug 2016 16:17:56 +0530
> Sumit Semwal wrote:
>
>> Convert dma-buf documentation over to sphinx; also cleanup to
>> address sphinx warnings.
>>
>> While at that, convert dma-buf-sharing.tx
rning: No description found for
> parameter 'signal_on_any'
>
> Signed-off-by: Randy Dunlap
> Cc: Sumit Semwal
> Cc: linux-media at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: linaro-mm-sig at lists.linaro.org
> ---
> driver
Convert dma-buf documentation over to sphinx.
While at that, convert dma-buf-sharing.txt as well, and make it the
dma-buf API guide.
There is no content change yet; only format conversion and creation of
some hyperlinks.
v2: Address review comments from Jonathan Corbet and Markus Heiser.
Sumit
comments from Jonathan Corbet and Markus Heiser.
Signed-off-by: Sumit Semwal
---
Documentation/DocBook/device-drivers.tmpl | 41 ---
Documentation/dma-buf-sharing.txt | 482
Documentation/dma-buf/guide.rst | 507
Include dma-buf sphinx documentation into top level index.
Signed-off-by: Sumit Semwal
---
Documentation/index.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/index.rst b/Documentation/index.rst
index e0fc72963e87..8d05070122c2 100644
--- a/Documentation/index.rst
+++ b
Hi Jon,
On 23 August 2016 at 18:38, Jonathan Corbet wrote:
> On Tue, 23 Aug 2016 08:01:35 +0200
> Daniel Vetter wrote:
>
>> I'm also not too sure about whether dma-buf really should be it's own
>> subdirectory. It's plucked from the device-drivers.tmpl, I think an
>> overall device-drivers/ for
Hi Christian,
On Sat, 27 Apr 2019 at 05:31, Liam Mark wrote:
>
> On Tue, 16 Apr 2019, Christian König wrote:
>
> > To allow a smooth transition from pinning buffer objects to dynamic
> > invalidation we first start to cache the sg_table for an attachment
> > unless the driver explicitly says to n
Hello everyone,
Sincere apologies for chiming in a bit late here, but was off due to
some health issues.
Also, adding Daniel Vetter to the mix, since he has been one of the
core guys who shaped up dma-buf as it is today.
On Tue, 22 Jan 2019 at 02:51, Andrew F. Davis wrote:
>
> On 1/21/19 5:22 A
Hello everyone,
(Thanks to Dan for letting me know my last email got corrupted :/ -
resending it here)
Sincere apologies for chiming in a bit late here, but was off due to some
health issues.
Also, adding Daniel Vetter to the mix, since he has been one of the core
guys who shaped up dma-buf as i
On Mon, 25 Feb 2019 at 20:06, Andrew F. Davis wrote:
>
> This framework allows a unified userspace interface for dma-buf
> exporters, allowing userland to allocate specific types of memory
> for use in dma-buf sharing.
>
> Each heap is given its own device node, which a user can allocate
> a dma-b
Hello Chenbo,
Thanks very much for your patches. Other than a couple tiny nits
below, I think these look good, and I will merge them before the end
of this week.
On Tue, 11 Jun 2019 at 05:32, Chenbo Feng wrote:
>
> From: Greg Hackmann
>
> This patch adds complimentary DMA_BUF_SET_NAME and DMA_BU
Hi Chenbo,
On Fri, 14 Jun 2019 at 04:04, Chenbo Feng wrote:
>
> Currently, all dma-bufs share the same anonymous inode. While we can count
> how many dma-buf fds or mappings a process has, we can't get the size of
> the backing buffers or tell if two entries point to the same dma-buf. And
> in de
Hello Chenbo,Thank you for your RFC series.
On Wed, 27 Feb 2019 at 09:24, Chenbo Feng wrote:
>
> Currently, all dma-bufs share the same anonymous inode. While we can count
> how many dma-buf fds or mappings a process has, we can't get the size of
> the backing buffers or tell if two entries point
On Sat, 16 Mar 2019 at 04:15, Laura Abbott wrote:
> On 3/15/19 2:29 PM, John Stultz wrote:
> > On Fri, Mar 15, 2019 at 1:18 PM Laura Abbott wrote:
> >>
> >> On 3/5/19 12:54 PM, John Stultz wrote:
> >>> +DMA-BUF HEAPS FRAMEWORK
> >>> +M: Laura Abbott
> >>> +R: Liam Mark
> >>> +R: Brian Star
On Sat, 16 Mar 2019 at 04:15, Laura Abbott wrote:
>
> On 3/15/19 2:29 PM, John Stultz wrote:
> > On Fri, Mar 15, 2019 at 1:18 PM Laura Abbott wrote:
> >>
> >> On 3/5/19 12:54 PM, John Stultz wrote:
> >>> +DMA-BUF HEAPS FRAMEWORK
> >>> +M: Laura Abbott
> >>> +R: Liam Mark
> >>> +R: Brian Sta
Hi Daniel,
On Fri, 15 Mar 2019 at 16:36, Daniel Vetter wrote:
>
> On Thu, Mar 14, 2019 at 6:49 PM Sumit Semwal wrote:
> >
> > Hello Chenbo,Thank you for your RFC series.
> >
> > On Wed, 27 Feb 2019 at 09:24, Chenbo Feng wrote:
> > >
> > > Curren
Hi Andrew,
On Mon, 1 Apr 2019 at 20:38, Christian König
wrote:
>
> Am 29.03.19 um 17:52 schrieb Andrew F. Davis:
> > The docs state the callback is optional but it is not, make it optional.
> >
> > Signed-off-by: Andrew F. Davis
>
> Reviewed-by: Christian König
Thanks for the patch; I will que
Hi Joel,
On Wed, 8 Jun 2022 at 00:01, Joel Selvaraj wrote:
>
> Hi,
>
> I can see that the dts changes from this patch series has been applied
> to 5.19-rc1 release. However, this patch that has the related change to
> the panel driver, is not applied in the 5.19-rc1 release. Any particular
> reas
Hi Joel,
On Wed, 8 Jun 2022 at 22:10, Joel Selvaraj wrote:
>
> Hi Sumit,
>
> On 08/06/22 22:00, Sumit Semwal wrote:
> > This is entirely my fault - It somehow missed my radar, and I didn't
> > queue it up. I will push it via drm-misc tree tonight. Apologies
> >
t drm-misc-next and provide a
> >follow up to cleanup the MAINTAINERS file a bit more.
Thank you for the patch; apologies for not being able to respond
earlier (was out due to covid, just getting back slowly).
With Christian's suggestions, looks good to me as well - feel free to add an
A
Hi Christian,
On Thu, 28 Apr 2022 at 13:33, Christian König wrote:
>
> Am 28.04.22 um 08:39 schrieb Yuanzheng Song:
> > 'cat /sys/kernel/debug/dma_buf/bufinfo' will print the Dma-buf
> > Objects' information when the CONFIG_DEBUG_FS=y.
> > However, the printed table header information does not co
gt; > Suggested-by: Al Viro
> > Cc: Sumit Semwal
> > Cc: Christian König
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Jason A. Donenfeld
>
> I'm assuming this is part of a vfs cleanup and lands through that tree?
> For that:
>
return;
>
> + dma_resv_assert_held(dmabuf->resv);
> +
> BUG_ON(iosys_map_is_null(&dmabuf->vmap_ptr));
> BUG_ON(dmabuf->vmapping_counter == 0);
> BUG_ON(!iosys_map_is_equal(&dmabuf->vmap_ptr, map));
> --
> 2.37.3
>
--
Thanks and regards,
Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs
| 17 +-
> drivers/infiniband/core/umem_dmabuf.c | 7 +-
> .../common/videobuf2/videobuf2-dma-contig.c | 22 +-
> .../media/common/videobuf2/videobuf2-dma-sg.c | 19 +-
> .../common/videobuf2/videobuf2-vmalloc.c | 17 +-
> .../platform/nvidia/tegra-vde/dmabuf-c
g shared.
>
> So since it was never used, and this idea's time is clearly over, let's
> remove it all.
As always, thanks for helping keep this code sane :)
Fwiw, for the series, please feel free to add my
Acked-by: Sumit Semwal
>
> Only real change I had to do (aside fro
Hello Zhong Jiang,
On Tue, 17 Dec 2019 at 07:56, zhong jiang wrote:
>
> On 2019/12/17 5:13, John Stultz wrote:
> > On Mon, Dec 16, 2019 at 5:43 AM zhong jiang wrote:
> >> Fix the following sparse warning.
Thanks for the patch; could I request you to please use
scripts/get_maintainer.pl to get th
From: zhong jiang
Fix the following sparse warning.
drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds'
was not declared. Should it be static?
Acked-by: Andrew F. Davis
Acked-by: John Stultz
Signed-off-by: zhong jiang
Signed-off-by: Sumit Semwal
[sumits: re
Hi John, Andrews,
On Fri, 18 Oct 2019 at 10:53, John Stultz wrote:
>
> Andrew brought up a reasonable concern with the CMA heap
> enumeration in the previous patch set, and I had a few other
> minor cleanups to add, so here is yet another pass at the
> dma-buf heaps patchset Andrew and I have bee
Hi John,
On Tue, 22 Oct 2019 at 00:33, John Stultz wrote:
>
> Lucky number 13! :)
>
> Last week in v12 I had re-added some symbol exports to support
> later patches I have pending to enable loading heaps from
> modules. He reminded me that back around v3 (its been awhile!) I
> had removed those e
On Fri, 25 Oct 2019 at 11:26, Sumit Semwal wrote:
>
> Hi John,
>
> On Tue, 22 Oct 2019 at 00:33, John Stultz wrote:
> >
> > Lucky number 13! :)
> >
> > Last week in v12 I had re-added some symbol exports to support
> > later patches I have pending to
ot;dma-buf: add DMA_BUF_SET_NAME ioctls")
> Reported-by: syzbot+b2098bc44728a4efb...@syzkaller.appspotmail.com
> Signed-off-by: Cong Wang
> Reviewed-by: Andrew Morton
> Acked-by: Chenbo Feng
> Cc: Sumit Semwal
> Cc: Greg Hackmann
> Signed-off-by: Andrew Morton
>
oe Perches.
>
> Cc: linux-me...@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linaro-mm-...@lists.linaro.org
> Cc: Joe Perches
> Cc: Sumit Semwal
> Cc: Sam Ravnborg
> Signed-off-by: Daniel Vetter
Acked-by: Sumit Semwal
> ---
> v2: No single quotes
alue
> * Add forgotten include file to fix build issue on x86
> * Checkpatch whitespace fixups
>
> Thoughts and feedback would be greatly appreciated!
>
> thanks
> -john
Best,
Sumit.
>
> Cc: Laura Abbott
> Cc: Benjamin Gaignard
> Cc: Sumit Semwal
> Cc: Liam
ks for doing this!
Acked-by: Sumit Semwal
>
> Letting the compiler do the real work (for the bits I spot checked it
> was the expected mechanical translation), and overwhelmingly agreeing with
> the motivation,
> Reviewed-by: Chris Wilson
> -Chris
>
Best,
Sumit.
_
Signed-off-by: Jason Ekstrand
> > Cc: Daniel Vetter
> > Cc: Christian König
> > Cc: Sumit Semwal
>
> We're still missing the doc for the SET_NAME ioctl, but maybe Sumit can be
> motivated to fix that?
>
Yes, certainly, I'll cook up a patc
>> +
> >> mutex_lock(&heap_list_lock);
> >> +/* check the name is unique */
> >> +list_for_each_entry(h, &heap_list, list) {
> >> +if (!strcmp(h->name, exp_info->name)) {
> >> +mutex_unlock(&heap_list_lock);
> >> +pr_err("dma_heap: Already registered heap named %s\n",
> >> + exp_info->name);
> >> +err_ret = ERR_PTR(-EINVAL);
> >> +goto err3;
> >> +}
> >> +}
> >> +
> >> +/* Add heap to the list */
> >> list_add(&heap->list, &heap_list);
> >> mutex_unlock(&heap_list_lock);
> >>
> >> return heap;
> >>
> >> +err3:
> >> +device_destroy(dma_heap_class, heap->heap_devt);
> >> err2:
> >> cdev_del(&heap->heap_cdev);
> >> err1:
> >> --
> >> 2.25.1
> >>
>
--
Thanks and regards,
Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs
d propagate the function
> > signature changes out into all relevant subsystems that use this
> > callback.
>
> Acked-by: Mauro Carvalho Chehab
> >
Please feel free to add my
Acked-by: Sumit Semwal
for the dma-buf portion.
Best,
Sumit.
> > Cc: Fenghua Yu
> > Cc: R
anges to dma_bug_getfile() and a missing NULL
> check in dma_buf_file_release()
>
> Signed-off-by: Christian König
Thank you for this nice cleanup.
Acked-by: Sumit Semwal
Best,
Sumit.
> ---
> drivers/dma-buf/dma-buf-sysfs-stats.c | 7 +--
> drivers/dma-buf/
pcc color block in dpu
> driver")
> Reported-by: Yongqin Liu
> Signed-off-by: Dmitry Baryshkov
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
Thanks for your patch, Dmitry. LGTM.
Please feel free to add:
Reviewed-
_4_0_sdm845.h| 21 +++
> 1 file changed, 17 insertions(+), 4 deletions(-)
Thanks for your patch, Dmitry. LGTM.
Please feel free to add:
Reviewed-by: Sumit Semwal
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h
> b/drivers/gpu/drm/msm/disp/dpu1
Hi John,
On Fri, 30 Jun 2023 at 10:22, John Stultz wrote:
>
> T.J. has been responsible for dmab-buf items on the Android team
> for awhile now, so it would be great to have him on as a reviewer.
>
> Cc: T.J. Mercier
> Cc: Sumit Semwal
> Cc: Benjamin Gaignard
> Cc: B
w.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
Thank you for the patch; I'll queue it up.
> >
> > Signed-off-by: Azeem Shaikh
>
> Reviewed-by: Kees Cook
>
> --
> Kees Cook
Best,
Sumit.
--
Thanks and
> > drm_syncobj_assign_null_handle(), to check for NULL instead.
> >
> > Fixes: f781f661e8c9 ("dma-buf: keep the signaling time of merged fences v3")
> > Signed-off-by: Dan Carpenter
>
Thanks for catching this!
> Reviewed-by: Christian König
Reviewed-by: Sumi
Hi Alex,
On 23 September 2016 at 18:24, Daniel Vetter wrote:
> On Mon, Aug 29, 2016 at 08:08:24AM +0100, Chris Wilson wrote:
>> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
>> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
>> need to handle such co
Hi Ben,
On 23 September 2016 at 18:25, Daniel Vetter wrote:
> On Mon, Aug 29, 2016 at 08:08:27AM +0100, Chris Wilson wrote:
>> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
>> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
>> need to handle such con
Hi Thomas, Sinclair,
On 23 September 2016 at 18:26, Daniel Vetter wrote:
> On Mon, Aug 29, 2016 at 08:08:28AM +0100, Chris Wilson wrote:
>> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
>> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
>> need to ha
Hi Lucas,
On 23 September 2016 at 18:25, Daniel Vetter wrote:
> On Mon, Aug 29, 2016 at 08:08:25AM +0100, Chris Wilson wrote:
>> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
>> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
>> need to handle such c
ully it
>> (
>> ...
>> )
>>
>> Signed-off-by: Chris Wilson
Acked-by: Sumit Semwal
Daniel,
As we agreed, we should perhaps take it via the drm tree?
>
> Reviewed-by: Gustavo Padovan
>
> Gustavo
>
Best regards,
Sumit.
Hi Russell,
On 31 March 2017 at 15:33, Russell King wrote:
> Align the heading with the values output from debugfs.
>
> Signed-off-by: Russell King
Thanks for your patch; applied to drm-misc-next.
> ---
> drivers/dma-buf/dma-buf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
'll take a while to get there. For now this is good enough I
>> think.
>
> All true.
>
> Reviewed-by: Daniel Stone
>
Thanks for this, Daniel!
Reviewed-by: Sumit Semwal
Best,
Sumit.
> Cheers,
> Daniel
___
dri-devel mailing
Hi Daniel,
On 11 April 2017 at 13:03, Sumit Semwal wrote:
> On 11 April 2017 at 12:38, Daniel Stone wrote:
>> Hi,
>>
>> On 11 April 2017 at 07:48, Daniel Vetter wrote:
>>> Note: As Daniel Stone mentioned in the announcement fd.o admins
>>> started chat
eed it later.
>>
>> [airlied: fix buildbot warnings]
>>
>> Reviewed-by: Chris Wilson
>> Signed-off-by: Dave Airlie
>> ---
>> drivers/dma-buf/sync_file.c | 13 ++---
>> include/linux/sync_file.h | 3 ---
>> 2 files changed, 2 insert
Hi Robert,
On 13 April 2017 at 21:40, Robert Foss wrote:
> From: Sean Paul
>
> From drm_crtc.h, for use with the plane "rotation" property.
>
> Signed-off-by: Sean Paul
> Signed-off-by: Robert Foss
Thanks for the patch; fwiw, please feel free to a
istency I've renamed all four of kmap* and kunmap* to be
>> map* and unmap*. (Even though only kmap_atomic presently conflicts.)
>>
>> [1] https://www.spinics.net/lists/target-devel/msg15070.html
>>
>> Signed-off-by: Logan Gunthorpe
>> Reviewed-by: Sinclair Y
--- a/drivers/staging/android/ion/ion.c
>>> +++ b/drivers/staging/android/ion/ion.c
>>> @@ -1020,10 +1020,10 @@ static const struct dma_buf_ops dma_buf_ops = {
>>> .release = ion_dma_buf_release,
>>> .begin_cpu_access = ion_dma_buf_begin_cpu_access,
>>> .end_cpu_access = ion_dma_buf_end_cpu_access,
>>> - .kmap_atomic = ion_dma_buf_kmap,
>>> - .kunmap_atomic = ion_dma_buf_kunmap,
>>> - .kmap = ion_dma_buf_kmap,
>>> - .kunmap = ion_dma_buf_kunmap,
>>> + .map_atomic = ion_dma_buf_kmap,
>>> + .unmap_atomic = ion_dma_buf_kunmap,
>>> + .map = ion_dma_buf_kmap,
>>> + .unmap = ion_dma_buf_kunmap,
>>> };
>>>
>>> struct dma_buf *ion_share_dma_buf(struct ion_client *client,
>>> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
>>> index bfb3704..79f27d6 100644
>>> --- a/include/linux/dma-buf.h
>>> +++ b/include/linux/dma-buf.h
>>> @@ -39,13 +39,13 @@ struct dma_buf_attachment;
>>>
>>> /**
>>>* struct dma_buf_ops - operations possible on struct dma_buf
>>> - * @kmap_atomic: maps a page from the buffer into kernel address
>>> - * space, users may not block until the subsequent unmap
>>> call.
>>> - * This callback must not sleep.
>>> - * @kunmap_atomic: [optional] unmaps a atomically mapped page from the
>>> buffer.
>>> - *This Callback must not sleep.
>>> - * @kmap: maps a page from the buffer into kernel address space.
>>> - * @kunmap: [optional] unmaps a page from the buffer.
>>> + * @map_atomic: maps a page from the buffer into kernel address
>>> + * space, users may not block until the subsequent unmap
>>> call.
>>> + * This callback must not sleep.
>>> + * @unmap_atomic: [optional] unmaps a atomically mapped page from the
>>> buffer.
>>> + * This Callback must not sleep.
>>> + * @map: maps a page from the buffer into kernel address space.
>>> + * @unmap: [optional] unmaps a page from the buffer.
>>>* @vmap: [optional] creates a virtual mapping for the buffer into
>>> kernel
>>>* address space. Same restrictions as for vmap and friends apply.
>>>* @vunmap: [optional] unmaps a vmap from the buffer
>>> @@ -206,10 +206,10 @@ struct dma_buf_ops {
>>> * to be restarted.
>>> */
>>> int (*end_cpu_access)(struct dma_buf *, enum dma_data_direction);
>>> - void *(*kmap_atomic)(struct dma_buf *, unsigned long);
>>> - void (*kunmap_atomic)(struct dma_buf *, unsigned long, void *);
>>> - void *(*kmap)(struct dma_buf *, unsigned long);
>>> - void (*kunmap)(struct dma_buf *, unsigned long, void *);
>>> + void *(*map_atomic)(struct dma_buf *, unsigned long);
>>> + void (*unmap_atomic)(struct dma_buf *, unsigned long, void *);
>>> + void *(*map)(struct dma_buf *, unsigned long);
>>> + void (*unmap)(struct dma_buf *, unsigned long, void *);
>>>
>>> /**
>>> * @mmap:
>
>
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
>
--
Thanks and regards,
Sumit Semwal
Linaro Mobile Group - Kernel Team Lead
Linaro.org │ Open source software for ARM SoCs
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 21 April 2017 at 03:20, Daniel Vetter wrote:
>> - Rename dma_buf_ops->kmap_* to avoid naming collision (Logan)
>
> This one touches v4l and ion and is acked by the corresponding
> maintainers (but Sumit forgot to record that when applying the patch,
> and Sean didn't highlight it in the summar
is a new version to address that. I also
> addressed some minor comments on the patch to collapse header files.
For the series, please feel free to apply my
Acked-by: Sumit Semwal
>
> Thanks,
> Laura
>
> Laura Abbott (12):
> cma: Store a name in the cma structure
>
ng and would like to emit this tracepoint for completeness.
>>
>> Signed-off-by: Chris Wilson
>> Cc: Sumit Semwal
>> Cc: Daniel Vetter
>> ---
>> drivers/dma-buf/dma-fence.c | 1 +
>> 1 file changed, 1 insertion(+)
well.
> >
> > Signed-off-by: Gustavo Padovan
>
> Acked-by: Daniel Vetter
>
> Of course, feel free to add my
Acked-by: Sumit Semwal
> I guess wait for an ack from Sumit, then push.
> -Daniel
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 in
ntry was not added on Kbuild to install it. This patch resolves this
> omission
> so that "make headers_install" installs this header.
>
> Thanks for the patch; please feel free to add my
Acked-by: Sumit Semwal
> Signed-off-by: Denys Dmytriyenko
> Reviewed-by: Tomi Valkei
d on Kbuild to install it. This patch resolves this omission
> so that "make headers_install" installs this header.
>
Thanks for the patch; please feel free to add my
Acked-by: Sumit Semwal
> Signed-off-by: Denys Dmytriyenko
> Reviewed-by: Tomi Valkeinen
> Cc: Ville
Hi Gustavo,
On 16 February 2017 at 02:27, Chris Wilson wrote:
> On Wed, Feb 15, 2017 at 03:57:25PM -0200, Gustavo Padovan wrote:
>> From: Gustavo Padovan
>>
>> Document return values for this function.
>>
>> Signed-off-by: Gustavo Padovan
> Reviewed-by: Chris Wilson
> -Chris
>
Thanks, pushed
is Reviewed-by: Christian König
>> .
>
Thanks much for spotting this!
> Since you have commit rights for drm-misc, care to push this to
> drm-misc-next-fixes pls? Also I think this warrants a cc: stable,
> clearly an obvious screw-up in creating this api on our side :( So
> feel free
1 - 100 of 402 matches
Mail list logo
