Re: [PATCH 4/5] arm64: dts: qcom: sdm845: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 5/5] arm64: dts: qcom: sm8250: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-01 Thread Stephen Boyd
Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Stephen Boyd
Quoting Rob Clark (2022-03-03 11:46:47) > diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h > index fde9a29f884e..0ba1dbd4e50f 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.h > +++ b/drivers/gpu/drm/msm/msm_gpu.h > @@ -330,6 +337,24 @@ struct msm_file_private { > struc

Re: [PATCH 1/4] drm/msm/dpu: document INTF_EDP/INTF_DP difference

2022-03-03 Thread Stephen Boyd
DP and DP interfaces handled by the msm/dp > driver. The DPU driver does not make a difference between them. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/4] drm/msm/dpu: drop INTF_TYPE_MAX symbol

2022-03-03 Thread Stephen Boyd
by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/4] drm/msm/dpu: drop obsolete INTF_EDP comment

2022-03-03 Thread Stephen Boyd
ment serves no purpose. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 4/4] drm/msm/dpu: drop INTF_EDP from interface type conditions

2022-03-03 Thread Stephen Boyd
by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 3/6] drm/msm/dpu: allow just single IRQ callback

2022-03-03 Thread Stephen Boyd
upt handling code. > > Reported-by: kernel test robot > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-03-03 Thread Stephen Boyd
longer needs to remember which function is called. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 0/6] drm/msm/dpu: simplify IRQ helpers

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 20:31:42) > This is the second part of > https://patchwork.freedesktop.org/series/91631/ reworked and cleaned up. > > Changes since v1: v2? > - Fix warning ins dpu_trace.h related to >dpu_core_irq_unregister_callback event Any plans to migrate to hierarc

Re: [PATCH v4 1/4] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
d value during the usecase. > > Changes in v2: > - Remove assigned-clock-rate property and set mdp clk during resume sequence. > - Add fixes tag. > > Changes in v3: > - Remove extra line after fixes tag.(Stephen Boyd) > This changelog goes below triple dash when they ar

Re: [PATCH v4 2/4] arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
d value during the usecase. > > Fixes: a3db7ad1af("arm64: dts: qcom: sc7180: add display dt nodes") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 3/4] arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
d value during the usecase. > > Fixes: 08c2a076d1("arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
d value during the usecase. > > Fixes: 7c1dffd471("arm64: dts: qcom: sm8250.dtsi: add display system nodes") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-03-03 Thread Stephen Boyd
Quoting Vinod Polimera (2022-03-03 03:42:59) > - Some DPU versions support inline rot90. It is supported only for > limited amount of UBWC formats. > - There are two versions of inline rotators, v1 (present on sm8250 and > sm7250) and v2 (sc7280). These versions differ in the list of supported > fo

Re: [PATCH v5 1/5] drm/msm/dpu: simplify clocks handling

2022-03-03 Thread Stephen Boyd
andled using devres instead. > > DP implementation is unchanged for now. > > Tested-by: Jessica Zhang # RB3 (sdm845) and RB5 > (qrb5165) > Reviewed-by: Jessica Zhang > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 2/5] drm/msm/dp: "inline" dp_ctrl_set_clock_rate("ctrl_link")

2022-03-03 Thread Stephen Boyd
) directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:27) > The only clock for which we set the rate is the "stream_pixel". Rather > than storing the rate and then setting it by looping over all the > clocks, set the clock rate directly. > > Signed-off-by: Dmitry Baryshkov [...] > diff --git a/drivers/gpu/dr

Re: [PATCH v5 4/5] drm/msm/dp: inline dp_power_clk_set_rate()

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:28) > Inline the dp_power_clk_set_rate() function, replacing it with the call > to msm_dss_enable_clk(). > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 5/5] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:29) > In order to simplify DP code, drop hand-coded loops over clock arrays, > replacing them with clk_bulk_* functions. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Stephen Boyd
Quoting Rob Clark (2022-03-03 13:47:14) > On Thu, Mar 3, 2022 at 1:17 PM Rob Clark wrote: > > > > On Thu, Mar 3, 2022 at 12:47 PM Stephen Boyd wrote: > > > > > > Quoting Rob Clark (2022-03-03 11:46:47) > > > > + > > > > + /* then

Re: [PATCH 00/12] Add writeback block support for DPU

2022-03-03 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-02-04 13:17:13) > This series adds support for writeback block on DPU. Writeback > block is extremely useful to validate boards having no physical displays > in addition to many other use-cases where we want to get the output > of the display pipeline to examine whether

Re: [PATCH v2 1/4] drm/msm: unify MDSS drivers

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:40:02) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > b/drivers/gpu/drm/msm/msm_mdss.c > similarity index 58% > rename from drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > rename to drivers/gpu/drm/msm/msm_mdss.c > index 9f5cc7f9e9a9..f5429eb0ae52 1006

Re: [PATCH v2 2/4] drm/msm: remove extra indirection for msm_mdss

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:40:03) > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index be06a62d7ccb..f18dfbb614f0 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -1211,19 +1212,32 @@ static int msm_pdev_probe(struc

Re: [PATCH v2 3/4] drm/msm: split the main platform driver

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:40:04) > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index 06d26c5fb274..6895c056be19 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -451,10 +451,18 @@ static inline void msm_dp_debugfs

Re: [PATCH v2 4/4] drm/msm: stop using device's match data pointer

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:40:05) > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 759076357e0e..f83dca99f03d 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -314,11 +314,11 @@ static const struct dev_pm_op

Re: [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 15:50:50) > On Thu, 3 Mar 2022 at 12:40, Vinod Polimera wrote: > > > > Kernel clock driver assumes that initial rate is the > > max rate for that clock and was not allowing it to scale > > beyond the assigned clock value. > > > > Drop the assigned clock rate pr

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 20:23:06) > On Fri, 4 Mar 2022 at 01:32, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-02-16 21:55:27) > > > The only clock for which we set the rate is the "stream_pixel". Rather > > > than storing the r

Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-30 Thread Stephen Boyd
Quoting Marijn Suijten (2021-08-30 11:24:44) > All DSI PHY/PLL drivers were referencing their VCO parent clock by a > global name, most of which don't exist or have been renamed. These > clock drivers seem to function fine without that except the 14nm driver > for the sdm6xx [1]. > > At the same

Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-30 Thread Stephen Boyd
Quoting Marijn Suijten (2021-08-30 15:45:42) > Hi Stephen, > > On 2021-08-30 15:16:13, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-08-30 11:24:44) > > > All DSI PHY/PLL drivers were referencing their VCO parent clock by a > > > global name, most of which

Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-08-30 Thread Stephen Boyd
Quoting Lyude Paul (2021-08-30 09:58:01) > On Mon, 2021-08-30 at 08:56 -0700, khs...@codeaurora.org wrote: > > On 2021-08-25 09:26, Lyude Paul wrote: > > > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems > > > like it > > > just hasn't trickled down to linus's branch quite ye

Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-31 Thread Stephen Boyd
Quoting Marijn Suijten (2021-08-30 16:10:26) > > I'm 95% sure this shouldn't cause any problems given current DTs and > their history, but that's probably not enough. This might also impact > DTs that have not yet been upstreamed, but afaik the general stance is > to not care and actually serve a

Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-08-31 Thread Stephen Boyd
b1a6-a1cd-3c7d-a88e-dc83f8a1b...@somainline.org/ > and prevented the removal of "xo" at that time. > > Signed-off-by: Marijn Suijten > --- Presumably this wants to go with the first one. Acked-by: Stephen Boyd

Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-09-01 Thread Stephen Boyd
Quoting Marijn Suijten (2021-09-01 01:49:10) > Hi Stephen, > > On 2021-08-31 22:35:12, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-08-30 16:10:26) > > > > > > I'm 95% sure this shouldn't cause any problems given current DTs and > > >

Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-01 Thread Stephen Boyd
Quoting Marijn Suijten (2021-09-01 01:57:15) > On 2021-08-31 22:35:56, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-08-30 11:24:45) > > > The DSI PHY/PLL was relying on a global "xo" clock to be found, but the > > > real clock is named "xo_boar

Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-02 Thread Stephen Boyd
Quoting Marijn Suijten (2021-09-02 06:05:34) > On 2021-09-01 20:46:34, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-09-01 01:57:15) > > > On 2021-08-31 22:35:56, Stephen Boyd wrote: > > > > Quoting Marijn Suijten (2021-08-30 11:24:45) > > > > >

Re: [PATCH v3 06/16] ARM: configs: Everyone who had PANEL_SIMPLE now gets PANEL_SIMPLE_EDP

2021-09-03 Thread Stephen Boyd
Quoting Doug Anderson (2021-09-01 16:10:15) > Hi, > > On Wed, Sep 1, 2021 at 2:12 PM Olof Johansson wrote: > > > > On Wed, Sep 1, 2021 at 1:20 PM Douglas Anderson > > wrote: > > > > > > In the patch ("drm/panel-simple-edp: Split eDP panels out of > > > panel-simple") we split the PANEL_SIMPLE d

Re: [PATCH 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-08 Thread Stephen Boyd
Quoting Philip Chen (2021-09-08 11:18:05) > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > b/drivers/gpu/drm/bridge/parade-ps8640.c > index 685e9c38b2db..a16725dbf912 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -64,12 +65,29 @@ s

Re: [PATCH 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-08 Thread Stephen Boyd
Quoting Philip Chen (2021-09-08 11:18:06) > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > b/drivers/gpu/drm/bridge/parade-ps8640.c > index a16725dbf912..3f0241a60357 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -93,6 +115,102 @@

Re: [PATCH 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-09 Thread Stephen Boyd
Quoting Philip Chen (2021-09-09 11:15:27) > On Wed, Sep 8, 2021 at 3:27 PM Stephen Boyd wrote: > > > > Quoting Philip Chen (2021-09-08 11:18:06) > > > > > + > > > + data = (len - 1) & AUX_LENGTH_MASK; > > > + regmap_write(map, PAGE0_

Re: [PATCH 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-09 Thread Stephen Boyd
Quoting Philip Chen (2021-09-09 11:29:19) > Hi, > > On Wed, Sep 8, 2021 at 2:54 PM Stephen Boyd wrote: > > > > Quoting Philip Chen (2021-09-08 11:18:05) > > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > > > b/drivers/gpu/drm/bridge/parade-ps8640.c

Re: [PATCH 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-09 Thread Stephen Boyd
Quoting Doug Anderson (2021-09-09 14:14:29) > On Thu, Sep 9, 2021 at 12:09 PM Stephen Boyd wrote: > > > > > > Oh does this have register pages? regmap has support for pages where you > > write some indirection register and then access the same i2c address for &g

Re: [PATCH 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers

2021-09-13 Thread Stephen Boyd
Quoting Sean Paul (2021-09-13 10:57:43) > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 64d8d9e5e47a..984301442653 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller

Re: [PATCH 13/14] drm/msm: Add hdcp register ranges to sc7180 device tree

2021-09-13 Thread Stephen Boyd
Quoting Sean Paul (2021-09-13 10:57:44) > From: Sean Paul > > This patch adds the register ranges required for HDCP to the sc7180 > device tree. These registers will be used to inject HDCP key as well as > toggle HDCP on and off. It doesn't look to do any of that? > > Signed-off-by: Sean Paul >

Re: [PATCH v1 1/2] drm/msm/dp: Add support for SC7280 eDP

2021-09-13 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-08-11 17:08:01) > The eDP controller on SC7280 is similar to the eDP/DP controllers > supported by the current driver implementation. > > SC7280 supports one EDP and one DP controller which can operate > concurrently. > > The following are some required changes fo

Re: [PATCH v4 01/15] dt-bindings: drm/panel-simple-edp: Introduce generic eDP panels

2021-09-14 Thread Stephen Boyd
Quoting Douglas Anderson (2021-09-09 14:00:17) > diff --git a/Documentation/devicetree/bindings/display/panel/panel-edp.yaml > b/Documentation/devicetree/bindings/display/panel/panel-edp.yaml > new file mode 100644 > index ..6a621376ff86 > --- /dev/null > +++ b/Documentation/devicetree

Re: [PATCH v3 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent

2021-09-14 Thread Stephen Boyd
Quoting Marijn Suijten (2021-09-11 06:19:19) > All DSI PHY/PLL drivers were referencing their VCO parent clock by a > global name, most of which don't exist or have been renamed. These > clock drivers seem to function fine without that except the 14nm driver > for sdm6xx [1]. > > At the same time

Re: [PATCH v3 1/3] drm/bridge: parade-ps8640: Improve logging at probing

2021-09-14 Thread Stephen Boyd
Quoting Philip Chen (2021-09-14 16:28:43) > Use dev_err_probe() to add logs for error cases at probing time. > > Signed-off-by: Philip Chen > --- > Can you use a cover-letter for more than one patch series? > (no changes since v1) > > drivers/gpu/drm/bridge/parade-ps8640.c | 22 ++--

Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-14 Thread Stephen Boyd
Quoting Philip Chen (2021-09-14 16:28:44) > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > b/drivers/gpu/drm/bridge/parade-ps8640.c > index e340af381e05..8d3e7a147170 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -368,6 +396,12 @@

Re: [PATCH v3 3/3] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-14 Thread Stephen Boyd
Quoting Philip Chen (2021-09-14 16:28:45) > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > b/drivers/gpu/drm/bridge/parade-ps8640.c > index 8d3e7a147170..dc349d729f5a 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -117,6 +144,129 @@

Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-14 Thread Stephen Boyd
Quoting Doug Anderson (2021-09-14 19:17:03) > Hi, > > On Tue, Sep 14, 2021 at 5:29 PM Stephen Boyd wrote: > > > > Quoting Philip Chen (2021-09-14 16:28:44) > > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > > > b/drivers/gpu/drm/bridge/p

Re: [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-09-15 Thread Stephen Boyd
Quoting Hans de Goede (2021-08-17 14:52:01) > diff --git a/drivers/usb/typec/altmodes/displayport.c > b/drivers/usb/typec/altmodes/displayport.c > index aa669b9cf70e..c1d8c23baa39 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -125,6 +

Re: [PATCH v3 3/3] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-16 Thread Stephen Boyd
Quoting Doug Anderson (2021-09-15 14:27:40) > Hi, > > On Tue, Sep 14, 2021 at 5:57 PM Stephen Boyd wrote: > > > > Quoting Philip Chen (2021-09-14 16:28:45) > > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > > > b/drivers/gpu/drm/bridge/p

Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-16 Thread Stephen Boyd
TL;DR: Please try to reduce these error messages in drivers and consolidate them into subsystems so that drivers stay simple. Quoting Doug Anderson (2021-09-15 09:41:39) > Hi, > > On Tue, Sep 14, 2021 at 7:50 PM Stephen Boyd wrote: > > > > > > I'd rather see any

Re: [PATCH v2 11/13] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules

2021-09-16 Thread Stephen Boyd
Signed-off-by: Sean Paul > Link: > https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-s...@poorly.run > #v1 > > Changes in v2: > -None > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack

2021-09-16 Thread Stephen Boyd
t > serves no purpose any longer. So remove the indirection. When did it become false? Just curious when this became obsolete. > > Signed-off-by: Sean Paul > Link: > https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-11-s...@poorly.run > #v1 > > Changes in

Re: [PATCH v2 09/13] drm/msm/dpu: Remove useless checks in dpu_encoder

2021-09-16 Thread Stephen Boyd
v2: > -None > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 08/13] drm/msm/dpu_kms: Re-order dpu includes

2021-09-16 Thread Stephen Boyd
Quoting Sean Paul (2021-09-15 13:38:27) > From: Sean Paul > > Make includes alphabetical in dpu_kms.c > > Signed-off-by: Sean Paul > Link: > https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-9-s...@poorly.run > #v1 > > Changes in v2: > -None > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-09-16 Thread Stephen Boyd
Quoting Sean Paul (2021-09-15 13:38:32) > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index c8921e2d6480..3ae6fc7a2c01 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3088,7 +3088,9 @@ mdss_dp:

Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-16 Thread Stephen Boyd
Quoting Doug Anderson (2021-09-16 16:21:12) > Hi, > > On Thu, Sep 16, 2021 at 3:17 PM Stephen Boyd wrote: > > > > TL;DR: Please try to reduce these error messages in drivers and > > consolidate them into subsystems so that drivers stay simple. > > > > Quo

Re: [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Stephen Boyd (2021-10-07 11:40:07) > Quoting Saravana Kannan (2021-10-06 20:07:11) > > On Wed, Oct 6, 2021 at 12:38 PM Stephen Boyd wrote: > > > diff --git a/drivers/base/component.c b/drivers/base/component.c > > > index 0a41bbe14981..d99e99cabb99 1006

Re: [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2021-10-06 22:37:40) > On Wed, Oct 06, 2021 at 12:37:47PM -0700, Stephen Boyd wrote: > > > > Let's make the component driver into an actual device driver that has > > probe/remove/shutdown functions. The driver will only be bound to the >

Re: [PATCH v2 00/34] component: Make into an aggregate bus

2021-10-07 Thread Stephen Boyd
Quoting Andrzej Hajda (2021-10-07 03:16:27) > Hi Stephen, > > On 06.10.2021 21:37, Stephen Boyd wrote: > > This series is from discussion we had on reordering the device lists for > > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put >

Re: [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-07 Thread Stephen Boyd
aurora.org wrote: > >> > > >> > > On 2021-10-05 19:10, Bjorn Andersson wrote: > >> > > > On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote: > >> > > > > >> > > > > On 2021-10-05 15:36, Stephen Boyd wrote:

Re: [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Saravana Kannan (2021-10-07 18:10:24) > On Thu, Oct 7, 2021 at 1:11 PM Stephen Boyd wrote: > > > > Quoting Stephen Boyd (2021-10-07 11:40:07) > > > Quoting Saravana Kannan (2021-10-06 20:07:11) > > > > On Wed, Oct 6, 2021 at 12:38 PM Stephen Boyd &

Re: [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Saravana Kannan (2021-10-07 18:32:20) > On Thu, Oct 7, 2021 at 6:24 PM Stephen Boyd wrote: > > > > Anyway, I think we still have to do a rescan so that we can try to bind > > the aggregate device. Is there a better API to use for that? > > If you know the e

Re: [PATCH v2] drm/msm/dsi: Use division result from div_u64_rem in 7nm and 14nm PLL

2021-10-12 Thread Stephen Boyd
earlier to the 10nm pll in > 5c191fef4ce2 ("drm/msm/dsi_pll_10nm: Fix dividing the same numbers > twice"). > > Signed-off-by: Marijn Suijten > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dp: Use the connector passed to dp_debug_get()

2021-10-12 Thread Stephen Boyd
ode and the support the s/the support the/to support the/ > multiple instances. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 01/34] component: Introduce struct aggregate_device

2021-10-13 Thread Stephen Boyd
Quoting Daniel Vetter (2021-10-13 05:22:23) > On Wed, Oct 06, 2021 at 12:37:46PM -0700, Stephen Boyd wrote: > > Replace 'struct master' with 'struct aggregate_device' and then rename > > 'master' to 'adev' everywhere in the code. While w

Re: [PATCH v12 05/35] dt-bindings: clock: tegra-car: Document new clock sub-nodes

2021-10-14 Thread Stephen Boyd
Quoting Dmitry Osipenko (2021-09-20 11:11:15) > diff --git a/Documentation/devicetree/bindings/clock/nvidia,tegra20-car.yaml > b/Documentation/devicetree/bindings/clock/nvidia,tegra20-car.yaml > index 459d2a525393..f832abb7f11a 100644 > --- a/Documentation/devicetree/bindings/clock/nvidia,tegra20-

Re: [PATCH v12 05/35] dt-bindings: clock: tegra-car: Document new clock sub-nodes

2021-10-14 Thread Stephen Boyd
Quoting Dmitry Osipenko (2021-10-14 17:43:49) > 15.10.2021 03:16, Stephen Boyd пишет: > > Quoting Dmitry Osipenko (2021-09-20 11:11:15) > >> diff --git > >> a/Documentation/devicetree/bindings/clock/nvidia,tegra20-car.yaml > >> b/Documentation/devicetree/bi

Re: [PATCH 1/2] drm/msm/hdmi: use bulk regulator API

2021-10-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-10-14 17:10:59) > Switch to using bulk regulator API instead of hand coding loops. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] ARM: dts: qcom-apq8064: stop using legacy clock names for HDMI

2021-10-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-10-14 14:42:21) > Stop using legacy clock names (with _clk suffix) for HDMI and HDMI PHY > device tree nodes. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 3/7] drm/msm/dp: Allow specifying connector_type per controller

2021-10-16 Thread Stephen Boyd
block at this point, the array of descs > and the search in dp_display_get_desc() are introduced here to simplify > the next patch, that does introduce support for multiple DP blocks. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 4/7] drm/msm/dp: Allow attaching a drm_panel

2021-10-16 Thread Stephen Boyd
DP and which is eDP, > parser->parse() is passed the connector_type and the parser is limited > to only search for a panel in the eDP case. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-16 Thread Stephen Boyd
. > > Lastly, bump the number of struct msm_dp instances carries by priv->dp > to 3, the currently known maximum number of controllers found in a > Qualcomm SoC. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 7/7] drm/msm/dp: Add sc8180x DP controllers

2021-10-16 Thread Stephen Boyd
> --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 7/7] drm/msm/dp: Add sc8180x DP controllers

2021-10-16 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-10-16 15:18:43) > The sc8180x has 2 DP and 1 eDP controllers, add support for these to the > DP driver. > > Link: > https://lore.kernel.org/linux-arm-msm/20210725042436.3967173-7-bjorn.anders...@linaro.org/ BTW, was the link intentional?

Re: [PATCH v2] drm/msm: use compatible lists to find mdp node

2021-10-19 Thread Stephen Boyd
ed-off-by: Krishna Manikandan > > Changes in v2: >- Use compatible lists instead of duplicate string > check (Stephen Boyd) > --- > drivers/gpu/drm/msm/msm_drv.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/

Re: [PATCH v2 1/2] drm/msm/dp: Add support for SC7280 eDP

2021-10-21 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-10-20 05:14:10) > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index 62e75dc..9fea49c 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -1238,9 +1240,21 @@ static int dp_ctrl_link

Re: [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280

2021-10-21 Thread Stephen Boyd
gt; - Drop target from description (Stephen Boyd) > - Drop items from compatible (Stephen Boyd) > - Add clock names one per line for readability (Stephen Boyd) > - Use correct indendation (Stephen Boyd) This changelog should come after the triple dash. qcom maintainers don't want d

Re: [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-10-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-10-20 06:58:51) > Add mdss and mdp DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > - Rename display dt nodes (Stephen Boyd) > - Add clock names one per line for readability (Stephen Boyd) > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes

2021-10-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-10-20 06:58:53) > From: Sankeerth Billakanti > > Add edp controller and phy DT nodes for sc7280. > > Signed-off-by: Sankeerth Billakanti > Signed-off-by: Krishna Manikandan > Some comments below Reviewed-by: Stephen Boyd > Cha

Re: [PATCH v2 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes

2021-10-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-10-20 06:58:52) > Add DSI controller and PHY nodes for sc7280. > > Signed-off-by: Rajeev Nandan > Signed-off-by: Krishna Manikandan > Reviewed-by: Matthias Kaehlcke > > Changes in v2: > - Drop flags from interrupts (Stephen Boyd) >

Re: [PATCH v2 1/2] drm/bridge: parade-ps8640: Enable runtime power management

2021-10-25 Thread Stephen Boyd
Quoting Philip Chen (2021-10-21 14:05:59) > Fit ps8640 driver into runtime power management framework: > > First, break _poweron() to 3 parts: (1) turn on power and wait for > ps8640's internal MCU to finish init (2) check panel HPD (which is > proxied by GPIO9) (3) the other configs. As runtime_re

Re: [PATCH v2 2/2] drm/bridge: parade-ps8640: Populate devices on aux-bus

2021-10-25 Thread Stephen Boyd
turn false; > + of_node_put(panel); > + > + return true; > +} > + > static void ps8640_ensure_hpd(struct ps8640 *ps_bridge) > { > struct regmap *map = ps_bridge->regmap[PAGE2_TOP_CNTL]; Otherwise Reviewed-by: Stephen Boyd

[PATCH v3 00/34] component: Make into an aggregate bus

2021-10-25 Thread Stephen Boyd
/20210508074118.1621729-1-swb...@chromium.org Stephen Boyd (34): component: Introduce struct aggregate_device component: Remove most references to 'master' component: Introduce the aggregate bus_type component: Move struct aggregate_device out to header file component: Add {bind

[PATCH v3 01/34] component: Introduce struct aggregate_device

2021-10-25 Thread Stephen Boyd
Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v3 03/34] component: Introduce the aggregate bus_type

2021-10-25 Thread Stephen Boyd
s to attach shutdown logic (and in the future runtime PM logic) to the aggregate driver so that it runs the hooks in the correct order. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-

[PATCH v3 07/34] drm/msm: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
play pipeline is called before any of the component device driver shutdown hooks are called. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_drv.c | 46 +++--

[PATCH v3 04/34] component: Move struct aggregate_device out to header file

2021-10-25 Thread Stephen Boyd
: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 15 --- include/linux/component.h | 19 --- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index 3d9d2f94df28..997b17053ecf 10

[PATCH v3 06/34] drm/of: Add a drm_of_aggregate_probe() API

2021-10-25 Thread Stephen Boyd
c: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_of.c | 85 +++- include/drm/drm_of.h | 12 ++ 2 files changed, 78 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_

[PATCH v3 02/34] component: Remove most references to 'master'

2021-10-25 Thread Stephen Boyd
ravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 248 +++--- include/linux/component.h | 2 +- 2 files changed, 123 insertions(+), 127 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index 1c3c91ba7d2e..

[PATCH v3 05/34] component: Add {bind, unbind}_component() ops that take aggregate device

2021-10-25 Thread Stephen Boyd
Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 14 +++--- include/linux/component.h | 22 ++ 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component

[PATCH v3 08/34] drm/komeda: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- .../gpu/drm/arm/display/komeda/komeda_drv.c | 20 --- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/disp

[PATCH v3 09/34] drm/arm/hdlcd: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/arm/hdlcd_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 479c2422a2e0..5c03eb98d814 100644 --- a/drive

[PATCH v3 12/34] drm/etnaviv: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 7d

[PATCH v3 11/34] drm/armada: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/armada/armada_drv.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c index 8e3e98f13db4..b3559363ea43 100644 --- a/drive

[PATCH v3 14/34] drm/exynos: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drive

<    1   2   3   4   5   6   7   8   9   10   >