[PATCH] drm/msm/dpu: Add newlines to printks

2021-07-07 Thread Stephen Boyd
Add some missing newlines to the various DRM printks in this file. Noticed while looking at logs. While we're here unbreak quoted strings so grepping them is easier. Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +--- 1 file changed, 5 insertions(

Re: [PATCH 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:14) > DP cable should always connect to DPU during the entire PHY compliance > testing run. Since DP PHY compliance test is executed at irq_hpd event > context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off(). > dp_ctrl_off() is used for unpl

Re: [PATCH 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:18) > Response with correct edid checksum saved at connector after corrupted edid > checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_panel.c | 9 +++-- > 1 file changed, 7

Re: [PATCH 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:20) > Main link symbol locked is achieved at end of link training 2. Some > dongle main link symbol may become unlocked again if host did not end > link training soon enough after completion of link training 2. Host > have to re train main link if loss of symb

Re: [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:15) > Reduce link rate and re start link training if link training 1 > failed due to loss of clock recovery done to fix Link Layer > CTS case 4.3.1.7. Also only update voltage and pre-emphasis > swing level after link training started to fix Link Layer CTS >

Re: [PATCH 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:16) > Aux hardware calibration sequence requires resetting the aux controller > in order for the new setting to take effect. However resetting the AUX > controller will also clear HPD interrupt status which may accidentally > cause pending unplug interrupt to

Re: [PATCH 4/7] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-07-08 Thread Stephen Boyd
y: Kuogee Hsieh > --- This needs a Fixes tag of some kind. Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-08 Thread Stephen Boyd
Quoting maitreye (2021-07-08 12:13:44) > From: Maitreyee Rao > > Add trace points across the MSM DP driver to help debug > interop issues. > > Changes in v2: > - Got rid of redundant log messages. > - Added %#x instead of 0x%x wherever required. > - Got rid of __func__ calls in debug messages.

Re: [PATCH] drm/msm/dp: Remove unused variable

2021-07-14 Thread Stephen Boyd
y: kernel test robot > Signed-off-by: Souptick Joarder > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-07-09 10:46:41) > On 2021-07-08 00:33, Stephen Boyd wrote: > >> + > >> +static bool dp_ctrl_any_lane_cr_lose(struct dp_ctrl_private *ctrl, > >> + u8 *cr_status) > >> +{ >

Re: [PATCH 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-07-09 10:16:52) > On 2021-07-08 00:21, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-07-06 10:20:20) > >> Main link symbol locked is achieved at end of link training 2. Some > >> dongle main link symbol may become unlocke

Re: [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-03 Thread Stephen Boyd
Quoting Abhinav Kumar (2020-10-29 13:55:09) > For sinks that do not support audio, there is no need to notify > audio subsystem of the connection event. > > This will make sure that audio routes only to the primary display > when connected to such sinks. > Does this need a Fixes tag? Or it's jus

Re: [PATCH] drm/msm/dp: deinitialize mainlink if link training failedo

2020-11-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-30 16:22:53) > DP compo phy have to be enable to start link training. When > link training failed phy need to be disabled so that next > link trainng can be proceed smoothly at next plug in. This s/trainng/training/ > patch de initialize mainlink to disable phy if li

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-03 Thread Stephen Boyd
Quoting Doug Anderson (2020-11-02 08:37:21) > Hi, > > On Sun, Nov 1, 2020 at 9:37 AM Sam Ravnborg wrote: > > > > Hi Stephen. > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > > This patch series cleans up the DDC code a little b

[PATCH v3 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures

2020-11-03 Thread Stephen Boyd
2: - Move WRITE_STATUS_UPDATE check from case to assignment Changes in v2: - Handle WRITE_STATUS_UPDATE properly Reviewed-by: Douglas Anderson Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Sean Paul Acked-by: Sam Ravnborg Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/ti-s

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-03 Thread Stephen Boyd
Quoting Sam Ravnborg (2020-11-01 09:37:41) > Hi Stephen. > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > This patch series cleans up the DDC code a little bit so that > > it is more efficient time wise and supports grabbing the EDID > > of the eDP

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-03 Thread Stephen Boyd
Quoting Stephen Boyd (2020-11-02 17:15:24) > Quoting Sam Ravnborg (2020-11-01 09:37:41) > > Hi Stephen. > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > > This patch series cleans up the DDC code a little bit so that > > > it i

Re: [PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer()

2020-11-03 Thread Stephen Boyd
Quoting Doug Anderson (2020-11-02 08:18:47) > Hi, > > On Thu, Oct 29, 2020 at 6:17 PM Stephen Boyd wrote: > > > > These register reads and writes are sometimes directly next to each > > other in the register address space. Let's use regmap bulk read/write &

[PATCH v3 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer()

2020-11-03 Thread Stephen Boyd
chart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Sean Paul Acked-by: Sam Ravnborg Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 50 --- 1 file changed, 22 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/driver

Re: [PATCH v2 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2020-11-03 Thread Stephen Boyd
Quoting Doug Anderson (2020-11-02 08:06:14) > On Sun, Nov 1, 2020 at 11:21 AM Laurent Pinchart > wrote: > > On Thu, Oct 29, 2020 at 06:17:37PM -0700, Stephen Boyd wrote: > > > @@ -265,6 +267,23 @@ connector_to_ti_sn_bridge(struct drm_connector > > >

[PATCH v3 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-03 Thread Stephen Boyd
ected properly instead of treating them as some sort of error that can't be discerned. Stephen Boyd (4): drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer() drm/bridge: ti-sn65dsi86: Make polling a busy loop drm/bridge: ti-sn65dsi86: Read EDID blob over DDC drm/

Re: [Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-03 Thread Stephen Boyd
Quoting abhin...@codeaurora.org (2020-11-02 14:43:33) > Hi Stephen > > Thanks for the review. > > On 2020-11-02 13:19, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2020-10-29 13:55:09) > >> For sinks that do not support audio, there is no need to notify > >

[PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2020-11-03 Thread Stephen Boyd
Use the DDC connection to read the EDID from the eDP panel instead of relying on the panel to tell us the modes. Reviewed-by: Douglas Anderson Reviewed-by: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Sean Paul Acked-by: Sam Ravnborg Signed-off-by: Stephen Boyd --- drivers

Re: [PATCH v2] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-11-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-30 16:23:10) > Some dongle will not clear LINK_STATUS_UPDATED bit after > DPCD read which cause link training failed. This patch $ git grep 'this patch' -- Documentation/process/submitting-patches.rst > just read 6 bytes of DPCD link status from sink and return > wit

Re: [PATCH] drm/msm/dp: promote irq_hpd handle to handle link trainign correctly

2020-11-03 Thread Stephen Boyd
Subject has a typo in "training". Quoting Kuogee Hsieh (2020-10-30 16:23:24) > Some dongles, such as Apple, required link training done at irq_hpd s/required/require/ > request instead of plugin request. This patch promote irq_hpd hanlder s/hanlder/handler/ > to handle link training and setup

[PATCH v3 2/4] drm/bridge: ti-sn65dsi86: Make polling a busy loop

2020-11-03 Thread Stephen Boyd
adding any sort of delay here in the bridge driver. Reviewed-by: Douglas Anderson Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Sean Paul Acked-by: Sam Ravnborg Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 3/3] drm/msm/dp: promote irq_hpd handle to handle link training correctly

2020-11-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-11-03 12:49:02) > Some dongles require link training done at irq_hpd request instead > of plugin request. This patch promote irq_hpd handler to handle link > training and setup hpd_state correctly. > > Fixes: fdaf9a5e3c15 (drm/msm/dp: fixes wrong connection state caused

[PATCH] drm/panel: simple: Add flags to boe_nv133fhm_n61

2020-11-08 Thread Stephen Boyd
Reading the EDID of this panel shows that these flags should be set. Set them so that we match what is in the EDID. Cc: Douglas Anderson Cc: Bjorn Andersson Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/panel/panel-si

Re: [PATCH] drm/msm/dp: remove duplicate include statement

2020-11-12 Thread Stephen Boyd
Quoting Tian Tao (2020-11-10 23:57:56) > linux/rational.h is included more than once, Remove the one that isn't > necessary. > > Signed-off-by: Tian Tao > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.f

Re: [PATCH] drm/msm/dp: fix connect/disconnect handled at ir_hdp

2020-11-17 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-11-13 14:26:39) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 27e7e27b8b90..4e84f500b721 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -279,13 +279,25 @@ static voi

[PATCH] drm/msm/dpu: Remove chatty vbif debug print

2020-11-18 Thread Stephen Boyd
I don't know what this debug print is for but it is super chatty, throwing 8 lines of debug prints in the logs every time we update a plane. It looks like it has no value. Let's nuke it so we can get better logs. Cc: Sean Paul Cc: Abhinav Kumar Signed-off-by: Stephen Boyd --- drive

Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print

2020-11-18 Thread Stephen Boyd
Quoting abhin...@codeaurora.org (2020-11-17 12:34:56) > On 2020-11-17 09:26, Stephen Boyd wrote: > > I don't know what this debug print is for but it is super chatty, > > throwing 8 lines of debug prints in the logs every time we update a > > plane. It looks like it has

Re: [PATCH v2] drm/msm/dp: fix connect/disconnect handled at irq_hpd

2020-11-18 Thread Stephen Boyd
in V2: > -- add dp_display_handle_port_ststus_changed() > -- fix kernel test robot complaint > > Reported-by: kernel test robot > Fixes: 26b8d66a399e ("drm/msm/dp: promote irq_hpd handle to handle link > training correctly") > Signed-off-by

Re: [PATCH v5 1/5] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-08 Thread Stephen Boyd
ck-rate property and set mdp clk during resume sequence. > - Add fixes tag. > > Changes in v3: > - Remove extra line after fixes tag.(Stephen Boyd) This changelog should be removed. > > Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add display dt nodes") I thought fol

Re: [PATCH] drm/msm/adreno: fix cast in adreno_get_param()

2022-03-08 Thread Stephen Boyd
rm/msm/adreno: Expose speedbin to userspace") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 1/5] drm/msm: unify MDSS drivers

2022-03-08 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 2/5] drm/msm: remove extra indirection for msm_mdss

2022-03-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 19:21:03) > Since now there is just one mdss subdriver, drop all the indirection, > make msm_mdss struct completely opaque (and defined inside msm_mdss.c) > and call mdss functions directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 3/5] drm/msm: split the main platform driver

2022-03-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 19:21:04) > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 857eefbb8649..c89de88ed2d1 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -255,3 +258,170 @@ struct msm_mdss *msm_mdss_ini

Re: [PATCH v3 4/5] drm/msm: stop using device's match data pointer

2022-03-08 Thread Stephen Boyd
private data instead. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 19:21:06) > MSM DRM driver already allows one to compile out the DP or DSI support. > Add support for disabling other features like MDP4/MDP5/DPU drivers or > direct HDMI output support. > > Suggested-by: Stephen Boyd > Signed-off-by

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-03-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 23:58:58) > On Fri, 4 Mar 2022 at 07:31, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-03-03 20:23:06) > > > On Fri, 4 Mar 2022 at 01:32, Stephen Boyd wrote: > > > > > > > > Quoting Dmitry Baryshko

Re: [PATCH v7 00/12] clk: Improve clock range handling

2022-03-11 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-25 06:35:22) > Hi, > > This is a follow-up of the discussion here: > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > and here: > https://lore.kernel.org/all/20210914093515.260031-1-max...@cerno.tech/ > > While the initial proposal imp

Re: [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe

2022-03-17 Thread Stephen Boyd
Quoting Vinod Polimera (2022-03-14 07:46:53) > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. Capitalize 'use'. Why is it important to use max frequency during probe/bind? Does not setting the clk rate during probe mean

Re: [PATCH v5 1/9] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:46) > Rename the edp_out label in the sc7280 platform to mdss_edp_out > so that the nodes related to mdss are all grouped together in > the board specific files. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:47) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index e2efbdd..2df654e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -7,6 +7,7 @@ >

Re: [PATCH v5 3/9] arm64: dts: qcom: sc7280: Enable backlight for eDP panel

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:48) > Enable backlight support for eDP panel on CRD platform for sc7280. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v5: > - Separate out backlight nodes > > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 18 ++ > 1 file

Re: [PATCH v5 4/9] drm/panel-edp: add LQ140M1JW46 edp panel entry

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:49) > Add panel identification entry for the sharp LQ140M1JW46 eDP panel > with power sequencing delay information. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 5/9] drm/msm/dp: Add eDP support via aux_bus

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:50) > This patch adds support for generic eDP sink through aux_bus. Please unindent commit text paragraphs. This isn't a book. > The eDP/DP controller driver should support aux transactions originating > from the panel-edp driver and hence sh

[PATCH] drm/msm/dsi: Use connector directly in msm_dsi_manager_connector_init()

2022-03-17 Thread Stephen Boyd
: Dmitry Baryshkov Cc: Sean Paul Fixes: 6d5e78406991 ("drm/msm/dsi: Move dsi panel init into modeset init path") Signed-off-by: Stephen Boyd --- I don't know if this is superseeded by something else but I found this while trying to use the connector from msm_dsi in this function.

Re: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:51) > The source device should ensure the sink is ready before > proceeding to read the sink capability or performing any aux transactions. > The sink will indicate its readiness by asserting the HPD line. > > The eDP sink requires powe

Re: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Stephen Boyd
Quoting Doug Anderson (2022-03-18 09:24:17) > Hi, > > On Thu, Mar 17, 2022 at 6:19 PM Stephen Boyd wrote: > > > > Quoting Sankeerth Billakanti (2022-03-16 10:35:51) > > > The source device should ensure the sink is ready before > > > proceeding to

Re: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Stephen Boyd
Quoting Doug Anderson (2022-03-18 14:58:55) > Hi, > > On Fri, Mar 18, 2022 at 1:17 PM Stephen Boyd wrote: > > > > > > > + ret = dp_catalog_aux_wait_for_hpd_connect_state(aux->catalog); > > > > > > > > Why are we making aux transacti

Re: [PATCH v7 06/12] clk: Always set the rate on clk_set_range_rate

2022-03-24 Thread Stephen Boyd
Quoting Maxime Ripard (2022-03-23 01:51:40) > Hi, > > > The whole point of this patch is to give an opportunity to every driver > to change the rate whenever the boundaries have changed, so we very much > want to have the option to change it if clk_set_rate() has never been > called. > > However

Re: [PATCH 1/3] drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()

2022-03-24 Thread Stephen Boyd
Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/3] drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 03:35:46) > Since the last commit, the max_pclk_khz became constant, it's set to > DP_MAX_PIXEL_CLK_KHZ and never changed afterwards. Remove it completely > and use DP_MAX_PIXEL_CLK_KHZ directly. > > Signed-off-by: Dmitry Baryshkov > --

Re: [PATCH 2/3] drm/msm/dp: simplify dp_connector_get_modes()

2022-03-24 Thread Stephen Boyd
by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example

2022-03-24 Thread Stephen Boyd
Rob Herring > Cc: Loic Poulain > Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 > DPU bindings") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 3/6] drm/msm: split the main platform driver

2022-03-24 Thread Stephen Boyd
gt; --- With the match table fixed and the nit below Reviewed-by: Stephen Boyd > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > index 3cf476c55158..c5c0650414c5 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > +++

Re: [PATCH v3 6/6] drm/msm: make mdp5/dpu devices master components

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 02:25:38) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 38627ccf3068..ab8a35e09bc9 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -381,8 +3

Re: [PATCH v4 6/6] drm/msm: make mdp5/dpu devices master components

2022-03-25 Thread Stephen Boyd
rv. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

RE: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (QUIC) (2022-03-25 06:30:58) > > > > > + vdda-1p2-supply = <&vreg_l6b_1p2>; > > > + vdda-0p9-supply = <&vreg_l10c_0p8>; > > > + > > > + aux-bus { > > > > Can this move to sc7280.dtsi and get a phandle? > > > > Okay, I will move this to sc7280.dtsi like

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-03-25 Thread Stephen Boyd
Quoting Daniel Latypov (2022-02-24 15:21:57) > On Thu, Feb 24, 2022 at 2:54 PM Stephen Boyd wrote: > > > > Quoting Daniel Latypov (2022-02-23 14:50:59) > > > On Wed, Feb 23, 2022 at 2:56 AM Maxime Ripard wrote: > > > > > > > > Let's test vario

Re: [PATCH v4 03/10] clk: Use clamp instead of open-coding our own

2022-02-18 Thread Stephen Boyd
Quoting Maxime Ripard (2022-01-25 06:15:42) > The code in clk_set_rate_range() will, if the current rate is outside of > the new range, will force it to the minimum or maximum. This is > equivalent to using clamp, while being less readable. Let's switch to > using clamp instead. > > Signed-off-by:

Re: [PATCH v4 02/10] clk: Always clamp the rounded rate

2022-02-18 Thread Stephen Boyd
Quoting Maxime Ripard (2022-01-25 06:15:41) > The current core while setting the min and max rate properly in the > clk_request structure will not make sure that the requested rate is > within these boundaries, leaving it to each and every driver to make > sure it is. It would be good to describe

Re: [RFC PATCH v2 2/5] drm/msm/dp: support attaching bridges to the DP encoder

2022-02-18 Thread Stephen Boyd
or with EDID lines for panel autodetect > - eDP encoder ⇒ ptn3460 ⇒ THC63LVD1024 ⇒ DPI panel. > - eDP encoder ⇒ LT8912 ⇒ DSI panel > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

2022-02-18 Thread Stephen Boyd
tached to the encoder. > > Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable > and disable") > Cc: Kuogee Hsieh > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd > drivers/gpu/drm/msm/dp/dp_drm.c | 21 +++

Re: [RFC PATCH v2 3/5] drm/msm/dp: support finding next bridge even for DP interfaces

2022-02-18 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-11 14:40:04) > It is possible to supply display-connector (bridge) to the DP interface, > add support for parsing it too. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-18 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-18 14:32:53) > On 19/02/2022 00:31, Kuogee Hsieh wrote: > > > > On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: > >> There is little point in having both connector and root bridge > >> implementation in the same driver. Move connector's functionality to the > >> brid

Re: [PATCH v4 01/10] clk: Introduce Kunit Tests for the framework

2022-02-18 Thread Stephen Boyd
Quoting Maxime Ripard (2022-01-25 06:15:40) > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > index 6a98291350b6..2664aaab8068 100644 > --- a/drivers/clk/Makefile > +++ b/drivers/clk/Makefile > @@ -2,6 +2,7 @@ > # common clock types > obj-$(CONFIG_HAVE_CLK) += clk-devres.o clk-

Re: [PATCH v4 05/10] clk: Add clk_drop_range

2022-02-18 Thread Stephen Boyd
Quoting Maxime Ripard (2022-01-25 06:15:44) > index 266e8de3cb51..f365dac7be17 100644 > --- a/include/linux/clk.h > +++ b/include/linux/clk.h > @@ -1005,6 +1005,17 @@ static inline struct clk *clk_get_optional(struct > device *dev, const char *id) > return clk; > } > > +/** > + * clk_dr

Re: [PATCH v4 0/10] clk: Improve clock range handling

2022-02-18 Thread Stephen Boyd
Quoting Laurent Pinchart (2022-02-14 01:45:56) > Hi Maxime and Stephen, > > We have recently posted a driver for the BCM2711 Unicam CSI-2 receiver > (see [1]) which is a perfect candidate for this API, as it needs a > minimum rate for the VPU clock. Any chance we can get this series merged > ? :-)

Re: [PATCH v4 00/10] clk: Improve clock range handling

2022-02-18 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-10 02:19:16) > Hi Stephen, > > On Tue, Jan 25, 2022 at 03:15:39PM +0100, Maxime Ripard wrote: > > Hi, > > > > This is a follow-up of the discussion here: > > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > > > and here: > > https://lo

Re: [PATCH v8 1/4] drm/msm/dpu: adjust display_v_end for eDP and DP

2022-02-18 Thread Stephen Boyd
plementation has > only display_h_end adjusted. > > Signed-off-by: Kuogee Hsieh > --- Is this not a problem for me because this is set already to something correct in the hardware? Reviewed-by: Stephen Boyd

Re: [PATCH v8 2/4] drm/msm/dpu: replace BIT(x) with correspond marco define string

2022-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 13:36:26) > To improve code readability, this patch replace BIT(x) with > correspond register bit define string > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v8 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 13:36:27) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 0d315b4..0c22839 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -217,6

Re: [PATCH v8 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 13:36:28) > Widebus feature will transmit two pixel data per pixel clock to interface. > This feature now is required to be enabled to easy migrant to higher s/migrant/migrate/? > resolution applications in future. However since some legacy chipsets s/in/in the/

Re: [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 05:12:06) > Panels with higher refresh rate will need mdp clk above 300Mhz. > Select max frequency for mdp clock during bootup, dpu driver will > scale down the clock as per usecase when first update from the framework is > received. > > Signed-off-by: Vinod Poli

Re: [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

2022-02-22 Thread Stephen Boyd
Quoting José Expósito (2022-02-20 23:33:39) > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Signed-off-by: José Expósito > --- Dmitry is rewriting this code in a larger series. This

Re: [PATCH v2 2/4] drm/bridge: use atomic enable/disable for bridge callbacks

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 06:51:24) > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index b32295a..5c7dc82 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -102,30 +136,82 @@ static void panel_bridge_detach(struct dr

Re: [PATCH v2 4/4] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 06:51:26) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index e7c9fe1..ba3240c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -951,6 +952,14 @@

Re: [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Stephen Boyd
Quoting Doug Anderson (2022-02-22 13:25:05) > Hi, > > On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote: > > > > Quoting Vinod Polimera (2022-02-21 05:12:06) > > > Panels with higher refresh rate will need mdp clk above 300Mhz. > > > Select max frequency

Re: [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-23 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-23 10:27:26) > > On 2/23/2022 10:22 AM, Dmitry Baryshkov wrote: > > On 23/02/2022 20:21, Kuogee Hsieh wrote: > > > > In the panel device node. > > > > Can you please share it too? > > > &soc { >     edp_power_supply: edp_power { >     compatible = "re

Re: [PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 10:35:30) > Since DRM_DEBUG_DP is deprecated in favor of drm_dbg_dp(NULL, ...), > this patch replace all DRM_DEBUG_DP with drm_dbg_dp(). > > Changes in v4: > -- replace (strucr drm_dev *)NULL with drm_dev > > Signed-off-by: Kuogee Hsieh > -

Re: [PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-24 10:20:31) > Hi Stephen, > > Are you still has concern on this patch? > No more concerns.

Re: [PATCH v4 01/10] clk: Introduce Kunit Tests for the framework

2022-02-24 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-21 07:12:59) > Hi Stephen, > > Thanks for your review > > On Fri, Feb 18, 2022 at 06:20:46PM -0800, Stephen Boyd wrote: > > It would also be good to add a test that tries to set the clk rate with > > clk_set_rate() after a range has b

Re: [PATCH v4 02/10] clk: Always clamp the rounded rate

2022-02-24 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-21 08:18:21) > Hi, > > On Fri, Feb 18, 2022 at 03:15:06PM -0800, Stephen Boyd wrote: > > Quoting Maxime Ripard (2022-01-25 06:15:41) > > > The current core while setting the min and max rate properly in the > > > clk_request stru

Re: [PATCH v4 02/10] clk: Always clamp the rounded rate

2022-02-24 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-21 08:43:23) > Hi again, > > On Mon, Feb 21, 2022 at 05:18:21PM +0100, Maxime Ripard wrote: > > On Fri, Feb 18, 2022 at 03:15:06PM -0800, Stephen Boyd wrote: > > > Quoting Maxime Ripard (2022-01-25 06:15:41) > > > > +/* > &g

Re: [PATCH v4 03/10] clk: Use clamp instead of open-coding our own

2022-02-24 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-21 08:30:01) > On Fri, Feb 18, 2022 at 02:34:20PM -0800, Stephen Boyd wrote: > > Quoting Maxime Ripard (2022-01-25 06:15:42) > > > The code in clk_set_rate_range() will, if the current rate is outside of > > > the new range, will force i

Re: [PATCH v6 05/12] clk: Use clamp instead of open-coding our own

2022-02-24 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-23 02:55:53) > The code in clk_set_rate_range() will, if the current rate is outside of > the new range, will force it to the minimum or maximum. s/will// > > Since it's running under the condition that the rate is either lower > than the minimum, or higher than th

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-02-24 Thread Stephen Boyd
Quoting Daniel Latypov (2022-02-23 14:50:59) > On Wed, Feb 23, 2022 at 2:56 AM Maxime Ripard wrote: > > > > Let's test various parts of the rate-related clock API with the kunit > > testing framework. > > > > Cc: kunit-...@googlegroups.com > > Suggested

Re: [PATCH v2 1/2] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-02-25 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-25 07:57:49) > Kernel clock driver assumes that initial rate is the > max rate for that clock and was not allowing it to scale > beyond the assigned clock value. > > drop the assigned clock rate property and set it > during resume sequence with max value in the opp t

Re: [PATCH v2 2/2] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table

2022-02-25 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-25 07:57:50) > use max clock during resume sequence from the opp table. s/use/Use/ > The clock will be scaled down when framework sends an update. > > Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add display dt nodes") Presumably this is the wrong fixes tag, see be

Re: [PATCH v10 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-25 Thread Stephen Boyd
N features check. > > Changes in v10: > -- add const inside dpu_encoder_is_widebus_enabled() > -- drop useless parenthesis please > > Signed-off-by: Kuogee Hsieh > Tested-by: Bjorn Andersson > Reviewed-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v10 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-22 16:27:40) > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c > b/drivers/gpu/drm/msm/dp/dp_catalog.c > index 6ae9b29..c789f4e 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.c > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c > @@ -483,6 +485,22 @@ int dp_catalog_ctrl_s

Re: [PATCH v11 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-25 12:45:57) > Widebus feature will transmit two pixel data per pixel clock to interface. > This feature now is required to be enabled to easy migrant to higher > resolution applications in future. However since some legacy chipsets > does not support this feature, thi

Re: [PATCH v12 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
add const to dp_catalog_hw_revision() > -- add const to msm_dp_wide_bus_available() > > Changes in v12: > -- dp_catalog_hw_revision(const struct dp_catalog *dp_catalog) > -- msm_dp_wide_bus_available(const struct msm_dp *dp_display) > > Signed-off-by: Kuogee Hsieh > Reported-by: kernel test robot > Tested-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-02-25 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-25 06:26:06) > Hi Stephen, > > On Thu, Feb 24, 2022 at 02:54:20PM -0800, Stephen Boyd wrote: > > Quoting Daniel Latypov (2022-02-23 14:50:59) > > > On Wed, Feb 23, 2022 at 2:56 AM Maxime Ripard wrote: > > > Incremental cove

Re: [PATCH 1/5] arm64: dts: qcom: msm8996: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/5] arm64: dts: qcom: sdm630: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/5] arm64: dts: qcom: sdm660: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

<    1   2   3   4   5   6   7   8   9   10   >