Re: [PATCH v2 4/5] drm/msm/dp: Store each subblock in the io region

2021-08-25 Thread Stephen Boyd
. > > Signed-off-by: Bjorn Andersson > --- One nit below: Reviewed-by: Stephen Boyd > > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h > b/drivers/gpu/drm/msm/dp/dp_parser.h > index dc62e70b1640..a95b05dbb11c 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.h > +

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-25 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-26 16:13:51) > eDP panels might need some power sequencing and backlight management, > so make it possible to associate a drm_panel with a DP instance and > prepare and enable the panel accordingly. > > Signed-off-by: Bjorn Andersson > --- > > This solves my immedi

Re: [PATCH v2 1/5] drm/msm/dp: Remove global g_dp_display variable

2021-08-25 Thread Stephen Boyd
gt; Replace this with a combination of existing references to adjacent > objects and drvdata. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 2/5] drm/msm/dp: Modify prototype of encoder based API

2021-08-26 Thread Stephen Boyd
orn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 16:42:31) > Based on the removal of the g_dp_display and the movement of the > priv->dp lookup into the DP code it's now possible to have multiple > DP instances. > > In line with the other controllers in the MSM driver, introduce a > per-compatible list of base

Re: [PATCH v2 5/5] drm/msm/dp: Add sc8180x DP controllers

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 16:42:33) > The sc8180x has 2 DP and 1 eDP controllers, add support for these to the > DP driver. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-26 09:57:18) > On Thu 26 Aug 00:13 PDT 2021, Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-08-25 16:42:31) > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c &g

Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 16:42:31) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 2c7de43f655a..4a6132c18e57 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -78,6 +78,8 @@ struct dp_d

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling

2021-03-13 Thread Stephen Boyd
heck for NULL in the enable case anyway so why not avoid the extra > call? > > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix

2021-03-13 Thread Stephen Boyd
Quoting Douglas Anderson (2021-03-04 15:52:00) > This patch is _only_ code motion to prepare for the patch > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if > refclk") and make it easier to understand. > > Signed-off-by: Douglas Anderson > --

Re: [PATCH 1/8] clk: Add range accessors

2021-03-16 Thread Stephen Boyd
Quoting Maxime Ripard (2021-03-03 00:45:27) > Hi Stephen, > > On Tue, Mar 02, 2021 at 03:18:58PM -0800, Stephen Boyd wrote: > > Quoting Maxime Ripard (2021-02-25 07:59:02) > > > Some devices might need to access the current available range of a clock > > > to d

Re: [PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2021-03-22 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-17 17:20:43) > Hi Stephen, > > Reviving a bit of an old thread, for a question. > > On Mon, Nov 02, 2020 at 10:11:43AM -0800, Stephen Boyd wrote: > > @@ -265,6 +267,23 @@ connector_to_ti_sn_bridge(struct drm_connector > >

Re: [PATCH] drm/msm/dp: Fixed couple of typos

2021-03-22 Thread Stephen Boyd
Quoting Bhaskar Chowdhury (2021-03-17 23:26:50) > s/modueles/modules/ two different places > > Signed-off-by: Bhaskar Chowdhury > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedeskt

Re: [RFC PATCH 01/11] dt-bindings: drm/bridge: ti-sn65dsi8: Make enable GPIO optional

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:18) > The SN65DSI86 EN pin can be hardwired to a high level, or connected to a > global reset signal, not controllable by the kernel. Make it optional in > those cases. > > Signed-off-by: Laurent Pinchart > --- Reviewe

Re: [RFC PATCH 02/11] drm/bridge: ti-sn65dsi86: Make enable GPIO optional

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:19) > The enable signal may not be controllable by the kernel. Make it > optional. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing

Re: [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove()

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:20) > The AUX adapter registered in probe() need to be unregistered in > remove(). Do so. > > Fixes: b814ec6d4535 ("drm/bridge: ti-sn65dsi86: Implement AUX channel") > Signed-off-by: Laurent Pinchart > --

Re: [RFC PATCH 04/11] drm/bridge: ti-sn65dsi86: Use bitmask to store valid rates

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:21) > The valid rates are stored in an array of 8 booleans. Replace it with a > bitmask to save space. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing

Re: [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:22) > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 1d1be791d5ba..c21a7f7d452b 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -418,8 +420,18 @@

Re: [RFC PATCH 06/11] drm/bridge: ti-sn65dsi86: Group code in sections

2021-03-23 Thread Stephen Boyd
more functions, to ensure that the code will stay readable. > > No functional change intended. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://list

Re: [RFC PATCH 07/11] drm/bridge: ti-sn65dsi86: Split connector creation to a function

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:24) > To prepare for making connector creation option, move connector creation > out of ti_sn_bridge_attach to a separate function. > > No functional change intended. > > Signed-off-by: Laurent Pinchart > --- Revi

Re: [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2021-03-23 Thread Stephen Boyd
() operation. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH 11/11] drm/bridge: ti-sn65dsi86: Support hotplug detection

2021-03-23 Thread Stephen Boyd
limited to the bridge operations, as the connector > operations are legacy and new users should use > DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 46 +++

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-22 17:00:23) > Hi Stephen, > > On Mon, Nov 02, 2020 at 05:15:24PM -0800, Stephen Boyd wrote: > > Quoting Sam Ravnborg (2020-11-01 09:37:41) > > > Hi Stephen. > > > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Ste

Re: [PATCH v2] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-03-18 13:05:44) > if GPU components have failed to bind, shutdown callback would fail with > the following backtrace. Add safeguard check to stop that oops from > happening and allow the board to reboot. [...] > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu

Re: [PATCH v2] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-24 Thread Stephen Boyd
Quoting Rob Clark (2021-03-24 20:09:37) > On Wed, Mar 24, 2021 at 6:49 PM Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2021-03-18 13:05:44) > > > if GPU components have failed to bind, shutdown callback would fail with > > > the following backtrace. Add

[PATCH] drm/msm: Set drvdata to NULL when msm_drm_init() fails

2021-03-25 Thread Stephen Boyd
ort for display platform_driver") Cc: Dmitry Baryshkov Cc: Fabio Estevam Cc: Krishna Manikandan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index a5c6b8c23336..19690

Re: [PATCH 1/3] drm/msm/dp: Fix indentation kbot warnings in DP driver

2021-03-25 Thread Stephen Boyd
rm/msm/dp/dp_power.c:203 dp_power_clk_enable() > warn: inconsistent indenting > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing

Re: [PATCH 2/3] drm/msm/dp: Fix incorrect NULL check kbot warnings in DP driver

2021-03-25 Thread Stephen Boyd
) > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/msm/dp: delete unnecessary debugfs error handling

2021-03-25 Thread Stephen Boyd
TR_ERR' > > Debugfs functions are not supposed to be checked in the normal > case so delete this code. Also it silences the above Smatch > warnings that we're checking for NULL when these functions only > return error pointers. > > Reported-by: kernel test robot &g

Re: [PATCH v4 3/4] drm/msm: add compatibles for sm8150/sm8250 display

2021-03-29 Thread Stephen Boyd
new compatible in the condition. > > Signed-off-by: Jonathan Marek > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 2/4] dt-bindings: msm/disp: add compatibles for sm8150/sm8250 display

2021-03-29 Thread Stephen Boyd
> Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd This will conflict with the yaml changes to this file that are also in flight. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 4/4] arm64: dts: qcom: sm8250: fix display nodes

2021-03-29 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-03-29 05:00:51) > From: Jonathan Marek > > - Use sm8250 compatibles instead of sdm845 compatibles > Does it need the " - " prefix? > Signed-off-by: Jonathan Marek > Signed-off-by: Dmitry Baryshkov >

Re: [PATCH v3 02/25] clk: mux: provide devm_clk_hw_register_mux()

2021-03-29 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-03-27 04:02:42) > Add devm_clk_hw_register_mux() - devres-managed version of > clk_hw_register_mux(). > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar > --- Acked-by: Stephen Boyd ___

Re: [PATCH v3 03/25] clk: divider: add devm_clk_hw_register_divider

2021-03-29 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-03-27 04:02:43) > Add devm_clk_hw_register_divider() - devres version of > clk_hw_register_divider(). > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar > --- Acked-by: Stephen Boyd ___

Re: [PATCH v3 12/25] drm/msm/dsi: use devm_clk_*register to registe DSI PHY clocks

2021-03-29 Thread Stephen Boyd
Subject should say register instead of registe Quoting Dmitry Baryshkov (2021-03-27 04:02:52) > Use devres-enabled version of clock registration functions. This lets us > remove dsi_pll destroy callbacks completely. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dsi/dsi.h

Re: [PATCH v3 13/25] drm/msm/dsi: use devm_of_clk_add_hw_provider

2021-03-29 Thread Stephen Boyd
Would make it devm_of_clk_add_hw_provider() in the subject Quoting Dmitry Baryshkov (2021-03-27 04:02:53) > Use devm_of_clk_add_hw_provider() to register provided clocks. This > allows dropping the remove function alltogether. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-b

Re: [PATCH v3 00/25] drm/msm/dsi: refactor MSM DSI PHY/PLL drivers

2021-03-29 Thread Stephen Boyd
since commit 627dc55c273dab308303a5217bd3e767d7083ddb: > > drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume > (2021-03-22 18:52:34 -0700) > > are available in the Git repository at: > > https://git.li

Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-03-29 Thread Stephen Boyd
Trimming Cc list way down, sorry if that's too much. Quoting Maxime Ripard (2021-02-19 04:00:30) > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, > which would be the new plane state in the global atomic sta

Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-03-30 Thread Stephen Boyd
Quoting Maxime Ripard (2021-03-30 08:35:27) > Hi Stephen, > > On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > > Trimming Cc list way down, sorry if that's too much. > > > > Quoting Maxime Ripard (2021-02-19 04:00:30) > > > Many drivers re

Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-14 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 09:44:24) > On 2021-01-11 11:55, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-07 12:30:24) > >> irq_hpd event can only be executed at connected state. Therefore > >> irq_hpd event should be postponed if it happened at co

Re: [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler

2021-01-14 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 09:48:25) > On 2021-01-11 11:54, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-07 12:30:25) > >> There is HPD unplug interrupts missed at scenario of an irq_hpd > >> followed by unplug interrupts with around 10 ms

Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-14 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 15:44:32) > On 2021-01-13 12:22, Stephen Boyd wrote: > > Quoting khs...@codeaurora.org (2021-01-13 09:44:24) > >> On 2021-01-11 11:55, Stephen Boyd wrote: > >> > Quoting Kuogee Hsieh (2021-01-07 12:30:24) > >> &

Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-14 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 09:44:24) > On 2021-01-11 11:55, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-07 12:30:24) > >> irq_hpd event can only be executed at connected state. Therefore > >> irq_hpd event should be postponed if it happened at co

Re: [PATCH v2 0/2] fix missing unplug interrupt problem

2021-01-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-01-13 10:59:58) > Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. > Therefore irq_hpd handler should not issues either aux or sw reset > to avoid following unplug interrupt be cleared accidentally. > > Kuogee Hsieh (2): > drm/msm/dp: return fail when bo

Re: [PATCH v2 0/2] fix missing unplug interrupt problem

2021-01-14 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 15:52:37) > On 2021-01-13 12:25, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-13 10:59:58) > >> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. > >> Therefore irq_hpd handler should not issues either au

Re: [PATCH] drm/panel-simple: Undo enable if HPD never asserts

2021-01-15 Thread Stephen Boyd
metimes doesn't assert. > Obviously that needs to be debugged, but this patch makes it so that > if I add a retry that I can make things work. > > Fixes: 48834e6084f1 ("drm/panel-simple: Support hpd-gpios for delaying > prepare()") > Signed-off-by: Do

Re: [PATCH v2 1/5] drm/panel-simple: Undo enable if HPD never asserts

2021-01-16 Thread Stephen Boyd
derson > --- Nice catch on the unprepared_time Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 4/5] dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1

2021-01-26 Thread Stephen Boyd
Quoting Douglas Anderson (2021-01-15 14:44:19) > Another simple eDP panel. > > Signed-off-by: Douglas Anderson > --- With subject fixed Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedeskt

[PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-01-26 Thread Stephen Boyd
layer updates") Cc: Krishna Manikandan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_kms.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h index d8151a89e163..4735251a394d 100644 --- a/drivers

Re: [PATCH v2 5/5] drm/panel-simple: Add N116BCA-EA1

2021-01-26 Thread Stephen Boyd
N116BCA-EA1, at least according to the datasheet. > > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-01-26 Thread Stephen Boyd
layer updates") Cc: Krishna Manikandan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_kms.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h index d8151a89e163..4735251a394d 100644 --- a/drivers

Re: [PATCH v2 2/5] drm/panel-simple: Don't wait longer for HPD than hpd_absent_delay

2021-01-26 Thread Stephen Boyd
ut. This is especially useful for dealing with panels > that periodically fail to power on and need to be retried. We can > detect the problem sooner. > > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd ___ dri-d

Re: [PATCH v2 3/5] drm/panel-simple: Retry if we timeout waiting for HPD

2021-01-26 Thread Stephen Boyd
ardware should be debugged), adding a few retries to the power on > routine doesn't seem insane. Even if this panel's problems are > attributed to the fact that it's pre-production and/or can be fixed, > retries clearly can help in some cases and really don't hurt. &g

[PATCHv2] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-01-28 Thread Stephen Boyd
layer updates") Cc: Krishna Manikandan Signed-off-by: Stephen Boyd --- Changes from v1: * Fixed typo in commit text drivers/gpu/drm/msm/msm_kms.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h index d

Re: [PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-03 Thread Stephen Boyd
Quoting Bernard Zhao (2021-02-02 04:32:03) > remove unneeded variable: "rc". > > Signed-off-by: Bernard Zhao > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.or

Re: [PATCH] drm/msm/dp/dp_ctrl: Remove unneeded semicolon

2021-02-04 Thread Stephen Boyd
Quoting Xu Wang (2021-01-29 01:44:16) > fix semicolon.cocci warnings: > drivers/gpu/drm/msm/dp/dp_ctrl.c:1161:2-3: Unneeded semicolon > > Signed-off-by: Xu Wang > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing

Re: [PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-02-04 Thread Stephen Boyd
Quoting Rob Clark (2021-02-03 09:29:09) > On Wed, Feb 3, 2021 at 2:10 AM Daniel Vetter wrote: > > > > On Tue, Feb 02, 2021 at 08:51:25AM -0800, Rob Clark wrote: > > > On Tue, Feb 2, 2021 at 7:46 AM Daniel Vetter wrote: > > > > > > > > On Mon, Jan

Re: [PATCH] drm/msm/dp: reset dp controller only at boot up and pm_resume

2021-02-05 Thread Stephen Boyd
after irq_hpd > handler") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-06 Thread Stephen Boyd
reedr...@lists.freedesktop.org Cc: Lee Jones Fixes: cc9014bf63a4 ("drm/msm/dp/dp_ctrl: Move 'tu' from the stack to the heap") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c

Re: [PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-08 Thread Stephen Boyd
Quoting Joe Perches (2021-02-06 21:06:54) > On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote: > > A missing semicolon here causes my external display to stop working. > > Indeed, missing the semicolon on the return statement leads to > > dp_panel_update_tu_timings() not

Re: [PATCH v2 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

2021-02-08 Thread Stephen Boyd
Quoting Jernej Skrabec (2021-02-08 04:17:48) > CLK_SET_RATE_PARENT flag is checked on parent clock instead of current > one. Fix that. > > Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when > allowed") > Reviewed-by: Chen-Yu Tsai > Tested-by: Andre Heider > Signed-off-by: Jer

Re: [PATCH v3 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

2021-02-10 Thread Stephen Boyd
Quoting Maxime Ripard (2021-02-10 02:29:04) > Hi Mike, Stephen, > > On Tue, Feb 09, 2021 at 06:58:56PM +0100, Jernej Skrabec wrote: > > CLK_SET_RATE_PARENT flag is checked on parent clock instead of current > > one. Fix that. > > > > Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rat

[PATCH] drm/msm/kms: Use nested locking for crtc lock instead of custom classes

2021-02-11 Thread Stephen Boyd
ishna Manikandan Suggested-by: Daniel Vetter Fixes: b3d91800d9ac ("drm/msm: Fix race condition in msm driver with async layer updates") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_atomic.c | 7 +-- drivers/gpu/drm/msm/msm_kms.h| 8 ++-- 2 files changed, 7 insertions(

Re: [PATCH v3 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

2021-02-11 Thread Stephen Boyd
Quoting Jernej Skrabec (2021-02-09 09:58:56) > CLK_SET_RATE_PARENT flag is checked on parent clock instead of current > one. Fix that. > > Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when > allowed") > Reviewed-by: Chen-Yu Tsai > Tested-by: Andre Heider > Signed-off-by: Jer

Re: [PATCH] drm/msm/dp: add support of HBR3 link rate

2021-02-17 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-02-17 08:58:42) > Add hbr3_hbr2 voltage and pre-emphasis swing table to support > HBR3 link rate > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_panel.c | 4 > drivers/phy/qualcomm/phy-qcom-qmp.c | 24 ++-- This spans to su

Re: [PATCH 2/2] drm/msm/dp: Drop limit link rate at HBR2

2021-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-02-17 15:09:57) > Drop limit link rate at HBR2 to support link rate > upto HBR3. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freede

Re: [PATCH 2/2] drm/msm/dp: Drop limit link rate at HBR2

2021-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-02-17 15:09:57) > Drop limit link rate at HBR2 to support link rate > upto HBR3. > > Signed-off-by: Kuogee Hsieh > --- Should also say Tested-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.

Re: [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-02-18 12:55:04) > Allow supported link rate to be limited to the value specified at > dtsi. If it is not specified, then link rate is derived from dpcd > directly. Below are examples, > link-rate = <162000> for max link rate limited at 1.62G > link-rate = <27> for max

Re: [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-19 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-02-19 08:39:38) > On 2021-02-18 15:02, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-02-18 12:55:04) > >> Allow supported link rate to be limited to the value specified at > >> dtsi. If it is not specified, then link rate is deri

[PATCH] drm/msm/dp: Restore aux retry tuning logic

2021-02-26 Thread Stephen Boyd
e reliable. Cc: Kuogee Hsieh Fixes: 9fc418430c65 ("drm/msm/dp: unplug interrupt missed after irq_hpd handler") Signed-off-by: Stephen Boyd --- Noticed by code inspection and based on bug reports where the aux channel stops working once the commit this is fixing is applied. drivers/gp

Re: [PATCH 1/8] clk: Add range accessors

2021-03-02 Thread Stephen Boyd
Quoting Maxime Ripard (2021-02-25 07:59:02) > Some devices might need to access the current available range of a clock > to discover their capabilities. Let's add those accessors. This needs more than two sentences to describe what's required. > > Signed-off-by: Maxime Ripard > --- > drivers/c

Re: [PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

2021-03-04 Thread Stephen Boyd
Maybe subject could be "Ignore debugfs failures, fix indentation, fix logical error"? Quoting Abhinav Kumar (2021-03-04 17:31:52) > Fix the warnings reported by kbot across MSM DP driver. Which warnings? Can you include them? Or at least list the three things that are being fixed in this patch?

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-05-03 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-05-03 12:23:31) > On 2021-04-29 20:11, Stephen Boyd wrote: > > Quoting khs...@codeaurora.org (2021-04-29 10:23:31) > >> On 2021-04-29 02:26, Stephen Boyd wrote: > >> > Quoting khs...@codeaurora.org (2021-04-28 10:38:11) > >&g

Re: [PATCH v4 1/4] drm/msm/dp: check sink_count before update is_connected status

2021-05-03 Thread Stephen Boyd
m/dp: reset dp controller only at boot up and > pm_resume") > Reported-by: Stephen Boyd > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_display.c | 15 --- > 1 file changed, 8

Re: [PATCH v4 2/4] drm/msm/dp: initialize audio_comp when audio starts

2021-05-03 Thread Stephen Boyd
> > Changes in v3: > -- restore dp_display_handle_plugged_change() at dp_hpd_unplug_handle(). > > Changes in v4: > -- none > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd Fixes: c703d5789590 ("drm/msm/

Re: [PATCH v4 4/4] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-05-03 Thread Stephen Boyd
V4: > -- split this patch as stand alone patch > > Signed-off-by: Kuogee Hsieh Can this patch come before the one previously? And then some fixes tag be added? Otherwise looks good to me. Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd ___ dr

Re: [PATCH v4 3/4] drm/msm/dp: check main link status before start aux read

2021-05-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-21 16:37:37) > Maybe when the cable is disconnected the DP phy should be shutdown and > some bit in the phy could effectively "cut off" the aux channel and then > NAKs would start coming through here in the DP controller I/O register > space. This patch have DP aux cha

[PATCH 0/3] drm/msm/dp: Simplify aux code

2021-05-07 Thread Stephen Boyd
e into the logs. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Stephen Boyd (3): drm/msm/dp: Simplify aux irq handling code drm/msm/dp: Shrink locking area of dp_aux_transfer() drm/msm/dp: Handle aux timeouts, nacks, defers drivers

[PATCH 2/3] drm/msm/dp: Shrink locking area of dp_aux_transfer()

2021-05-07 Thread Stephen Boyd
ra.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_aux.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c index 91188466cece..b49810396513 100644 --- a/drivers/gpu

[PATCH 1/3] drm/msm/dp: Simplify aux irq handling code

2021-05-07 Thread Stephen Boyd
vi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_aux.c | 22 -- drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +- drivers/gpu/drm/msm/dp/dp_catalog.h | 2 +- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/dr

[PATCH 3/3] drm/msm/dp: Handle aux timeouts, nacks, defers

2021-05-07 Thread Stephen Boyd
at the drm core can figure out that things are just not going well. The important thing is that we're now returning -ETIMEDOUT when the message times out and nacks for bad addresses. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-

Re: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-07 Thread Stephen Boyd
Quoting Zhen Lei (2021-05-07 19:42:54) > Fix to return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- > drivers

[PATCH] component: Move host device to end of device lists on binding

2021-05-08 Thread Stephen Boyd
;t need the suppliers to probe to succeed. Cc: "Rafael J. Wysocki" Cc: Daniel Vetter Cc: Russell King Cc: Rob Clark Cc: Signed-off-by: Stephen Boyd --- drivers/base/component.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/base/component.c b/drivers/

Re: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-08 Thread Stephen Boyd
Quoting Leizhen (ThunderTown) (2021-05-08 00:55:04) > > > On 2021/5/8 14:09, Stephen Boyd wrote: > > Quoting Zhen Lei (2021-05-07 19:42:54) > >> Fix to return a negative error code from the error handling case instead > >> of 0, as done elsewhere in this functi

Re: [PATCH v2 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-10 Thread Stephen Boyd
quot; to make > the code clearer. > > Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- Reviewed-by: Stephen Boyd

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-10 09:05:21) > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > The device lists are poorly ordered when the component device code is > > used. This is because component_master_add_with_match() returns 0 > > regardless of comp

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-10 11:26:40) > On Mon, May 10, 2021 at 7:52 PM Stephen Boyd wrote: > > The device list now has msm, i2c, bridge in that order. When we go to > > system wide shutdown the bridge is shutdown first, then the i2c bus, and > > then msm calls drm_a

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Rafael J. Wysocki (2021-05-11 03:52:06) > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > [cut] > > > > > > > > > > I will try it, but then I wonder about things like system wide > > > > suspend/resume too. The drm encoder ch

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-11 06:39:36) > On Tue, May 11, 2021 at 12:52 PM Rafael J. Wysocki wrote: > > > > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > > > [cut] > > > > > > > > > > > > > > I will try it, but

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Russell King - ARM Linux admin (2021-05-11 07:42:37) > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > Within the component device framework this usually isn't that bad > > because the real driver work is done at bind time via > > componen

[PATCH 0/7] component: Make into an aggregate bus

2021-05-19 Thread Stephen Boyd
Russell King Cc: Saravana Kannan [1] https://lore.kernel.org/r/20210508074118.1621729-1-swb...@chromium.org Stephen Boyd (7): component: Drop 'dev' argument to component_match_realloc() component: Rename 'dev' to 'parent' component: Introduce struct aggregate_devic

[PATCH 1/7] component: Drop 'dev' argument to component_match_realloc()

2021-05-19 Thread Stephen Boyd
This argument isn't used. Drop it. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/bas

[PATCH 4/7] component: Introduce the aggregate bus_type

2021-05-19 Thread Stephen Boyd
s to attach shutdown logic (and in the future runtime PM logic) to the aggregate driver so that it runs the hooks in the correct order. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/componen

[PATCH 5/7] component: Use dev.parent instead of adev->parent

2021-05-19 Thread Stephen Boyd
We left this in place to ease the code diff, but now we can remove it because the aggregate device parent pointer is the same. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/compon

[PATCH 6/7] component: Move struct aggregate_device out to header file

2021-05-19 Thread Stephen Boyd
This allows aggregate driver writers to use the device passed to their probe/remove/shutdown functions properly instead of treating it as an opaque pointer. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --

[PATCH 2/7] component: Rename 'dev' to 'parent'

2021-05-19 Thread Stephen Boyd
places that 'dev' is modified. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 89 +++- 1 file changed, 42 insertions(+), 47 deleti

[PATCH 7/7] drm/msm: Migrate to aggregate driver

2021-05-19 Thread Stephen Boyd
play pipeline is called before any of the component device driver shutdown hooks are called. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- As stated in the cover letter, this isn't perfect but it stil

[PATCH 3/7] component: Introduce struct aggregate_device

2021-05-19 Thread Stephen Boyd
Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 249 -- include/linux/component.h | 2 +- 2 files changed, 134 insertions(+), 117 deletio

Re: [PATCH 0/7] component: Make into an aggregate bus

2021-05-19 Thread Stephen Boyd
Quoting Saravana Kannan (2021-05-19 18:27:50) > On Wed, May 19, 2021 at 5:25 PM Stephen Boyd wrote: > > > > This series is from discussion we had on reordering the device lists for > > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put >

Re: [PATCH] drm/dp_mst: Fix return code on sideband message failure

2021-06-29 Thread Stephen Boyd
"sideband msg failed to send\n"); > - drm_dp_mst_dump_sideband_msg_tx(&p, txmsg); > + drm_printf(&p, "sideband msg failed to send\n"); > + drm_dp_mst_dump_sideband_msg_tx(&p, txmsg); > + } > return ret; > } > With the above fixed up Reviewed-by: Stephen Boyd

<    1   2   3   4   5   6   7   8   9   10   >