Re: [PATCH v3] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-20 Thread Stephen Boyd
Quoting maitreye (2021-07-20 15:39:30) > diff --git a/drivers/gpu/drm/msm/dp/dp_link.c > b/drivers/gpu/drm/msm/dp/dp_link.c > index be986da..316e8e6 100644 > --- a/drivers/gpu/drm/msm/dp/dp_link.c > +++ b/drivers/gpu/drm/msm/dp/dp_link.c > @@ -1036,43 +1036,46 @@ int dp_link_process_request(struct

Re: [v2 1/3] dt-bindings: msm/dsi: Add sc7280 7nm dsi phy

2021-07-21 Thread Stephen Boyd
Quoting Rajeev Nandan (2021-06-22 05:42:26) > The SC7280 SoC uses the 7nm (V4.1) DSI PHY driver. > > Signed-off-by: Rajeev Nandan > --- Reviewed-by: Stephen Boyd

Re: [v2 2/3] drm/msm/dsi: Add PHY configuration for SC7280

2021-07-21 Thread Stephen Boyd
Quoting Rajeev Nandan (2021-06-22 05:42:27) > The SC7280 SoC uses the 7nm (V4.1) DSI PHY driver with > different enable|disable regulator loads. > > Signed-off-by: Rajeev Nandan > Reviewed-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [v2 3/3] drm/msm/dsi: Add DSI support for SC7280

2021-07-21 Thread Stephen Boyd
Quoting Rajeev Nandan (2021-06-22 05:42:28) > Add support for v2.5.0 DSI block in the SC7280 SoC. > > Signed-off-by: Rajeev Nandan > Reviewed-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-07-22 Thread Stephen Boyd
is used for unplug event which is triggered when DP cable is > dis connected. > > Changes in V2: > -- add fixes statement > > Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd with sink_count = 0 > correctly") > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:02) > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index 27fb0f0..92cf331 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -1634,6 +1617,24 @@ void dp_ctrl_handle_sink_reques

Re: [PATCH v2 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

2021-07-22 Thread Stephen Boyd
interrupt to get lost. Therefore reset aux > controller only when link is in connection state when dp_aux_cmd_fifo_tx() > fail. This fixes Link Layer CTS cases 4.2.1.1 and 4.2.1.2. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:07) > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index 6a013b0..20951c8 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -1638,6 +1638,25 @@ static bool dp_ctrl_clock_recov

Re: [PATCH v2 6/7] drm/msm/dp: do not end dp link training until video is ready

2021-07-22 Thread Stephen Boyd
ement. This fixes Link Layer > CTS cases 4.3.2.1, 4.3.2.2, 4.3.2.3 and 4.3.2.4. > > Signed-off-by: Kuogee Hsieh > --- Any fixes tag? Reviewed-by: Stephen Boyd

Re: [PATCH v2 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:05) > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c > b/drivers/gpu/drm/msm/dp/dp_panel.c > index 88196f7..0fdb551 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -303,7 +303,12 @@ void dp_panel_handle_sink_req

Re: [PATCH v2 4/7] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:04) > Remove special handling of replug interrupt and instead treat replug event > as a sequential unplug followed by a plugin event. This is needed to meet > the requirements of DP Link Layer CTS test case 4.2.1.3. > > Changes in V2: > -- add fixes statement

Re: [PATCH 1/5] dt-bindings: msm/dp: Change reg definition

2021-07-22 Thread Stephen Boyd
s are specified instead. > It is expected that the implementation will handle existing DTBs, even > though the schema defines the new layout. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/5] drm/msm/dp: Use devres for ioremap()

2021-07-22 Thread Stephen Boyd
Bjorn Andersson > --- Reviewed-by: Stephen Boyd > drivers/gpu/drm/msm/dp/dp_parser.c | 29 - > 1 file changed, 4 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c > b/drivers/gpu/drm/msm/dp/dp_parser.c > index 0519dd3ac3c3.

Re: [PATCH 3/5] drm/msm/dp: Refactor ioremap wrapper

2021-07-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-21 19:42:25) > In order to deal with multiple memory ranges in the following commit > change the ioremap wrapper to not poke directly into the dss_io_data > struct. > > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/dp/dp_parser.c | 28 ++--

Re: [PATCH 4/5] drm/msm/dp: Store each subblock in the io region

2021-07-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-21 19:42:26) > Not all platforms has DP_P0 at offset 0x1000 from the beginning of the > DP block. So dss_io_data into representing each of the sub-regions, to "So dss_io_data into" doesn't make sense to me. Is some word or words missing? > make it possible in the

Re: [PATCH 5/5] drm/msm/dp: Allow sub-regions to be specified in DT

2021-07-22 Thread Stephen Boyd
r to support existing DT. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dp: Initialize the INTF_CONFIG register

2021-07-22 Thread Stephen Boyd
m/msm/dp: add displayPort driver support") > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 1/2] drm/msm/dsi: update dsi register header file for tpg

2021-07-22 Thread Stephen Boyd
Quoting Abhinav Kumar (2021-07-21 19:50:31) > Update the DSI controller header XML file to add registers > and bitfields to support rectangular checkered pattern > generator. > > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 2/2] drm/msm/dsi: add support for dsi test pattern generator

2021-07-22 Thread Stephen Boyd
r validation on dual DSI and command mode panel is pending. > If there are any fix ups needed for those, it shall be applied on top > of this change. > > Changes in v2: > - generate the new dsi.xml.h and update the bitfield names > > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-22 Thread Stephen Boyd
Quoting maitreye (2021-07-21 16:19:40) > From: Maitreyee Rao > > Add trace points across the MSM DP driver to help debug > interop issues. > > Changes in v4: > - Changed goto statement and used if else-if I think drm likes to see all the changelog here to see patch evolution. > > Signed-off-by:

Re: [PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-22 Thread Stephen Boyd
Quoting maitr...@codeaurora.org (2021-07-22 14:33:43) > Thank you Stephen. > > On 2021-07-22 13:31, Stephen Boyd wrote: > > Quoting maitreye (2021-07-21 16:19:40) > >> From: Maitreyee Rao > >> > >> Add trace points across the MSM DP driver to help debug

Re: [PATCH] drm/msm/dp: signal audio plugged change at dp_pm_resume

2021-07-22 Thread Stephen Boyd
dp_pm_resume() so that audio option will be in > correct state after system resumed. > > Fixes: bd52cfedb5a8 ("drm/msm/dp: power off DP phy at suspend") This should be Fixes: f591dbb5fb8c ("drm/msm/dp: power off DP phy at suspend") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-23 Thread Stephen Boyd
Quoting maitr...@codeaurora.org (2021-07-22 20:53:37) > On 2021-07-22 15:09, Stephen Boyd wrote: > Thank you for the comments . > > Quoting maitr...@codeaurora.org (2021-07-22 14:33:43) > >> Thank you Stephen. > >> > >> On 2021-07-22 13:31, Stephen Boyd wro

Re: [PATCH] arm64: dts: qcom: sc7280: Add gpu support

2021-07-23 Thread Stephen Boyd
Quoting Akhil P Oommen (2021-07-23 04:20:54) > Add the necessary dt nodes for gpu support in sc7280. > > Signed-off-by: Akhil P Oommen > --- > This patch has dependency on the GPUCC bindings patch here: > https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-t..

Re: [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread Stephen Boyd
> - Changed if else if statement, >to not overwrite the ret variable multiple times. > > Signed-off-by: Maitreyee Rao > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm/dp: signal audio plugged change at dp_pm_resume

2021-07-26 Thread Stephen Boyd
dp_pm_resume() so that audio option will be in > correct state after system resumed. > > Changes in V2: > -- correct Fixes tag commit id. > > Fixes: f591dbb5fb8c ("drm/msm/dp: power off DP phy at suspend") > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd

Re: [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread Stephen Boyd
Quoting maitreye (2021-07-26 10:36:26) > @@ -509,6 +515,7 @@ static int dp_display_usbpd_attention_cb(struct device > *dev) > DRM_ERROR("invalid dev\n"); > return -EINVAL; > } > + DRM_DEBUG_DP("sink_request: %d\n", sink_request); This one is bad. sink

Re: [PATCH v2] drm/msm/dp: signal audio plugged change at dp_pm_resume

2021-07-26 Thread Stephen Boyd
dp_pm_resume() so that audio option will be in > correct state after system resumed. > > Changes in V2: > -- correct Fixes tag commit id. > > Fixes: f591dbb5fb8c ("drm/msm/dp: power off DP phy at suspend") > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd

Re: [PATCH 1/5] drm/msm/dp: Remove global g_dp_display variable

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:31) > As the Qualcomm DisplayPort driver only supports a single instance of > the driver the commonly used struct dp_display is kept in a global > variable. As we introduce additional instances this obviously doesn't > work. > > Replace this with a combinat

Re: [PATCH 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:33) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 59ffd6c8f41f..92b7646a1bb7 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -238,8 +251,11 @@ static i

Re: [PATCH 4/5] dt-bindings: msm/dp: Add SC8180x compatibles

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:35) > The Qualcomm SC8180x has 2 DP controllers and 1 eDP controller, add > compatibles for these to the msm/dp binding. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH 5/5] drm/msm/dp: Add sc8180x DP controllers

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:36) > The sc8180x has 2 DP and 1 eDP controllers, add support for these to the > DP driver. > > Link: > https://lore.kernel.org/linux-arm-msm/20210511042043.592802-5-bjorn.anders...@linaro.org/ > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm

Re: [PATCH 2/5] drm/msm/dp: Modify prototype of encoder based API

2021-07-26 Thread Stephen Boyd
ruct msm_dp the > operation relates to. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-26 Thread Stephen Boyd
Quoting Akhil P Oommen (2021-07-24 10:29:00) > Add the necessary dt nodes for gpu support in sc7280. > > Signed-off-by: Akhil P Oommen > --- > This patch has dependency on the GPUCC bindings patch here: > https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-t..

Re: [PATCH v6] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-27 Thread Stephen Boyd
> - Changed if else if statement, >to not overwrite the ret variable multiple times. > Changes in v6: > - Changed a wrong log message. > Signed-off-by: Maitreyee Rao > --- Reviewed-by: Stephen Boyd It may also be good to add some logging into the dp_pm_resume() and d

Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-29 Thread Stephen Boyd
Quoting Akhil P Oommen (2021-07-28 00:17:45) > On 7/27/2021 5:46 AM, Stephen Boyd wrote: > > Quoting Akhil P Oommen (2021-07-24 10:29:00) > >> Add the necessary dt nodes for gpu support in sc7280. > >> > >> Signed-off-by: Akhil P Oommen > >> --

Re: [PATCH v3 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-29 Thread Stephen Boyd
Quoting Akhil P Oommen (2021-07-28 04:54:01) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 029723a..c88f366 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -592,6 +593,85 @@ >

Re: [PATCH v3 2/2] arm64: dts: qcom: sc7280: Add gpu thermal zone cooling support

2021-07-29 Thread Stephen Boyd
ff-by: Akhil P Oommen > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-29 Thread Stephen Boyd
Quoting Rob Clark (2021-07-29 10:35:32) > On Thu, Jul 29, 2021 at 10:19 AM Stephen Boyd wrote: > > > > > > Why is 45000 after 55000? Is it on purpose? If not intended > > please sort by frequency. > > We've used descending order, at least for gpu

Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-29 Thread Stephen Boyd
Quoting Akhil P Oommen (2021-07-29 11:57:23) > On 7/29/2021 10:46 PM, Stephen Boyd wrote: > > Quoting Akhil P Oommen (2021-07-28 00:17:45) > >> On 7/27/2021 5:46 AM, Stephen Boyd wrote: > >>> Quoting Akhil P Oommen (2021-07-24 10:29:00) > >>>> Add the

Re: [PATCH] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-07-30 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-28 14:30:54) > Currently at dp_pm_resume() is_connected state is decided base on hpd > connection > status only. This will put is_connected in wrongly "true" state at the > scenario > that dongle attached to DUT but without hmdi cable connecting to it. Fix this > pro

Re: [PATCH v2] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-08-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-02 13:20:55) > Currently at dp_pm_resume() is_connected state is decided base on hpd > connection > status only. This will put is_connected in wrongly "true" state at the > scenario > that dongle attached to DUT but without hmdi cable connecting to it. Fix this > pro

Re: [PATCH v3] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-08-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-03 09:25:13) > Currently at dp_pm_resume() is_connected state is decided base on hpd > connection > status only. This will put is_connected in wrongly "true" state at the > scenario > that dongle attached to DUT but without hmdi cable connecting to it. Fix this > pro

Re: [v2] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-08-03 Thread Stephen Boyd
Quoting Kalyan Thota (2021-08-03 03:41:47) > Add safe lut configuration for all the targets in dpu > driver as per QOS recommendation. > > Issue reported on SC7280: > > With wait-for-safe feature in smmu enabled, RT client > buffer levels are checked to be safe before smmu invalidation. > Since dis

Re: [PATCH] drm/msm: remove unneeded variable ret

2021-04-07 Thread Stephen Boyd
Quoting Bernard Zhao (2021-04-07 06:06:21) > This patch fix coccicheck warning: > drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return > "0" on line 880 > Also remove unneeded function return value check. > > Signed-off-by: Bernard

Re: [PATCH] clk: fixed: fix double free in resource managed fixed-factor clock

2021-04-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-04-06 16:06:06) > devm_clk_hw_register_fixed_factor_release(), the release function for > the devm_clk_hw_register_fixed_factor(), calls > clk_hw_unregister_fixed_factor(), which will kfree() the clock. However > after that the devres functions will also kfree the all

Re: [PATCH] clk: fixed: fix double free in resource managed fixed-factor clock

2021-04-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-04-06 16:06:06) > devm_clk_hw_register_fixed_factor_release(), the release function for > the devm_clk_hw_register_fixed_factor(), calls > clk_hw_unregister_fixed_factor(), which will kfree() the clock. However > after that the devres functions will also kfree the all

Re: [PATCH] clk: fixed: fix double free in resource managed fixed-factor clock

2021-04-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-04-07 15:57:01) > On Thu, 8 Apr 2021 at 01:41, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2021-04-06 16:06:06) > > > devm_clk_hw_register_fixed_factor_release(), the release function for > > > the devm_clk_

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-10 Thread Stephen Boyd
asmus Villemoes > Signed-off-by: Andrew Morton > --- > drivers/clk/analogbits/wrpll-cln28hpc.c | 4 + Acked-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/msm/dp: check sink_count before update is_connected status

2021-04-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-12 10:02:51) > At pm_resume check link sisnk_count before update is_connected status s/sisnk_count/sink_count/ > base on HPD real time link status. Also print out error message only > when either EV_CONNECT_PENDING_TIMEOUT or EV_DISCONNECT_PENDING_TIMEOUT > happen.

Re: [PATCH 1/2] drm/msm/dp: check sink_count before update is_connected status

2021-04-12 Thread Stephen Boyd
ned-off-by: Kuogee Hsieh > --- Also please include Reported-by: Stephen Boyd in the next post. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/msm/dp: do not re initialize of audio_comp

2021-04-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-12 10:03:23) > At dp_display_disable(), do not re initialize audio_comp if > hdp_state == ST_DISCONNECT_PENDING (unplug event) to avoid > race condition which cause 5 second timeout expired. More details please. > Also > add abort mechanism to reduce time spinning at

Re: [PATCH v2 1/3] drm/msm/dp: check sink_count before update is_connected status

2021-04-13 Thread Stephen Boyd
only at boot up and > pm_resume") > Reported-by: Stephen Boyd > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/3] drm/msm/dp: do not re initialize of audio_comp at display_disable()

2021-04-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-13 16:11:30) > At dongle unplug, dp initializes audio_comp followed by sending disconnect > event notification to audio and to make sure audio had shutdown completely > by wait for audio completion notification at display_disable(). This patch Is this dp_display_disab

Re: [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-13 16:11:44) > Make sure main link is in connection state before start aux > read/write operation to avoid unnecessary long delay due to > main link had been unplugged. > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_aux.c | 5 + > drivers/gp

Re: [PATCH v2 1/3] drm/msm/dp: check sink_count before update is_connected status

2021-04-14 Thread Stephen Boyd
only at boot up and > pm_resume") > Reported-by: Stephen Boyd > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd > Signed-off-by: Kuogee Hsieh > --- Can you please thread your emailed patches? I see them all as toplevel messages in my inbox :( > drivers/gpu/drm/msm

Re: [PATCH v2 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-14 14:02:50) > Initialize audio_comp when audio starts and wait for audio_comp at > dp_display_disable(). This will take care of both dongle unplugged > and display off (suspend) cases. > > Changes in v2: > -- add dp_display_start_audio() > > Signed-off-by: Kuogee Hs

Re: [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-15 10:37:29) > On 2021-04-14 14:09, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-04-13 16:11:44) > >> Make sure main link is in connection state before start aux > >> read/write operation to avoid unnecessary long delay due

Re: [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-15 15:02:40) > On 2021-04-15 13:06, Stephen Boyd wrote: > > > > Is it really necessary to have this patch at all? I think there are > > bigger problems with suspend/resume of the DP driver in relation to the > > kthread stopping.

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-20 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-16 13:27:57) > Some dongle may generate more than one irq_hpd events in a short period of > time. This patch will treat those irq_hpd events as single one and service > only one irq_hpd event. Why is it bad to get multiple irq_hpd events in a short period of time? Ple

Re: [PATCH v3 3/3] drm/msm/dp: check main link status before start aux read

2021-04-20 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-16 10:38:51) > Maybe when the cable is disconnected the DP phy should be shutdown and > some bit in the phy could effectively "cut off" the aux channel and then > NAKs would start coming through here in the DP controller I/O register > space. This patch have DP aux cha

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-27 Thread Stephen Boyd
Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) > On 2021-04-21 10:26, khs...@codeaurora.org wrote: > >> > >>> + > >>> mutex_unlock(&dp->event_mutex); > >>> > >>> return 0; > >>> @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp, > >>> struct drm_encoder *enco

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-29 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-28 10:38:11) > On 2021-04-27 17:00, Stephen Boyd wrote: > > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) > >> On 2021-04-21 10:26, khs...@codeaurora.org wrote: > >> >> > >> >>&g

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-29 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-29 10:23:31) > On 2021-04-29 02:26, Stephen Boyd wrote: > > Quoting khs...@codeaurora.org (2021-04-28 10:38:11) > >> On 2021-04-27 17:00, Stephen Boyd wrote: > >> > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) &g

Re: [PATCH] drm/msm/dpu: Delete bonkers code

2021-04-30 Thread Stephen Boyd
80/0xa0 >[ 20.950058] el0_svc+0x20/0x30 >[ 20.953145] el0_sync_handler+0x88/0xb0 >[ 20.957014] el0_sync+0x13c/0x140 > > The reason for the codepath seems dubious, the atomic suspend/resume > heplers should handle the power-collapse case. If not, the CRTC's

[PATCH 0/6] drm/msm: Trim down drm debugging logs

2021-04-30 Thread Stephen Boyd
that felt appropriate. Please review. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Stephen Boyd (6): drm/msm: Move vblank debug prints to drm_dbg_vbl() drm/msm: Use VERB() for extra verbose logging drm/msm/dp: Drop malformed debug

[PATCH 3/6] drm/msm/dp: Drop malformed debug print

2021-04-30 Thread Stephen Boyd
This print is missing a newline, and doesn't really provide any value. Drop it. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 2/6] drm/msm: Use VERB() for extra verbose logging

2021-04-30 Thread Stephen Boyd
cally useless. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 16 2 files changed, 9 insertions(

[PATCH 4/6] drm/msm: Move FB debug prints to drm_dbg_state()

2021-04-30 Thread Stephen Boyd
g Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_fb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index d42f0665359a..90514d3179bb 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/

[PATCH 5/6] drm/msm/disp: Use plane debug print helper

2021-04-30 Thread Stephen Boyd
Use the DPU_DEBUG_PLANE() helper to print the plane number instead of open coding it. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 +++-- 1 file

[PATCH 1/6] drm/msm: Move vblank debug prints to drm_dbg_vbl()

2021-04-30 Thread Stephen Boyd
Put these debug prints in the vblank code into the appropriate vblank category via drm_dbg_vbl(). Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2

[PATCH 6/6] drm/msm/disp: Move various debug logs to atomic bucket

2021-04-30 Thread Stephen Boyd
Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 22 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 38 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++--- drivers/gpu/drm/msm/disp/dpu1/dpu_format

Re: [PATCH 0/2] clk: Implement a clock request API

2021-04-30 Thread Stephen Boyd
Quoting Maxime Ripard (2021-04-13 03:13:18) > Hi, > > This is a follow-up of the discussion here: > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > This implements a mechanism to raise and lower clock rates based on consumer > workloads, with an example of such an i

Re: [PATCH v3] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-08-04 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-08-04 08:48:04) > On 2021-08-03 12:05, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-08-03 09:25:13) > >> @@ -1327,14 +1327,26 @@ static int dp_pm_resume(struct device *dev) > >> > >> dp_catalog_ctrl_hpd_config(dp

Re: [PATCH v4] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-08-04 Thread Stephen Boyd
t; -- delete status local variable from dp_pm_resume() > > Changes in v4: > -- delete un necessary comment at dp_pm_resume() > > Fixes: d9aa6571b28ba ("drm/msm/dp: check sink_count before update > is_connected status") > Signed-off-by: Kuogee Hsieh > --- Tested-by: Stephen Boyd Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-09 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-09 14:58:57) > Add drm debug logs to dp_pm_resume and dp_pm_suspend to help > debug suspend/resume issues. > > Fixes: 355ab7428f09 ("drm/msm/dp: add debug logs to dp_pm_resume/suspend") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-09 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-09 14:58:57) > Add drm debug logs to dp_pm_resume and dp_pm_suspend to help > debug suspend/resume issues. > > Fixes: 355ab7428f09 ("drm/msm/dp: add debug logs to dp_pm_resume/suspend") BTW, I have no idea what commit this is. Best to probably just drop it?

Re: [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-10 08:29:22) > Changes in V2: > -- correct Fixes text > -- drop commit text > > Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease of > debugging") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-10 08:29:22) > Changes in V2: > -- correct Fixes text > -- drop commit text > > Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease of > debugging") > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_display.c | 13 + > 1 fi

Re: [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-08-10 12:18:02) > On 2021-08-10 11:33, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-08-10 08:29:22) > >> Changes in V2: > >> -- correct Fixes text > >> -- drop commit text > >> > >> Fixes: 601f047

Re: [PATCH v3 2/6] drm/msm/dp: reduce link rate if failed at link training 1

2021-08-10 Thread Stephen Boyd
V3: > -- return failed if lane_count <= 1 > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 4/6] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-08-10 Thread Stephen Boyd
dd fixes statement > > Changes in V3: > -- delete EV_HPD_REPLUG_INT > > Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd with sink_count = 0 > correctly") > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 5/6] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-05 13:44:54) > Response with correct edid checksum saved at connector after corrupted edid > checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 6/6] drm/msm/dp: do not end dp link training until video is ready

2021-08-10 Thread Stephen Boyd
itted to sink > properly. This fixes Link Layer CTS cases 4.3.2.1, 4.3.2.2, 4.3.2.3 > and 4.3.2.4. > > Changes in v3: > -- merge retrain link if loss of symbol locked happen into this patch > -- replace dp_ctrl_loss_symbol_lock() with dp_ctrl_channel_eq_ok() > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 0/6] add fixes to pass DP Link Layer compliance test cases

2021-08-10 Thread Stephen Boyd
s ready I'm still able to use my Apple dongle with these patches so Tested-by: Stephen Boyd

Re: [PATCH v2 4/6] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-08-10 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-06-23 17:03:02) > To simplify interfacing with the panel, wrap it in a panel-bridge and > let the DRM bridge helpers handle chaining of operations. > > This also prepares for support of DRM_BRIDGE_ATTACH_NO_CONNECTOR, which > requires all components in the display pip

Re: [PATCH v5 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-08-11 Thread Stephen Boyd
Quoting Akhil P Oommen (2021-08-11 07:23:54) > Add the necessary dt nodes for gpu support in sc7280. > > Signed-off-by: Akhil P Oommen > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 4/6] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-08-11 Thread Stephen Boyd
Quoting Rob Clark (2021-08-11 09:20:30) > On Wed, Aug 11, 2021 at 5:15 AM Laurent Pinchart > wrote: > > > > Hi Stephen, > > > > On Tue, Aug 10, 2021 at 10:26:33PM -0700, Stephen Boyd wrote: > > > Quoting Laurent Pinchart (2021-06-23 17:03:02) > > >

Re: [PATCH v2 4/6] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-08-11 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-08-11 15:40:24) > On Wed, Aug 11, 2021 at 01:51:28PM -0700, Rob Clark wrote: > > > > I kinda think *all* bridges that create a connector (whether optional > > or not) should OR in NO_CONNECTOR when attaching the next downstream > > bridge.. since you never want multip

Re: [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors

2021-08-11 Thread Stephen Boyd
(and we > supported that mode) this would change nothing. > > Fixes: 4e5763f03e10 ("drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge") > Signed-off-by: Rob Clark > --- Thanks for saving me the packaging effort. Reported-by: Stephen Boyd Tested-by: Stephen Boyd

Re: [PATCH v1 2/2] dt-bindings: Add SC7280 compatible string

2021-08-11 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-08-11 17:08:02) > The Qualcomm SC7280 platform supports an eDP controller, add > compatible string for it to msm/binding. > > Signed-off-by: Sankeerth Billakanti > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1 file changed,

Re: [PATCH v1 1/2] drm/msm/dp: Add support for SC7280 eDP

2021-08-11 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-08-11 17:08:01) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index b131fd37..1096c44 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_c

Re: [PATCH v1 1/4] dt-bindings: msm: add DT bindings for sc7280

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:01) > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml > b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml > new file mode 100644 > index 000..3d256c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/

Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:02) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 53a21d0..fd7ff1c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -5,6 +5,7 @@ > * Copyright

Re: [PATCH v1 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:03) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index fd7ff1c..aadf55d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -1507,6 +1519,95 @@ >

Re: [PATCH v1 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:04) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index aadf55d..5be318e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -1412,7 +1412,7 @@ >

Re: [PATCH v1 1/4] dt-bindings: msm: add DT bindings for sc7280

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:01) > MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI, EDP etc. Add required DPU > device tree bindings for SC7280. > > Signed-off-by: Krishna Manikandan > --- Please send a cover-letter next time. Do you

Re: [PATCH v2] drm/bridge: parade-ps8640: Reorg the macros

2021-08-25 Thread Stephen Boyd
the number of mipi data lanes. > > Signed-off-by: Philip Chen > --- Reviewed-by: Stephen Boyd

Re: [PATCH v1 2/2] dt-bindings: Add SC7280 compatible string

2021-08-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-08-11 17:08:02) > The Qualcomm SC7280 platform supports an eDP controller, add > compatible string for it to msm/binding. > > Signed-off-by: Sankeerth Billakanti > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1 file changed,

Re: [PATCH v2 3/5] drm/msm/dp: Refactor ioremap wrapper

2021-08-25 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 15:25:55) > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c > b/drivers/gpu/drm/msm/dp/dp_parser.c > index c064ced78278..215065336268 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.c > +++ b/drivers/gpu/drm/msm/dp/dp_parser.c > @@ -19,40 +19,30 @@ static const

  1   2   3   4   5   6   7   8   9   10   >