[PATCH] drm/radeon: Use correct value for unknown audio/video latency

2014-07-13 Thread Stefan Brüns
Valid values are 1 to 251 for 0 to 500 ms latency, 0 for unknown and 255 for audio/video unsupported by sink, according to HDMI 1.3 spec. Also matches Radeon HDA verb 0xf7b documentation. Signed-off-by: Stefan Br?ns --- drivers/gpu/drm/radeon/dce6_afmt.c | 4 ++-- 1 file changed, 2 insertions(+)

[PATCH] drm/radeon: Fix manufacturer/product ID and monitor name in ELD data

2014-07-13 Thread Stefan Brüns
Low/high bytes were for manufacturer and product ID were swapped. Monitor name in ELD data is not zero terminated, use length field from ELD data and initialize remaining bytes to 0. Signed-off-by: Stefan Br?ns --- drivers/gpu/drm/radeon/dce6_afmt.c | 10 ++ 1 file changed, 6 insertions(

[PATCH] drm/radeon/audio: break out of loops once we match connector

2014-07-13 Thread Stefan Brüns
No need to continue with the loops once we've matched the appropriate connector. See commit 8a992ee14551eae53fd3ab6c2dc8e06ba6fff174 Signed-off-by: Stefan Br?ns --- drivers/gpu/drm/radeon/dce6_afmt.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rade

[PATCH 2/2] drm/edid: Tighten checksum conditions for CEA blocks

2014-11-16 Thread Stefan Brüns
4a638b4e38234233f5c7e6705662fbc0b58d80c2 disabled the checksumming for CEA blocks. If only the checksum is wrong, reading twice should result in identical data, whereas a bad transfer will most likely corrupt diffent bytes. Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 25 +++

[PATCH] drm/edid: Check for empty block prior to checksumming

2014-11-16 Thread Stefan Brüns
drm_edid_block_valid will dump the whole EDID block. Shorten the log output to a single line stating the block is empty. Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/driver

[PATCH 1/2] drm/edid: new drm_edid_block_checksum helper function

2014-11-16 Thread Stefan Brüns
Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0755d01..505960e 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -1184,6 +1184,17

[PATCH] drm/edid: shorten log output in case of all zeroes edid block

2014-11-20 Thread Stefan Brüns
There is no need to dump the whole EDID block in case it contains no information. Just print a single line stating the block is empty instead of 8 lines containing only zeroes. Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(

[PATCH 1/3] drm/edid: new drm_edid_block_checksum helper function

2014-11-20 Thread Stefan Brüns
The function will also be used by a later patch, so factor it out. Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ec4f91f..b072041 100644

[PATCH 2/3] drm/edid: calculate address of current extension block only once

2014-11-20 Thread Stefan Brüns
Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b072041..3a10f3f 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -1232,1

[PATCH 3/3] drm/edid: Tighten checksum conditions for CEA blocks

2014-11-20 Thread Stefan Brüns
Checksumming was disabled for CEA blocks by commit 4a638b4e38234233f5c7e6705662fbc0b58d80c2 Author: Adam Jackson Date: Tue May 25 16:33:09 2010 -0400 drm/edid: Allow non-fatal checksum errors in CEA blocks If only the checksum is wrong, reading twice should result in identical data, where

[PATCH] drm/i915: reduce memory footprint for debugging

2014-09-23 Thread Stefan Brüns
see df8fbc231b7e4a78dae2b02e116fe73e4ea63cb0 Signed-off-by: Stefan Br?ns --- drivers/gpu/drm/i915/intel_dp.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index fdff1d4..dafb169 100644 --- a/drivers/gp

[PATCH v1] drm/i915: Try EDID bitbanging on HDMI after failed read

2017-12-24 Thread Stefan Brüns
the center. Fallback to bitbanging is already done for the CRT connector. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92685 Signed-off-by: Stefan Brüns --- drivers/gpu/drm/i915/intel_hdmi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2] drm/i915: Try EDID bitbanging on HDMI after failed read

2017-12-31 Thread Stefan Brüns
the center. Fallback to bitbanging is already done for the CRT connector. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92685 Signed-off-by: Stefan Brüns --- Changes in v2: - Fix/enhance commit message, no code changes drivers/gpu/drm/i915/intel_hdmi.c | 14 +++--- 1 file c

Re: [Intel-gfx] [PATCH v2] drm/i915: Try EDID bitbanging on HDMI after failed read

2018-01-03 Thread Stefan Brüns
On Wednesday, January 3, 2018 8:14:47 AM CET Jani Nikula wrote: > On Tue, 02 Jan 2018, Chris Wilson wrote: > > Quoting Rodrigo Vivi (2018-01-02 19:12:18) > > > >> On Sun, Dec 31, 2017 at 10:34:54PM +, Stefan Brüns wrote: > >> > +

[PATCH] drm/radeon: use RADEON_MAX_CRTCS, RADEON_MAX_AFMT_BLOCKS

2014-06-29 Thread Stefan Brüns
Signed-off-by: Stefan Br?ns --- drivers/gpu/drm/radeon/radeon_mode.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h index ad0e4b8..79b8c7e 100644 --- a/drivers/gpu/drm/radeon/radeon_mode.h +++ b

[PATCH] drm/radeon: Use only one line for whole DPCD debug output

2014-06-29 Thread Stefan Brüns
Signed-off-by: Stefan Br?ns --- drivers/gpu/drm/radeon/atombios_dp.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c index c5b1f2d..35f4182 100644 --- a/drivers/gpu/drm/radeon/atombios_d

[PATCH 1/2] drm/edid: move drm_edid_is_zero to top, make edid argument const

2014-11-23 Thread Stefan Brüns
drm_edid_is_zero will be used by drm_edid_block valid, move it up. raw_edid argument can be const. Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edi

[PATCH 2/2] drm/edid: shorten log output in case of all zeroes edid block V2

2014-11-23 Thread Stefan Brüns
There is no need to dump the whole EDID block in case it contains no information. Just print a single line stating the block is empty instead of 8 lines containing only zeroes. Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(

[PATCH 1/3] drm/edid: new drm_edid_block_checksum helper function V2

2014-11-23 Thread Stefan Brüns
The function will also be used by a later patch, so factor it out. V2: make raw_edid const, define/declare before first use Signed-off-by: Stefan Brüns Reviewed-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/

[PATCH 0/6] drm/edid: Enhance EDID validity checks

2014-11-30 Thread Stefan Brüns
This patch series enhances the handling of bad EDIDS: 1. The log output for empty EDIDs is shortened 2. Checking of CEA extension blocks is more strict. Previously, checksumming of CEA blocks was disabled, thus bad blocks could be forwarded to userspace. Updated to apply against current drm-next

[PATCH 1/6] drm/edid: move drm_edid_is_zero to top, make edid argument const

2014-11-30 Thread Stefan Brüns
drm_edid_is_zero will be used by drm_edid_block valid, move it up. raw_edid argument can be const. Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edi

[PATCH 2/6] drm/edid: shorten log output in case of all zeroes edid block

2014-11-30 Thread Stefan Brüns
There is no need to dump the whole EDID block in case it contains no information. Just print a single line stating the block is empty instead of 8 lines containing only zeroes. Signed-off-by: Stefan Brüns Reviewed-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 ++-- 1 file changed, 6 i

[PATCH 3/6] drm/edid: new drm_edid_block_checksum helper function V3

2014-11-30 Thread Stefan Brüns
The function will also be used by a later patch, so factor it out. V2: make raw_edid const, define/declare before first use V3: fix erroneuos removal of csum variable Signed-off-by: Stefan Brüns Reviewed-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 16 1 file changed, 12

[PATCH 4/6] drm/edid: calculate address of current extension block only once

2014-11-30 Thread Stefan Brüns
Signed-off-by: Stefan Brüns Reviewed-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1cbaf29..d68f56d 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu

[PATCH 5/6] drm/edid: add drm_edid_dump helper function

2014-11-30 Thread Stefan Brüns
This function will also be used by drm_edid_block_valid after the next patch in the series. Signed-off-by: Stefan Brüns --- drivers/gpu/drm/drm_edid.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_ed

[PATCH 6/6] drm/edid: Tighten checksum conditions for CEA blocks

2014-11-30 Thread Stefan Brüns
Checksumming was disabled for CEA blocks by commit 4a638b4e38234233f5c7e6705662fbc0b58d80c2 Author: Adam Jackson Date: Tue May 25 16:33:09 2010 -0400 drm/edid: Allow non-fatal checksum errors in CEA blocks If only the checksum is wrong, reading twice should result in identical data, where