nnector's state crtc
pointer (initialized to NULL) that is the main connector on/off control,
and should thus default to ON.
Fixes: 4a97a3da420b ("drm: Don't update property values for atomic drivers")
Cc: sta...@vger.kernel.org
Signed-off-by: Laurent Pinchart
Signed-off-by: St
Hi Laurent,
On 2017-11-09 11:45, Laurent Pinchart wrote:
> Hi Stefan,
>
> Thank you for the patch.
>
> On Thursday, 9 November 2017 11:14:36 EET Stefan Agner wrote:
>
> I notice you have changed the subject line. I'm not sure if the new wording
> is
> better
[ 930.992433] [ cut here ]
[ 930.992494] WARNING: CPU: 0 PID: 361 at
drivers/gpu/drm/drm_atomic_helper.c:1249
drm_atomic_helper_wait_for_vblanks.part.1+0x284/0x288
[ 930.992502] [CRTC:28:crtc-0] vblank wait timed out
Tested-by: Stefan Agner
Acked-by: Stefan Agner
Wil
On 2017-11-09 17:49, Noralf Trønnes wrote:
> Den 09.11.2017 15.34, skrev Stefan Agner:
>> On 2017-11-06 20:18, Noralf Trønnes wrote:
>>> Replace driver's code with the generic helpers that do the same thing.
>> Tested using:
>> echo devices > /sys/power/pm_
re_disable+0x8c/0x90
Remove clk_disable_unprepare call for pixel clock to avoid
unbalanced clock disable on suspend.
Fixes: 0a70c998d0c5 ("drm/fsl-dcu: enable pixel clock when enabling CRTC")
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 1 -
1 file
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 24f234902646..aeeaf0bcf646 100644
--- a/drivers/gpu/drm/fsl-dcu
pplies on top of the connector's state crtc
pointer (initialized to NULL) that is the main connector on/off control,
and should thus default to ON.
Fixes: 4a97a3da420b ("drm: Don't update property values for atomic drivers")
Cc: sta...@vger.kernel.org
Signed-off-by: Laure
On 2017-11-09 17:49, Noralf Trønnes wrote:
> Den 09.11.2017 15.34, skrev Stefan Agner:
>> On 2017-11-06 20:18, Noralf Trønnes wrote:
>>> Replace driver's code with the generic helpers that do the same thing.
>> Tested using:
>> echo devices > /sys/power/pm_
491] [<80792c48>] (kernel_init) from [<80107cb0>]
(ret_from_fork+0x14/0x24)
[1.483093] r5:80792c48 r4:
[1.486697] Code: e58460d8 e0823003 e58430d4 e59730ac (e5935008)
[1.492895] ---[ end trace 95d88c85f82f6379 ]---
[1.497604] Kernel pa
On 2017-11-10 19:06, Noralf Trønnes wrote:
> Den 10.11.2017 17.39, skrev Stefan Agner:
>> On 2017-11-09 17:49, Noralf Trønnes wrote:
>>> Den 09.11.2017 15.34, skrev Stefan Agner:
>>>> On 2017-11-06 20:18, Noralf Trønnes wrote:
>>>>> Replace driver
On 2017-11-06 20:18, Noralf Trønnes wrote:
> Replace driver's code with the generic helpers that do the same thing.
> Remove todo entry.
This patch looks good to me:
Reviewed-by: Stefan Agner
One question below though:
>
> Signed-off-by: Noralf Trønnes
> ---
> Doc
On 2017-11-14 16:40, Noralf Trønnes wrote:
> Den 14.11.2017 16.23, skrev Stefan Agner:
>> On 2017-11-10 19:06, Noralf Trønnes wrote:
>>> Den 10.11.2017 17.39, skrev Stefan Agner:
>>>> On 2017-11-09 17:49, Noralf Trønnes wrote:
>>>>> Den 09.11.2017 15.34
re_disable+0x8c/0x90
Remove clk_disable_unprepare call for pixel clock to avoid
unbalanced clock disable on suspend.
Fixes: 0a70c998d0c5 ("drm/fsl-dcu: enable pixel clock when enabling CRTC")
Signed-off-by: Stefan Agner
Acked-by: Noralf Trønnes
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm
Signed-off-by: Stefan Agner
Acked-by: Noralf Trønnes
---
Rebased onto drm-misc-next-fixes
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index
u to fetch changes up to 9fd99f4f3f5e13ce959900ae57d64b1bdb51d823:
drm/fsl-dcu: enable IRQ before drm_atomic_helper_resume() (2017-11-14
17:19:24 +0100)
Laurent Pinchart (1):
drm/fsl-dcu: Don't set connector DPMS propert
On 2017-11-20 11:18, Daniel Vetter wrote:
> On Sat, Nov 18, 2017 at 01:23:28AM +0100, Stefan Agner wrote:
>> Hi Daniel,
>
> What am I supposed to do with this pull request? drm-misc doesn't take
> pull requests, and I'm not the drm top-level tree maintainer ...
t set connector DPMS property
Stefan Agner (2):
drm/fsl-dcu: avoid disabling pixel clock twice on suspend
drm/fsl-dcu: enable IRQ before drm_atomic_helper_resume()
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 +--
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 5 -
2 files chang
Hi there,
Error handling seems to be broken when allocating a framebuffer fails
(see below). Observed on a Apalis TK1 (Tegra K1 with 2GB RAM, seems to
allocate 240 MB for vmalloc) using Linux 4.15.0-rc7 connected to a 4K
TV:
[5.632659] [drm:drm_setup_crtcs]
[5.636227] [drm:drm_helper_prob
On 2016-06-28 14:07, Rob Herring wrote:
> On Tue, Jun 28, 2016 at 05:39:07PM +0800, Meng Yi wrote:
>> dropped the old "fsl,panel" property, using the of_graph dt
>> binding syntax
>>
>> Signed-off-by: Meng Yi
>> ---
>> Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++--
>> 1 file
On 2016-06-28 19:58, Meng Yi wrote:
>> >> Optional properties:
>> >> - fsl,tcon: The phandle to the timing controller node.
>> >> @@ -24,6 +24,11 @@ dcu: dcu at 2ce {
>> >> clocks = <&platform_clk 0>, <&platform_clk 0>;
>> >> clock-names = "dcu", "pix";
>> >> big-endian;
>>
Hi Alexander,
On 2016-03-24 06:33, Alexander Stein wrote:
> Using REGCACHE_RBTREE for MMIO regmap is not valid as spinlock's will be
> used during cache allocation.
>
> This fixes the following bug:
> BUG: sleeping function called from invalid context at mm/slab.h:388
> in_atomic(): 1, irqs_disab
driver by removing suspend/resume
capabilities (encoder disable/enable makes sure that
TCON bypass gets disabled/reenabled on suspend)
- Use common clock framework to create a divider clock
which represents the DCU internal pixel clock divider
Stefan Agner (8):
ARM: imx: clk-vf610: fix DCU
parent clock of VF610_CLK_DCUx to be the bus
clock (ipg_bus).
Since the clock has not been used far, there are no further changes
needed.
Signed-off-by: Stefan Agner
---
drivers/clk/imx/clk-vf610.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk-vf610
Fix error handling during probe by reordering initialization and
adding a error path which disables clock again. Also disable the
clock on remove.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 44 +++
1 file changed, 21 insertions(+), 23
The Vybrid DCU variant has two independent clock inputs, one
for the registers (IPG bus clock) and one for the pixel clock.
Support this distinction in the DCU DRM driver while staying
backward compatible with devices providing only a single clock
(e.g. LS1021a SoC's).
Signed-off-by: Stefan
Add the ipg (bus) clock for the TCON modules (Timing Controller). This
module is required by the new DCU DRM driver, since the display signals
pass through TCON.
Signed-off-by: Stefan Agner
---
drivers/clk/imx/clk-vf610.c | 3 +++
include/dt-bindings/clock/vf610-clock.h | 4 +++-
2
it also allows to see
the actual pixel clock in the sysfs clock summary.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 7 ++-
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 26 ++
2 files changed, 24 insertions(+), 9 deletions(-)
diff
Add the dcu and tcon nodes to enable the Display Controller Unit
and Timing Controller in Vybrid's SoC level device-tree file.
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/vfxxx.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/vfxxx.d
Enable dcu node which is used by the DCU DRM driver. Assign the 5.7"
EDT panel with VGA resolution which Toradex sells often with the
evaluation board.
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 16 +++
arch/arm/boot/dts/vf-colibri.dtsi
iming signals for raw TFT panels
or operate in a bypass mode which leaves all signals unaltered.
The driver currently only supports the bypass mode.
Signed-off-by: Stefan Agner
---
.../devicetree/bindings/display/fsl,dcu.txt| 2 +
.../devicetree/bindings/display/fsl,tcon.txt
On 2016-03-28 23:45, Alexander Stein wrote:
> Hi,
>
> some comments below.
>
> On Monday 28 March 2016 19:00:00, Stefan Agner wrote:
>> Add driver for the TCON (timing controller) module. The TCON module
>> is a separate module attached after the DCU (display co
On 2016-03-29 00:26, Alexander Stein wrote:
> On Tuesday 29 March 2016 00:11:13, Stefan Agner wrote:
>> >> --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt
>> >> +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt
>> >>
>
On 2015-02-13 12:03, Jianwei Wang wrote:
> This patch add support for Two Dimensional Animation and Compositing
> Engine (2D-ACE) on the Freescale LS102x SoCs.
>
> 2D-ACE is a Freescale display controller. It supports at most four
> plane and provide an hardware cursor.
>
> This is a simplified v
Hi Jianwei,
Normally, for the second and higher iteration of a patchset, developers
add the version to the subject (e.g. PATCH v2). You can use the
--reroll-count option when creating the patches with git format-patch.
On 2015-03-13 10:44, Jianwei Wang wrote:
> This patch add support for Two Dime
Hi Jianwei,
The driver worked on a Vybrid VF610 device using the exported
framebuffer. However, when using X-Server through the DRM interface
directly (by using the modesetting driver) I get just a black screen so
far, still investigating the reason. What user-space interfaces did you
test?
When
Hi,
This avoids a NULL pointer dereference when no crtc is available (e.g.
the fsl,panel not assigned).
Any chance to get this into 4.4?
Tested-by: Stefan Agner
--
Stefan
On 2015-08-30 20:39, Jianwei Wang wrote:
> For state->fb may be NULL in fsl_dcu_drm_plane_atomic_check function,
&
clean those up.
Stefan Agner (7):
drm/fsl-dcu: specify volatile registers
drm/fsl-dcu: remove regmap return value checks
drm/fsl-dcu: avoid memory leak on errors
drm/fsl-dcu: handle initialization errors properly
drm/fsl-dcu: mask all interrupts on initialization
drm/fsl-dcu: fix alpha
Since we are using cached registers, we need to specify volatile
registers explicitly to avoid reading their value from the cache.
This allows to read the correct interrupt status in fsl_dcu_drm_irq
and clear the asserted bits only.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu
user. Hence remove most of
them.
The check in the interrupt handler is worth keeping since a
volatile register won't be readable in case register caching is
still enabled.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 124 +---
driver
Improve error handling during CRTC initialization. Especially avoid
memory leaks in the primary plane initialization error path.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 7 ++-
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 1 +
2 files changed, 7
If initialization fails (e.g. due to missing panel node or deferred
probe) make sure to roll-back all operations and return the error
code.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 24
1 file changed, 20 insertions(+), 4 deletions
enabled which we don't need.
Therefor, mask all interrupts on initialization.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
b/drivers/gpu/drm/fs
Fix alpha blending by enabling alpha blending for the whole frame if
a color mode with alpha channel is selected (DRM_FORMAT_ARGB*). Also
support color modes without alpha channel (DRM_FORMAT_XRGB*) by just
not enabling alpha blending on layer level.
Signed-off-by: Stefan Agner
---
drivers/gpu
values as defaults (e.g.
if no flags are specified):
- Display samples data on the rising edge
- VSYNC signal not inverted (active HIGH)
- HSYNC signal not inverted (active HIGH)
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 16 +---
drivers/gpu/d
change is an attempt to implement a proper driver.
Ideas have been taken from the sun4i Tcon driver:
https://lkml.org/lkml/2015/10/30/369
The patchset depends on my fsl-dcu fixes patchset:
https://lkml.org/lkml/2015/11/18/953
Stefan Agner (4):
ARM: dts: vf610: add display nodes
ARM: dts: vf610
Add the dcu and tcon nodes to enable the Display Controller Unit
and Timing Controller in Vybrid's SoC level device-tree file.
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/vfxxx.dtsi | 18 ++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/vfxxx.dtsi b
Enable dcu node which is used by the DCU DRM driver. Assign the 5.7"
EDT panel with VGA resolution which Toradex sells often with the
evaluation board.
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 16 +++
arch/arm/boot/dts/vf-colibri.dtsi
Add the ipg (bus) clock for the TCON modules (Timing Controller). This
module is required by the new DCU DRM driver, since the display signals
pass through TCON.
Signed-off-by: Stefan Agner
---
drivers/clk/imx/clk-vf610.c | 3 +++
include/dt-bindings/clock/vf610-clock.h | 4 +++-
2
iming signals for raw TFT panels
or operate in a bypass mode which leaves all signals unaltered.
The driver currently only supports the bypass mode.
Signed-off-by: Stefan Agner
---
.../devicetree/bindings/display/fsl,dcu.txt| 4 +
.../devicetree/bindings/display/fsl,tcon.txt
The comment has been copied from modetest and is not applicable
for vbltest.
Signed-off-by: Stefan Agner
---
tests/vbltest/vbltest.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c
index 531196c..5c61b43
From: Stefan Agner
Signed-off-by: Stefan Agner
---
tests/kmstest/main.c | 1 +
tests/modetest/modetest.c | 2 +-
tests/proptest/proptest.c | 2 +-
tests/vbltest/vbltest.c | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/kmstest/main.c b/tests/kmstest/main.c
On 2015-12-19 08:49, Emil Velikov wrote:
> Hi Stefan,
>
> On 18 December 2015 at 19:37, Stefan Agner wrote:
>> From: Stefan Agner
>>
>> Signed-off-by: Stefan Agner
>> ---
>> tests/kmstest/main.c | 1 +
>> tests/modetest/modetest.c | 2 +-
&
Use the new util_open() helper instead of open-coding the method for
finding a usable device. While at it, make the command-line interface
more consistent with that of modetest by adding the -D and -M options.
Signed-off-by: Stefan Agner
---
tests/kmstest/Makefile.am | 4 +++-
tests/kmstest
Signed-off-by: Stefan Agner
---
tests/util/kms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/util/kms.c b/tests/util/kms.c
index 57b0191..dcd5a8e 100644
--- a/tests/util/kms.c
+++ b/tests/util/kms.c
@@ -139,6 +139,7 @@ static const char * const modules[] = {
"im
_check function,
> if so, return -EINVAL. No need check in
> fsl_dcu_drm_plane_atomic_update anymore.
>
> Signed-off-by: Jianwei Wang
> Signed-off-by: Yi Meng
> Signed-off-by: Wang Dongsheng
> Tested-by: Stefan Agner
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
&g
On 2015-04-08 09:17, Jianwei.Wang at freescale.com wrote:
> Hi Stefan,
>
>> -Original Message-----
>> From: Stefan Agner [mailto:stefan at agner.ch]
>> Sent: Tuesday, April 07, 2015 8:12 PM
>> To: Wang Jianwei-B52261
>> Cc: Wood Scott-B0742
Hi Jianwei,
On 2015-04-07 08:44, Jianwei.Wang at freescale.com wrote:
> Hi Stefan,
>
> Thank you for your review and testing on Vybrid F610 device. This driver
> just implement the basic functions and it only support the exported
> framebuffer access. Some DRM interfaces are not implemented now
On 2025-04-17 17:11, Frank Li wrote:
> Convert fsl,tcon.txt to yaml format.
>
> Signed-off-by: Frank Li
Reviewed-by: Stefan Agner
> ---
> .../devicetree/bindings/display/fsl,tcon.txt | 17
> .../bindings/display/fsl,vf610-tcon.yaml | 43
On 2025-04-17 17:19, Frank Li wrote:
> Convert fsl,dcu.txt to yaml format.
>
> Additional changes:
> - remove label in example.
> - change node to display-controller in example.
> - use 32bit address in example.
>
> Signed-off-by: Frank Li
Reviewed-by: Stefan Agner
401 - 459 of 459 matches
Mail list logo
