-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
index ca0f7d83..36df2eb 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
+++ b
Use clk_prepare_enable and clk_disable_unprepare helpers. This also
fixes a sequence issue in the enable path which lead to a warning
on resume.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff
Use the drm_atomic_helper_suspend() and drm_atomic_helper_resume()
helpers to implement subsystem-level suspend/resume. This replaces
the (non-functional) regmap cache based suspend resume functionality.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 39
On 2016-02-22 13:33, Arnd Bergmann wrote:
> The fsl-dcu driver copies a drm_mode_config object to its
> stack but then only accesses a single member (dpms_property)
> once. The data structure is large enough to trigger a warning
> about the amount of kernel stack being used:
>
> drivers/gpu/drm/fs
Add optional cleanup function on master level. This allows the
master to call framework level cleanup functions in case binding
of any component failed before the previously successfully bound
components get unbound.
Signed-off-by: Stefan Agner
---
Hi,
This is an attempt to fix the issue
sure all framework level
cleanup is done by the time we unbind components.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/imx/imx-drm-core.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
b/drivers/gpu/drm/imx/imx-drm-core.c
[adding Lucas]
On 10.10.2018 12:38, Russell King - ARM Linux wrote:
> On Tue, Oct 09, 2018 at 11:30:49PM +0200, Stefan Agner wrote:
>> In situations where a component fails to bind, a previously
>> successfully bound component might already registered itself
>> with the D
y undo
what ->bind does.
Link:
https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg233327.html
Suggested-by: Russell King
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/imx/imx-drm-core.c | 4 ++--
drivers/gpu/drm/imx/imx-ldb.c | 6 ++
drivers/gpu/drm/imx/
On 16.10.2018 18:51, Lucas Stach wrote:
> Am Dienstag, den 16.10.2018, 18:09 +0200 schrieb Stefan Agner:
>> This reverts commit 8e3b16e2117409625b89807de3912ff773aea354.
>>
>> Using the component framework requires all components to undo in
>> ->unbind what -
On 16.10.2018 18:09, Stefan Agner wrote:
> This reverts commit 8e3b16e2117409625b89807de3912ff773aea354.
>
> Using the component framework requires all components to undo in
> ->unbind what ->bind does. Unfortunately that particular commit
> broke this rule. In particular,
On 17.10.2018 13:25, Stefan Agner wrote:
> On 16.10.2018 18:09, Stefan Agner wrote:
>> This reverts commit 8e3b16e2117409625b89807de3912ff773aea354.
>>
>> Using the component framework requires all components to undo in
>> ->unbind what ->bind does. Unfortunatel
Error: Driver 'mxsfb' is already registered, aborting...
Avoid driver name conflict with MXS fbdev driver by renaming the
more recently added DRM driver.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On 13.06.2018 01:08, Marek Vasut wrote:
> On 06/12/2018 06:01 PM, Fabio Estevam wrote:
>> On Tue, Jun 12, 2018 at 11:35 AM, Stefan Agner wrote:
>>
>>> There are two drivers for the LCDIF/MXSFB peripheral. If the DRM
>>> and fbdev are compiled in, the registrati
[adding Sascha and Bartlomiej]
On 13.06.2018 09:17, Marek Vasut wrote:
> On 06/13/2018 09:16 AM, Stefan Agner wrote:
>> On 13.06.2018 01:08, Marek Vasut wrote:
>>> On 06/12/2018 06:01 PM, Fabio Estevam wrote:
>>>> On Tue, Jun 12, 2018 at 11:35 AM, Stefan Agner w
On 03.05.2018 10:44, Satendra Singh Thakur wrote:
> To avoid duplicate logic for the same
How about:
Use drm_display_mode_to_videomode to avoid duplicate logic.
>
> Signed-off-by: Satendra Singh Thakur
> Cc: Madhur Verma
> Cc: Hemanshu Srivastava
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm
RS
> @@ -4661,7 +4661,7 @@ F:
> Documentation/devicetree/bindings/display/exynos/
>
> DRM DRIVERS FOR FREESCALE DCU
> M: Stefan Agner
> -M: Alison Wang
> +M: Alison Wang
> L: dri-devel@lists.freedesktop.org
> S: Supported
> F: drivers/gpu/drm/fs
The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)
are available in the Git repository at:
http://git.agner.ch/git/linux-drm-fsl-dcu.git tags/drm-fsl-dcu-fixes-for-v4.18
for you to fetch changes up to 63e482f172f4680a4ff00
s/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++--
> drivers/gpu/drm/etnaviv/etnaviv_drv.c| 4 ++--
> drivers/gpu/drm/mxsfb/mxsfb_drv.c| 4 ++--
For mxsfb:
Acked-by: Stefan Agner
--
Stefan
> drivers/gpu/drm/rcar-du/rcar_du_drv.c| 2 +-
> drivers/gpu/drm
The Apalis iMX6 modules use a simple DAC using resistor ladders
to convert parallel RGB to VGA. Add support for this output using
the dump VGA driver.
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/imx6q-apalis-eval.dts | 28 +
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 52
Support boards with a passive RGB to VGA bridge which require a low
active data-enable polarity.
Signed-off-by: Stefan Agner
---
Alternatively a new dt binding could be introduced for dumb VGA bridges
requiring low active data enable... However, also other polarities might
need a specific
Allow to specify the data-enable polarity required by a dumb VGA
DAC converting parallel RGB to VGA.
Signed-off-by: Stefan Agner
---
.../devicetree/bindings/display/bridge/dumb-vga-dac.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display
A bridge might require specific settings for the pixel data on
the bus. Copy the bus flags from the bridge timings if a bridge
is in use.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/imx/parallel-display.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/imx
-off-by: Stefan Agner
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 +++---
include/drm/drm_bridge.h | 11 +--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c
b/drivers/gpu/drm/bridge/dumb-vga-dac.c
index 9b706789a341
-bus = <&i2cddc>;
};
&hdmi {
/delete-property/ pinctrl-0;
};
&i2cddc {
status = "okay";
};
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts
-off-by: Stefan Agner
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 +++---
include/drm/drm_bridge.h | 11 +--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c
b/drivers/gpu/drm/bridge/dumb-vga-dac.c
index 9b706789a341
Use libutil to lookup connector type names and state. This also
makes sure that the latest connector type addition "DPI" gets
printed correctly.
Signed-off-by: Stefan Agner
---
tests/modeprint/Makefile.am | 1 +
tests/modeprint/meson.build | 2 +-
tests/modeprint/modepr
Support boards with a passive RGB to VGA bridge which require a low
active data-enable polarity.
Signed-off-by: Stefan Agner
---
Alternatively a new dt binding could be introduced for dumb VGA bridges
requiring low active data enable... However, also other polarities might
need a specific
Allow to specify the data-enable polarity required by a dumb VGA
DAC converting parallel RGB to VGA.
Signed-off-by: Stefan Agner
---
.../devicetree/bindings/display/bridge/dumb-vga-dac.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display
Print encoder types similar to connector types.
Signed-off-by: Stefan Agner
---
tests/modeprint/modeprint.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/modeprint/modeprint.c b/tests/modeprint/modeprint.c
index 1d62270f..ad727e12 100644
--- a/tests/modeprint
On 05.09.2018 11:00, Stefan Agner wrote:
> The DRM bus flags convey additional information on pixel data on
> the bus. All current available bus flags might be of interest for
> a bridge. Remove the sampling_edge field and use bus_flags.
>
> In the case at hand a dumb VGA bridge n
On 05.09.2018 00:07, Laurent Pinchart wrote:
> Hi Stefan,
>
> Thank you for the patch.
>
> On Wednesday, 5 September 2018 08:21:10 EEST Stefan Agner wrote:
>> Allow to specify the data-enable polarity required by a dumb VGA
>> DAC converting parallel RGB to VGA.
>&g
On 05.09.2018 00:44, Laurent Pinchart wrote:
> Hi Stefan,
>
> On Wednesday, 5 September 2018 10:06:28 EEST Laurent Pinchart wrote:
>> On Wednesday, 5 September 2018 08:21:08 EEST Stefan Agner wrote:
>> > The DRM bus flags convey additional information on pixel data on
&
On 06.09.2018 05:25, Laurent Pinchart wrote:
> Hi Linus,
>
> On Thursday, 6 September 2018 14:07:41 EEST Linus Walleij wrote:
>> On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote:
>> > On 05.09.2018 00:44, Laurent Pinchart wrote:
>> >
>> > Good point! I
On 06.09.2018 09:54, Laurent Pinchart wrote:
> Hi Stefan,
>
> On Thursday, 6 September 2018 19:48:51 EEST Stefan Agner wrote:
>> On 06.09.2018 05:25, Laurent Pinchart wrote:
>> > On Thursday, 6 September 2018 14:07:41 EEST Linus Walleij wrote:
>> >> On Wed,
On 06.09.2018 04:07, Linus Walleij wrote:
> On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote:
>> On 05.09.2018 00:44, Laurent Pinchart wrote:
>
>> Good point! I actually really don't like that we use the same flags here
>> but from a different perspective. Espec
On 26.07.2018 06:36, Stefan Agner wrote:
> If the GPIO subsystem is not ready make sure to return -EPROBE_DEFER
> instead of silently continuing without HPD.
>
> Reported-by: Marcel Ziswiler
> Signed-off-by: Stefan Agner
I think this did not get merged yet, any chance to get it
Boris, Maxime,
On 07.08.2017 08:26, Stefan Agner wrote:
> The statement always evaluates to true since the struct fields
> are arrays. This has shown up as a warning when compiling with
> clang:
> warning: address of array 'desc->layout.xstride' will always
> e
the first plane instead.
Signed-off-by: Stefan Agner
---
Changes in v2:
- Check for first value instead of dropping if statement
(subject was: drm/atmel-hlcdc: remove unnecessary if statement)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
nerated.
Fixes: 10dd74eac4db ("drm/amdgpu/vg20:Restruct uvd.inst to support multiple
instances")
Cc: James Zhu
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uv
status' [-Wenum-conversion]
enum dc_status result = DDC_RESULT_UNKNOWN;
~~ ^~
1 warning generated.
Initialization of result is unnecessary anyway, just drop the
initialization.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/amd/display/
The limit_id_fallback array uses enum drm_ipp_size_id to index its
content. The content itself is of type enum drm_exynos_ipp_limit_type.
Cc: Marek Szyprowski
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 18.06.2018 09:43, Daniel Vetter wrote:
> On Sat, Jun 16, 2018 at 01:32:44AM +0200, Marek Vasut wrote:
>> On 06/16/2018 12:42 AM, Leonard Crestez wrote:
>> > On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote:
>> >> On 06/15/2018 10:58 PM, Leonard Crestez wrote:
>> >>> On Fri, 2018-06-15 at 16:
On 16.06.2018 01:32, Marek Vasut wrote:
> On 06/16/2018 12:42 AM, Leonard Crestez wrote:
>> On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote:
>>> On 06/15/2018 10:58 PM, Leonard Crestez wrote:
On Fri, 2018-06-15 at 16:47 -0300, Fabio Estevam wrote:
> On Fri, Jun 15, 2018 at 4:43 PM, Le
On 10.07.2018 11:11, Marek Vasut wrote:
> On 07/10/2018 11:06 AM, Stefan Agner wrote:
>> On 16.06.2018 01:32, Marek Vasut wrote:
>>> On 06/16/2018 12:42 AM, Leonard Crestez wrote:
>>>> On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote:
>>>>>
[adding Authors of the problematic device trees]
On 10.07.2018 11:11, Marek Vasut wrote:
> On 07/10/2018 11:06 AM, Stefan Agner wrote:
>> On 16.06.2018 01:32, Marek Vasut wrote:
>>> On 06/16/2018 12:42 AM, Leonard Crestez wrote:
>>>> On Fri, 2018-06-15 at 23:36 +020
On 12.07.2018 15:03, Leonard Crestez wrote:
> On Thu, 2018-07-12 at 11:21 +0200, Stefan Agner wrote:
>> On 10.07.2018 11:11, Marek Vasut wrote:
>> > On 07/10/2018 11:06 AM, Stefan Agner wrote:
>> > > This is one of the situation where states quo is ki
On 05.12.2018 11:42, Tomi Valkeinen wrote:
> Hi,
>
> On 05/12/18 10:49, Laurent Pinchart wrote:
>> From: Laurent Pinchart
>>
>> The DRM_BUS_FLAG_PIXDATA_(POS|NEG)EDGE and
>> DRM_BUS_FLAG_SYNC_(POS|NEG)EDGE flags are deprecated in favour of the
>> new DRM_BUS_FLAG_PIXDATA_(DRIVE|SAMPLE)_(POS|NEG)E
On 07.09.2018 00:10, Linus Walleij wrote:
> On Thu, Sep 6, 2018 at 10:25 PM Stefan Agner wrote:
>
>> Ok, I read a bit up on the history of bridge timing, especially:
>> https://www.spinics.net/lists/dri-devel/msg155618.html
>>
>> IMHO, this got overengineered. F
.
--
Stefan
Changes in v2:
- Rename bus_flags to simple_bus_flags
- Reword dt-bindings for de-active
- Add patch 2/3 which attempts to simplify bridge timings
Stefan Agner (8):
drm/bridge: use bus flags in bridge timings
drm/pl111: simplify bridge timing support
drm/bridge: simplify bridge timing
Simplify bridge timing support by only supporting pixel clock
polarity. This aligns pixel clock polarity handling for bridges
with displays.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/pl111/pl111_display.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff
seems not convincing that this
is currently really required for bridges either.
Remove setup/hold timings again to better align timing information
of displays and briges.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 17 +
include/drm/drm_bridge.h
). This is an
assumption we already make for displays. For all we know it is a
safe assumption for bridges too.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 +++---
include/drm/drm_bridge.h | 11 +--
2 files changed, 8 insertions(+), 9 deletions
Support boards with a passive RGB to VGA bridge which require a low
active data-enable polarity.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga
Allow to specify the data-enable polarity required by a dumb VGA
DAC converting parallel RGB to VGA.
Signed-off-by: Stefan Agner
---
.../devicetree/bindings/display/bridge/dumb-vga-dac.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display
A bridge might require specific settings for the pixel data on
the bus. Copy the bus flags from the bridge timings if a bridge
is in use.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/imx/parallel-display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/imx/parallel
The Apalis iMX6 modules use a simple DAC using resistor ladders
to convert parallel RGB to VGA. Add support for this output using
the dumb VGA driver.
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/imx6q-apalis-eval.dts | 28 +
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 52
-bus = <&i2cddc>;
};
&hdmi {
/delete-property/ pinctrl-0;
};
&i2cddc {
status = "okay";
};
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts
Hi,
While working on Apalis iMX6 with four displays, I encountered the
following crash:
...
[2.978166] imx-drm display-subsystem: trying to bring up master
[2.984368] imx-drm display-subsystem: Looking for component 0
[2.990236] imx-drm display-subsystem: master has incomplete compone
On 12.09.2018 15:26, Stefan Agner wrote:
> Hi,
>
> While working on Apalis iMX6 with four displays, I encountered the
> following crash:
>
> ...
> [2.978166] imx-drm display-subsystem: trying to bring up master
> [2.984368] imx-drm display-subsystem:
Hi Philipp,
On 13.09.2018 01:36, Philipp Zabel wrote:
> Hi Stefan,
>
> thank you for the report. I think what happens is the following:
Thanks for looking into it!
>
> On Wed, 2018-09-12 at 15:26 -0700, Stefan Agner wrote:
>> Hi,
>>
>> While working on
On 13.09.2018 01:38, Philipp Zabel wrote:
> On Wed, 2018-09-12 at 11:32 -0700, Stefan Agner wrote:
>> A bridge might require specific settings for the pixel data on
>> the bus.
>
> On which bus? The bridge has input and output.
>
>> Copy the bus flags from the bridg
On 17.09.2018 12:16, Sean Paul wrote:
> On Mon, Sep 17, 2018 at 04:42:10PM +0300, Leonard Crestez wrote:
>> Adding lcdif nodes to a power domain currently doesn't work, it results
>> in black/corrupted screens or hangs. While the driver does enable
>> runtime pm it does not deal correctly with the
On 14.09.2018 02:23, Laurent Pinchart wrote:
> Hi Stefan,
>
> Thankk you for the patch.
>
> On Wednesday, 12 September 2018 21:32:15 EEST Stefan Agner wrote:
>> The DRM bus flags conveys additional information on pixel data on
>> the bus. All currently available bus
On 14.09.2018 02:49, Laurent Pinchart wrote:
> Hi Stefan,
>
> On Thursday, 6 September 2018 23:25:56 EEST Stefan Agner wrote:
>> On 06.09.2018 04:07, Linus Walleij wrote:
>> > On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote:
>> >> On 05.09.2018 00:44, Laur
On 19.09.2018 13:39, Sean Paul wrote:
> From: Sean Paul
>
> Another "small driver" moving into drm-misc. Stefan has also offered to
> co-maintain it.
>
> Cc: Marek Vasut
> Cc: Stefan Agner
> Cc: David Airlie
> Cc: Gustavo Padovan
> Cc: Maarten Lankho
On 22.09.2018 14:15, Laurent Pinchart wrote:
> Hello,
>
> This patch series attemps at clarifying usage of the
> DRM_BUS_FLAG_PIXDATA_(POS|NEG)EDGE flags. It results from a discussion
> on the mailing list available at [1].
>
> The problem being discussed was confusion around how the
> DRM_BUS_FL
On 24.09.2018 13:48, Thierry Reding wrote:
> On Sat, Sep 22, 2018 at 03:15:04PM +0300, Laurent Pinchart wrote:
>> The DRM_BUS_FLAG_PIXDATA_(POS|NEG)EDGE flags are deprecated in favour of
>> the new DRM_BUS_FLAG_PIXDATA_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags. Replace
>> them through the code.
>>
>> Sign
On 24.09.2018 14:13, Thierry Reding wrote:
> On Mon, Sep 24, 2018 at 01:59:25PM +0200, Stefan Agner wrote:
>> On 24.09.2018 13:48, Thierry Reding wrote:
>> > On Sat, Sep 22, 2018 at 03:15:04PM +0300, Laurent Pinchart wrote:
>> >> The DRM_BUS_FLAG_PIXDATA_(POS|NE
On 19.09.2018 22:39, Sean Paul wrote:
> From: Sean Paul
>
> Another "small driver" moving into drm-misc. Stefan has also offered to
> co-maintain it.
>
> Cc: Marek Vasut
> Cc: Stefan Agner
> Cc: David Airlie
> Cc: Gustavo Padovan
> Cc: Maarten Lankh
The driver is mostly in maintenance mode. Using drm-misc is a
good fit and should make maintenance a bit easier.
Signed-off-by: Stefan Agner
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 02a39617ec82..6646a3d098a1 100644
--- a/MAINTAINERS
On 26.09.2018 15:39, Sean Paul wrote:
> On Wed, Sep 26, 2018 at 02:50:34PM +0200, Stefan Agner wrote:
>> The driver is mostly in maintenance mode.
>
> Is the status still Supported, then?
>
Yeah Supported as defined in MAINTAINERS is still accurate. Its just
that we do not ad
On 20.09.2018 18:39, Sean Paul wrote:
> On Thu, Sep 20, 2018 at 11:59 AM Leonard Crestez
> wrote:
>>
>> On Mon, 2018-09-17 at 16:37 -0700, Stefan Agner wrote:
>> > On 17.09.2018 12:16, Sean Paul wrote:
>> > > On Mon, Sep 17, 2018 at 04:42:10PM +0300, Leona
On 26.09.2018 13:43, Thomas Zimmermann wrote:
> This patch unifies the naming of DRM functions for reference counting
> of struct drm_device. The resulting code is more aligned with the rest
> of the Linux kernel interfaces.
Applied!
--
Stefan
>
> Signed-off-by: Thomas Zimmermann
> ---
> driv
_helper functions directly.
> Remove console.h inclusion which was forgotten when converting to the
> suspend/resume helpers.
Just realized this never made it upstream. I guess its still valid and
could be applied?
--
Stefan
>
> Cc: Stefan Agner
> Cc: Alison Wang
> Signed-off-b
The result of drm_crtc_index() is unused. Remove the call and
the unused variable.
Signed-off-by: Stefan Agner
---
This is a split version of a patch posted a while ago:
https://lore.kernel.org/patchwork/patch/903786/
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 3 +--
1 file changed, 1
From: Satendra Singh Thakur
Use the drm_display_mode_to_videomode function to calculate front/
back porches and sync length.
Cc: Madhur Verma
Cc: Hemanshu Srivastava
Signed-off-by: Satendra Singh Thakur
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 32
ed probing. Can we add something like this, similar to
tinydrm-core.c?
if (ret)
DRM_ERROR("Failed to initialize fbdev: %d\n", ret);
--
Stefan
>
> Cc: Stefan Agner
> Cc: Alison Wang
> Signed-off-by: Noralf Trønnes
> ---
> drivers/gpu/drm/fsl-d
On 27.09.2018 23:23, Noralf Trønnes wrote:
> Den 27.09.2018 23.08, skrev Stefan Agner:
>> On 08.09.2018 15:46, Noralf Trønnes wrote:
>>> The CMA helper is already using the drm_fb_helper_generic_probe part of
>>> the generic fbdev emulation. This patch makes full u
On 28.09.2018 16:57, Noralf Trønnes wrote:
> Den 28.09.2018 16.11, skrev Stefan Agner:
>> On 27.09.2018 23:23, Noralf Trønnes wrote:
>>> Den 27.09.2018 23.08, skrev Stefan Agner:
>>>> On 08.09.2018 15:46, Noralf Trønnes wrote:
>>>>> The CMA helper is
On 01.10.2018 09:57, Daniel Vetter wrote:
> On Wed, Sep 26, 2018 at 10:41:50PM +0200, Stefan Agner wrote:
>> From: Satendra Singh Thakur
>>
>> Use the drm_display_mode_to_videomode function to calculate front/
>> back porches and sync length.
>>
>> Cc: M
On 13.07.2018 11:12, Marek Vasut wrote:
> On 07/13/2018 11:06 AM, Anson Huang wrote:
> [...]
>>>
>>> On 07/13/2018 10:54 AM, Anson Huang wrote:
As display power domain is combined with lcdif node on some i.MX
platforms like i.MX6SL, when lcdif driver is enabled, the mxsfb_load
is cal
On 13.07.2018 12:36, Marek Vasut wrote:
> On 07/13/2018 12:33 PM, Stefan Agner wrote:
>> On 13.07.2018 11:12, Marek Vasut wrote:
>>> On 07/13/2018 11:06 AM, Anson Huang wrote:
>>> [...]
>>>>>
>>>>> On 07/13/2018 10:54 AM, Anson Huang wro
On 05.06.2018 19:11, Leonard Crestez wrote:
> Adding imx6sl/sx lcdif nodes in a power domain currently does work, it
> results in black/corrupted screens or hangs. While the driver does
> enable runtime pm it does not deal correctly with the block being
> unpowered.
>
> Fix by adding pm_runtime_ge
If the GPIO subsystem is not ready make sure to return -EPROBE_DEFER
instead of silently continuing without HPD.
Reported-by: Marcel Ziswiler
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/tegra/output.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
On 17.07.2018 12:48, Leonard Crestez wrote:
> Adding lcdif nodes to a power domain currently does work, it results in
> black/corrupted screens or hangs. While the driver does enable runtime
> pm it does not deal correctly with the block being unpowered.
>
> Ensure power is on when required by add
On 02.08.2018 12:17, Philipp Zabel wrote:
> On Tue, 2018-07-31 at 12:17 +, Leonard Crestez wrote:
>> On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote:
>> > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote:
>> > > Adding lcdif nodes to a power domain currently does work, it results
On 06.08.2018 21:31, Leonard Crestez wrote:
> LCDIF will repeatedly display data from CUR_BUF and set CUR_BUF to
> NEXT_BUF when done. Since we are only ever writing to NEXT_BUF the
> display will show an initial corrupt frame.
>
> Fix by writing the FB paddr to both CUR_BUF and NEXT_BUF when
> ac
mxsfb_pipe_enable/disable.
>
> Signed-off-by: Leonard Crestez
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
On 06.08.2018 21:31, Leonard Crestez wrote:
> Since power to the lcdif block can be lost on suspend implement
> PM_SLEEP_OPS using drm_mode_config_helper_suspend/resume to save/restore
> the current mode.
>
> Signed-off-by: Leonard Crestez
Reviewed-by: Stefan Agner
> ---
mmit_tail_rpm just exacerbates an
issue which we haven't seen before...
Since I think it is a general fix, I'd rather prefer have it in a
separate commit.
>
> Signed-off-by: Leonard Crestez
> Suggested-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 15
As a driver write it is not entirely obvious that a reference to
the event e mentioned in the doc can be obtained via
drm_crtc_vblank_get(). Clarify how to obtain the reference.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/drm_vblank.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On 08.08.2018 10:00, Leonard Crestez wrote:
> On Tue, 2018-08-07 at 21:01 +0200, Stefan Agner wrote:
>> On 06.08.2018 21:31, Leonard Crestez wrote:
>> > The lcdif block is only powered on when display is active so plane
>> > updates when not enabled are not valid. Writi
d NEXT_BUF when
> activating the CRTC.
>
> Signed-off-by: Leonard Crestez
> Tested-by: Philipp Zabel
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 45 +-
> 1 file changed, 32 insertions(+), 13 deletions(-)
>
> diff
rtc_disable for simmetry
>
> This shouldn't have any functional effect.
>
> Signed-off-by: Leonard Crestez
Thanks, looks good!
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletions(-
x27;u32' (aka 'unsigned int')
changes value from 33.5 to 33 [-Wliteral-conversion]
.vback_porch = { 6, 21, 33.5 },
~^~~~
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/panel/panel-simple.c | 4 ++--
1 file changed, 2 insertions(
Use tegra124_(primary|overlay)_formats for Tegra124.
Fixes: 511c7023cf23 ("drm/tegra: dc: Support more formats")
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/tegra/dc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu
t' to different
enumeration type 'enum dsi_cmd_dst_format' [-Wenum-conversion]
case MIPI_DSI_FMT_RGB666: return VID_DST_FORMAT_RGB666;
~~ ^~~~~
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/ms
lear out the entire dynamic state with memset().
Back when I introduced bus flags it was meant to be a static
information.
So for the general idea/drm_connector.h:
Reviewed-by: Stefan Agner
[...]
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 2 +-
For fsl-dcu:
Ack
On 2017-07-23 12:16, Noralf Trønnes wrote:
> This driver can use the drm_driver.dumb_destroy and
> drm_driver.dumb_map_offset defaults, so no need to set them.
>
> Cc: Stefan Agner
> Cc: Alison Wang
> Signed-off-by: Noralf Trønnes
Acked-by: Stefan Agner
--
Stefan
> -
The statement always evaluates to true since the struct fields
are arrays. This has shown up as a warning when compiling with
clang:
warning: address of array 'desc->layout.xstride' will always
evaluate to 'true' [-Wpointer-bool-conversion]
Signed-off-by: Stefan
301 - 400 of 459 matches
Mail list logo
